@atlaskit/jql-editor 6.4.1 → 6.4.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/jql-editor
 
+## 6.4.2
+
+### Patch Changes
+
+- [`4f13d0c596cb7`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/4f13d0c596cb7) -
+  Cleanup experiment gate `anip-1289-scroll-issues-in-jql-autocomplete`. The scroll fix (maxWidth
+  clamping on the autocomplete Popper panel) is now permanently enabled.
+
 ## 6.4.1
 
 ### Patch Changes

package/dist/cjs/plugins/autocomplete/components/autocomplete-dropdown/index.js

@@ -10,7 +10,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = _interopRequireWildcard(require("react"));
-var _featureGateJsClient = _interopRequireDefault(require("@atlaskit/feature-gate-js-client"));
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _popper = require("@atlaskit/popper");
 var _spinner = _interopRequireDefault(require("@atlaskit/spinner"));
@@ -107,7 +106,6 @@ var AutocompleteDropdown = function AutocompleteDropdown(_ref) {
     _useScopedId2 = (0, _slicedToArray2.default)(_useScopedId, 1),
     autocompleteId = _useScopedId2[0];
   var isPopperPositioningEnabled = (0, _platformFeatureFlags.fg)('jql_editor_autocomplete_use_popper');
-  var isScrollUIFixEnabled = _featureGateJsClient.default.getExperimentValue('anip-1289-scroll-issues-in-jql-autocomplete', 'isEnabled', false);
 
   // Create virtual reference element positioned at cursor location (for popper implementation)
   var virtualReferenceElement = (0, _react.useMemo)(function () {
@@ -338,14 +336,13 @@ var AutocompleteDropdown = function AutocompleteDropdown(_ref) {
     return /*#__PURE__*/_react.default.createElement(_styled.AutocompleteContainer, {
       "data-testid": "jql-editor-autocomplete",
       tabIndex: -1,
-      ref: ref
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Popper requires dynamic positioning via style prop
-      ,
-      style: isScrollUIFixEnabled ? _objectSpread(_objectSpread({}, style), {}, {
+      ref: ref,
+      style: _objectSpread(_objectSpread({}, style), {}, {
         // Popper's maxSize modifier can produce a maxWidth larger than our design cap on small
         // viewports; clamp it here so the panel never overflows off-screen.
+        // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- inline style needed to override Popper shouldFitViewport
         maxWidth: 'min(400px, calc(100vw - 16px))'
-      }) : style,
+      }),
       isOpen: isAutocompleteOpen,
       usePopper: true,
       onBlur: onEditorViewBlur,

package/dist/es2019/plugins/autocomplete/components/autocomplete-dropdown/index.js

@@ -1,6 +1,5 @@
 import _extends from "@babel/runtime/helpers/extends";
 import React, { useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';
-import FeatureGates from '@atlaskit/feature-gate-js-client';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { Popper } from '@atlaskit/popper';
 import Spinner from '@atlaskit/spinner';
@@ -76,7 +75,6 @@ const AutocompleteDropdown = ({
   const [areRichInlineNodesEnabled] = useRichInlineNodesEnabled();
   const [autocompleteId] = useScopedId(JQL_EDITOR_AUTOCOMPLETE_ID);
   const isPopperPositioningEnabled = fg('jql_editor_autocomplete_use_popper');
-  const isScrollUIFixEnabled = FeatureGates.getExperimentValue('anip-1289-scroll-issues-in-jql-autocomplete', 'isEnabled', false);
 
   // Create virtual reference element positioned at cursor location (for popper implementation)
   const virtualReferenceElement = useMemo(() => {
@@ -295,15 +293,15 @@ const AutocompleteDropdown = ({
   }) => /*#__PURE__*/React.createElement(AutocompleteContainer, {
     "data-testid": "jql-editor-autocomplete",
     tabIndex: -1,
-    ref: ref
-    // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Popper requires dynamic positioning via style prop
-    ,
-    style: isScrollUIFixEnabled ? {
+    ref: ref,
+    style: {
+      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop
       ...style,
       // Popper's maxSize modifier can produce a maxWidth larger than our design cap on small
       // viewports; clamp it here so the panel never overflows off-screen.
+      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- inline style needed to override Popper shouldFitViewport
       maxWidth: 'min(400px, calc(100vw - 16px))'
-    } : style,
+    },
     isOpen: isAutocompleteOpen,
     usePopper: true,
     onBlur: onEditorViewBlur,

package/dist/esm/plugins/autocomplete/components/autocomplete-dropdown/index.js

@@ -4,7 +4,6 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import React, { useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';
-import FeatureGates from '@atlaskit/feature-gate-js-client';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { Popper } from '@atlaskit/popper';
 import Spinner from '@atlaskit/spinner';
@@ -98,7 +97,6 @@ var AutocompleteDropdown = function AutocompleteDropdown(_ref) {
     _useScopedId2 = _slicedToArray(_useScopedId, 1),
     autocompleteId = _useScopedId2[0];
   var isPopperPositioningEnabled = fg('jql_editor_autocomplete_use_popper');
-  var isScrollUIFixEnabled = FeatureGates.getExperimentValue('anip-1289-scroll-issues-in-jql-autocomplete', 'isEnabled', false);
 
   // Create virtual reference element positioned at cursor location (for popper implementation)
   var virtualReferenceElement = useMemo(function () {
@@ -329,14 +327,13 @@ var AutocompleteDropdown = function AutocompleteDropdown(_ref) {
     return /*#__PURE__*/React.createElement(AutocompleteContainer, {
       "data-testid": "jql-editor-autocomplete",
       tabIndex: -1,
-      ref: ref
-      // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- Popper requires dynamic positioning via style prop
-      ,
-      style: isScrollUIFixEnabled ? _objectSpread(_objectSpread({}, style), {}, {
+      ref: ref,
+      style: _objectSpread(_objectSpread({}, style), {}, {
         // Popper's maxSize modifier can produce a maxWidth larger than our design cap on small
         // viewports; clamp it here so the panel never overflows off-screen.
+        // eslint-disable-next-line @atlaskit/ui-styling-standard/enforce-style-prop -- inline style needed to override Popper shouldFitViewport
         maxWidth: 'min(400px, calc(100vw - 16px))'
-      }) : style,
+      }),
       isOpen: isAutocompleteOpen,
       usePopper: true,
       onBlur: onEditorViewBlur,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/jql-editor",
-	"version": "6.4.1",
+	"version": "6.4.2",
 	"description": "This package allows consumers to render an advanced JQL editor component to enable autocomplete-assisted authoring and validation of JQL queries.",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -46,7 +46,7 @@
 		"@atlaskit/button": "^23.11.0",
 		"@atlaskit/css": "^0.19.0",
 		"@atlaskit/editor-prosemirror": "^7.3.0",
-		"@atlaskit/emoji": "^70.7.0",
+		"@atlaskit/emoji": "^70.8.0",
 		"@atlaskit/feature-gate-js-client": "^5.5.0",
 		"@atlaskit/form": "^15.5.0",
 		"@atlaskit/icon": "^34.5.0",