@atlaskit/jql-editor 6.2.2 → 6.2.3

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/jql-editor
 
+## 6.2.3
+
+### Patch Changes
+
+- [`ef04a3969cfd2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ef04a3969cfd2) -
+  Fixes a bug where it was not possible to focus the JQL Editor using the `tab` key when it was
+  contained by certain components, such as the Atlaskit Popup component.
+
 ## 6.2.2
 
 ### Patch Changes

package/dist/cjs/state/index.js

@@ -87,6 +87,9 @@ var initialState = exports.initialState = {
 var isLineNumbersVisible = function isLineNumbersVisible(editorState) {
   return editorState.doc.childCount > 1;
 };
+
+// Explicit type declaration for actions is required for IsoDec compliance
+
 var actions = exports.actions = {
   onEditorViewBlur: function onEditorViewBlur() {
     return function (_ref) {

package/dist/cjs/ui/jql-editor-view/index.js

@@ -10,6 +10,7 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = _interopRequireWildcard(require("react"));
 var _throttle = _interopRequireDefault(require("lodash/throttle"));
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _constants = require("../../common/constants");
 var _useEditorTheme = require("../../hooks/use-editor-theme");
 var _useEditorViewIsInvalid = require("../../hooks/use-editor-view-is-invalid");
@@ -109,7 +110,7 @@ var JQLEditorView = function JQLEditorView(_ref) {
 
   // Compute HTML attributes to be applied to the Prosemirror editor view
   var getAttributes = (0, _react.useCallback)(function () {
-    return _objectSpread(_objectSpread({
+    return _objectSpread(_objectSpread(_objectSpread({
       id: editorId,
       'data-vc': _constants.JQL_EDITOR_INPUT_ID,
       'data-testid': 'jql-editor-input',
@@ -128,6 +129,8 @@ var JQLEditorView = function JQLEditorView(_ref) {
       'aria-activedescendant': selectedOptionId
     }), editorViewIsInvalid && {
       'aria-invalid': 'true'
+    }), (0, _platformFeatureFlags.fg)('empanda_jql-editor_fix_tab_select_in_popup') && {
+      tabindex: '0'
     });
   }, [editorId, isAutocompleteOpen, intl, autocompleteId, editorViewIsInvalid, validationId, helpContentId, selectedOptionId]);
 

package/dist/es2019/state/index.js

@@ -74,6 +74,9 @@ export const initialState = {
  * Line numbers should be shown if there are more than 1 paragraph blocks in the document.
  */
 const isLineNumbersVisible = editorState => editorState.doc.childCount > 1;
+
+// Explicit type declaration for actions is required for IsoDec compliance
+
 export const actions = {
   onEditorViewBlur: () => ({
     setState,

package/dist/es2019/ui/jql-editor-view/index.js

@@ -1,5 +1,6 @@
 import React, { useCallback, useEffect, useImperativeHandle, useMemo, useRef } from 'react';
 import throttle from 'lodash/throttle';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { JQL_EDITOR_AUTOCOMPLETE_ID, JQL_EDITOR_HELP_CONTENT_ID, JQL_EDITOR_INPUT_ID, JQL_EDITOR_MAIN_ID, JQL_EDITOR_VALIDATION_ID } from '../../common/constants';
 import { useEditorThemeContext } from '../../hooks/use-editor-theme';
 import { useEditorViewIsInvalid } from '../../hooks/use-editor-view-is-invalid';
@@ -97,6 +98,9 @@ const JQLEditorView = ({
       }),
       ...(editorViewIsInvalid && {
         'aria-invalid': 'true'
+      }),
+      ...(fg('empanda_jql-editor_fix_tab_select_in_popup') && {
+        tabindex: '0'
       })
     };
   }, [editorId, isAutocompleteOpen, intl, autocompleteId, editorViewIsInvalid, validationId, helpContentId, selectedOptionId]);

package/dist/esm/state/index.js

@@ -81,6 +81,9 @@ export var initialState = {
 var isLineNumbersVisible = function isLineNumbersVisible(editorState) {
   return editorState.doc.childCount > 1;
 };
+
+// Explicit type declaration for actions is required for IsoDec compliance
+
 export var actions = {
   onEditorViewBlur: function onEditorViewBlur() {
     return function (_ref) {

package/dist/esm/ui/jql-editor-view/index.js

@@ -4,6 +4,7 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import React, { useCallback, useEffect, useImperativeHandle, useMemo, useRef } from 'react';
 import throttle from 'lodash/throttle';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { JQL_EDITOR_AUTOCOMPLETE_ID, JQL_EDITOR_HELP_CONTENT_ID, JQL_EDITOR_INPUT_ID, JQL_EDITOR_MAIN_ID, JQL_EDITOR_VALIDATION_ID } from '../../common/constants';
 import { useEditorThemeContext } from '../../hooks/use-editor-theme';
 import { useEditorViewIsInvalid } from '../../hooks/use-editor-view-is-invalid';
@@ -102,7 +103,7 @@ var JQLEditorView = function JQLEditorView(_ref) {
 
   // Compute HTML attributes to be applied to the Prosemirror editor view
   var getAttributes = useCallback(function () {
-    return _objectSpread(_objectSpread({
+    return _objectSpread(_objectSpread(_objectSpread({
       id: editorId,
       'data-vc': JQL_EDITOR_INPUT_ID,
       'data-testid': 'jql-editor-input',
@@ -121,6 +122,8 @@ var JQLEditorView = function JQLEditorView(_ref) {
       'aria-activedescendant': selectedOptionId
     }), editorViewIsInvalid && {
       'aria-invalid': 'true'
+    }), fg('empanda_jql-editor_fix_tab_select_in_popup') && {
+      tabindex: '0'
     });
   }, [editorId, isAutocompleteOpen, intl, autocompleteId, editorViewIsInvalid, validationId, helpContentId, selectedOptionId]);