@atlaskit/jql-editor 5.8.3 → 5.8.4

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @atlaskit/jql-editor
 
+## 5.8.4
+
+### Patch Changes
+
+- [`d87f35a08c765`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/d87f35a08c765) -
+  Add undefined checks for autocomplete dropdown keyboard navigation.
+
 ## 5.8.3
 
 ### Patch Changes

package/dist/cjs/analytics/util.js

@@ -6,5 +6,5 @@ Object.defineProperty(exports, "__esModule", {
 exports.useJqlEditorAnalytics = void 0;
 var _jqlEditorCommon = require("@atlaskit/jql-editor-common");
 var useJqlEditorAnalytics = exports.useJqlEditorAnalytics = function useJqlEditorAnalytics(analyticsSource) {
-  return (0, _jqlEditorCommon.useJqlPackageAnalytics)(analyticsSource, "@atlaskit/jql-editor", "5.8.2", _jqlEditorCommon.ANALYTICS_CHANNEL);
+  return (0, _jqlEditorCommon.useJqlPackageAnalytics)(analyticsSource, "@atlaskit/jql-editor", "5.8.3", _jqlEditorCommon.ANALYTICS_CHANNEL);
 };

package/dist/cjs/plugins/autocomplete/components/autocomplete-dropdown/index.js

@@ -22,13 +22,17 @@ var _styled = require("./styled");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var getPreviousOptionId = function getPreviousOptionId(options, selectedOptionId) {
   if (!selectedOptionId) {
-    return options[options.length - 1].id;
+    var _options;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options = options[options.length - 1]) === null || _options === void 0 ? void 0 : _options.id;
   }
   var index = options.findIndex(function (option) {
     return option.id === selectedOptionId;
   });
   if (index === -1) {
-    return options[options.length - 1].id;
+    var _options2;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options2 = options[options.length - 1]) === null || _options2 === void 0 ? void 0 : _options2.id;
   }
   if (index > 0) {
     return options[index - 1].id;
@@ -37,13 +41,17 @@ var getPreviousOptionId = function getPreviousOptionId(options, selectedOptionId
 };
 var getNextOptionId = function getNextOptionId(options, selectedOptionId) {
   if (!selectedOptionId) {
-    return options[0].id;
+    var _options$;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options$ = options[0]) === null || _options$ === void 0 ? void 0 : _options$.id;
   }
   var index = options.findIndex(function (option) {
     return option.id === selectedOptionId;
   });
   if (index === -1) {
-    return options[0].id;
+    var _options$2;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options$2 = options[0]) === null || _options$2 === void 0 ? void 0 : _options$2.id;
   }
   if (index < options.length - 1) {
     return options[index + 1].id;
@@ -193,21 +201,21 @@ var AutocompleteDropdown = function AutocompleteDropdown(_ref) {
       return true;
     });
     keymap.bindMultipleKeys([_constants2.HOME_KEY, _constants2.CMD_ARROW_UP_KEY], function () {
-      var _options$;
+      var _options$3;
       if (!isAutocompleteOpen) {
         return false;
       }
       !navigatingWithKeyboard && setNavigatingWithKeyboard(true);
-      setSelectedAutocompleteOptionId((_options$ = options[0]) === null || _options$ === void 0 ? void 0 : _options$.id);
+      setSelectedAutocompleteOptionId((_options$3 = options[0]) === null || _options$3 === void 0 ? void 0 : _options$3.id);
       return true;
     });
     keymap.bindMultipleKeys([_constants2.END_KEY, _constants2.CMD_ARROW_DOWN_KEY], function () {
-      var _options;
+      var _options3;
       if (!isAutocompleteOpen) {
         return false;
       }
       !navigatingWithKeyboard && setNavigatingWithKeyboard(true);
-      setSelectedAutocompleteOptionId((_options = options[options.length - 1]) === null || _options === void 0 ? void 0 : _options.id);
+      setSelectedAutocompleteOptionId((_options3 = options[options.length - 1]) === null || _options3 === void 0 ? void 0 : _options3.id);
       return true;
     });
 

package/dist/es2019/analytics/util.js

@@ -1,4 +1,4 @@
 import { ANALYTICS_CHANNEL, useJqlPackageAnalytics } from '@atlaskit/jql-editor-common';
 export const useJqlEditorAnalytics = analyticsSource => {
-  return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "5.8.2", ANALYTICS_CHANNEL);
+  return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "5.8.3", ANALYTICS_CHANNEL);
 };

package/dist/es2019/plugins/autocomplete/components/autocomplete-dropdown/index.js

@@ -12,11 +12,15 @@ import AutocompleteOption from '../autocomplete-option';
 import { AutocompleteContainer, AutocompleteLoadingFooter, AutocompleteOptionsContainer, OptionList } from './styled';
 const getPreviousOptionId = (options, selectedOptionId) => {
   if (!selectedOptionId) {
-    return options[options.length - 1].id;
+    var _options;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options = options[options.length - 1]) === null || _options === void 0 ? void 0 : _options.id;
   }
   const index = options.findIndex(option => option.id === selectedOptionId);
   if (index === -1) {
-    return options[options.length - 1].id;
+    var _options2;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options2 = options[options.length - 1]) === null || _options2 === void 0 ? void 0 : _options2.id;
   }
   if (index > 0) {
     return options[index - 1].id;
@@ -25,11 +29,15 @@ const getPreviousOptionId = (options, selectedOptionId) => {
 };
 const getNextOptionId = (options, selectedOptionId) => {
   if (!selectedOptionId) {
-    return options[0].id;
+    var _options$;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options$ = options[0]) === null || _options$ === void 0 ? void 0 : _options$.id;
   }
   const index = options.findIndex(option => option.id === selectedOptionId);
   if (index === -1) {
-    return options[0].id;
+    var _options$2;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options$2 = options[0]) === null || _options$2 === void 0 ? void 0 : _options$2.id;
   }
   if (index < options.length - 1) {
     return options[index + 1].id;
@@ -161,21 +169,21 @@ const AutocompleteDropdown = ({
       return true;
     });
     keymap.bindMultipleKeys([HOME_KEY, CMD_ARROW_UP_KEY], () => {
-      var _options$;
+      var _options$3;
       if (!isAutocompleteOpen) {
         return false;
       }
       !navigatingWithKeyboard && setNavigatingWithKeyboard(true);
-      setSelectedAutocompleteOptionId((_options$ = options[0]) === null || _options$ === void 0 ? void 0 : _options$.id);
+      setSelectedAutocompleteOptionId((_options$3 = options[0]) === null || _options$3 === void 0 ? void 0 : _options$3.id);
       return true;
     });
     keymap.bindMultipleKeys([END_KEY, CMD_ARROW_DOWN_KEY], () => {
-      var _options;
+      var _options3;
       if (!isAutocompleteOpen) {
         return false;
       }
       !navigatingWithKeyboard && setNavigatingWithKeyboard(true);
-      setSelectedAutocompleteOptionId((_options = options[options.length - 1]) === null || _options === void 0 ? void 0 : _options.id);
+      setSelectedAutocompleteOptionId((_options3 = options[options.length - 1]) === null || _options3 === void 0 ? void 0 : _options3.id);
       return true;
     });
 

package/dist/esm/analytics/util.js

@@ -1,4 +1,4 @@
 import { ANALYTICS_CHANNEL, useJqlPackageAnalytics } from '@atlaskit/jql-editor-common';
 export var useJqlEditorAnalytics = function useJqlEditorAnalytics(analyticsSource) {
-  return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "5.8.2", ANALYTICS_CHANNEL);
+  return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "5.8.3", ANALYTICS_CHANNEL);
 };

package/dist/esm/plugins/autocomplete/components/autocomplete-dropdown/index.js

@@ -13,13 +13,17 @@ import AutocompleteOption from '../autocomplete-option';
 import { AutocompleteContainer, AutocompleteLoadingFooter, AutocompleteOptionsContainer, OptionList } from './styled';
 var getPreviousOptionId = function getPreviousOptionId(options, selectedOptionId) {
   if (!selectedOptionId) {
-    return options[options.length - 1].id;
+    var _options;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options = options[options.length - 1]) === null || _options === void 0 ? void 0 : _options.id;
   }
   var index = options.findIndex(function (option) {
     return option.id === selectedOptionId;
   });
   if (index === -1) {
-    return options[options.length - 1].id;
+    var _options2;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options2 = options[options.length - 1]) === null || _options2 === void 0 ? void 0 : _options2.id;
   }
   if (index > 0) {
     return options[index - 1].id;
@@ -28,13 +32,17 @@ var getPreviousOptionId = function getPreviousOptionId(options, selectedOptionId
 };
 var getNextOptionId = function getNextOptionId(options, selectedOptionId) {
   if (!selectedOptionId) {
-    return options[0].id;
+    var _options$;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options$ = options[0]) === null || _options$ === void 0 ? void 0 : _options$.id;
   }
   var index = options.findIndex(function (option) {
     return option.id === selectedOptionId;
   });
   if (index === -1) {
-    return options[0].id;
+    var _options$2;
+    // Options can be empty if the user presses arrow keys while results are loading
+    return (_options$2 = options[0]) === null || _options$2 === void 0 ? void 0 : _options$2.id;
   }
   if (index < options.length - 1) {
     return options[index + 1].id;
@@ -184,21 +192,21 @@ var AutocompleteDropdown = function AutocompleteDropdown(_ref) {
       return true;
     });
     keymap.bindMultipleKeys([HOME_KEY, CMD_ARROW_UP_KEY], function () {
-      var _options$;
+      var _options$3;
       if (!isAutocompleteOpen) {
         return false;
       }
       !navigatingWithKeyboard && setNavigatingWithKeyboard(true);
-      setSelectedAutocompleteOptionId((_options$ = options[0]) === null || _options$ === void 0 ? void 0 : _options$.id);
+      setSelectedAutocompleteOptionId((_options$3 = options[0]) === null || _options$3 === void 0 ? void 0 : _options$3.id);
       return true;
     });
     keymap.bindMultipleKeys([END_KEY, CMD_ARROW_DOWN_KEY], function () {
-      var _options;
+      var _options3;
       if (!isAutocompleteOpen) {
         return false;
       }
       !navigatingWithKeyboard && setNavigatingWithKeyboard(true);
-      setSelectedAutocompleteOptionId((_options = options[options.length - 1]) === null || _options === void 0 ? void 0 : _options.id);
+      setSelectedAutocompleteOptionId((_options3 = options[options.length - 1]) === null || _options3 === void 0 ? void 0 : _options3.id);
       return true;
     });
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/jql-editor",
-	"version": "5.8.3",
+	"version": "5.8.4",
 	"description": "This package allows consumers to render an advanced JQL editor component to enable autocomplete-assisted authoring and validation of JQL queries.",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",