@atlaskit/jql-editor 5.2.2 → 5.3.1

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/jql-editor
 
+## 5.3.1
+
+### Patch Changes
+
+- [#159778](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/159778)
+  [`24eb0515f7011`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/24eb0515f7011) -
+  Clean up old code path for accessibility fix in error messages section
+
+## 5.3.0
+
+### Minor Changes
+
+- [#157088](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/157088)
+  [`0d5045c49d85a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/0d5045c49d85a) -
+  We are testing the migration to the ADS Link component behind a feature flag. If this fix is
+  successful it will be available in a later release.
+
 ## 5.2.2
 
 ### Patch Changes

package/dist/cjs/analytics/util.js

@@ -6,5 +6,5 @@ Object.defineProperty(exports, "__esModule", {
 exports.useJqlEditorAnalytics = void 0;
 var _jqlEditorCommon = require("@atlaskit/jql-editor-common");
 var useJqlEditorAnalytics = exports.useJqlEditorAnalytics = function useJqlEditorAnalytics(analyticsSource) {
-  return (0, _jqlEditorCommon.useJqlPackageAnalytics)(analyticsSource, "@atlaskit/jql-editor", "5.2.2", _jqlEditorCommon.ANALYTICS_CHANNEL);
+  return (0, _jqlEditorCommon.useJqlPackageAnalytics)(analyticsSource, "@atlaskit/jql-editor", "5.3.1", _jqlEditorCommon.ANALYTICS_CHANNEL);
 };

package/dist/cjs/ui/jql-editor-footer-content/jql-messages/errors/index.js

@@ -13,7 +13,6 @@ var _react = _interopRequireWildcard(require("react"));
 var _reactMagneticDi = require("react-magnetic-di");
 var _form = require("@atlaskit/form");
 var _jqlAst = require("@atlaskit/jql-ast");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _constants = require("../../../../common/constants");
 var _messages = require("../../../../common/messages");
 var _useEditorTheme = require("../../../../hooks/use-editor-theme");
@@ -108,16 +107,11 @@ var ErrorMessages = exports.ErrorMessages = function ErrorMessages() {
     CustomErrorComponent = _useCustomErrorCompon2[0];
   var childrenToRender = errorMessages != null ? /*#__PURE__*/_react.default.createElement(_format.MessageContainer, null, /*#__PURE__*/_react.default.createElement(_form.ErrorMessage, {
     testId: _constants.JQL_EDITOR_VALIDATION_ID
-  }, (0, _platformFeatureFlags.fg)('jql_editor_a11y') ? /*#__PURE__*/_react.default.createElement("span", {
+  }, /*#__PURE__*/_react.default.createElement("span", {
     role: "alert",
     id: validationId
   }, /*#__PURE__*/_react.default.createElement(_format.FormatMessages, {
     messages: errorMessages
-  })) : /*#__PURE__*/_react.default.createElement("span", {
-    role: "alert",
-    "aria-describedby": editorId
-  }, /*#__PURE__*/_react.default.createElement(_format.FormatMessages, {
-    messages: errorMessages
   })))) : null;
 
   // Only render CustomErrorComponent if there is an errorMessage

package/dist/cjs/ui/jql-editor-footer-content/jql-messages/warnings/index.js

@@ -13,6 +13,8 @@ var _reactMagneticDi = require("react-magnetic-di");
 var _form = require("@atlaskit/form");
 var _warning = _interopRequireDefault(require("@atlaskit/icon/glyph/warning"));
 var _warning2 = _interopRequireDefault(require("@atlaskit/icon/utility/warning"));
+var _link = _interopRequireDefault(require("@atlaskit/link"));
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _compiled = require("@atlaskit/primitives/compiled");
 var colors = _interopRequireWildcard(require("@atlaskit/theme/colors"));
 var _useEditorViewHasWarnings = require("../../../../hooks/use-editor-view-has-warnings");
@@ -70,7 +72,17 @@ var useFormattedWarningMessage = exports.useFormattedWarningMessage = function u
   } else if (epicLinkDeprecationTerm && parentLinkDeprecationTerm) {
     return formatWarnings(formatMessage(_messages.messages.deprecatedBothParentReplacementMessage, {
       link: function link(chunks) {
-        return /*#__PURE__*/_react.default.createElement("a", {
+        return (0, _platformFeatureFlags.fg)('dst-a11y__replace-anchor-with-link__jira-platform-') ? /*#__PURE__*/_react.default.createElement(_link.default, {
+          href: softDeprecateEpicParentDocsLink,
+          target: "_blank",
+          rel: "noopener noreferrer",
+          onClick: function onClick(e) {
+            return e.stopPropagation();
+          }
+        }, chunks) :
+        /*#__PURE__*/
+        // eslint-disable-next-line @atlaskit/design-system/no-html-anchor
+        _react.default.createElement("a", {
           href: softDeprecateEpicParentDocsLink,
           target: "_blank",
           rel: "noopener noreferrer",
@@ -86,7 +98,17 @@ var useFormattedWarningMessage = exports.useFormattedWarningMessage = function u
   } else if (epicLinkDeprecationTerm || parentLinkDeprecationTerm) {
     return formatWarnings(formatMessage(_messages.messages.deprecatedParentReplacementMessage, {
       link: function link(chunks) {
-        return /*#__PURE__*/_react.default.createElement("a", {
+        return (0, _platformFeatureFlags.fg)('dst-a11y__replace-anchor-with-link__jira-platform-') ? /*#__PURE__*/_react.default.createElement(_link.default, {
+          href: softDeprecateEpicParentDocsLink,
+          target: "_blank",
+          rel: "noopener noreferrer",
+          onClick: function onClick(e) {
+            return e.stopPropagation();
+          }
+        }, chunks) :
+        /*#__PURE__*/
+        // eslint-disable-next-line @atlaskit/design-system/no-html-anchor
+        _react.default.createElement("a", {
           href: softDeprecateEpicParentDocsLink,
           target: "_blank",
           rel: "noopener noreferrer",

package/dist/cjs/ui/jql-editor-view/index.js

@@ -10,7 +10,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = _interopRequireWildcard(require("react"));
 var _throttle = _interopRequireDefault(require("lodash/throttle"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _constants = require("../../common/constants");
 var _useEditorTheme = require("../../hooks/use-editor-theme");
 var _useEditorViewIsInvalid = require("../../hooks/use-editor-view-is-invalid");
@@ -124,7 +123,7 @@ var JQLEditorView = function JQLEditorView(_ref) {
       'aria-label': intl.formatMessage(_messages.messages.inputLabel),
       'aria-controls': autocompleteId,
       'aria-owns': autocompleteId,
-      'aria-describedby': (0, _platformFeatureFlags.fg)('jql_editor_a11y') ? editorViewIsInvalid ? validationId : helpContentId : helpContentId
+      'aria-describedby': editorViewIsInvalid ? validationId : helpContentId
     }, selectedOptionId && {
       'aria-activedescendant': selectedOptionId
     }), editorViewIsInvalid && {

package/dist/es2019/analytics/util.js

@@ -1,4 +1,4 @@
 import { ANALYTICS_CHANNEL, useJqlPackageAnalytics } from '@atlaskit/jql-editor-common';
 export const useJqlEditorAnalytics = analyticsSource => {
-  return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "5.2.2", ANALYTICS_CHANNEL);
+  return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "5.3.1", ANALYTICS_CHANNEL);
 };

package/dist/es2019/ui/jql-editor-footer-content/jql-messages/errors/index.js

@@ -3,7 +3,6 @@ import React, { useEffect } from 'react';
 import { di } from 'react-magnetic-di';
 import { ErrorMessage } from '@atlaskit/form';
 import { JQLSyntaxError } from '@atlaskit/jql-ast';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { JQL_EDITOR_INPUT_ID, JQL_EDITOR_VALIDATION_ID } from '../../../../common/constants';
 import { commonMessages } from '../../../../common/messages';
 import { useEditorThemeContext } from '../../../../hooks/use-editor-theme';
@@ -88,16 +87,11 @@ export const ErrorMessages = () => {
   const [CustomErrorComponent] = useCustomErrorComponent();
   const childrenToRender = errorMessages != null ? /*#__PURE__*/React.createElement(MessageContainer, null, /*#__PURE__*/React.createElement(ErrorMessage, {
     testId: JQL_EDITOR_VALIDATION_ID
-  }, fg('jql_editor_a11y') ? /*#__PURE__*/React.createElement("span", {
+  }, /*#__PURE__*/React.createElement("span", {
     role: "alert",
     id: validationId
   }, /*#__PURE__*/React.createElement(FormatMessages, {
     messages: errorMessages
-  })) : /*#__PURE__*/React.createElement("span", {
-    role: "alert",
-    "aria-describedby": editorId
-  }, /*#__PURE__*/React.createElement(FormatMessages, {
-    messages: errorMessages
   })))) : null;
 
   // Only render CustomErrorComponent if there is an errorMessage

package/dist/es2019/ui/jql-editor-footer-content/jql-messages/warnings/index.js

@@ -3,6 +3,8 @@ import { di } from 'react-magnetic-di';
 import { HelperMessage } from '@atlaskit/form';
 import LegacyWarningIcon from '@atlaskit/icon/glyph/warning';
 import WarningIcon from '@atlaskit/icon/utility/warning';
+import Link from '@atlaskit/link';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { Box } from '@atlaskit/primitives/compiled';
 import * as colors from '@atlaskit/theme/colors';
 import { useEditorViewHasWarnings } from '../../../../hooks/use-editor-view-has-warnings';
@@ -51,7 +53,15 @@ export const useFormattedWarningMessage = () => {
     }));
   } else if (epicLinkDeprecationTerm && parentLinkDeprecationTerm) {
     return formatWarnings(formatMessage(messages.deprecatedBothParentReplacementMessage, {
-      link: chunks => /*#__PURE__*/React.createElement("a", {
+      link: chunks => fg('dst-a11y__replace-anchor-with-link__jira-platform-') ? /*#__PURE__*/React.createElement(Link, {
+        href: softDeprecateEpicParentDocsLink,
+        target: "_blank",
+        rel: "noopener noreferrer",
+        onClick: e => e.stopPropagation()
+      }, chunks) :
+      /*#__PURE__*/
+      // eslint-disable-next-line @atlaskit/design-system/no-html-anchor
+      React.createElement("a", {
         href: softDeprecateEpicParentDocsLink,
         target: "_blank",
         rel: "noopener noreferrer",
@@ -63,7 +73,15 @@ export const useFormattedWarningMessage = () => {
     }));
   } else if (epicLinkDeprecationTerm || parentLinkDeprecationTerm) {
     return formatWarnings(formatMessage(messages.deprecatedParentReplacementMessage, {
-      link: chunks => /*#__PURE__*/React.createElement("a", {
+      link: chunks => fg('dst-a11y__replace-anchor-with-link__jira-platform-') ? /*#__PURE__*/React.createElement(Link, {
+        href: softDeprecateEpicParentDocsLink,
+        target: "_blank",
+        rel: "noopener noreferrer",
+        onClick: e => e.stopPropagation()
+      }, chunks) :
+      /*#__PURE__*/
+      // eslint-disable-next-line @atlaskit/design-system/no-html-anchor
+      React.createElement("a", {
         href: softDeprecateEpicParentDocsLink,
         target: "_blank",
         rel: "noopener noreferrer",

package/dist/es2019/ui/jql-editor-view/index.js

@@ -1,6 +1,5 @@
 import React, { useCallback, useEffect, useImperativeHandle, useMemo, useRef } from 'react';
 import throttle from 'lodash/throttle';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { JQL_EDITOR_AUTOCOMPLETE_ID, JQL_EDITOR_HELP_CONTENT_ID, JQL_EDITOR_INPUT_ID, JQL_EDITOR_MAIN_ID, JQL_EDITOR_VALIDATION_ID } from '../../common/constants';
 import { useEditorThemeContext } from '../../hooks/use-editor-theme';
 import { useEditorViewIsInvalid } from '../../hooks/use-editor-view-is-invalid';
@@ -91,7 +90,7 @@ const JQLEditorView = ({
       'aria-label': intl.formatMessage(messages.inputLabel),
       'aria-controls': autocompleteId,
       'aria-owns': autocompleteId,
-      'aria-describedby': fg('jql_editor_a11y') ? editorViewIsInvalid ? validationId : helpContentId : helpContentId,
+      'aria-describedby': editorViewIsInvalid ? validationId : helpContentId,
       ...(selectedOptionId && {
         'aria-activedescendant': selectedOptionId
       }),

package/dist/esm/analytics/util.js

@@ -1,4 +1,4 @@
 import { ANALYTICS_CHANNEL, useJqlPackageAnalytics } from '@atlaskit/jql-editor-common';
 export var useJqlEditorAnalytics = function useJqlEditorAnalytics(analyticsSource) {
-  return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "5.2.2", ANALYTICS_CHANNEL);
+  return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "5.3.1", ANALYTICS_CHANNEL);
 };

package/dist/esm/ui/jql-editor-footer-content/jql-messages/errors/index.js

@@ -6,7 +6,6 @@ import React, { useEffect } from 'react';
 import { di } from 'react-magnetic-di';
 import { ErrorMessage } from '@atlaskit/form';
 import { JQLSyntaxError } from '@atlaskit/jql-ast';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { JQL_EDITOR_INPUT_ID, JQL_EDITOR_VALIDATION_ID } from '../../../../common/constants';
 import { commonMessages } from '../../../../common/messages';
 import { useEditorThemeContext } from '../../../../hooks/use-editor-theme';
@@ -99,16 +98,11 @@ export var ErrorMessages = function ErrorMessages() {
     CustomErrorComponent = _useCustomErrorCompon2[0];
   var childrenToRender = errorMessages != null ? /*#__PURE__*/React.createElement(MessageContainer, null, /*#__PURE__*/React.createElement(ErrorMessage, {
     testId: JQL_EDITOR_VALIDATION_ID
-  }, fg('jql_editor_a11y') ? /*#__PURE__*/React.createElement("span", {
+  }, /*#__PURE__*/React.createElement("span", {
     role: "alert",
     id: validationId
   }, /*#__PURE__*/React.createElement(FormatMessages, {
     messages: errorMessages
-  })) : /*#__PURE__*/React.createElement("span", {
-    role: "alert",
-    "aria-describedby": editorId
-  }, /*#__PURE__*/React.createElement(FormatMessages, {
-    messages: errorMessages
   })))) : null;
 
   // Only render CustomErrorComponent if there is an errorMessage

package/dist/esm/ui/jql-editor-footer-content/jql-messages/warnings/index.js

@@ -5,6 +5,8 @@ import { di } from 'react-magnetic-di';
 import { HelperMessage } from '@atlaskit/form';
 import LegacyWarningIcon from '@atlaskit/icon/glyph/warning';
 import WarningIcon from '@atlaskit/icon/utility/warning';
+import Link from '@atlaskit/link';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { Box } from '@atlaskit/primitives/compiled';
 import * as colors from '@atlaskit/theme/colors';
 import { useEditorViewHasWarnings } from '../../../../hooks/use-editor-view-has-warnings';
@@ -60,7 +62,17 @@ export var useFormattedWarningMessage = function useFormattedWarningMessage() {
   } else if (epicLinkDeprecationTerm && parentLinkDeprecationTerm) {
     return formatWarnings(formatMessage(messages.deprecatedBothParentReplacementMessage, {
       link: function link(chunks) {
-        return /*#__PURE__*/React.createElement("a", {
+        return fg('dst-a11y__replace-anchor-with-link__jira-platform-') ? /*#__PURE__*/React.createElement(Link, {
+          href: softDeprecateEpicParentDocsLink,
+          target: "_blank",
+          rel: "noopener noreferrer",
+          onClick: function onClick(e) {
+            return e.stopPropagation();
+          }
+        }, chunks) :
+        /*#__PURE__*/
+        // eslint-disable-next-line @atlaskit/design-system/no-html-anchor
+        React.createElement("a", {
           href: softDeprecateEpicParentDocsLink,
           target: "_blank",
           rel: "noopener noreferrer",
@@ -76,7 +88,17 @@ export var useFormattedWarningMessage = function useFormattedWarningMessage() {
   } else if (epicLinkDeprecationTerm || parentLinkDeprecationTerm) {
     return formatWarnings(formatMessage(messages.deprecatedParentReplacementMessage, {
       link: function link(chunks) {
-        return /*#__PURE__*/React.createElement("a", {
+        return fg('dst-a11y__replace-anchor-with-link__jira-platform-') ? /*#__PURE__*/React.createElement(Link, {
+          href: softDeprecateEpicParentDocsLink,
+          target: "_blank",
+          rel: "noopener noreferrer",
+          onClick: function onClick(e) {
+            return e.stopPropagation();
+          }
+        }, chunks) :
+        /*#__PURE__*/
+        // eslint-disable-next-line @atlaskit/design-system/no-html-anchor
+        React.createElement("a", {
           href: softDeprecateEpicParentDocsLink,
           target: "_blank",
           rel: "noopener noreferrer",

package/dist/esm/ui/jql-editor-view/index.js

@@ -4,7 +4,6 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import React, { useCallback, useEffect, useImperativeHandle, useMemo, useRef } from 'react';
 import throttle from 'lodash/throttle';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { JQL_EDITOR_AUTOCOMPLETE_ID, JQL_EDITOR_HELP_CONTENT_ID, JQL_EDITOR_INPUT_ID, JQL_EDITOR_MAIN_ID, JQL_EDITOR_VALIDATION_ID } from '../../common/constants';
 import { useEditorThemeContext } from '../../hooks/use-editor-theme';
 import { useEditorViewIsInvalid } from '../../hooks/use-editor-view-is-invalid';
@@ -116,7 +115,7 @@ var JQLEditorView = function JQLEditorView(_ref) {
       'aria-label': intl.formatMessage(messages.inputLabel),
       'aria-controls': autocompleteId,
       'aria-owns': autocompleteId,
-      'aria-describedby': fg('jql_editor_a11y') ? editorViewIsInvalid ? validationId : helpContentId : helpContentId
+      'aria-describedby': editorViewIsInvalid ? validationId : helpContentId
     }, selectedOptionId && {
       'aria-activedescendant': selectedOptionId
     }), editorViewIsInvalid && {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/jql-editor",
-	"version": "5.2.2",
+	"version": "5.3.1",
 	"description": "This package allows consumers to render an advanced JQL editor component to enable autocomplete-assisted authoring and validation of JQL queries.",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -39,21 +39,22 @@
 	"dependencies": {
 		"@atlaskit/analytics-gas-types": "^5.1.0",
 		"@atlaskit/analytics-next": "^11.0.0",
-		"@atlaskit/avatar": "^25.0.0",
-		"@atlaskit/button": "^23.0.0",
+		"@atlaskit/avatar": "^25.1.0",
+		"@atlaskit/button": "^23.2.0",
 		"@atlaskit/editor-prosemirror": "7.0.0",
 		"@atlaskit/form": "^12.0.0",
-		"@atlaskit/icon": "^26.0.0",
+		"@atlaskit/icon": "^26.1.0",
 		"@atlaskit/jql-ast": "^3.3.0",
 		"@atlaskit/jql-autocomplete": "^2.0.0",
 		"@atlaskit/jql-editor-common": "^3.0.0",
 		"@atlaskit/jql-parser": "^2.0.0",
 		"@atlaskit/legacy-custom-icons": "^0.22.0",
+		"@atlaskit/link": "^3.2.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
-		"@atlaskit/primitives": "^14.7.0",
+		"@atlaskit/primitives": "^14.8.0",
 		"@atlaskit/spinner": "^18.0.0",
 		"@atlaskit/theme": "^18.0.0",
-		"@atlaskit/tokens": "^4.8.0",
+		"@atlaskit/tokens": "^4.9.0",
 		"@atlaskit/tooltip": "^20.0.0",
 		"@babel/runtime": "^7.0.0",
 		"@emotion/react": "^11.7.1",
@@ -134,7 +135,7 @@
 		"add_nin_press_interactions": {
 			"type": "boolean"
 		},
-		"jql_editor_a11y": {
+		"dst-a11y__replace-anchor-with-link__jira-platform-": {
 			"type": "boolean"
 		}
 	}