@atlaskit/jql-editor 4.8.1 → 4.8.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,13 @@
1
1
  # @atlaskit/jql-editor
2
2
 
3
+ ## 4.8.2
4
+
5
+ ### Patch Changes
6
+
7
+ - [#146607](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/146607)
8
+ [`abcdffd9cb56d`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/abcdffd9cb56d) -
9
+ [ux] Correcting flicker when search button show loading. It needs an extra style for hiding.
10
+
3
11
  ## 4.8.1
4
12
 
5
13
  ### Patch Changes
@@ -6,5 +6,5 @@ Object.defineProperty(exports, "__esModule", {
6
6
  exports.useJqlEditorAnalytics = void 0;
7
7
  var _jqlEditorCommon = require("@atlaskit/jql-editor-common");
8
8
  var useJqlEditorAnalytics = exports.useJqlEditorAnalytics = function useJqlEditorAnalytics(analyticsSource) {
9
- return (0, _jqlEditorCommon.useJqlPackageAnalytics)(analyticsSource, "@atlaskit/jql-editor", "4.8.1", _jqlEditorCommon.ANALYTICS_CHANNEL);
9
+ return (0, _jqlEditorCommon.useJqlPackageAnalytics)(analyticsSource, "@atlaskit/jql-editor", "4.8.2", _jqlEditorCommon.ANALYTICS_CHANNEL);
10
10
  };
@@ -10,7 +10,6 @@ var _react = _interopRequireWildcard(require("react"));
10
10
  var _button = require("@atlaskit/button");
11
11
  var _new = require("@atlaskit/button/new");
12
12
  var _searchEditorSearch = _interopRequireDefault(require("@atlaskit/icon/core/migration/search--editor-search"));
13
- var _search = _interopRequireDefault(require("@atlaskit/icon/core/search"));
14
13
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
15
14
  var _primitives = require("@atlaskit/primitives");
16
15
  function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
@@ -24,6 +23,11 @@ var iconStyle = (0, _primitives.xcss)({
24
23
  margin: 'space.050',
25
24
  display: 'flex'
26
25
  });
26
+
27
+ // Fixes an issue where loading button makes the editor flicker with a scrollbar
28
+ var buttonContainerStyle = (0, _primitives.xcss)({
29
+ overflow: 'hidden'
30
+ });
27
31
  var BaseSearch = exports.BaseSearch = function BaseSearch(_ref) {
28
32
  var isDisabled = _ref.isDisabled,
29
33
  isSearching = _ref.isSearching,
@@ -35,7 +39,9 @@ var BaseSearch = exports.BaseSearch = function BaseSearch(_ref) {
35
39
  e.preventDefault();
36
40
  }
37
41
  }, []);
38
- return (0, _platformFeatureFlags.fg)('platform-component-visual-refresh') ? /*#__PURE__*/_react.default.createElement(_new.IconButton, {
42
+ return (0, _platformFeatureFlags.fg)('platform-component-visual-refresh') ? /*#__PURE__*/_react.default.createElement(_primitives.Box, {
43
+ xcss: buttonContainerStyle
44
+ }, /*#__PURE__*/_react.default.createElement(_new.IconButton, {
39
45
  label: label,
40
46
  isDisabled: isDisabled,
41
47
  testId: "jql-editor-search",
@@ -44,8 +50,8 @@ var BaseSearch = exports.BaseSearch = function BaseSearch(_ref) {
44
50
  onClick: onSearch,
45
51
  onKeyDown: preventRepeatClick,
46
52
  isLoading: isSearching,
47
- icon: _search.default
48
- }) : /*#__PURE__*/_react.default.createElement(_button.LoadingButton, {
53
+ icon: _searchEditorSearch.default
54
+ })) : /*#__PURE__*/_react.default.createElement(_button.LoadingButton, {
49
55
  "aria-label": label,
50
56
  isDisabled: isDisabled,
51
57
  testId: "jql-editor-search"
@@ -1,4 +1,4 @@
1
1
  import { ANALYTICS_CHANNEL, useJqlPackageAnalytics } from '@atlaskit/jql-editor-common';
2
2
  export const useJqlEditorAnalytics = analyticsSource => {
3
- return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "4.8.1", ANALYTICS_CHANNEL);
3
+ return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "4.8.2", ANALYTICS_CHANNEL);
4
4
  };
@@ -1,8 +1,7 @@
1
1
  import React, { useCallback } from 'react';
2
2
  import { LoadingButton } from '@atlaskit/button';
3
3
  import { IconButton } from '@atlaskit/button/new';
4
- import SearchIconOld from '@atlaskit/icon/core/migration/search--editor-search';
5
- import SearchIcon from '@atlaskit/icon/core/search';
4
+ import SearchIcon from '@atlaskit/icon/core/migration/search--editor-search';
6
5
  import { fg } from '@atlaskit/platform-feature-flags';
7
6
  import { Box, xcss } from '@atlaskit/primitives';
8
7
  const style = {
@@ -14,6 +13,11 @@ const iconStyle = xcss({
14
13
  margin: 'space.050',
15
14
  display: 'flex'
16
15
  });
16
+
17
+ // Fixes an issue where loading button makes the editor flicker with a scrollbar
18
+ const buttonContainerStyle = xcss({
19
+ overflow: 'hidden'
20
+ });
17
21
  export const BaseSearch = ({
18
22
  isDisabled,
19
23
  isSearching,
@@ -26,7 +30,9 @@ export const BaseSearch = ({
26
30
  e.preventDefault();
27
31
  }
28
32
  }, []);
29
- return fg('platform-component-visual-refresh') ? /*#__PURE__*/React.createElement(IconButton, {
33
+ return fg('platform-component-visual-refresh') ? /*#__PURE__*/React.createElement(Box, {
34
+ xcss: buttonContainerStyle
35
+ }, /*#__PURE__*/React.createElement(IconButton, {
30
36
  label: label,
31
37
  isDisabled: isDisabled,
32
38
  testId: "jql-editor-search",
@@ -36,7 +42,7 @@ export const BaseSearch = ({
36
42
  onKeyDown: preventRepeatClick,
37
43
  isLoading: isSearching,
38
44
  icon: SearchIcon
39
- }) : /*#__PURE__*/React.createElement(LoadingButton, {
45
+ })) : /*#__PURE__*/React.createElement(LoadingButton, {
40
46
  "aria-label": label,
41
47
  isDisabled: isDisabled,
42
48
  testId: "jql-editor-search"
@@ -50,7 +56,7 @@ export const BaseSearch = ({
50
56
  isLoading: isSearching,
51
57
  iconBefore: /*#__PURE__*/React.createElement(Box, {
52
58
  xcss: iconStyle
53
- }, /*#__PURE__*/React.createElement(SearchIconOld, {
59
+ }, /*#__PURE__*/React.createElement(SearchIcon, {
54
60
  color: "currentColor",
55
61
  label: '',
56
62
  LEGACY_size: 'medium',
@@ -1,4 +1,4 @@
1
1
  import { ANALYTICS_CHANNEL, useJqlPackageAnalytics } from '@atlaskit/jql-editor-common';
2
2
  export var useJqlEditorAnalytics = function useJqlEditorAnalytics(analyticsSource) {
3
- return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "4.8.1", ANALYTICS_CHANNEL);
3
+ return useJqlPackageAnalytics(analyticsSource, "@atlaskit/jql-editor", "4.8.2", ANALYTICS_CHANNEL);
4
4
  };
@@ -1,8 +1,7 @@
1
1
  import React, { useCallback } from 'react';
2
2
  import { LoadingButton } from '@atlaskit/button';
3
3
  import { IconButton } from '@atlaskit/button/new';
4
- import SearchIconOld from '@atlaskit/icon/core/migration/search--editor-search';
5
- import SearchIcon from '@atlaskit/icon/core/search';
4
+ import SearchIcon from '@atlaskit/icon/core/migration/search--editor-search';
6
5
  import { fg } from '@atlaskit/platform-feature-flags';
7
6
  import { Box, xcss } from '@atlaskit/primitives';
8
7
  var style = {
@@ -14,6 +13,11 @@ var iconStyle = xcss({
14
13
  margin: 'space.050',
15
14
  display: 'flex'
16
15
  });
16
+
17
+ // Fixes an issue where loading button makes the editor flicker with a scrollbar
18
+ var buttonContainerStyle = xcss({
19
+ overflow: 'hidden'
20
+ });
17
21
  export var BaseSearch = function BaseSearch(_ref) {
18
22
  var isDisabled = _ref.isDisabled,
19
23
  isSearching = _ref.isSearching,
@@ -25,7 +29,9 @@ export var BaseSearch = function BaseSearch(_ref) {
25
29
  e.preventDefault();
26
30
  }
27
31
  }, []);
28
- return fg('platform-component-visual-refresh') ? /*#__PURE__*/React.createElement(IconButton, {
32
+ return fg('platform-component-visual-refresh') ? /*#__PURE__*/React.createElement(Box, {
33
+ xcss: buttonContainerStyle
34
+ }, /*#__PURE__*/React.createElement(IconButton, {
29
35
  label: label,
30
36
  isDisabled: isDisabled,
31
37
  testId: "jql-editor-search",
@@ -35,7 +41,7 @@ export var BaseSearch = function BaseSearch(_ref) {
35
41
  onKeyDown: preventRepeatClick,
36
42
  isLoading: isSearching,
37
43
  icon: SearchIcon
38
- }) : /*#__PURE__*/React.createElement(LoadingButton, {
44
+ })) : /*#__PURE__*/React.createElement(LoadingButton, {
39
45
  "aria-label": label,
40
46
  isDisabled: isDisabled,
41
47
  testId: "jql-editor-search"
@@ -49,7 +55,7 @@ export var BaseSearch = function BaseSearch(_ref) {
49
55
  isLoading: isSearching,
50
56
  iconBefore: /*#__PURE__*/React.createElement(Box, {
51
57
  xcss: iconStyle
52
- }, /*#__PURE__*/React.createElement(SearchIconOld, {
58
+ }, /*#__PURE__*/React.createElement(SearchIcon, {
53
59
  color: "currentColor",
54
60
  label: '',
55
61
  LEGACY_size: 'medium',
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/jql-editor",
3
- "version": "4.8.1",
3
+ "version": "4.8.2",
4
4
  "description": "This package allows consumers to render an advanced JQL editor component to enable autocomplete-assisted authoring and validation of JQL queries.",
5
5
  "author": "Atlassian Pty Ltd",
6
6
  "license": "Apache-2.0",
@@ -41,7 +41,7 @@
41
41
  "@atlaskit/button": "^20.2.0",
42
42
  "@atlaskit/editor-prosemirror": "6.0.0",
43
43
  "@atlaskit/form": "^10.5.0",
44
- "@atlaskit/icon": "^22.18.0",
44
+ "@atlaskit/icon": "^22.19.0",
45
45
  "@atlaskit/jql-ast": "^3.3.0",
46
46
  "@atlaskit/jql-autocomplete": "^2.0.0",
47
47
  "@atlaskit/jql-editor-common": "^2.1.0",