@atlaskit/inline-edit 13.4.1 → 13.5.0

package/codemods/__tests__/spread-errorMessage-out-of-fieldProps.tsx

@@ -8,10 +8,10 @@ jest.autoMockOff();
 const defineInlineTest = require('jscodeshift/dist/testUtils').defineInlineTest;
 
 describe('spreadErrorMessage prop', () => {
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from "react";
     import InlineEdit from "@atlaskit/inline-edit";
 
@@ -30,7 +30,7 @@ describe('spreadErrorMessage prop', () => {
       />
     );
     `,
-    `
+		`
     import React from "react";
     import InlineEdit from "@atlaskit/inline-edit";
 
@@ -54,13 +54,13 @@ describe('spreadErrorMessage prop', () => {
       />
     );
     `,
-    'should spread errorMessage out',
-  );
+		'should spread errorMessage out',
+	);
 
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React from "react";
     import InlineEdit from "@atlaskit/inline-edit";
 
@@ -79,7 +79,7 @@ describe('spreadErrorMessage prop', () => {
       />
     );
     `,
-    `
+		`
     import React from "react";
     import InlineEdit from "@atlaskit/inline-edit";
 
@@ -103,13 +103,13 @@ describe('spreadErrorMessage prop', () => {
       />
     );
     `,
-    'should spread errorMessage out - with alias',
-  );
+		'should spread errorMessage out - with alias',
+	);
 
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React, { PureComponent } from "react";
     import InlineEdit from "@atlaskit/inline-edit";
     import TextField from "@atlaskit/textfield";
@@ -202,7 +202,7 @@ describe('spreadErrorMessage prop', () => {
       }
     }
     `,
-    `
+		`
     import React, { PureComponent } from "react";
     import InlineEdit from "@atlaskit/inline-edit";
     import TextField from "@atlaskit/textfield";
@@ -295,13 +295,13 @@ describe('spreadErrorMessage prop', () => {
       }
     }
     `,
-    'ColumnEditableTitle - add comment when editView is not inline',
-  );
+		'ColumnEditableTitle - add comment when editView is not inline',
+	);
 
-  defineInlineTest(
-    { default: transformer, parser: 'tsx' },
-    {},
-    `
+	defineInlineTest(
+		{ default: transformer, parser: 'tsx' },
+		{},
+		`
     import React, { PureComponent } from "react";
     import InlineEdit from "@atlaskit/inline-edit";
     import TextField from "@atlaskit/textfield";
@@ -393,7 +393,7 @@ describe('spreadErrorMessage prop', () => {
       }
     }
     `,
-    `
+		`
     import React, { PureComponent } from "react";
     import InlineEdit from "@atlaskit/inline-edit";
     import TextField from "@atlaskit/textfield";
@@ -488,6 +488,6 @@ describe('spreadErrorMessage prop', () => {
       }
     }
     `,
-    'ColumnEditableTitle - convert when editView is inline',
-  );
+		'ColumnEditableTitle - convert when editView is inline',
+	);
 });

package/codemods/migrates/add-comments-when-validate-found.ts

@@ -1,10 +1,6 @@
 import type { ASTPath, default as core, ImportDeclaration } from 'jscodeshift';
 
-import {
-  addCommentToStartOfFile,
-  getDefaultSpecifierName,
-  hasJSXAttributesByName,
-} from './utils';
+import { addCommentToStartOfFile, getDefaultSpecifierName, hasJSXAttributesByName } from './utils';
 
 const commentMessage = `We could not automatically convert this code to the new API.
 
@@ -31,24 +27,18 @@ const MyEditView = (
 `;
 
 const addCommentsWhenValidateFound = (j: core.JSCodeshift, source: any) => {
-  const defaultSpecifier = getDefaultSpecifierName(
-    j,
-    source,
-    '@atlaskit/inline-edit',
-  );
-
-  if (!defaultSpecifier) {
-    return;
-  }
-
-  source
-    .findJSXElements(defaultSpecifier)
-    .forEach((element: ASTPath<ImportDeclaration>) => {
-      const isValidateDefined = hasJSXAttributesByName(j, element, 'validate');
-      if (isValidateDefined) {
-        addCommentToStartOfFile({ j, base: source, message: commentMessage });
-      }
-    });
+	const defaultSpecifier = getDefaultSpecifierName(j, source, '@atlaskit/inline-edit');
+
+	if (!defaultSpecifier) {
+		return;
+	}
+
+	source.findJSXElements(defaultSpecifier).forEach((element: ASTPath<ImportDeclaration>) => {
+		const isValidateDefined = hasJSXAttributesByName(j, element, 'validate');
+		if (isValidateDefined) {
+			addCommentToStartOfFile({ j, base: source, message: commentMessage });
+		}
+	});
 };
 
 export default addCommentsWhenValidateFound;

package/codemods/migrates/lift-InlineEditStateless-to-default.ts

@@ -1,9 +1,9 @@
 import type {
-  ASTPath,
-  default as core,
-  ImportDeclaration,
-  ImportDefaultSpecifier,
-  ImportSpecifier,
+	ASTPath,
+	default as core,
+	ImportDeclaration,
+	ImportDefaultSpecifier,
+	ImportSpecifier,
 } from 'jscodeshift';
 
 import { addCommentToStartOfFile } from './utils';
@@ -14,58 +14,44 @@ This file uses \`InlineEdit\` and \`InlineEditStateless\` at the same time. We'v
 `;
 
 const elevateComponentToDefault =
-  (pkg: string, toPkg: string, innerElementName: string) =>
-  (j: core.JSCodeshift, root: any) => {
-    const importDeclarations = root
-      .find(j.ImportDeclaration)
-      .filter(
-        (path: ASTPath<ImportDeclaration>) => path.node.source.value === pkg,
-      );
-
-    const defaultSpecifier = importDeclarations
-      .find(j.ImportDefaultSpecifier)
-      .nodes();
-    const otherSpecifier = importDeclarations.find(j.ImportSpecifier).nodes();
-
-    const isImportingStateless =
-      otherSpecifier.filter(
-        (s: ImportSpecifier) =>
-          s.imported && s.imported.name === innerElementName,
-      ).length > 0;
-
-    if (defaultSpecifier.length > 0 && isImportingStateless) {
-      addCommentToStartOfFile({ j, base: root, message: commentMessage });
-      return;
-    }
-
-    const newDefaultSpecifier = defaultSpecifier.map(
-      (s: ImportDefaultSpecifier) => {
-        return j.importDeclaration(
-          [j.importDefaultSpecifier(s.local)],
-          j.literal(pkg),
-        );
-      },
-    );
-
-    const newOtherSpecifiers = otherSpecifier.map((s: ImportSpecifier) => {
-      if (s.imported.name === innerElementName) {
-        return j.importDeclaration(
-          [j.importDefaultSpecifier(s.local)],
-          j.literal(toPkg),
-        );
-      } else {
-        return j.importDeclaration([s], j.literal(pkg));
-      }
-    });
-
-    importDeclarations.forEach((path: ASTPath<ImportDeclaration>) => {
-      j(path).replaceWith(newDefaultSpecifier);
-      j(path).insertBefore(newOtherSpecifiers);
-    });
-  };
+	(pkg: string, toPkg: string, innerElementName: string) => (j: core.JSCodeshift, root: any) => {
+		const importDeclarations = root
+			.find(j.ImportDeclaration)
+			.filter((path: ASTPath<ImportDeclaration>) => path.node.source.value === pkg);
+
+		const defaultSpecifier = importDeclarations.find(j.ImportDefaultSpecifier).nodes();
+		const otherSpecifier = importDeclarations.find(j.ImportSpecifier).nodes();
+
+		const isImportingStateless =
+			otherSpecifier.filter(
+				(s: ImportSpecifier) => s.imported && s.imported.name === innerElementName,
+			).length > 0;
+
+		if (defaultSpecifier.length > 0 && isImportingStateless) {
+			addCommentToStartOfFile({ j, base: root, message: commentMessage });
+			return;
+		}
+
+		const newDefaultSpecifier = defaultSpecifier.map((s: ImportDefaultSpecifier) => {
+			return j.importDeclaration([j.importDefaultSpecifier(s.local)], j.literal(pkg));
+		});
+
+		const newOtherSpecifiers = otherSpecifier.map((s: ImportSpecifier) => {
+			if (s.imported.name === innerElementName) {
+				return j.importDeclaration([j.importDefaultSpecifier(s.local)], j.literal(toPkg));
+			} else {
+				return j.importDeclaration([s], j.literal(pkg));
+			}
+		});
+
+		importDeclarations.forEach((path: ASTPath<ImportDeclaration>) => {
+			j(path).replaceWith(newDefaultSpecifier);
+			j(path).insertBefore(newOtherSpecifiers);
+		});
+	};
 
 export default elevateComponentToDefault(
-  '@atlaskit/inline-edit',
-  '@atlaskit/inline-edit',
-  'InlineEditStateless',
+	'@atlaskit/inline-edit',
+	'@atlaskit/inline-edit',
+	'InlineEditStateless',
 );

package/codemods/migrates/lift-InlineEditableTextField-to-its-entry-point.ts

@@ -1,53 +1,40 @@
 import type {
-  ASTPath,
-  default as core,
-  ImportDeclaration,
-  ImportDefaultSpecifier,
-  ImportSpecifier,
+	ASTPath,
+	default as core,
+	ImportDeclaration,
+	ImportDefaultSpecifier,
+	ImportSpecifier,
 } from 'jscodeshift';
 
 const elevateComponentToNewEntryPoint =
-  (pkg: string, toPkg: string, innerElementName: string) =>
-  (j: core.JSCodeshift, root: any) => {
-    const importDeclarations = root
-      .find(j.ImportDeclaration)
-      .filter(
-        (path: ASTPath<ImportDeclaration>) => path.node.source.value === pkg,
-      );
+	(pkg: string, toPkg: string, innerElementName: string) => (j: core.JSCodeshift, root: any) => {
+		const importDeclarations = root
+			.find(j.ImportDeclaration)
+			.filter((path: ASTPath<ImportDeclaration>) => path.node.source.value === pkg);
 
-    const defaultSpecifier = importDeclarations
-      .find(j.ImportDefaultSpecifier)
-      .nodes();
-    const otherSpecifier = importDeclarations.find(j.ImportSpecifier).nodes();
+		const defaultSpecifier = importDeclarations.find(j.ImportDefaultSpecifier).nodes();
+		const otherSpecifier = importDeclarations.find(j.ImportSpecifier).nodes();
 
-    const newDefaultSpecifier = defaultSpecifier.map(
-      (s: ImportDefaultSpecifier) => {
-        return j.importDeclaration(
-          [j.importDefaultSpecifier(s.local)],
-          j.literal(pkg),
-        );
-      },
-    );
+		const newDefaultSpecifier = defaultSpecifier.map((s: ImportDefaultSpecifier) => {
+			return j.importDeclaration([j.importDefaultSpecifier(s.local)], j.literal(pkg));
+		});
 
-    const newOtherSpecifiers = otherSpecifier.map((s: ImportSpecifier) => {
-      if (s.imported.name === innerElementName) {
-        return j.importDeclaration(
-          [j.importDefaultSpecifier(s.local)],
-          j.literal(toPkg),
-        );
-      } else {
-        return j.importDeclaration([s], j.literal(pkg));
-      }
-    });
+		const newOtherSpecifiers = otherSpecifier.map((s: ImportSpecifier) => {
+			if (s.imported.name === innerElementName) {
+				return j.importDeclaration([j.importDefaultSpecifier(s.local)], j.literal(toPkg));
+			} else {
+				return j.importDeclaration([s], j.literal(pkg));
+			}
+		});
 
-    importDeclarations.forEach((path: ASTPath<ImportDeclaration>) => {
-      j(path).replaceWith(newDefaultSpecifier);
-      j(path).insertBefore(newOtherSpecifiers);
-    });
-  };
+		importDeclarations.forEach((path: ASTPath<ImportDeclaration>) => {
+			j(path).replaceWith(newDefaultSpecifier);
+			j(path).insertBefore(newOtherSpecifiers);
+		});
+	};
 
 export default elevateComponentToNewEntryPoint(
-  '@atlaskit/inline-edit',
-  '@atlaskit/inline-edit/inline-editable-textfield',
-  'InlineEditableTextfield',
+	'@atlaskit/inline-edit',
+	'@atlaskit/inline-edit/inline-editable-textfield',
+	'InlineEditableTextfield',
 );

package/codemods/migrates/spread-errorMessage-out-of-fieldProps.ts

@@ -1,74 +1,56 @@
 import { type NodePath } from 'ast-types/lib/node-path';
 import type { ASTPath, default as core, ImportDeclaration } from 'jscodeshift';
 
-import {
-  getDefaultSpecifierName,
-  getJSXAttributesByName,
-  hasJSXAttributesByName,
-} from './utils';
+import { getDefaultSpecifierName, getJSXAttributesByName, hasJSXAttributesByName } from './utils';
 
 const isConvertable = (arrowFunction: NodePath | null) => {
-  return (
-    arrowFunction &&
-    arrowFunction.value.params.length === 1 &&
-    arrowFunction.value.params[0].type === 'Identifier'
-  );
+	return (
+		arrowFunction &&
+		arrowFunction.value.params.length === 1 &&
+		arrowFunction.value.params[0].type === 'Identifier'
+	);
 };
 
 const spreadErrorMessage = (j: core.JSCodeshift, source: any) => {
-  const defaultSpecifier = getDefaultSpecifierName(
-    j,
-    source,
-    '@atlaskit/inline-edit',
-  );
-
-  if (!defaultSpecifier) {
-    return;
-  }
-
-  const createObjectProperty = (name: string) => {
-    const obj = j.objectProperty(j.identifier(name), j.identifier(name));
-    obj.shorthand = true;
-    obj.loc = null;
-
-    return obj;
-  };
-
-  source
-    .findJSXElements(defaultSpecifier)
-    .forEach((element: ASTPath<ImportDeclaration>) => {
-      getJSXAttributesByName(j, element, 'editView').forEach((editView) => {
-        const collection = j(editView)
-          .find(j.JSXExpressionContainer)
-          .find(j.ArrowFunctionExpression);
-
-        const isValidateDefined = hasJSXAttributesByName(
-          j,
-          element,
-          'validate',
-        );
-        const arrowFunction = collection.length > 0 ? collection.get() : null;
-
-        if (isValidateDefined && isConvertable(arrowFunction)) {
-          const name = arrowFunction.value.params[0].name;
-          const replacement = j.jsxExpressionContainer(
-            j.arrowFunctionExpression(
-              [
-                j.objectPattern([
-                  createObjectProperty('errorMessage'),
-                  j.restProperty(j.identifier(name)),
-                ]),
-              ],
-              arrowFunction.value.body,
-            ),
-          );
-
-          j(editView).replaceWith(
-            j.jsxAttribute(j.jsxIdentifier('editView'), replacement),
-          );
-        }
-      });
-    });
+	const defaultSpecifier = getDefaultSpecifierName(j, source, '@atlaskit/inline-edit');
+
+	if (!defaultSpecifier) {
+		return;
+	}
+
+	const createObjectProperty = (name: string) => {
+		const obj = j.objectProperty(j.identifier(name), j.identifier(name));
+		obj.shorthand = true;
+		obj.loc = null;
+
+		return obj;
+	};
+
+	source.findJSXElements(defaultSpecifier).forEach((element: ASTPath<ImportDeclaration>) => {
+		getJSXAttributesByName(j, element, 'editView').forEach((editView) => {
+			const collection = j(editView).find(j.JSXExpressionContainer).find(j.ArrowFunctionExpression);
+
+			const isValidateDefined = hasJSXAttributesByName(j, element, 'validate');
+			const arrowFunction = collection.length > 0 ? collection.get() : null;
+
+			if (isValidateDefined && isConvertable(arrowFunction)) {
+				const name = arrowFunction.value.params[0].name;
+				const replacement = j.jsxExpressionContainer(
+					j.arrowFunctionExpression(
+						[
+							j.objectPattern([
+								createObjectProperty('errorMessage'),
+								j.restProperty(j.identifier(name)),
+							]),
+						],
+						arrowFunction.value.body,
+					),
+				);
+
+				j(editView).replaceWith(j.jsxAttribute(j.jsxIdentifier('editView'), replacement));
+			}
+		});
+	});
 };
 
 export default spreadErrorMessage;

package/codemods/migrates/utils.ts

@@ -1,102 +1,94 @@
 import type {
-  ASTPath,
-  default as core,
-  ImportDeclaration,
-  JSXAttribute,
-  Program,
+	ASTPath,
+	default as core,
+	ImportDeclaration,
+	JSXAttribute,
+	Program,
 } from 'jscodeshift';
 import { type Collection } from 'jscodeshift/src/Collection';
 
 function addCommentBefore({
-  j,
-  target,
-  message,
+	j,
+	target,
+	message,
 }: {
-  j: core.JSCodeshift;
-  target:
-    | Collection<Node>
-    | Collection<Program>
-    | Collection<ImportDeclaration>;
-  message: string;
+	j: core.JSCodeshift;
+	target: Collection<Node> | Collection<Program> | Collection<ImportDeclaration>;
+	message: string;
 }) {
-  const content: string = ` TODO: (from codemod) ${message} `;
-  target.forEach((path: ASTPath<any>) => {
-    path.value.comments = path.value.comments || [];
+	const content: string = ` TODO: (from codemod) ${message} `;
+	target.forEach((path: ASTPath<any>) => {
+		path.value.comments = path.value.comments || [];
 
-    const exists = path.value.comments.find(
-      (comment: ASTPath<any>) => comment.value === content,
-    );
+		const exists = path.value.comments.find((comment: ASTPath<any>) => comment.value === content);
 
-    // avoiding duplicates of the same comment
-    if (exists) {
-      return;
-    }
+		// avoiding duplicates of the same comment
+		if (exists) {
+			return;
+		}
 
-    path.value.comments.push(j.commentBlock(content));
-  });
+		path.value.comments.push(j.commentBlock(content));
+	});
 }
 
 function addCommentToStartOfFile({
-  j,
-  base,
-  message,
+	j,
+	base,
+	message,
 }: {
-  j: core.JSCodeshift;
-  base: Collection<Node>;
-  message: string;
+	j: core.JSCodeshift;
+	base: Collection<Node>;
+	message: string;
 }) {
-  addCommentBefore({
-    j,
-    target: base.find(j.Program),
-    message,
-  });
+	addCommentBefore({
+		j,
+		target: base.find(j.Program),
+		message,
+	});
 }
 
 function getJSXAttributesByName(
-  j: core.JSCodeshift,
-  element: ASTPath<any>,
-  attributeName: string,
+	j: core.JSCodeshift,
+	element: ASTPath<any>,
+	attributeName: string,
 ): Collection<JSXAttribute> {
-  return j(element)
-    .find(j.JSXOpeningElement)
-    .find(j.JSXAttribute)
-    .filter((attribute) => {
-      const matches = j(attribute)
-        .find(j.JSXIdentifier)
-        .filter((identifier) => identifier.value.name === attributeName);
-      return Boolean(matches.length);
-    });
+	return j(element)
+		.find(j.JSXOpeningElement)
+		.find(j.JSXAttribute)
+		.filter((attribute) => {
+			const matches = j(attribute)
+				.find(j.JSXIdentifier)
+				.filter((identifier) => identifier.value.name === attributeName);
+			return Boolean(matches.length);
+		});
 }
 
 const getDefaultSpecifierName = (
-  j: core.JSCodeshift,
-  base: Collection<any>,
-  packageName: string,
+	j: core.JSCodeshift,
+	base: Collection<any>,
+	packageName: string,
 ) => {
-  const specifiers = base
-    .find(j.ImportDeclaration)
-    .filter(
-      (path: ASTPath<ImportDeclaration>) =>
-        path.node.source.value === packageName,
-    )
-    .find(j.ImportDefaultSpecifier);
+	const specifiers = base
+		.find(j.ImportDeclaration)
+		.filter((path: ASTPath<ImportDeclaration>) => path.node.source.value === packageName)
+		.find(j.ImportDefaultSpecifier);
 
-  if (!specifiers.length) {
-    return null;
-  }
+	if (!specifiers.length) {
+		return null;
+	}
 
-  return specifiers.nodes()[0]!.local!.name;
+	return specifiers.nodes()[0]!.local!.name;
 };
 
 const hasJSXAttributesByName = (
-  j: core.JSCodeshift,
-  element: ASTPath<any>,
-  attributeName: string,
+	j: core.JSCodeshift,
+	element: ASTPath<any>,
+	attributeName: string,
 ) => getJSXAttributesByName(j, element, attributeName).length > 0;
 
 export {
-  getDefaultSpecifierName,
-  getJSXAttributesByName,
-  hasJSXAttributesByName,
-  addCommentToStartOfFile,
+	getDefaultSpecifierName,
+	getJSXAttributesByName,
+	hasJSXAttributesByName,
+	addCommentToStartOfFile,
 };

package/dist/cjs/inline-edit.js

@@ -21,7 +21,9 @@ var _readView = _interopRequireDefault(require("./internal/read-view"));
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
-function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } /** @jsx jsx */
+function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } /**
+ * @jsxRuntime classic
+ */ /** @jsx jsx */ // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 var fieldStyles = (0, _react2.css)({
   maxWidth: '100%',
   position: 'relative'
@@ -29,7 +31,7 @@ var fieldStyles = (0, _react2.css)({
 var analyticsAttributes = {
   componentName: 'inlineEdit',
   packageName: "@atlaskit/inline-edit",
-  packageVersion: "13.4.1"
+  packageVersion: "13.5.0"
 };
 var noop = function noop() {};
 var InnerInlineEdit = function InnerInlineEdit(props) {