@atlaskit/inline-edit 13.1.0 → 13.2.0

package/dist/cjs/inline-edit.js

@@ -13,6 +13,8 @@ var _react2 = require("@emotion/react");
 var _analyticsNext = require("@atlaskit/analytics-next");
 var _Field = _interopRequireDefault(require("@atlaskit/form/Field"));
 var _Form = _interopRequireDefault(require("@atlaskit/form/Form"));
+var _pressable = _interopRequireDefault(require("@atlaskit/primitives/pressable"));
+var _visuallyHidden = _interopRequireDefault(require("@atlaskit/visually-hidden"));
 var _buttons = _interopRequireDefault(require("./internal/buttons"));
 var _useButtonFocusHook2 = _interopRequireDefault(require("./internal/hooks/use-button-focus-hook"));
 var _readView = _interopRequireDefault(require("./internal/read-view"));
@@ -27,7 +29,7 @@ var fieldStyles = (0, _react2.css)({
 var analyticsAttributes = {
   componentName: 'inlineEdit',
   packageName: "@atlaskit/inline-edit",
-  packageVersion: "13.1.0"
+  packageVersion: "13.2.0"
 };
 var noop = function noop() {};
 var InnerInlineEdit = function InnerInlineEdit(props) {
@@ -150,7 +152,8 @@ var InnerInlineEdit = function InnerInlineEdit(props) {
       postReadViewClick: doNotFocusOnEditButton,
       editButtonRef: editButtonRef,
       readViewFitContainerWidth: readViewFitContainerWidth,
-      readView: readView
+      readView: readView,
+      testId: testId
     });
   };
   return (0, _react2.jsx)(_Form.default, {
@@ -211,11 +214,10 @@ var InnerInlineEdit = function InnerInlineEdit(props) {
           _onCancelClick(e);
         }
       }) : /** This is to allow Ctrl + Enter to submit without action buttons */
-      (0, _react2.jsx)("button", {
+      (0, _react2.jsx)(_pressable.default, {
         hidden: true,
-        type: "submit",
-        "aria-label": "Submit"
-      }));
+        type: "submit"
+      }, (0, _react2.jsx)(_visuallyHidden.default, null, "Submit")));
     }) : /** Field is used here only for the label and spacing */
     (0, _react2.jsx)(_Field.default, {
       name: "inlineEdit",

package/dist/cjs/internal/read-view.js

@@ -1,5 +1,6 @@
 "use strict";
 
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
 var _typeof = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
@@ -7,7 +8,9 @@ Object.defineProperty(exports, "__esModule", {
 exports.default = void 0;
 var _react = _interopRequireWildcard(require("react"));
 var _react2 = require("@emotion/react");
+var _primitives = require("@atlaskit/primitives");
 var _colors = require("@atlaskit/theme/colors");
+var _visuallyHidden = _interopRequireDefault(require("@atlaskit/visually-hidden"));
 var _constants = require("./constants");
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
@@ -16,17 +19,24 @@ function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e;
 var readViewContainerStyles = (0, _react2.css)({
   lineHeight: 1
 });
-var editButtonStyles = (0, _react2.css)({
+var editButtonStyles = (0, _primitives.xcss)({
   display: 'block',
-  margin: "var(--ds-space-0, 0px)",
-  padding: "var(--ds-space-0, 0px)",
+  margin: 'space.0',
+  padding: 'space.0',
   appearance: 'none',
   background: 'transparent',
   border: 0,
   lineHeight: 1,
-  outline: '0',
-  '&:focus + div': {
-    border: "2px solid ".concat("var(--ds-border-focused, ".concat(_colors.B100, ")"))
+  outline: 0,
+  ':focus-visible': {
+    outline: 0
+  },
+  // @ts-expect-error
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors
+  ':focus + div': {
+    borderColor: 'color.border.focused',
+    borderWidth: 'border.width.outline',
+    borderStyle: 'solid'
   }
 });
 var readViewWrapperStyles = (0, _react2.css)({
@@ -51,7 +61,8 @@ var ReadView = function ReadView(_ref) {
     postReadViewClick = _ref.postReadViewClick,
     editButtonRef = _ref.editButtonRef,
     readViewFitContainerWidth = _ref.readViewFitContainerWidth,
-    readView = _ref.readView;
+    readView = _ref.readView,
+    testId = _ref.testId;
   var startX = (0, _react.useRef)(0);
   var startY = (0, _react.useRef)(0);
   var mouseHasMovedAfterMouseDown = function mouseHasMovedAfterMouseDown(event) {
@@ -68,13 +79,12 @@ var ReadView = function ReadView(_ref) {
   };
   return (0, _react2.jsx)("div", {
     css: readViewContainerStyles
-  }, (0, _react2.jsx)("button", {
-    css: editButtonStyles,
-    "aria-label": editButtonLabel,
-    type: "button",
+  }, (0, _react2.jsx)(_primitives.Pressable, {
+    xcss: editButtonStyles,
     onClick: onEditRequested,
-    ref: editButtonRef
-  }), (0, _react2.jsx)("div", {
+    ref: editButtonRef,
+    testId: testId && "".concat(testId, "--edit-button")
+  }, (0, _react2.jsx)(_visuallyHidden.default, null, editButtonLabel)), (0, _react2.jsx)("div", {
     css: [readViewWrapperStyles, readViewFitContainerWidth && readViewFitContainerWidthStyles]
     /**
      * It is not normally acceptable to add click handlers to non-interactive elements

package/dist/es2019/inline-edit.js

@@ -4,6 +4,8 @@ import { css, jsx } from '@emotion/react';
 import { usePlatformLeafEventHandler } from '@atlaskit/analytics-next';
 import Field from '@atlaskit/form/Field';
 import Form from '@atlaskit/form/Form';
+import Pressable from '@atlaskit/primitives/pressable';
+import VisuallyHidden from '@atlaskit/visually-hidden';
 import Buttons from './internal/buttons';
 import useButtonFocusHook from './internal/hooks/use-button-focus-hook';
 import ReadView from './internal/read-view';
@@ -14,7 +16,7 @@ const fieldStyles = css({
 const analyticsAttributes = {
   componentName: 'inlineEdit',
   packageName: "@atlaskit/inline-edit",
-  packageVersion: "13.1.0"
+  packageVersion: "13.2.0"
 };
 const noop = () => {};
 const InnerInlineEdit = props => {
@@ -126,7 +128,8 @@ const InnerInlineEdit = props => {
       postReadViewClick: doNotFocusOnEditButton,
       editButtonRef: editButtonRef,
       readViewFitContainerWidth: readViewFitContainerWidth,
-      readView: readView
+      readView: readView,
+      testId: testId
     });
   };
   return jsx(Form, {
@@ -187,11 +190,10 @@ const InnerInlineEdit = props => {
       onCancelClick(e);
     }
   }) : /** This is to allow Ctrl + Enter to submit without action buttons */
-  jsx("button", {
+  jsx(Pressable, {
     hidden: true,
-    type: "submit",
-    "aria-label": "Submit"
-  }))) : /** Field is used here only for the label and spacing */
+    type: "submit"
+  }, jsx(VisuallyHidden, null, "Submit")))) : /** Field is used here only for the label and spacing */
   jsx(Field, {
     name: "inlineEdit",
     label: label,

package/dist/es2019/internal/read-view.js

@@ -1,22 +1,31 @@
 /** @jsx jsx */
 import React, { useRef } from 'react';
 import { css, jsx } from '@emotion/react';
-import { B100, N30 } from '@atlaskit/theme/colors';
+import { Pressable, xcss } from '@atlaskit/primitives';
+import { N30 } from '@atlaskit/theme/colors';
+import VisuallyHidden from '@atlaskit/visually-hidden';
 import { borderRadius } from './constants';
 const readViewContainerStyles = css({
   lineHeight: 1
 });
-const editButtonStyles = css({
+const editButtonStyles = xcss({
   display: 'block',
-  margin: "var(--ds-space-0, 0px)",
-  padding: "var(--ds-space-0, 0px)",
+  margin: 'space.0',
+  padding: 'space.0',
   appearance: 'none',
   background: 'transparent',
   border: 0,
   lineHeight: 1,
-  outline: '0',
-  '&:focus + div': {
-    border: `2px solid ${`var(--ds-border-focused, ${B100})`}`
+  outline: 0,
+  ':focus-visible': {
+    outline: 0
+  },
+  // @ts-expect-error
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors
+  ':focus + div': {
+    borderColor: 'color.border.focused',
+    borderWidth: 'border.width.outline',
+    borderStyle: 'solid'
   }
 });
 const readViewWrapperStyles = css({
@@ -41,7 +50,8 @@ const ReadView = ({
   postReadViewClick,
   editButtonRef,
   readViewFitContainerWidth,
-  readView
+  readView,
+  testId
 }) => {
   const startX = useRef(0);
   const startY = useRef(0);
@@ -59,13 +69,12 @@ const ReadView = ({
   };
   return jsx("div", {
     css: readViewContainerStyles
-  }, jsx("button", {
-    css: editButtonStyles,
-    "aria-label": editButtonLabel,
-    type: "button",
+  }, jsx(Pressable, {
+    xcss: editButtonStyles,
     onClick: onEditRequested,
-    ref: editButtonRef
-  }), jsx("div", {
+    ref: editButtonRef,
+    testId: testId && `${testId}--edit-button`
+  }, jsx(VisuallyHidden, null, editButtonLabel)), jsx("div", {
     css: [readViewWrapperStyles, readViewFitContainerWidth && readViewFitContainerWidthStyles]
     /**
      * It is not normally acceptable to add click handlers to non-interactive elements

package/dist/esm/inline-edit.js

@@ -8,6 +8,8 @@ import { css, jsx } from '@emotion/react';
 import { usePlatformLeafEventHandler } from '@atlaskit/analytics-next';
 import Field from '@atlaskit/form/Field';
 import Form from '@atlaskit/form/Form';
+import Pressable from '@atlaskit/primitives/pressable';
+import VisuallyHidden from '@atlaskit/visually-hidden';
 import Buttons from './internal/buttons';
 import useButtonFocusHook from './internal/hooks/use-button-focus-hook';
 import ReadView from './internal/read-view';
@@ -18,7 +20,7 @@ var fieldStyles = css({
 var analyticsAttributes = {
   componentName: 'inlineEdit',
   packageName: "@atlaskit/inline-edit",
-  packageVersion: "13.1.0"
+  packageVersion: "13.2.0"
 };
 var noop = function noop() {};
 var InnerInlineEdit = function InnerInlineEdit(props) {
@@ -141,7 +143,8 @@ var InnerInlineEdit = function InnerInlineEdit(props) {
       postReadViewClick: doNotFocusOnEditButton,
       editButtonRef: editButtonRef,
       readViewFitContainerWidth: readViewFitContainerWidth,
-      readView: readView
+      readView: readView,
+      testId: testId
     });
   };
   return jsx(Form, {
@@ -202,11 +205,10 @@ var InnerInlineEdit = function InnerInlineEdit(props) {
           _onCancelClick(e);
         }
       }) : /** This is to allow Ctrl + Enter to submit without action buttons */
-      jsx("button", {
+      jsx(Pressable, {
         hidden: true,
-        type: "submit",
-        "aria-label": "Submit"
-      }));
+        type: "submit"
+      }, jsx(VisuallyHidden, null, "Submit")));
     }) : /** Field is used here only for the label and spacing */
     jsx(Field, {
       name: "inlineEdit",

package/dist/esm/internal/read-view.js

@@ -1,22 +1,31 @@
 /** @jsx jsx */
 import React, { useRef } from 'react';
 import { css, jsx } from '@emotion/react';
-import { B100, N30 } from '@atlaskit/theme/colors';
+import { Pressable, xcss } from '@atlaskit/primitives';
+import { N30 } from '@atlaskit/theme/colors';
+import VisuallyHidden from '@atlaskit/visually-hidden';
 import { borderRadius } from './constants';
 var readViewContainerStyles = css({
   lineHeight: 1
 });
-var editButtonStyles = css({
+var editButtonStyles = xcss({
   display: 'block',
-  margin: "var(--ds-space-0, 0px)",
-  padding: "var(--ds-space-0, 0px)",
+  margin: 'space.0',
+  padding: 'space.0',
   appearance: 'none',
   background: 'transparent',
   border: 0,
   lineHeight: 1,
-  outline: '0',
-  '&:focus + div': {
-    border: "2px solid ".concat("var(--ds-border-focused, ".concat(B100, ")"))
+  outline: 0,
+  ':focus-visible': {
+    outline: 0
+  },
+  // @ts-expect-error
+  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors
+  ':focus + div': {
+    borderColor: 'color.border.focused',
+    borderWidth: 'border.width.outline',
+    borderStyle: 'solid'
   }
 });
 var readViewWrapperStyles = css({
@@ -41,7 +50,8 @@ var ReadView = function ReadView(_ref) {
     postReadViewClick = _ref.postReadViewClick,
     editButtonRef = _ref.editButtonRef,
     readViewFitContainerWidth = _ref.readViewFitContainerWidth,
-    readView = _ref.readView;
+    readView = _ref.readView,
+    testId = _ref.testId;
   var startX = useRef(0);
   var startY = useRef(0);
   var mouseHasMovedAfterMouseDown = function mouseHasMovedAfterMouseDown(event) {
@@ -58,13 +68,12 @@ var ReadView = function ReadView(_ref) {
   };
   return jsx("div", {
     css: readViewContainerStyles
-  }, jsx("button", {
-    css: editButtonStyles,
-    "aria-label": editButtonLabel,
-    type: "button",
+  }, jsx(Pressable, {
+    xcss: editButtonStyles,
     onClick: onEditRequested,
-    ref: editButtonRef
-  }), jsx("div", {
+    ref: editButtonRef,
+    testId: testId && "".concat(testId, "--edit-button")
+  }, jsx(VisuallyHidden, null, editButtonLabel)), jsx("div", {
     css: [readViewWrapperStyles, readViewFitContainerWidth && readViewFitContainerWidthStyles]
     /**
      * It is not normally acceptable to add click handlers to non-interactive elements

package/dist/types/inline-edit.d.ts

@@ -1,4 +1,4 @@
 import { jsx } from '@emotion/react';
-import { InlineEditProps } from './types';
+import { type InlineEditProps } from './types';
 declare const InlineEdit: <FieldValue extends unknown = string>(props: InlineEditProps<FieldValue>) => jsx.JSX.Element;
 export default InlineEdit;

package/dist/types/internal/read-view.d.ts

@@ -8,6 +8,7 @@ interface ReadViewProps {
     editButtonRef: React.RefObject<HTMLButtonElement>;
     readViewFitContainerWidth?: boolean;
     readView: () => React.ReactNode;
+    testId?: string;
 }
-declare const ReadView: ({ editButtonLabel, onEditRequested, postReadViewClick, editButtonRef, readViewFitContainerWidth, readView, }: ReadViewProps) => jsx.JSX.Element;
+declare const ReadView: ({ editButtonLabel, onEditRequested, postReadViewClick, editButtonRef, readViewFitContainerWidth, readView, testId, }: ReadViewProps) => jsx.JSX.Element;
 export default ReadView;

package/dist/types-ts4.5/inline-edit.d.ts

@@ -1,4 +1,4 @@
 import { jsx } from '@emotion/react';
-import { InlineEditProps } from './types';
+import { type InlineEditProps } from './types';
 declare const InlineEdit: <FieldValue extends unknown = string>(props: InlineEditProps<FieldValue>) => jsx.JSX.Element;
 export default InlineEdit;

package/dist/types-ts4.5/internal/read-view.d.ts

@@ -8,6 +8,7 @@ interface ReadViewProps {
     editButtonRef: React.RefObject<HTMLButtonElement>;
     readViewFitContainerWidth?: boolean;
     readView: () => React.ReactNode;
+    testId?: string;
 }
-declare const ReadView: ({ editButtonLabel, onEditRequested, postReadViewClick, editButtonRef, readViewFitContainerWidth, readView, }: ReadViewProps) => jsx.JSX.Element;
+declare const ReadView: ({ editButtonLabel, onEditRequested, postReadViewClick, editButtonRef, readViewFitContainerWidth, readView, testId, }: ReadViewProps) => jsx.JSX.Element;
 export default ReadView;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/inline-edit",
-  "version": "13.1.0",
+  "version": "13.2.0",
   "description": "An inline edit displays a custom input component that switches between reading and editing on the same page.",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -35,15 +35,17 @@
     }
   },
   "dependencies": {
-    "@atlaskit/analytics-next": "^9.2.0",
-    "@atlaskit/button": "^17.7.0",
+    "@atlaskit/analytics-next": "^9.3.0",
+    "@atlaskit/button": "^17.14.0",
     "@atlaskit/codemod-utils": "^4.2.0",
-    "@atlaskit/form": "^9.0.3",
+    "@atlaskit/form": "^9.3.0",
     "@atlaskit/icon": "^22.1.0",
     "@atlaskit/inline-dialog": "^14.0.0",
-    "@atlaskit/textfield": "^6.1.0",
-    "@atlaskit/theme": "^12.6.0",
-    "@atlaskit/tokens": "^1.42.0",
+    "@atlaskit/primitives": "^5.7.0",
+    "@atlaskit/textfield": "^6.3.0",
+    "@atlaskit/theme": "^12.7.0",
+    "@atlaskit/tokens": "^1.45.0",
+    "@atlaskit/visually-hidden": "^1.3.0",
     "@babel/runtime": "^7.0.0",
     "@emotion/react": "^11.7.1"
   },
@@ -53,15 +55,15 @@
   "devDependencies": {
     "@af/accessibility-testing": "*",
     "@af/integration-testing": "*",
-    "@atlaskit/datetime-picker": "^13.2.0",
+    "@atlaskit/datetime-picker": "^13.5.0",
     "@atlaskit/docs": "*",
-    "@atlaskit/ds-lib": "^2.2.0",
-    "@atlaskit/section-message": "^6.4.0",
-    "@atlaskit/select": "^17.3.0",
+    "@atlaskit/ds-lib": "^2.3.0",
+    "@atlaskit/section-message": "^6.5.0",
+    "@atlaskit/select": "^17.8.0",
     "@atlaskit/ssr": "*",
-    "@atlaskit/tag": "^12.0.0",
-    "@atlaskit/tag-group": "^10.2.0",
-    "@atlaskit/textarea": "^5.2.0",
+    "@atlaskit/tag": "^12.2.0",
+    "@atlaskit/tag-group": "^10.3.0",
+    "@atlaskit/textarea": "^5.4.0",
     "@atlaskit/visual-regression": "*",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
     "@emotion/styled": "^11.0.0",