@atlaskit/form 12.5.3 → 12.5.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,12 @@
1
1
  # @atlaskit/form
2
2
 
3
+ ## 12.5.4
4
+
5
+ ### Patch Changes
6
+
7
+ - [`281cc603f5925`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/281cc603f5925) -
8
+ Improve typing within checkbox field
9
+
3
10
  ## 12.5.3
4
11
 
5
12
  ### Patch Changes
@@ -14,9 +14,9 @@ var _react = _interopRequireWildcard(require("react"));
14
14
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
15
15
  var _field = _interopRequireDefault(require("./field"));
16
16
  var _excluded = ["children", "defaultIsChecked", "isDisabled", "isRequired", "label", "name", "value"],
17
- _excluded2 = ["value"],
17
+ _excluded2 = ["value", "onChange"],
18
18
  _excluded3 = ["fieldProps"],
19
- _excluded4 = ["value"],
19
+ _excluded4 = ["value", "onChange"],
20
20
  _excluded5 = ["fieldProps"];
21
21
  function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
22
22
  function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
@@ -45,46 +45,60 @@ var CheckboxField = function CheckboxField(_ref) {
45
45
  var currentValue = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : [];
46
46
  return defaultIsChecked && value !== undefined ? [].concat((0, _toConsumableArray2.default)(currentValue), [value]) : currentValue;
47
47
  }, [value, defaultIsChecked]);
48
- return value !== undefined ? /*#__PURE__*/_react.default.createElement(_field.default, (0, _extends2.default)({}, (0, _platformFeatureFlags.fg)('platform_design-system-team_checkbox-field-spread') ? {} : _objectSpread({}, rest), {
48
+ return value !== undefined ? /*#__PURE__*/_react.default.createElement(_field.default
49
+ // eslint-disable-next-line @repo/internal/react/no-unsafe-spread-props
50
+ , (0, _extends2.default)({}, (0, _platformFeatureFlags.fg)('platform_design-system-team_checkbox-field-spread') ? {} : _objectSpread({}, rest), {
49
51
  defaultValue: defaultValue,
50
52
  isDisabled: isDisabled,
51
53
  isRequired: isRequired,
52
54
  label: label,
53
55
  name: name,
54
56
  transform: function transform(event, currentValue) {
55
- return event.currentTarget.checked && currentValue ? [].concat((0, _toConsumableArray2.default)(currentValue), [value]) : currentValue.filter(function (v) {
57
+ return !Array.isArray(event) && event.currentTarget.checked && currentValue ? [].concat((0, _toConsumableArray2.default)(currentValue), [value]) : currentValue.filter(function (v) {
56
58
  return v !== value;
57
59
  });
58
60
  }
59
61
  }), function (_ref2) {
60
62
  var _ref2$fieldProps = _ref2.fieldProps,
61
63
  fieldValue = _ref2$fieldProps.value,
64
+ _onChange = _ref2$fieldProps.onChange,
62
65
  otherFieldProps = (0, _objectWithoutProperties2.default)(_ref2$fieldProps, _excluded2),
63
66
  others = (0, _objectWithoutProperties2.default)(_ref2, _excluded3);
64
67
  return children(_objectSpread({
65
68
  fieldProps: _objectSpread(_objectSpread({}, otherFieldProps), {}, {
69
+ // Setting to any because it's typed weirdly at the field level
70
+ onChange: function onChange(v) {
71
+ return _onChange(v);
72
+ },
66
73
  isChecked: !!fieldValue.find(function (v) {
67
74
  return v === value;
68
75
  }),
69
76
  value: value
70
77
  })
71
78
  }, others));
72
- }) : /*#__PURE__*/_react.default.createElement(_field.default, (0, _extends2.default)({}, (0, _platformFeatureFlags.fg)('platform_design-system-team_checkbox-field-spread') ? {} : _objectSpread({}, rest), {
79
+ }) : /*#__PURE__*/_react.default.createElement(_field.default
80
+ // eslint-disable-next-line @repo/internal/react/no-unsafe-spread-props
81
+ , (0, _extends2.default)({}, (0, _platformFeatureFlags.fg)('platform_design-system-team_checkbox-field-spread') ? {} : _objectSpread({}, rest), {
73
82
  defaultValue: defaultIsChecked,
74
83
  isDisabled: isDisabled,
75
84
  isRequired: isRequired,
76
85
  label: label,
77
86
  name: name,
78
87
  transform: function transform(event) {
79
- return event.currentTarget.checked;
88
+ return typeof event === 'boolean' ? event : event.currentTarget.checked;
80
89
  }
81
90
  }), function (_ref3) {
82
91
  var _ref3$fieldProps = _ref3.fieldProps,
83
92
  fieldValue = _ref3$fieldProps.value,
93
+ _onChange2 = _ref3$fieldProps.onChange,
84
94
  otherFieldProps = (0, _objectWithoutProperties2.default)(_ref3$fieldProps, _excluded4),
85
95
  others = (0, _objectWithoutProperties2.default)(_ref3, _excluded5);
86
96
  return children(_objectSpread({
87
97
  fieldProps: _objectSpread(_objectSpread({}, otherFieldProps), {}, {
98
+ // Setting to any because it's typed weirdly at the field level
99
+ onChange: function onChange(v) {
100
+ return _onChange2(v);
101
+ },
88
102
  isChecked: fieldValue,
89
103
  value: value
90
104
  })
@@ -23,7 +23,9 @@ const CheckboxField = ({
23
23
  }) => {
24
24
  // Maintains a memoised list of the default values
25
25
  const defaultValue = useCallback((currentValue = []) => defaultIsChecked && value !== undefined ? [...currentValue, value] : currentValue, [value, defaultIsChecked]);
26
- return value !== undefined ? /*#__PURE__*/React.createElement(Field, _extends({}, fg('platform_design-system-team_checkbox-field-spread') ? {} : {
26
+ return value !== undefined ? /*#__PURE__*/React.createElement(Field
27
+ // eslint-disable-next-line @repo/internal/react/no-unsafe-spread-props
28
+ , _extends({}, fg('platform_design-system-team_checkbox-field-spread') ? {} : {
27
29
  ...rest
28
30
  }, {
29
31
  defaultValue: defaultValue,
@@ -31,21 +33,26 @@ const CheckboxField = ({
31
33
  isRequired: isRequired,
32
34
  label: label,
33
35
  name: name,
34
- transform: (event, currentValue) => event.currentTarget.checked && currentValue ? [...currentValue, value] : currentValue.filter(v => v !== value)
36
+ transform: (event, currentValue) => !Array.isArray(event) && event.currentTarget.checked && currentValue ? [...currentValue, value] : currentValue.filter(v => v !== value)
35
37
  }), ({
36
38
  fieldProps: {
37
39
  value: fieldValue,
40
+ onChange,
38
41
  ...otherFieldProps
39
42
  },
40
43
  ...others
41
44
  }) => children({
42
45
  fieldProps: {
43
46
  ...otherFieldProps,
47
+ // Setting to any because it's typed weirdly at the field level
48
+ onChange: v => onChange(v),
44
49
  isChecked: !!fieldValue.find(v => v === value),
45
50
  value
46
51
  },
47
52
  ...others
48
- })) : /*#__PURE__*/React.createElement(Field, _extends({}, fg('platform_design-system-team_checkbox-field-spread') ? {} : {
53
+ })) : /*#__PURE__*/React.createElement(Field
54
+ // eslint-disable-next-line @repo/internal/react/no-unsafe-spread-props
55
+ , _extends({}, fg('platform_design-system-team_checkbox-field-spread') ? {} : {
49
56
  ...rest
50
57
  }, {
51
58
  defaultValue: defaultIsChecked,
@@ -53,16 +60,19 @@ const CheckboxField = ({
53
60
  isRequired: isRequired,
54
61
  label: label,
55
62
  name: name,
56
- transform: event => event.currentTarget.checked
63
+ transform: event => typeof event === 'boolean' ? event : event.currentTarget.checked
57
64
  }), ({
58
65
  fieldProps: {
59
66
  value: fieldValue,
67
+ onChange,
60
68
  ...otherFieldProps
61
69
  },
62
70
  ...others
63
71
  }) => children({
64
72
  fieldProps: {
65
73
  ...otherFieldProps,
74
+ // Setting to any because it's typed weirdly at the field level
75
+ onChange: v => onChange(v),
66
76
  isChecked: fieldValue,
67
77
  value
68
78
  },
@@ -3,9 +3,9 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
3
3
  import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
4
4
  import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
5
5
  var _excluded = ["children", "defaultIsChecked", "isDisabled", "isRequired", "label", "name", "value"],
6
- _excluded2 = ["value"],
6
+ _excluded2 = ["value", "onChange"],
7
7
  _excluded3 = ["fieldProps"],
8
- _excluded4 = ["value"],
8
+ _excluded4 = ["value", "onChange"],
9
9
  _excluded5 = ["fieldProps"];
10
10
  function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
11
11
  function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
@@ -36,46 +36,60 @@ var CheckboxField = function CheckboxField(_ref) {
36
36
  var currentValue = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : [];
37
37
  return defaultIsChecked && value !== undefined ? [].concat(_toConsumableArray(currentValue), [value]) : currentValue;
38
38
  }, [value, defaultIsChecked]);
39
- return value !== undefined ? /*#__PURE__*/React.createElement(Field, _extends({}, fg('platform_design-system-team_checkbox-field-spread') ? {} : _objectSpread({}, rest), {
39
+ return value !== undefined ? /*#__PURE__*/React.createElement(Field
40
+ // eslint-disable-next-line @repo/internal/react/no-unsafe-spread-props
41
+ , _extends({}, fg('platform_design-system-team_checkbox-field-spread') ? {} : _objectSpread({}, rest), {
40
42
  defaultValue: defaultValue,
41
43
  isDisabled: isDisabled,
42
44
  isRequired: isRequired,
43
45
  label: label,
44
46
  name: name,
45
47
  transform: function transform(event, currentValue) {
46
- return event.currentTarget.checked && currentValue ? [].concat(_toConsumableArray(currentValue), [value]) : currentValue.filter(function (v) {
48
+ return !Array.isArray(event) && event.currentTarget.checked && currentValue ? [].concat(_toConsumableArray(currentValue), [value]) : currentValue.filter(function (v) {
47
49
  return v !== value;
48
50
  });
49
51
  }
50
52
  }), function (_ref2) {
51
53
  var _ref2$fieldProps = _ref2.fieldProps,
52
54
  fieldValue = _ref2$fieldProps.value,
55
+ _onChange = _ref2$fieldProps.onChange,
53
56
  otherFieldProps = _objectWithoutProperties(_ref2$fieldProps, _excluded2),
54
57
  others = _objectWithoutProperties(_ref2, _excluded3);
55
58
  return children(_objectSpread({
56
59
  fieldProps: _objectSpread(_objectSpread({}, otherFieldProps), {}, {
60
+ // Setting to any because it's typed weirdly at the field level
61
+ onChange: function onChange(v) {
62
+ return _onChange(v);
63
+ },
57
64
  isChecked: !!fieldValue.find(function (v) {
58
65
  return v === value;
59
66
  }),
60
67
  value: value
61
68
  })
62
69
  }, others));
63
- }) : /*#__PURE__*/React.createElement(Field, _extends({}, fg('platform_design-system-team_checkbox-field-spread') ? {} : _objectSpread({}, rest), {
70
+ }) : /*#__PURE__*/React.createElement(Field
71
+ // eslint-disable-next-line @repo/internal/react/no-unsafe-spread-props
72
+ , _extends({}, fg('platform_design-system-team_checkbox-field-spread') ? {} : _objectSpread({}, rest), {
64
73
  defaultValue: defaultIsChecked,
65
74
  isDisabled: isDisabled,
66
75
  isRequired: isRequired,
67
76
  label: label,
68
77
  name: name,
69
78
  transform: function transform(event) {
70
- return event.currentTarget.checked;
79
+ return typeof event === 'boolean' ? event : event.currentTarget.checked;
71
80
  }
72
81
  }), function (_ref3) {
73
82
  var _ref3$fieldProps = _ref3.fieldProps,
74
83
  fieldValue = _ref3$fieldProps.value,
84
+ _onChange2 = _ref3$fieldProps.onChange,
75
85
  otherFieldProps = _objectWithoutProperties(_ref3$fieldProps, _excluded4),
76
86
  others = _objectWithoutProperties(_ref3, _excluded5);
77
87
  return children(_objectSpread({
78
88
  fieldProps: _objectSpread(_objectSpread({}, otherFieldProps), {}, {
89
+ // Setting to any because it's typed weirdly at the field level
90
+ onChange: function onChange(v) {
91
+ return _onChange2(v);
92
+ },
79
93
  isChecked: fieldValue,
80
94
  value: value
81
95
  })
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/form",
3
- "version": "12.5.3",
3
+ "version": "12.5.4",
4
4
  "description": "A form allows users to input information.",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"