@atlaskit/flag 14.5.9 → 14.6.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,16 @@
1
1
  # @atlaskit/flag
2
2
 
3
+ ## 14.6.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [`379b0a864df`](https://bitbucket.org/atlassian/atlassian-frontend/commits/379b0a864df) - [ux] Remove truncation of titles and wrap text instead. Very slightly changed title text positioning.
8
+
9
+ ### Patch Changes
10
+
11
+ - [`f16146d83ff`](https://bitbucket.org/atlassian/atlassian-frontend/commits/f16146d83ff) - [ux] Fix cross icon positioning
12
+ - Updated dependencies
13
+
3
14
  ## 14.5.9
4
15
 
5
16
  ### Patch Changes
@@ -26,7 +26,7 @@ function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "functio
26
26
  function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
27
27
 
28
28
  var packageName = "@atlaskit/flag";
29
- var packageVersion = "14.5.9";
29
+ var packageVersion = "14.6.0";
30
30
  var AUTO_DISMISS_SECONDS = 8;
31
31
  exports.AUTO_DISMISS_SECONDS = AUTO_DISMISS_SECONDS;
32
32
 
package/dist/cjs/flag.js CHANGED
@@ -44,15 +44,19 @@ function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { va
44
44
  var analyticsAttributes = {
45
45
  componentName: 'flag',
46
46
  packageName: "@atlaskit/flag",
47
- packageVersion: "14.5.9"
47
+ packageVersion: "14.6.0"
48
48
  };
49
49
  var gridSize = (0, _constants.gridSize)();
50
50
  var doubleGridSize = gridSize * 2;
51
- var headerHeight = gridSize * 4;
52
- var iconStyles = (0, _core.css)({
51
+ var titleGroupStyles = (0, _core.css)({
53
52
  display: 'flex',
54
- height: headerHeight,
55
- alignItems: 'center'
53
+ alignItems: 'start'
54
+ });
55
+ var iconTitleStyles = (0, _core.css)({
56
+ display: 'flex',
57
+ paddingTop: "".concat(gridSize / 2, "px"),
58
+ alignItems: 'start',
59
+ flex: 1
56
60
  });
57
61
  var flagHeaderStyles = (0, _core.css)({
58
62
  boxSizing: 'border-box',
@@ -171,10 +175,12 @@ var Flag = function Flag(props) {
171
175
  style: {
172
176
  color: iconColor
173
177
  },
174
- css: iconStyles
178
+ css: titleGroupStyles
179
+ }, (0, _core.jsx)("div", {
180
+ css: iconTitleStyles
175
181
  }, icon, (0, _core.jsx)(_internal.Title, {
176
182
  color: textColor
177
- }, title), isDismissable ? !(isBold && !description && !actions.length) && (0, _core.jsx)(_internal.DismissButton, {
183
+ }, title)), isDismissable ? !(isBold && !description && !actions.length) && (0, _core.jsx)(_internal.DismissButton, {
178
184
  testId: testId,
179
185
  appearance: appearance,
180
186
  isBold: isBold,
@@ -185,7 +191,8 @@ var Flag = function Flag(props) {
185
191
  testId: testId
186
192
  }, description && (0, _core.jsx)(_internal.Description, {
187
193
  testId: testId && "".concat(testId, "-description"),
188
- color: textColor
194
+ color: textColor,
195
+ isBold: isBold
189
196
  }, description), (0, _core.jsx)(_flagActions.default, {
190
197
  actions: actions,
191
198
  appearance: appearance,
@@ -9,8 +9,8 @@ var _core = require("@emotion/core");
9
9
 
10
10
  /** @jsx jsx */
11
11
  var descriptionStyles = (0, _core.css)({
12
- /* height is defined as 5 lines maximum by design */
13
12
  maxHeight: 100,
13
+ // height is defined as 5 lines maximum by design
14
14
  overflow: 'auto',
15
15
  wordWrap: 'break-word'
16
16
  });
@@ -18,12 +18,13 @@ var descriptionStyles = (0, _core.css)({
18
18
  var Description = function Description(_ref) {
19
19
  var color = _ref.color,
20
20
  testId = _ref.testId,
21
- children = _ref.children;
21
+ children = _ref.children,
22
+ isBold = _ref.isBold;
22
23
  return (0, _core.jsx)("div", {
23
24
  style: {
24
25
  color: color
25
26
  },
26
- css: descriptionStyles,
27
+ css: [descriptionStyles],
27
28
  "data-testid": testId
28
29
  }, children);
29
30
  };
@@ -40,6 +40,9 @@ var dismissButtonStyles = (0, _core.css)({
40
40
  lineHeight: '1',
41
41
  whiteSpace: 'nowrap'
42
42
  });
43
+ var crossIconStyles = (0, _core.css)({
44
+ paddingTop: "".concat(gridSize, "px")
45
+ });
43
46
 
44
47
  var DismissButton = function DismissButton(_ref) {
45
48
  var appearance = _ref.appearance,
@@ -67,7 +70,7 @@ var DismissButton = function DismissButton(_ref) {
67
70
  style: {
68
71
  color: (0, _theme.getFlagTextColor)(appearance, mode)
69
72
  },
70
- css: dismissButtonStyles,
73
+ css: [dismissButtonStyles, !isBold && crossIconStyles],
71
74
  onClick: onClick,
72
75
  "data-testid": buttonTestId,
73
76
  type: "button",
@@ -12,7 +12,8 @@ var _motion = require("@atlaskit/motion");
12
12
  var _constants = require("@atlaskit/theme/constants");
13
13
 
14
14
  /** @jsx jsx */
15
- var paddingLeft = (0, _constants.gridSize)() * 5;
15
+ var gridSize = (0, _constants.gridSize)();
16
+ var paddingLeft = gridSize * 5;
16
17
  var expanderStyles = (0, _core.css)({
17
18
  display: 'flex',
18
19
  minWidth: 0,
@@ -9,12 +9,9 @@ var _core = require("@emotion/core");
9
9
 
10
10
  /** @jsx jsx */
11
11
  var titleStyles = (0, _core.css)({
12
- padding: "0 0 0 16px",
12
+ padding: "2px 0 6px 16px",
13
13
  flex: 1,
14
- fontWeight: 600,
15
- overflow: 'hidden',
16
- textOverflow: 'ellipsis',
17
- whiteSpace: 'nowrap'
14
+ fontWeight: 600
18
15
  });
19
16
 
20
17
  var Title = function Title(_ref) {
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "name": "@atlaskit/flag",
3
- "version": "14.5.9",
3
+ "version": "14.6.0",
4
4
  "sideEffects": false
5
5
  }
@@ -5,7 +5,7 @@ import noop from '@atlaskit/ds-lib/noop';
5
5
  import Flag from './flag';
6
6
  import { useFlagGroup } from './flag-group';
7
7
  const packageName = "@atlaskit/flag";
8
- const packageVersion = "14.5.9";
8
+ const packageVersion = "14.6.0";
9
9
  export const AUTO_DISMISS_SECONDS = 8;
10
10
 
11
11
  const AutoDismissFlag = props => {
@@ -16,15 +16,19 @@ import { Title, Description, Expander, DismissButton } from './internal';
16
16
  const analyticsAttributes = {
17
17
  componentName: 'flag',
18
18
  packageName: "@atlaskit/flag",
19
- packageVersion: "14.5.9"
19
+ packageVersion: "14.6.0"
20
20
  };
21
21
  const gridSize = getGridSize();
22
22
  const doubleGridSize = gridSize * 2;
23
- const headerHeight = gridSize * 4;
24
- const iconStyles = css({
23
+ const titleGroupStyles = css({
25
24
  display: 'flex',
26
- height: headerHeight,
27
- alignItems: 'center'
25
+ alignItems: 'start'
26
+ });
27
+ const iconTitleStyles = css({
28
+ display: 'flex',
29
+ paddingTop: `${gridSize / 2}px`,
30
+ alignItems: 'start',
31
+ flex: 1
28
32
  });
29
33
  const flagHeaderStyles = css({
30
34
  boxSizing: 'border-box',
@@ -134,10 +138,12 @@ const Flag = props => {
134
138
  style: {
135
139
  color: iconColor
136
140
  },
137
- css: iconStyles
141
+ css: titleGroupStyles
142
+ }, jsx("div", {
143
+ css: iconTitleStyles
138
144
  }, icon, jsx(Title, {
139
145
  color: textColor
140
- }, title), isDismissable ? !(isBold && !description && !actions.length) && jsx(DismissButton, {
146
+ }, title)), isDismissable ? !(isBold && !description && !actions.length) && jsx(DismissButton, {
141
147
  testId: testId,
142
148
  appearance: appearance,
143
149
  isBold: isBold,
@@ -148,7 +154,8 @@ const Flag = props => {
148
154
  testId: testId
149
155
  }, description && jsx(Description, {
150
156
  testId: testId && `${testId}-description`,
151
- color: textColor
157
+ color: textColor,
158
+ isBold: isBold
152
159
  }, description), jsx(Actions, {
153
160
  actions: actions,
154
161
  appearance: appearance,
@@ -1,8 +1,8 @@
1
1
  /** @jsx jsx */
2
2
  import { jsx, css } from '@emotion/core';
3
3
  const descriptionStyles = css({
4
- /* height is defined as 5 lines maximum by design */
5
4
  maxHeight: 100,
5
+ // height is defined as 5 lines maximum by design
6
6
  overflow: 'auto',
7
7
  wordWrap: 'break-word'
8
8
  });
@@ -10,12 +10,13 @@ const descriptionStyles = css({
10
10
  const Description = ({
11
11
  color,
12
12
  testId,
13
- children
13
+ children,
14
+ isBold
14
15
  }) => jsx("div", {
15
16
  style: {
16
17
  color
17
18
  },
18
- css: descriptionStyles,
19
+ css: [descriptionStyles],
19
20
  "data-testid": testId
20
21
  }, children);
21
22
 
@@ -22,6 +22,9 @@ const dismissButtonStyles = css({
22
22
  lineHeight: '1',
23
23
  whiteSpace: 'nowrap'
24
24
  });
25
+ const crossIconStyles = css({
26
+ paddingTop: `${gridSize}px`
27
+ });
25
28
 
26
29
  const DismissButton = ({
27
30
  appearance,
@@ -49,7 +52,7 @@ const DismissButton = ({
49
52
  style: {
50
53
  color: getFlagTextColor(appearance, mode)
51
54
  },
52
- css: dismissButtonStyles,
55
+ css: [dismissButtonStyles, !isBold && crossIconStyles],
53
56
  onClick: onClick,
54
57
  "data-testid": buttonTestId,
55
58
  type: "button",
@@ -1,8 +1,9 @@
1
1
  /** @jsx jsx */
2
2
  import { css, jsx } from '@emotion/core';
3
3
  import { ExitingPersistence, FadeIn } from '@atlaskit/motion';
4
- import { gridSize } from '@atlaskit/theme/constants';
5
- const paddingLeft = gridSize() * 5;
4
+ import { gridSize as getGridSize } from '@atlaskit/theme/constants';
5
+ const gridSize = getGridSize();
6
+ const paddingLeft = gridSize * 5;
6
7
  const expanderStyles = css({
7
8
  display: 'flex',
8
9
  minWidth: 0,
@@ -1,12 +1,9 @@
1
1
  /** @jsx jsx */
2
2
  import { jsx, css } from '@emotion/core';
3
3
  const titleStyles = css({
4
- padding: `0 0 0 16px`,
4
+ padding: `2px 0 6px 16px`,
5
5
  flex: 1,
6
- fontWeight: 600,
7
- overflow: 'hidden',
8
- textOverflow: 'ellipsis',
9
- whiteSpace: 'nowrap'
6
+ fontWeight: 600
10
7
  });
11
8
 
12
9
  const Title = ({
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "name": "@atlaskit/flag",
3
- "version": "14.5.9",
3
+ "version": "14.6.0",
4
4
  "sideEffects": false
5
5
  }
@@ -5,7 +5,7 @@ import noop from '@atlaskit/ds-lib/noop';
5
5
  import Flag from './flag';
6
6
  import { useFlagGroup } from './flag-group';
7
7
  var packageName = "@atlaskit/flag";
8
- var packageVersion = "14.5.9";
8
+ var packageVersion = "14.6.0";
9
9
  export var AUTO_DISMISS_SECONDS = 8;
10
10
 
11
11
  var AutoDismissFlag = function AutoDismissFlag(props) {
package/dist/esm/flag.js CHANGED
@@ -22,15 +22,19 @@ import { Title, Description, Expander, DismissButton } from './internal';
22
22
  var analyticsAttributes = {
23
23
  componentName: 'flag',
24
24
  packageName: "@atlaskit/flag",
25
- packageVersion: "14.5.9"
25
+ packageVersion: "14.6.0"
26
26
  };
27
27
  var gridSize = getGridSize();
28
28
  var doubleGridSize = gridSize * 2;
29
- var headerHeight = gridSize * 4;
30
- var iconStyles = css({
29
+ var titleGroupStyles = css({
31
30
  display: 'flex',
32
- height: headerHeight,
33
- alignItems: 'center'
31
+ alignItems: 'start'
32
+ });
33
+ var iconTitleStyles = css({
34
+ display: 'flex',
35
+ paddingTop: "".concat(gridSize / 2, "px"),
36
+ alignItems: 'start',
37
+ flex: 1
34
38
  });
35
39
  var flagHeaderStyles = css({
36
40
  boxSizing: 'border-box',
@@ -149,10 +153,12 @@ var Flag = function Flag(props) {
149
153
  style: {
150
154
  color: iconColor
151
155
  },
152
- css: iconStyles
156
+ css: titleGroupStyles
157
+ }, jsx("div", {
158
+ css: iconTitleStyles
153
159
  }, icon, jsx(Title, {
154
160
  color: textColor
155
- }, title), isDismissable ? !(isBold && !description && !actions.length) && jsx(DismissButton, {
161
+ }, title)), isDismissable ? !(isBold && !description && !actions.length) && jsx(DismissButton, {
156
162
  testId: testId,
157
163
  appearance: appearance,
158
164
  isBold: isBold,
@@ -163,7 +169,8 @@ var Flag = function Flag(props) {
163
169
  testId: testId
164
170
  }, description && jsx(Description, {
165
171
  testId: testId && "".concat(testId, "-description"),
166
- color: textColor
172
+ color: textColor,
173
+ isBold: isBold
167
174
  }, description), jsx(Actions, {
168
175
  actions: actions,
169
176
  appearance: appearance,
@@ -1,8 +1,8 @@
1
1
  /** @jsx jsx */
2
2
  import { jsx, css } from '@emotion/core';
3
3
  var descriptionStyles = css({
4
- /* height is defined as 5 lines maximum by design */
5
4
  maxHeight: 100,
5
+ // height is defined as 5 lines maximum by design
6
6
  overflow: 'auto',
7
7
  wordWrap: 'break-word'
8
8
  });
@@ -10,12 +10,13 @@ var descriptionStyles = css({
10
10
  var Description = function Description(_ref) {
11
11
  var color = _ref.color,
12
12
  testId = _ref.testId,
13
- children = _ref.children;
13
+ children = _ref.children,
14
+ isBold = _ref.isBold;
14
15
  return jsx("div", {
15
16
  style: {
16
17
  color: color
17
18
  },
18
- css: descriptionStyles,
19
+ css: [descriptionStyles],
19
20
  "data-testid": testId
20
21
  }, children);
21
22
  };
@@ -22,6 +22,9 @@ var dismissButtonStyles = css({
22
22
  lineHeight: '1',
23
23
  whiteSpace: 'nowrap'
24
24
  });
25
+ var crossIconStyles = css({
26
+ paddingTop: "".concat(gridSize, "px")
27
+ });
25
28
 
26
29
  var DismissButton = function DismissButton(_ref) {
27
30
  var appearance = _ref.appearance,
@@ -49,7 +52,7 @@ var DismissButton = function DismissButton(_ref) {
49
52
  style: {
50
53
  color: getFlagTextColor(appearance, mode)
51
54
  },
52
- css: dismissButtonStyles,
55
+ css: [dismissButtonStyles, !isBold && crossIconStyles],
53
56
  onClick: onClick,
54
57
  "data-testid": buttonTestId,
55
58
  type: "button",
@@ -1,8 +1,9 @@
1
1
  /** @jsx jsx */
2
2
  import { css, jsx } from '@emotion/core';
3
3
  import { ExitingPersistence, FadeIn } from '@atlaskit/motion';
4
- import { gridSize } from '@atlaskit/theme/constants';
5
- var paddingLeft = gridSize() * 5;
4
+ import { gridSize as getGridSize } from '@atlaskit/theme/constants';
5
+ var gridSize = getGridSize();
6
+ var paddingLeft = gridSize * 5;
6
7
  var expanderStyles = css({
7
8
  display: 'flex',
8
9
  minWidth: 0,
@@ -1,12 +1,9 @@
1
1
  /** @jsx jsx */
2
2
  import { jsx, css } from '@emotion/core';
3
3
  var titleStyles = css({
4
- padding: "0 0 0 16px",
4
+ padding: "2px 0 6px 16px",
5
5
  flex: 1,
6
- fontWeight: 600,
7
- overflow: 'hidden',
8
- textOverflow: 'ellipsis',
9
- whiteSpace: 'nowrap'
6
+ fontWeight: 600
10
7
  });
11
8
 
12
9
  var Title = function Title(_ref) {
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "name": "@atlaskit/flag",
3
- "version": "14.5.9",
3
+ "version": "14.6.0",
4
4
  "sideEffects": false
5
5
  }
@@ -2,6 +2,7 @@ import { FC } from 'react';
2
2
  interface DescriptionProps {
3
3
  testId?: string;
4
4
  color: string;
5
+ isBold: boolean;
5
6
  }
6
7
  declare const Description: FC<DescriptionProps>;
7
8
  export default Description;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/flag",
3
- "version": "14.5.9",
3
+ "version": "14.6.0",
4
4
  "description": "A flag is used for confirmations, alerts, and acknowledgments that require minimal user interaction, often displayed using a flag group.",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -19,13 +19,14 @@
19
19
  "deprecatedAutoEntryPoints": true,
20
20
  "releaseModel": "scheduled",
21
21
  "website": {
22
- "name": "Flag"
22
+ "name": "Flag",
23
+ "category": "Components"
23
24
  }
24
25
  },
25
26
  "dependencies": {
26
27
  "@atlaskit/analytics-next": "^8.0.0",
27
28
  "@atlaskit/button": "^16.3.0",
28
- "@atlaskit/ds-lib": "^1.4.0",
29
+ "@atlaskit/ds-lib": "^2.0.0",
29
30
  "@atlaskit/focus-ring": "^1.0.0",
30
31
  "@atlaskit/icon": "^21.10.0",
31
32
  "@atlaskit/motion": "^1.1.0",
@@ -62,6 +63,7 @@
62
63
  ],
63
64
  "techstack": {
64
65
  "@repo/internal": {
66
+ "dom-events": "use-bind-event-listener",
65
67
  "ui-components": [
66
68
  "lite-mode"
67
69
  ],