@atlaskit/feedback-collector 15.4.0 → 15.5.0

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @atlaskit/feedback-collector
 
+## 15.5.0
+
+### Minor Changes
+
+- [`7bbde375a3b30`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/7bbde375a3b30) -
+  Add onCancel callback to FeedbackCollector and FeedbackForm
+
 ## 15.4.0
 
 ### Minor Changes

package/dist/cjs/components/FeedbackCollector.js

@@ -164,7 +164,7 @@ var FeedbackCollector = exports.default = /*#__PURE__*/function (_Component) {
   }, {
     key: "getPackageVersion",
     value: function getPackageVersion() {
-      return "15.3.0" || 'Unknown, at least 11.0.0';
+      return "15.4.0" || 'Unknown, at least 11.0.0';
     }
   }, {
     key: "getEntitlementInformation",

package/dist/cjs/components/FeedbackForm.js

@@ -100,9 +100,16 @@ var FeedbackForm = function FeedbackForm(_ref2) {
   var isTypeSelected = function isTypeSelected() {
     return type !== 'empty';
   };
+
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   var handleCancel = function handleCancel() {
-    onCancel === null || onCancel === void 0 || onCancel();
-    onClose();
+    for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
+      args[_key] = arguments[_key];
+    }
+    onCancel === null || onCancel === void 0 || onCancel.apply(void 0, args);
+    // Forward every arg the click handler received so consumers retain the full
+    // pre-change runtime contract (originating event + Atlaskit UI analytics event).
+    onClose.apply(void 0, args);
   };
   var canShowTextField = isTypeSelected() || !showTypeField;
   var hasDescription = description || hasDescriptionDefaultValue;

package/dist/es2019/components/FeedbackCollector.js

@@ -92,7 +92,7 @@ export default class FeedbackCollector extends Component {
     return FeedbackCollector.defaultProps.url;
   }
   getPackageVersion() {
-    return "15.3.0" || 'Unknown, at least 11.0.0';
+    return "15.4.0" || 'Unknown, at least 11.0.0';
   }
   async getEntitlementInformation() {
     var _entitlementDetails, _entitlementDetails2, _productName, _entitlement, _productEntitlement;

package/dist/es2019/components/FeedbackForm.js

@@ -60,9 +60,13 @@ const FeedbackForm = ({
     formatMessage
   } = useIntl();
   const isTypeSelected = () => type !== 'empty';
-  const handleCancel = () => {
-    onCancel === null || onCancel === void 0 ? void 0 : onCancel();
-    onClose();
+
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  const handleCancel = (...args) => {
+    onCancel === null || onCancel === void 0 ? void 0 : onCancel(...args);
+    // Forward every arg the click handler received so consumers retain the full
+    // pre-change runtime contract (originating event + Atlaskit UI analytics event).
+    onClose(...args);
   };
   const canShowTextField = isTypeSelected() || !showTypeField;
   const hasDescription = description || hasDescriptionDefaultValue;

package/dist/esm/components/FeedbackCollector.js

@@ -155,7 +155,7 @@ var FeedbackCollector = /*#__PURE__*/function (_Component) {
   }, {
     key: "getPackageVersion",
     value: function getPackageVersion() {
-      return "15.3.0" || 'Unknown, at least 11.0.0';
+      return "15.4.0" || 'Unknown, at least 11.0.0';
     }
   }, {
     key: "getEntitlementInformation",

package/dist/esm/components/FeedbackForm.js

@@ -91,9 +91,16 @@ var FeedbackForm = function FeedbackForm(_ref2) {
   var isTypeSelected = function isTypeSelected() {
     return type !== 'empty';
   };
+
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   var handleCancel = function handleCancel() {
-    onCancel === null || onCancel === void 0 || onCancel();
-    onClose();
+    for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
+      args[_key] = arguments[_key];
+    }
+    onCancel === null || onCancel === void 0 || onCancel.apply(void 0, args);
+    // Forward every arg the click handler received so consumers retain the full
+    // pre-change runtime contract (originating event + Atlaskit UI analytics event).
+    onClose.apply(void 0, args);
   };
   var canShowTextField = isTypeSelected() || !showTypeField;
   var hasDescription = description || hasDescriptionDefaultValue;

package/dist/types/components/FeedbackCollector.d.ts

@@ -86,10 +86,16 @@ export interface Props {
     cancelButtonLabel?: string;
     /**  Message for select option labels and field labels */
     feedbackGroupLabels?: Partial<Record<SelectValue, SelectOptionDetails>>;
-    /** Function that will be called to initiate the exit transition. */
-    onClose: () => void;
+    /**
+     * Function that will be called to initiate the exit transition.
+     * When triggered by the cancel button the originating event and Atlaskit UI analytics
+     * event are forwarded; programmatic close paths (e.g. after submit) invoke it with no
+     * arguments. Typed as a variadic `any[]` to maximise backward compatibility with
+     * consumers that declared any conceivable signature for this callback.
+     */
+    onClose: (...args: any[]) => void;
     /** Optional function that will be called when the cancel button is clicked, in addition to onClose. */
-    onCancel?: () => void;
+    onCancel?: (...args: any[]) => void;
     /** Function that will be called optimistically after a delay when the feedback is submitted. */
     onSubmit: (formFields: FormFields) => void;
     /**  Locale for i18n */
@@ -168,7 +174,7 @@ export default class FeedbackCollector extends Component<Props> {
         showTypeField: boolean;
         showDefaultTextFields: boolean;
         anonymousFeedback: boolean;
-        onClose: () => void;
+        onClose: (...args: any[]) => void;
         onSubmit: () => void;
     };
     getGatewayUrl(): string;

package/dist/types/components/FeedbackForm.d.ts

@@ -27,10 +27,16 @@ interface Props {
     cancelButtonLabel?: string;
     /**  Message for select option labels and field labels **/
     feedbackGroupLabels?: Partial<Record<SelectValue, SelectOptionDetails>>;
-    /** Function that will be called to initiate the exit transition. */
-    onClose: () => void;
+    /**
+     * Function that will be called to initiate the exit transition.
+     * When triggered by the cancel button the originating event and Atlaskit UI analytics
+     * event are forwarded; programmatic close paths (e.g. after submit) invoke it with no
+     * arguments. Typed as a variadic `any[]` to maximise backward compatibility with
+     * consumers that declared any conceivable signature for this callback.
+     */
+    onClose: (...args: any[]) => void;
     /** Optional function that will be called when the cancel button is clicked, in addition to onClose. */
-    onCancel?: () => void;
+    onCancel?: (...args: any[]) => void;
     /** Function that will be called immediately after the submit action  */
     onSubmit: (formValues: FormFields) => Promise<void>;
     /**  Optional locale for i18n **/

package/dist/types-ts4.5/components/FeedbackCollector.d.ts

@@ -86,10 +86,16 @@ export interface Props {
     cancelButtonLabel?: string;
     /**  Message for select option labels and field labels */
     feedbackGroupLabels?: Partial<Record<SelectValue, SelectOptionDetails>>;
-    /** Function that will be called to initiate the exit transition. */
-    onClose: () => void;
+    /**
+     * Function that will be called to initiate the exit transition.
+     * When triggered by the cancel button the originating event and Atlaskit UI analytics
+     * event are forwarded; programmatic close paths (e.g. after submit) invoke it with no
+     * arguments. Typed as a variadic `any[]` to maximise backward compatibility with
+     * consumers that declared any conceivable signature for this callback.
+     */
+    onClose: (...args: any[]) => void;
     /** Optional function that will be called when the cancel button is clicked, in addition to onClose. */
-    onCancel?: () => void;
+    onCancel?: (...args: any[]) => void;
     /** Function that will be called optimistically after a delay when the feedback is submitted. */
     onSubmit: (formFields: FormFields) => void;
     /**  Locale for i18n */
@@ -168,7 +174,7 @@ export default class FeedbackCollector extends Component<Props> {
         showTypeField: boolean;
         showDefaultTextFields: boolean;
         anonymousFeedback: boolean;
-        onClose: () => void;
+        onClose: (...args: any[]) => void;
         onSubmit: () => void;
     };
     getGatewayUrl(): string;

package/dist/types-ts4.5/components/FeedbackForm.d.ts

@@ -27,10 +27,16 @@ interface Props {
     cancelButtonLabel?: string;
     /**  Message for select option labels and field labels **/
     feedbackGroupLabels?: Partial<Record<SelectValue, SelectOptionDetails>>;
-    /** Function that will be called to initiate the exit transition. */
-    onClose: () => void;
+    /**
+     * Function that will be called to initiate the exit transition.
+     * When triggered by the cancel button the originating event and Atlaskit UI analytics
+     * event are forwarded; programmatic close paths (e.g. after submit) invoke it with no
+     * arguments. Typed as a variadic `any[]` to maximise backward compatibility with
+     * consumers that declared any conceivable signature for this callback.
+     */
+    onClose: (...args: any[]) => void;
     /** Optional function that will be called when the cancel button is clicked, in addition to onClose. */
-    onCancel?: () => void;
+    onCancel?: (...args: any[]) => void;
     /** Function that will be called immediately after the submit action  */
     onSubmit: (formValues: FormFields) => Promise<void>;
     /**  Optional locale for i18n **/

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/feedback-collector",
-	"version": "15.4.0",
+	"version": "15.5.0",
 	"description": "A component that collects feedback across Atlassian products.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -44,7 +44,7 @@
 		"@atlaskit/section-message": "^8.13.0",
 		"@atlaskit/select": "^21.12.0",
 		"@atlaskit/textarea": "^8.3.0",
-		"@atlaskit/tokens": "^13.2.0",
+		"@atlaskit/tokens": "^13.3.0",
 		"@babel/runtime": "^7.0.0"
 	},
 	"peerDependencies": {