@atlaskit/eslint-plugin-ui-styling-standard 2.1.2 → 2.1.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +16 -0
- package/README.md +18 -18
- package/dist/cjs/rules/no-important-styles/index.js +79 -99
- package/dist/cjs/rules/no-nested-selectors/index.js +48 -36
- package/dist/cjs/rules/no-unsafe-selectors/index.js +88 -87
- package/dist/cjs/rules/no-unsafe-selectors/lint-selector.js +140 -101
- package/dist/cjs/rules/no-unsafe-selectors/walk-css-map.js +20 -50
- package/dist/cjs/rules/utils/create-rule-with-typed-config.js +29 -10
- package/dist/cjs/rules/utils/is-simple-selector.js +70 -0
- package/dist/cjs/rules/utils/parse-selector.js +30 -0
- package/dist/cjs/rules/utils/style-calls.js +127 -0
- package/dist/cjs/rules/utils/walk-style-call-properties.js +50 -0
- package/dist/es2019/rules/no-important-styles/index.js +79 -70
- package/dist/es2019/rules/no-nested-selectors/index.js +38 -36
- package/dist/es2019/rules/no-unsafe-selectors/index.js +68 -89
- package/dist/es2019/rules/no-unsafe-selectors/lint-selector.js +29 -23
- package/dist/es2019/rules/no-unsafe-selectors/walk-css-map.js +4 -30
- package/dist/es2019/rules/utils/create-rule-with-typed-config.js +30 -10
- package/dist/es2019/rules/utils/is-simple-selector.js +63 -0
- package/dist/es2019/rules/utils/parse-selector.js +23 -0
- package/dist/es2019/rules/utils/style-calls.js +89 -0
- package/dist/es2019/rules/utils/walk-style-call-properties.js +23 -0
- package/dist/esm/rules/no-important-styles/index.js +80 -100
- package/dist/esm/rules/no-nested-selectors/index.js +48 -34
- package/dist/esm/rules/no-unsafe-selectors/index.js +89 -87
- package/dist/esm/rules/no-unsafe-selectors/lint-selector.js +141 -102
- package/dist/esm/rules/no-unsafe-selectors/walk-css-map.js +19 -49
- package/dist/esm/rules/utils/create-rule-with-typed-config.js +30 -10
- package/dist/esm/rules/utils/is-simple-selector.js +64 -0
- package/dist/esm/rules/utils/parse-selector.js +23 -0
- package/dist/esm/rules/utils/style-calls.js +120 -0
- package/dist/esm/rules/utils/walk-style-call-properties.js +44 -0
- package/dist/types/rules/no-unsafe-selectors/constants.d.ts +1 -1
- package/dist/types/rules/no-unsafe-selectors/walk-css-map.d.ts +1 -7
- package/dist/types/rules/utils/create-rule-with-typed-config.d.ts +1 -1
- package/dist/types/rules/utils/is-simple-selector.d.ts +11 -0
- package/dist/types/rules/utils/parse-selector.d.ts +9 -0
- package/dist/types/rules/utils/style-calls.d.ts +17 -0
- package/dist/types/rules/utils/walk-style-call-properties.d.ts +5 -0
- package/package.json +3 -3
|
@@ -1,24 +1,26 @@
|
|
|
1
1
|
"use strict";
|
|
2
2
|
|
|
3
|
-
var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
|
|
4
3
|
Object.defineProperty(exports, "__esModule", {
|
|
5
4
|
value: true
|
|
6
5
|
});
|
|
7
6
|
exports.default = void 0;
|
|
8
|
-
var _postcssSelectorParser = _interopRequireDefault(require("postcss-selector-parser"));
|
|
9
|
-
var _contextCompat = require("@atlaskit/eslint-utils/context-compat");
|
|
10
|
-
var _isSupportedImport = require("@atlaskit/eslint-utils/is-supported-import");
|
|
11
7
|
var _schema = require("@atlaskit/eslint-utils/schema");
|
|
12
|
-
var _walkStyleProperties = require("@atlaskit/eslint-utils/walk-style-properties");
|
|
13
8
|
var _createRuleWithTypedConfig = require("../utils/create-rule-with-typed-config");
|
|
9
|
+
var _isSimpleSelector = require("../utils/is-simple-selector");
|
|
10
|
+
var _parseSelector = require("../utils/parse-selector");
|
|
11
|
+
var _styleCalls = require("../utils/style-calls");
|
|
12
|
+
var _walkStyleCallProperties = require("../utils/walk-style-call-properties");
|
|
14
13
|
var _lintSelector = require("./lint-selector");
|
|
15
14
|
var _walkCssMap = require("./walk-css-map");
|
|
15
|
+
var _constants = require("./constants");
|
|
16
|
+
function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
|
|
17
|
+
function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
|
|
18
|
+
function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
|
|
16
19
|
var ignoredAtRules = new Set(['@container',
|
|
17
20
|
// ignored because it's covered by `no-container-queries`
|
|
18
21
|
'@media',
|
|
19
22
|
// ignored because it's covered by `no-nested-styles`
|
|
20
23
|
'@supports', '@property', '@starting-style']);
|
|
21
|
-
var cssSelectorProcessor = (0, _postcssSelectorParser.default)();
|
|
22
24
|
var rule = (0, _createRuleWithTypedConfig.createLintRuleWithTypedConfig)({
|
|
23
25
|
meta: {
|
|
24
26
|
name: 'no-unsafe-selectors',
|
|
@@ -64,93 +66,92 @@ var rule = (0, _createRuleWithTypedConfig.createLintRuleWithTypedConfig)({
|
|
|
64
66
|
},
|
|
65
67
|
create: function create(context, config) {
|
|
66
68
|
return {
|
|
67
|
-
Program: function Program(
|
|
68
|
-
(0,
|
|
69
|
-
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
|
|
73
|
-
|
|
74
|
-
|
|
75
|
-
if (type === 'grouped-at-rules') {
|
|
76
|
-
context.report({
|
|
77
|
-
node: node.key,
|
|
78
|
-
messageId: 'no-grouped-at-rules'
|
|
79
|
-
});
|
|
80
|
-
return;
|
|
69
|
+
Program: function Program() {
|
|
70
|
+
var _iterator = _createForOfIteratorHelper((0, _styleCalls.getStyleCalls)(context)),
|
|
71
|
+
_step;
|
|
72
|
+
try {
|
|
73
|
+
var _loop = function _loop() {
|
|
74
|
+
var styleCall = _step.value;
|
|
75
|
+
if (!config.importSources.includes(styleCall.importSource)) {
|
|
76
|
+
return 1; // continue
|
|
81
77
|
}
|
|
82
|
-
if (
|
|
83
|
-
|
|
84
|
-
|
|
85
|
-
|
|
78
|
+
if (styleCall.styleFunction === 'cssMap') {
|
|
79
|
+
(0, _walkCssMap.walkCssMapCall)(styleCall.node, function (property) {
|
|
80
|
+
var type = property.type,
|
|
81
|
+
node = property.node;
|
|
82
|
+
if (type === 'grouped-at-rules') {
|
|
83
|
+
context.report({
|
|
84
|
+
node: node.key,
|
|
85
|
+
messageId: 'no-grouped-at-rules'
|
|
86
|
+
});
|
|
87
|
+
} else if (type === 'selectors') {
|
|
88
|
+
context.report({
|
|
89
|
+
node: node.key,
|
|
90
|
+
messageId: 'no-selectors-object'
|
|
91
|
+
});
|
|
92
|
+
}
|
|
86
93
|
});
|
|
87
|
-
return;
|
|
88
94
|
}
|
|
89
|
-
|
|
90
|
-
|
|
91
|
-
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
101
|
-
|
|
102
|
-
|
|
103
|
-
|
|
104
|
-
|
|
105
|
-
|
|
106
|
-
|
|
107
|
-
|
|
108
|
-
|
|
109
|
-
|
|
110
|
-
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
|
|
115
|
-
|
|
116
|
-
|
|
117
|
-
|
|
118
|
-
|
|
119
|
-
|
|
120
|
-
|
|
121
|
-
|
|
122
|
-
|
|
123
|
-
|
|
124
|
-
|
|
125
|
-
|
|
126
|
-
|
|
127
|
-
|
|
128
|
-
|
|
129
|
-
|
|
130
|
-
|
|
131
|
-
|
|
132
|
-
|
|
133
|
-
|
|
134
|
-
|
|
135
|
-
|
|
136
|
-
|
|
137
|
-
|
|
138
|
-
sourceNode: key,
|
|
139
|
-
selector: selector,
|
|
140
|
-
config: config,
|
|
141
|
-
isXcssCall: isXcssCall
|
|
142
|
-
});
|
|
143
|
-
});
|
|
144
|
-
} catch (_unused) {
|
|
145
|
-
context.report({
|
|
146
|
-
node: key,
|
|
147
|
-
messageId: 'no-unparsable-selectors',
|
|
148
|
-
data: {
|
|
149
|
-
selectorText: selectorText
|
|
95
|
+
(0, _walkStyleCallProperties.walkStyleCallProperties)(styleCall, function (_ref) {
|
|
96
|
+
var key = _ref.key,
|
|
97
|
+
value = _ref.value;
|
|
98
|
+
if (value.type !== 'ObjectExpression' || key.type !== 'Literal' || typeof key.value !== 'string') {
|
|
99
|
+
return;
|
|
100
|
+
}
|
|
101
|
+
var selectorText = key.value;
|
|
102
|
+
if (selectorText.includes('@')) {
|
|
103
|
+
lintAtRule({
|
|
104
|
+
context: context,
|
|
105
|
+
sourceNode: key,
|
|
106
|
+
atRule: selectorText
|
|
107
|
+
});
|
|
108
|
+
return;
|
|
109
|
+
}
|
|
110
|
+
if ((0, _isSimpleSelector.isSimpleSelector)(selectorText, {
|
|
111
|
+
allowedPseudos: _constants.allowedPseudos,
|
|
112
|
+
allowLeadingPseudo: styleCall.styleFunction === 'xcss'
|
|
113
|
+
})) {
|
|
114
|
+
return;
|
|
115
|
+
}
|
|
116
|
+
try {
|
|
117
|
+
var selectorList = (0, _parseSelector.parseSelector)(context, selectorText);
|
|
118
|
+
var _iterator2 = _createForOfIteratorHelper(selectorList.nodes),
|
|
119
|
+
_step2;
|
|
120
|
+
try {
|
|
121
|
+
for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
|
|
122
|
+
var selector = _step2.value;
|
|
123
|
+
(0, _lintSelector.lintSelector)({
|
|
124
|
+
context: context,
|
|
125
|
+
sourceNode: key,
|
|
126
|
+
selector: selector,
|
|
127
|
+
config: config,
|
|
128
|
+
isXcssCall: styleCall.styleFunction === 'xcss'
|
|
129
|
+
});
|
|
130
|
+
}
|
|
131
|
+
} catch (err) {
|
|
132
|
+
_iterator2.e(err);
|
|
133
|
+
} finally {
|
|
134
|
+
_iterator2.f();
|
|
135
|
+
}
|
|
136
|
+
} catch (_unused) {
|
|
137
|
+
context.report({
|
|
138
|
+
node: key,
|
|
139
|
+
messageId: 'no-unparsable-selectors',
|
|
140
|
+
data: {
|
|
141
|
+
selectorText: selectorText
|
|
142
|
+
}
|
|
143
|
+
});
|
|
150
144
|
}
|
|
151
145
|
});
|
|
146
|
+
};
|
|
147
|
+
for (_iterator.s(); !(_step = _iterator.n()).done;) {
|
|
148
|
+
if (_loop()) continue;
|
|
152
149
|
}
|
|
153
|
-
})
|
|
150
|
+
} catch (err) {
|
|
151
|
+
_iterator.e(err);
|
|
152
|
+
} finally {
|
|
153
|
+
_iterator.f();
|
|
154
|
+
}
|
|
154
155
|
}
|
|
155
156
|
};
|
|
156
157
|
}
|
|
@@ -11,11 +11,23 @@ var _postcssSelectorParser = require("postcss-selector-parser");
|
|
|
11
11
|
var _constants = require("./constants");
|
|
12
12
|
var _getSourceLocationFromRange = require("./get-source-location-from-range");
|
|
13
13
|
var _sourcePositionUtils = require("./source-position-utils");
|
|
14
|
+
function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
|
|
15
|
+
function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
|
|
16
|
+
function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
|
|
14
17
|
function lintSelector(args) {
|
|
15
18
|
checkNoAmbiguousPseudos(args);
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
|
|
19
|
+
var pseudos = [];
|
|
20
|
+
var nestings = [];
|
|
21
|
+
args.selector.walk(function (node) {
|
|
22
|
+
if ((0, _postcssSelectorParser.isPseudo)(node)) {
|
|
23
|
+
pseudos.push(node);
|
|
24
|
+
} else if ((0, _postcssSelectorParser.isNesting)(node)) {
|
|
25
|
+
nestings.push(node);
|
|
26
|
+
}
|
|
27
|
+
});
|
|
28
|
+
checkNoRestrictedPseudos(args, pseudos);
|
|
29
|
+
checkNoLegacyPseudoElementSyntax(args, pseudos);
|
|
30
|
+
checkNoIncreasedSpecificity(args, nestings);
|
|
19
31
|
}
|
|
20
32
|
var legacyPseudoElements = new Set([':after', ':before', ':first-letter', ':first-line']);
|
|
21
33
|
|
|
@@ -83,39 +95,47 @@ function checkNoAmbiguousPseudos(_ref) {
|
|
|
83
95
|
});
|
|
84
96
|
}
|
|
85
97
|
}
|
|
86
|
-
function checkNoRestrictedPseudos(_ref2) {
|
|
98
|
+
function checkNoRestrictedPseudos(_ref2, pseudos) {
|
|
87
99
|
var context = _ref2.context,
|
|
88
|
-
sourceNode = _ref2.sourceNode
|
|
89
|
-
|
|
90
|
-
|
|
91
|
-
|
|
92
|
-
|
|
93
|
-
|
|
100
|
+
sourceNode = _ref2.sourceNode;
|
|
101
|
+
var _iterator = _createForOfIteratorHelper(pseudos),
|
|
102
|
+
_step;
|
|
103
|
+
try {
|
|
104
|
+
for (_iterator.s(); !(_step = _iterator.n()).done;) {
|
|
105
|
+
var pseudo = _step.value;
|
|
106
|
+
if (_constants.allowedPseudos.has(pseudo.value)) {
|
|
107
|
+
continue;
|
|
108
|
+
}
|
|
94
109
|
|
|
95
|
-
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
101
|
-
|
|
102
|
-
|
|
103
|
-
|
|
104
|
-
|
|
105
|
-
|
|
106
|
-
|
|
107
|
-
|
|
108
|
-
|
|
109
|
-
|
|
110
|
-
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
|
|
115
|
-
|
|
116
|
-
|
|
110
|
+
/**
|
|
111
|
+
* If someone has written `:after` it is allowed,
|
|
112
|
+
* they've just used the legacy syntax.
|
|
113
|
+
*
|
|
114
|
+
* This will be caught by the `no-legacy-pseudo-element-syntax` check.
|
|
115
|
+
*/
|
|
116
|
+
if (legacyPseudoElements.has(pseudo.value) && _constants.allowedPseudos.has(":".concat(pseudo.value))) {
|
|
117
|
+
continue;
|
|
118
|
+
}
|
|
119
|
+
if (!_constants.allowedPseudos.has(pseudo.value)) {
|
|
120
|
+
var range = (0, _sourcePositionUtils.getRangeFromNode)({
|
|
121
|
+
node: pseudo,
|
|
122
|
+
sourceNode: sourceNode
|
|
123
|
+
});
|
|
124
|
+
var loc = (0, _getSourceLocationFromRange.getSourceLocationFromRange)(context, range);
|
|
125
|
+
context.report({
|
|
126
|
+
loc: loc,
|
|
127
|
+
messageId: 'no-restricted-pseudos',
|
|
128
|
+
data: {
|
|
129
|
+
pseudo: pseudo.value
|
|
130
|
+
}
|
|
131
|
+
});
|
|
132
|
+
}
|
|
117
133
|
}
|
|
118
|
-
})
|
|
134
|
+
} catch (err) {
|
|
135
|
+
_iterator.e(err);
|
|
136
|
+
} finally {
|
|
137
|
+
_iterator.f();
|
|
138
|
+
}
|
|
119
139
|
}
|
|
120
140
|
|
|
121
141
|
/**
|
|
@@ -123,78 +143,97 @@ function checkNoRestrictedPseudos(_ref2) {
|
|
|
123
143
|
*
|
|
124
144
|
* https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-elements
|
|
125
145
|
*/
|
|
126
|
-
function checkNoLegacyPseudoElementSyntax(_ref3) {
|
|
146
|
+
function checkNoLegacyPseudoElementSyntax(_ref3, pseudos) {
|
|
127
147
|
var context = _ref3.context,
|
|
128
|
-
sourceNode = _ref3.sourceNode
|
|
129
|
-
|
|
130
|
-
|
|
131
|
-
|
|
132
|
-
|
|
133
|
-
|
|
134
|
-
|
|
135
|
-
|
|
136
|
-
|
|
137
|
-
|
|
138
|
-
|
|
139
|
-
|
|
140
|
-
|
|
141
|
-
|
|
142
|
-
|
|
143
|
-
|
|
144
|
-
|
|
145
|
-
|
|
146
|
-
|
|
147
|
-
|
|
148
|
-
|
|
149
|
-
|
|
150
|
-
|
|
151
|
-
|
|
152
|
-
|
|
148
|
+
sourceNode = _ref3.sourceNode;
|
|
149
|
+
var _iterator2 = _createForOfIteratorHelper(pseudos),
|
|
150
|
+
_step2;
|
|
151
|
+
try {
|
|
152
|
+
var _loop = function _loop() {
|
|
153
|
+
var pseudo = _step2.value;
|
|
154
|
+
if (legacyPseudoElements.has(pseudo.value)) {
|
|
155
|
+
var range = (0, _sourcePositionUtils.getRangeFromNode)({
|
|
156
|
+
node: pseudo,
|
|
157
|
+
sourceNode: sourceNode
|
|
158
|
+
});
|
|
159
|
+
var loc = (0, _getSourceLocationFromRange.getSourceLocationFromRange)(context, range);
|
|
160
|
+
context.report({
|
|
161
|
+
loc: loc,
|
|
162
|
+
messageId: 'no-legacy-pseudo-element-syntax',
|
|
163
|
+
fix: /*#__PURE__*/_regenerator.default.mark(function fix(fixer) {
|
|
164
|
+
return _regenerator.default.wrap(function (_context3) {
|
|
165
|
+
while (1) switch (_context3.prev = _context3.next) {
|
|
166
|
+
case 0:
|
|
167
|
+
_context3.next = 1;
|
|
168
|
+
return fixer.insertTextBeforeRange(range, ':');
|
|
169
|
+
case 1:
|
|
170
|
+
case "end":
|
|
171
|
+
return _context3.stop();
|
|
172
|
+
}
|
|
173
|
+
}, fix);
|
|
174
|
+
})
|
|
175
|
+
});
|
|
176
|
+
}
|
|
177
|
+
};
|
|
178
|
+
for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
|
|
179
|
+
_loop();
|
|
153
180
|
}
|
|
154
|
-
})
|
|
181
|
+
} catch (err) {
|
|
182
|
+
_iterator2.e(err);
|
|
183
|
+
} finally {
|
|
184
|
+
_iterator2.f();
|
|
185
|
+
}
|
|
155
186
|
}
|
|
156
|
-
function checkNoIncreasedSpecificity(_ref4) {
|
|
187
|
+
function checkNoIncreasedSpecificity(_ref4, nestings) {
|
|
157
188
|
var context = _ref4.context,
|
|
158
|
-
sourceNode = _ref4.sourceNode
|
|
159
|
-
|
|
160
|
-
|
|
161
|
-
|
|
162
|
-
|
|
163
|
-
|
|
164
|
-
|
|
165
|
-
|
|
166
|
-
|
|
167
|
-
|
|
189
|
+
sourceNode = _ref4.sourceNode;
|
|
190
|
+
var _iterator3 = _createForOfIteratorHelper(nestings),
|
|
191
|
+
_step3;
|
|
192
|
+
try {
|
|
193
|
+
for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
|
|
194
|
+
var nesting = _step3.value;
|
|
195
|
+
/**
|
|
196
|
+
* If it's not the start of a chain, then it's already been reported.
|
|
197
|
+
*/
|
|
198
|
+
if ((0, _postcssSelectorParser.isNesting)(nesting.prev())) {
|
|
199
|
+
continue;
|
|
200
|
+
}
|
|
201
|
+
var next = nesting.next();
|
|
168
202
|
|
|
169
|
-
|
|
170
|
-
|
|
171
|
-
|
|
172
|
-
|
|
173
|
-
|
|
174
|
-
|
|
175
|
-
|
|
176
|
-
|
|
177
|
-
|
|
178
|
-
|
|
179
|
-
|
|
203
|
+
/**
|
|
204
|
+
* If it is followed by something other than another nesting selector,
|
|
205
|
+
* then it isn't just there to increase specificity — it is actually necessary.
|
|
206
|
+
*/
|
|
207
|
+
if (next && !(0, _postcssSelectorParser.isNesting)(next)) {
|
|
208
|
+
continue;
|
|
209
|
+
}
|
|
210
|
+
var lastNesting = nesting;
|
|
211
|
+
while ((0, _postcssSelectorParser.isNesting)(next)) {
|
|
212
|
+
lastNesting = next;
|
|
213
|
+
next = next.next();
|
|
214
|
+
}
|
|
215
|
+
var _getRangeFromNode = (0, _sourcePositionUtils.getRangeFromNode)({
|
|
216
|
+
node: nesting,
|
|
217
|
+
sourceNode: sourceNode
|
|
218
|
+
}),
|
|
219
|
+
_getRangeFromNode2 = (0, _slicedToArray2.default)(_getRangeFromNode, 1),
|
|
220
|
+
start = _getRangeFromNode2[0];
|
|
221
|
+
var _getRangeFromNode3 = (0, _sourcePositionUtils.getRangeFromNode)({
|
|
222
|
+
node: lastNesting,
|
|
223
|
+
sourceNode: sourceNode
|
|
224
|
+
}),
|
|
225
|
+
_getRangeFromNode4 = (0, _slicedToArray2.default)(_getRangeFromNode3, 2),
|
|
226
|
+
_ = _getRangeFromNode4[0],
|
|
227
|
+
end = _getRangeFromNode4[1];
|
|
228
|
+
var loc = (0, _getSourceLocationFromRange.getSourceLocationFromRange)(context, [start, end]);
|
|
229
|
+
context.report({
|
|
230
|
+
loc: loc,
|
|
231
|
+
messageId: 'no-increased-specificity'
|
|
232
|
+
});
|
|
180
233
|
}
|
|
181
|
-
|
|
182
|
-
|
|
183
|
-
|
|
184
|
-
|
|
185
|
-
|
|
186
|
-
start = _getRangeFromNode2[0];
|
|
187
|
-
var _getRangeFromNode3 = (0, _sourcePositionUtils.getRangeFromNode)({
|
|
188
|
-
node: lastNesting,
|
|
189
|
-
sourceNode: sourceNode
|
|
190
|
-
}),
|
|
191
|
-
_getRangeFromNode4 = (0, _slicedToArray2.default)(_getRangeFromNode3, 2),
|
|
192
|
-
_ = _getRangeFromNode4[0],
|
|
193
|
-
end = _getRangeFromNode4[1];
|
|
194
|
-
var loc = (0, _getSourceLocationFromRange.getSourceLocationFromRange)(context, [start, end]);
|
|
195
|
-
context.report({
|
|
196
|
-
loc: loc,
|
|
197
|
-
messageId: 'no-increased-specificity'
|
|
198
|
-
});
|
|
199
|
-
});
|
|
234
|
+
} catch (err) {
|
|
235
|
+
_iterator3.e(err);
|
|
236
|
+
} finally {
|
|
237
|
+
_iterator3.f();
|
|
238
|
+
}
|
|
200
239
|
}
|
|
@@ -1,12 +1,9 @@
|
|
|
1
1
|
"use strict";
|
|
2
2
|
|
|
3
|
-
var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
|
|
4
3
|
Object.defineProperty(exports, "__esModule", {
|
|
5
4
|
value: true
|
|
6
5
|
});
|
|
7
|
-
exports.
|
|
8
|
-
var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
|
|
9
|
-
var _contextCompat = require("@atlaskit/eslint-utils/context-compat");
|
|
6
|
+
exports.walkCssMapCall = walkCssMapCall;
|
|
10
7
|
/**
|
|
11
8
|
* This util is intentionally not in `@atlaskit/eslint-utils` at this time.
|
|
12
9
|
*
|
|
@@ -59,45 +56,18 @@ var _contextCompat = require("@atlaskit/eslint-utils/context-compat");
|
|
|
59
56
|
*/
|
|
60
57
|
var allowedGroupedAtRules = new Set(['@starting-style' // Has no parameters, can only be written in grouped form
|
|
61
58
|
]);
|
|
62
|
-
function
|
|
63
|
-
var
|
|
64
|
-
|
|
65
|
-
visitor = _ref.visitor;
|
|
66
|
-
var program = (0, _contextCompat.getSourceCode)(context).ast;
|
|
67
|
-
var importDeclaration = program.body.find(function (node) {
|
|
68
|
-
return node.type === 'ImportDeclaration' && importSources.includes(node.source.value);
|
|
69
|
-
});
|
|
70
|
-
var specifier = importDeclaration === null || importDeclaration === void 0 ? void 0 : importDeclaration.specifiers.find(function (specifier) {
|
|
71
|
-
return specifier.type === 'ImportSpecifier' && 'name' in specifier.imported && specifier.imported.name === 'cssMap';
|
|
72
|
-
});
|
|
73
|
-
if (!specifier) {
|
|
74
|
-
return;
|
|
75
|
-
}
|
|
76
|
-
var _getSourceCode$scopeM = (0, _contextCompat.getSourceCode)(context).scopeManager.getDeclaredVariables(specifier),
|
|
77
|
-
_getSourceCode$scopeM2 = (0, _slicedToArray2.default)(_getSourceCode$scopeM, 1),
|
|
78
|
-
variable = _getSourceCode$scopeM2[0];
|
|
79
|
-
if (!variable) {
|
|
80
|
-
return;
|
|
81
|
-
}
|
|
82
|
-
variable.references.forEach(function (reference) {
|
|
83
|
-
var identifier = reference.identifier;
|
|
84
|
-
var parent = identifier.parent;
|
|
85
|
-
if (parent.type !== 'CallExpression') {
|
|
86
|
-
return;
|
|
87
|
-
}
|
|
88
|
-
var variantMap = parent.arguments[0];
|
|
89
|
-
if (variantMap.type !== 'ObjectExpression') {
|
|
90
|
-
return;
|
|
91
|
-
}
|
|
59
|
+
function walkCssMapCall(call, visitor) {
|
|
60
|
+
var variantMap = call.arguments[0];
|
|
61
|
+
if ((variantMap === null || variantMap === void 0 ? void 0 : variantMap.type) === 'ObjectExpression') {
|
|
92
62
|
walkCssMapVariantMap({
|
|
93
63
|
variantMap: variantMap,
|
|
94
64
|
visitor: visitor
|
|
95
65
|
});
|
|
96
|
-
}
|
|
66
|
+
}
|
|
97
67
|
}
|
|
98
|
-
function walkCssMapVariantMap(
|
|
99
|
-
var variantMap =
|
|
100
|
-
visitor =
|
|
68
|
+
function walkCssMapVariantMap(_ref) {
|
|
69
|
+
var variantMap = _ref.variantMap,
|
|
70
|
+
visitor = _ref.visitor;
|
|
101
71
|
variantMap.properties.forEach(function (property) {
|
|
102
72
|
if (property.type !== 'Property') {
|
|
103
73
|
return;
|
|
@@ -108,9 +78,9 @@ function walkCssMapVariantMap(_ref2) {
|
|
|
108
78
|
});
|
|
109
79
|
});
|
|
110
80
|
}
|
|
111
|
-
function walkCssMapVariant(
|
|
112
|
-
var variant =
|
|
113
|
-
visitor =
|
|
81
|
+
function walkCssMapVariant(_ref2) {
|
|
82
|
+
var variant = _ref2.variant,
|
|
83
|
+
visitor = _ref2.visitor;
|
|
114
84
|
visitor({
|
|
115
85
|
type: 'variant',
|
|
116
86
|
node: variant
|
|
@@ -149,9 +119,9 @@ function walkCssMapVariant(_ref3) {
|
|
|
149
119
|
});
|
|
150
120
|
});
|
|
151
121
|
}
|
|
152
|
-
function walkCssMapAtRuleGrouping(
|
|
153
|
-
var atRuleGrouping =
|
|
154
|
-
visitor =
|
|
122
|
+
function walkCssMapAtRuleGrouping(_ref3) {
|
|
123
|
+
var atRuleGrouping = _ref3.atRuleGrouping,
|
|
124
|
+
visitor = _ref3.visitor;
|
|
155
125
|
var atRule = getKeyValue(atRuleGrouping.key);
|
|
156
126
|
if (!atRule) {
|
|
157
127
|
return;
|
|
@@ -178,9 +148,9 @@ function walkCssMapAtRuleGrouping(_ref4) {
|
|
|
178
148
|
});
|
|
179
149
|
});
|
|
180
150
|
}
|
|
181
|
-
function walkCssMapSelectors(
|
|
182
|
-
var selectors =
|
|
183
|
-
visitor =
|
|
151
|
+
function walkCssMapSelectors(_ref4) {
|
|
152
|
+
var selectors = _ref4.selectors,
|
|
153
|
+
visitor = _ref4.visitor;
|
|
184
154
|
visitor({
|
|
185
155
|
type: 'selectors',
|
|
186
156
|
node: selectors
|
|
@@ -198,9 +168,9 @@ function walkCssMapSelectors(_ref5) {
|
|
|
198
168
|
});
|
|
199
169
|
});
|
|
200
170
|
}
|
|
201
|
-
function walkStyleRuleset(
|
|
202
|
-
var ruleset =
|
|
203
|
-
visitor =
|
|
171
|
+
function walkStyleRuleset(_ref5) {
|
|
172
|
+
var ruleset = _ref5.ruleset,
|
|
173
|
+
visitor = _ref5.visitor;
|
|
204
174
|
visitor({
|
|
205
175
|
type: 'ruleset',
|
|
206
176
|
node: ruleset
|
|
@@ -10,7 +10,26 @@ var _ajv = _interopRequireDefault(require("ajv"));
|
|
|
10
10
|
var _getRuleUrl = require("./get-rule-url");
|
|
11
11
|
function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
|
|
12
12
|
function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
|
|
13
|
+
/**
|
|
14
|
+
* A single shared Ajv instance is reused across every rule instead of constructing
|
|
15
|
+
* a new one each time a default config is needed. Ajv's constructor is expensive
|
|
16
|
+
* (it compiles its own meta-schemas), so we only ever want to pay for it once.
|
|
17
|
+
*/
|
|
18
|
+
var ajv = new _ajv.default({
|
|
19
|
+
useDefaults: true
|
|
20
|
+
});
|
|
13
21
|
var createLintRuleWithTypedConfig = exports.createLintRuleWithTypedConfig = function createLintRuleWithTypedConfig(rule) {
|
|
22
|
+
/**
|
|
23
|
+
* Lazily-computed, cached default config.
|
|
24
|
+
*
|
|
25
|
+
* The default config is derived purely from the rule's (static) schema, so it is
|
|
26
|
+
* constant for the life of the process. Compiling the schema with Ajv involves
|
|
27
|
+
* runtime code generation (`new Function`), which is expensive — previously this
|
|
28
|
+
* ran on every `getDefaultConfig()` call, i.e. once per linted file. We now compute
|
|
29
|
+
* it at most once per rule and reuse the result.
|
|
30
|
+
*/
|
|
31
|
+
var defaultConfig;
|
|
32
|
+
|
|
14
33
|
/**
|
|
15
34
|
* Gets the default config by running the same validator
|
|
16
35
|
* ESLint does against an empty config object with
|
|
@@ -20,16 +39,16 @@ var createLintRuleWithTypedConfig = exports.createLintRuleWithTypedConfig = func
|
|
|
20
39
|
* will be populated with the specified default value.
|
|
21
40
|
*/
|
|
22
41
|
function getDefaultConfig() {
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
return
|
|
42
|
+
if (defaultConfig === undefined) {
|
|
43
|
+
var validate = ajv.compile(rule.meta.schema);
|
|
44
|
+
var _config = {};
|
|
45
|
+
/**
|
|
46
|
+
* The `validate()` function mutates the config object.
|
|
47
|
+
*/
|
|
48
|
+
validate(_config);
|
|
49
|
+
defaultConfig = _config;
|
|
50
|
+
}
|
|
51
|
+
return defaultConfig;
|
|
33
52
|
}
|
|
34
53
|
return _objectSpread(_objectSpread({}, rule), {}, {
|
|
35
54
|
meta: _objectSpread(_objectSpread({}, rule.meta), {}, {
|