@atlaskit/eslint-plugin-ui-styling-standard 0.14.2 → 0.15.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (71) hide show
  1. package/CHANGELOG.md +13 -0
  2. package/README.md +1 -0
  3. package/afm-cc/tsconfig.json +10 -3
  4. package/afm-jira/tsconfig.json +28 -0
  5. package/constellation/index/overview.mdx +29 -28
  6. package/constellation/no-unsafe-selectors/usage.mdx +244 -0
  7. package/dist/cjs/presets/all.codegen.js +2 -1
  8. package/dist/cjs/presets/recommended.codegen.js +2 -1
  9. package/dist/cjs/rules/index.codegen.js +3 -1
  10. package/dist/cjs/rules/no-unsafe-selectors/constants.js +30 -0
  11. package/dist/cjs/rules/no-unsafe-selectors/index.js +185 -0
  12. package/dist/cjs/rules/no-unsafe-selectors/lint-selector.js +189 -0
  13. package/dist/cjs/rules/no-unsafe-selectors/source-position-utils.js +42 -0
  14. package/dist/cjs/rules/no-unsafe-selectors/walk-css-map.js +186 -0
  15. package/dist/es2019/presets/all.codegen.js +2 -1
  16. package/dist/es2019/presets/recommended.codegen.js +2 -1
  17. package/dist/es2019/rules/index.codegen.js +3 -1
  18. package/dist/es2019/rules/no-unsafe-selectors/constants.js +22 -0
  19. package/dist/es2019/rules/no-unsafe-selectors/index.js +173 -0
  20. package/dist/es2019/rules/no-unsafe-selectors/lint-selector.js +152 -0
  21. package/dist/es2019/rules/no-unsafe-selectors/source-position-utils.js +31 -0
  22. package/dist/es2019/rules/no-unsafe-selectors/walk-css-map.js +180 -0
  23. package/dist/esm/presets/all.codegen.js +2 -1
  24. package/dist/esm/presets/recommended.codegen.js +2 -1
  25. package/dist/esm/rules/index.codegen.js +3 -1
  26. package/dist/esm/rules/no-unsafe-selectors/constants.js +24 -0
  27. package/dist/esm/rules/no-unsafe-selectors/index.js +178 -0
  28. package/dist/esm/rules/no-unsafe-selectors/lint-selector.js +182 -0
  29. package/dist/esm/rules/no-unsafe-selectors/source-position-utils.js +34 -0
  30. package/dist/esm/rules/no-unsafe-selectors/walk-css-map.js +179 -0
  31. package/dist/types/index.codegen.d.ts +2 -0
  32. package/dist/types/presets/all.codegen.d.ts +2 -1
  33. package/dist/types/presets/recommended.codegen.d.ts +2 -1
  34. package/dist/types/rules/index.codegen.d.ts +1 -0
  35. package/dist/types/rules/no-unsafe-selectors/constants.d.ts +23 -0
  36. package/dist/types/rules/no-unsafe-selectors/index.d.ts +3 -0
  37. package/dist/types/rules/no-unsafe-selectors/lint-selector.d.ts +13 -0
  38. package/dist/types/rules/no-unsafe-selectors/source-position-utils.d.ts +20 -0
  39. package/dist/types/rules/no-unsafe-selectors/walk-css-map.d.ts +23 -0
  40. package/dist/types-ts4.5/index.codegen.d.ts +2 -0
  41. package/dist/types-ts4.5/presets/all.codegen.d.ts +2 -1
  42. package/dist/types-ts4.5/presets/recommended.codegen.d.ts +2 -1
  43. package/dist/types-ts4.5/rules/index.codegen.d.ts +1 -0
  44. package/dist/types-ts4.5/rules/no-unsafe-selectors/constants.d.ts +84 -0
  45. package/dist/types-ts4.5/rules/no-unsafe-selectors/index.d.ts +3 -0
  46. package/dist/types-ts4.5/rules/no-unsafe-selectors/lint-selector.d.ts +13 -0
  47. package/dist/types-ts4.5/rules/no-unsafe-selectors/source-position-utils.d.ts +23 -0
  48. package/dist/types-ts4.5/rules/no-unsafe-selectors/walk-css-map.d.ts +23 -0
  49. package/package.json +6 -5
  50. package/scripts/codegen.tsx +3 -4
  51. package/src/presets/all.codegen.tsx +2 -1
  52. package/src/presets/recommended.codegen.tsx +2 -1
  53. package/src/rules/index.codegen.tsx +3 -1
  54. package/src/rules/no-classname-prop/index.tsx +1 -1
  55. package/src/rules/no-nested-selectors/index.tsx +1 -1
  56. package/src/rules/no-unsafe-selectors/README.md +232 -0
  57. package/src/rules/no-unsafe-selectors/__tests__/no-ambiguous-pseudos.test.tsx +358 -0
  58. package/src/rules/no-unsafe-selectors/__tests__/no-grouped-at-rules.test.tsx +60 -0
  59. package/src/rules/no-unsafe-selectors/__tests__/no-increased-specificity.test.tsx +73 -0
  60. package/src/rules/no-unsafe-selectors/__tests__/no-keyframes-at-rules.test.tsx +40 -0
  61. package/src/rules/no-unsafe-selectors/__tests__/no-legacy-pseudo-element-syntax.test.tsx +101 -0
  62. package/src/rules/no-unsafe-selectors/__tests__/no-restricted-at-rules.test.tsx +131 -0
  63. package/src/rules/no-unsafe-selectors/__tests__/no-restricted-pseudos.test.tsx +132 -0
  64. package/src/rules/no-unsafe-selectors/__tests__/no-selectors-object.test.tsx +25 -0
  65. package/src/rules/no-unsafe-selectors/__tests__/no-unparsable-selectors.test.tsx +35 -0
  66. package/src/rules/no-unsafe-selectors/__tests__/rule.test.tsx +238 -0
  67. package/src/rules/no-unsafe-selectors/constants.tsx +99 -0
  68. package/src/rules/no-unsafe-selectors/index.tsx +201 -0
  69. package/src/rules/no-unsafe-selectors/lint-selector.tsx +168 -0
  70. package/src/rules/no-unsafe-selectors/source-position-utils.tsx +55 -0
  71. package/src/rules/no-unsafe-selectors/walk-css-map.tsx +232 -0
@@ -0,0 +1,358 @@
1
+ import outdent from 'outdent';
2
+
3
+ import { tester } from '../../__tests__/utils/_tester';
4
+ import rule from '../index';
5
+
6
+ tester.run('no-ambiguous-pseudos', rule, {
7
+ valid: [
8
+ {
9
+ name: '& is used',
10
+ code: `
11
+ import { css } from '@compiled/react';
12
+
13
+ css({
14
+ '&:hover': {},
15
+ '&:focus, &:active': {},
16
+ });
17
+ `,
18
+ },
19
+ {
20
+ name: '& is used with compound selector',
21
+ code: `
22
+ import { css } from '@compiled/react';
23
+
24
+ css({
25
+ '&:hover:focus': {}
26
+ });
27
+ `,
28
+ },
29
+ {
30
+ name: '* is used',
31
+ code: `
32
+ import { css } from '@compiled/react';
33
+
34
+ css({
35
+ '*:hover': {},
36
+ '*:focus, *:active': {},
37
+ '*:hover:focus': {},
38
+ });
39
+ `,
40
+ },
41
+ {
42
+ name: 'missing & after attribute',
43
+ code: `
44
+ import { css } from '@compiled/react';
45
+
46
+ css({
47
+ '[data-testid]:hover': {}
48
+ });
49
+ `,
50
+ },
51
+ {
52
+ name: 'missing & after attribute with value',
53
+ code: `
54
+ import { css } from '@compiled/react';
55
+
56
+ css({
57
+ '[data-testid="abc"]:hover': {}
58
+ });
59
+ `,
60
+ },
61
+ {
62
+ name: 'missing & after descendant selector',
63
+ code: `
64
+ import { css } from '@compiled/react';
65
+
66
+ css({
67
+ '& :hover': {},
68
+ });
69
+ `,
70
+ },
71
+ {
72
+ name: 'missing & after sibling selector',
73
+ code: `
74
+ import { css } from '@compiled/react';
75
+
76
+ css({
77
+ '& + :hover': {},
78
+ });
79
+ `,
80
+ },
81
+ ],
82
+ invalid: [
83
+ {
84
+ name: 'missing &',
85
+ code: outdent`
86
+ import { css } from '@compiled/react';
87
+
88
+ css({
89
+ ':hover': {},
90
+ });
91
+ `,
92
+ output: outdent`
93
+ import { css } from '@compiled/react';
94
+
95
+ css({
96
+ '&:hover': {},
97
+ });
98
+ `,
99
+ errors: [
100
+ {
101
+ messageId: 'no-ambiguous-pseudos',
102
+ line: 4,
103
+ column: 4,
104
+ endColumn: 10,
105
+ },
106
+ ],
107
+ },
108
+ {
109
+ name: 'multiple selectors in list with missing &',
110
+ code: outdent`
111
+ import { css } from '@compiled/react';
112
+
113
+ css({
114
+ ':hover, :focus': {},
115
+ });
116
+ `,
117
+ output: outdent`
118
+ import { css } from '@compiled/react';
119
+
120
+ css({
121
+ '&:hover, &:focus': {},
122
+ });
123
+ `,
124
+ errors: [
125
+ {
126
+ messageId: 'no-ambiguous-pseudos',
127
+ line: 4,
128
+ column: 4,
129
+ endColumn: 10,
130
+ },
131
+ {
132
+ messageId: 'no-ambiguous-pseudos',
133
+ line: 4,
134
+ column: 12,
135
+ endColumn: 18,
136
+ },
137
+ ],
138
+ },
139
+ {
140
+ name: 'multiple selectors in list with one missing &',
141
+ code: outdent`
142
+ import { css } from '@compiled/react';
143
+
144
+ css({
145
+ '&:hover, :focus': {},
146
+ });
147
+ `,
148
+ output: outdent`
149
+ import { css } from '@compiled/react';
150
+
151
+ css({
152
+ '&:hover, &:focus': {},
153
+ });
154
+ `,
155
+ errors: [
156
+ {
157
+ messageId: 'no-ambiguous-pseudos',
158
+ line: 4,
159
+ column: 13,
160
+ endColumn: 19,
161
+ },
162
+ ],
163
+ },
164
+ {
165
+ name: 'compound selector with missing &',
166
+ code: outdent`
167
+ import { css } from '@compiled/react';
168
+
169
+ css({
170
+ ':hover:focus': {},
171
+ });
172
+ `,
173
+ output: outdent`
174
+ import { css } from '@compiled/react';
175
+
176
+ css({
177
+ '&:hover:focus': {},
178
+ });
179
+ `,
180
+ errors: [
181
+ {
182
+ messageId: 'no-ambiguous-pseudos',
183
+ line: 4,
184
+ column: 4,
185
+ endColumn: 10,
186
+ },
187
+ ],
188
+ },
189
+ ],
190
+ });
191
+
192
+ tester.run(
193
+ 'no-ambiguous-pseudos with shouldAlwaysInsertNestingSelectorForAmbiguousPseudos disabled',
194
+ rule,
195
+ {
196
+ valid: [],
197
+ invalid: [
198
+ {
199
+ name: 'missing &',
200
+ code: outdent`
201
+ import { css } from '@compiled/react';
202
+
203
+ css({
204
+ ':hover': {},
205
+ });
206
+ `,
207
+ options: [
208
+ {
209
+ shouldAlwaysInsertNestingSelectorForAmbiguousPseudos: false,
210
+ },
211
+ ],
212
+ errors: [
213
+ {
214
+ messageId: 'no-ambiguous-pseudos',
215
+ line: 4,
216
+ column: 4,
217
+ endColumn: 10,
218
+ suggestions: [
219
+ {
220
+ messageId: 'insert-nesting-selector',
221
+ output: outdent`
222
+ import { css } from '@compiled/react';
223
+
224
+ css({
225
+ '&:hover': {},
226
+ });
227
+ `,
228
+ },
229
+ ],
230
+ },
231
+ ],
232
+ },
233
+ {
234
+ name: 'multiple selectors in list with missing &',
235
+ code: outdent`
236
+ import { css } from '@compiled/react';
237
+
238
+ css({
239
+ ':hover, :focus': {},
240
+ });
241
+ `,
242
+ options: [
243
+ {
244
+ shouldAlwaysInsertNestingSelectorForAmbiguousPseudos: false,
245
+ },
246
+ ],
247
+ errors: [
248
+ {
249
+ messageId: 'no-ambiguous-pseudos',
250
+ line: 4,
251
+ column: 4,
252
+ endColumn: 10,
253
+ suggestions: [
254
+ {
255
+ messageId: 'insert-nesting-selector',
256
+ output: outdent`
257
+ import { css } from '@compiled/react';
258
+
259
+ css({
260
+ '&:hover, :focus': {},
261
+ });
262
+ `,
263
+ },
264
+ ],
265
+ },
266
+ {
267
+ messageId: 'no-ambiguous-pseudos',
268
+ line: 4,
269
+ column: 12,
270
+ endColumn: 18,
271
+ suggestions: [
272
+ {
273
+ messageId: 'insert-nesting-selector',
274
+ output: outdent`
275
+ import { css } from '@compiled/react';
276
+
277
+ css({
278
+ ':hover, &:focus': {},
279
+ });
280
+ `,
281
+ },
282
+ ],
283
+ },
284
+ ],
285
+ },
286
+ {
287
+ name: 'multiple selectors in list with one missing &',
288
+ code: outdent`
289
+ import { css } from '@compiled/react';
290
+
291
+ css({
292
+ '&:hover, :focus': {},
293
+ });
294
+ `,
295
+ options: [
296
+ {
297
+ shouldAlwaysInsertNestingSelectorForAmbiguousPseudos: false,
298
+ },
299
+ ],
300
+ errors: [
301
+ {
302
+ messageId: 'no-ambiguous-pseudos',
303
+ line: 4,
304
+ column: 13,
305
+ endColumn: 19,
306
+ suggestions: [
307
+ {
308
+ messageId: 'insert-nesting-selector',
309
+ output: outdent`
310
+ import { css } from '@compiled/react';
311
+
312
+ css({
313
+ '&:hover, &:focus': {},
314
+ });
315
+ `,
316
+ },
317
+ ],
318
+ },
319
+ ],
320
+ },
321
+ {
322
+ name: 'compound selector with missing &',
323
+ code: outdent`
324
+ import { css } from '@compiled/react';
325
+
326
+ css({
327
+ ':hover:focus': {},
328
+ });
329
+ `,
330
+ options: [
331
+ {
332
+ shouldAlwaysInsertNestingSelectorForAmbiguousPseudos: false,
333
+ },
334
+ ],
335
+ errors: [
336
+ {
337
+ messageId: 'no-ambiguous-pseudos',
338
+ line: 4,
339
+ column: 4,
340
+ endColumn: 10,
341
+ suggestions: [
342
+ {
343
+ messageId: 'insert-nesting-selector',
344
+ output: outdent`
345
+ import { css } from '@compiled/react';
346
+
347
+ css({
348
+ '&:hover:focus': {},
349
+ });
350
+ `,
351
+ },
352
+ ],
353
+ },
354
+ ],
355
+ },
356
+ ],
357
+ },
358
+ );
@@ -0,0 +1,60 @@
1
+ import { tester } from '../../__tests__/utils/_tester';
2
+ import rule from '../index';
3
+
4
+ tester.run('no-grouped-at-rules', rule, {
5
+ valid: [],
6
+ invalid: [
7
+ {
8
+ name: '@media grouping',
9
+ code: `
10
+ import { cssMap } from '@compiled/react';
11
+
12
+ cssMap({
13
+ variant: {
14
+ '@media': {
15
+ '(min-width: 900px)': {},
16
+ '(min-width: 1200px)': {},
17
+ }
18
+ }
19
+ });
20
+ `,
21
+ errors: [{ messageId: 'no-grouped-at-rules' }],
22
+ },
23
+ {
24
+ name: '@keyframes grouping',
25
+ code: `
26
+ import { cssMap } from '@compiled/react';
27
+
28
+ cssMap({
29
+ success: {
30
+ '@keyframes': {
31
+ 'fadeIn': {}
32
+ }
33
+ }
34
+ });
35
+ `,
36
+ errors: [
37
+ { messageId: 'no-grouped-at-rules' },
38
+ { messageId: 'no-keyframes-at-rules' },
39
+ ],
40
+ },
41
+ {
42
+ name: '@scope grouping',
43
+ code: `
44
+ import { cssMap } from '@compiled/react';
45
+
46
+ cssMap({
47
+ success: {
48
+ '@scope': {
49
+ '(body) to (article)': {}
50
+ }
51
+ }
52
+ });
53
+ `,
54
+ errors: [
55
+ { messageId: 'no-grouped-at-rules' },
56
+ { messageId: 'no-restricted-at-rules', data: { atRule: '@scope' } },
57
+ ],
58
+ },
59
+ ],
60
+ });
@@ -0,0 +1,73 @@
1
+ import { tester } from '../../__tests__/utils/_tester';
2
+ import rule from '../index';
3
+
4
+ tester.run('no-increased-specificity', rule, {
5
+ valid: [
6
+ {
7
+ name: 'multiple & in selector list',
8
+ code: `
9
+ import { css } from '@compiled/react';
10
+
11
+ css({
12
+ '&:hover, &:active': {},
13
+ });
14
+ `,
15
+ },
16
+ ],
17
+ invalid: [
18
+ {
19
+ name: 'single &',
20
+ code: `
21
+ import { css } from '@compiled/react';
22
+
23
+ css({
24
+ '&': {},
25
+ });
26
+ `,
27
+ errors: [
28
+ {
29
+ messageId: 'no-increased-specificity',
30
+ line: 5,
31
+ column: 12,
32
+ endColumn: 13,
33
+ },
34
+ ],
35
+ },
36
+ {
37
+ name: 'double &',
38
+ code: `
39
+ import { css } from '@compiled/react';
40
+
41
+ css({
42
+ '&&': {},
43
+ });
44
+ `,
45
+ errors: [
46
+ {
47
+ messageId: 'no-increased-specificity',
48
+ line: 5,
49
+ column: 12,
50
+ endColumn: 14,
51
+ },
52
+ ],
53
+ },
54
+ {
55
+ name: 'longer chain of &',
56
+ code: `
57
+ import { css } from '@compiled/react';
58
+
59
+ css({
60
+ '&&&&&&&&&': {},
61
+ });
62
+ `,
63
+ errors: [
64
+ {
65
+ messageId: 'no-increased-specificity',
66
+ line: 5,
67
+ column: 12,
68
+ endColumn: 21,
69
+ },
70
+ ],
71
+ },
72
+ ],
73
+ });
@@ -0,0 +1,40 @@
1
+ import { tester } from '../../__tests__/utils/_tester';
2
+ import rule from '../index';
3
+
4
+ tester.run('no-keyframes-at-rules', rule, {
5
+ valid: [],
6
+ invalid: [
7
+ {
8
+ name: '@keyframes',
9
+ code: `
10
+ import { css } from '@compiled/react';
11
+
12
+ css({
13
+ '@keyframes fadeIn': {}
14
+ });
15
+ `,
16
+ errors: [
17
+ {
18
+ messageId: 'no-keyframes-at-rules',
19
+ },
20
+ ],
21
+ },
22
+ {
23
+ name: '@keyframes in cssMap',
24
+ code: `
25
+ import { cssMap } from '@compiled/react';
26
+
27
+ cssMap({
28
+ success: {
29
+ '@keyframes fadeIn': {}
30
+ }
31
+ });
32
+ `,
33
+ errors: [
34
+ {
35
+ messageId: 'no-keyframes-at-rules',
36
+ },
37
+ ],
38
+ },
39
+ ],
40
+ });
@@ -0,0 +1,101 @@
1
+ import { tester } from '../../__tests__/utils/_tester';
2
+ import rule from '../index';
3
+
4
+ tester.run('no-legacy-pseudo-element-syntax', rule, {
5
+ valid: [
6
+ {
7
+ code: `
8
+ import { css } from '@compiled/react';
9
+
10
+ css({
11
+ '&::after': {},
12
+ '&::before': {},
13
+ '&::first-letter': {},
14
+ '&::first-line': {},
15
+ });
16
+ `,
17
+ },
18
+ ],
19
+ invalid: [
20
+ {
21
+ name: 'single colon syntax for pseudo elements',
22
+ code: `
23
+ import { css } from '@compiled/react';
24
+
25
+ css({
26
+ '&:after': {},
27
+ '&:before': {},
28
+ '&:first-letter': {},
29
+ '&:first-line': {},
30
+ });
31
+ `,
32
+ output: `
33
+ import { css } from '@compiled/react';
34
+
35
+ css({
36
+ '&::after': {},
37
+ '&::before': {},
38
+ '&::first-letter': {},
39
+ '&::first-line': {},
40
+ });
41
+ `,
42
+ errors: [
43
+ {
44
+ messageId: 'no-legacy-pseudo-element-syntax',
45
+ line: 5,
46
+ column: 13,
47
+ endColumn: 19,
48
+ },
49
+ {
50
+ messageId: 'no-legacy-pseudo-element-syntax',
51
+ line: 6,
52
+ column: 13,
53
+ endColumn: 20,
54
+ },
55
+ {
56
+ messageId: 'no-legacy-pseudo-element-syntax',
57
+ line: 7,
58
+ column: 13,
59
+ endColumn: 26,
60
+ },
61
+ {
62
+ messageId: 'no-legacy-pseudo-element-syntax',
63
+ line: 8,
64
+ column: 13,
65
+ endColumn: 24,
66
+ },
67
+ ],
68
+ },
69
+ {
70
+ name: 'single colon syntax in complex selector',
71
+ code: `
72
+ import { css } from '@compiled/react';
73
+
74
+ css({
75
+ '&:hover:after, &:active:before': {},
76
+ });
77
+ `,
78
+ output: `
79
+ import { css } from '@compiled/react';
80
+
81
+ css({
82
+ '&:hover::after, &:active::before': {},
83
+ });
84
+ `,
85
+ errors: [
86
+ {
87
+ messageId: 'no-legacy-pseudo-element-syntax',
88
+ line: 5,
89
+ column: 19,
90
+ endColumn: 25,
91
+ },
92
+ {
93
+ messageId: 'no-legacy-pseudo-element-syntax',
94
+ line: 5,
95
+ column: 35,
96
+ endColumn: 42,
97
+ },
98
+ ],
99
+ },
100
+ ],
101
+ });