@atlaskit/eslint-plugin-platform 2.4.1 → 2.5.0

package/CHANGELOG.md

@@ -1,5 +1,26 @@
 # @atlaskit/eslint-plugin-platform
 
+## 2.5.0
+
+### Minor Changes
+
+- [#127293](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/127293)
+  [`3ee2e5b640591`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3ee2e5b640591) -
+  Created new rule `@atlaskit/platform/ensure-no-private-dependencies` which ensures that private
+  dependencies are not used in published packages
+
+## 2.4.2
+
+### Patch Changes
+
+- [#120533](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/120533)
+  [`f1bec731e278f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f1bec731e278f) -
+  Adds a `sideEffects` field to ensure this package does not have Compiled styles tree-shaken in the
+  future to avoid an accidental regression.
+
+  This is related to
+  https://community.developer.atlassian.com/t/rfc-73-migrating-our-components-to-compiled-css-in-js/85953
+
 ## 2.4.1
 
 ### Patch Changes

package/dist/cjs/index.js

@@ -18,6 +18,7 @@ var _ensureFeatureFlagPrefix = _interopRequireDefault(require("./rules/ensure-fe
 var _ensureCriticalDependencyResolutions = _interopRequireDefault(require("./rules/ensure-critical-dependency-resolutions"));
 var _ensureValidPlatformYarnProtocolUsage = _interopRequireDefault(require("./rules/ensure-valid-platform-yarn-protocol-usage"));
 var _ensureValidBinValues = _interopRequireDefault(require("./rules/ensure-valid-bin-values"));
+var _ensureNoPrivateDependencies = _interopRequireDefault(require("./rules/ensure-no-private-dependencies"));
 var _expandBorderShorthand = _interopRequireDefault(require("./rules/compiled/expand-border-shorthand"));
 var _noInvalidStorybookDecoratorUsage = _interopRequireDefault(require("./rules/no-invalid-storybook-decorator-usage"));
 var _ensurePublishValid = _interopRequireDefault(require("./rules/ensure-publish-valid"));
@@ -45,6 +46,7 @@ var rules = exports.rules = {
   'ensure-critical-dependency-resolutions': _ensureCriticalDependencyResolutions.default,
   'ensure-valid-platform-yarn-protocol-usage': _ensureValidPlatformYarnProtocolUsage.default,
   'ensure-valid-bin-values': _ensureValidBinValues.default,
+  'ensure-no-private-dependencies': _ensureNoPrivateDependencies.default,
   'expand-border-shorthand': _expandBorderShorthand.default,
   'expand-background-shorthand': _expandBackgroundShorthand.default,
   'expand-spacing-shorthand': _expandSpacingShorthand.default,

package/dist/cjs/rules/ensure-no-private-dependencies/index.js

@@ -0,0 +1,101 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+var _regenerator = _interopRequireDefault(require("@babel/runtime/regenerator"));
+var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
+var _handleAstObject = require("../util/handle-ast-object");
+var _getPackages = require("@manypkg/get-packages");
+var _findRoot = require("@manypkg/find-root");
+function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
+function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
+function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; } // eslint-disable-next-line import/no-extraneous-dependencies
+var root = (0, _findRoot.findRootSync)(process.cwd());
+var pkgs = (0, _getPackages.getPackagesSync)(root).packages;
+var pkgMap = new Map(pkgs.map(function (pkg) {
+  return [pkg.packageJson.name, pkg];
+}));
+var rule = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: "Ensures that private dependencies are not used in published packages.",
+      recommended: true
+    },
+    hasSuggestions: false,
+    messages: {
+      invalidPrivateDependency: "Published package has private dependency '{{ pkgName }}'. To resolve this error, remove the private dependency or set this package to private."
+    }
+  },
+  create: function create(context) {
+    return {
+      ObjectExpression: function () {
+        var _ObjectExpression = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee(node) {
+          var isPrivatePkg, dependencies, peerDependencies, _i, _arr, obj, _iterator, _step, p, key, _pkgMap$get, isPrivateDependency;
+          return _regenerator.default.wrap(function _callee$(_context) {
+            while (1) switch (_context.prev = _context.next) {
+              case 0:
+                if (!(!context.filename.endsWith('package.json') || node.type !== 'ObjectExpression')) {
+                  _context.next = 2;
+                  break;
+                }
+                return _context.abrupt("return");
+              case 2:
+                // Private dependencies can be used in private packages
+                isPrivatePkg = (0, _handleAstObject.getObjectPropertyAsLiteral)(node, 'private') === true;
+                if (!(isPrivatePkg === true)) {
+                  _context.next = 5;
+                  break;
+                }
+                return _context.abrupt("return");
+              case 5:
+                // Check for private dependencies in dependencies and peerDependencies
+                // Note: devDependencies are not checked here as they don't end up in consumer lockfiles
+                dependencies = (0, _handleAstObject.getObjectPropertyAsObject)(node, 'dependencies');
+                peerDependencies = (0, _handleAstObject.getObjectPropertyAsObject)(node, 'peerDependencies');
+                for (_i = 0, _arr = [dependencies, peerDependencies]; _i < _arr.length; _i++) {
+                  obj = _arr[_i];
+                  _iterator = _createForOfIteratorHelper((obj === null || obj === void 0 ? void 0 : obj.properties) || []);
+                  try {
+                    for (_iterator.s(); !(_step = _iterator.n()).done;) {
+                      p = _step.value;
+                      if (p.type === 'Property' && p.key.type === 'Literal') {
+                        key = p.key.value;
+                        if (typeof key === 'string' && pkgMap.has(key)) {
+                          isPrivateDependency = ((_pkgMap$get = pkgMap.get(key)) === null || _pkgMap$get === void 0 ? void 0 : _pkgMap$get.packageJson.private) === true;
+                          if (isPrivateDependency) {
+                            context.report({
+                              node: node,
+                              messageId: 'invalidPrivateDependency',
+                              data: {
+                                pkgName: key
+                              }
+                            });
+                          }
+                        }
+                      }
+                    }
+                  } catch (err) {
+                    _iterator.e(err);
+                  } finally {
+                    _iterator.f();
+                  }
+                }
+              case 8:
+              case "end":
+                return _context.stop();
+            }
+          }, _callee);
+        }));
+        function ObjectExpression(_x) {
+          return _ObjectExpression.apply(this, arguments);
+        }
+        return ObjectExpression;
+      }()
+    };
+  }
+};
+var _default = exports.default = rule;

package/dist/cjs/rules/ensure-valid-platform-yarn-protocol-usage/index.js

@@ -8,7 +8,6 @@ var _handleAstObject = require("../util/handle-ast-object");
 function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
 function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; } // eslint-disable-next-line import/no-extraneous-dependencies
-var workspaceProtocolRegex = /^workspace:[\^~\*]$/;
 var rootProtocolRegex = /^root:[\^~\*]$/;
 
 /**
@@ -21,7 +20,8 @@ function getYarnProtocolsUsed(node) {
   };
   var dependencies = (0, _handleAstObject.getObjectPropertyAsObject)(node, 'dependencies');
   var devDependencies = (0, _handleAstObject.getObjectPropertyAsObject)(node, 'devDependencies');
-  for (var _i = 0, _arr = [dependencies, devDependencies]; _i < _arr.length; _i++) {
+  var peerDependencies = (0, _handleAstObject.getObjectPropertyAsObject)(node, 'peerDependencies');
+  for (var _i = 0, _arr = [dependencies, devDependencies, peerDependencies]; _i < _arr.length; _i++) {
     var obj = _arr[_i];
     var _iterator = _createForOfIteratorHelper((obj === null || obj === void 0 ? void 0 : obj.properties) || []),
       _step;
@@ -30,9 +30,6 @@ function getYarnProtocolsUsed(node) {
         var p = _step.value;
         if (p.type === 'Property' && p.value.type === 'Literal') {
           if (typeof p.value.value === 'string') {
-            if (workspaceProtocolRegex.test(p.value.value)) {
-              protocolsUsed.workspace = true;
-            }
             if (rootProtocolRegex.test(p.value.value)) {
               protocolsUsed.root = true;
             }
@@ -56,7 +53,7 @@ var rule = {
     },
     hasSuggestions: false,
     messages: {
-      invalidWorkspaceProtocolUsage: "The 'workspace:' protocol is not allowed in public packages. To resolve this error, either set the package to private or replace the 'workspace:' protocol with specific package versions (e.g. '^1.0.0').",
+      invalidWorkspaceProtocolUsage: "The 'workspace:^' or 'workspace:~' protocol is Used. To resolve this error, please use the 'workspace:*' protocol instead.",
       invalidRootProtocolUsage: "The 'root:' protocol is not allowed in platform packages. To resolve this error, replace the 'root:' protocol with specific package versions (e.g. '^1.0.0')."
     }
   },
@@ -75,15 +72,6 @@ var rule = {
             messageId: 'invalidRootProtocolUsage'
           });
         }
-
-        // The 'workspace:' protocol can not be used in public packages
-        var isPrivatePackage = (0, _handleAstObject.getObjectPropertyAsLiteral)(node, 'private') === true;
-        if (!isPrivatePackage && yarnProtocolsUsed.workspace) {
-          context.report({
-            node: node,
-            messageId: 'invalidWorkspaceProtocolUsage'
-          });
-        }
       }
     };
   }

package/dist/es2019/index.js

@@ -11,6 +11,7 @@ import ensureFeatureFlagPrefix from './rules/ensure-feature-flag-prefix';
 import ensureCriticalDependencyResolutions from './rules/ensure-critical-dependency-resolutions';
 import ensureValidPlatformYarnProtocolUsage from './rules/ensure-valid-platform-yarn-protocol-usage';
 import ensureValidBinValues from './rules/ensure-valid-bin-values';
+import ensureNoPrivateDependencies from './rules/ensure-no-private-dependencies';
 import expandBorderShorthand from './rules/compiled/expand-border-shorthand';
 import noInvalidStorybookDecoratorUsage from './rules/no-invalid-storybook-decorator-usage';
 import ensurePublishValid from './rules/ensure-publish-valid';
@@ -36,6 +37,7 @@ const rules = {
   'ensure-critical-dependency-resolutions': ensureCriticalDependencyResolutions,
   'ensure-valid-platform-yarn-protocol-usage': ensureValidPlatformYarnProtocolUsage,
   'ensure-valid-bin-values': ensureValidBinValues,
+  'ensure-no-private-dependencies': ensureNoPrivateDependencies,
   'expand-border-shorthand': expandBorderShorthand,
   'expand-background-shorthand': expandBackgroundShorthand,
   'expand-spacing-shorthand': expandSpacingShorthand,

package/dist/es2019/rules/ensure-no-private-dependencies/index.js

@@ -0,0 +1,63 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
+import { getObjectPropertyAsObject, getObjectPropertyAsLiteral } from '../util/handle-ast-object';
+import { getPackagesSync } from '@manypkg/get-packages';
+import { findRootSync } from '@manypkg/find-root';
+const root = findRootSync(process.cwd());
+const pkgs = getPackagesSync(root).packages;
+const pkgMap = new Map(pkgs.map(pkg => [pkg.packageJson.name, pkg]));
+const rule = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: `Ensures that private dependencies are not used in published packages.`,
+      recommended: true
+    },
+    hasSuggestions: false,
+    messages: {
+      invalidPrivateDependency: `Published package has private dependency '{{ pkgName }}'. To resolve this error, remove the private dependency or set this package to private.`
+    }
+  },
+  create(context) {
+    return {
+      ObjectExpression: async node => {
+        // Only run this rule on package.json files
+        if (!context.filename.endsWith('package.json') || node.type !== 'ObjectExpression') {
+          return;
+        }
+
+        // Private dependencies can be used in private packages
+        const isPrivatePkg = getObjectPropertyAsLiteral(node, 'private') === true;
+        if (isPrivatePkg === true) {
+          return;
+        }
+
+        // Check for private dependencies in dependencies and peerDependencies
+        // Note: devDependencies are not checked here as they don't end up in consumer lockfiles
+        const dependencies = getObjectPropertyAsObject(node, 'dependencies');
+        const peerDependencies = getObjectPropertyAsObject(node, 'peerDependencies');
+        for (const obj of [dependencies, peerDependencies]) {
+          for (const p of (obj === null || obj === void 0 ? void 0 : obj.properties) || []) {
+            if (p.type === 'Property' && p.key.type === 'Literal') {
+              const key = p.key.value;
+              if (typeof key === 'string' && pkgMap.has(key)) {
+                var _pkgMap$get;
+                const isPrivateDependency = ((_pkgMap$get = pkgMap.get(key)) === null || _pkgMap$get === void 0 ? void 0 : _pkgMap$get.packageJson.private) === true;
+                if (isPrivateDependency) {
+                  context.report({
+                    node,
+                    messageId: 'invalidPrivateDependency',
+                    data: {
+                      pkgName: key
+                    }
+                  });
+                }
+              }
+            }
+          }
+        }
+      }
+    };
+  }
+};
+export default rule;

package/dist/es2019/rules/ensure-valid-platform-yarn-protocol-usage/index.js

@@ -1,7 +1,6 @@
 // eslint-disable-next-line import/no-extraneous-dependencies
 
-import { getObjectPropertyAsObject, getObjectPropertyAsLiteral } from '../util/handle-ast-object';
-const workspaceProtocolRegex = /^workspace:[\^~\*]$/;
+import { getObjectPropertyAsObject } from '../util/handle-ast-object';
 const rootProtocolRegex = /^root:[\^~\*]$/;
 
 /**
@@ -14,13 +13,11 @@ function getYarnProtocolsUsed(node) {
   };
   const dependencies = getObjectPropertyAsObject(node, 'dependencies');
   const devDependencies = getObjectPropertyAsObject(node, 'devDependencies');
-  for (const obj of [dependencies, devDependencies]) {
+  const peerDependencies = getObjectPropertyAsObject(node, 'peerDependencies');
+  for (const obj of [dependencies, devDependencies, peerDependencies]) {
     for (const p of (obj === null || obj === void 0 ? void 0 : obj.properties) || []) {
       if (p.type === 'Property' && p.value.type === 'Literal') {
         if (typeof p.value.value === 'string') {
-          if (workspaceProtocolRegex.test(p.value.value)) {
-            protocolsUsed.workspace = true;
-          }
           if (rootProtocolRegex.test(p.value.value)) {
             protocolsUsed.root = true;
           }
@@ -39,7 +36,7 @@ const rule = {
     },
     hasSuggestions: false,
     messages: {
-      invalidWorkspaceProtocolUsage: `The 'workspace:' protocol is not allowed in public packages. To resolve this error, either set the package to private or replace the 'workspace:' protocol with specific package versions (e.g. '^1.0.0').`,
+      invalidWorkspaceProtocolUsage: `The 'workspace:^' or 'workspace:~' protocol is Used. To resolve this error, please use the 'workspace:*' protocol instead.`,
       invalidRootProtocolUsage: `The 'root:' protocol is not allowed in platform packages. To resolve this error, replace the 'root:' protocol with specific package versions (e.g. '^1.0.0').`
     }
   },
@@ -58,15 +55,6 @@ const rule = {
             messageId: 'invalidRootProtocolUsage'
           });
         }
-
-        // The 'workspace:' protocol can not be used in public packages
-        const isPrivatePackage = getObjectPropertyAsLiteral(node, 'private') === true;
-        if (!isPrivatePackage && yarnProtocolsUsed.workspace) {
-          context.report({
-            node,
-            messageId: 'invalidWorkspaceProtocolUsage'
-          });
-        }
       }
     };
   }

package/dist/esm/index.js

@@ -14,6 +14,7 @@ import ensureFeatureFlagPrefix from './rules/ensure-feature-flag-prefix';
 import ensureCriticalDependencyResolutions from './rules/ensure-critical-dependency-resolutions';
 import ensureValidPlatformYarnProtocolUsage from './rules/ensure-valid-platform-yarn-protocol-usage';
 import ensureValidBinValues from './rules/ensure-valid-bin-values';
+import ensureNoPrivateDependencies from './rules/ensure-no-private-dependencies';
 import expandBorderShorthand from './rules/compiled/expand-border-shorthand';
 import noInvalidStorybookDecoratorUsage from './rules/no-invalid-storybook-decorator-usage';
 import ensurePublishValid from './rules/ensure-publish-valid';
@@ -39,6 +40,7 @@ var rules = {
   'ensure-critical-dependency-resolutions': ensureCriticalDependencyResolutions,
   'ensure-valid-platform-yarn-protocol-usage': ensureValidPlatformYarnProtocolUsage,
   'ensure-valid-bin-values': ensureValidBinValues,
+  'ensure-no-private-dependencies': ensureNoPrivateDependencies,
   'expand-border-shorthand': expandBorderShorthand,
   'expand-background-shorthand': expandBackgroundShorthand,
   'expand-spacing-shorthand': expandSpacingShorthand,

package/dist/esm/rules/ensure-no-private-dependencies/index.js

@@ -0,0 +1,96 @@
+import _asyncToGenerator from "@babel/runtime/helpers/asyncToGenerator";
+import _regeneratorRuntime from "@babel/runtime/regenerator";
+function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
+function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
+function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
+import { getObjectPropertyAsObject, getObjectPropertyAsLiteral } from '../util/handle-ast-object';
+import { getPackagesSync } from '@manypkg/get-packages';
+import { findRootSync } from '@manypkg/find-root';
+var root = findRootSync(process.cwd());
+var pkgs = getPackagesSync(root).packages;
+var pkgMap = new Map(pkgs.map(function (pkg) {
+  return [pkg.packageJson.name, pkg];
+}));
+var rule = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: "Ensures that private dependencies are not used in published packages.",
+      recommended: true
+    },
+    hasSuggestions: false,
+    messages: {
+      invalidPrivateDependency: "Published package has private dependency '{{ pkgName }}'. To resolve this error, remove the private dependency or set this package to private."
+    }
+  },
+  create: function create(context) {
+    return {
+      ObjectExpression: function () {
+        var _ObjectExpression = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee(node) {
+          var isPrivatePkg, dependencies, peerDependencies, _i, _arr, obj, _iterator, _step, p, key, _pkgMap$get, isPrivateDependency;
+          return _regeneratorRuntime.wrap(function _callee$(_context) {
+            while (1) switch (_context.prev = _context.next) {
+              case 0:
+                if (!(!context.filename.endsWith('package.json') || node.type !== 'ObjectExpression')) {
+                  _context.next = 2;
+                  break;
+                }
+                return _context.abrupt("return");
+              case 2:
+                // Private dependencies can be used in private packages
+                isPrivatePkg = getObjectPropertyAsLiteral(node, 'private') === true;
+                if (!(isPrivatePkg === true)) {
+                  _context.next = 5;
+                  break;
+                }
+                return _context.abrupt("return");
+              case 5:
+                // Check for private dependencies in dependencies and peerDependencies
+                // Note: devDependencies are not checked here as they don't end up in consumer lockfiles
+                dependencies = getObjectPropertyAsObject(node, 'dependencies');
+                peerDependencies = getObjectPropertyAsObject(node, 'peerDependencies');
+                for (_i = 0, _arr = [dependencies, peerDependencies]; _i < _arr.length; _i++) {
+                  obj = _arr[_i];
+                  _iterator = _createForOfIteratorHelper((obj === null || obj === void 0 ? void 0 : obj.properties) || []);
+                  try {
+                    for (_iterator.s(); !(_step = _iterator.n()).done;) {
+                      p = _step.value;
+                      if (p.type === 'Property' && p.key.type === 'Literal') {
+                        key = p.key.value;
+                        if (typeof key === 'string' && pkgMap.has(key)) {
+                          isPrivateDependency = ((_pkgMap$get = pkgMap.get(key)) === null || _pkgMap$get === void 0 ? void 0 : _pkgMap$get.packageJson.private) === true;
+                          if (isPrivateDependency) {
+                            context.report({
+                              node: node,
+                              messageId: 'invalidPrivateDependency',
+                              data: {
+                                pkgName: key
+                              }
+                            });
+                          }
+                        }
+                      }
+                    }
+                  } catch (err) {
+                    _iterator.e(err);
+                  } finally {
+                    _iterator.f();
+                  }
+                }
+              case 8:
+              case "end":
+                return _context.stop();
+            }
+          }, _callee);
+        }));
+        function ObjectExpression(_x) {
+          return _ObjectExpression.apply(this, arguments);
+        }
+        return ObjectExpression;
+      }()
+    };
+  }
+};
+export default rule;

package/dist/esm/rules/ensure-valid-platform-yarn-protocol-usage/index.js

@@ -3,8 +3,7 @@ function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r)
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
 // eslint-disable-next-line import/no-extraneous-dependencies
 
-import { getObjectPropertyAsObject, getObjectPropertyAsLiteral } from '../util/handle-ast-object';
-var workspaceProtocolRegex = /^workspace:[\^~\*]$/;
+import { getObjectPropertyAsObject } from '../util/handle-ast-object';
 var rootProtocolRegex = /^root:[\^~\*]$/;
 
 /**
@@ -17,7 +16,8 @@ function getYarnProtocolsUsed(node) {
   };
   var dependencies = getObjectPropertyAsObject(node, 'dependencies');
   var devDependencies = getObjectPropertyAsObject(node, 'devDependencies');
-  for (var _i = 0, _arr = [dependencies, devDependencies]; _i < _arr.length; _i++) {
+  var peerDependencies = getObjectPropertyAsObject(node, 'peerDependencies');
+  for (var _i = 0, _arr = [dependencies, devDependencies, peerDependencies]; _i < _arr.length; _i++) {
     var obj = _arr[_i];
     var _iterator = _createForOfIteratorHelper((obj === null || obj === void 0 ? void 0 : obj.properties) || []),
       _step;
@@ -26,9 +26,6 @@ function getYarnProtocolsUsed(node) {
         var p = _step.value;
         if (p.type === 'Property' && p.value.type === 'Literal') {
           if (typeof p.value.value === 'string') {
-            if (workspaceProtocolRegex.test(p.value.value)) {
-              protocolsUsed.workspace = true;
-            }
             if (rootProtocolRegex.test(p.value.value)) {
               protocolsUsed.root = true;
             }
@@ -52,7 +49,7 @@ var rule = {
     },
     hasSuggestions: false,
     messages: {
-      invalidWorkspaceProtocolUsage: "The 'workspace:' protocol is not allowed in public packages. To resolve this error, either set the package to private or replace the 'workspace:' protocol with specific package versions (e.g. '^1.0.0').",
+      invalidWorkspaceProtocolUsage: "The 'workspace:^' or 'workspace:~' protocol is Used. To resolve this error, please use the 'workspace:*' protocol instead.",
       invalidRootProtocolUsage: "The 'root:' protocol is not allowed in platform packages. To resolve this error, replace the 'root:' protocol with specific package versions (e.g. '^1.0.0')."
     }
   },
@@ -71,15 +68,6 @@ var rule = {
             messageId: 'invalidRootProtocolUsage'
           });
         }
-
-        // The 'workspace:' protocol can not be used in public packages
-        var isPrivatePackage = getObjectPropertyAsLiteral(node, 'private') === true;
-        if (!isPrivatePackage && yarnProtocolsUsed.workspace) {
-          context.report({
-            node: node,
-            messageId: 'invalidWorkspaceProtocolUsage'
-          });
-        }
       }
     };
   }

package/dist/types/index.d.ts

@@ -8,6 +8,7 @@ declare const rules: {
     'ensure-critical-dependency-resolutions': import("eslint").Rule.RuleModule;
     'ensure-valid-platform-yarn-protocol-usage': import("eslint").Rule.RuleModule;
     'ensure-valid-bin-values': import("eslint").Rule.RuleModule;
+    'ensure-no-private-dependencies': import("eslint").Rule.RuleModule;
     'expand-border-shorthand': import("eslint").Rule.RuleModule;
     'expand-background-shorthand': import("eslint").Rule.RuleModule;
     'expand-spacing-shorthand': import("eslint").Rule.RuleModule;
@@ -41,6 +42,7 @@ declare const plugin: {
         'ensure-critical-dependency-resolutions': import("eslint").Rule.RuleModule;
         'ensure-valid-platform-yarn-protocol-usage': import("eslint").Rule.RuleModule;
         'ensure-valid-bin-values': import("eslint").Rule.RuleModule;
+        'ensure-no-private-dependencies': import("eslint").Rule.RuleModule;
         'expand-border-shorthand': import("eslint").Rule.RuleModule;
         'expand-background-shorthand': import("eslint").Rule.RuleModule;
         'expand-spacing-shorthand': import("eslint").Rule.RuleModule;

package/dist/types/rules/ensure-no-private-dependencies/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/index.d.ts

@@ -8,6 +8,7 @@ declare const rules: {
     'ensure-critical-dependency-resolutions': import("eslint").Rule.RuleModule;
     'ensure-valid-platform-yarn-protocol-usage': import("eslint").Rule.RuleModule;
     'ensure-valid-bin-values': import("eslint").Rule.RuleModule;
+    'ensure-no-private-dependencies': import("eslint").Rule.RuleModule;
     'expand-border-shorthand': import("eslint").Rule.RuleModule;
     'expand-background-shorthand': import("eslint").Rule.RuleModule;
     'expand-spacing-shorthand': import("eslint").Rule.RuleModule;
@@ -41,6 +42,7 @@ declare const plugin: {
         'ensure-critical-dependency-resolutions': import("eslint").Rule.RuleModule;
         'ensure-valid-platform-yarn-protocol-usage': import("eslint").Rule.RuleModule;
         'ensure-valid-bin-values': import("eslint").Rule.RuleModule;
+        'ensure-no-private-dependencies': import("eslint").Rule.RuleModule;
         'expand-border-shorthand': import("eslint").Rule.RuleModule;
         'expand-background-shorthand': import("eslint").Rule.RuleModule;
         'expand-spacing-shorthand': import("eslint").Rule.RuleModule;

package/dist/types-ts4.5/rules/ensure-no-private-dependencies/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@atlaskit/eslint-plugin-platform",
 	"description": "The essential plugin for use with Atlassian frontend platform tools",
-	"version": "2.4.1",
+	"version": "2.5.0",
 	"author": "Atlassian Pty Ltd",
 	"atlassian": {
 		"team": "Build Infra",
@@ -25,7 +25,9 @@
 			]
 		}
 	},
-	"sideEffects": false,
+	"sideEffects": [
+		"*.compiled.css"
+	],
 	"atlaskit:src": "src/index.tsx",
 	"af:exports": {
 		".": "./src/index.tsx"
@@ -35,11 +37,12 @@
 		"@babel/runtime": "^7.0.0",
 		"@compiled/eslint-plugin": "^0.18.2",
 		"@manypkg/find-root": "^1.1.0",
+		"@manypkg/get-packages": "^1.1.3",
 		"fuse.js": "^6.6.2",
 		"read-pkg-up": "^7.0.1"
 	},
 	"devDependencies": {
-		"@atlassian/ts-loader": "*",
+		"@atlassian/ts-loader": "^0.1.0",
 		"@types/eslint": "^8.56.6",
 		"eslint": "^8.57.0",
 		"outdent": "^0.5.0"

package/src/index.tsx

@@ -12,6 +12,7 @@ import ensureFeatureFlagPrefix from './rules/ensure-feature-flag-prefix';
 import ensureCriticalDependencyResolutions from './rules/ensure-critical-dependency-resolutions';
 import ensureValidPlatformYarnProtocolUsage from './rules/ensure-valid-platform-yarn-protocol-usage';
 import ensureValidBinValues from './rules/ensure-valid-bin-values';
+import ensureNoPrivateDependencies from './rules/ensure-no-private-dependencies';
 import expandBorderShorthand from './rules/compiled/expand-border-shorthand';
 import noInvalidStorybookDecoratorUsage from './rules/no-invalid-storybook-decorator-usage';
 import ensurePublishValid from './rules/ensure-publish-valid';
@@ -43,6 +44,7 @@ const rules = {
 	'ensure-critical-dependency-resolutions': ensureCriticalDependencyResolutions,
 	'ensure-valid-platform-yarn-protocol-usage': ensureValidPlatformYarnProtocolUsage,
 	'ensure-valid-bin-values': ensureValidBinValues,
+	'ensure-no-private-dependencies': ensureNoPrivateDependencies,
 	'expand-border-shorthand': expandBorderShorthand,
 	'expand-background-shorthand': expandBackgroundShorthand,
 	'expand-spacing-shorthand': expandSpacingShorthand,

package/src/rules/ensure-no-private-dependencies/__tests__/unit/rule.test.ts

@@ -0,0 +1,212 @@
+import { tester } from '../../../../__tests__/utils/_tester';
+import rule from '../../index';
+
+const cwd = process.cwd();
+
+jest.mock('@manypkg/find-root');
+
+jest.mock('@manypkg/get-packages', () => ({
+	getPackagesSync: () => {
+		return {
+			packages: [
+				// Private packages
+				{
+					packageJson: {
+						name: '@af/private-pkg',
+						private: true,
+					},
+				},
+				{
+					packageJson: {
+						name: '@atlassian/private-pkg',
+						private: true,
+					},
+				},
+				{
+					packageJson: {
+						name: '@atlassiansox/private-pkg',
+						private: true,
+					},
+				},
+				// Public packages
+				{
+					packageJson: {
+						name: '@atlassian/public-pkg',
+						publishConfig: { registry: 'https://pkg-registry.com' },
+					},
+				},
+				{
+					packageJson: {
+						name: '@atlassiansox/public-pkg',
+						publishConfig: { registry: 'https://pkg-registry.com' },
+					},
+				},
+				{
+					packageJson: {
+						name: '@atlaskit/public-pkg',
+						publishConfig: { registry: 'https://pkg-registry.com' },
+					},
+				},
+			],
+		};
+	},
+}));
+
+const getErrorMessage = (pkgName: string) =>
+	`Published package has private dependency '${pkgName}'. To resolve this error, remove the private dependency or set this package to private.`;
+
+describe('test ensure-no-private-dependencies', () => {
+	tester.run('ensure-no-private-dependencies', rule, {
+		valid: [
+			// Private and public dependencies are allowed in private '@af' scoped packages
+			{
+				code: `const foo = {
+				"name:": "@af/test",
+				"private": true,
+				"dependencies": {
+					"@af/private-pkg": "workspace:*",
+					"@af/public-pkg": "workspace:*",
+					"@atlassian/private-pkg": "workspace:*",
+					"@atlassian/public-pkg": "workspace:*",
+					"@atlassiansox/private-pkg": "workspace:*",
+					"@atlassiansox/public-pkg": "workspace:*",
+					"react": "root:*"
+				}
+			}`,
+				filename: `${cwd}/packages/fpp/package.json`,
+			},
+			// Private and public dependencies are allowed in private '@atlassian' scoped packages
+			{
+				code: `const foo = {
+				"name:": "@atlassian/test",
+				"private": true,
+				"dependencies": {
+					"@af/private-pkg": "workspace:*",
+					"@af/public-pkg": "workspace:*",
+					"@atlassian/private-pkg": "workspace:*",
+					"@atlassian/public-pkg": "workspace:*",
+					"@atlassiansox/private-pkg": "workspace:*",
+					"@atlassiansox/public-pkg": "workspace:*",
+					"react": "root:*"
+				}
+			}`,
+				filename: `${cwd}/packages/fpp/package.json`,
+			},
+			// Private dependencies are allowed in private '@atlassiansox' scoped packages
+			{
+				code: `const foo = {
+	        "name:": "@atlassiansox/test",
+	        "private": true,
+	        "dependencies": {
+	          "@af/private-pkg": "workspace:*",
+	          "@atlassian/private-pkg": "workspace:*",
+ 	          "@atlassiansox/private-pkg": "workspace:*",
+ 	          "react": "root:*"
+	        }
+	      }`,
+				filename: `${cwd}/packages/foo/package.json`,
+			},
+			// Private and public dependencies are allowed in private '@atlassiansox' scoped packages
+			{
+				code: `const foo = {
+				"name:": "@atlassiansox/test",
+				"private": true,
+				"dependencies": {
+	        "@af/private-pkg": "workspace:*",
+	        "@af/public-pkg": "workspace:*",
+	        "@atlassian/private-pkg": "workspace:*",
+	        "@atlassian/public-pkg": "workspace:*",
+	        "@atlassiansox/private-pkg": "workspace:*",
+	        "@atlassiansox/public-pkg": "workspace:*",
+	        "react": "root:*"
+				}
+			}`,
+				filename: `${cwd}/packages/fpp/package.json`,
+			},
+		],
+		invalid: [
+			// Disallow private dependencies in public '@atlaskit' scoped packages
+			{
+				code: `const foo = {
+	        "name": "@atlaskit/test",
+	        "publishConfig": { "registry": "https://pkg-registry.com" },
+	        "dependencies": {
+	          "@af/private-pkg": "workspace:*",
+	          "@atlassian/private-pkg": "workspace:*",
+ 	          "@atlassiansox/private-pkg": "workspace:*",
+ 	          "react": "root:*"
+	        }
+				}`,
+				filename: `${cwd}/packages/foo/package.json`,
+				errors: [
+					{
+						message:
+							"Published package has private dependency '@af/private-pkg'. To resolve this error, remove the private dependency or set this package to private.",
+					},
+					{
+						message:
+							"Published package has private dependency '@atlassian/private-pkg'. To resolve this error, remove the private dependency or set this package to private.",
+					},
+					{
+						message:
+							"Published package has private dependency '@atlassiansox/private-pkg'. To resolve this error, remove the private dependency or set this package to private.",
+					},
+				],
+			},
+			// Disallow private dependencies in public '@atlassian' scoped packages
+			{
+				code: `const foo = {
+	        "name": "@atlassian/test",
+	        "publishConfig": { "registry": "https://registry.npmjs.org/" },
+	        "dependencies": {
+	          "@af/private-pkg": "workspace:*",
+	          "@atlassian/private-pkg": "workspace:*",
+ 	          "@atlassiansox/private-pkg": "workspace:*"
+	        }
+	        }`,
+				filename: `${cwd}/packages/foo/package.json`,
+				errors: [
+					{ message: getErrorMessage('@af/private-pkg') },
+					{ message: getErrorMessage('@atlassian/private-pkg') },
+					{ message: getErrorMessage('@atlassiansox/private-pkg') },
+				],
+			},
+			// Disallow private dependencies in public '@atlassiansox' scoped packages
+			{
+				code: `const foo = {
+					"name": "@atlassian/test3",
+					"publishConfig": { "registry": "https://registry.npmjs.org/" },
+					"dependencies": {
+	          "@af/private-pkg": "workspace:*",
+	          "@atlassian/private-pkg": "workspace:*",
+ 	          "@atlassiansox/private-pkg": "workspace:*"
+					}
+					}`,
+				filename: `${cwd}/packages/foo/package.json`,
+				errors: [
+					{ message: getErrorMessage('@af/private-pkg') },
+					{ message: getErrorMessage('@atlassian/private-pkg') },
+					{ message: getErrorMessage('@atlassiansox/private-pkg') },
+				],
+			},
+			// Disallow private peer dependencies
+			{
+				code: `const foo = {
+	        "name": "@atlaskit/test",
+	        "publishConfig": { "registry": "https://registry.npmjs.org/" },
+	        "peerDependencies": {
+	          "@af/private-pkg": "workspace:*",
+	          "@atlassian/private-pkg": "workspace:*",
+ 	          "@atlassiansox/private-pkg": "workspace:*"
+	        }
+					}`,
+				filename: `${cwd}/packages/foo/package.json`,
+				errors: [
+					{ message: getErrorMessage('@af/private-pkg') },
+					{ message: getErrorMessage('@atlassian/private-pkg') },
+					{ message: getErrorMessage('@atlassiansox/private-pkg') },
+				],
+			},
+		],
+	});
+});

package/src/rules/ensure-no-private-dependencies/index.ts

@@ -0,0 +1,64 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+import type { Rule } from 'eslint';
+import { getObjectPropertyAsObject, getObjectPropertyAsLiteral } from '../util/handle-ast-object';
+import { getPackagesSync } from '@manypkg/get-packages';
+import { findRootSync } from '@manypkg/find-root';
+
+const root = findRootSync(process.cwd());
+const pkgs = getPackagesSync(root).packages;
+const pkgMap = new Map(pkgs.map((pkg) => [pkg.packageJson.name, pkg]));
+
+const rule: Rule.RuleModule = {
+	meta: {
+		type: 'problem',
+		docs: {
+			description: `Ensures that private dependencies are not used in published packages.`,
+			recommended: true,
+		},
+		hasSuggestions: false,
+		messages: {
+			invalidPrivateDependency: `Published package has private dependency '{{ pkgName }}'. To resolve this error, remove the private dependency or set this package to private.`,
+		},
+	},
+	create(context) {
+		return {
+			ObjectExpression: async (node: Rule.Node) => {
+				// Only run this rule on package.json files
+				if (!context.filename.endsWith('package.json') || node.type !== 'ObjectExpression') {
+					return;
+				}
+
+				// Private dependencies can be used in private packages
+				const isPrivatePkg = getObjectPropertyAsLiteral(node, 'private') === true;
+				if (isPrivatePkg === true) {
+					return;
+				}
+
+				// Check for private dependencies in dependencies and peerDependencies
+				// Note: devDependencies are not checked here as they don't end up in consumer lockfiles
+				const dependencies = getObjectPropertyAsObject(node, 'dependencies');
+				const peerDependencies = getObjectPropertyAsObject(node, 'peerDependencies');
+
+				for (const obj of [dependencies, peerDependencies]) {
+					for (const p of obj?.properties || []) {
+						if (p.type === 'Property' && p.key.type === 'Literal') {
+							const key = p.key.value;
+							if (typeof key === 'string' && pkgMap.has(key)) {
+								const isPrivateDependency = pkgMap.get(key)?.packageJson.private === true;
+								if (isPrivateDependency) {
+									context.report({
+										node,
+										messageId: 'invalidPrivateDependency',
+										data: { pkgName: key },
+									});
+								}
+							}
+						}
+					}
+				}
+			},
+		};
+	},
+};
+
+export default rule;

package/src/rules/ensure-valid-platform-yarn-protocol-usage/__tests__/unit/rule.test.ts

@@ -6,95 +6,43 @@ const cwd = process.cwd();
 describe('test ensure-valid-platform-yarn-protocol-usage rule', () => {
 	tester.run('workspace protocol', rule, {
 		valid: [
-			// Workspace protocol is allowed in private packages as dependencies
+			// Workspace protocol 'workspace:*' is allowed in packages as dependencies
 			{
 				code: `const foo = {
-            "private": true,
-            "dependencies": {
-              "@atlaskit/button": "workspace:^",
-              "@atlaskit/primitives": "workspace:*",
-              "@atlaskit/tokens": "workspace:*"
-            }
-        }`,
+	        "dependencies": {
+	          "@atlaskit/button": "workspace:*",
+	          "@atlaskit/primitives": "workspace:*",
+	          "@atlaskit/tokens": "workspace:*"
+	        }
+	    }`,
 				filename: `${cwd}/packages/foo/package.json`,
 			},
-			// Workspace protocol is allowed in private packages as devDependencies
+			// Workspace protocol 'workspace:*' is allowed in packages as devDependencies
 			{
 				code: `const foo = {
-            "private": true,
-            "devDependencies": {
-              "@atlaskit/button": "workspace:^",
-              "@atlaskit/primitives": "workspace:^"
-            }
-        }`,
+	        "devDependencies": {
+	          "@atlaskit/button": "workspace:*",
+	          "@atlaskit/primitives": "workspace:*"
+	        }
+	    }`,
 				filename: `${cwd}/packages/foo/package.json`,
 			},
-			// Workspace protocol is allowed in private packages dependencies and devDependencies
+			// Workspace protocol is allowed in packages dependencies and devDependencies
 			{
 				code: `const foo = {
-            "private": true,
-            "dependencies": {
-              "@atlaskit/button": "workspace:^",
-              "@atlaskit/primitives": "workspace:^"
-            },
-            "devDependencies": {
-              "@atlaskit/button": "workspace:^",
-              "@atlaskit/primitives": "workspace:^"
-            }
-        }`,
+	        "dependencies": {
+	          "@atlaskit/button": "workspace:*",
+	          "@atlaskit/primitives": "workspace:*"
+	        },
+	        "devDependencies": {
+	          "@atlaskit/button": "workspace:*",
+	          "@atlaskit/primitives": "workspace:*"
+	        }
+	    }`,
 				filename: `${cwd}/packages/foo/package.json`,
 			},
 		],
-		invalid: [
-			// Workspace protocol is not allowed in public packages as dependencies
-			{
-				code: `const foo = {
-            "dependencies": {
-              "@atlaskit/button": "workspace:^",
-              "@atlaskit/primitives": "workspace:*",
-              "@atlaskit/tokens": "workspace:*"
-            }
-        }`,
-				filename: `${cwd}/packages/foo/package.json`,
-				errors: [
-					{
-						messageId: 'invalidWorkspaceProtocolUsage',
-					},
-				],
-			},
-			// Workspace protocol is not allowed in public packages as devDependencies
-			{
-				code: `const foo = {
-            "devDependencies": {
-              "@atlaskit/button": "workspace:^",
-              "@atlaskit/primitives": "^1.0.0"
-            }
-        }`,
-				filename: `${cwd}/packages/foo/package.json`,
-				errors: [
-					{
-						messageId: 'invalidWorkspaceProtocolUsage',
-					},
-				],
-			},
-			// Workspace protocol is not allowed in public packages as dependencies and devDependencies
-			{
-				code: `const foo = {
-            "dependencies": {
-              "@atlaskit/button": "workspace:^"
-            },
-            "devDependencies": {
-              "@atlaskit/primitives": "workspace:^"
-            }
-        }`,
-				filename: `${cwd}/packages/foo/package.json`,
-				errors: [
-					{
-						messageId: 'invalidWorkspaceProtocolUsage',
-					},
-				],
-			},
-		],
+		invalid: [],
 	});
 
 	tester.run('root: protocol', rule, {
@@ -104,10 +52,10 @@ describe('test ensure-valid-platform-yarn-protocol-usage rule', () => {
 			// 'root:' protocol is not allowed in packages as dependencies
 			{
 				code: `const foo = {
-            "dependencies": {
-              "react": "root:*",
-            }
-        }`,
+	        "dependencies": {
+	          "react": "root:*",
+	        }
+	    }`,
 				filename: `${cwd}/packages/foo/package.json`,
 				errors: [
 					{
@@ -118,11 +66,11 @@ describe('test ensure-valid-platform-yarn-protocol-usage rule', () => {
 			// 'root:' protocol is not allowed in private packages as dependencies
 			{
 				code: `const foo = {
-            "private": true,
-            "dependencies": {
-              "react": "root:*",
-            }
-        }`,
+	        "private": true,
+	        "dependencies": {
+	          "react": "root:*",
+	        }
+	    }`,
 				filename: `${cwd}/packages/foo/package.json`,
 				errors: [
 					{
@@ -133,10 +81,10 @@ describe('test ensure-valid-platform-yarn-protocol-usage rule', () => {
 			// 'root:' protocol is not allowed in public packages as devDependencies
 			{
 				code: `const foo = {
-            "devDependencies": {
-              "react": "root:*",
-            }
-        }`,
+	        "devDependencies": {
+	          "react": "root:*",
+	        }
+	    }`,
 				filename: `${cwd}/packages/foo/package.json`,
 				errors: [
 					{
@@ -147,11 +95,11 @@ describe('test ensure-valid-platform-yarn-protocol-usage rule', () => {
 			// 'root:' protocol is not allowed in private packages as devDependencies
 			{
 				code: `const foo = {
-            "private": true,
-            "devDependencies": {
-              "react": "root:*",
-            }
-        }`,
+	        "private": true,
+	        "devDependencies": {
+	          "react": "root:*",
+	        }
+	    }`,
 				filename: `${cwd}/packages/foo/package.json`,
 				errors: [
 					{
@@ -162,13 +110,13 @@ describe('test ensure-valid-platform-yarn-protocol-usage rule', () => {
 			// 'root:' protocol is not allowed in public packages as dependencies and devDependencies
 			{
 				code: `const foo = {
-            "dependencies": {
-              "lodash": "root:*"
-            },
-            "devDependencies": {
-              "react": "root:*"
-            }
-        }`,
+	        "dependencies": {
+	          "lodash": "root:*"
+	        },
+	        "devDependencies": {
+	          "react": "root:*"
+	        }
+	    }`,
 				filename: `${cwd}/packages/foo/package.json`,
 				errors: [
 					{
@@ -179,14 +127,14 @@ describe('test ensure-valid-platform-yarn-protocol-usage rule', () => {
 			// 'root:' protocol is not allowed in private packages as dependencies and devDependencies
 			{
 				code: `const foo = {
-            "private": true,
-            "dependencies": {
-              "lodash": "root:*"
-            },
-            "devDependencies": {
-              "react": "root:*"
-            }
-        }`,
+	        "private": true,
+	        "dependencies": {
+	          "lodash": "root:*"
+	        },
+	        "devDependencies": {
+	          "react": "root:*"
+	        }
+	    }`,
 				filename: `${cwd}/packages/foo/package.json`,
 				errors: [
 					{

package/src/rules/ensure-valid-platform-yarn-protocol-usage/index.ts

@@ -1,9 +1,8 @@
 // eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 import type { ObjectExpression } from 'estree';
-import { getObjectPropertyAsObject, getObjectPropertyAsLiteral } from '../util/handle-ast-object';
+import { getObjectPropertyAsObject } from '../util/handle-ast-object';
 
-const workspaceProtocolRegex = /^workspace:[\^~\*]$/;
 const rootProtocolRegex = /^root:[\^~\*]$/;
 
 /**
@@ -14,14 +13,12 @@ function getYarnProtocolsUsed(node: ObjectExpression) {
 
 	const dependencies = getObjectPropertyAsObject(node, 'dependencies');
 	const devDependencies = getObjectPropertyAsObject(node, 'devDependencies');
+	const peerDependencies = getObjectPropertyAsObject(node, 'peerDependencies');
 
-	for (const obj of [dependencies, devDependencies]) {
+	for (const obj of [dependencies, devDependencies, peerDependencies]) {
 		for (const p of obj?.properties || []) {
 			if (p.type === 'Property' && p.value.type === 'Literal') {
 				if (typeof p.value.value === 'string') {
-					if (workspaceProtocolRegex.test(p.value.value)) {
-						protocolsUsed.workspace = true;
-					}
 					if (rootProtocolRegex.test(p.value.value)) {
 						protocolsUsed.root = true;
 					}
@@ -42,7 +39,7 @@ const rule: Rule.RuleModule = {
 		},
 		hasSuggestions: false,
 		messages: {
-			invalidWorkspaceProtocolUsage: `The 'workspace:' protocol is not allowed in public packages. To resolve this error, either set the package to private or replace the 'workspace:' protocol with specific package versions (e.g. '^1.0.0').`,
+			invalidWorkspaceProtocolUsage: `The 'workspace:^' or 'workspace:~' protocol is Used. To resolve this error, please use the 'workspace:*' protocol instead.`,
 			invalidRootProtocolUsage: `The 'root:' protocol is not allowed in platform packages. To resolve this error, replace the 'root:' protocol with specific package versions (e.g. '^1.0.0').`,
 		},
 	},
@@ -62,15 +59,6 @@ const rule: Rule.RuleModule = {
 						messageId: 'invalidRootProtocolUsage',
 					});
 				}
-
-				// The 'workspace:' protocol can not be used in public packages
-				const isPrivatePackage = getObjectPropertyAsLiteral(node, 'private') === true;
-				if (!isPrivatePackage && yarnProtocolsUsed.workspace) {
-					context.report({
-						node,
-						messageId: 'invalidWorkspaceProtocolUsage',
-					});
-				}
 			},
 		};
 	},