@atlaskit/eslint-plugin-platform 2.2.1 → 2.4.0

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @atlaskit/eslint-plugin-platform
 
+## 2.4.0
+
+### Minor Changes
+
+- [#113173](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/113173)
+  [`46aad36c62f2f`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/46aad36c62f2f) -
+  Cuts a new changeset to land ESLint v9 changes to NPM fully (shipped internally Feb 5th:
+  https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/109855)
+
+### Patch Changes
+
+- Updated dependencies
+
+## 2.3.0
+
+### Minor Changes
+
+- [#108485](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/108485)
+  [`0c642edaebbbb`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/0c642edaebbbb) -
+  AFB-822 Modifying expand-spacing-shorthand ESLint rule to not throw error for non-token
+  expressions in template strings
+
 ## 2.2.1
 
 ### Patch Changes

package/dist/cjs/index.js

@@ -74,7 +74,7 @@ var commonConfig = {
   // Compiled: rules that are not included via `@compiled/recommended
   '@atlaskit/platform/expand-border-shorthand': 'error',
   '@atlaskit/platform/expand-background-shorthand': 'error',
-  '@atlaskit/platform/expand-spacing-shorthand': 'off',
+  '@atlaskit/platform/expand-spacing-shorthand': 'error',
   '@compiled/jsx-pragma': ['error', {
     importSources: ['@atlaskit/css'],
     onlyRunIfImportingCompiled: true,

package/dist/cjs/rules/compiled/expand-border-shorthand/index.js

@@ -5,7 +5,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.expandBorderShorthand = exports.default = void 0;
 var EXCLUDED_VALUES = ['0', 'none', 'unset', 'none !important'];
-var findCallExpression = function findCallExpression(node) {
+var _findCallExpression = function findCallExpression(node) {
   var parent = node.parent;
   if (!parent) {
     return null;
@@ -13,7 +13,7 @@ var findCallExpression = function findCallExpression(node) {
   if (parent.type === 'CallExpression') {
     return parent;
   }
-  return findCallExpression(parent);
+  return _findCallExpression(parent);
 };
 var separateBorderProperties = function separateBorderProperties(borderString, property, context) {
   if (EXCLUDED_VALUES.includes(borderString)) {
@@ -58,11 +58,11 @@ var expandBorderShorthand = exports.expandBorderShorthand = {
   create: function create(context) {
     var importDeclaration;
     return {
-      'ImportDeclaration[source.value="@compiled/react"], ImportDeclaration[source.value="@atlaskit/css"]': function ImportDeclarationSourceValueCompiledReactImportDeclarationSourceValueAtlaskitCss(node) {
+      'ImportDeclaration[source.value="@compiled/react"], ImportDeclaration[source.value="@atlaskit/css"]': function ImportDeclarationSourceValueCompiled_react_ImportDeclarationSourceValueAtlaskit_css(node) {
         importDeclaration = node;
       },
       'Property[key.name="border"]': function PropertyKeyNameBorder(node) {
-        var callExpression = findCallExpression(node);
+        var callExpression = _findCallExpression(node);
         if (!callExpression) {
           return;
         }

package/dist/cjs/rules/compiled/expand-spacing-shorthand/index.js

@@ -48,15 +48,23 @@ var parseTemplateLiteral = function parseTemplateLiteral(templateLiteral, contex
 };
 
 /**
- * Checks if the parsed property values are valid (i.e. no rule violation will be thrown). Cases are, the property values:
- * 1. Do not contain a token
- * 2. Have length that are not in the range [1, 4]
- * 3. Includes `calc(...)`
+ * Checks if the parsed property values are valid; values that we shouldn't handle with the fixer:
+ * 1. At least one expression in TemplateLiteral is not a token expression
+ * 2. Do not contain a token
+ * 3. Have length that are not in the range [1, 4] for different spacing directions
+ * 		- No more than 4 to exclude additional values such as `!important`
+ * 4. Includes `calc(...)`
  * Then, the rule will return with no error
  * @param propertyValues property values parsed as list of strings
  * @returns boolean
  */
-var isPropertyValueExempted = function isPropertyValueExempted(propertyValues) {
+var isPropertyValueExempted = function isPropertyValueExempted(templateLiteral, propertyValues) {
+  var expressions = templateLiteral.expressions;
+  if (!expressions.every(function (expr) {
+    return expr.type === 'CallExpression' && isTokenCallExpression(expr);
+  })) {
+    return true;
+  }
   if (!propertyValues.some(function (str) {
     return str.includes('token(');
   })) {
@@ -74,21 +82,14 @@ var isPropertyValueExempted = function isPropertyValueExempted(propertyValues) {
 };
 
 /**
- * Checks if the parsed property values are invalid (i.e. rule violation thrown) and autofix required. Cases are when:
- *  1. All expressions in TemplateLiteral are token expressions
- *  2. Property values must have a format which includes -> e.g. 2, '2(rem|em|px)', auto, initial, inherit, token(...)
+ *  Checks if the parsed property values are invalid (i.e. rule violation thrown) and autofix required. Cases are when
+ *  property values must have a format which includes -> e.g. 2, '2(rem|em|px)', auto, initial, inherit, token(...)
  *  The rule will return with error and provide a fix
  * @param templateLiteral TemplateLiteral AST Node
  * @param propertyValues property values parsed as list of strings
  * @returns boolean
  */
-var isPropertyValuesInvalidFix = function isPropertyValuesInvalidFix(templateLiteral, propertyValues) {
-  var expressions = templateLiteral.expressions;
-  if (!expressions.every(function (expr) {
-    return expr.type === 'CallExpression' && isTokenCallExpression(expr);
-  })) {
-    return false;
-  }
+var isPropertyValuesInvalidFix = function isPropertyValuesInvalidFix(propertyValues) {
   var _iterator = _createForOfIteratorHelper(propertyValues),
     _step;
   try {
@@ -182,11 +183,11 @@ var executeExpandSpacingRule = function executeExpandSpacingRule(context, node,
   }
   if (node.value.type === 'TemplateLiteral') {
     var propertyValues = parseTemplateLiteral(node.value, context);
-    if (isPropertyValueExempted(propertyValues)) {
+    if (isPropertyValueExempted(node.value, propertyValues)) {
       // Valid, so no error should be thrown
       return;
     }
-    if (isPropertyValuesInvalidFix(node.value, propertyValues)) {
+    if (isPropertyValuesInvalidFix(propertyValues)) {
       // Invalid, so error should be thrown and fix provided
       context.report({
         node: node,

package/dist/cjs/rules/ensure-test-runner-arguments/index.js

@@ -25,7 +25,7 @@ var rule = {
     }
   },
   create: function create(context) {
-    return (0, _defineProperty2.default)({}, "CallExpression[callee.name=/".concat(TEST_RUNNER_IDENTIFIER, "/]"), function CallExpressionCalleeName(node) {
+    return (0, _defineProperty2.default)({}, "CallExpression[callee.name=/".concat(TEST_RUNNER_IDENTIFIER, "/]"), function CallExpressionCalleeName__(node) {
       if (node.type === 'CallExpression') {
         var _node$parent, _node$parent2;
         var args = node.arguments;

package/dist/cjs/rules/ensure-test-runner-nested-count/index.js

@@ -49,7 +49,7 @@ var rule = {
     }
   },
   create: function create(context) {
-    return (0, _defineProperty2.default)({}, "Program > * > CallExpression[callee.name=/".concat(TEST_RUNNER_IDENTIFIER, "/], CallExpression[callee.name=/describe/] > * > * > * > CallExpression[callee.name=/").concat(TEST_RUNNER_IDENTIFIER, "/]"), function ProgramCallExpressionCalleeNameCallExpressionCalleeNameDescribeCallExpressionCalleeName(node) {
+    return (0, _defineProperty2.default)({}, "Program > * > CallExpression[callee.name=/".concat(TEST_RUNNER_IDENTIFIER, "/], CallExpression[callee.name=/describe/] > * > * > * > CallExpression[callee.name=/").concat(TEST_RUNNER_IDENTIFIER, "/]"), function Program____CallExpressionCalleeName___CallExpressionCalleeName_describe_________CallExpressionCalleeName__(node) {
       if (node.type === 'CallExpression') {
         // Calculate the depth of nested test runners, counting from the most outside
         var depth = getDepthOfNestedRunner(node);

package/dist/cjs/rules/feature-gating/inline-usage/index.js

@@ -9,15 +9,15 @@ var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/sli
 var _utils = require("../utils");
 var FUNCTION_NAMES = new Set(['ff', 'fg', 'expVal', 'expValEquals', 'UNSAFE_noExposureExp']);
 var STATSIG_ONLY_FUNCTION_NAMES = new Set(['fg', 'expVal', 'expValEquals', 'UNSAFE_noExposureExp']);
-var findDefinitionDeclaration = function findDefinitionDeclaration(node) {
-  return node.type === 'VariableDeclaration' || node.type === 'FunctionDeclaration' ? node : findDefinitionDeclaration(node.parent);
+var _findDefinitionDeclaration = function findDefinitionDeclaration(node) {
+  return node.type === 'VariableDeclaration' || node.type === 'FunctionDeclaration' ? node : _findDefinitionDeclaration(node.parent);
 };
 var validateCallExpression = function validateCallExpression(node, context) {
   var targetedFunctionsSwitch = context.options[0] === 'ssOnly' ? STATSIG_ONLY_FUNCTION_NAMES : FUNCTION_NAMES;
   var callee = node.callee;
   var shouldWarn = callee.type === 'Identifier' && targetedFunctionsSwitch.has(callee.name) && (0, _utils.isAPIimport)(callee.name, context, node);
   if (shouldWarn) {
-    var defDeclaration = findDefinitionDeclaration(node.parent);
+    var defDeclaration = _findDefinitionDeclaration(node.parent);
     context.report({
       messageId: 'inlineUsage',
       node: defDeclaration.parent.type === 'ExportNamedDeclaration' ? defDeclaration.parent : defDeclaration
@@ -74,13 +74,16 @@ var rule = {
       description: 'Ensure feature flags/gates and experiments are inlined so that they can be statically analyzable.',
       url: 'https://stash.atlassian.com/projects/ATLASSIAN/repos/atlassian-frontend-monorepo/browse/platform/packages/platform/eslint-plugin/src/rules/inline-usage/README.md'
     },
+    schema: [{
+      enum: ['ssOnly']
+    }],
     messages: {
       inlineUsage: 'Do not export or wrap feature flags/gates and experiments usages. Inline calls at the callsite to ensure it is statically analyzable.'
     }
   },
   create: function create(context) {
     return {
-      'VariableDeclaration[declarations.length=1] > VariableDeclarator[id.type="Identifier"]:matches([init.type="ArrowFunctionExpression"], [init.type="FunctionExpression"]) > *.init': function VariableDeclarationDeclarationsLength1VariableDeclaratorIdTypeIdentifierMatchesInitTypeArrowFunctionExpressionInitTypeFunctionExpressionInit(_ref2) {
+      'VariableDeclaration[declarations.length=1] > VariableDeclarator[id.type="Identifier"]:matches([init.type="ArrowFunctionExpression"], [init.type="FunctionExpression"]) > *.init': function VariableDeclarationDeclarationsLength1__VariableDeclaratorIdTypeIdentifierMatchesInitTypeArrowFunctionExpression_InitTypeFunctionExpression__Init(_ref2) {
         var body = _ref2.body;
         validateFunctionBody(body, context);
       },

package/dist/cjs/rules/feature-gating/no-alias/index.js

@@ -46,7 +46,7 @@ var rule = {
           }
         });
       },
-      'VariableDeclaration[kind="const"] > VariableDeclarator[id.type="Identifier"][init.type="Identifier"]': function VariableDeclarationKindConstVariableDeclaratorIdTypeIdentifierInitTypeIdentifier(node) {
+      'VariableDeclaration[kind="const"] > VariableDeclarator[id.type="Identifier"][init.type="Identifier"]': function VariableDeclarationKindConst__VariableDeclaratorIdTypeIdentifierInitTypeIdentifier(node) {
         if (!node.init || node.init.type !== 'Identifier') {
           return;
         }

package/dist/cjs/rules/feature-gating/no-preconditioning/index.js

@@ -11,10 +11,10 @@ var isAndExpression = function isAndExpression(node) {
 var isExpUsage = function isExpUsage(calleeName) {
   return calleeName === 'expVal' || calleeName === 'expValEquals';
 };
-var getGateType = function getGateType(node, context) {
+var _getGateType = function getGateType(node, context) {
   var type = node.type;
   if (type === 'BinaryExpression') {
-    return getGateType(node.left, context) || getGateType(node.right, context);
+    return _getGateType(node.left, context) || _getGateType(node.right, context);
   }
   if (node.type === 'CallExpression') {
     var callee = node.callee;
@@ -29,9 +29,9 @@ var getPreconditionStatus = function getPreconditionStatus(logicalExpression, co
   var _ref = logicalExpression,
     left = _ref.left;
   // If left side is a nested AND expression then the left side node is on the nested's right
-  var leftGateType = getGateType(isAndExpression(left) ? left.right : left, context);
+  var leftGateType = _getGateType(isAndExpression(left) ? left.right : left, context);
   if (leftGateType) {
-    var rightGateType = getGateType(logicalExpression.right, context);
+    var rightGateType = _getGateType(logicalExpression.right, context);
     // Check this scenario: fg('gate') && isAdmin
     if (!rightGateType) {
       return 'early-exposure';

package/dist/cjs/rules/feature-gating/use-recommended-utils/index.js

@@ -20,7 +20,7 @@ var rule = {
   },
   create: function create(context) {
     return {
-      'CallExpression > MemberExpression:matches([property.name="checkGate"])': function CallExpressionMemberExpressionMatchesPropertyNameCheckGate(node) {
+      'CallExpression > MemberExpression:matches([property.name="checkGate"])': function CallExpression__MemberExpressionMatchesPropertyNameCheckGate(node) {
         if (node.object.type === 'Identifier' && (0, _utils.isIdentifierImportedFrom)(node.object.name, BANNED_IMPORTS_SET, context, node)) {
           context.report({
             messageId: 'useRecommended',
@@ -33,7 +33,7 @@ var rule = {
           });
         }
       },
-      'CallExpression > MemberExpression:matches([property.name="getExperimentValue"])': function CallExpressionMemberExpressionMatchesPropertyNameGetExperimentValue(node) {
+      'CallExpression > MemberExpression:matches([property.name="getExperimentValue"])': function CallExpression__MemberExpressionMatchesPropertyNameGetExperimentValue(node) {
         if (node.object.type === 'Identifier' && (0, _utils.isIdentifierImportedFrom)(node.object.name, BANNED_IMPORTS_SET, context, node)) {
           context.report({
             messageId: 'notSupported',

package/dist/cjs/rules/no-duplicate-dependencies/index.js

@@ -27,11 +27,11 @@ var rule = {
     var dependencies = new Map();
     var devDependencies = new Map();
     return {
-      'ObjectExpression Property[key.value=dependencies] Property': function ObjectExpressionPropertyKeyValueDependenciesProperty(node) {
+      'ObjectExpression Property[key.value=dependencies] Property': function ObjectExpression_PropertyKeyValueDependencies_Property(node) {
         // @ts-expect-error
         dependencies.set(node.key.value, node.key);
       },
-      'ObjectExpression Property[key.value=devDependencies] Property': function ObjectExpressionPropertyKeyValueDevDependenciesProperty(node) {
+      'ObjectExpression Property[key.value=devDependencies] Property': function ObjectExpression_PropertyKeyValueDevDependencies_Property(node) {
         // @ts-expect-error
         devDependencies.set(node.key.value, node.key);
       },

package/dist/cjs/rules/no-invalid-feature-flag-usage/index.js

@@ -9,12 +9,12 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 // eslint-disable-next-line import/no-extraneous-dependencies
 
 var FF_GETTER_BOOLEAN_IDENTIFIER = 'getBooleanFF';
-var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression(root, ignoredNode) {
+var _isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression(root, ignoredNode) {
   switch (root.type) {
     case 'IfStatement':
-      return __isOnlyOneFlagCheckInExpression(root.test, ignoredNode);
+      return _isOnlyOneFlagCheckInExpression(root.test, ignoredNode);
     case 'UnaryExpression':
-      return __isOnlyOneFlagCheckInExpression(root.argument, ignoredNode);
+      return _isOnlyOneFlagCheckInExpression(root.argument, ignoredNode);
     case 'CallExpression':
       if (root === ignoredNode) {
         return true;
@@ -26,7 +26,7 @@ var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression
       return root.name !== FF_GETTER_BOOLEAN_IDENTIFIER;
     case 'BinaryExpression':
     case 'LogicalExpression':
-      return __isOnlyOneFlagCheckInExpression(root.left, ignoredNode) && __isOnlyOneFlagCheckInExpression(root.right, ignoredNode);
+      return _isOnlyOneFlagCheckInExpression(root.left, ignoredNode) && _isOnlyOneFlagCheckInExpression(root.right, ignoredNode);
     default:
       return true;
   }
@@ -38,7 +38,7 @@ var isOnlyOneFlagCheckInExpression = function isOnlyOneFlagCheckInExpression(nod
   while (root.type.endsWith('Expression')) {
     root = root.parent;
   }
-  return __isOnlyOneFlagCheckInExpression(root, node);
+  return _isOnlyOneFlagCheckInExpression(root, node);
 };
 var rule = {
   meta: {
@@ -55,7 +55,7 @@ var rule = {
     }
   },
   create: function create(context) {
-    return (0, _defineProperty2.default)({}, "CallExpression[callee.name=/".concat(FF_GETTER_BOOLEAN_IDENTIFIER, "/]"), function CallExpressionCalleeName(node) {
+    return (0, _defineProperty2.default)({}, "CallExpression[callee.name=/".concat(FF_GETTER_BOOLEAN_IDENTIFIER, "/]"), function CallExpressionCalleeName__(node) {
       var _node$parent2;
       // to make typescript happy
       if (node.type === 'CallExpression') {

package/dist/cjs/rules/no-invalid-storybook-decorator-usage/index.js

@@ -21,7 +21,7 @@ var rule = {
     }
   },
   create: function create(context) {
-    return (0, _defineProperty2.default)({}, "CallExpression[callee.name=/".concat(STORYBOOK_DECORATOR_IDENTIFIER, "/]"), function CallExpressionCalleeName(node) {
+    return (0, _defineProperty2.default)({}, "CallExpression[callee.name=/".concat(STORYBOOK_DECORATOR_IDENTIFIER, "/]"), function CallExpressionCalleeName__(node) {
       // to make typescript happy
       if (node.type === 'CallExpression') {
         var args = node.arguments;

package/dist/cjs/rules/no-pre-post-installs/index.js

@@ -20,7 +20,7 @@ var rule = {
   },
   create: function create(context) {
     return {
-      'ObjectExpression Property[key.value=scripts] Property[key.value=/^(pre|post)install$/]': function ObjectExpressionPropertyKeyValueScriptsPropertyKeyValuePrePostInstall$(node) {
+      'ObjectExpression Property[key.value=scripts] Property[key.value=/^(pre|post)install$/]': function ObjectExpression_PropertyKeyValueScripts_PropertyKeyValue_PrePostInstall$_(node) {
         if (!context.getFilename().endsWith('/package.json')) {
           return;
         }

package/dist/es2019/index.js

@@ -65,7 +65,7 @@ const commonConfig = {
   // Compiled: rules that are not included via `@compiled/recommended
   '@atlaskit/platform/expand-border-shorthand': 'error',
   '@atlaskit/platform/expand-background-shorthand': 'error',
-  '@atlaskit/platform/expand-spacing-shorthand': 'off',
+  '@atlaskit/platform/expand-spacing-shorthand': 'error',
   '@compiled/jsx-pragma': ['error', {
     importSources: ['@atlaskit/css'],
     onlyRunIfImportingCompiled: true,

package/dist/es2019/rules/compiled/expand-spacing-shorthand/index.js

@@ -37,15 +37,21 @@ const parseTemplateLiteral = (templateLiteral, context) => {
 };
 
 /**
- * Checks if the parsed property values are valid (i.e. no rule violation will be thrown). Cases are, the property values:
- * 1. Do not contain a token
- * 2. Have length that are not in the range [1, 4]
- * 3. Includes `calc(...)`
+ * Checks if the parsed property values are valid; values that we shouldn't handle with the fixer:
+ * 1. At least one expression in TemplateLiteral is not a token expression
+ * 2. Do not contain a token
+ * 3. Have length that are not in the range [1, 4] for different spacing directions
+ * 		- No more than 4 to exclude additional values such as `!important`
+ * 4. Includes `calc(...)`
  * Then, the rule will return with no error
  * @param propertyValues property values parsed as list of strings
  * @returns boolean
  */
-const isPropertyValueExempted = propertyValues => {
+const isPropertyValueExempted = (templateLiteral, propertyValues) => {
+  const expressions = templateLiteral.expressions;
+  if (!expressions.every(expr => expr.type === 'CallExpression' && isTokenCallExpression(expr))) {
+    return true;
+  }
   if (!propertyValues.some(str => str.includes('token('))) {
     return true;
   }
@@ -59,19 +65,14 @@ const isPropertyValueExempted = propertyValues => {
 };
 
 /**
- * Checks if the parsed property values are invalid (i.e. rule violation thrown) and autofix required. Cases are when:
- *  1. All expressions in TemplateLiteral are token expressions
- *  2. Property values must have a format which includes -> e.g. 2, '2(rem|em|px)', auto, initial, inherit, token(...)
+ *  Checks if the parsed property values are invalid (i.e. rule violation thrown) and autofix required. Cases are when
+ *  property values must have a format which includes -> e.g. 2, '2(rem|em|px)', auto, initial, inherit, token(...)
  *  The rule will return with error and provide a fix
  * @param templateLiteral TemplateLiteral AST Node
  * @param propertyValues property values parsed as list of strings
  * @returns boolean
  */
-const isPropertyValuesInvalidFix = (templateLiteral, propertyValues) => {
-  const expressions = templateLiteral.expressions;
-  if (!expressions.every(expr => expr.type === 'CallExpression' && isTokenCallExpression(expr))) {
-    return false;
-  }
+const isPropertyValuesInvalidFix = propertyValues => {
   for (const propValue of propertyValues) {
     if (propValue === '0') {
       continue;
@@ -139,11 +140,11 @@ const executeExpandSpacingRule = (context, node, propertyShorthand) => {
   }
   if (node.value.type === 'TemplateLiteral') {
     const propertyValues = parseTemplateLiteral(node.value, context);
-    if (isPropertyValueExempted(propertyValues)) {
+    if (isPropertyValueExempted(node.value, propertyValues)) {
       // Valid, so no error should be thrown
       return;
     }
-    if (isPropertyValuesInvalidFix(node.value, propertyValues)) {
+    if (isPropertyValuesInvalidFix(propertyValues)) {
       // Invalid, so error should be thrown and fix provided
       context.report({
         node,

package/dist/es2019/rules/feature-gating/inline-usage/index.js

@@ -68,6 +68,9 @@ const rule = {
       description: 'Ensure feature flags/gates and experiments are inlined so that they can be statically analyzable.',
       url: 'https://stash.atlassian.com/projects/ATLASSIAN/repos/atlassian-frontend-monorepo/browse/platform/packages/platform/eslint-plugin/src/rules/inline-usage/README.md'
     },
+    schema: [{
+      enum: ['ssOnly']
+    }],
     messages: {
       inlineUsage: 'Do not export or wrap feature flags/gates and experiments usages. Inline calls at the callsite to ensure it is statically analyzable.'
     }

package/dist/esm/index.js

@@ -68,7 +68,7 @@ var commonConfig = {
   // Compiled: rules that are not included via `@compiled/recommended
   '@atlaskit/platform/expand-border-shorthand': 'error',
   '@atlaskit/platform/expand-background-shorthand': 'error',
-  '@atlaskit/platform/expand-spacing-shorthand': 'off',
+  '@atlaskit/platform/expand-spacing-shorthand': 'error',
   '@compiled/jsx-pragma': ['error', {
     importSources: ['@atlaskit/css'],
     onlyRunIfImportingCompiled: true,

package/dist/esm/rules/compiled/expand-border-shorthand/index.js

@@ -1,5 +1,5 @@
 var EXCLUDED_VALUES = ['0', 'none', 'unset', 'none !important'];
-var findCallExpression = function findCallExpression(node) {
+var _findCallExpression = function findCallExpression(node) {
   var parent = node.parent;
   if (!parent) {
     return null;
@@ -7,7 +7,7 @@ var findCallExpression = function findCallExpression(node) {
   if (parent.type === 'CallExpression') {
     return parent;
   }
-  return findCallExpression(parent);
+  return _findCallExpression(parent);
 };
 var separateBorderProperties = function separateBorderProperties(borderString, property, context) {
   if (EXCLUDED_VALUES.includes(borderString)) {
@@ -52,11 +52,11 @@ export var expandBorderShorthand = {
   create: function create(context) {
     var importDeclaration;
     return {
-      'ImportDeclaration[source.value="@compiled/react"], ImportDeclaration[source.value="@atlaskit/css"]': function ImportDeclarationSourceValueCompiledReactImportDeclarationSourceValueAtlaskitCss(node) {
+      'ImportDeclaration[source.value="@compiled/react"], ImportDeclaration[source.value="@atlaskit/css"]': function ImportDeclarationSourceValueCompiled_react_ImportDeclarationSourceValueAtlaskit_css(node) {
         importDeclaration = node;
       },
       'Property[key.name="border"]': function PropertyKeyNameBorder(node) {
-        var callExpression = findCallExpression(node);
+        var callExpression = _findCallExpression(node);
         if (!callExpression) {
           return;
         }

package/dist/esm/rules/compiled/expand-spacing-shorthand/index.js

@@ -41,15 +41,23 @@ var parseTemplateLiteral = function parseTemplateLiteral(templateLiteral, contex
 };
 
 /**
- * Checks if the parsed property values are valid (i.e. no rule violation will be thrown). Cases are, the property values:
- * 1. Do not contain a token
- * 2. Have length that are not in the range [1, 4]
- * 3. Includes `calc(...)`
+ * Checks if the parsed property values are valid; values that we shouldn't handle with the fixer:
+ * 1. At least one expression in TemplateLiteral is not a token expression
+ * 2. Do not contain a token
+ * 3. Have length that are not in the range [1, 4] for different spacing directions
+ * 		- No more than 4 to exclude additional values such as `!important`
+ * 4. Includes `calc(...)`
  * Then, the rule will return with no error
  * @param propertyValues property values parsed as list of strings
  * @returns boolean
  */
-var isPropertyValueExempted = function isPropertyValueExempted(propertyValues) {
+var isPropertyValueExempted = function isPropertyValueExempted(templateLiteral, propertyValues) {
+  var expressions = templateLiteral.expressions;
+  if (!expressions.every(function (expr) {
+    return expr.type === 'CallExpression' && isTokenCallExpression(expr);
+  })) {
+    return true;
+  }
   if (!propertyValues.some(function (str) {
     return str.includes('token(');
   })) {
@@ -67,21 +75,14 @@ var isPropertyValueExempted = function isPropertyValueExempted(propertyValues) {
 };
 
 /**
- * Checks if the parsed property values are invalid (i.e. rule violation thrown) and autofix required. Cases are when:
- *  1. All expressions in TemplateLiteral are token expressions
- *  2. Property values must have a format which includes -> e.g. 2, '2(rem|em|px)', auto, initial, inherit, token(...)
+ *  Checks if the parsed property values are invalid (i.e. rule violation thrown) and autofix required. Cases are when
+ *  property values must have a format which includes -> e.g. 2, '2(rem|em|px)', auto, initial, inherit, token(...)
  *  The rule will return with error and provide a fix
  * @param templateLiteral TemplateLiteral AST Node
  * @param propertyValues property values parsed as list of strings
  * @returns boolean
  */
-var isPropertyValuesInvalidFix = function isPropertyValuesInvalidFix(templateLiteral, propertyValues) {
-  var expressions = templateLiteral.expressions;
-  if (!expressions.every(function (expr) {
-    return expr.type === 'CallExpression' && isTokenCallExpression(expr);
-  })) {
-    return false;
-  }
+var isPropertyValuesInvalidFix = function isPropertyValuesInvalidFix(propertyValues) {
   var _iterator = _createForOfIteratorHelper(propertyValues),
     _step;
   try {
@@ -175,11 +176,11 @@ var executeExpandSpacingRule = function executeExpandSpacingRule(context, node,
   }
   if (node.value.type === 'TemplateLiteral') {
     var propertyValues = parseTemplateLiteral(node.value, context);
-    if (isPropertyValueExempted(propertyValues)) {
+    if (isPropertyValueExempted(node.value, propertyValues)) {
       // Valid, so no error should be thrown
       return;
     }
-    if (isPropertyValuesInvalidFix(node.value, propertyValues)) {
+    if (isPropertyValuesInvalidFix(propertyValues)) {
       // Invalid, so error should be thrown and fix provided
       context.report({
         node: node,

package/dist/esm/rules/ensure-test-runner-arguments/index.js

@@ -18,7 +18,7 @@ var rule = {
     }
   },
   create: function create(context) {
-    return _defineProperty({}, "CallExpression[callee.name=/".concat(TEST_RUNNER_IDENTIFIER, "/]"), function CallExpressionCalleeName(node) {
+    return _defineProperty({}, "CallExpression[callee.name=/".concat(TEST_RUNNER_IDENTIFIER, "/]"), function CallExpressionCalleeName__(node) {
       if (node.type === 'CallExpression') {
         var _node$parent, _node$parent2;
         var args = node.arguments;

package/dist/esm/rules/ensure-test-runner-nested-count/index.js

@@ -42,7 +42,7 @@ var rule = {
     }
   },
   create: function create(context) {
-    return _defineProperty({}, "Program > * > CallExpression[callee.name=/".concat(TEST_RUNNER_IDENTIFIER, "/], CallExpression[callee.name=/describe/] > * > * > * > CallExpression[callee.name=/").concat(TEST_RUNNER_IDENTIFIER, "/]"), function ProgramCallExpressionCalleeNameCallExpressionCalleeNameDescribeCallExpressionCalleeName(node) {
+    return _defineProperty({}, "Program > * > CallExpression[callee.name=/".concat(TEST_RUNNER_IDENTIFIER, "/], CallExpression[callee.name=/describe/] > * > * > * > CallExpression[callee.name=/").concat(TEST_RUNNER_IDENTIFIER, "/]"), function Program____CallExpressionCalleeName___CallExpressionCalleeName_describe_________CallExpressionCalleeName__(node) {
       if (node.type === 'CallExpression') {
         // Calculate the depth of nested test runners, counting from the most outside
         var depth = getDepthOfNestedRunner(node);

package/dist/esm/rules/feature-gating/inline-usage/index.js

@@ -2,15 +2,15 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import { isAPIimport } from '../utils';
 var FUNCTION_NAMES = new Set(['ff', 'fg', 'expVal', 'expValEquals', 'UNSAFE_noExposureExp']);
 var STATSIG_ONLY_FUNCTION_NAMES = new Set(['fg', 'expVal', 'expValEquals', 'UNSAFE_noExposureExp']);
-var findDefinitionDeclaration = function findDefinitionDeclaration(node) {
-  return node.type === 'VariableDeclaration' || node.type === 'FunctionDeclaration' ? node : findDefinitionDeclaration(node.parent);
+var _findDefinitionDeclaration = function findDefinitionDeclaration(node) {
+  return node.type === 'VariableDeclaration' || node.type === 'FunctionDeclaration' ? node : _findDefinitionDeclaration(node.parent);
 };
 var validateCallExpression = function validateCallExpression(node, context) {
   var targetedFunctionsSwitch = context.options[0] === 'ssOnly' ? STATSIG_ONLY_FUNCTION_NAMES : FUNCTION_NAMES;
   var callee = node.callee;
   var shouldWarn = callee.type === 'Identifier' && targetedFunctionsSwitch.has(callee.name) && isAPIimport(callee.name, context, node);
   if (shouldWarn) {
-    var defDeclaration = findDefinitionDeclaration(node.parent);
+    var defDeclaration = _findDefinitionDeclaration(node.parent);
     context.report({
       messageId: 'inlineUsage',
       node: defDeclaration.parent.type === 'ExportNamedDeclaration' ? defDeclaration.parent : defDeclaration
@@ -67,13 +67,16 @@ var rule = {
       description: 'Ensure feature flags/gates and experiments are inlined so that they can be statically analyzable.',
       url: 'https://stash.atlassian.com/projects/ATLASSIAN/repos/atlassian-frontend-monorepo/browse/platform/packages/platform/eslint-plugin/src/rules/inline-usage/README.md'
     },
+    schema: [{
+      enum: ['ssOnly']
+    }],
     messages: {
       inlineUsage: 'Do not export or wrap feature flags/gates and experiments usages. Inline calls at the callsite to ensure it is statically analyzable.'
     }
   },
   create: function create(context) {
     return {
-      'VariableDeclaration[declarations.length=1] > VariableDeclarator[id.type="Identifier"]:matches([init.type="ArrowFunctionExpression"], [init.type="FunctionExpression"]) > *.init': function VariableDeclarationDeclarationsLength1VariableDeclaratorIdTypeIdentifierMatchesInitTypeArrowFunctionExpressionInitTypeFunctionExpressionInit(_ref2) {
+      'VariableDeclaration[declarations.length=1] > VariableDeclarator[id.type="Identifier"]:matches([init.type="ArrowFunctionExpression"], [init.type="FunctionExpression"]) > *.init': function VariableDeclarationDeclarationsLength1__VariableDeclaratorIdTypeIdentifierMatchesInitTypeArrowFunctionExpression_InitTypeFunctionExpression__Init(_ref2) {
         var body = _ref2.body;
         validateFunctionBody(body, context);
       },

package/dist/esm/rules/feature-gating/no-alias/index.js

@@ -39,7 +39,7 @@ var rule = {
           }
         });
       },
-      'VariableDeclaration[kind="const"] > VariableDeclarator[id.type="Identifier"][init.type="Identifier"]': function VariableDeclarationKindConstVariableDeclaratorIdTypeIdentifierInitTypeIdentifier(node) {
+      'VariableDeclaration[kind="const"] > VariableDeclarator[id.type="Identifier"][init.type="Identifier"]': function VariableDeclarationKindConst__VariableDeclaratorIdTypeIdentifierInitTypeIdentifier(node) {
         if (!node.init || node.init.type !== 'Identifier') {
           return;
         }

package/dist/esm/rules/feature-gating/no-preconditioning/index.js

@@ -5,10 +5,10 @@ var isAndExpression = function isAndExpression(node) {
 var isExpUsage = function isExpUsage(calleeName) {
   return calleeName === 'expVal' || calleeName === 'expValEquals';
 };
-var getGateType = function getGateType(node, context) {
+var _getGateType = function getGateType(node, context) {
   var type = node.type;
   if (type === 'BinaryExpression') {
-    return getGateType(node.left, context) || getGateType(node.right, context);
+    return _getGateType(node.left, context) || _getGateType(node.right, context);
   }
   if (node.type === 'CallExpression') {
     var callee = node.callee;
@@ -23,9 +23,9 @@ var getPreconditionStatus = function getPreconditionStatus(logicalExpression, co
   var _ref = logicalExpression,
     left = _ref.left;
   // If left side is a nested AND expression then the left side node is on the nested's right
-  var leftGateType = getGateType(isAndExpression(left) ? left.right : left, context);
+  var leftGateType = _getGateType(isAndExpression(left) ? left.right : left, context);
   if (leftGateType) {
-    var rightGateType = getGateType(logicalExpression.right, context);
+    var rightGateType = _getGateType(logicalExpression.right, context);
     // Check this scenario: fg('gate') && isAdmin
     if (!rightGateType) {
       return 'early-exposure';

package/dist/esm/rules/feature-gating/use-recommended-utils/index.js

@@ -14,7 +14,7 @@ var rule = {
   },
   create: function create(context) {
     return {
-      'CallExpression > MemberExpression:matches([property.name="checkGate"])': function CallExpressionMemberExpressionMatchesPropertyNameCheckGate(node) {
+      'CallExpression > MemberExpression:matches([property.name="checkGate"])': function CallExpression__MemberExpressionMatchesPropertyNameCheckGate(node) {
         if (node.object.type === 'Identifier' && isIdentifierImportedFrom(node.object.name, BANNED_IMPORTS_SET, context, node)) {
           context.report({
             messageId: 'useRecommended',
@@ -27,7 +27,7 @@ var rule = {
           });
         }
       },
-      'CallExpression > MemberExpression:matches([property.name="getExperimentValue"])': function CallExpressionMemberExpressionMatchesPropertyNameGetExperimentValue(node) {
+      'CallExpression > MemberExpression:matches([property.name="getExperimentValue"])': function CallExpression__MemberExpressionMatchesPropertyNameGetExperimentValue(node) {
         if (node.object.type === 'Identifier' && isIdentifierImportedFrom(node.object.name, BANNED_IMPORTS_SET, context, node)) {
           context.report({
             messageId: 'notSupported',

package/dist/esm/rules/no-duplicate-dependencies/index.js

@@ -20,11 +20,11 @@ var rule = {
     var dependencies = new Map();
     var devDependencies = new Map();
     return {
-      'ObjectExpression Property[key.value=dependencies] Property': function ObjectExpressionPropertyKeyValueDependenciesProperty(node) {
+      'ObjectExpression Property[key.value=dependencies] Property': function ObjectExpression_PropertyKeyValueDependencies_Property(node) {
         // @ts-expect-error
         dependencies.set(node.key.value, node.key);
       },
-      'ObjectExpression Property[key.value=devDependencies] Property': function ObjectExpressionPropertyKeyValueDevDependenciesProperty(node) {
+      'ObjectExpression Property[key.value=devDependencies] Property': function ObjectExpression_PropertyKeyValueDevDependencies_Property(node) {
         // @ts-expect-error
         devDependencies.set(node.key.value, node.key);
       },

package/dist/esm/rules/no-invalid-feature-flag-usage/index.js

@@ -2,12 +2,12 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
 // eslint-disable-next-line import/no-extraneous-dependencies
 
 var FF_GETTER_BOOLEAN_IDENTIFIER = 'getBooleanFF';
-var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression(root, ignoredNode) {
+var _isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression(root, ignoredNode) {
   switch (root.type) {
     case 'IfStatement':
-      return __isOnlyOneFlagCheckInExpression(root.test, ignoredNode);
+      return _isOnlyOneFlagCheckInExpression(root.test, ignoredNode);
     case 'UnaryExpression':
-      return __isOnlyOneFlagCheckInExpression(root.argument, ignoredNode);
+      return _isOnlyOneFlagCheckInExpression(root.argument, ignoredNode);
     case 'CallExpression':
       if (root === ignoredNode) {
         return true;
@@ -19,7 +19,7 @@ var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression
       return root.name !== FF_GETTER_BOOLEAN_IDENTIFIER;
     case 'BinaryExpression':
     case 'LogicalExpression':
-      return __isOnlyOneFlagCheckInExpression(root.left, ignoredNode) && __isOnlyOneFlagCheckInExpression(root.right, ignoredNode);
+      return _isOnlyOneFlagCheckInExpression(root.left, ignoredNode) && _isOnlyOneFlagCheckInExpression(root.right, ignoredNode);
     default:
       return true;
   }
@@ -31,7 +31,7 @@ var isOnlyOneFlagCheckInExpression = function isOnlyOneFlagCheckInExpression(nod
   while (root.type.endsWith('Expression')) {
     root = root.parent;
   }
-  return __isOnlyOneFlagCheckInExpression(root, node);
+  return _isOnlyOneFlagCheckInExpression(root, node);
 };
 var rule = {
   meta: {
@@ -48,7 +48,7 @@ var rule = {
     }
   },
   create: function create(context) {
-    return _defineProperty({}, "CallExpression[callee.name=/".concat(FF_GETTER_BOOLEAN_IDENTIFIER, "/]"), function CallExpressionCalleeName(node) {
+    return _defineProperty({}, "CallExpression[callee.name=/".concat(FF_GETTER_BOOLEAN_IDENTIFIER, "/]"), function CallExpressionCalleeName__(node) {
       var _node$parent2;
       // to make typescript happy
       if (node.type === 'CallExpression') {

package/dist/esm/rules/no-invalid-storybook-decorator-usage/index.js

@@ -14,7 +14,7 @@ var rule = {
     }
   },
   create: function create(context) {
-    return _defineProperty({}, "CallExpression[callee.name=/".concat(STORYBOOK_DECORATOR_IDENTIFIER, "/]"), function CallExpressionCalleeName(node) {
+    return _defineProperty({}, "CallExpression[callee.name=/".concat(STORYBOOK_DECORATOR_IDENTIFIER, "/]"), function CallExpressionCalleeName__(node) {
       // to make typescript happy
       if (node.type === 'CallExpression') {
         var args = node.arguments;

package/dist/esm/rules/no-pre-post-installs/index.js

@@ -14,7 +14,7 @@ var rule = {
   },
   create: function create(context) {
     return {
-      'ObjectExpression Property[key.value=scripts] Property[key.value=/^(pre|post)install$/]': function ObjectExpressionPropertyKeyValueScriptsPropertyKeyValuePrePostInstall$(node) {
+      'ObjectExpression Property[key.value=scripts] Property[key.value=/^(pre|post)install$/]': function ObjectExpression_PropertyKeyValueScripts_PropertyKeyValue_PrePostInstall$_(node) {
         if (!context.getFilename().endsWith('/package.json')) {
           return;
         }

package/dist/types/index.d.ts

@@ -82,7 +82,7 @@ declare const plugin: {
                 '@atlaskit/platform/no-module-level-eval-nav4': "error";
                 '@atlaskit/platform/expand-border-shorthand': "error";
                 '@atlaskit/platform/expand-background-shorthand': "error";
-                '@atlaskit/platform/expand-spacing-shorthand': "off";
+                '@atlaskit/platform/expand-spacing-shorthand': "error";
                 '@compiled/jsx-pragma': ["error", {
                     importSources: string[];
                     onlyRunIfImportingCompiled: boolean;
@@ -114,7 +114,7 @@ declare const plugin: {
                 '@atlaskit/platform/no-module-level-eval-nav4': "error";
                 '@atlaskit/platform/expand-border-shorthand': "error";
                 '@atlaskit/platform/expand-background-shorthand': "error";
-                '@atlaskit/platform/expand-spacing-shorthand': "off";
+                '@atlaskit/platform/expand-spacing-shorthand': "error";
                 '@compiled/jsx-pragma': ["error", {
                     importSources: string[];
                     onlyRunIfImportingCompiled: boolean;
@@ -133,7 +133,7 @@ declare const plugin: {
                 '@atlaskit/platform/no-module-level-eval-nav4': "error";
                 '@atlaskit/platform/expand-border-shorthand': "error";
                 '@atlaskit/platform/expand-background-shorthand': "error";
-                '@atlaskit/platform/expand-spacing-shorthand': "off";
+                '@atlaskit/platform/expand-spacing-shorthand': "error";
                 '@compiled/jsx-pragma': ["error", {
                     importSources: string[];
                     onlyRunIfImportingCompiled: boolean;
@@ -155,7 +155,7 @@ declare const plugin: {
                 '@atlaskit/platform/no-module-level-eval-nav4': "error";
                 '@atlaskit/platform/expand-border-shorthand': "error";
                 '@atlaskit/platform/expand-background-shorthand': "error";
-                '@atlaskit/platform/expand-spacing-shorthand': "off";
+                '@atlaskit/platform/expand-spacing-shorthand': "error";
                 '@compiled/jsx-pragma': ["error", {
                     importSources: string[];
                     onlyRunIfImportingCompiled: boolean;
@@ -191,7 +191,7 @@ declare const configs: {
             '@atlaskit/platform/no-module-level-eval-nav4': "error";
             '@atlaskit/platform/expand-border-shorthand': "error";
             '@atlaskit/platform/expand-background-shorthand': "error";
-            '@atlaskit/platform/expand-spacing-shorthand': "off";
+            '@atlaskit/platform/expand-spacing-shorthand': "error";
             '@compiled/jsx-pragma': ["error", {
                 importSources: string[];
                 onlyRunIfImportingCompiled: boolean;
@@ -223,7 +223,7 @@ declare const configs: {
             '@atlaskit/platform/no-module-level-eval-nav4': "error";
             '@atlaskit/platform/expand-border-shorthand': "error";
             '@atlaskit/platform/expand-background-shorthand': "error";
-            '@atlaskit/platform/expand-spacing-shorthand': "off";
+            '@atlaskit/platform/expand-spacing-shorthand': "error";
             '@compiled/jsx-pragma': ["error", {
                 importSources: string[];
                 onlyRunIfImportingCompiled: boolean;
@@ -242,7 +242,7 @@ declare const configs: {
             '@atlaskit/platform/no-module-level-eval-nav4': "error";
             '@atlaskit/platform/expand-border-shorthand': "error";
             '@atlaskit/platform/expand-background-shorthand': "error";
-            '@atlaskit/platform/expand-spacing-shorthand': "off";
+            '@atlaskit/platform/expand-spacing-shorthand': "error";
             '@compiled/jsx-pragma': ["error", {
                 importSources: string[];
                 onlyRunIfImportingCompiled: boolean;
@@ -264,7 +264,7 @@ declare const configs: {
             '@atlaskit/platform/no-module-level-eval-nav4': "error";
             '@atlaskit/platform/expand-border-shorthand': "error";
             '@atlaskit/platform/expand-background-shorthand': "error";
-            '@atlaskit/platform/expand-spacing-shorthand': "off";
+            '@atlaskit/platform/expand-spacing-shorthand': "error";
             '@compiled/jsx-pragma': ["error", {
                 importSources: string[];
                 onlyRunIfImportingCompiled: boolean;

package/dist/types-ts4.5/index.d.ts

@@ -85,7 +85,7 @@ declare const plugin: {
                 '@atlaskit/platform/no-module-level-eval-nav4': "error";
                 '@atlaskit/platform/expand-border-shorthand': "error";
                 '@atlaskit/platform/expand-background-shorthand': "error";
-                '@atlaskit/platform/expand-spacing-shorthand': "off";
+                '@atlaskit/platform/expand-spacing-shorthand': "error";
                 '@compiled/jsx-pragma': [
                     "error",
                     {
@@ -123,7 +123,7 @@ declare const plugin: {
                 '@atlaskit/platform/no-module-level-eval-nav4': "error";
                 '@atlaskit/platform/expand-border-shorthand': "error";
                 '@atlaskit/platform/expand-background-shorthand': "error";
-                '@atlaskit/platform/expand-spacing-shorthand': "off";
+                '@atlaskit/platform/expand-spacing-shorthand': "error";
                 '@compiled/jsx-pragma': [
                     "error",
                     {
@@ -145,7 +145,7 @@ declare const plugin: {
                 '@atlaskit/platform/no-module-level-eval-nav4': "error";
                 '@atlaskit/platform/expand-border-shorthand': "error";
                 '@atlaskit/platform/expand-background-shorthand': "error";
-                '@atlaskit/platform/expand-spacing-shorthand': "off";
+                '@atlaskit/platform/expand-spacing-shorthand': "error";
                 '@compiled/jsx-pragma': [
                     "error",
                     {
@@ -170,7 +170,7 @@ declare const plugin: {
                 '@atlaskit/platform/no-module-level-eval-nav4': "error";
                 '@atlaskit/platform/expand-border-shorthand': "error";
                 '@atlaskit/platform/expand-background-shorthand': "error";
-                '@atlaskit/platform/expand-spacing-shorthand': "off";
+                '@atlaskit/platform/expand-spacing-shorthand': "error";
                 '@compiled/jsx-pragma': [
                     "error",
                     {
@@ -212,7 +212,7 @@ declare const configs: {
             '@atlaskit/platform/no-module-level-eval-nav4': "error";
             '@atlaskit/platform/expand-border-shorthand': "error";
             '@atlaskit/platform/expand-background-shorthand': "error";
-            '@atlaskit/platform/expand-spacing-shorthand': "off";
+            '@atlaskit/platform/expand-spacing-shorthand': "error";
             '@compiled/jsx-pragma': [
                 "error",
                 {
@@ -250,7 +250,7 @@ declare const configs: {
             '@atlaskit/platform/no-module-level-eval-nav4': "error";
             '@atlaskit/platform/expand-border-shorthand': "error";
             '@atlaskit/platform/expand-background-shorthand': "error";
-            '@atlaskit/platform/expand-spacing-shorthand': "off";
+            '@atlaskit/platform/expand-spacing-shorthand': "error";
             '@compiled/jsx-pragma': [
                 "error",
                 {
@@ -272,7 +272,7 @@ declare const configs: {
             '@atlaskit/platform/no-module-level-eval-nav4': "error";
             '@atlaskit/platform/expand-border-shorthand': "error";
             '@atlaskit/platform/expand-background-shorthand': "error";
-            '@atlaskit/platform/expand-spacing-shorthand': "off";
+            '@atlaskit/platform/expand-spacing-shorthand': "error";
             '@compiled/jsx-pragma': [
                 "error",
                 {
@@ -297,7 +297,7 @@ declare const configs: {
             '@atlaskit/platform/no-module-level-eval-nav4': "error";
             '@atlaskit/platform/expand-border-shorthand': "error";
             '@atlaskit/platform/expand-background-shorthand': "error";
-            '@atlaskit/platform/expand-spacing-shorthand': "off";
+            '@atlaskit/platform/expand-spacing-shorthand': "error";
             '@compiled/jsx-pragma': [
                 "error",
                 {

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@atlaskit/eslint-plugin-platform",
 	"description": "The essential plugin for use with Atlassian frontend platform tools",
-	"version": "2.2.1",
+	"version": "2.4.0",
 	"author": "Atlassian Pty Ltd",
 	"atlassian": {
 		"team": "Build Infra",
@@ -31,7 +31,7 @@
 		".": "./src/index.tsx"
 	},
 	"dependencies": {
-		"@atlaskit/eslint-utils": "^1.8.0",
+		"@atlaskit/eslint-utils": "^1.10.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/eslint-plugin": "^0.18.2",
 		"@manypkg/find-root": "^1.1.0",

package/src/index.tsx

@@ -73,7 +73,7 @@ const commonConfig = {
 	// Compiled: rules that are not included via `@compiled/recommended
 	'@atlaskit/platform/expand-border-shorthand': 'error',
 	'@atlaskit/platform/expand-background-shorthand': 'error',
-	'@atlaskit/platform/expand-spacing-shorthand': 'off',
+	'@atlaskit/platform/expand-spacing-shorthand': 'error',
 	'@compiled/jsx-pragma': [
 		'error',
 		{

package/src/rules/compiled/expand-spacing-shorthand/__tests__/rule.test.ts

@@ -79,6 +79,28 @@ const validTestCases = (property: string) => {
 			});
 			`,
 		},
+		// Template literal containing expressions that is not token should only throw error with no autofix
+		{
+			name: `${property}: property value template string where it contains an expression that is not a token`,
+			code: outdent`
+			import {css} from '@compiled/react';
+			const styles = css({
+				${property}: \`\${token('space.100', '8px')} \${gridSize * 2}px\`,
+			});
+			const styles2 = css({
+				padding: \`\${DROPDOWN_HEADER_VERTICAL_PADDING} \${token('space.075','6px')} 
+					\${DROPDOWN_HEADER_VERTICAL_PADDING} \${token('space.200', '16px')}\`,
+			});
+			const styles3 = css({
+				${property}: \`\${token('space.050', '4px')} \${token('space.150', '12px')} \${token('space.150', '12px')} 
+					\${({ isSummaryView }: EditFormContentWrapperProps) =>
+					isSummaryView ? token('space.0', '0') : token('space.150', '12px')}\`,
+			});
+			const styles4 = css({
+				${property}: \`\${token('space.100', '8px')} -\${gridSize}px 0\`,
+			});
+			`,
+		},
 	];
 };
 
@@ -252,26 +274,6 @@ const invalidTestCases = (property: string) => {
 			`,
 			errors: [{ messageId: 'expandSpacingShorthand' }],
 		},
-		// Template literal containing expressions that is not token should only throw error with no autofix
-		{
-			name: `${property}: property value template string where it contains an expression that is not a token`,
-			code: outdent`
-			import {css} from '@compiled/react';
-			const styles = css({
-				${property}: \`\${token('space.100', '8px')} \${gridSize * 2}px\`,
-			});
-			const styles2 = css({
-				padding: \`\${DROPDOWN_HEADER_VERTICAL_PADDING} \${token('space.075','6px')} 
-					\${DROPDOWN_HEADER_VERTICAL_PADDING} \${token('space.200', '16px')}\`,
-			});
-			const styles3 = css({
-				${property}: \`\${token('space.050', '4px')} \${token('space.150', '12px')} \${token('space.150', '12px')} 
-					\${({ isSummaryView }: EditFormContentWrapperProps) =>
-					isSummaryView ? token('space.0', '0') : token('space.150', '12px')}\`,
-			});
-			`,
-			errors: Array.from(Array(3), () => ({ messageId: 'expandSpacingShorthand' })),
-		},
 		// Strings that are not valid property values should not be autofixed (e.g. !important)
 		{
 			name: `${property}: Don't autofix if not able to handle all the string values, e.g !important`,

package/src/rules/compiled/expand-spacing-shorthand/index.ts

@@ -50,15 +50,21 @@ const parseTemplateLiteral = (templateLiteral: TemplateLiteral, context: Rule.Ru
 };
 
 /**
- * Checks if the parsed property values are valid (i.e. no rule violation will be thrown). Cases are, the property values:
- * 1. Do not contain a token
- * 2. Have length that are not in the range [1, 4]
- * 3. Includes `calc(...)`
+ * Checks if the parsed property values are valid; values that we shouldn't handle with the fixer:
+ * 1. At least one expression in TemplateLiteral is not a token expression
+ * 2. Do not contain a token
+ * 3. Have length that are not in the range [1, 4] for different spacing directions
+ * 		- No more than 4 to exclude additional values such as `!important`
+ * 4. Includes `calc(...)`
  * Then, the rule will return with no error
  * @param propertyValues property values parsed as list of strings
  * @returns boolean
  */
-const isPropertyValueExempted = (propertyValues: string[]) => {
+const isPropertyValueExempted = (templateLiteral: TemplateLiteral, propertyValues: string[]) => {
+	const expressions = templateLiteral.expressions;
+	if (!expressions.every((expr) => expr.type === 'CallExpression' && isTokenCallExpression(expr))) {
+		return true;
+	}
 	if (!propertyValues.some((str) => str.includes('token('))) {
 		return true;
 	}
@@ -72,29 +78,31 @@ const isPropertyValueExempted = (propertyValues: string[]) => {
 };
 
 /**
- * Checks if the parsed property values are invalid (i.e. rule violation thrown) and autofix required. Cases are when:
- *  1. All expressions in TemplateLiteral are token expressions
- *  2. Property values must have a format which includes -> e.g. 2, '2(rem|em|px)', auto, initial, inherit, token(...)
+ *  Checks if the parsed property values are invalid (i.e. rule violation thrown) and autofix required. Cases are when
+ *  property values must have a format which includes -> e.g. 2, '2(rem|em|px)', auto, initial, inherit, token(...)
  *  The rule will return with error and provide a fix
  * @param templateLiteral TemplateLiteral AST Node
  * @param propertyValues property values parsed as list of strings
  * @returns boolean
  */
-const isPropertyValuesInvalidFix = (templateLiteral: TemplateLiteral, propertyValues: string[]) => {
-	const expressions = templateLiteral.expressions;
-	if (!expressions.every((expr) => expr.type === 'CallExpression' && isTokenCallExpression(expr))) {
-		return false;
-	}
-	
+const isPropertyValuesInvalidFix = (propertyValues: string[]) => {
 	for (const propValue of propertyValues) {
-		if (propValue === '0') { continue; }
-		if (['auto', 'initial', 'inherit'].includes(propValue.slice(1, -1))) { continue; }
-		if ((/^token\(.*\)$/).test(propValue)) { continue; }
-		if ((/^['"]\d+(\.\d+)?((rem)|(em)|(px))['"]$/).test(propValue)) { continue; }
+		if (propValue === '0') {
+			continue;
+		}
+		if (['auto', 'initial', 'inherit'].includes(propValue.slice(1, -1))) {
+			continue;
+		}
+		if (/^token\(.*\)$/.test(propValue)) {
+			continue;
+		}
+		if (/^['"]\d+(\.\d+)?((rem)|(em)|(px))['"]$/.test(propValue)) {
+			continue;
+		}
 		return false;
 	}
 	return true;
-}
+};
 
 // To fix spacing shorthands, given a list of spacing property values, expands the spacing property and adds autofix fixes
 const expandSpacingProperties = ({
@@ -157,11 +165,11 @@ const executeExpandSpacingRule = (
 	}
 	if (node.value.type === 'TemplateLiteral') {
 		const propertyValues = parseTemplateLiteral(node.value, context);
-		if (isPropertyValueExempted(propertyValues)) {
+		if (isPropertyValueExempted(node.value, propertyValues)) {
 			// Valid, so no error should be thrown
 			return;
 		}
-		if (isPropertyValuesInvalidFix(node.value, propertyValues)) {
+		if (isPropertyValuesInvalidFix(propertyValues)) {
 			// Invalid, so error should be thrown and fix provided
 			context.report({
 				node,
@@ -170,7 +178,13 @@ const executeExpandSpacingRule = (
 					property: propertyShorthand,
 				},
 				fix(fixer) {
-					return expandSpacingProperties({ context, node, propertyValues, fixer, propertyShorthand });
+					return expandSpacingProperties({
+						context,
+						node,
+						propertyValues,
+						fixer,
+						propertyShorthand,
+					});
 				},
 			});
 		} else {

package/src/rules/feature-gating/README.md

@@ -1,7 +1,7 @@
 ### Notes
 
 - feature-gating/\* rules are copied from
-  [eslint-plugin-jira/rules/ff](https://stash.atlassian.com/projects/ATLASSIAN/repos/atlassian-frontend-monorepo/browse/jira/build-tools/eslint-plugin-jira/rules/ff)
+  [eslint-plugin-jira/rules/ff](https://stash.atlassian.com/projects/ATLASSIAN/repos/atlassian-frontend-monorepo/browse/jira/dev-tooling/packages/eslint-plugin-jira/rules/ff)
   with small variations as mentioned in this
   [PR](https://stash.atlassian.com/projects/ATLASSIAN/repos/atlassian-frontend-monorepo/pull-requests/115546/overview)
 - these rules could be a WIP since they are still targeting JFE libraries- see

package/src/rules/feature-gating/inline-usage/index.tsx

@@ -109,6 +109,11 @@ const rule: Rule.RuleModule = {
 				'Ensure feature flags/gates and experiments are inlined so that they can be statically analyzable.',
 			url: 'https://stash.atlassian.com/projects/ATLASSIAN/repos/atlassian-frontend-monorepo/browse/platform/packages/platform/eslint-plugin/src/rules/inline-usage/README.md',
 		},
+		schema: [
+			{
+				enum: ['ssOnly'],
+			},
+		],
 		messages: {
 			inlineUsage:
 				'Do not export or wrap feature flags/gates and experiments usages. Inline calls at the callsite to ensure it is statically analyzable.',