@atlaskit/eslint-plugin-platform 2.0.2 → 2.1.1

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/eslint-plugin-platform
 
+## 2.1.1
+
+### Patch Changes
+
+- [#101753](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/101753)
+  [`ab8a4d93399e8`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/ab8a4d93399e8) -
+  AFB-822 Turn of expand-spacing-shorthand rule until all of Jira and Platform rollout is complete
+
+## 2.1.0
+
+### Minor Changes
+
+- [#98759](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/98759)
+  [`e6f89962ceaba`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/e6f89962ceaba) -
+  ESLint rule for expand-spacing-shorthand (i.e. padding and margin)
+
 ## 2.0.2
 
 ### Patch Changes

package/dist/cjs/index.js

@@ -31,6 +31,7 @@ var _noAlias = _interopRequireDefault(require("./rules/feature-gating/no-alias")
 var _useEntrypointsInExamples = _interopRequireDefault(require("./rules/use-entrypoints-in-examples"));
 var _useRecommendedUtils = _interopRequireDefault(require("./rules/feature-gating/use-recommended-utils"));
 var _expandBackgroundShorthand = _interopRequireDefault(require("./rules/compiled/expand-background-shorthand"));
+var _expandSpacingShorthand = _interopRequireDefault(require("./rules/compiled/expand-spacing-shorthand"));
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } // eslint-disable-next-line import/no-extraneous-dependencies
 var rules = exports.rules = {
@@ -44,6 +45,7 @@ var rules = exports.rules = {
   'ensure-valid-bin-values': _ensureValidBinValues.default,
   'expand-border-shorthand': _expandBorderShorthand.default,
   'expand-background-shorthand': _expandBackgroundShorthand.default,
+  'expand-spacing-shorthand': _expandSpacingShorthand.default,
   'no-duplicate-dependencies': _noDuplicateDependencies.default,
   'no-invalid-feature-flag-usage': _noInvalidFeatureFlagUsage.default,
   'no-pre-post-install-scripts': _noPrePostInstalls.default,
@@ -70,6 +72,7 @@ var commonConfig = {
   // Compiled: rules that are not included via `@compiled/recommended
   '@atlaskit/platform/expand-border-shorthand': 'error',
   '@atlaskit/platform/expand-background-shorthand': 'error',
+  '@atlaskit/platform/expand-spacing-shorthand': 'off',
   '@compiled/jsx-pragma': ['error', {
     importSources: ['@atlaskit/css'],
     onlyRunIfImportingCompiled: true,

package/dist/cjs/rules/compiled/expand-background-shorthand/index.js

@@ -4,22 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.expandBackgroundShorthand = exports.default = void 0;
-var _isSupportedImport = require("@atlaskit/eslint-utils/is-supported-import");
-var _contextCompat = require("../../util/context-compat");
-// Checks if the function that holds the border property is using an import package that this rule is targeting
-var isCompiledAPI = function isCompiledAPI(context, node) {
-  var importSources = (0, _isSupportedImport.getImportSources)(context);
-  var _getScope = (0, _contextCompat.getScope)(context, node),
-    references = _getScope.references;
-  var ancestors = (0, _contextCompat.getAncestors)(context, node);
-  if (ancestors.some(function (ancestor) {
-    return ancestor.type === 'CallExpression' && ancestor.callee && ((0, _isSupportedImport.isCompiled)(ancestor.callee, references, importSources) || (0, _isSupportedImport.isAtlasKitCSS)(ancestor.callee, references, importSources));
-  })) {
-    return true;
-  }
-  return false;
-};
-
+var _compiledUtils = require("../../util/compiled-utils");
 // Checks if node is a call expression with identifier 'token'
 var isTokenCallExpression = function isTokenCallExpression(node) {
   if (node.type === 'CallExpression') {
@@ -43,7 +28,7 @@ var expandBackgroundShorthand = exports.expandBackgroundShorthand = {
   create: function create(context) {
     return {
       'Property[key.name="background"]': function PropertyKeyNameBackground(node) {
-        if (isCompiledAPI(context, node) && isTokenCallExpression(node.value)) {
+        if ((0, _compiledUtils.isCompiledAPI)(context, node) && isTokenCallExpression(node.value)) {
           context.report({
             node: node,
             messageId: 'expandBackgroundShorthand',

package/dist/cjs/rules/compiled/expand-spacing-shorthand/index.js

@@ -0,0 +1,214 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.expandSpacingShorthand = exports.default = void 0;
+var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
+var _contextCompat = require("../../util/context-compat");
+var _compiledUtils = require("../../util/compiled-utils");
+function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
+function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
+function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
+var spacingPos = ['Top', 'Right', 'Bottom', 'Left'];
+// Checks if node is a call expression with identifier 'token'
+var isTokenCallExpression = function isTokenCallExpression(node) {
+  if (node.callee.type === 'Identifier' && node.callee.name === 'token') {
+    return true;
+  }
+  return false;
+};
+
+// Given a TemplateLiteral node, returns the value of the spacing property as an array of strings
+// e.g. `0 ${token('a')} ${token('b')}` -> ['0', 'token('a')', 'token('b')']
+var parseTemplateLiteral = function parseTemplateLiteral(templateLiteral, context) {
+  var expressions = templateLiteral.expressions;
+  var quasis = templateLiteral.quasis;
+  var propertyValues = [];
+  for (var i = 0; i < expressions.length || i < quasis.length; i++) {
+    if (i < quasis.length) {
+      var cookedQuasi = quasis[i].value.cooked;
+      if (cookedQuasi) {
+        var splitQuasi = cookedQuasi.split(' ').filter(function (str) {
+          return str.trim().length > 0;
+        });
+        splitQuasi.forEach(function (str) {
+          propertyValues.push(isNaN(Number(str)) ? "'".concat(str, "'") : str);
+        });
+      }
+    }
+    if (i < expressions.length) {
+      var expr = (0, _contextCompat.getSourceCode)(context).getText(expressions[i]);
+      propertyValues.push(expr);
+    }
+  }
+  return propertyValues;
+};
+var checkValidPropertyValues = function checkValidPropertyValues(propertyValues) {
+  if (!propertyValues.some(function (str) {
+    return str.includes('token(');
+  })) {
+    return false;
+  }
+  if (propertyValues.length < 1 || propertyValues.length > 4) {
+    return false;
+  }
+  if (propertyValues.some(function (str) {
+    return str.includes('calc(');
+  })) {
+    return false;
+  }
+  return true;
+};
+
+// Check that all expressions in TemplateLiteral are token expressions
+// If true: create an autofix
+// If false: report violation without autofix
+var hasOnlyTokens = function hasOnlyTokens(templateLiteral) {
+  var expressions = templateLiteral.expressions;
+  return expressions.every(function (expr) {
+    return expr.type === 'CallExpression' && isTokenCallExpression(expr);
+  });
+};
+
+// To fix spacing shorthands, given a list of spacing property values, expands the spacing property and adds autofix fixes
+var expandSpacingProperties = function expandSpacingProperties(_ref) {
+  var context = _ref.context,
+    node = _ref.node,
+    propertyValues = _ref.propertyValues,
+    fixer = _ref.fixer,
+    propertyShorthand = _ref.propertyShorthand;
+  var _propertyValues = (0, _slicedToArray2.default)(propertyValues, 4),
+    top = _propertyValues[0],
+    _propertyValues$ = _propertyValues[1],
+    right = _propertyValues$ === void 0 ? top : _propertyValues$,
+    _propertyValues$2 = _propertyValues[2],
+    bottom = _propertyValues$2 === void 0 ? top : _propertyValues$2,
+    _propertyValues$3 = _propertyValues[3],
+    left = _propertyValues$3 === void 0 ? right : _propertyValues$3;
+  var spacing = [top, right, bottom, left];
+  var fixes = [];
+  var parentNode = node.parent;
+  if (parentNode && parentNode.type === 'ObjectExpression') {
+    var _iterator = _createForOfIteratorHelper(parentNode.properties),
+      _step;
+    try {
+      for (_iterator.s(); !(_step = _iterator.n()).done;) {
+        var prop = _step.value;
+        if (prop.type !== 'Property') {
+          continue;
+        }
+        if (prop.key.type === 'Identifier' && prop.range && prop.key.name !== "".concat(propertyShorthand)) {
+          for (var i = 0; i < spacing.length; i++) {
+            if (prop.key.name === "".concat(propertyShorthand).concat(spacingPos[i])) {
+              var _prop$range = (0, _slicedToArray2.default)(prop.range, 2),
+                start = _prop$range[0],
+                end = _prop$range[1];
+              // Remove the entire line for the duplicate property
+              while ((0, _contextCompat.getSourceCode)(context).text[end] !== '\n') {
+                end += 1;
+              }
+              while ((0, _contextCompat.getSourceCode)(context).text[start] !== '\n') {
+                start -= 1;
+              }
+              spacing[i] = (0, _contextCompat.getSourceCode)(context).getText(prop.value);
+              fixes.push(fixer.removeRange([start, end]));
+              break;
+            }
+          }
+        }
+      }
+    } catch (err) {
+      _iterator.e(err);
+    } finally {
+      _iterator.f();
+    }
+  }
+  fixes.push(fixer.insertTextAfter(node, "".concat(propertyShorthand, "Top: ").concat(spacing[0], ",\n")));
+  fixes.push(fixer.insertTextAfter(node, "\t".concat(propertyShorthand, "Right: ").concat(spacing[1], ",\n")));
+  fixes.push(fixer.insertTextAfter(node, "\t".concat(propertyShorthand, "Bottom: ").concat(spacing[2], ",\n")));
+  fixes.push(fixer.insertTextAfter(node, "\t".concat(propertyShorthand, "Left: ").concat(spacing[3])));
+  fixes.push(fixer.remove(node));
+  return fixes;
+};
+var executeExpandSpacingRule = function executeExpandSpacingRule(context, node, propertyShorthand) {
+  if (!(0, _compiledUtils.isCompiledAPI)(context, node)) {
+    return;
+  }
+  if (node.value.type === 'TemplateLiteral') {
+    // Value of spacing property is a TemplateLiteral type that contains a token, e.g. padding: `0 token('a')`
+    if (!hasOnlyTokens(node.value)) {
+      context.report({
+        node: node,
+        messageId: 'expandSpacingShorthand',
+        data: {
+          property: propertyShorthand
+        }
+      });
+      return;
+    }
+    var propertyValues = parseTemplateLiteral(node.value, context);
+    if (!checkValidPropertyValues(propertyValues)) {
+      return;
+    }
+    context.report({
+      node: node,
+      messageId: 'expandSpacingShorthand',
+      data: {
+        property: propertyShorthand
+      },
+      fix: function fix(fixer) {
+        return expandSpacingProperties({
+          context: context,
+          node: node,
+          propertyValues: propertyValues,
+          fixer: fixer,
+          propertyShorthand: propertyShorthand
+        });
+      }
+    });
+  } else if (node.value.type === 'CallExpression' && isTokenCallExpression(node.value)) {
+    // Value of spacing property is a token CallExpression type, e.g. margin: token('space.100', '8px')
+    var _propertyValues2 = [(0, _contextCompat.getSourceCode)(context).getText(node.value)];
+    context.report({
+      node: node,
+      messageId: 'expandSpacingShorthand',
+      data: {
+        property: propertyShorthand
+      },
+      fix: function fix(fixer) {
+        return expandSpacingProperties({
+          context: context,
+          node: node,
+          propertyValues: _propertyValues2,
+          fixer: fixer,
+          propertyShorthand: propertyShorthand
+        });
+      }
+    });
+  }
+};
+var expandSpacingShorthand = exports.expandSpacingShorthand = {
+  meta: {
+    docs: {
+      url: 'https://bitbucket.org/atlassian/atlassian-frontend-monorepo/src/master/platform/packages/platform/eslint-plugin/src/rules/compiled/expand-spacing-shorthand/'
+    },
+    messages: {
+      expandSpacingShorthand: 'Use {{ property }}Top, {{ property }}Right, {{ property }}Bottom and {{ property }}Left instead of {{ property }} shorthand'
+    },
+    type: 'problem',
+    fixable: 'code'
+  },
+  create: function create(context) {
+    return {
+      'Property[key.name="padding"]': function PropertyKeyNamePadding(node) {
+        executeExpandSpacingRule(context, node, 'padding');
+      },
+      'Property[key.name="margin"]': function PropertyKeyNameMargin(node) {
+        executeExpandSpacingRule(context, node, 'margin');
+      }
+    };
+  }
+};
+var _default = exports.default = expandSpacingShorthand;

package/dist/cjs/rules/util/compiled-utils.js

@@ -0,0 +1,21 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.isCompiledAPI = void 0;
+var _contextCompat = require("./context-compat");
+var _isSupportedImport = require("@atlaskit/eslint-utils/is-supported-import");
+// Checks if the function that holds the property is using a Compiled import package that this rule is targeting
+var isCompiledAPI = exports.isCompiledAPI = function isCompiledAPI(context, node) {
+  var importSources = (0, _isSupportedImport.getImportSources)(context);
+  var _getScope = (0, _contextCompat.getScope)(context, node),
+    references = _getScope.references;
+  var ancestors = (0, _contextCompat.getAncestors)(context, node);
+  if (ancestors.some(function (ancestor) {
+    return ancestor.type === 'CallExpression' && ancestor.callee && ((0, _isSupportedImport.isCompiled)(ancestor.callee, references, importSources) || (0, _isSupportedImport.isAtlasKitCSS)(ancestor.callee, references, importSources));
+  })) {
+    return true;
+  }
+  return false;
+};

package/dist/cjs/rules/util/context-compat.js

@@ -3,7 +3,7 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.getScope = exports.getAncestors = void 0;
+exports.getSourceCode = exports.getScope = exports.getAncestors = void 0;
 /**
  * TODO: Consider whether this should be replaced by ESLint's compat library.
  * Either way, this should be removed once we no longer need to support ESLint versions less than 8.40.
@@ -15,7 +15,7 @@ exports.getScope = exports.getAncestors = void 0;
  * `context.getSourceCode()` is deprecated in v8 and removed in v9.
  * @param context - The ESLint rule context
  */
-var getSourceCode = function getSourceCode(context) {
+var getSourceCode = exports.getSourceCode = function getSourceCode(context) {
   var _context$sourceCode;
   return (_context$sourceCode = context.sourceCode) !== null && _context$sourceCode !== void 0 ? _context$sourceCode : context.getSourceCode();
 };

package/dist/es2019/index.js

@@ -25,6 +25,7 @@ import noAlias from './rules/feature-gating/no-alias';
 import useEntrypointsInExamples from './rules/use-entrypoints-in-examples';
 import useRecommendedUtils from './rules/feature-gating/use-recommended-utils';
 import expandBackgroundShorthand from './rules/compiled/expand-background-shorthand';
+import expandSpacingShorthand from './rules/compiled/expand-spacing-shorthand';
 export const rules = {
   'ensure-feature-flag-registration': ensureFeatureFlagRegistration,
   'ensure-feature-flag-prefix': ensureFeatureFlagPrefix,
@@ -36,6 +37,7 @@ export const rules = {
   'ensure-valid-bin-values': ensureValidBinValues,
   'expand-border-shorthand': expandBorderShorthand,
   'expand-background-shorthand': expandBackgroundShorthand,
+  'expand-spacing-shorthand': expandSpacingShorthand,
   'no-duplicate-dependencies': noDuplicateDependencies,
   'no-invalid-feature-flag-usage': noInvalidFeatureFlagUsage,
   'no-pre-post-install-scripts': noPreAndPostInstallScripts,
@@ -62,6 +64,7 @@ const commonConfig = {
   // Compiled: rules that are not included via `@compiled/recommended
   '@atlaskit/platform/expand-border-shorthand': 'error',
   '@atlaskit/platform/expand-background-shorthand': 'error',
+  '@atlaskit/platform/expand-spacing-shorthand': 'off',
   '@compiled/jsx-pragma': ['error', {
     importSources: ['@atlaskit/css'],
     onlyRunIfImportingCompiled: true,

package/dist/es2019/rules/compiled/expand-background-shorthand/index.js

@@ -1,18 +1,4 @@
-import { getImportSources, isCompiled, isAtlasKitCSS } from '@atlaskit/eslint-utils/is-supported-import';
-import { getAncestors, getScope } from '../../util/context-compat';
-
-// Checks if the function that holds the border property is using an import package that this rule is targeting
-const isCompiledAPI = (context, node) => {
-  const importSources = getImportSources(context);
-  const {
-    references
-  } = getScope(context, node);
-  const ancestors = getAncestors(context, node);
-  if (ancestors.some(ancestor => ancestor.type === 'CallExpression' && ancestor.callee && (isCompiled(ancestor.callee, references, importSources) || isAtlasKitCSS(ancestor.callee, references, importSources)))) {
-    return true;
-  }
-  return false;
-};
+import { isCompiledAPI } from '../../util/compiled-utils';
 
 // Checks if node is a call expression with identifier 'token'
 const isTokenCallExpression = node => {

package/dist/es2019/rules/compiled/expand-spacing-shorthand/index.js

@@ -0,0 +1,178 @@
+import { getSourceCode } from '../../util/context-compat';
+import { isCompiledAPI } from '../../util/compiled-utils';
+const spacingPos = ['Top', 'Right', 'Bottom', 'Left'];
+// Checks if node is a call expression with identifier 'token'
+const isTokenCallExpression = node => {
+  if (node.callee.type === 'Identifier' && node.callee.name === 'token') {
+    return true;
+  }
+  return false;
+};
+
+// Given a TemplateLiteral node, returns the value of the spacing property as an array of strings
+// e.g. `0 ${token('a')} ${token('b')}` -> ['0', 'token('a')', 'token('b')']
+const parseTemplateLiteral = (templateLiteral, context) => {
+  const expressions = templateLiteral.expressions;
+  const quasis = templateLiteral.quasis;
+  let propertyValues = [];
+  for (let i = 0; i < expressions.length || i < quasis.length; i++) {
+    if (i < quasis.length) {
+      const cookedQuasi = quasis[i].value.cooked;
+      if (cookedQuasi) {
+        const splitQuasi = cookedQuasi.split(' ').filter(str => str.trim().length > 0);
+        splitQuasi.forEach(str => {
+          propertyValues.push(isNaN(Number(str)) ? `'${str}'` : str);
+        });
+      }
+    }
+    if (i < expressions.length) {
+      const expr = getSourceCode(context).getText(expressions[i]);
+      propertyValues.push(expr);
+    }
+  }
+  return propertyValues;
+};
+const checkValidPropertyValues = propertyValues => {
+  if (!propertyValues.some(str => str.includes('token('))) {
+    return false;
+  }
+  if (propertyValues.length < 1 || propertyValues.length > 4) {
+    return false;
+  }
+  if (propertyValues.some(str => str.includes('calc('))) {
+    return false;
+  }
+  return true;
+};
+
+// Check that all expressions in TemplateLiteral are token expressions
+// If true: create an autofix
+// If false: report violation without autofix
+const hasOnlyTokens = templateLiteral => {
+  const expressions = templateLiteral.expressions;
+  return expressions.every(expr => expr.type === 'CallExpression' && isTokenCallExpression(expr));
+};
+
+// To fix spacing shorthands, given a list of spacing property values, expands the spacing property and adds autofix fixes
+const expandSpacingProperties = ({
+  context,
+  node,
+  propertyValues,
+  fixer,
+  propertyShorthand
+}) => {
+  const [top, right = top, bottom = top, left = right] = propertyValues;
+  const spacing = [top, right, bottom, left];
+  const fixes = [];
+  const parentNode = node.parent;
+  if (parentNode && parentNode.type === 'ObjectExpression') {
+    for (var prop of parentNode.properties) {
+      if (prop.type !== 'Property') {
+        continue;
+      }
+      if (prop.key.type === 'Identifier' && prop.range && prop.key.name !== `${propertyShorthand}`) {
+        for (let i = 0; i < spacing.length; i++) {
+          if (prop.key.name === `${propertyShorthand}${spacingPos[i]}`) {
+            let [start, end] = prop.range;
+            // Remove the entire line for the duplicate property
+            while (getSourceCode(context).text[end] !== '\n') {
+              end += 1;
+            }
+            while (getSourceCode(context).text[start] !== '\n') {
+              start -= 1;
+            }
+            spacing[i] = getSourceCode(context).getText(prop.value);
+            fixes.push(fixer.removeRange([start, end]));
+            break;
+          }
+        }
+      }
+    }
+  }
+  fixes.push(fixer.insertTextAfter(node, `${propertyShorthand}Top: ${spacing[0]},\n`));
+  fixes.push(fixer.insertTextAfter(node, `\t${propertyShorthand}Right: ${spacing[1]},\n`));
+  fixes.push(fixer.insertTextAfter(node, `\t${propertyShorthand}Bottom: ${spacing[2]},\n`));
+  fixes.push(fixer.insertTextAfter(node, `\t${propertyShorthand}Left: ${spacing[3]}`));
+  fixes.push(fixer.remove(node));
+  return fixes;
+};
+const executeExpandSpacingRule = (context, node, propertyShorthand) => {
+  if (!isCompiledAPI(context, node)) {
+    return;
+  }
+  if (node.value.type === 'TemplateLiteral') {
+    // Value of spacing property is a TemplateLiteral type that contains a token, e.g. padding: `0 token('a')`
+    if (!hasOnlyTokens(node.value)) {
+      context.report({
+        node,
+        messageId: 'expandSpacingShorthand',
+        data: {
+          property: propertyShorthand
+        }
+      });
+      return;
+    }
+    const propertyValues = parseTemplateLiteral(node.value, context);
+    if (!checkValidPropertyValues(propertyValues)) {
+      return;
+    }
+    context.report({
+      node,
+      messageId: 'expandSpacingShorthand',
+      data: {
+        property: propertyShorthand
+      },
+      fix(fixer) {
+        return expandSpacingProperties({
+          context,
+          node,
+          propertyValues,
+          fixer,
+          propertyShorthand
+        });
+      }
+    });
+  } else if (node.value.type === 'CallExpression' && isTokenCallExpression(node.value)) {
+    // Value of spacing property is a token CallExpression type, e.g. margin: token('space.100', '8px')
+    const propertyValues = [getSourceCode(context).getText(node.value)];
+    context.report({
+      node,
+      messageId: 'expandSpacingShorthand',
+      data: {
+        property: propertyShorthand
+      },
+      fix(fixer) {
+        return expandSpacingProperties({
+          context,
+          node,
+          propertyValues,
+          fixer,
+          propertyShorthand
+        });
+      }
+    });
+  }
+};
+export const expandSpacingShorthand = {
+  meta: {
+    docs: {
+      url: 'https://bitbucket.org/atlassian/atlassian-frontend-monorepo/src/master/platform/packages/platform/eslint-plugin/src/rules/compiled/expand-spacing-shorthand/'
+    },
+    messages: {
+      expandSpacingShorthand: 'Use {{ property }}Top, {{ property }}Right, {{ property }}Bottom and {{ property }}Left instead of {{ property }} shorthand'
+    },
+    type: 'problem',
+    fixable: 'code'
+  },
+  create(context) {
+    return {
+      'Property[key.name="padding"]': function (node) {
+        executeExpandSpacingRule(context, node, 'padding');
+      },
+      'Property[key.name="margin"]': function (node) {
+        executeExpandSpacingRule(context, node, 'margin');
+      }
+    };
+  }
+};
+export default expandSpacingShorthand;

package/dist/es2019/rules/util/compiled-utils.js

@@ -0,0 +1,15 @@
+import { getAncestors, getScope } from './context-compat';
+import { getImportSources, isCompiled, isAtlasKitCSS } from '@atlaskit/eslint-utils/is-supported-import';
+
+// Checks if the function that holds the property is using a Compiled import package that this rule is targeting
+export const isCompiledAPI = (context, node) => {
+  const importSources = getImportSources(context);
+  const {
+    references
+  } = getScope(context, node);
+  const ancestors = getAncestors(context, node);
+  if (ancestors.some(ancestor => ancestor.type === 'CallExpression' && ancestor.callee && (isCompiled(ancestor.callee, references, importSources) || isAtlasKitCSS(ancestor.callee, references, importSources)))) {
+    return true;
+  }
+  return false;
+};

package/dist/es2019/rules/util/context-compat.js

@@ -9,7 +9,7 @@
  * `context.getSourceCode()` is deprecated in v8 and removed in v9.
  * @param context - The ESLint rule context
  */
-const getSourceCode = context => {
+export const getSourceCode = context => {
   var _context$sourceCode;
   return (_context$sourceCode = context.sourceCode) !== null && _context$sourceCode !== void 0 ? _context$sourceCode : context.getSourceCode();
 };

package/dist/esm/index.js

@@ -28,6 +28,7 @@ import noAlias from './rules/feature-gating/no-alias';
 import useEntrypointsInExamples from './rules/use-entrypoints-in-examples';
 import useRecommendedUtils from './rules/feature-gating/use-recommended-utils';
 import expandBackgroundShorthand from './rules/compiled/expand-background-shorthand';
+import expandSpacingShorthand from './rules/compiled/expand-spacing-shorthand';
 export var rules = {
   'ensure-feature-flag-registration': ensureFeatureFlagRegistration,
   'ensure-feature-flag-prefix': ensureFeatureFlagPrefix,
@@ -39,6 +40,7 @@ export var rules = {
   'ensure-valid-bin-values': ensureValidBinValues,
   'expand-border-shorthand': expandBorderShorthand,
   'expand-background-shorthand': expandBackgroundShorthand,
+  'expand-spacing-shorthand': expandSpacingShorthand,
   'no-duplicate-dependencies': noDuplicateDependencies,
   'no-invalid-feature-flag-usage': noInvalidFeatureFlagUsage,
   'no-pre-post-install-scripts': noPreAndPostInstallScripts,
@@ -65,6 +67,7 @@ var commonConfig = {
   // Compiled: rules that are not included via `@compiled/recommended
   '@atlaskit/platform/expand-border-shorthand': 'error',
   '@atlaskit/platform/expand-background-shorthand': 'error',
+  '@atlaskit/platform/expand-spacing-shorthand': 'off',
   '@compiled/jsx-pragma': ['error', {
     importSources: ['@atlaskit/css'],
     onlyRunIfImportingCompiled: true,

package/dist/esm/rules/compiled/expand-background-shorthand/index.js

@@ -1,19 +1,4 @@
-import { getImportSources, isCompiled, isAtlasKitCSS } from '@atlaskit/eslint-utils/is-supported-import';
-import { getAncestors, getScope } from '../../util/context-compat';
-
-// Checks if the function that holds the border property is using an import package that this rule is targeting
-var isCompiledAPI = function isCompiledAPI(context, node) {
-  var importSources = getImportSources(context);
-  var _getScope = getScope(context, node),
-    references = _getScope.references;
-  var ancestors = getAncestors(context, node);
-  if (ancestors.some(function (ancestor) {
-    return ancestor.type === 'CallExpression' && ancestor.callee && (isCompiled(ancestor.callee, references, importSources) || isAtlasKitCSS(ancestor.callee, references, importSources));
-  })) {
-    return true;
-  }
-  return false;
-};
+import { isCompiledAPI } from '../../util/compiled-utils';
 
 // Checks if node is a call expression with identifier 'token'
 var isTokenCallExpression = function isTokenCallExpression(node) {