@atlaskit/eslint-plugin-platform 1.1.0 → 2.0.1

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/eslint-plugin-platform
 
+## 2.0.1
+
+### Patch Changes
+
+- [`2034d96c50c40`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/2034d96c50c40) -
+  fixed backwards compatibility with older versions of eslint
+
+## 2.0.0
+
+### Major Changes
+
+- [#176646](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/176646)
+  [`9612cd921a885`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/9612cd921a885) -
+  ESlint rule for expand background shorthand with color token
+
 ## 1.1.0
 
 ### Minor Changes

package/dist/cjs/index.js

@@ -69,7 +69,7 @@ var commonConfig = {
   '@atlaskit/platform/no-module-level-eval-nav4': 'error',
   // Compiled: rules that are not included via `@compiled/recommended
   '@atlaskit/platform/expand-border-shorthand': 'error',
-  '@atlaskit/platform/expand-background-shorthand': 'warn',
+  '@atlaskit/platform/expand-background-shorthand': 'error',
   '@compiled/jsx-pragma': ['error', {
     importSources: ['@atlaskit/css'],
     onlyRunIfImportingCompiled: true,

package/dist/cjs/rules/util/context-compat.js

@@ -28,6 +28,6 @@ var getSourceCode = function getSourceCode(context) {
  * @param node - The node to get the scope for
  */
 var getScope = exports.getScope = function getScope(context, node) {
-  var _getSourceCode$getSco, _getSourceCode;
-  return (_getSourceCode$getSco = (_getSourceCode = getSourceCode(context)) === null || _getSourceCode === void 0 ? void 0 : _getSourceCode.getScope(node)) !== null && _getSourceCode$getSco !== void 0 ? _getSourceCode$getSco : context.getScope();
+  var _getSourceCode$getSco, _getSourceCode, _getSourceCode$getSco2;
+  return (_getSourceCode$getSco = (_getSourceCode = getSourceCode(context)) === null || _getSourceCode === void 0 || (_getSourceCode$getSco2 = _getSourceCode.getScope) === null || _getSourceCode$getSco2 === void 0 ? void 0 : _getSourceCode$getSco2.call(_getSourceCode, node)) !== null && _getSourceCode$getSco !== void 0 ? _getSourceCode$getSco : context.getScope();
 };

package/dist/es2019/index.js

@@ -61,7 +61,7 @@ const commonConfig = {
   '@atlaskit/platform/no-module-level-eval-nav4': 'error',
   // Compiled: rules that are not included via `@compiled/recommended
   '@atlaskit/platform/expand-border-shorthand': 'error',
-  '@atlaskit/platform/expand-background-shorthand': 'warn',
+  '@atlaskit/platform/expand-background-shorthand': 'error',
   '@compiled/jsx-pragma': ['error', {
     importSources: ['@atlaskit/css'],
     onlyRunIfImportingCompiled: true,

package/dist/es2019/rules/util/context-compat.js

@@ -22,6 +22,6 @@ const getSourceCode = context => {
  * @param node - The node to get the scope for
  */
 export const getScope = (context, node) => {
-  var _getSourceCode$getSco, _getSourceCode;
-  return (_getSourceCode$getSco = (_getSourceCode = getSourceCode(context)) === null || _getSourceCode === void 0 ? void 0 : _getSourceCode.getScope(node)) !== null && _getSourceCode$getSco !== void 0 ? _getSourceCode$getSco : context.getScope();
+  var _getSourceCode$getSco, _getSourceCode, _getSourceCode$getSco2;
+  return (_getSourceCode$getSco = (_getSourceCode = getSourceCode(context)) === null || _getSourceCode === void 0 ? void 0 : (_getSourceCode$getSco2 = _getSourceCode.getScope) === null || _getSourceCode$getSco2 === void 0 ? void 0 : _getSourceCode$getSco2.call(_getSourceCode, node)) !== null && _getSourceCode$getSco !== void 0 ? _getSourceCode$getSco : context.getScope();
 };

package/dist/esm/index.js

@@ -64,7 +64,7 @@ var commonConfig = {
   '@atlaskit/platform/no-module-level-eval-nav4': 'error',
   // Compiled: rules that are not included via `@compiled/recommended
   '@atlaskit/platform/expand-border-shorthand': 'error',
-  '@atlaskit/platform/expand-background-shorthand': 'warn',
+  '@atlaskit/platform/expand-background-shorthand': 'error',
   '@compiled/jsx-pragma': ['error', {
     importSources: ['@atlaskit/css'],
     onlyRunIfImportingCompiled: true,

package/dist/esm/rules/util/context-compat.js

@@ -22,6 +22,6 @@ var getSourceCode = function getSourceCode(context) {
  * @param node - The node to get the scope for
  */
 export var getScope = function getScope(context, node) {
-  var _getSourceCode$getSco, _getSourceCode;
-  return (_getSourceCode$getSco = (_getSourceCode = getSourceCode(context)) === null || _getSourceCode === void 0 ? void 0 : _getSourceCode.getScope(node)) !== null && _getSourceCode$getSco !== void 0 ? _getSourceCode$getSco : context.getScope();
+  var _getSourceCode$getSco, _getSourceCode, _getSourceCode$getSco2;
+  return (_getSourceCode$getSco = (_getSourceCode = getSourceCode(context)) === null || _getSourceCode === void 0 || (_getSourceCode$getSco2 = _getSourceCode.getScope) === null || _getSourceCode$getSco2 === void 0 ? void 0 : _getSourceCode$getSco2.call(_getSourceCode, node)) !== null && _getSourceCode$getSco !== void 0 ? _getSourceCode$getSco : context.getScope();
 };

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@atlaskit/eslint-plugin-platform",
 	"description": "The essential plugin for use with Atlassian frontend platform tools",
-	"version": "1.1.0",
+	"version": "2.0.1",
 	"author": "Atlassian Pty Ltd",
 	"atlassian": {
 		"team": "Build Infra",

package/src/index.tsx

@@ -63,7 +63,7 @@ const commonConfig = {
 	'@atlaskit/platform/no-module-level-eval-nav4': 'error',
 	// Compiled: rules that are not included via `@compiled/recommended
 	'@atlaskit/platform/expand-border-shorthand': 'error',
-	'@atlaskit/platform/expand-background-shorthand': 'warn',
+	'@atlaskit/platform/expand-background-shorthand': 'error',
 	'@compiled/jsx-pragma': [
 		'error',
 		{

package/src/rules/util/__tests__/context-compat.test.ts

@@ -0,0 +1,64 @@
+import type { Rule, Scope, SourceCode } from 'eslint';
+import type { Node } from 'estree';
+
+import { getScope } from '../context-compat';
+
+describe('context-compat', () => {
+	describe('getScope', () => {
+		let context: Rule.RuleContext;
+		let node: Node;
+		let sourceCode: SourceCode;
+		let scope: Scope.Scope;
+
+		beforeEach(() => {
+			node = {} as Node;
+			scope = {} as Scope.Scope;
+			sourceCode = {
+				getScope: jest.fn().mockReturnValue(scope),
+			} as unknown as SourceCode;
+		});
+
+		it('should return scope from context.sourceCode.getScope if available', () => {
+			context = {
+				sourceCode,
+			} as unknown as Rule.RuleContext;
+
+			const result = getScope(context, node);
+			expect(result).toBe(scope);
+			expect(sourceCode.getScope).toHaveBeenCalledWith(node);
+		});
+
+		it('should return scope from context.getSourceCode().getScope if context.sourceCode is not available', () => {
+			context = {
+				getSourceCode: jest.fn().mockReturnValue(sourceCode),
+			} as unknown as Rule.RuleContext;
+
+			const result = getScope(context, node);
+			expect(result).toBe(scope);
+			expect(context.getSourceCode).toHaveBeenCalled();
+			expect(sourceCode.getScope).toHaveBeenCalledWith(node);
+		});
+
+		it('should return scope from context.getScope if neither context.sourceCode nor context.getSourceCode().getScope is available', () => {
+			context = {
+				getSourceCode: jest.fn().mockReturnValue({}),
+				getScope: jest.fn().mockReturnValue(scope),
+			} as unknown as Rule.RuleContext;
+
+			const result = getScope(context, node);
+			expect(result).toBe(scope);
+			expect(context.getScope).toHaveBeenCalled();
+		});
+
+		it('should return scope from context.getScope if context.sourceCode does not have getScope', () => {
+			context = {
+				sourceCode: {},
+				getScope: jest.fn().mockReturnValue(scope),
+			} as unknown as Rule.RuleContext;
+
+			const result = getScope(context, node);
+			expect(result).toBe(scope);
+			expect(context.getScope).toHaveBeenCalled();
+		});
+	});
+});

package/src/rules/util/context-compat.ts

@@ -24,5 +24,5 @@ const getSourceCode = (context: Rule.RuleContext): SourceCode => {
  * @param node - The node to get the scope for
  */
 export const getScope = (context: Rule.RuleContext, node: Node): Scope.Scope => {
-	return getSourceCode(context)?.getScope(node) ?? context.getScope();
+	return getSourceCode(context)?.getScope?.(node) ?? context.getScope();
 };