@atlaskit/eslint-plugin-platform 0.3.0 → 0.4.1

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/eslint-plugin-platform
 
+## 0.4.1
+
+### Patch Changes
+
+- [#78702](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/78702) [`6b76dabb8255`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/6b76dabb8255) - Add rule to check for invalid flag usages in exports
+
+## 0.4.0
+
+### Minor Changes
+
+- [#43563](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/43563) [`51f9f6e2f10`](https://bitbucket.org/atlassian/atlassian-frontend/commits/51f9f6e2f10) - Add @types/react v18.2 to critical deps whitelist
+
 ## 0.3.0
 
 ### Minor Changes

package/afm-cc/tsconfig.json

@@ -0,0 +1,21 @@
+{
+    "extends": "../../../../tsconfig.entry-points.confluence.json",
+    "compilerOptions": {
+        "target": "es5",
+        "composite": true,
+        "outDir": "../dist",
+        "rootDir": "../",
+        "baseUrl": "../"
+    },
+    "include": [
+        "../src/**/*.ts",
+        "../src/**/*.tsx"
+    ],
+    "exclude": [
+        "../src/**/__tests__/*",
+        "../__tests__/*",
+        "../src/**/*.test.*",
+        "../src/**/test.*"
+    ],
+    "references": []
+}

package/dist/cjs/index.js

@@ -18,7 +18,7 @@ var _ensureCriticalDependencyResolutions = _interopRequireDefault(require("./rul
 var _noInvalidStorybookDecoratorUsage = _interopRequireDefault(require("./rules/no-invalid-storybook-decorator-usage"));
 var _ensurePublishValid = _interopRequireDefault(require("./rules/ensure-publish-valid"));
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
-function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } // eslint-disable-next-line import/no-extraneous-dependencies
 var rules = exports.rules = {
   'ensure-feature-flag-registration': _ensureFeatureFlagRegistration.default,
   'ensure-feature-flag-prefix': _ensureFeatureFlagPrefix.default,

package/dist/cjs/rules/ensure-atlassian-team/index.js

@@ -4,6 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     type: 'problem',

package/dist/cjs/rules/ensure-critical-dependency-resolutions/index.js

@@ -8,11 +8,13 @@ exports.default = void 0;
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _findRoot = require("@manypkg/find-root");
 var _handleAstObject = require("../util/handle-ast-object");
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 // Here we only need to specify the major and minor versions
 // In matchMinorVersion, we will check if the versions in resolutions fall in the right ranges.
 var DESIRED_PKG_VERSIONS = {
-  typescript: '4.9',
-  '@types/react': '16.14'
+  typescript: ['4.9'],
+  '@types/react': ['16.14', '18.2']
 };
 var matchMinorVersion = function matchMinorVersion(desiredVersion, versionInResolutions) {
   var firstChar = versionInResolutions[0];
@@ -67,16 +69,25 @@ var rule = {
         var rootDir = (0, _findRoot.findRootSync)(process.cwd());
         var isRootPackageJson = fileName.endsWith("".concat(rootDir, "/package.json"));
         if (packageResolutions !== null) {
+          var _loop = function _loop() {
+              var _Object$entries$_i = (0, _slicedToArray2.default)(_Object$entries[_i], 2),
+                key = _Object$entries$_i[0],
+                values = _Object$entries$_i[1];
+              if (!values.some(function (value) {
+                return verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson);
+              })) {
+                return {
+                  v: context.report({
+                    node: node,
+                    messageId: 'invalidPackageResolution'
+                  })
+                };
+              }
+            },
+            _ret;
           for (var _i = 0, _Object$entries = Object.entries(DESIRED_PKG_VERSIONS); _i < _Object$entries.length; _i++) {
-            var _Object$entries$_i = (0, _slicedToArray2.default)(_Object$entries[_i], 2),
-              key = _Object$entries$_i[0],
-              value = _Object$entries$_i[1];
-            if (!verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson)) {
-              return context.report({
-                node: node,
-                messageId: 'invalidPackageResolution'
-              });
-            }
+            _ret = _loop();
+            if (_ret) return _ret.v;
           }
         }
       })

package/dist/cjs/rules/ensure-feature-flag-prefix/index.js

@@ -5,6 +5,8 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 var _registrationUtils = require("../util/registration-utils");
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     docs: {

package/dist/cjs/rules/ensure-feature-flag-registration/index.js

@@ -8,7 +8,7 @@ exports.default = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _registrationUtils = require("../util/registration-utils");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
-function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } // eslint-disable-next-line import/no-extraneous-dependencies
 var rule = {
   meta: {
     docs: {

package/dist/cjs/rules/ensure-publish-valid/index.js

@@ -5,6 +5,8 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 var _handleAstObject = require("../util/handle-ast-object");
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     type: 'problem',

package/dist/cjs/rules/ensure-test-runner-arguments/index.js

@@ -6,6 +6,8 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var TEST_RUNNER_IDENTIFIER = 'ffTest';
 var rule = {
   meta: {

package/dist/cjs/rules/ensure-test-runner-nested-count/index.js

@@ -8,6 +8,8 @@ exports.default = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var NESTED_LIMIT = 4;
 var TEST_RUNNER_IDENTIFIER = 'ffTest';
 var getDepthOfNestedRunner = function getDepthOfNestedRunner(node) {

package/dist/cjs/rules/no-duplicate-dependencies/index.js

@@ -9,6 +9,8 @@ var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/sli
 function _createForOfIteratorHelper(o, allowArrayLike) { var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; if (!it) { if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = it.call(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it.return != null) it.return(); } finally { if (didErr) throw err; } } }; }
 function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     type: 'problem',

package/dist/cjs/rules/no-invalid-feature-flag-usage/index.js

@@ -6,6 +6,8 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var FF_GETTER_BOOLEAN_IDENTIFIER = 'getBooleanFF';
 var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression(root, ignoredNode) {
   switch (root.type) {
@@ -48,11 +50,13 @@ var rule = {
     messages: {
       onlyInlineIf: "Only call feature flags as part of an expression, don't assign to a variable! See http://go/pff-eslint for more details",
       onlyStringLiteral: "Only get feature flags by string literal, don't use variables! See http://go/pff-eslint for more details",
-      multipleFlagCheckInExpression: "Only check one flag per expression! See http://go/pff-eslint for more details"
+      multipleFlagCheckInExpression: "Only check one flag per expression! See http://go/pff-eslint for more details",
+      noModuleScope: "Don't use platform feature flags in module scope! See http://go/pff-eslint for more details"
     }
   },
   create: function create(context) {
     return (0, _defineProperty2.default)({}, "CallExpression[callee.name=/".concat(FF_GETTER_BOOLEAN_IDENTIFIER, "/]"), function CallExpressionCalleeName(node) {
+      var _node$parent2;
       // to make typescript happy
       if (node.type === 'CallExpression') {
         var _node$parent;
@@ -65,7 +69,26 @@ var rule = {
         }
         switch ((_node$parent = node.parent) === null || _node$parent === void 0 ? void 0 : _node$parent.type) {
           case 'IfStatement':
+            break;
           case 'ConditionalExpression':
+            switch ((_node$parent2 = node.parent) === null || _node$parent2 === void 0 ? void 0 : _node$parent2.parent.type) {
+              case 'ExportDefaultDeclaration':
+                // handles "export default getBooleanFF('test-flag') ? "this is" : "not good";"
+                context.report({
+                  node: node,
+                  messageId: 'noModuleScope'
+                });
+                break;
+              case 'VariableDeclarator':
+                // handles "export const foo = getBooleanFF('test-flag') ? 'this is' : 'not good';"
+                if (node.parent.parent.parent.type === 'VariableDeclaration' && node.parent.parent.parent.parent.type === 'ExportNamedDeclaration') {
+                  context.report({
+                    node: node,
+                    messageId: 'noModuleScope'
+                  });
+                }
+                break;
+            }
             break;
           case 'UnaryExpression':
           case 'LogicalExpression':

package/dist/cjs/rules/no-invalid-storybook-decorator-usage/index.js

@@ -6,6 +6,8 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var STORYBOOK_DECORATOR_IDENTIFIER = 'withPlatformFeatureFlags';
 var rule = {
   meta: {

package/dist/cjs/rules/no-pre-post-installs/index.js

@@ -4,6 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     type: 'problem',

package/dist/es2019/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import ensureFeatureFlagRegistration from './rules/ensure-feature-flag-registration';
 import noPreAndPostInstallScripts from './rules/no-pre-post-installs';
 import ensureTestRunnerArguments from './rules/ensure-test-runner-arguments';

package/dist/es2019/rules/ensure-atlassian-team/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const rule = {
   meta: {
     type: 'problem',

package/dist/es2019/rules/ensure-critical-dependency-resolutions/index.js

@@ -1,11 +1,13 @@
 import { findRootSync } from '@manypkg/find-root';
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getObjectPropertyAsObject } from '../util/handle-ast-object';
 
 // Here we only need to specify the major and minor versions
 // In matchMinorVersion, we will check if the versions in resolutions fall in the right ranges.
 const DESIRED_PKG_VERSIONS = {
-  typescript: '4.9',
-  '@types/react': '16.14'
+  typescript: ['4.9'],
+  '@types/react': ['16.14', '18.2']
 };
 const matchMinorVersion = (desiredVersion, versionInResolutions) => {
   const firstChar = versionInResolutions[0];
@@ -48,8 +50,10 @@ const rule = {
         const rootDir = findRootSync(process.cwd());
         const isRootPackageJson = fileName.endsWith(`${rootDir}/package.json`);
         if (packageResolutions !== null) {
-          for (const [key, value] of Object.entries(DESIRED_PKG_VERSIONS)) {
-            if (!verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson)) {
+          for (const [key, values] of Object.entries(DESIRED_PKG_VERSIONS)) {
+            if (!values.some(value => {
+              return verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson);
+            })) {
               return context.report({
                 node,
                 messageId: 'invalidPackageResolution'

package/dist/es2019/rules/ensure-feature-flag-prefix/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getMetadataForFilename, getterIdentifierToFlagTypeMap } from '../util/registration-utils';
 const rule = {
   meta: {

package/dist/es2019/rules/ensure-feature-flag-registration/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getMetadataForFilename, getterIdentifierToFlagTypeMap } from '../util/registration-utils';
 const rule = {
   meta: {

package/dist/es2019/rules/ensure-publish-valid/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getObjectPropertyAsLiteral, getObjectPropertyAsObject } from '../util/handle-ast-object';
 const rule = {
   meta: {

package/dist/es2019/rules/ensure-test-runner-arguments/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const TEST_RUNNER_IDENTIFIER = 'ffTest';
 const rule = {
   meta: {

package/dist/es2019/rules/ensure-test-runner-nested-count/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const NESTED_LIMIT = 4;
 const TEST_RUNNER_IDENTIFIER = 'ffTest';
 const getDepthOfNestedRunner = node => {

package/dist/es2019/rules/no-duplicate-dependencies/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const rule = {
   meta: {
     type: 'problem',

package/dist/es2019/rules/no-invalid-feature-flag-usage/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const FF_GETTER_BOOLEAN_IDENTIFIER = 'getBooleanFF';
 const __isOnlyOneFlagCheckInExpression = (root, ignoredNode) => {
   switch (root.type) {
@@ -40,12 +42,14 @@ const rule = {
     messages: {
       onlyInlineIf: "Only call feature flags as part of an expression, don't assign to a variable! See http://go/pff-eslint for more details",
       onlyStringLiteral: "Only get feature flags by string literal, don't use variables! See http://go/pff-eslint for more details",
-      multipleFlagCheckInExpression: `Only check one flag per expression! See http://go/pff-eslint for more details`
+      multipleFlagCheckInExpression: `Only check one flag per expression! See http://go/pff-eslint for more details`,
+      noModuleScope: `Don't use platform feature flags in module scope! See http://go/pff-eslint for more details`
     }
   },
   create(context) {
     return {
       [`CallExpression[callee.name=/${FF_GETTER_BOOLEAN_IDENTIFIER}/]`]: node => {
+        var _node$parent2;
         // to make typescript happy
         if (node.type === 'CallExpression') {
           var _node$parent;
@@ -58,7 +62,26 @@ const rule = {
           }
           switch ((_node$parent = node.parent) === null || _node$parent === void 0 ? void 0 : _node$parent.type) {
             case 'IfStatement':
+              break;
             case 'ConditionalExpression':
+              switch ((_node$parent2 = node.parent) === null || _node$parent2 === void 0 ? void 0 : _node$parent2.parent.type) {
+                case 'ExportDefaultDeclaration':
+                  // handles "export default getBooleanFF('test-flag') ? "this is" : "not good";"
+                  context.report({
+                    node,
+                    messageId: 'noModuleScope'
+                  });
+                  break;
+                case 'VariableDeclarator':
+                  // handles "export const foo = getBooleanFF('test-flag') ? 'this is' : 'not good';"
+                  if (node.parent.parent.parent.type === 'VariableDeclaration' && node.parent.parent.parent.parent.type === 'ExportNamedDeclaration') {
+                    context.report({
+                      node,
+                      messageId: 'noModuleScope'
+                    });
+                  }
+                  break;
+              }
               break;
             case 'UnaryExpression':
             case 'LogicalExpression':

package/dist/es2019/rules/no-invalid-storybook-decorator-usage/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const STORYBOOK_DECORATOR_IDENTIFIER = 'withPlatformFeatureFlags';
 const rule = {
   meta: {

package/dist/es2019/rules/no-pre-post-installs/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const rule = {
   meta: {
     type: 'problem',

package/dist/esm/index.js

@@ -1,6 +1,8 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import ensureFeatureFlagRegistration from './rules/ensure-feature-flag-registration';
 import noPreAndPostInstallScripts from './rules/no-pre-post-installs';
 import ensureTestRunnerArguments from './rules/ensure-test-runner-arguments';

package/dist/esm/rules/ensure-atlassian-team/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     type: 'problem',

package/dist/esm/rules/ensure-critical-dependency-resolutions/index.js

@@ -1,12 +1,14 @@
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import { findRootSync } from '@manypkg/find-root';
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getObjectPropertyAsObject } from '../util/handle-ast-object';
 
 // Here we only need to specify the major and minor versions
 // In matchMinorVersion, we will check if the versions in resolutions fall in the right ranges.
 var DESIRED_PKG_VERSIONS = {
-  typescript: '4.9',
-  '@types/react': '16.14'
+  typescript: ['4.9'],
+  '@types/react': ['16.14', '18.2']
 };
 var matchMinorVersion = function matchMinorVersion(desiredVersion, versionInResolutions) {
   var firstChar = versionInResolutions[0];
@@ -61,16 +63,25 @@ var rule = {
         var rootDir = findRootSync(process.cwd());
         var isRootPackageJson = fileName.endsWith("".concat(rootDir, "/package.json"));
         if (packageResolutions !== null) {
+          var _loop = function _loop() {
+              var _Object$entries$_i = _slicedToArray(_Object$entries[_i], 2),
+                key = _Object$entries$_i[0],
+                values = _Object$entries$_i[1];
+              if (!values.some(function (value) {
+                return verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson);
+              })) {
+                return {
+                  v: context.report({
+                    node: node,
+                    messageId: 'invalidPackageResolution'
+                  })
+                };
+              }
+            },
+            _ret;
           for (var _i = 0, _Object$entries = Object.entries(DESIRED_PKG_VERSIONS); _i < _Object$entries.length; _i++) {
-            var _Object$entries$_i = _slicedToArray(_Object$entries[_i], 2),
-              key = _Object$entries$_i[0],
-              value = _Object$entries$_i[1];
-            if (!verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson)) {
-              return context.report({
-                node: node,
-                messageId: 'invalidPackageResolution'
-              });
-            }
+            _ret = _loop();
+            if (_ret) return _ret.v;
           }
         }
       })

package/dist/esm/rules/ensure-feature-flag-prefix/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getMetadataForFilename, getterIdentifierToFlagTypeMap } from '../util/registration-utils';
 var rule = {
   meta: {

package/dist/esm/rules/ensure-feature-flag-registration/index.js

@@ -1,6 +1,8 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getMetadataForFilename, getterIdentifierToFlagTypeMap } from '../util/registration-utils';
 var rule = {
   meta: {

package/dist/esm/rules/ensure-publish-valid/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getObjectPropertyAsLiteral, getObjectPropertyAsObject } from '../util/handle-ast-object';
 var rule = {
   meta: {

package/dist/esm/rules/ensure-test-runner-arguments/index.js

@@ -1,4 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var TEST_RUNNER_IDENTIFIER = 'ffTest';
 var rule = {
   meta: {

package/dist/esm/rules/ensure-test-runner-nested-count/index.js

@@ -1,6 +1,8 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var NESTED_LIMIT = 4;
 var TEST_RUNNER_IDENTIFIER = 'ffTest';
 var getDepthOfNestedRunner = function getDepthOfNestedRunner(node) {

package/dist/esm/rules/no-duplicate-dependencies/index.js

@@ -2,6 +2,8 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 function _createForOfIteratorHelper(o, allowArrayLike) { var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; if (!it) { if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = it.call(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it.return != null) it.return(); } finally { if (didErr) throw err; } } }; }
 function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
 function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     type: 'problem',

package/dist/esm/rules/no-invalid-feature-flag-usage/index.js

@@ -1,4 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var FF_GETTER_BOOLEAN_IDENTIFIER = 'getBooleanFF';
 var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression(root, ignoredNode) {
   switch (root.type) {
@@ -41,11 +43,13 @@ var rule = {
     messages: {
       onlyInlineIf: "Only call feature flags as part of an expression, don't assign to a variable! See http://go/pff-eslint for more details",
       onlyStringLiteral: "Only get feature flags by string literal, don't use variables! See http://go/pff-eslint for more details",
-      multipleFlagCheckInExpression: "Only check one flag per expression! See http://go/pff-eslint for more details"
+      multipleFlagCheckInExpression: "Only check one flag per expression! See http://go/pff-eslint for more details",
+      noModuleScope: "Don't use platform feature flags in module scope! See http://go/pff-eslint for more details"
     }
   },
   create: function create(context) {
     return _defineProperty({}, "CallExpression[callee.name=/".concat(FF_GETTER_BOOLEAN_IDENTIFIER, "/]"), function CallExpressionCalleeName(node) {
+      var _node$parent2;
       // to make typescript happy
       if (node.type === 'CallExpression') {
         var _node$parent;
@@ -58,7 +62,26 @@ var rule = {
         }
         switch ((_node$parent = node.parent) === null || _node$parent === void 0 ? void 0 : _node$parent.type) {
           case 'IfStatement':
+            break;
           case 'ConditionalExpression':
+            switch ((_node$parent2 = node.parent) === null || _node$parent2 === void 0 ? void 0 : _node$parent2.parent.type) {
+              case 'ExportDefaultDeclaration':
+                // handles "export default getBooleanFF('test-flag') ? "this is" : "not good";"
+                context.report({
+                  node: node,
+                  messageId: 'noModuleScope'
+                });
+                break;
+              case 'VariableDeclarator':
+                // handles "export const foo = getBooleanFF('test-flag') ? 'this is' : 'not good';"
+                if (node.parent.parent.parent.type === 'VariableDeclaration' && node.parent.parent.parent.parent.type === 'ExportNamedDeclaration') {
+                  context.report({
+                    node: node,
+                    messageId: 'noModuleScope'
+                  });
+                }
+                break;
+            }
             break;
           case 'UnaryExpression':
           case 'LogicalExpression':

package/dist/esm/rules/no-invalid-storybook-decorator-usage/index.js

@@ -1,4 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var STORYBOOK_DECORATOR_IDENTIFIER = 'withPlatformFeatureFlags';
 var rule = {
   meta: {

package/dist/esm/rules/no-pre-post-installs/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     type: 'problem',

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-platform",
   "description": "The essential plugin for use with Atlassian frontend platform tools",
-  "version": "0.3.0",
+  "version": "0.4.1",
   "author": "Atlassian Pty Ltd",
   "atlassian": {
     "team": "UIP - Platform Integration Trust (PITa)",
@@ -37,6 +37,7 @@
   },
   "devDependencies": {
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
+    "@types/eslint": "^8.4.5",
     "eslint": "^7.7.0",
     "tsconfig-paths": "^4.2.0"
   },

package/src/index.tsx

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Linter } from 'eslint';
 import ensureFeatureFlagRegistration from './rules/ensure-feature-flag-registration';
 import noPreAndPostInstallScripts from './rules/no-pre-post-installs';

package/src/rules/ensure-atlassian-team/index.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 
 const rule: Rule.RuleModule = {

package/src/rules/ensure-critical-dependency-resolutions/__test__/unit/rule.test.tsx

@@ -16,6 +16,16 @@ describe('test ensure-critical-dependency-resolutions rule', () => {
         }`,
         filename: `${cwd}/package.json`,
       },
+      // Root package.json, have all of the correct resolutions
+      {
+        code: `const foo = {
+                  "resolutions": {
+                      "@types/react": "18.2.28",
+                      "typescript": "4.9.5",
+                  }
+              }`,
+        filename: `${cwd}/package.json`,
+      },
       // Root package.json, have all of the correct resolutions with ~
       {
         code: `const foo = {

package/src/rules/ensure-critical-dependency-resolutions/index.tsx

@@ -1,13 +1,14 @@
 import { findRootSync } from '@manypkg/find-root';
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 import type { ObjectExpression } from 'estree';
 import { getObjectPropertyAsObject } from '../util/handle-ast-object';
 
 // Here we only need to specify the major and minor versions
 // In matchMinorVersion, we will check if the versions in resolutions fall in the right ranges.
-const DESIRED_PKG_VERSIONS: Record<string, string> = {
-  typescript: '4.9',
-  '@types/react': '16.14',
+const DESIRED_PKG_VERSIONS: Record<string, string[]> = {
+  typescript: ['4.9'],
+  '@types/react': ['16.14', '18.2'],
 };
 
 const matchMinorVersion = (
@@ -89,14 +90,16 @@ const rule: Rule.RuleModule = {
         const isRootPackageJson = fileName.endsWith(`${rootDir}/package.json`);
 
         if (packageResolutions !== null) {
-          for (const [key, value] of Object.entries(DESIRED_PKG_VERSIONS)) {
+          for (const [key, values] of Object.entries(DESIRED_PKG_VERSIONS)) {
             if (
-              !verifyResolutionFromObject(
-                packageResolutions as ObjectExpression,
-                key,
-                value,
-                !isRootPackageJson,
-              )
+              !values.some((value) => {
+                return verifyResolutionFromObject(
+                  packageResolutions as ObjectExpression,
+                  key,
+                  value,
+                  !isRootPackageJson,
+                );
+              })
             ) {
               return context.report({
                 node,

package/src/rules/ensure-feature-flag-prefix/index.tsx

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 import {
   getMetadataForFilename,

package/src/rules/ensure-feature-flag-registration/index.tsx

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 import {
   getMetadataForFilename,

package/src/rules/ensure-publish-valid/index.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 import {
   getObjectPropertyAsLiteral,

package/src/rules/ensure-test-runner-arguments/index.tsx

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 
 const TEST_RUNNER_IDENTIFIER = 'ffTest' as const;

package/src/rules/ensure-test-runner-nested-count/index.tsx

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 import type { SimpleCallExpression } from 'estree';
 

package/src/rules/no-duplicate-dependencies/index.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 
 const rule: Rule.RuleModule = {

package/src/rules/no-invalid-feature-flag-usage/__tests__/unit/rule.test.tsx

@@ -55,6 +55,15 @@ describe('enforce-feature-flag-usage-structure tests', () => {
           { messageId: 'multipleFlagCheckInExpression' },
         ],
       },
+      {
+        code: `export default getBooleanFF('test-flag') ? "this is" : "not good";`,
+        errors: [{ messageId: 'noModuleScope' }],
+      },
+      {
+        only: true,
+        code: `export const foo = getBooleanFF('test-flag') ? "this is" : "not good";`,
+        errors: [{ messageId: 'noModuleScope' }],
+      },
     ],
   });
 });

package/src/rules/no-invalid-feature-flag-usage/index.tsx

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 import type { Node, Expression } from 'estree';
 
@@ -62,6 +63,7 @@ const rule: Rule.RuleModule = {
       onlyStringLiteral:
         "Only get feature flags by string literal, don't use variables! See http://go/pff-eslint for more details",
       multipleFlagCheckInExpression: `Only check one flag per expression! See http://go/pff-eslint for more details`,
+      noModuleScope: `Don't use platform feature flags in module scope! See http://go/pff-eslint for more details`,
     },
   },
   create(context) {
@@ -82,7 +84,30 @@ const rule: Rule.RuleModule = {
 
           switch (node.parent?.type) {
             case 'IfStatement':
+              break;
             case 'ConditionalExpression':
+              switch (node.parent?.parent.type) {
+                case 'ExportDefaultDeclaration':
+                  // handles "export default getBooleanFF('test-flag') ? "this is" : "not good";"
+                  context.report({
+                    node,
+                    messageId: 'noModuleScope',
+                  });
+                  break;
+                case 'VariableDeclarator':
+                  // handles "export const foo = getBooleanFF('test-flag') ? 'this is' : 'not good';"
+                  if (
+                    node.parent.parent.parent.type === 'VariableDeclaration' &&
+                    node.parent.parent.parent.parent.type ===
+                      'ExportNamedDeclaration'
+                  ) {
+                    context.report({
+                      node,
+                      messageId: 'noModuleScope',
+                    });
+                  }
+                  break;
+              }
               break;
             case 'UnaryExpression':
             case 'LogicalExpression':

package/src/rules/no-invalid-storybook-decorator-usage/index.tsx

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 
 const STORYBOOK_DECORATOR_IDENTIFIER = 'withPlatformFeatureFlags' as const;

package/src/rules/no-pre-post-installs/index.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 
 const rule: Rule.RuleModule = {

package/tsconfig.app.json

@@ -32,5 +32,6 @@
     "composite": true,
     "outDir": "../../../tsDist/@atlaskit__eslint-plugin-platform/app"
   },
-  "references": []
+  "references": [],
+  "files": []
 }

package/tsconfig.dev.json

@@ -36,5 +36,6 @@
     {
       "path": "tsconfig.app.json"
     }
-  ]
+  ],
+  "files": []
 }

package/tmp/api-report-tmp.d.ts

@@ -1,50 +0,0 @@
-## API Report File for "@atlaskit/eslint-plugin-platform"
-
-> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
-
-```ts
-
-import type { Linter } from 'eslint';
-import { Rule } from 'eslint';
-
-// @public (undocumented)
-export const configs: {
-    recommended: {
-        plugins: string[];
-        rules: {
-            '@atlaskit/platform/ensure-feature-flag-registration': string;
-            '@atlaskit/platform/ensure-feature-flag-prefix': (string | {
-                allowedPrefixes: string[];
-            })[];
-            '@atlaskit/platform/ensure-test-runner-arguments': string;
-            '@atlaskit/platform/ensure-test-runner-nested-count': string;
-            '@atlaskit/platform/no-invalid-feature-flag-usage': string;
-            '@atlaskit/platform/no-invalid-storybook-decorator-usage': string;
-            '@atlaskit/platform/ensure-atlassian-team': string;
-        };
-    };
-};
-
-// @public (undocumented)
-export const processors: {
-    'package-json-processor': Linter.Processor<Linter.ProcessorFile | string>;
-};
-
-// @public (undocumented)
-export const rules: {
-    'ensure-feature-flag-registration': Rule.RuleModule;
-    'ensure-feature-flag-prefix': Rule.RuleModule;
-    'ensure-test-runner-arguments': Rule.RuleModule;
-    'ensure-test-runner-nested-count': Rule.RuleModule;
-    'ensure-atlassian-team': Rule.RuleModule;
-    'ensure-critical-dependency-resolutions': Rule.RuleModule;
-    'no-duplicate-dependencies': Rule.RuleModule;
-    'no-invalid-feature-flag-usage': Rule.RuleModule;
-    'no-pre-post-install-scripts': Rule.RuleModule;
-    'no-invalid-storybook-decorator-usage': Rule.RuleModule;
-    'ensure-publish-valid': Rule.RuleModule;
-};
-
-// (No @packageDocumentation comment for this package)
-
-```