@atlaskit/eslint-plugin-platform 0.2.6 → 0.4.0

package/dist/es2019/index.js

@@ -1,8 +1,11 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import ensureFeatureFlagRegistration from './rules/ensure-feature-flag-registration';
 import noPreAndPostInstallScripts from './rules/no-pre-post-installs';
 import ensureTestRunnerArguments from './rules/ensure-test-runner-arguments';
 import ensureTestRunnerNestedCount from './rules/ensure-test-runner-nested-count';
 import ensureAtlassianTeam from './rules/ensure-atlassian-team';
+import noDuplicateDependencies from './rules/no-duplicate-dependencies';
 import noInvalidFeatureFlagUsage from './rules/no-invalid-feature-flag-usage';
 import ensureFeatureFlagPrefix from './rules/ensure-feature-flag-prefix';
 import ensureCriticalDependencyResolutions from './rules/ensure-critical-dependency-resolutions';
@@ -15,6 +18,7 @@ export const rules = {
   'ensure-test-runner-nested-count': ensureTestRunnerNestedCount,
   'ensure-atlassian-team': ensureAtlassianTeam,
   'ensure-critical-dependency-resolutions': ensureCriticalDependencyResolutions,
+  'no-duplicate-dependencies': noDuplicateDependencies,
   'no-invalid-feature-flag-usage': noInvalidFeatureFlagUsage,
   'no-pre-post-install-scripts': noPreAndPostInstallScripts,
   'no-invalid-storybook-decorator-usage': noInvalidStorybookDecoratorUsage,
@@ -36,12 +40,31 @@ export const configs = {
     }
   }
 };
+const jsonPrefix = '/* eslint-disable quote-props, comma-dangle, quotes, semi, eol-last, @typescript-eslint/semi, no-template-curly-in-string */ module.exports = ';
 export const processors = {
   'package-json-processor': {
     preprocess: source => {
       // augment the json into a js file
-      return [`/* eslint-disable quote-props, comma-dangle, quotes, semi, eol-last, @typescript-eslint/semi, no-template-curly-in-string */ module.exports = ${source.trim()}`];
+      return [jsonPrefix + source.trim()];
     },
-    postprocess: errors => errors[0]
+    postprocess: messages => {
+      return messages[0].map(message => {
+        const {
+          fix
+        } = message;
+        if (!fix) {
+          return message;
+        }
+        const offset = jsonPrefix.length;
+        return {
+          ...message,
+          fix: {
+            ...fix,
+            range: [fix.range[0] - offset, fix.range[1] - offset]
+          }
+        };
+      });
+    },
+    supportsAutofix: true
   }
 };

package/dist/es2019/rules/ensure-atlassian-team/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const rule = {
   meta: {
     type: 'problem',

package/dist/es2019/rules/ensure-critical-dependency-resolutions/index.js

@@ -1,11 +1,13 @@
 import { findRootSync } from '@manypkg/find-root';
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getObjectPropertyAsObject } from '../util/handle-ast-object';
 
 // Here we only need to specify the major and minor versions
 // In matchMinorVersion, we will check if the versions in resolutions fall in the right ranges.
 const DESIRED_PKG_VERSIONS = {
-  typescript: '4.9',
-  '@types/react': '16.14'
+  typescript: ['4.9'],
+  '@types/react': ['16.14', '18.2']
 };
 const matchMinorVersion = (desiredVersion, versionInResolutions) => {
   const firstChar = versionInResolutions[0];
@@ -48,8 +50,10 @@ const rule = {
         const rootDir = findRootSync(process.cwd());
         const isRootPackageJson = fileName.endsWith(`${rootDir}/package.json`);
         if (packageResolutions !== null) {
-          for (const [key, value] of Object.entries(DESIRED_PKG_VERSIONS)) {
-            if (!verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson)) {
+          for (const [key, values] of Object.entries(DESIRED_PKG_VERSIONS)) {
+            if (!values.some(value => {
+              return verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson);
+            })) {
               return context.report({
                 node,
                 messageId: 'invalidPackageResolution'

package/dist/es2019/rules/ensure-feature-flag-prefix/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getMetadataForFilename, getterIdentifierToFlagTypeMap } from '../util/registration-utils';
 const rule = {
   meta: {

package/dist/es2019/rules/ensure-feature-flag-registration/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getMetadataForFilename, getterIdentifierToFlagTypeMap } from '../util/registration-utils';
 const rule = {
   meta: {

package/dist/es2019/rules/ensure-publish-valid/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getObjectPropertyAsLiteral, getObjectPropertyAsObject } from '../util/handle-ast-object';
 const rule = {
   meta: {

package/dist/es2019/rules/ensure-test-runner-arguments/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const TEST_RUNNER_IDENTIFIER = 'ffTest';
 const rule = {
   meta: {

package/dist/es2019/rules/ensure-test-runner-nested-count/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const NESTED_LIMIT = 4;
 const TEST_RUNNER_IDENTIFIER = 'ffTest';
 const getDepthOfNestedRunner = node => {

package/dist/es2019/rules/no-duplicate-dependencies/index.js

@@ -0,0 +1,67 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
+const rule = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'This rule disallows a dependency to be defined in both dependencies and devDependencies',
+      recommended: false
+    },
+    fixable: 'code',
+    messages: {
+      unexpectedDuplicateDependency: 'Unexpected duplicate dependency {{name}}'
+    }
+  },
+  create(context) {
+    const dependencies = new Map();
+    const devDependencies = new Map();
+    return {
+      'ObjectExpression Property[key.value=dependencies] Property': node => {
+        // @ts-expect-error
+        dependencies.set(node.key.value, node.key);
+      },
+      'ObjectExpression Property[key.value=devDependencies] Property': node => {
+        // @ts-expect-error
+        devDependencies.set(node.key.value, node.key);
+      },
+      'Program:exit': () => {
+        for (const [dependency, node] of devDependencies) {
+          if (dependencies.has(dependency)) {
+            context.report({
+              data: {
+                name: dependency
+              },
+              fix(fixer) {
+                var _sourceCode$getTokenA;
+                const sourceCode = context.getSourceCode();
+                const property = node.parent;
+                const isLastLine = ((_sourceCode$getTokenA = sourceCode.getTokenAfter(property)) === null || _sourceCode$getTokenA === void 0 ? void 0 : _sourceCode$getTokenA.value) === '}';
+                const end = property.loc.end;
+                if (!isLastLine) {
+                  return fixer.removeRange([sourceCode.getIndexFromLoc({
+                    line: property.loc.start.line,
+                    column: 0
+                  }), sourceCode.getIndexFromLoc({
+                    line: end.line + 1,
+                    column: 0
+                  })]);
+                }
+                const previousToken = sourceCode.getTokenBefore(property);
+                return fixer.removeRange([sourceCode.getIndexFromLoc({
+                  line: previousToken.loc.end.line,
+                  column: previousToken.loc.end.column - 1
+                }), sourceCode.getIndexFromLoc({
+                  line: end.line,
+                  column: end.column
+                })]);
+              },
+              messageId: 'unexpectedDuplicateDependency',
+              node
+            });
+          }
+        }
+      }
+    };
+  }
+};
+export default rule;

package/dist/es2019/rules/no-invalid-feature-flag-usage/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const FF_GETTER_BOOLEAN_IDENTIFIER = 'getBooleanFF';
 const __isOnlyOneFlagCheckInExpression = (root, ignoredNode) => {
   switch (root.type) {

package/dist/es2019/rules/no-invalid-storybook-decorator-usage/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const STORYBOOK_DECORATOR_IDENTIFIER = 'withPlatformFeatureFlags';
 const rule = {
   meta: {

package/dist/es2019/rules/no-pre-post-installs/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 const rule = {
   meta: {
     type: 'problem',

package/dist/esm/index.js

@@ -1,8 +1,14 @@
+import _defineProperty from "@babel/runtime/helpers/defineProperty";
+function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
+function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import ensureFeatureFlagRegistration from './rules/ensure-feature-flag-registration';
 import noPreAndPostInstallScripts from './rules/no-pre-post-installs';
 import ensureTestRunnerArguments from './rules/ensure-test-runner-arguments';
 import ensureTestRunnerNestedCount from './rules/ensure-test-runner-nested-count';
 import ensureAtlassianTeam from './rules/ensure-atlassian-team';
+import noDuplicateDependencies from './rules/no-duplicate-dependencies';
 import noInvalidFeatureFlagUsage from './rules/no-invalid-feature-flag-usage';
 import ensureFeatureFlagPrefix from './rules/ensure-feature-flag-prefix';
 import ensureCriticalDependencyResolutions from './rules/ensure-critical-dependency-resolutions';
@@ -15,6 +21,7 @@ export var rules = {
   'ensure-test-runner-nested-count': ensureTestRunnerNestedCount,
   'ensure-atlassian-team': ensureAtlassianTeam,
   'ensure-critical-dependency-resolutions': ensureCriticalDependencyResolutions,
+  'no-duplicate-dependencies': noDuplicateDependencies,
   'no-invalid-feature-flag-usage': noInvalidFeatureFlagUsage,
   'no-pre-post-install-scripts': noPreAndPostInstallScripts,
   'no-invalid-storybook-decorator-usage': noInvalidStorybookDecoratorUsage,
@@ -36,14 +43,27 @@ export var configs = {
     }
   }
 };
+var jsonPrefix = '/* eslint-disable quote-props, comma-dangle, quotes, semi, eol-last, @typescript-eslint/semi, no-template-curly-in-string */ module.exports = ';
 export var processors = {
   'package-json-processor': {
     preprocess: function preprocess(source) {
       // augment the json into a js file
-      return ["/* eslint-disable quote-props, comma-dangle, quotes, semi, eol-last, @typescript-eslint/semi, no-template-curly-in-string */ module.exports = ".concat(source.trim())];
+      return [jsonPrefix + source.trim()];
     },
-    postprocess: function postprocess(errors) {
-      return errors[0];
-    }
+    postprocess: function postprocess(messages) {
+      return messages[0].map(function (message) {
+        var fix = message.fix;
+        if (!fix) {
+          return message;
+        }
+        var offset = jsonPrefix.length;
+        return _objectSpread(_objectSpread({}, message), {}, {
+          fix: _objectSpread(_objectSpread({}, fix), {}, {
+            range: [fix.range[0] - offset, fix.range[1] - offset]
+          })
+        });
+      });
+    },
+    supportsAutofix: true
   }
 };

package/dist/esm/rules/ensure-atlassian-team/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     type: 'problem',

package/dist/esm/rules/ensure-critical-dependency-resolutions/index.js

@@ -1,12 +1,14 @@
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import { findRootSync } from '@manypkg/find-root';
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getObjectPropertyAsObject } from '../util/handle-ast-object';
 
 // Here we only need to specify the major and minor versions
 // In matchMinorVersion, we will check if the versions in resolutions fall in the right ranges.
 var DESIRED_PKG_VERSIONS = {
-  typescript: '4.9',
-  '@types/react': '16.14'
+  typescript: ['4.9'],
+  '@types/react': ['16.14', '18.2']
 };
 var matchMinorVersion = function matchMinorVersion(desiredVersion, versionInResolutions) {
   var firstChar = versionInResolutions[0];
@@ -61,16 +63,25 @@ var rule = {
         var rootDir = findRootSync(process.cwd());
         var isRootPackageJson = fileName.endsWith("".concat(rootDir, "/package.json"));
         if (packageResolutions !== null) {
+          var _loop = function _loop() {
+              var _Object$entries$_i = _slicedToArray(_Object$entries[_i], 2),
+                key = _Object$entries$_i[0],
+                values = _Object$entries$_i[1];
+              if (!values.some(function (value) {
+                return verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson);
+              })) {
+                return {
+                  v: context.report({
+                    node: node,
+                    messageId: 'invalidPackageResolution'
+                  })
+                };
+              }
+            },
+            _ret;
           for (var _i = 0, _Object$entries = Object.entries(DESIRED_PKG_VERSIONS); _i < _Object$entries.length; _i++) {
-            var _Object$entries$_i = _slicedToArray(_Object$entries[_i], 2),
-              key = _Object$entries$_i[0],
-              value = _Object$entries$_i[1];
-            if (!verifyResolutionFromObject(packageResolutions, key, value, !isRootPackageJson)) {
-              return context.report({
-                node: node,
-                messageId: 'invalidPackageResolution'
-              });
-            }
+            _ret = _loop();
+            if (_ret) return _ret.v;
           }
         }
       })

package/dist/esm/rules/ensure-feature-flag-prefix/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getMetadataForFilename, getterIdentifierToFlagTypeMap } from '../util/registration-utils';
 var rule = {
   meta: {

package/dist/esm/rules/ensure-feature-flag-registration/index.js

@@ -1,6 +1,8 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getMetadataForFilename, getterIdentifierToFlagTypeMap } from '../util/registration-utils';
 var rule = {
   meta: {

package/dist/esm/rules/ensure-publish-valid/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 import { getObjectPropertyAsLiteral, getObjectPropertyAsObject } from '../util/handle-ast-object';
 var rule = {
   meta: {

package/dist/esm/rules/ensure-test-runner-arguments/index.js

@@ -1,4 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var TEST_RUNNER_IDENTIFIER = 'ffTest';
 var rule = {
   meta: {

package/dist/esm/rules/ensure-test-runner-nested-count/index.js

@@ -1,6 +1,8 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var NESTED_LIMIT = 4;
 var TEST_RUNNER_IDENTIFIER = 'ffTest';
 var getDepthOfNestedRunner = function getDepthOfNestedRunner(node) {

package/dist/esm/rules/no-duplicate-dependencies/index.js

@@ -0,0 +1,85 @@
+import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
+function _createForOfIteratorHelper(o, allowArrayLike) { var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; if (!it) { if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = it.call(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it.return != null) it.return(); } finally { if (didErr) throw err; } } }; }
+function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
+function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
+// eslint-disable-next-line import/no-extraneous-dependencies
+
+var rule = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'This rule disallows a dependency to be defined in both dependencies and devDependencies',
+      recommended: false
+    },
+    fixable: 'code',
+    messages: {
+      unexpectedDuplicateDependency: 'Unexpected duplicate dependency {{name}}'
+    }
+  },
+  create: function create(context) {
+    var dependencies = new Map();
+    var devDependencies = new Map();
+    return {
+      'ObjectExpression Property[key.value=dependencies] Property': function ObjectExpressionPropertyKeyValueDependenciesProperty(node) {
+        // @ts-expect-error
+        dependencies.set(node.key.value, node.key);
+      },
+      'ObjectExpression Property[key.value=devDependencies] Property': function ObjectExpressionPropertyKeyValueDevDependenciesProperty(node) {
+        // @ts-expect-error
+        devDependencies.set(node.key.value, node.key);
+      },
+      'Program:exit': function ProgramExit() {
+        var _iterator = _createForOfIteratorHelper(devDependencies),
+          _step;
+        try {
+          var _loop = function _loop() {
+            var _step$value = _slicedToArray(_step.value, 2),
+              dependency = _step$value[0],
+              node = _step$value[1];
+            if (dependencies.has(dependency)) {
+              context.report({
+                data: {
+                  name: dependency
+                },
+                fix: function fix(fixer) {
+                  var _sourceCode$getTokenA;
+                  var sourceCode = context.getSourceCode();
+                  var property = node.parent;
+                  var isLastLine = ((_sourceCode$getTokenA = sourceCode.getTokenAfter(property)) === null || _sourceCode$getTokenA === void 0 ? void 0 : _sourceCode$getTokenA.value) === '}';
+                  var end = property.loc.end;
+                  if (!isLastLine) {
+                    return fixer.removeRange([sourceCode.getIndexFromLoc({
+                      line: property.loc.start.line,
+                      column: 0
+                    }), sourceCode.getIndexFromLoc({
+                      line: end.line + 1,
+                      column: 0
+                    })]);
+                  }
+                  var previousToken = sourceCode.getTokenBefore(property);
+                  return fixer.removeRange([sourceCode.getIndexFromLoc({
+                    line: previousToken.loc.end.line,
+                    column: previousToken.loc.end.column - 1
+                  }), sourceCode.getIndexFromLoc({
+                    line: end.line,
+                    column: end.column
+                  })]);
+                },
+                messageId: 'unexpectedDuplicateDependency',
+                node: node
+              });
+            }
+          };
+          for (_iterator.s(); !(_step = _iterator.n()).done;) {
+            _loop();
+          }
+        } catch (err) {
+          _iterator.e(err);
+        } finally {
+          _iterator.f();
+        }
+      }
+    };
+  }
+};
+export default rule;

package/dist/esm/rules/no-invalid-feature-flag-usage/index.js

@@ -1,4 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var FF_GETTER_BOOLEAN_IDENTIFIER = 'getBooleanFF';
 var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression(root, ignoredNode) {
   switch (root.type) {

package/dist/esm/rules/no-invalid-storybook-decorator-usage/index.js

@@ -1,4 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var STORYBOOK_DECORATOR_IDENTIFIER = 'withPlatformFeatureFlags';
 var rule = {
   meta: {

package/dist/esm/rules/no-pre-post-installs/index.js

@@ -1,3 +1,5 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
 var rule = {
   meta: {
     type: 'problem',

package/dist/types/index.d.ts

@@ -6,6 +6,7 @@ export declare const rules: {
     'ensure-test-runner-nested-count': import("eslint").Rule.RuleModule;
     'ensure-atlassian-team': import("eslint").Rule.RuleModule;
     'ensure-critical-dependency-resolutions': import("eslint").Rule.RuleModule;
+    'no-duplicate-dependencies': import("eslint").Rule.RuleModule;
     'no-invalid-feature-flag-usage': import("eslint").Rule.RuleModule;
     'no-pre-post-install-scripts': import("eslint").Rule.RuleModule;
     'no-invalid-storybook-decorator-usage': import("eslint").Rule.RuleModule;

package/dist/types/rules/no-duplicate-dependencies/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/index.d.ts

@@ -6,6 +6,7 @@ export declare const rules: {
     'ensure-test-runner-nested-count': import("eslint").Rule.RuleModule;
     'ensure-atlassian-team': import("eslint").Rule.RuleModule;
     'ensure-critical-dependency-resolutions': import("eslint").Rule.RuleModule;
+    'no-duplicate-dependencies': import("eslint").Rule.RuleModule;
     'no-invalid-feature-flag-usage': import("eslint").Rule.RuleModule;
     'no-pre-post-install-scripts': import("eslint").Rule.RuleModule;
     'no-invalid-storybook-decorator-usage': import("eslint").Rule.RuleModule;

package/dist/types-ts4.5/rules/no-duplicate-dependencies/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-platform",
   "description": "The essential plugin for use with Atlassian frontend platform tools",
-  "version": "0.2.6",
+  "version": "0.4.0",
   "author": "Atlassian Pty Ltd",
   "atlassian": {
     "team": "UIP - Platform Integration Trust (PITa)",
@@ -37,8 +37,9 @@
   },
   "devDependencies": {
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
+    "@types/eslint": "^8.4.5",
     "eslint": "^7.7.0",
-    "tsconfig-paths": "^3.9.0"
+    "tsconfig-paths": "^4.2.0"
   },
   "prettier": "@atlassian/atlassian-frontend-prettier-config-1.0.1"
 }

package/report.api.md

@@ -52,6 +52,7 @@ export const rules: {
   'ensure-test-runner-nested-count': Rule.RuleModule;
   'ensure-atlassian-team': Rule.RuleModule;
   'ensure-critical-dependency-resolutions': Rule.RuleModule;
+  'no-duplicate-dependencies': Rule.RuleModule;
   'no-invalid-feature-flag-usage': Rule.RuleModule;
   'no-pre-post-install-scripts': Rule.RuleModule;
   'no-invalid-storybook-decorator-usage': Rule.RuleModule;

package/src/index.tsx

@@ -1,9 +1,11 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Linter } from 'eslint';
 import ensureFeatureFlagRegistration from './rules/ensure-feature-flag-registration';
 import noPreAndPostInstallScripts from './rules/no-pre-post-installs';
 import ensureTestRunnerArguments from './rules/ensure-test-runner-arguments';
 import ensureTestRunnerNestedCount from './rules/ensure-test-runner-nested-count';
 import ensureAtlassianTeam from './rules/ensure-atlassian-team';
+import noDuplicateDependencies from './rules/no-duplicate-dependencies';
 import noInvalidFeatureFlagUsage from './rules/no-invalid-feature-flag-usage';
 import ensureFeatureFlagPrefix from './rules/ensure-feature-flag-prefix';
 import ensureCriticalDependencyResolutions from './rules/ensure-critical-dependency-resolutions';
@@ -17,6 +19,7 @@ export const rules = {
   'ensure-test-runner-nested-count': ensureTestRunnerNestedCount,
   'ensure-atlassian-team': ensureAtlassianTeam,
   'ensure-critical-dependency-resolutions': ensureCriticalDependencyResolutions,
+  'no-duplicate-dependencies': noDuplicateDependencies,
   'no-invalid-feature-flag-usage': noInvalidFeatureFlagUsage,
   'no-pre-post-install-scripts': noPreAndPostInstallScripts,
   'no-invalid-storybook-decorator-usage': noInvalidStorybookDecoratorUsage,
@@ -41,14 +44,32 @@ export const configs = {
   },
 };
 
+const jsonPrefix =
+  '/* eslint-disable quote-props, comma-dangle, quotes, semi, eol-last, @typescript-eslint/semi, no-template-curly-in-string */ module.exports = ';
+
 export const processors = {
   'package-json-processor': {
     preprocess: (source: string) => {
       // augment the json into a js file
-      return [
-        `/* eslint-disable quote-props, comma-dangle, quotes, semi, eol-last, @typescript-eslint/semi, no-template-curly-in-string */ module.exports = ${source.trim()}`,
-      ];
+      return [jsonPrefix + source.trim()];
+    },
+    postprocess: (messages) => {
+      return messages[0].map((message) => {
+        const { fix } = message;
+        if (!fix) {
+          return message;
+        }
+
+        const offset = jsonPrefix.length;
+        return {
+          ...message,
+          fix: {
+            ...fix,
+            range: [fix.range[0] - offset, fix.range[1] - offset],
+          },
+        };
+      });
     },
-    postprocess: (errors) => errors[0],
+    supportsAutofix: true,
   } as Linter.Processor,
 };

package/src/rules/ensure-atlassian-team/index.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import type { Rule } from 'eslint';
 
 const rule: Rule.RuleModule = {

package/src/rules/ensure-critical-dependency-resolutions/__test__/unit/rule.test.tsx

@@ -16,6 +16,16 @@ describe('test ensure-critical-dependency-resolutions rule', () => {
         }`,
         filename: `${cwd}/package.json`,
       },
+      // Root package.json, have all of the correct resolutions
+      {
+        code: `const foo = {
+                  "resolutions": {
+                      "@types/react": "18.2.28",
+                      "typescript": "4.9.5",
+                  }
+              }`,
+        filename: `${cwd}/package.json`,
+      },
       // Root package.json, have all of the correct resolutions with ~
       {
         code: `const foo = {