@atlaskit/eslint-plugin-platform 0.2.1 → 0.2.3

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/eslint-plugin-platform
 
+## 0.2.3
+
+### Patch Changes
+
+- [`0bf64fb3dd0`](https://bitbucket.org/atlassian/atlassian-frontend/commits/0bf64fb3dd0) - Update to support unary expressions like negation
+
+## 0.2.2
+
+### Patch Changes
+
+- [`9d00501a414`](https://bitbucket.org/atlassian/atlassian-frontend/commits/9d00501a414) - Ensure legacy types are published for TS 4.5-4.8
+
 ## 0.2.1
 
 ### Patch Changes

package/dist/cjs/rules/no-invalid-feature-flag-usage/index.js

@@ -11,6 +11,8 @@ var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression
   switch (root.type) {
     case 'IfStatement':
       return __isOnlyOneFlagCheckInExpression(root.test, ignoredNode);
+    case 'UnaryExpression':
+      return __isOnlyOneFlagCheckInExpression(root.argument, ignoredNode);
     case 'CallExpression':
       if (root === ignoredNode) {
         return true;
@@ -30,7 +32,8 @@ var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression
 var isOnlyOneFlagCheckInExpression = function isOnlyOneFlagCheckInExpression(node) {
   var root = node.parent;
   // find the root node of the expression
-  while (root.type === 'LogicalExpression') {
+  // NOTE: This is not an exhaustive check for all ESTree.Expression types but is good enough
+  while (root.type.endsWith('Expression')) {
     root = root.parent;
   }
   return __isOnlyOneFlagCheckInExpression(root, node);
@@ -64,6 +67,7 @@ var rule = {
           case 'IfStatement':
           case 'ConditionalExpression':
             break;
+          case 'UnaryExpression':
           case 'LogicalExpression':
             if (!isOnlyOneFlagCheckInExpression(node)) {
               context.report({

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-platform",
-	"version": "0.2.1",
+	"version": "0.2.3",
 	"sideEffects": false
 }

package/dist/es2019/rules/no-invalid-feature-flag-usage/index.js

@@ -3,6 +3,8 @@ const __isOnlyOneFlagCheckInExpression = (root, ignoredNode) => {
   switch (root.type) {
     case 'IfStatement':
       return __isOnlyOneFlagCheckInExpression(root.test, ignoredNode);
+    case 'UnaryExpression':
+      return __isOnlyOneFlagCheckInExpression(root.argument, ignoredNode);
     case 'CallExpression':
       if (root === ignoredNode) {
         return true;
@@ -22,7 +24,8 @@ const __isOnlyOneFlagCheckInExpression = (root, ignoredNode) => {
 const isOnlyOneFlagCheckInExpression = node => {
   let root = node.parent;
   // find the root node of the expression
-  while (root.type === 'LogicalExpression') {
+  // NOTE: This is not an exhaustive check for all ESTree.Expression types but is good enough
+  while (root.type.endsWith('Expression')) {
     root = root.parent;
   }
   return __isOnlyOneFlagCheckInExpression(root, node);
@@ -57,6 +60,7 @@ const rule = {
             case 'IfStatement':
             case 'ConditionalExpression':
               break;
+            case 'UnaryExpression':
             case 'LogicalExpression':
               if (!isOnlyOneFlagCheckInExpression(node)) {
                 context.report({

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-platform",
-	"version": "0.2.1",
+	"version": "0.2.3",
 	"sideEffects": false
 }

package/dist/esm/rules/no-invalid-feature-flag-usage/index.js

@@ -4,6 +4,8 @@ var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression
   switch (root.type) {
     case 'IfStatement':
       return __isOnlyOneFlagCheckInExpression(root.test, ignoredNode);
+    case 'UnaryExpression':
+      return __isOnlyOneFlagCheckInExpression(root.argument, ignoredNode);
     case 'CallExpression':
       if (root === ignoredNode) {
         return true;
@@ -23,7 +25,8 @@ var __isOnlyOneFlagCheckInExpression = function __isOnlyOneFlagCheckInExpression
 var isOnlyOneFlagCheckInExpression = function isOnlyOneFlagCheckInExpression(node) {
   var root = node.parent;
   // find the root node of the expression
-  while (root.type === 'LogicalExpression') {
+  // NOTE: This is not an exhaustive check for all ESTree.Expression types but is good enough
+  while (root.type.endsWith('Expression')) {
     root = root.parent;
   }
   return __isOnlyOneFlagCheckInExpression(root, node);
@@ -57,6 +60,7 @@ var rule = {
           case 'IfStatement':
           case 'ConditionalExpression':
             break;
+          case 'UnaryExpression':
           case 'LogicalExpression':
             if (!isOnlyOneFlagCheckInExpression(node)) {
               context.report({

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-platform",
-	"version": "0.2.1",
+	"version": "0.2.3",
 	"sideEffects": false
 }

package/dist/types-ts4.5/index.d.ts

@@ -0,0 +1,28 @@
+import type { Linter } from 'eslint';
+export declare const rules: {
+    'ensure-feature-flag-registration': import("eslint").Rule.RuleModule;
+    'ensure-feature-flag-prefix': import("eslint").Rule.RuleModule;
+    'ensure-test-runner-arguments': import("eslint").Rule.RuleModule;
+    'ensure-test-runner-nested-count': import("eslint").Rule.RuleModule;
+    'no-invalid-feature-flag-usage': import("eslint").Rule.RuleModule;
+    'no-pre-post-install-scripts': import("eslint").Rule.RuleModule;
+    'no-invalid-storybook-decorator-usage': import("eslint").Rule.RuleModule;
+};
+export declare const configs: {
+    recommended: {
+        plugins: string[];
+        rules: {
+            '@atlaskit/platform/ensure-feature-flag-registration': string;
+            '@atlaskit/platform/ensure-feature-flag-prefix': (string | {
+                allowedPrefixes: string[];
+            })[];
+            '@atlaskit/platform/ensure-test-runner-arguments': string;
+            '@atlaskit/platform/ensure-test-runner-nested-count': string;
+            '@atlaskit/platform/no-invalid-feature-flag-usage': string;
+            '@atlaskit/platform/no-invalid-storybook-decorator-usage': string;
+        };
+    };
+};
+export declare const processors: {
+    'package-json-processor': Linter.Processor<string | Linter.ProcessorFile>;
+};

package/dist/types-ts4.5/rules/ensure-feature-flag-prefix/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/rules/ensure-feature-flag-registration/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/rules/ensure-test-runner-arguments/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/rules/ensure-test-runner-nested-count/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/rules/no-invalid-feature-flag-usage/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/rules/no-invalid-storybook-decorator-usage/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/rules/no-pre-post-installs/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/rules/util/registration-utils.d.ts

@@ -0,0 +1,19 @@
+import readPkgUp from 'read-pkg-up';
+import Fuse from 'fuse.js';
+export declare const getterIdentifierToFlagTypeMap: {
+    readonly getBooleanFF: "boolean";
+    readonly ffTest: "boolean";
+};
+export type PlatformFeatureFlagRegistrationSection = {
+    [key: string]: {
+        type: (typeof getterIdentifierToFlagTypeMap)[keyof typeof getterIdentifierToFlagTypeMap];
+    };
+};
+export type EnhancedPackageJson = readPkgUp.PackageJson & {
+    'platform-feature-flags'?: PlatformFeatureFlagRegistrationSection;
+};
+export type PkgJsonMetaData = {
+    pkgJson: EnhancedPackageJson;
+    fuse: Fuse<string> | null;
+};
+export declare const getMetadataForFilename: (filename: string) => PkgJsonMetaData;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-platform",
   "description": "The essential plugin for use with Atlassian frontend platform tools",
-  "version": "0.2.1",
+  "version": "0.2.3",
   "author": "Atlassian Pty Ltd",
   "atlassian": {
     "team": "UIP - Platform Integration Trust (PITa)",

package/src/rules/no-invalid-feature-flag-usage/__tests__/unit/rule.test.tsx

@@ -8,6 +8,10 @@ describe('enforce-feature-flag-usage-structure tests', () => {
         // IfStatement
         code: `if(getBooleanFF('test-flag')) { }`,
       },
+      {
+        // negated IfStatement
+        code: `if(!getBooleanFF('test-flag')) { }`,
+      },
       {
         // ConditionalExpression
         code: `const val = getBooleanFF('test-flag') ? 'yay' : 'no';`,
@@ -38,7 +42,14 @@ describe('enforce-feature-flag-usage-structure tests', () => {
         ],
       },
       {
-        code: `if((getBooleanFF('test-flag') || 1 == true) && getBooleanFF('test-flag')) { }`,
+        code: `if(!getBooleanFF('test-flag') && !getBooleanFF('test-flag')) { }`,
+        errors: [
+          { messageId: 'multipleFlagCheckInExpression' },
+          { messageId: 'multipleFlagCheckInExpression' },
+        ],
+      },
+      {
+        code: `if((!getBooleanFF('test-flag') || 1 == true) && getBooleanFF('test-flag')) { }`,
         errors: [
           { messageId: 'multipleFlagCheckInExpression' },
           { messageId: 'multipleFlagCheckInExpression' },

package/src/rules/no-invalid-feature-flag-usage/index.tsx

@@ -1,17 +1,17 @@
 import type { Rule } from 'eslint';
+import type { Node, Expression } from 'estree';
 
 const FF_GETTER_BOOLEAN_IDENTIFIER = 'getBooleanFF' as const;
 
 const __isOnlyOneFlagCheckInExpression = (
-  root: Rule.Node,
-  ignoredNode: Rule.Node,
+  root: Node | Expression,
+  ignoredNode: Node,
 ): boolean => {
   switch (root.type) {
     case 'IfStatement':
-      return __isOnlyOneFlagCheckInExpression(
-        root.test as Rule.Node,
-        ignoredNode,
-      );
+      return __isOnlyOneFlagCheckInExpression(root.test, ignoredNode);
+    case 'UnaryExpression':
+      return __isOnlyOneFlagCheckInExpression(root.argument, ignoredNode);
 
     case 'CallExpression':
       if (root === ignoredNode) {
@@ -29,8 +29,8 @@ const __isOnlyOneFlagCheckInExpression = (
     case 'BinaryExpression':
     case 'LogicalExpression':
       return (
-        __isOnlyOneFlagCheckInExpression(root.left as Rule.Node, ignoredNode) &&
-        __isOnlyOneFlagCheckInExpression(root.right as Rule.Node, ignoredNode)
+        __isOnlyOneFlagCheckInExpression(root.left, ignoredNode) &&
+        __isOnlyOneFlagCheckInExpression(root.right, ignoredNode)
       );
 
     default:
@@ -41,7 +41,8 @@ const __isOnlyOneFlagCheckInExpression = (
 const isOnlyOneFlagCheckInExpression = (node: Rule.Node): boolean => {
   let root = node.parent;
   // find the root node of the expression
-  while (root.type === 'LogicalExpression') {
+  // NOTE: This is not an exhaustive check for all ESTree.Expression types but is good enough
+  while (root.type.endsWith('Expression')) {
     root = root.parent;
   }
 
@@ -83,6 +84,7 @@ const rule: Rule.RuleModule = {
             case 'IfStatement':
             case 'ConditionalExpression':
               break;
+            case 'UnaryExpression':
             case 'LogicalExpression':
               if (!isOnlyOneFlagCheckInExpression(node)) {
                 context.report({