@atlaskit/eslint-plugin-design-system 8.37.2 → 8.37.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 8.37.3
+
+### Patch Changes
+
+- [#83116](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/83116) [`8d4e99057fe0`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/8d4e99057fe0) - Upgrade Typescript from `4.9.5` to `5.4.2`
+
 ## 8.37.2
 
 ### Patch Changes

package/dist/cjs/rules/use-primitives/utils/validate-styles.js

@@ -93,7 +93,6 @@ var isTokenCall = function isTokenCall(node) {
     return false;
   }
   var token = ast.FunctionCall.getArgumentAtPos(node, 0);
-  var fallback = ast.FunctionCall.getArgumentAtPos(node, 1);
   if (!token || token.type !== 'Literal') {
     return false;
   }
@@ -104,7 +103,17 @@ var isTokenCall = function isTokenCall(node) {
   }
 
   // Not all `token()` calls have a fall back. This is fine, but if there is a fallback, make sure it's the same as the fallback xcss will use
-  if (fallback && fallback.type === 'Literal') {
+  if (node.arguments.length === 2) {
+    var fallback = ast.FunctionCall.getArgumentAtPos(node, 1);
+
+    // `getArgumentAtPos` is only able to understand `Literal` and `ObjectExpression` statements
+    // If there are 2 args, but `fallback` is undefined, then the fallback is something wild, like `token('space.100, `${gridSize * rem(3)`})`
+    if (!fallback) {
+      return false;
+    }
+    if (fallback.type !== 'Literal') {
+      return false;
+    }
     if (_transformers.spaceTokenMap[fallback.value] !== token.value) {
       return false;
     }

package/dist/es2019/rules/use-primitives/utils/validate-styles.js

@@ -86,7 +86,6 @@ const isTokenCall = node => {
     return false;
   }
   const token = ast.FunctionCall.getArgumentAtPos(node, 0);
-  const fallback = ast.FunctionCall.getArgumentAtPos(node, 1);
   if (!token || token.type !== 'Literal') {
     return false;
   }
@@ -97,7 +96,17 @@ const isTokenCall = node => {
   }
 
   // Not all `token()` calls have a fall back. This is fine, but if there is a fallback, make sure it's the same as the fallback xcss will use
-  if (fallback && fallback.type === 'Literal') {
+  if (node.arguments.length === 2) {
+    const fallback = ast.FunctionCall.getArgumentAtPos(node, 1);
+
+    // `getArgumentAtPos` is only able to understand `Literal` and `ObjectExpression` statements
+    // If there are 2 args, but `fallback` is undefined, then the fallback is something wild, like `token('space.100, `${gridSize * rem(3)`})`
+    if (!fallback) {
+      return false;
+    }
+    if (fallback.type !== 'Literal') {
+      return false;
+    }
     if (spaceTokenMap[fallback.value] !== token.value) {
       return false;
     }

package/dist/esm/rules/use-primitives/utils/validate-styles.js

@@ -84,7 +84,6 @@ var isTokenCall = function isTokenCall(node) {
     return false;
   }
   var token = ast.FunctionCall.getArgumentAtPos(node, 0);
-  var fallback = ast.FunctionCall.getArgumentAtPos(node, 1);
   if (!token || token.type !== 'Literal') {
     return false;
   }
@@ -95,7 +94,17 @@ var isTokenCall = function isTokenCall(node) {
   }
 
   // Not all `token()` calls have a fall back. This is fine, but if there is a fallback, make sure it's the same as the fallback xcss will use
-  if (fallback && fallback.type === 'Literal') {
+  if (node.arguments.length === 2) {
+    var fallback = ast.FunctionCall.getArgumentAtPos(node, 1);
+
+    // `getArgumentAtPos` is only able to understand `Literal` and `ObjectExpression` statements
+    // If there are 2 args, but `fallback` is undefined, then the fallback is something wild, like `token('space.100, `${gridSize * rem(3)`})`
+    if (!fallback) {
+      return false;
+    }
+    if (fallback.type !== 'Literal') {
+      return false;
+    }
     if (spaceTokenMap[fallback.value] !== token.value) {
       return false;
     }

package/dist/types/rules/index.codegen.d.ts

@@ -5,13 +5,13 @@ declare const _default: {
     'icon-label': import("eslint").Rule.RuleModule;
     'no-banned-imports': import("eslint").Rule.RuleModule;
     'no-css-tagged-template-expression': import("eslint").Rule.RuleModule;
-    'no-deprecated-apis': import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<string, [{
+    'no-deprecated-apis': import("@typescript-eslint/utils/dist/ts-eslint").RuleModule<string, [{
         deprecatedConfig: import("./utils/types").DeprecatedConfig;
-    }], import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>;
+    }], import("@typescript-eslint/utils/dist/ts-eslint").RuleListener>;
     'no-deprecated-design-token-usage': import("eslint").Rule.RuleModule;
-    'no-deprecated-imports': import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<string, [{
+    'no-deprecated-imports': import("@typescript-eslint/utils/dist/ts-eslint").RuleModule<string, [{
         deprecatedConfig: import("./utils/types").DeprecatedConfig;
-    }], import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>;
+    }], import("@typescript-eslint/utils/dist/ts-eslint").RuleListener>;
     'no-empty-styled-expression': import("eslint").Rule.RuleModule;
     'no-exported-css': import("eslint").Rule.RuleModule;
     'no-exported-keyframes': import("eslint").Rule.RuleModule;

package/dist/types/rules/use-visually-hidden/constants.d.ts

@@ -1,3 +1,3 @@
 export declare const IMPORT_NAME = "AKVisuallyHidden";
 export declare const VISUALLY_HIDDEN_SOURCE = "@atlaskit/visually-hidden";
-export declare const VISUALLY_HIDDEN_IMPORT: string;
+export declare const VISUALLY_HIDDEN_IMPORT = "import AKVisuallyHidden from '@atlaskit/visually-hidden';\n";

package/dist/types/rules/utils/create-rule.d.ts

@@ -9,7 +9,7 @@ import type { Rule } from 'eslint';
  * @private
  * @deprecated
  */
-export declare const createRule: <TOptions extends readonly unknown[], TMessageIds extends string, TRuleListener extends import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener = import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>({ name, meta, ...rule }: Readonly<ESLintUtils.RuleWithMetaAndName<TOptions, TMessageIds, TRuleListener>>) => import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<TMessageIds, TOptions, TRuleListener>;
+export declare const createRule: <TOptions extends readonly unknown[], TMessageIds extends string, TRuleListener extends import("@typescript-eslint/utils/dist/ts-eslint").RuleListener = import("@typescript-eslint/utils/dist/ts-eslint").RuleListener>({ name, meta, ...rule }: Readonly<ESLintUtils.RuleWithMetaAndName<TOptions, TMessageIds, TRuleListener>>) => import("@typescript-eslint/utils/dist/ts-eslint").RuleModule<TMessageIds, TOptions, TRuleListener>;
 export interface LintRule extends Omit<Rule.RuleModule, 'meta'> {
     /**
      * Including this for backwards compat moving from the typescript-eslint util.

package/dist/types-ts4.5/rules/index.codegen.d.ts

@@ -5,17 +5,17 @@ declare const _default: {
     'icon-label': import("eslint").Rule.RuleModule;
     'no-banned-imports': import("eslint").Rule.RuleModule;
     'no-css-tagged-template-expression': import("eslint").Rule.RuleModule;
-    'no-deprecated-apis': import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<string, [
+    'no-deprecated-apis': import("@typescript-eslint/utils/dist/ts-eslint").RuleModule<string, [
         {
             deprecatedConfig: import("./utils/types").DeprecatedConfig;
         }
-    ], import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>;
+    ], import("@typescript-eslint/utils/dist/ts-eslint").RuleListener>;
     'no-deprecated-design-token-usage': import("eslint").Rule.RuleModule;
-    'no-deprecated-imports': import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<string, [
+    'no-deprecated-imports': import("@typescript-eslint/utils/dist/ts-eslint").RuleModule<string, [
         {
             deprecatedConfig: import("./utils/types").DeprecatedConfig;
         }
-    ], import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>;
+    ], import("@typescript-eslint/utils/dist/ts-eslint").RuleListener>;
     'no-empty-styled-expression': import("eslint").Rule.RuleModule;
     'no-exported-css': import("eslint").Rule.RuleModule;
     'no-exported-keyframes': import("eslint").Rule.RuleModule;

package/dist/types-ts4.5/rules/use-visually-hidden/constants.d.ts

@@ -1,3 +1,3 @@
 export declare const IMPORT_NAME = "AKVisuallyHidden";
 export declare const VISUALLY_HIDDEN_SOURCE = "@atlaskit/visually-hidden";
-export declare const VISUALLY_HIDDEN_IMPORT: string;
+export declare const VISUALLY_HIDDEN_IMPORT = "import AKVisuallyHidden from '@atlaskit/visually-hidden';\n";

package/dist/types-ts4.5/rules/utils/create-rule.d.ts

@@ -9,7 +9,7 @@ import type { Rule } from 'eslint';
  * @private
  * @deprecated
  */
-export declare const createRule: <TOptions extends readonly unknown[], TMessageIds extends string, TRuleListener extends import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener = import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleListener>({ name, meta, ...rule }: Readonly<ESLintUtils.RuleWithMetaAndName<TOptions, TMessageIds, TRuleListener>>) => import("@typescript-eslint/utils/dist/ts-eslint/Rule").RuleModule<TMessageIds, TOptions, TRuleListener>;
+export declare const createRule: <TOptions extends readonly unknown[], TMessageIds extends string, TRuleListener extends import("@typescript-eslint/utils/dist/ts-eslint").RuleListener = import("@typescript-eslint/utils/dist/ts-eslint").RuleListener>({ name, meta, ...rule }: Readonly<ESLintUtils.RuleWithMetaAndName<TOptions, TMessageIds, TRuleListener>>) => import("@typescript-eslint/utils/dist/ts-eslint").RuleModule<TMessageIds, TOptions, TRuleListener>;
 export interface LintRule extends Omit<Rule.RuleModule, 'meta'> {
     /**
      * Including this for backwards compat moving from the typescript-eslint util.

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-design-system",
   "description": "The essential plugin for use with the Atlassian Design System.",
-  "version": "8.37.2",
+  "version": "8.37.3",
   "author": "Atlassian Pty Ltd",
   "license": "Apache-2.0",
   "publishConfig": {
@@ -64,7 +64,7 @@
     "ts-jest": "26.5.6",
     "ts-node": "^10.9.1",
     "tsconfig-paths": "^4.2.0",
-    "typescript": "~4.9.5"
+    "typescript": "~5.4.2"
   },
   "scripts": {
     "ak-postbuild": "cp -r configs dist",
@@ -87,4 +87,4 @@
   },
   "homepage": "https://atlassian.design/components/eslint-plugin-design-system",
   "prettier": "@atlassian/atlassian-frontend-prettier-config-1.0.1"
-}
+}