@atlaskit/eslint-plugin-design-system 8.33.0 → 8.34.0

package/dist/cjs/rules/use-tokens-typography/transformers/style-object.js

@@ -0,0 +1,212 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.StyleObject = void 0;
+var _eslintCodemodUtils = require("eslint-codemod-utils");
+var _astNodes = require("../../../ast-nodes");
+var _utils = require("../../ensure-design-token-usage/utils");
+var _isNode = require("../../utils/is-node");
+var _utils2 = require("../utils");
+/* eslint-disable @repo/internal/react/require-jsdoc */
+
+var StyleObject = exports.StyleObject = {
+  lint: function lint(node, _ref) {
+    var context = _ref.context;
+    // To force the correct node type
+    if (!(0, _eslintCodemodUtils.isNodeOfType)(node, 'ObjectExpression')) {
+      return {
+        success: false
+      };
+    }
+
+    // Check whether all criteria needed to make a transformation are met
+    var _StyleObject$_check = StyleObject._check(node, {
+        context: context
+      }),
+      success = _StyleObject$_check.success,
+      refs = _StyleObject$_check.refs;
+    if (!success || !refs) {
+      return;
+    }
+    var fontSizeNode = refs.fontSizeNode,
+      fontSizeRaw = refs.fontSizeRaw,
+      tokensImportNode = refs.tokensImportNode;
+    var fontSizeValue = (0, _utils.normaliseValue)('fontSize', fontSizeRaw);
+
+    // -- Font weight --
+    var fontWeightNode = _astNodes.Object.getEntryByPropertyName(node, 'fontWeight');
+    var fontWeightRaw = fontWeightNode && (0, _utils.getValueForPropertyNode)(fontWeightNode, context);
+
+    // If no fontWeight value exists, default to 400 to avoid matching with a bolder token resulting in a visual change
+    var fontWeightValue = fontWeightRaw && (0, _utils.normaliseValue)('fontWeight', fontWeightRaw) || _utils2.defaultFontWeight;
+    fontWeightValue = fontWeightValue.length === 3 ? fontWeightValue : _utils2.fontWeightMap[fontWeightValue] || _utils2.defaultFontWeight;
+
+    // -- Line height --
+    var lineHeightNode = _astNodes.Object.getEntryByPropertyName(node, 'lineHeight');
+    var lineHeightRaw = lineHeightNode && (0, _utils.getValueForPropertyNode)(lineHeightNode, context);
+    var shouldAddFontWeight = false;
+    var lineHeightValue = lineHeightRaw && (0, _utils.normaliseValue)('lineHeight', lineHeightRaw) || undefined;
+    if (lineHeightValue === fontSizeValue) {
+      lineHeightValue = '1';
+    }
+
+    // -- Match tokens --
+    var matchingTokens = (0, _utils2.findTypographyTokenForValues)(fontSizeValue, lineHeightValue);
+    if (matchingTokens.length) {
+      // If we have multiple matching tokens, try matching fontWeight
+      var matchingTokensWithWeight = matchingTokens.filter(function (token) {
+        return fontWeightValue ? token.values.fontWeight === fontWeightValue : token;
+      });
+      if (matchingTokensWithWeight.length) {
+        // Possibly narrowed down tokens
+        matchingTokens = matchingTokensWithWeight;
+      } else {
+        // Ended up with 0 matches by matching fontWeight
+        // return body token and add fontWeight manually
+        matchingTokens = matchingTokens.filter(function (token) {
+          return token.tokenName.includes('.body');
+        });
+        shouldAddFontWeight = true;
+      }
+    }
+
+    // Get other font-* nodes that we can replace/remove.
+    // These aren't needed for token matching.
+
+    // -- Font family --
+    var fontFamilyNode = _astNodes.Object.getEntryByPropertyName(node, 'fontFamily');
+    var fontFamilyRaw = fontFamilyNode && (0, _utils.getValueForPropertyNode)(fontFamilyNode, context);
+    var fontFamilyValue = fontFamilyRaw && (0, _utils.normaliseValue)('fontFamily', fontFamilyRaw) || undefined;
+    var fontFamilyToAdd;
+    // If font family uses the Charlie font we can't replace; exit
+    if (fontFamilyValue) {
+      if (fontFamilyValue.toLowerCase().includes('charlie display')) {
+        fontFamilyToAdd = 'heading';
+      } else if (fontFamilyValue.toLowerCase().includes('charlie text')) {
+        fontFamilyToAdd = 'body';
+      }
+    } else {
+      // Font family node exists but we can't resolve its value
+      // Will need to re-add it below the font property to ensure it still applies
+      fontFamilyToAdd = fontFamilyNode ? 'original' : undefined;
+    }
+
+    // -- Font style --
+    var fontStyleNode = _astNodes.Object.getEntryByPropertyName(node, 'fontStyle');
+    var fontStyleRaw = fontStyleNode && (0, _utils.getValueForPropertyNode)(fontStyleNode, context);
+    var fontStyleValue = fontStyleRaw && (0, _utils.normaliseValue)('fontStyle', fontStyleRaw) || undefined;
+    var fontStyleToAdd;
+    if (fontStyleValue === 'italic') {
+      fontStyleToAdd = 'italic';
+    }
+
+    // -- Letter spacing --
+    var letterSpacingNode = _astNodes.Object.getEntryByPropertyName(node, 'letterSpacing');
+
+    // A single matching token
+    // TOOD: Maybe suggest options if > 1 matching token
+    if (matchingTokens.length === 1) {
+      var matchingToken = matchingTokens[0];
+
+      // fontSize node is always first
+      var nodesToReplace = [fontSizeNode, fontWeightNode, lineHeightNode, fontFamilyNode, fontStyleNode, letterSpacingNode].filter(_utils2.notUndefined);
+      var fontFamilyTokenName = fontFamilyToAdd ? "font.family.brand.".concat(fontFamilyToAdd) : '';
+      var fontWeightReplacementToken = shouldAddFontWeight ? (0, _utils2.findFontWeightTokenForValue)(fontWeightValue) : undefined;
+      var fontWeightReplacement = fontWeightReplacementToken && (0, _utils2.getTokenProperty)('fontWeight', fontWeightReplacementToken.tokenName, fontWeightValue);
+      var fontFamilyReplacement = fontFamilyToAdd && (fontFamilyToAdd === 'original' ? (0, _utils2.convertPropertyNodeToStringableNode)(
+      // This will always exist if fontFamilyToAdd === 'original', TS can't figure that out.
+      fontFamilyNode) : (0, _utils2.getTokenProperty)('fontFamily', fontFamilyTokenName, (0, _utils2.findFontFamilyValueForToken)(fontFamilyTokenName)));
+      var fontStyleReplacement = fontStyleToAdd && (0, _utils2.getLiteralProperty)('fontStyle', fontStyleToAdd);
+      var fixerRefs = {
+        matchingToken: matchingToken,
+        nodesToReplace: nodesToReplace,
+        tokensImportNode: tokensImportNode,
+        fontWeightReplacement: fontWeightReplacement,
+        fontFamilyReplacement: fontFamilyReplacement,
+        fontStyleReplacement: fontStyleReplacement
+      };
+      context.report({
+        node: fontSizeNode,
+        messageId: 'noRawTypographyValues',
+        data: {
+          payload: "fontSize:".concat(fontSizeRaw)
+        },
+        fix: StyleObject._fix(fixerRefs, context)
+      });
+    } else if (!matchingTokens.length) {
+      context.report({
+        node: fontSizeNode,
+        messageId: 'noRawTypographyValues',
+        data: {
+          payload: "fontSize:".concat(fontSizeRaw)
+        }
+      });
+    }
+    return;
+  },
+  _check: function _check(node, _ref2) {
+    var context = _ref2.context;
+    if (!(0, _isNode.isDecendantOfStyleBlock)(node) && !(0, _isNode.isDecendantOfType)(node, 'JSXExpressionContainer')) {
+      return {
+        success: false
+      };
+    }
+
+    // -- Font size --
+    var fontSizeNode = _astNodes.Object.getEntryByPropertyName(node, 'fontSize');
+    if (!fontSizeNode || !(0, _utils2.isValidPropertyNode)(fontSizeNode) || (0, _isNode.isDecendantOfGlobalToken)(fontSizeNode.value)) {
+      return {
+        success: false
+      };
+    }
+    var fontSizeRaw = (0, _utils.getValueForPropertyNode)(fontSizeNode, context);
+
+    // Without a valid fontSize value we can't be certain what token should be used; exit
+    if (!fontSizeRaw) {
+      return {
+        success: false
+      };
+    }
+    var importDeclaration = _astNodes.Root.findImportsByModule(context.getSourceCode().ast.body, '@atlaskit/tokens');
+
+    // If there is more than one `@atlaskit/tokens` import, then it becomes difficult to determine which import to transform
+    if (importDeclaration.length > 1) {
+      return {
+        success: false
+      };
+    }
+    return {
+      success: true,
+      refs: {
+        fontSizeNode: fontSizeNode,
+        fontSizeRaw: fontSizeRaw,
+        tokensImportNode: importDeclaration[0]
+      }
+    };
+  },
+  _fix: function _fix(refs, context) {
+    return function (fixer) {
+      var matchingToken = refs.matchingToken,
+        nodesToReplace = refs.nodesToReplace,
+        tokensImportNode = refs.tokensImportNode,
+        fontWeightReplacement = refs.fontWeightReplacement,
+        fontFamilyReplacement = refs.fontFamilyReplacement,
+        fontStyleReplacement = refs.fontStyleReplacement;
+      var fontSizeNode = nodesToReplace[0];
+      return (!tokensImportNode ? [(0, _utils.insertTokensImport)(fixer)] : []).concat(nodesToReplace.map(function (node, index) {
+        // Replace first node with token, delete remaining nodes. Guaranteed to be fontSize
+        if (index === 0) {
+          return fixer.replaceText(node, "".concat((0, _utils2.getTokenProperty)('font', matchingToken.tokenName, matchingToken.tokenValue)));
+        }
+
+        // We don't replace fontWeight/fontFamily/fontStyle here in case it occurs before the font property.
+        // Instead delete the original property and add below
+        return _astNodes.ObjectEntry.deleteEntry(node, context, fixer);
+      }),
+      // Make sure font weight/family/style properties are added AFTER font property to ensure they override corectly
+      fontWeightReplacement ? [fixer.insertTextAfter(fontSizeNode, ",\n".concat(fontWeightReplacement))] : [], fontFamilyReplacement ? [fixer.insertTextAfter(fontSizeNode, ",\n".concat(fontFamilyReplacement))] : [], fontStyleReplacement ? [fixer.insertTextAfter(fontSizeNode, ",\n".concat(fontStyleReplacement))] : []);
+    };
+  }
+};

package/dist/cjs/rules/use-tokens-typography/utils.js

@@ -0,0 +1,146 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.convertPropertyNodeToStringableNode = convertPropertyNodeToStringableNode;
+exports.defaultFontWeight = void 0;
+exports.findFontFamilyValueForToken = findFontFamilyValueForToken;
+exports.findFontWeightTokenForValue = findFontWeightTokenForValue;
+exports.findTypographyTokenForValues = findTypographyTokenForValues;
+exports.fontWeightTokens = exports.fontWeightMap = exports.fontFamilyTokens = void 0;
+exports.getLiteralProperty = getLiteralProperty;
+exports.getTokenProperty = getTokenProperty;
+exports.isTypographyProperty = exports.isFontSizeSmall = exports.isFontSize = exports.isFontFamily = exports.isCodeFontFamily = void 0;
+exports.isValidPropertyNode = isValidPropertyNode;
+exports.notUndefined = notUndefined;
+exports.typographyValueToToken = exports.typographyProperties = void 0;
+var _eslintCodemodUtils = require("eslint-codemod-utils");
+var _palettesRaw = require("@atlaskit/tokens/palettes-raw");
+var _tokensRaw = require("@atlaskit/tokens/tokens-raw");
+var typographyProperties = exports.typographyProperties = ['fontSize', 'fontWeight', 'fontFamily', 'lineHeight'];
+var isTypographyProperty = exports.isTypographyProperty = function isTypographyProperty(propertyName) {
+  return typographyProperties.includes(propertyName);
+};
+var isFontSize = exports.isFontSize = function isFontSize(node) {
+  return (0, _eslintCodemodUtils.isNodeOfType)(node, 'CallExpression') && (0, _eslintCodemodUtils.isNodeOfType)(node.callee, 'Identifier') && (node.callee.name === 'fontSize' || node.callee.name === 'getFontSize');
+};
+var isFontSizeSmall = exports.isFontSizeSmall = function isFontSizeSmall(node) {
+  return (0, _eslintCodemodUtils.isNodeOfType)(node, 'CallExpression') && (0, _eslintCodemodUtils.isNodeOfType)(node.callee, 'Identifier') && node.callee.name === 'fontSizeSmall';
+};
+var isFontFamily = exports.isFontFamily = function isFontFamily(node) {
+  return (0, _eslintCodemodUtils.isNodeOfType)(node, 'CallExpression') && (0, _eslintCodemodUtils.isNodeOfType)(node.callee, 'Identifier') && (node.callee.name === 'fontFamily' || node.callee.name === 'getFontFamily');
+};
+var isCodeFontFamily = exports.isCodeFontFamily = function isCodeFontFamily(node) {
+  return (0, _eslintCodemodUtils.isNodeOfType)(node, 'CallExpression') && (0, _eslintCodemodUtils.isNodeOfType)(node.callee, 'Identifier') && (node.callee.name === 'codeFontFamily' || node.callee.name === 'getCodeFontFamily');
+};
+var typographyValueToToken = exports.typographyValueToToken = _tokensRaw.typographyAdg3
+// we're filtering here to remove the `font` tokens.
+.filter(function (t) {
+  return t.attributes.group === 'typography';
+}).filter(function (t) {
+  return t.cleanName.includes('font.heading') || t.cleanName.includes('font.body');
+}).map(function (currentToken) {
+  var _typographyPalette$fi, _typographyPalette$fi2, _typographyPalette$fi3;
+  var individualValues = {
+    fontSize: (_typographyPalette$fi = _palettesRaw.typographyPalette.find(function (baseToken) {
+      return baseToken.path.slice(-1)[0] ===
+      // @ts-expect-error token.original.value can be a string, due to the typographyTokens export including deprecated tokens
+      currentToken.original.value.fontSize;
+    })) === null || _typographyPalette$fi === void 0 ? void 0 : _typographyPalette$fi.value,
+    fontWeight: (_typographyPalette$fi2 = _palettesRaw.typographyPalette.find(function (baseToken) {
+      return baseToken.path.slice(-1)[0] ===
+      // @ts-expect-error token.original.value can be a string, due to the typographyTokens export including deprecated tokens
+      currentToken.original.value.fontWeight;
+    })) === null || _typographyPalette$fi2 === void 0 ? void 0 : _typographyPalette$fi2.value,
+    lineHeight: (_typographyPalette$fi3 = _palettesRaw.typographyPalette.find(function (baseToken) {
+      return baseToken.path.slice(-1)[0] ===
+      // @ts-expect-error token.original.value can be a string, due to the typographyTokens export including deprecated tokens
+      currentToken.original.value.lineHeight;
+    })) === null || _typographyPalette$fi3 === void 0 ? void 0 : _typographyPalette$fi3.value
+  };
+  return {
+    tokenName: currentToken.cleanName,
+    tokenValue: currentToken.value,
+    values: individualValues
+  };
+});
+function findTypographyTokenForValues(fontSize, lineHeight) {
+  var matchingTokens = typographyValueToToken.filter(function (token) {
+    return token.values.fontSize === fontSize;
+  })
+  // If lineHeight == 1, we don't match to a token
+  .filter(function () {
+    return lineHeight === '1' ? false : true;
+  });
+  return matchingTokens;
+}
+var fontWeightTokens = exports.fontWeightTokens = _tokensRaw.typographyAdg3.filter(function (token) {
+  return token.attributes.group === 'fontWeight';
+}).map(function (token) {
+  return {
+    tokenName: token.cleanName,
+    tokenValue: token.value,
+    values: {}
+  };
+});
+function findFontWeightTokenForValue(fontWeight) {
+  return fontWeightTokens.find(function (token) {
+    return token.tokenValue === fontWeight;
+  });
+}
+var fontWeightMap = exports.fontWeightMap = {
+  regular: '400',
+  medium: '500',
+  semibold: '600',
+  bold: '700'
+};
+var defaultFontWeight = exports.defaultFontWeight = fontWeightMap.regular;
+var fontFamilyTokens = exports.fontFamilyTokens = _tokensRaw.typographyAdg3.filter(function (token) {
+  return token.attributes.group === 'fontFamily';
+});
+function findFontFamilyValueForToken(tokenName) {
+  var _fontFamilyTokens$fin;
+  // Note this will only ever be undefined if the tokens get renamed, and should never happen.
+  return ((_fontFamilyTokens$fin = fontFamilyTokens.find(function (token) {
+    return token.cleanName === tokenName;
+  })) === null || _fontFamilyTokens$fin === void 0 ? void 0 : _fontFamilyTokens$fin.value) || '';
+}
+function notUndefined(value) {
+  return value !== undefined;
+}
+function isValidPropertyNode(node) {
+  if (!(0, _eslintCodemodUtils.isNodeOfType)(node.key, 'Identifier') && !(0, _eslintCodemodUtils.isNodeOfType)(node.key, 'Literal')) {
+    return false;
+  }
+  return true;
+}
+function getTokenNode(tokenName, tokenValue) {
+  return (0, _eslintCodemodUtils.callExpression)({
+    callee: (0, _eslintCodemodUtils.identifier)({
+      name: 'token'
+    }),
+    arguments: [(0, _eslintCodemodUtils.literal)({
+      value: "'".concat(tokenName, "'")
+    }), (0, _eslintCodemodUtils.literal)(tokenValue)],
+    optional: false
+  });
+}
+function getTokenProperty(propertyName, tokenName, tokenFallback) {
+  return (0, _eslintCodemodUtils.property)({
+    key: (0, _eslintCodemodUtils.identifier)(propertyName),
+    value: getTokenNode(tokenName, tokenFallback)
+  });
+}
+function getLiteralProperty(propertyName, propertyValue) {
+  return (0, _eslintCodemodUtils.property)({
+    key: (0, _eslintCodemodUtils.identifier)(propertyName),
+    value: (0, _eslintCodemodUtils.literal)(propertyValue)
+  });
+}
+function convertPropertyNodeToStringableNode(node) {
+  return (0, _eslintCodemodUtils.property)({
+    key: node.key,
+    value: node.value
+  });
+}

package/dist/es2019/ast-nodes/index.js

@@ -3,4 +3,5 @@ export { Import } from './import';
 export { JSXAttribute } from './jsx-attribute';
 export { JSXElement } from './jsx-element';
 export { Object } from './object';
+export { ObjectEntry } from './object-entry';
 export { Root } from './root';

package/dist/es2019/ast-nodes/object-entry.js

@@ -0,0 +1,22 @@
+const ObjectEntry = {
+  deleteEntry(node, context, fixer) {
+    var _lastToken;
+    // context.getSourceCode() is deprecated in favour of context.sourceCode, however this returns undefined for some reason
+    const sourceCode = context.getSourceCode();
+
+    // fixer.remove() doesn't account for things like commas or newlines within an ObjectExpression and will result in invalid output.
+    // This approach specifically removes the node and trailing comma, and should work for single- and multi-line objects.
+    // From https://github.com/eslint/eslint/issues/9576#issuecomment-341737453
+    let prevToken = sourceCode.getTokenBefore(node);
+    while (((_prevToken = prevToken) === null || _prevToken === void 0 ? void 0 : _prevToken.value) !== ',' && ((_prevToken2 = prevToken) === null || _prevToken2 === void 0 ? void 0 : _prevToken2.value) !== '{') {
+      var _prevToken, _prevToken2;
+      prevToken = sourceCode.getTokenBefore(node);
+    }
+    let lastToken = sourceCode.getTokenAfter(node);
+    if (((_lastToken = lastToken) === null || _lastToken === void 0 ? void 0 : _lastToken.value) !== ',') {
+      lastToken = sourceCode.getTokenBefore(lastToken);
+    }
+    return fixer.removeRange([prevToken.range[1], lastToken.range[1]]);
+  }
+};
+export { ObjectEntry };

package/dist/es2019/ast-nodes/object.js

@@ -27,7 +27,7 @@ const ASTObjectExpression = {
     });
   },
   /**
-   * Returns a key-value pair like: `padding: '8px'` from: `{ padding: '8px' }`.
+   * Returns the first Property node from an Object that matches the provided name.
    */
   getEntryByPropertyName(node, name) {
     return node.properties.find(property => {

package/dist/es2019/presets/all.codegen.js

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::bcb633b9d5c2def00d43b11139433c5c>>
+ * @codegen <<SignedSource::d90c2cf5e100daf98915f9467f2e5663>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 export default {
@@ -35,6 +35,7 @@ export default {
     '@atlaskit/design-system/use-href-in-link-item': 'warn',
     '@atlaskit/design-system/use-primitives': 'warn',
     '@atlaskit/design-system/use-primitives-text': 'warn',
+    '@atlaskit/design-system/use-tokens-typography': 'warn',
     '@atlaskit/design-system/use-visually-hidden': 'error'
   }
 };

package/dist/es2019/rules/ensure-design-token-usage/index.js

@@ -8,7 +8,7 @@ import { lintJSXIdentifierForColor, lintJSXLiteralForColor, lintJSXMemberForColo
 import { errorBoundary } from './error-boundary';
 import ruleMeta from './rule-meta';
 import { lintObjectForSpacing } from './spacing';
-import { convertHyphenatedNameToCamelCase, emToPixels, getDomainsForProperty, getFontSizeFromNode, getFontSizeValueInScope, getTokenReplacement, getValueFromShorthand, getValueFromTemplateLiteralRaw, includesTokenString, insertTokensImport, isAuto, isCalc, isTokenValueString, isValidSpacingValue, isZero, processCssNode, splitShorthandValues } from './utils';
+import { convertHyphenatedNameToCamelCase, emToPixels, getDomainsForProperty, getFontSizeValueInScope, getPropertyNodeFromParent, getTokenReplacement, getValueForPropertyNode, getValueFromShorthand, getValueFromTemplateLiteralRaw, includesTokenString, insertTokensImport, isAuto, isCalc, isTokenValueString, isValidSpacingValue, isZero, processCssNode, splitShorthandValues } from './utils';
 const defaultConfig = {
   domains: ['color', 'spacing'],
   applyImport: true,
@@ -89,11 +89,12 @@ const createWithConfig = initialConfig => context => {
         if (domains.includes('color')) {
           return lintObjectForColor(node, context, config);
         }
-        if (domains.includes('spacing') || domains.includes('shape') || domains.includes('typography')) {
+        if (domains.includes('spacing') || domains.includes('shape')) {
           /**
-           * We do this in case the fontSize for a style object is declared alongside the `em` or `lineHeight` declaration
+           * We do this in case the fontSize for a style object is declared alongside the `em` or `lineHeight` declaration.
            */
-          const fontSize = getFontSizeFromNode(parentNode, context);
+          const fontSizeNode = getPropertyNodeFromParent('fontSize', parentNode);
+          const fontSize = fontSizeNode && getValueForPropertyNode(fontSizeNode, context);
           return lintObjectForSpacing(node, context, config, fontSize, tokenNode);
         }
       }
@@ -140,7 +141,7 @@ const createWithConfig = initialConfig => context => {
             return currentSource;
           }
         }
-        if (domains.includes('spacing') || domains.includes('typography') || domains.includes('shape')) {
+        if (domains.includes('spacing') || domains.includes('shape')) {
           if (!isValidSpacingValue(resolvedCssValues, globalFontSize)) {
             // no changes should be made to the current property
             return currentSource;

package/dist/es2019/rules/ensure-design-token-usage/rule-meta.js

@@ -1,4 +1,4 @@
-const domainsToLint = ['color', 'spacing', 'typography', 'shape'];
+const domainsToLint = ['color', 'spacing', 'shape'];
 const ruleMeta = {
   name: 'ensure-design-token-usage',
   hasSuggestions: true,

package/dist/es2019/rules/ensure-design-token-usage/spacing.js

@@ -64,7 +64,8 @@ export const lintObjectForSpacing = (node, context, ruleConfig, fontSize, tokenN
         payload: `${propertyName}:${pixelValue}`
       },
       fix: fixer => {
-        const replacementNode = getTokenReplacement(propertyName, pixelValue);
+        // Casting due to possibility of pixelValue being string | number from emToPixels
+        const replacementNode = pixelValue && getTokenReplacement(propertyName, pixelValue);
         if (!replacementNode) {
           return null;
         }
@@ -110,6 +111,8 @@ export const lintObjectForSpacing = (node, context, ruleConfig, fontSize, tokenN
         if (!allResolvableValues) {
           return null;
         }
+
+        // Casting due to possibility of value being string | number
         const valuesWithTokenReplacement = valuesForProperty.filter(value => findTokenNameByPropertyValue(propertyName, value)).filter(value => value !== 0);
         if (valuesWithTokenReplacement.length === 0) {
           // all values could be replaceable but that just means they're numeric
@@ -139,6 +142,7 @@ export const lintObjectForSpacing = (node, context, ruleConfig, fontSize, tokenN
           const pixelValueString = `${pixelValue}px`;
           // if there is a token we take it, otherwise we go with the original value
 
+          // Casting due to possibility of value being string | number
           return findTokenNameByPropertyValue(propertyName, value) ? `\${${getTokenNodeForValue(propertyName, pixelValueString)}}` : originalValues[index];
         }).join(' ')}\``)]);
       }