@atlaskit/eslint-plugin-design-system 8.25.0 → 8.25.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 8.25.2
+
+### Patch Changes
+
+- [#71361](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/71361) [`0f3be2c76337`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/0f3be2c76337) - `use-primitives` no longer reports elements that have empty style objects.
+
+## 8.25.1
+
+### Patch Changes
+
+- [#67941](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/67941) [`0b1def807516`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/0b1def807516) - Now rule is aplicable only to ButtonGroup ImportSpecifiers
+
 ## 8.25.0
 
 ### Minor Changes

package/dist/cjs/ast-nodes/object.js

@@ -54,12 +54,19 @@ var ASTObjectExpression = exports.Object = {
     return [fixer.remove(entry)];
   },
   /**
-   * Returns a only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+   * Returns only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+   * If you want the key/value pair, use `getEntryByPropertyName`.
    */
   getProperty: function getProperty(node, name) {
     var _ASTObjectExpression$;
     return (_ASTObjectExpression$ = ASTObjectExpression.getEntryByPropertyName(node, name)) === null || _ASTObjectExpression$ === void 0 ? void 0 : _ASTObjectExpression$.key;
   },
+  /**
+   * Gets the array of key/value pairs in an ObjectExpression.
+   */
+  getEntries: function getEntries(node) {
+    return node.properties;
+  },
   /**
    * Returns a only the property @type {Property['value']} like: `'8px` from: `{ padding: '8px' }`.
    *

package/dist/cjs/rules/use-button-group-label/index.js

@@ -30,16 +30,18 @@ var rule = (0, _createRule.createLintRule)({
     var contextLocalIdentifier = [];
     return {
       ImportDeclaration: function ImportDeclaration(node) {
-        if (node.source.value === '@atlaskit/button') {
-          if (node.specifiers.length) {
-            var defaultImport = node.specifiers.filter(function (spec) {
-              return spec.type === 'ImportSpecifier';
-            });
-            if (defaultImport && defaultImport.length) {
-              var local = defaultImport[0].local;
-              contextLocalIdentifier.push(local.name);
-            }
+        var _node$specifiers;
+        var buttonGroupIdentifier = (_node$specifiers = node.specifiers) === null || _node$specifiers === void 0 ? void 0 : _node$specifiers.filter(function (spec) {
+          if (node.source.value === '@atlaskit/button') {
+            var _spec$imported;
+            return spec.type === 'ImportSpecifier' && ((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name) === 'ButtonGroup';
+          } else if (node.source.value === '@atlaskit/button/button-group') {
+            return spec.type === 'ImportDefaultSpecifier';
           }
+        });
+        if (buttonGroupIdentifier !== null && buttonGroupIdentifier !== void 0 && buttonGroupIdentifier.length) {
+          var local = buttonGroupIdentifier[0].local;
+          contextLocalIdentifier.push(local.name);
         }
       },
       JSXElement: function JSXElement(node) {

package/dist/cjs/rules/use-primitives/utils/is-valid-css-properties-to-transform.js

@@ -27,6 +27,11 @@ var isValidCssPropertiesToTransform = exports.isValidCssPropertiesToTransform =
   if (!ast.Object.isFlat(cssObjectExpression)) {
     return false;
   }
+
+  // `use-primitives` should not report on empty style objects. See: https://product-fabric.atlassian.net/browse/DSP-16520
+  if (ast.Object.getEntries(cssObjectExpression).length === 0) {
+    return false;
+  }
   var _convertASTObjectExpr = (0, _convertAstObjectExpressionToJsObject.convertASTObjectExpressionToJSObject)(cssObjectExpression),
     unsupported = _convertASTObjectExpr.unsupported,
     cssObject = (0, _objectWithoutProperties2.default)(_convertASTObjectExpr, _excluded);

package/dist/es2019/ast-nodes/object.js

@@ -48,12 +48,19 @@ const ASTObjectExpression = {
     return [fixer.remove(entry)];
   },
   /**
-   * Returns a only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+   * Returns only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+   * If you want the key/value pair, use `getEntryByPropertyName`.
    */
   getProperty(node, name) {
     var _ASTObjectExpression$;
     return (_ASTObjectExpression$ = ASTObjectExpression.getEntryByPropertyName(node, name)) === null || _ASTObjectExpression$ === void 0 ? void 0 : _ASTObjectExpression$.key;
   },
+  /**
+   * Gets the array of key/value pairs in an ObjectExpression.
+   */
+  getEntries(node) {
+    return node.properties;
+  },
   /**
    * Returns a only the property @type {Property['value']} like: `'8px` from: `{ padding: '8px' }`.
    *

package/dist/es2019/rules/use-button-group-label/index.js

@@ -24,16 +24,20 @@ const rule = createLintRule({
     const contextLocalIdentifier = [];
     return {
       ImportDeclaration(node) {
-        if (node.source.value === '@atlaskit/button') {
-          if (node.specifiers.length) {
-            const defaultImport = node.specifiers.filter(spec => spec.type === 'ImportSpecifier');
-            if (defaultImport && defaultImport.length) {
-              const {
-                local
-              } = defaultImport[0];
-              contextLocalIdentifier.push(local.name);
-            }
+        var _node$specifiers;
+        const buttonGroupIdentifier = (_node$specifiers = node.specifiers) === null || _node$specifiers === void 0 ? void 0 : _node$specifiers.filter(spec => {
+          if (node.source.value === '@atlaskit/button') {
+            var _spec$imported;
+            return spec.type === 'ImportSpecifier' && ((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name) === 'ButtonGroup';
+          } else if (node.source.value === '@atlaskit/button/button-group') {
+            return spec.type === 'ImportDefaultSpecifier';
           }
+        });
+        if (buttonGroupIdentifier !== null && buttonGroupIdentifier !== void 0 && buttonGroupIdentifier.length) {
+          const {
+            local
+          } = buttonGroupIdentifier[0];
+          contextLocalIdentifier.push(local.name);
         }
       },
       JSXElement(node) {

package/dist/es2019/rules/use-primitives/utils/is-valid-css-properties-to-transform.js

@@ -14,6 +14,11 @@ export const isValidCssPropertiesToTransform = (node, config) => {
   if (!ast.Object.isFlat(cssObjectExpression)) {
     return false;
   }
+
+  // `use-primitives` should not report on empty style objects. See: https://product-fabric.atlassian.net/browse/DSP-16520
+  if (ast.Object.getEntries(cssObjectExpression).length === 0) {
+    return false;
+  }
   const {
     unsupported,
     ...cssObject

package/dist/esm/ast-nodes/object.js

@@ -48,12 +48,19 @@ var ASTObjectExpression = {
     return [fixer.remove(entry)];
   },
   /**
-   * Returns a only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+   * Returns only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+   * If you want the key/value pair, use `getEntryByPropertyName`.
    */
   getProperty: function getProperty(node, name) {
     var _ASTObjectExpression$;
     return (_ASTObjectExpression$ = ASTObjectExpression.getEntryByPropertyName(node, name)) === null || _ASTObjectExpression$ === void 0 ? void 0 : _ASTObjectExpression$.key;
   },
+  /**
+   * Gets the array of key/value pairs in an ObjectExpression.
+   */
+  getEntries: function getEntries(node) {
+    return node.properties;
+  },
   /**
    * Returns a only the property @type {Property['value']} like: `'8px` from: `{ padding: '8px' }`.
    *

package/dist/esm/rules/use-button-group-label/index.js

@@ -24,16 +24,18 @@ var rule = createLintRule({
     var contextLocalIdentifier = [];
     return {
       ImportDeclaration: function ImportDeclaration(node) {
-        if (node.source.value === '@atlaskit/button') {
-          if (node.specifiers.length) {
-            var defaultImport = node.specifiers.filter(function (spec) {
-              return spec.type === 'ImportSpecifier';
-            });
-            if (defaultImport && defaultImport.length) {
-              var local = defaultImport[0].local;
-              contextLocalIdentifier.push(local.name);
-            }
+        var _node$specifiers;
+        var buttonGroupIdentifier = (_node$specifiers = node.specifiers) === null || _node$specifiers === void 0 ? void 0 : _node$specifiers.filter(function (spec) {
+          if (node.source.value === '@atlaskit/button') {
+            var _spec$imported;
+            return spec.type === 'ImportSpecifier' && ((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name) === 'ButtonGroup';
+          } else if (node.source.value === '@atlaskit/button/button-group') {
+            return spec.type === 'ImportDefaultSpecifier';
           }
+        });
+        if (buttonGroupIdentifier !== null && buttonGroupIdentifier !== void 0 && buttonGroupIdentifier.length) {
+          var local = buttonGroupIdentifier[0].local;
+          contextLocalIdentifier.push(local.name);
         }
       },
       JSXElement: function JSXElement(node) {

package/dist/esm/rules/use-primitives/utils/is-valid-css-properties-to-transform.js

@@ -17,6 +17,11 @@ export var isValidCssPropertiesToTransform = function isValidCssPropertiesToTran
   if (!ast.Object.isFlat(cssObjectExpression)) {
     return false;
   }
+
+  // `use-primitives` should not report on empty style objects. See: https://product-fabric.atlassian.net/browse/DSP-16520
+  if (ast.Object.getEntries(cssObjectExpression).length === 0) {
+    return false;
+  }
   var _convertASTObjectExpr = convertASTObjectExpressionToJSObject(cssObjectExpression),
     unsupported = _convertASTObjectExpr.unsupported,
     cssObject = _objectWithoutProperties(_convertASTObjectExpr, _excluded);

package/dist/types/ast-nodes/object.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { ObjectExpression, Property } from 'eslint-codemod-utils';
+import { ObjectExpression, Property, SpreadElement } from 'eslint-codemod-utils';
 declare const ASTObjectExpression: {
     /**
      * Returns `true` if an object contains a property with the specified name, `false` otherwise.
@@ -19,9 +19,14 @@ declare const ASTObjectExpression: {
     getEntryByPropertyName(node: ObjectExpression, name: string): Property | undefined;
     deleteEntry(node: ObjectExpression, name: string, fixer: Rule.RuleFixer): Rule.Fix[];
     /**
-     * Returns a only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+     * Returns only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+     * If you want the key/value pair, use `getEntryByPropertyName`.
      */
     getProperty(node: ObjectExpression, name: string): Property['key'] | undefined;
+    /**
+     * Gets the array of key/value pairs in an ObjectExpression.
+     */
+    getEntries(node: ObjectExpression): (Property | SpreadElement)[];
     /**
      * Returns a only the property @type {Property['value']} like: `'8px` from: `{ padding: '8px' }`.
      *

package/dist/types-ts4.5/ast-nodes/object.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { ObjectExpression, Property } from 'eslint-codemod-utils';
+import { ObjectExpression, Property, SpreadElement } from 'eslint-codemod-utils';
 declare const ASTObjectExpression: {
     /**
      * Returns `true` if an object contains a property with the specified name, `false` otherwise.
@@ -19,9 +19,14 @@ declare const ASTObjectExpression: {
     getEntryByPropertyName(node: ObjectExpression, name: string): Property | undefined;
     deleteEntry(node: ObjectExpression, name: string, fixer: Rule.RuleFixer): Rule.Fix[];
     /**
-     * Returns a only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+     * Returns only the property @type {Property['key']} like: `padding` from: `{ padding: '8px' }`.
+     * If you want the key/value pair, use `getEntryByPropertyName`.
      */
     getProperty(node: ObjectExpression, name: string): Property['key'] | undefined;
+    /**
+     * Gets the array of key/value pairs in an ObjectExpression.
+     */
+    getEntries(node: ObjectExpression): (Property | SpreadElement)[];
     /**
      * Returns a only the property @type {Property['value']} like: `'8px` from: `{ padding: '8px' }`.
      *

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-design-system",
   "description": "The essential plugin for use with the Atlassian Design System.",
-  "version": "8.25.0",
+  "version": "8.25.2",
   "author": "Atlassian Pty Ltd",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"