@atlaskit/eslint-plugin-design-system 5.0.0 → 5.0.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 5.0.2
+
+### Patch Changes
+
+- [`a5f1c4fa284`](https://bitbucket.org/atlassian/atlassian-frontend/commits/a5f1c4fa284) - Update links in the `use-primitives` rule to point to the right docs URL.
+
+## 5.0.1
+
+### Patch Changes
+
+- [`31ebca384fa`](https://bitbucket.org/atlassian/atlassian-frontend/commits/31ebca384fa) - Improved behaviour of `ensure-design-token-usage-spacing` rule to not report on or replace 0, auto, and calc within spacing properties.
+
 ## 5.0.0
 
 ### Major Changes

package/dist/cjs/rules/ensure-design-token-usage-spacing/index.js

@@ -118,6 +118,11 @@ var rule = (0, _createRule.createRule)({
             });
             return;
           }
+
+          // Don't report on CSS calc function
+          if (node.value.type === 'Literal' && (0, _utils.isCalc)(node.value.value)) {
+            return;
+          }
           var propertyName = node.key.name;
           var isFontFamily = /fontFamily/.test(propertyName);
           var value = (0, _utils.getValue)(node.value, context);
@@ -139,6 +144,11 @@ var rule = (0, _createRule.createRule)({
           if (values.length === 1 || isFontFamily) {
             var _values = (0, _slicedToArray2.default)(values, 1),
               _value = _values[0];
+
+            // Do not report or suggest a token to replace `0`
+            if ((0, _utils.isZero)(_value)) {
+              return;
+            }
             var pixelValue = isFontFamily ? _value : (0, _utils.emToPixels)(_value, fontSize);
             return context.report({
               node: node,
@@ -170,17 +180,22 @@ var rule = (0, _createRule.createRule)({
            * estree node.
            *
            * @example
-           * { padding: '8px 0px' } // two values we don't try and apply the fixer
+           * { padding: '8px 0px' }
            */
           values.forEach(function (val, index) {
             var pixelValue = (0, _utils.emToPixels)(val, fontSize);
+
+            // Do not report or suggest a token to replace `0`
+            if ((0, _utils.isZero)(val) || val === 'auto') {
+              return;
+            }
             context.report({
               node: node,
               messageId: 'noRawSpacingValues',
               data: {
                 payload: "".concat(propertyName, ":").concat(pixelValue)
               },
-              fix: index === 0 ? function (fixer) {
+              fix: function fix(fixer) {
                 var allResolvableValues = values.every(function (value) {
                   return !Number.isNaN((0, _utils.emToPixels)(value, fontSize));
                 });
@@ -189,6 +204,8 @@ var rule = (0, _createRule.createRule)({
                 }
                 var valuesWithTokenReplacement = values.filter(function (value) {
                   return (0, _utils.findTokenNameByPropertyValue)(propertyName, value);
+                }).filter(function (value) {
+                  return value !== 0;
                 });
                 if (valuesWithTokenReplacement.length === 0) {
                   // all values could be replaceable but that just means they're numeric
@@ -211,12 +228,16 @@ var rule = (0, _createRule.createRule)({
                   return null;
                 }
                 return (!tokenNode && ruleConfig.applyImport ? [(0, _utils.insertTokensImport)(fixer)] : []).concat([fixer.replaceText(node.value, "`".concat(values.map(function (value, index) {
+                  if ((0, _utils.isZero)(value)) {
+                    return originalValues[index];
+                  }
                   var pixelValue = (0, _utils.emToPixels)(value, fontSize);
                   var pixelValueString = "".concat(pixelValue, "px");
                   // if there is a token we take it, otherwise we go with the original value
+
                   return (0, _utils.findTokenNameByPropertyValue)(propertyName, value) ? "${".concat((0, _utils.getTokenNodeForValue)(propertyName, pixelValueString), "}") : originalValues[index];
                 }).join(' '), "`"))]);
-              } : undefined
+              }
             });
           });
         }
@@ -225,7 +246,7 @@ var rule = (0, _createRule.createRule)({
       // CSSTemplateLiteral and StyledTemplateLiteral
       // const cssTemplateLiteral = css`color: red; padding: 12px`;
       // const styledTemplateLiteral = styled.p`color: red; padding: 8px`;
-      'TaggedTemplateExpression[tag.name="css"],TaggedTemplateExpression[tag.object.name="styled"]': function TaggedTemplateExpressionTagNameCssTaggedTemplateExpressionTagObjectNameStyled(node) {
+      'TaggedTemplateExpression[tag.name="css"],TaggedTemplateExpression[tag.object.name="styled"],TaggedTemplateExpression[tag.callee.name="styled"]': function TaggedTemplateExpressionTagNameCssTaggedTemplateExpressionTagObjectNameStyledTaggedTemplateExpressionTagCalleeNameStyled(node) {
         if (node.type !== 'TaggedTemplateExpression') {
           return;
         }
@@ -282,17 +303,13 @@ var rule = (0, _createRule.createRule)({
               // if the value is already valid, nothing to report or replace
               return originalValue;
             }
-            if (isNaN(numericOrNanValue) && !isFontFamily) {
-              // this can be either a weird expression or a fontsize declaration
 
-              // we can't replace a NaN but we can alert what the offending value is
-              context.report({
-                node: node,
-                messageId: 'noRawSpacingValues',
-                data: {
-                  payload: "".concat(propertyName, ":").concat(originalValue)
-                }
-              });
+            // do not replace 0 with tokens
+            if ((0, _utils.isZero)(pxValue) || pxValue === 'auto') {
+              return originalValue;
+            }
+            if (isNaN(numericOrNanValue) && !isFontFamily) {
+              // do not report if we have nothing to replace with
               return originalValue;
             }
 

package/dist/cjs/rules/ensure-design-token-usage-spacing/utils.js

@@ -15,9 +15,9 @@ exports.getTokenNodeForValue = getTokenNodeForValue;
 exports.getTokenReplacement = getTokenReplacement;
 exports.getValueFromShorthand = exports.getValue = void 0;
 exports.insertTokensImport = insertTokensImport;
-exports.isSpacingProperty = void 0;
+exports.isSpacingProperty = exports.isCalc = void 0;
 exports.isTokenValueString = isTokenValueString;
-exports.onlyScaleTokens = exports.isValidSpacingValue = exports.isTypographyProperty = void 0;
+exports.onlyScaleTokens = exports.isZero = exports.isValidSpacingValue = exports.isTypographyProperty = void 0;
 exports.processCssNode = processCssNode;
 exports.removePixelSuffix = void 0;
 exports.shouldAnalyzeProperty = shouldAnalyzeProperty;
@@ -292,12 +292,11 @@ var emToPixels = function emToPixels(value, fontSize) {
   return value;
 };
 exports.emToPixels = emToPixels;
-var percentageOrEm = /(%$)|(\d+em$)/;
+var percentageOrEmOrAuto = /(%$)|(\d+em$)|(auto$)/;
 var removePixelSuffix = function removePixelSuffix(value) {
   var isString = typeof value === 'string';
-
   // @ts-ignore This shouldn't be a type error but CI is complaining
-  if (isString && percentageOrEm.test(value)) {
+  if (isString && percentageOrEmOrAuto.test(value)) {
     return value;
   }
 
@@ -305,7 +304,7 @@ var removePixelSuffix = function removePixelSuffix(value) {
   return Number(isString ? value.replace('px', '') : value);
 };
 exports.removePixelSuffix = removePixelSuffix;
-var invalidSpacingUnitRegex = /(%$)|(\d+rem$)|(^calc)|(vw$)|(vh$)/;
+var invalidSpacingUnitRegex = /(%$)|(\d+rem$)|(vw$)|(vh$)/;
 var isValidSpacingValue = function isValidSpacingValue(value, fontSize) {
   if (typeof value === 'string') {
     if (invalidSpacingUnitRegex.test(value)) {
@@ -324,9 +323,33 @@ var isValidSpacingValue = function isValidSpacingValue(value, fontSize) {
   }
   return true;
 };
+exports.isValidSpacingValue = isValidSpacingValue;
+var calcRegex = /(^calc)/;
+var isCalc = function isCalc(value) {
+  if (typeof value === 'string') {
+    if (calcRegex.test(value)) {
+      return true;
+    }
+  }
+  return false;
+};
+exports.isCalc = isCalc;
+var isZero = function isZero(value) {
+  if (typeof value === 'string') {
+    if (value === '0px' || value === '0') {
+      return true;
+    }
+  }
+  if (typeof value === 'number') {
+    if (value === 0) {
+      return true;
+    }
+  }
+  return false;
+};
 
 // convert line-height to lineHeight
-exports.isValidSpacingValue = isValidSpacingValue;
+exports.isZero = isZero;
 var convertHyphenatedNameToCamelCase = function convertHyphenatedNameToCamelCase(prop) {
   return prop.replace(/-./g, function (m) {
     return m[1].toUpperCase();

package/dist/cjs/rules/use-primitives/index.js

@@ -7,9 +7,9 @@ exports.default = void 0;
 var _eslintCodemodUtils = require("eslint-codemod-utils");
 var _createRule = require("../utils/create-rule");
 var _utils = require("./utils");
-var boxDocsUrl = 'https://atlassian.design/components/primitves/box/examples';
-var inlineDocsUrl = 'https://atlassian.design/components/primitves/inline/examples';
-var stackDocsUrl = 'https://atlassian.design/components/primitves/stack/examples';
+var boxDocsUrl = 'https://staging.atlassian.design/components/primitives/box';
+var inlineDocsUrl = 'https://staging.atlassian.design/components/primitives/inline';
+var stackDocsUrl = 'https://staging.atlassian.design/components/primitives/stack';
 var rule = (0, _createRule.createLintRule)({
   meta: {
     name: 'use-primitives',

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "5.0.0",
+	"version": "5.0.2",
 	"sideEffects": false
 }

package/dist/es2019/rules/ensure-design-token-usage-spacing/index.js

@@ -3,7 +3,7 @@
 import { isNodeOfType, node as nodeFn, property } from 'eslint-codemod-utils';
 import { createRule } from '../utils/create-rule';
 import { isDecendantOfGlobalToken } from '../utils/is-node';
-import { convertHyphenatedNameToCamelCase, emToPixels, findParentNodeForLine, findTokenNameByPropertyValue, getFontSizeValueInScope, getRawExpression, getTokenNodeForValue, getTokenReplacement, getValue, getValueFromShorthand, insertTokensImport, isTokenValueString, isTypographyProperty, isValidSpacingValue, processCssNode, shouldAnalyzeProperty, spacingValueToToken, splitShorthandValues, typographyValueToToken } from './utils';
+import { convertHyphenatedNameToCamelCase, emToPixels, findParentNodeForLine, findTokenNameByPropertyValue, getFontSizeValueInScope, getRawExpression, getTokenNodeForValue, getTokenReplacement, getValue, getValueFromShorthand, insertTokensImport, isCalc, isTokenValueString, isTypographyProperty, isValidSpacingValue, isZero, processCssNode, shouldAnalyzeProperty, spacingValueToToken, splitShorthandValues, typographyValueToToken } from './utils';
 const rule = createRule({
   defaultOptions: [{
     addons: ['spacing'],
@@ -109,6 +109,11 @@ const rule = createRule({
             });
             return;
           }
+
+          // Don't report on CSS calc function
+          if (node.value.type === 'Literal' && isCalc(node.value.value)) {
+            return;
+          }
           const propertyName = node.key.name;
           const isFontFamily = /fontFamily/.test(propertyName);
           const value = getValue(node.value, context);
@@ -129,6 +134,11 @@ const rule = createRule({
           // treat fontFamily as having one value
           if (values.length === 1 || isFontFamily) {
             const [value] = values;
+
+            // Do not report or suggest a token to replace `0`
+            if (isZero(value)) {
+              return;
+            }
             const pixelValue = isFontFamily ? value : emToPixels(value, fontSize);
             return context.report({
               node,
@@ -161,22 +171,27 @@ const rule = createRule({
            * estree node.
            *
            * @example
-           * { padding: '8px 0px' } // two values we don't try and apply the fixer
+           * { padding: '8px 0px' }
            */
           values.forEach((val, index) => {
             const pixelValue = emToPixels(val, fontSize);
+
+            // Do not report or suggest a token to replace `0`
+            if (isZero(val) || val === 'auto') {
+              return;
+            }
             context.report({
               node,
               messageId: 'noRawSpacingValues',
               data: {
                 payload: `${propertyName}:${pixelValue}`
               },
-              fix: index === 0 ? fixer => {
+              fix: fixer => {
                 const allResolvableValues = values.every(value => !Number.isNaN(emToPixels(value, fontSize)));
                 if (!allResolvableValues) {
                   return null;
                 }
-                const valuesWithTokenReplacement = values.filter(value => findTokenNameByPropertyValue(propertyName, value));
+                const valuesWithTokenReplacement = values.filter(value => findTokenNameByPropertyValue(propertyName, value)).filter(value => value !== 0);
                 if (valuesWithTokenReplacement.length === 0) {
                   // all values could be replaceable but that just means they're numeric
                   // if none of the values have token replacement we bail
@@ -198,12 +213,16 @@ const rule = createRule({
                   return null;
                 }
                 return (!tokenNode && ruleConfig.applyImport ? [insertTokensImport(fixer)] : []).concat([fixer.replaceText(node.value, `\`${values.map((value, index) => {
+                  if (isZero(value)) {
+                    return originalValues[index];
+                  }
                   const pixelValue = emToPixels(value, fontSize);
                   const pixelValueString = `${pixelValue}px`;
                   // if there is a token we take it, otherwise we go with the original value
+
                   return findTokenNameByPropertyValue(propertyName, value) ? `\${${getTokenNodeForValue(propertyName, pixelValueString)}}` : originalValues[index];
                 }).join(' ')}\``)]);
-              } : undefined
+              }
             });
           });
         }
@@ -212,7 +231,7 @@ const rule = createRule({
       // CSSTemplateLiteral and StyledTemplateLiteral
       // const cssTemplateLiteral = css`color: red; padding: 12px`;
       // const styledTemplateLiteral = styled.p`color: red; padding: 8px`;
-      'TaggedTemplateExpression[tag.name="css"],TaggedTemplateExpression[tag.object.name="styled"]': node => {
+      'TaggedTemplateExpression[tag.name="css"],TaggedTemplateExpression[tag.object.name="styled"],TaggedTemplateExpression[tag.callee.name="styled"]': node => {
         if (node.type !== 'TaggedTemplateExpression') {
           return;
         }
@@ -254,17 +273,13 @@ const rule = createRule({
               // if the value is already valid, nothing to report or replace
               return originalValue;
             }
-            if (isNaN(numericOrNanValue) && !isFontFamily) {
-              // this can be either a weird expression or a fontsize declaration
 
-              // we can't replace a NaN but we can alert what the offending value is
-              context.report({
-                node,
-                messageId: 'noRawSpacingValues',
-                data: {
-                  payload: `${propertyName}:${originalValue}`
-                }
-              });
+            // do not replace 0 with tokens
+            if (isZero(pxValue) || pxValue === 'auto') {
+              return originalValue;
+            }
+            if (isNaN(numericOrNanValue) && !isFontFamily) {
+              // do not report if we have nothing to replace with
               return originalValue;
             }
 

package/dist/es2019/rules/ensure-design-token-usage-spacing/utils.js

@@ -234,19 +234,18 @@ export const emToPixels = (value, fontSize) => {
   }
   return value;
 };
-const percentageOrEm = /(%$)|(\d+em$)/;
+const percentageOrEmOrAuto = /(%$)|(\d+em$)|(auto$)/;
 export const removePixelSuffix = value => {
   const isString = typeof value === 'string';
-
   // @ts-ignore This shouldn't be a type error but CI is complaining
-  if (isString && percentageOrEm.test(value)) {
+  if (isString && percentageOrEmOrAuto.test(value)) {
     return value;
   }
 
   // @ts-ignore This shouldn't be a type error but CI is complaining
   return Number(isString ? value.replace('px', '') : value);
 };
-const invalidSpacingUnitRegex = /(%$)|(\d+rem$)|(^calc)|(vw$)|(vh$)/;
+const invalidSpacingUnitRegex = /(%$)|(\d+rem$)|(vw$)|(vh$)/;
 export const isValidSpacingValue = (value, fontSize) => {
   if (typeof value === 'string') {
     if (invalidSpacingUnitRegex.test(value)) {
@@ -265,6 +264,28 @@ export const isValidSpacingValue = (value, fontSize) => {
   }
   return true;
 };
+const calcRegex = /(^calc)/;
+export const isCalc = value => {
+  if (typeof value === 'string') {
+    if (calcRegex.test(value)) {
+      return true;
+    }
+  }
+  return false;
+};
+export const isZero = value => {
+  if (typeof value === 'string') {
+    if (value === '0px' || value === '0') {
+      return true;
+    }
+  }
+  if (typeof value === 'number') {
+    if (value === 0) {
+      return true;
+    }
+  }
+  return false;
+};
 
 // convert line-height to lineHeight
 export const convertHyphenatedNameToCamelCase = prop => {

package/dist/es2019/rules/use-primitives/index.js

@@ -1,9 +1,9 @@
 import { isNodeOfType } from 'eslint-codemod-utils';
 import { createLintRule } from '../utils/create-rule';
 import { primitiveFixer, shouldSuggestBox, shouldSuggestInline, shouldSuggestStack } from './utils';
-const boxDocsUrl = 'https://atlassian.design/components/primitves/box/examples';
-const inlineDocsUrl = 'https://atlassian.design/components/primitves/inline/examples';
-const stackDocsUrl = 'https://atlassian.design/components/primitves/stack/examples';
+const boxDocsUrl = 'https://staging.atlassian.design/components/primitives/box';
+const inlineDocsUrl = 'https://staging.atlassian.design/components/primitives/inline';
+const stackDocsUrl = 'https://staging.atlassian.design/components/primitives/stack';
 const rule = createLintRule({
   meta: {
     name: 'use-primitives',

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "5.0.0",
+	"version": "5.0.2",
 	"sideEffects": false
 }

package/dist/esm/rules/ensure-design-token-usage-spacing/index.js

@@ -8,7 +8,7 @@ function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { va
 import { isNodeOfType, node as nodeFn, property } from 'eslint-codemod-utils';
 import { createRule } from '../utils/create-rule';
 import { isDecendantOfGlobalToken } from '../utils/is-node';
-import { convertHyphenatedNameToCamelCase, emToPixels, findParentNodeForLine, findTokenNameByPropertyValue, getFontSizeValueInScope, getRawExpression, getTokenNodeForValue, getTokenReplacement, getValue, getValueFromShorthand, insertTokensImport, isTokenValueString, isTypographyProperty, isValidSpacingValue, processCssNode, shouldAnalyzeProperty, spacingValueToToken, splitShorthandValues, typographyValueToToken } from './utils';
+import { convertHyphenatedNameToCamelCase, emToPixels, findParentNodeForLine, findTokenNameByPropertyValue, getFontSizeValueInScope, getRawExpression, getTokenNodeForValue, getTokenReplacement, getValue, getValueFromShorthand, insertTokensImport, isCalc, isTokenValueString, isTypographyProperty, isValidSpacingValue, isZero, processCssNode, shouldAnalyzeProperty, spacingValueToToken, splitShorthandValues, typographyValueToToken } from './utils';
 var rule = createRule({
   defaultOptions: [{
     addons: ['spacing'],
@@ -113,6 +113,11 @@ var rule = createRule({
             });
             return;
           }
+
+          // Don't report on CSS calc function
+          if (node.value.type === 'Literal' && isCalc(node.value.value)) {
+            return;
+          }
           var propertyName = node.key.name;
           var isFontFamily = /fontFamily/.test(propertyName);
           var value = getValue(node.value, context);
@@ -134,6 +139,11 @@ var rule = createRule({
           if (values.length === 1 || isFontFamily) {
             var _values = _slicedToArray(values, 1),
               _value = _values[0];
+
+            // Do not report or suggest a token to replace `0`
+            if (isZero(_value)) {
+              return;
+            }
             var pixelValue = isFontFamily ? _value : emToPixels(_value, fontSize);
             return context.report({
               node: node,
@@ -165,17 +175,22 @@ var rule = createRule({
            * estree node.
            *
            * @example
-           * { padding: '8px 0px' } // two values we don't try and apply the fixer
+           * { padding: '8px 0px' }
            */
           values.forEach(function (val, index) {
             var pixelValue = emToPixels(val, fontSize);
+
+            // Do not report or suggest a token to replace `0`
+            if (isZero(val) || val === 'auto') {
+              return;
+            }
             context.report({
               node: node,
               messageId: 'noRawSpacingValues',
               data: {
                 payload: "".concat(propertyName, ":").concat(pixelValue)
               },
-              fix: index === 0 ? function (fixer) {
+              fix: function fix(fixer) {
                 var allResolvableValues = values.every(function (value) {
                   return !Number.isNaN(emToPixels(value, fontSize));
                 });
@@ -184,6 +199,8 @@ var rule = createRule({
                 }
                 var valuesWithTokenReplacement = values.filter(function (value) {
                   return findTokenNameByPropertyValue(propertyName, value);
+                }).filter(function (value) {
+                  return value !== 0;
                 });
                 if (valuesWithTokenReplacement.length === 0) {
                   // all values could be replaceable but that just means they're numeric
@@ -206,12 +223,16 @@ var rule = createRule({
                   return null;
                 }
                 return (!tokenNode && ruleConfig.applyImport ? [insertTokensImport(fixer)] : []).concat([fixer.replaceText(node.value, "`".concat(values.map(function (value, index) {
+                  if (isZero(value)) {
+                    return originalValues[index];
+                  }
                   var pixelValue = emToPixels(value, fontSize);
                   var pixelValueString = "".concat(pixelValue, "px");
                   // if there is a token we take it, otherwise we go with the original value
+
                   return findTokenNameByPropertyValue(propertyName, value) ? "${".concat(getTokenNodeForValue(propertyName, pixelValueString), "}") : originalValues[index];
                 }).join(' '), "`"))]);
-              } : undefined
+              }
             });
           });
         }
@@ -220,7 +241,7 @@ var rule = createRule({
       // CSSTemplateLiteral and StyledTemplateLiteral
       // const cssTemplateLiteral = css`color: red; padding: 12px`;
       // const styledTemplateLiteral = styled.p`color: red; padding: 8px`;
-      'TaggedTemplateExpression[tag.name="css"],TaggedTemplateExpression[tag.object.name="styled"]': function TaggedTemplateExpressionTagNameCssTaggedTemplateExpressionTagObjectNameStyled(node) {
+      'TaggedTemplateExpression[tag.name="css"],TaggedTemplateExpression[tag.object.name="styled"],TaggedTemplateExpression[tag.callee.name="styled"]': function TaggedTemplateExpressionTagNameCssTaggedTemplateExpressionTagObjectNameStyledTaggedTemplateExpressionTagCalleeNameStyled(node) {
         if (node.type !== 'TaggedTemplateExpression') {
           return;
         }
@@ -277,17 +298,13 @@ var rule = createRule({
               // if the value is already valid, nothing to report or replace
               return originalValue;
             }
-            if (isNaN(numericOrNanValue) && !isFontFamily) {
-              // this can be either a weird expression or a fontsize declaration
 
-              // we can't replace a NaN but we can alert what the offending value is
-              context.report({
-                node: node,
-                messageId: 'noRawSpacingValues',
-                data: {
-                  payload: "".concat(propertyName, ":").concat(originalValue)
-                }
-              });
+            // do not replace 0 with tokens
+            if (isZero(pxValue) || pxValue === 'auto') {
+              return originalValue;
+            }
+            if (isNaN(numericOrNanValue) && !isFontFamily) {
+              // do not report if we have nothing to replace with
               return originalValue;
             }
 

package/dist/esm/rules/ensure-design-token-usage-spacing/utils.js

@@ -256,19 +256,18 @@ export var emToPixels = function emToPixels(value, fontSize) {
   }
   return value;
 };
-var percentageOrEm = /(%$)|(\d+em$)/;
+var percentageOrEmOrAuto = /(%$)|(\d+em$)|(auto$)/;
 export var removePixelSuffix = function removePixelSuffix(value) {
   var isString = typeof value === 'string';
-
   // @ts-ignore This shouldn't be a type error but CI is complaining
-  if (isString && percentageOrEm.test(value)) {
+  if (isString && percentageOrEmOrAuto.test(value)) {
     return value;
   }
 
   // @ts-ignore This shouldn't be a type error but CI is complaining
   return Number(isString ? value.replace('px', '') : value);
 };
-var invalidSpacingUnitRegex = /(%$)|(\d+rem$)|(^calc)|(vw$)|(vh$)/;
+var invalidSpacingUnitRegex = /(%$)|(\d+rem$)|(vw$)|(vh$)/;
 export var isValidSpacingValue = function isValidSpacingValue(value, fontSize) {
   if (typeof value === 'string') {
     if (invalidSpacingUnitRegex.test(value)) {
@@ -287,6 +286,28 @@ export var isValidSpacingValue = function isValidSpacingValue(value, fontSize) {
   }
   return true;
 };
+var calcRegex = /(^calc)/;
+export var isCalc = function isCalc(value) {
+  if (typeof value === 'string') {
+    if (calcRegex.test(value)) {
+      return true;
+    }
+  }
+  return false;
+};
+export var isZero = function isZero(value) {
+  if (typeof value === 'string') {
+    if (value === '0px' || value === '0') {
+      return true;
+    }
+  }
+  if (typeof value === 'number') {
+    if (value === 0) {
+      return true;
+    }
+  }
+  return false;
+};
 
 // convert line-height to lineHeight
 export var convertHyphenatedNameToCamelCase = function convertHyphenatedNameToCamelCase(prop) {

package/dist/esm/rules/use-primitives/index.js

@@ -1,9 +1,9 @@
 import { isNodeOfType } from 'eslint-codemod-utils';
 import { createLintRule } from '../utils/create-rule';
 import { primitiveFixer, shouldSuggestBox, shouldSuggestInline, shouldSuggestStack } from './utils';
-var boxDocsUrl = 'https://atlassian.design/components/primitves/box/examples';
-var inlineDocsUrl = 'https://atlassian.design/components/primitves/inline/examples';
-var stackDocsUrl = 'https://atlassian.design/components/primitves/stack/examples';
+var boxDocsUrl = 'https://staging.atlassian.design/components/primitives/box';
+var inlineDocsUrl = 'https://staging.atlassian.design/components/primitives/inline';
+var stackDocsUrl = 'https://staging.atlassian.design/components/primitives/stack';
 var rule = createLintRule({
   meta: {
     name: 'use-primitives',

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "5.0.0",
+	"version": "5.0.2",
 	"sideEffects": false
 }

package/dist/types/rules/ensure-design-token-usage-spacing/utils.d.ts

@@ -91,6 +91,8 @@ export declare const getRawExpression: (node: EslintNode, context: Rule.RuleCont
 export declare const emToPixels: <T extends unknown>(value: T, fontSize: number | null | undefined) => number | T | null;
 export declare const removePixelSuffix: (value: string | number) => string | number;
 export declare const isValidSpacingValue: (value: string | number | boolean | RegExp | null | undefined | any[] | bigint, fontSize?: number | null | undefined) => boolean;
+export declare const isCalc: (value: string | number | boolean | RegExp | null | undefined | any[] | bigint) => boolean;
+export declare const isZero: (value: string | number | boolean | RegExp | null | undefined | any[] | bigint) => boolean;
 export declare const convertHyphenatedNameToCamelCase: (prop: string) => string;
 /**
  * @param node

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-design-system",
   "description": "The essential plugin for use with the Atlassian Design System.",
-  "version": "5.0.0",
+  "version": "5.0.2",
   "author": "Atlassian Pty Ltd",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"