@atlaskit/eslint-plugin-design-system 4.4.5 → 4.6.0

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 4.6.0
+
+### Minor Changes
+
+- [`f561f58bc7a`](https://bitbucket.org/atlassian/atlassian-frontend/commits/f561f58bc7a) - Introduces a new rule `icon-label` to validate accessible usage of the icon components label prop when used with other design system components.
+
+## 4.5.0
+
+### Minor Changes
+
+- [`b7235858f48`](https://bitbucket.org/atlassian/atlassian-frontend/commits/b7235858f48) - Add new paths to the no-deprecated-imports rule for deprecated @atlaskit/logo exports.
+
+## 4.4.6
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 4.4.5
 
 ### Patch Changes

package/dist/cjs/index.js

@@ -9,6 +9,8 @@ exports.rules = exports.configs = void 0;
 
 var _ensureDesignTokenUsage = _interopRequireDefault(require("./rules/ensure-design-token-usage"));
 
+var _iconLabel = _interopRequireDefault(require("./rules/icon-label"));
+
 var _noDeprecatedApis = _interopRequireDefault(require("./rules/no-deprecated-apis"));
 
 var _noDeprecatedDesignTokenUsage = _interopRequireDefault(require("./rules/no-deprecated-design-token-usage"));
@@ -21,10 +23,11 @@ var _useVisuallyHidden = _interopRequireDefault(require("./rules/use-visually-hi
 
 var rules = {
   'ensure-design-token-usage': _ensureDesignTokenUsage.default,
-  'no-unsafe-design-token-usage': _noUnsafeDesignTokenUsage.default,
+  'icon-label': _iconLabel.default,
+  'no-deprecated-apis': _noDeprecatedApis.default,
   'no-deprecated-design-token-usage': _noDeprecatedDesignTokenUsage.default,
   'no-deprecated-imports': _noDeprecatedImports.default,
-  'no-deprecated-apis': _noDeprecatedApis.default,
+  'no-unsafe-design-token-usage': _noUnsafeDesignTokenUsage.default,
   'use-visually-hidden': _useVisuallyHidden.default
 };
 exports.rules = rules;
@@ -32,9 +35,10 @@ var configs = {
   recommended: {
     plugins: ['@atlaskit/design-system'],
     rules: {
+      '@atlaskit/design-system/icon-label': 'warn',
+      '@atlaskit/design-system/no-deprecated-apis': 'warn',
       '@atlaskit/design-system/no-deprecated-imports': 'error',
-      '@atlaskit/design-system/use-visually-hidden': 'error',
-      '@atlaskit/design-system/no-deprecated-apis': 'warn'
+      '@atlaskit/design-system/use-visually-hidden': 'error'
     }
   }
 };

package/dist/cjs/rules/icon-label/index.js

@@ -0,0 +1,134 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+
+var _jsx = require("../utils/jsx");
+
+var elements = ['AkButton', 'AKButton', 'Button', 'MenuItem', 'ButtonItem', 'CustomItem', 'CustomThemeButton', 'LoadingButton', 'BreadcrumbsItem'];
+var elementsIconProps = ['iconBefore', 'iconAfter', 'icon'];
+var rule = {
+  meta: {
+    fixable: 'code',
+    type: 'suggestion',
+    docs: {
+      url: 'http://go/adsc/icon/usage#accessibility-guidelines',
+      description: 'Enforces accessible usage of icon labels when composed with other Design System components.',
+      recommended: true
+    },
+    messages: {
+      unneededLabelPropContents: 'Label prop should be an empty string to prevent duplicate screen reader announcements. Learn more here: http://go/adsc/icon/usage#accessibility-guidelines.',
+      missingLabelProp: 'Missing label prop. If there is no supplementary text the label should describe what the icon is, else it should be an empty string. Learn more here: http://go/adsc/icon/usage#accessibility-guidelines.',
+      labelPropShouldHaveContents: 'Icon should have a meaningful label describing what the action is. Learn more here: http://go/adsc/icon/usage#accessibility-guidelines.'
+    }
+  },
+  create: function create(context) {
+    /**
+     * Contains a map of imported icon components from any atlaskit icon package.
+     */
+    var iconImports = {};
+    return {
+      ImportDeclaration: function ImportDeclaration(node) {
+        var moduleSource = node.source.value;
+
+        if (typeof moduleSource === 'string' && ['@atlaskit/icon/glyph/'].find(function (val) {
+          return moduleSource.startsWith(val);
+        }) && node.specifiers.length) {
+          var defaultImport = node.specifiers.find(function (spec) {
+            return spec.type === 'ImportDefaultSpecifier';
+          });
+
+          if (!defaultImport) {
+            return;
+          }
+
+          var defaultImportName = defaultImport.local.name;
+          iconImports[defaultImportName] = true;
+        }
+      },
+      JSXElement: function (_JSXElement) {
+        function JSXElement(_x) {
+          return _JSXElement.apply(this, arguments);
+        }
+
+        JSXElement.toString = function () {
+          return _JSXElement.toString();
+        };
+
+        return JSXElement;
+      }(function (node) {
+        if (node.openingElement.name.type !== 'JSXIdentifier') {
+          return;
+        }
+
+        var name = node.openingElement.name.name;
+
+        if (elements.includes(name)) {
+          // We've found a DS component that might use icons, let's check them.
+          var iconProps = node.openingElement.attributes.filter(function (attr) {
+            return attr.type === 'JSXAttribute' && attr.name.type === 'JSXIdentifier' && elementsIconProps.includes(attr.name.name);
+          });
+
+          if (iconProps.length) {
+            // This found element has icon props, and it has children. Let's make sure any icon usage has an empty string label.
+            iconProps.forEach(function (prop) {
+              var _prop$value;
+
+              if (prop.type !== 'JSXAttribute' || (prop === null || prop === void 0 ? void 0 : (_prop$value = prop.value) === null || _prop$value === void 0 ? void 0 : _prop$value.type) !== 'JSXExpressionContainer') {
+                return;
+              }
+
+              var hasOtherDefinedLabel = !!node.children.length || !!(0, _jsx.findProp)(node, 'aria-label');
+              var expression = prop.value.expression;
+
+              if (expression.type !== 'JSXElement' || expression.openingElement.name.type !== 'JSXIdentifier') {
+                return;
+              }
+
+              if (iconImports[expression.openingElement.name.name]) {
+                // We've found an icon from @atlaskit - let's get to work.
+                var labelProp = (0, _jsx.findProp)(expression, 'label');
+
+                if (labelProp && labelProp.value && labelProp.value.type === 'Literal') {
+                  var isEmptyStringLabel = labelProp.value.value === '';
+
+                  if (hasOtherDefinedLabel && !isEmptyStringLabel) {
+                    context.report({
+                      node: labelProp,
+                      messageId: 'unneededLabelPropContents',
+                      fix: function fix(fixer) {
+                        return fixer.replaceText(labelProp.value, '""');
+                      }
+                    });
+                  } else if (!hasOtherDefinedLabel && isEmptyStringLabel) {
+                    context.report({
+                      node: labelProp,
+                      messageId: 'labelPropShouldHaveContents'
+                    });
+                  }
+                }
+              }
+            });
+          }
+        }
+
+        if (iconImports[name]) {
+          // We've found an icon from @atlaskit - let's get to work.
+          var hasLabelProp = (0, _jsx.findProp)(node, 'label');
+
+          if (!hasLabelProp) {
+            context.report({
+              node: node.openingElement,
+              messageId: 'missingLabelProp'
+            });
+            return;
+          }
+        }
+      })
+    };
+  }
+};
+var _default = rule;
+exports.default = _default;

package/dist/cjs/rules/no-deprecated-imports/logo-paths.js

@@ -0,0 +1,61 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.namedLogoExports = exports.namedLogoConstantsExports = void 0;
+var namedLogoConstantsExports = [{
+  importName: 'DefaultProps',
+  message: 'DefaultProps has been renamed to defaultLogoParams.'
+}, {
+  importName: 'Props',
+  message: 'Props has been renamed to LogoProps.'
+}];
+exports.namedLogoConstantsExports = namedLogoConstantsExports;
+var namedLogoExports = [{
+  importName: 'StrideLogo',
+  message: 'StrideLogo is deprecated. Stride is no longer an Atlassian product.'
+}, {
+  importName: 'StrideIcon',
+  message: 'StrideIcon is deprecated. Stride is no longer an Atlassian product.'
+}, {
+  importName: 'StrideWordmark',
+  message: 'StrideWordmark is deprecated. Stride is no longer an Atlassian product.'
+}, {
+  importName: 'HipchatLogo',
+  message: 'HipchatLogo is deprecated. Hipchat is no longer an Atlassian product.'
+}, {
+  importName: 'HipchatIcon',
+  message: 'HipchatIcon is deprecated. Hipchat is no longer an Atlassian product.'
+}, {
+  importName: 'HipchatWordmark',
+  message: 'HipchatWordmark is deprecated. Hipchat is no longer an Atlassian product.'
+}, {
+  importName: 'JiraCoreLogo',
+  message: 'JiraCoreLogo is deprecated. Please use JiraWorkManagementLogo instead.'
+}, {
+  importName: 'JiraCoreIcon',
+  message: 'JiraCoreIcon is deprecated. Please use JiraWorkManagementIcon instead.'
+}, {
+  importName: 'JiraCoreWordmark',
+  message: 'JiraCoreWordmark is deprecated. Please use JiraWorkManagementWordmark instead.'
+}, {
+  importName: 'JiraServiceDeskLogo',
+  message: 'JiraServiceDeskLogo is deprecated. Please use JiraServiceManagementLogo instead.'
+}, {
+  importName: 'JiraServiceDeskIcon',
+  message: 'JiraServiceDeskIcon is deprecated. Please use JiraServiceManagementIcon instead.'
+}, {
+  importName: 'JiraServiceDeskWordmark',
+  message: 'JiraServiceDeskWordmark is deprecated. Please use JiraServiceManagementWordmark instead.'
+}, {
+  importName: 'OpsGenieLogo',
+  message: 'OpsGenieLogo was incorrectly spelled and has been marked deprecated. Please use OpsgenieLogo instead (no capital "g").'
+}, {
+  importName: 'OpsGenieIcon',
+  message: 'OpsGenieIcon was incorrectly spelled and has been marked deprecated. Please use OpsgenieIcon instead (no capital "g").'
+}, {
+  importName: 'OpsGenieWordmark',
+  message: 'OpsGenieWordmark was incorrectly spelled and is deprecated. Please use OpsgenieWordmark instead (no capital "g").'
+}];
+exports.namedLogoExports = namedLogoExports;

package/dist/cjs/rules/no-deprecated-imports/paths.js

@@ -4,6 +4,9 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.restrictedPaths = exports.namedThemeExports = void 0;
+
+var _logoPaths = require("./logo-paths");
+
 var namedThemeExports = [{
   importName: 'assistive',
   message: 'The assistive mixin is deprecated. Please use `@atlaskit/visually-hidden` instead.'
@@ -74,5 +77,11 @@ var restrictedPaths = [{
 }, {
   path: '@atlaskit/icon-priority',
   message: "icon-priority is deprecated due to limited usage in Cloud products. It will be deleted after 21 April 2022."
+}, {
+  path: '@atlaskit/logo/constants',
+  imports: _logoPaths.namedLogoConstantsExports
+}, {
+  path: '@atlaskit/logo',
+  imports: _logoPaths.namedLogoExports
 }];
 exports.restrictedPaths = restrictedPaths;

package/dist/cjs/rules/utils/jsx.js

@@ -0,0 +1,13 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.findProp = findProp;
+
+function findProp(jsx, propName) {
+  var labelProp = jsx.openingElement.attributes.find(function (attr) {
+    return attr.type === 'JSXAttribute' && attr.name.name === propName;
+  });
+  return labelProp;
+}

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "4.4.5",
+	"version": "4.6.0",
 	"sideEffects": false
 }

package/dist/es2019/index.js

@@ -1,4 +1,5 @@
 import ensureTokenUsage from './rules/ensure-design-token-usage';
+import iconLabel from './rules/icon-label';
 import noDeprecatedAPIs from './rules/no-deprecated-apis';
 import noDeprecatedUsage from './rules/no-deprecated-design-token-usage';
 import noDeprecatedImports from './rules/no-deprecated-imports';
@@ -6,19 +7,21 @@ import noUnsafeUsage from './rules/no-unsafe-design-token-usage';
 import useVisuallyHidden from './rules/use-visually-hidden';
 export const rules = {
   'ensure-design-token-usage': ensureTokenUsage,
-  'no-unsafe-design-token-usage': noUnsafeUsage,
+  'icon-label': iconLabel,
+  'no-deprecated-apis': noDeprecatedAPIs,
   'no-deprecated-design-token-usage': noDeprecatedUsage,
   'no-deprecated-imports': noDeprecatedImports,
-  'no-deprecated-apis': noDeprecatedAPIs,
+  'no-unsafe-design-token-usage': noUnsafeUsage,
   'use-visually-hidden': useVisuallyHidden
 };
 export const configs = {
   recommended: {
     plugins: ['@atlaskit/design-system'],
     rules: {
+      '@atlaskit/design-system/icon-label': 'warn',
+      '@atlaskit/design-system/no-deprecated-apis': 'warn',
       '@atlaskit/design-system/no-deprecated-imports': 'error',
-      '@atlaskit/design-system/use-visually-hidden': 'error',
-      '@atlaskit/design-system/no-deprecated-apis': 'warn'
+      '@atlaskit/design-system/use-visually-hidden': 'error'
     }
   }
 };

package/dist/es2019/rules/icon-label/index.js

@@ -0,0 +1,113 @@
+import { findProp } from '../utils/jsx';
+const elements = ['AkButton', 'AKButton', 'Button', 'MenuItem', 'ButtonItem', 'CustomItem', 'CustomThemeButton', 'LoadingButton', 'BreadcrumbsItem'];
+const elementsIconProps = ['iconBefore', 'iconAfter', 'icon'];
+const rule = {
+  meta: {
+    fixable: 'code',
+    type: 'suggestion',
+    docs: {
+      url: 'http://go/adsc/icon/usage#accessibility-guidelines',
+      description: 'Enforces accessible usage of icon labels when composed with other Design System components.',
+      recommended: true
+    },
+    messages: {
+      unneededLabelPropContents: 'Label prop should be an empty string to prevent duplicate screen reader announcements. Learn more here: http://go/adsc/icon/usage#accessibility-guidelines.',
+      missingLabelProp: 'Missing label prop. If there is no supplementary text the label should describe what the icon is, else it should be an empty string. Learn more here: http://go/adsc/icon/usage#accessibility-guidelines.',
+      labelPropShouldHaveContents: 'Icon should have a meaningful label describing what the action is. Learn more here: http://go/adsc/icon/usage#accessibility-guidelines.'
+    }
+  },
+
+  create(context) {
+    /**
+     * Contains a map of imported icon components from any atlaskit icon package.
+     */
+    const iconImports = {};
+    return {
+      ImportDeclaration(node) {
+        const moduleSource = node.source.value;
+
+        if (typeof moduleSource === 'string' && ['@atlaskit/icon/glyph/'].find(val => moduleSource.startsWith(val)) && node.specifiers.length) {
+          const defaultImport = node.specifiers.find(spec => spec.type === 'ImportDefaultSpecifier');
+
+          if (!defaultImport) {
+            return;
+          }
+
+          const defaultImportName = defaultImport.local.name;
+          iconImports[defaultImportName] = true;
+        }
+      },
+
+      JSXElement(node) {
+        if (node.openingElement.name.type !== 'JSXIdentifier') {
+          return;
+        }
+
+        const name = node.openingElement.name.name;
+
+        if (elements.includes(name)) {
+          // We've found a DS component that might use icons, let's check them.
+          const iconProps = node.openingElement.attributes.filter(attr => attr.type === 'JSXAttribute' && attr.name.type === 'JSXIdentifier' && elementsIconProps.includes(attr.name.name));
+
+          if (iconProps.length) {
+            // This found element has icon props, and it has children. Let's make sure any icon usage has an empty string label.
+            iconProps.forEach(prop => {
+              var _prop$value;
+
+              if (prop.type !== 'JSXAttribute' || (prop === null || prop === void 0 ? void 0 : (_prop$value = prop.value) === null || _prop$value === void 0 ? void 0 : _prop$value.type) !== 'JSXExpressionContainer') {
+                return;
+              }
+
+              const hasOtherDefinedLabel = !!node.children.length || !!findProp(node, 'aria-label');
+              const expression = prop.value.expression;
+
+              if (expression.type !== 'JSXElement' || expression.openingElement.name.type !== 'JSXIdentifier') {
+                return;
+              }
+
+              if (iconImports[expression.openingElement.name.name]) {
+                // We've found an icon from @atlaskit - let's get to work.
+                const labelProp = findProp(expression, 'label');
+
+                if (labelProp && labelProp.value && labelProp.value.type === 'Literal') {
+                  const isEmptyStringLabel = labelProp.value.value === '';
+
+                  if (hasOtherDefinedLabel && !isEmptyStringLabel) {
+                    context.report({
+                      node: labelProp,
+                      messageId: 'unneededLabelPropContents',
+                      fix: fixer => {
+                        return fixer.replaceText(labelProp.value, '""');
+                      }
+                    });
+                  } else if (!hasOtherDefinedLabel && isEmptyStringLabel) {
+                    context.report({
+                      node: labelProp,
+                      messageId: 'labelPropShouldHaveContents'
+                    });
+                  }
+                }
+              }
+            });
+          }
+        }
+
+        if (iconImports[name]) {
+          // We've found an icon from @atlaskit - let's get to work.
+          const hasLabelProp = findProp(node, 'label');
+
+          if (!hasLabelProp) {
+            context.report({
+              node: node.openingElement,
+              messageId: 'missingLabelProp'
+            });
+            return;
+          }
+        }
+      }
+
+    };
+  }
+
+};
+export default rule;

package/dist/es2019/rules/no-deprecated-imports/logo-paths.js

@@ -0,0 +1,53 @@
+export const namedLogoConstantsExports = [{
+  importName: 'DefaultProps',
+  message: 'DefaultProps has been renamed to defaultLogoParams.'
+}, {
+  importName: 'Props',
+  message: 'Props has been renamed to LogoProps.'
+}];
+export const namedLogoExports = [{
+  importName: 'StrideLogo',
+  message: 'StrideLogo is deprecated. Stride is no longer an Atlassian product.'
+}, {
+  importName: 'StrideIcon',
+  message: 'StrideIcon is deprecated. Stride is no longer an Atlassian product.'
+}, {
+  importName: 'StrideWordmark',
+  message: 'StrideWordmark is deprecated. Stride is no longer an Atlassian product.'
+}, {
+  importName: 'HipchatLogo',
+  message: 'HipchatLogo is deprecated. Hipchat is no longer an Atlassian product.'
+}, {
+  importName: 'HipchatIcon',
+  message: 'HipchatIcon is deprecated. Hipchat is no longer an Atlassian product.'
+}, {
+  importName: 'HipchatWordmark',
+  message: 'HipchatWordmark is deprecated. Hipchat is no longer an Atlassian product.'
+}, {
+  importName: 'JiraCoreLogo',
+  message: 'JiraCoreLogo is deprecated. Please use JiraWorkManagementLogo instead.'
+}, {
+  importName: 'JiraCoreIcon',
+  message: 'JiraCoreIcon is deprecated. Please use JiraWorkManagementIcon instead.'
+}, {
+  importName: 'JiraCoreWordmark',
+  message: 'JiraCoreWordmark is deprecated. Please use JiraWorkManagementWordmark instead.'
+}, {
+  importName: 'JiraServiceDeskLogo',
+  message: 'JiraServiceDeskLogo is deprecated. Please use JiraServiceManagementLogo instead.'
+}, {
+  importName: 'JiraServiceDeskIcon',
+  message: 'JiraServiceDeskIcon is deprecated. Please use JiraServiceManagementIcon instead.'
+}, {
+  importName: 'JiraServiceDeskWordmark',
+  message: 'JiraServiceDeskWordmark is deprecated. Please use JiraServiceManagementWordmark instead.'
+}, {
+  importName: 'OpsGenieLogo',
+  message: 'OpsGenieLogo was incorrectly spelled and has been marked deprecated. Please use OpsgenieLogo instead (no capital "g").'
+}, {
+  importName: 'OpsGenieIcon',
+  message: 'OpsGenieIcon was incorrectly spelled and has been marked deprecated. Please use OpsgenieIcon instead (no capital "g").'
+}, {
+  importName: 'OpsGenieWordmark',
+  message: 'OpsGenieWordmark was incorrectly spelled and is deprecated. Please use OpsgenieWordmark instead (no capital "g").'
+}];

package/dist/es2019/rules/no-deprecated-imports/paths.js

@@ -1,3 +1,4 @@
+import { namedLogoConstantsExports, namedLogoExports } from './logo-paths';
 export const namedThemeExports = [{
   importName: 'assistive',
   message: 'The assistive mixin is deprecated. Please use `@atlaskit/visually-hidden` instead.'
@@ -67,4 +68,10 @@ export const restrictedPaths = [{
 }, {
   path: '@atlaskit/icon-priority',
   message: `icon-priority is deprecated due to limited usage in Cloud products. It will be deleted after 21 April 2022.`
+}, {
+  path: '@atlaskit/logo/constants',
+  imports: namedLogoConstantsExports
+}, {
+  path: '@atlaskit/logo',
+  imports: namedLogoExports
 }];

package/dist/es2019/rules/utils/jsx.js

@@ -0,0 +1,4 @@
+export function findProp(jsx, propName) {
+  const labelProp = jsx.openingElement.attributes.find(attr => attr.type === 'JSXAttribute' && attr.name.name === propName);
+  return labelProp;
+}

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "4.4.5",
+	"version": "4.6.0",
 	"sideEffects": false
 }

package/dist/esm/index.js

@@ -1,4 +1,5 @@
 import ensureTokenUsage from './rules/ensure-design-token-usage';
+import iconLabel from './rules/icon-label';
 import noDeprecatedAPIs from './rules/no-deprecated-apis';
 import noDeprecatedUsage from './rules/no-deprecated-design-token-usage';
 import noDeprecatedImports from './rules/no-deprecated-imports';
@@ -6,19 +7,21 @@ import noUnsafeUsage from './rules/no-unsafe-design-token-usage';
 import useVisuallyHidden from './rules/use-visually-hidden';
 export var rules = {
   'ensure-design-token-usage': ensureTokenUsage,
-  'no-unsafe-design-token-usage': noUnsafeUsage,
+  'icon-label': iconLabel,
+  'no-deprecated-apis': noDeprecatedAPIs,
   'no-deprecated-design-token-usage': noDeprecatedUsage,
   'no-deprecated-imports': noDeprecatedImports,
-  'no-deprecated-apis': noDeprecatedAPIs,
+  'no-unsafe-design-token-usage': noUnsafeUsage,
   'use-visually-hidden': useVisuallyHidden
 };
 export var configs = {
   recommended: {
     plugins: ['@atlaskit/design-system'],
     rules: {
+      '@atlaskit/design-system/icon-label': 'warn',
+      '@atlaskit/design-system/no-deprecated-apis': 'warn',
       '@atlaskit/design-system/no-deprecated-imports': 'error',
-      '@atlaskit/design-system/use-visually-hidden': 'error',
-      '@atlaskit/design-system/no-deprecated-apis': 'warn'
+      '@atlaskit/design-system/use-visually-hidden': 'error'
     }
   }
 };

package/dist/esm/rules/icon-label/index.js

@@ -0,0 +1,125 @@
+import { findProp } from '../utils/jsx';
+var elements = ['AkButton', 'AKButton', 'Button', 'MenuItem', 'ButtonItem', 'CustomItem', 'CustomThemeButton', 'LoadingButton', 'BreadcrumbsItem'];
+var elementsIconProps = ['iconBefore', 'iconAfter', 'icon'];
+var rule = {
+  meta: {
+    fixable: 'code',
+    type: 'suggestion',
+    docs: {
+      url: 'http://go/adsc/icon/usage#accessibility-guidelines',
+      description: 'Enforces accessible usage of icon labels when composed with other Design System components.',
+      recommended: true
+    },
+    messages: {
+      unneededLabelPropContents: 'Label prop should be an empty string to prevent duplicate screen reader announcements. Learn more here: http://go/adsc/icon/usage#accessibility-guidelines.',
+      missingLabelProp: 'Missing label prop. If there is no supplementary text the label should describe what the icon is, else it should be an empty string. Learn more here: http://go/adsc/icon/usage#accessibility-guidelines.',
+      labelPropShouldHaveContents: 'Icon should have a meaningful label describing what the action is. Learn more here: http://go/adsc/icon/usage#accessibility-guidelines.'
+    }
+  },
+  create: function create(context) {
+    /**
+     * Contains a map of imported icon components from any atlaskit icon package.
+     */
+    var iconImports = {};
+    return {
+      ImportDeclaration: function ImportDeclaration(node) {
+        var moduleSource = node.source.value;
+
+        if (typeof moduleSource === 'string' && ['@atlaskit/icon/glyph/'].find(function (val) {
+          return moduleSource.startsWith(val);
+        }) && node.specifiers.length) {
+          var defaultImport = node.specifiers.find(function (spec) {
+            return spec.type === 'ImportDefaultSpecifier';
+          });
+
+          if (!defaultImport) {
+            return;
+          }
+
+          var defaultImportName = defaultImport.local.name;
+          iconImports[defaultImportName] = true;
+        }
+      },
+      JSXElement: function (_JSXElement) {
+        function JSXElement(_x) {
+          return _JSXElement.apply(this, arguments);
+        }
+
+        JSXElement.toString = function () {
+          return _JSXElement.toString();
+        };
+
+        return JSXElement;
+      }(function (node) {
+        if (node.openingElement.name.type !== 'JSXIdentifier') {
+          return;
+        }
+
+        var name = node.openingElement.name.name;
+
+        if (elements.includes(name)) {
+          // We've found a DS component that might use icons, let's check them.
+          var iconProps = node.openingElement.attributes.filter(function (attr) {
+            return attr.type === 'JSXAttribute' && attr.name.type === 'JSXIdentifier' && elementsIconProps.includes(attr.name.name);
+          });
+
+          if (iconProps.length) {
+            // This found element has icon props, and it has children. Let's make sure any icon usage has an empty string label.
+            iconProps.forEach(function (prop) {
+              var _prop$value;
+
+              if (prop.type !== 'JSXAttribute' || (prop === null || prop === void 0 ? void 0 : (_prop$value = prop.value) === null || _prop$value === void 0 ? void 0 : _prop$value.type) !== 'JSXExpressionContainer') {
+                return;
+              }
+
+              var hasOtherDefinedLabel = !!node.children.length || !!findProp(node, 'aria-label');
+              var expression = prop.value.expression;
+
+              if (expression.type !== 'JSXElement' || expression.openingElement.name.type !== 'JSXIdentifier') {
+                return;
+              }
+
+              if (iconImports[expression.openingElement.name.name]) {
+                // We've found an icon from @atlaskit - let's get to work.
+                var labelProp = findProp(expression, 'label');
+
+                if (labelProp && labelProp.value && labelProp.value.type === 'Literal') {
+                  var isEmptyStringLabel = labelProp.value.value === '';
+
+                  if (hasOtherDefinedLabel && !isEmptyStringLabel) {
+                    context.report({
+                      node: labelProp,
+                      messageId: 'unneededLabelPropContents',
+                      fix: function fix(fixer) {
+                        return fixer.replaceText(labelProp.value, '""');
+                      }
+                    });
+                  } else if (!hasOtherDefinedLabel && isEmptyStringLabel) {
+                    context.report({
+                      node: labelProp,
+                      messageId: 'labelPropShouldHaveContents'
+                    });
+                  }
+                }
+              }
+            });
+          }
+        }
+
+        if (iconImports[name]) {
+          // We've found an icon from @atlaskit - let's get to work.
+          var hasLabelProp = findProp(node, 'label');
+
+          if (!hasLabelProp) {
+            context.report({
+              node: node.openingElement,
+              messageId: 'missingLabelProp'
+            });
+            return;
+          }
+        }
+      })
+    };
+  }
+};
+export default rule;

package/dist/esm/rules/no-deprecated-imports/logo-paths.js

@@ -0,0 +1,53 @@
+export var namedLogoConstantsExports = [{
+  importName: 'DefaultProps',
+  message: 'DefaultProps has been renamed to defaultLogoParams.'
+}, {
+  importName: 'Props',
+  message: 'Props has been renamed to LogoProps.'
+}];
+export var namedLogoExports = [{
+  importName: 'StrideLogo',
+  message: 'StrideLogo is deprecated. Stride is no longer an Atlassian product.'
+}, {
+  importName: 'StrideIcon',
+  message: 'StrideIcon is deprecated. Stride is no longer an Atlassian product.'
+}, {
+  importName: 'StrideWordmark',
+  message: 'StrideWordmark is deprecated. Stride is no longer an Atlassian product.'
+}, {
+  importName: 'HipchatLogo',
+  message: 'HipchatLogo is deprecated. Hipchat is no longer an Atlassian product.'
+}, {
+  importName: 'HipchatIcon',
+  message: 'HipchatIcon is deprecated. Hipchat is no longer an Atlassian product.'
+}, {
+  importName: 'HipchatWordmark',
+  message: 'HipchatWordmark is deprecated. Hipchat is no longer an Atlassian product.'
+}, {
+  importName: 'JiraCoreLogo',
+  message: 'JiraCoreLogo is deprecated. Please use JiraWorkManagementLogo instead.'
+}, {
+  importName: 'JiraCoreIcon',
+  message: 'JiraCoreIcon is deprecated. Please use JiraWorkManagementIcon instead.'
+}, {
+  importName: 'JiraCoreWordmark',
+  message: 'JiraCoreWordmark is deprecated. Please use JiraWorkManagementWordmark instead.'
+}, {
+  importName: 'JiraServiceDeskLogo',
+  message: 'JiraServiceDeskLogo is deprecated. Please use JiraServiceManagementLogo instead.'
+}, {
+  importName: 'JiraServiceDeskIcon',
+  message: 'JiraServiceDeskIcon is deprecated. Please use JiraServiceManagementIcon instead.'
+}, {
+  importName: 'JiraServiceDeskWordmark',
+  message: 'JiraServiceDeskWordmark is deprecated. Please use JiraServiceManagementWordmark instead.'
+}, {
+  importName: 'OpsGenieLogo',
+  message: 'OpsGenieLogo was incorrectly spelled and has been marked deprecated. Please use OpsgenieLogo instead (no capital "g").'
+}, {
+  importName: 'OpsGenieIcon',
+  message: 'OpsGenieIcon was incorrectly spelled and has been marked deprecated. Please use OpsgenieIcon instead (no capital "g").'
+}, {
+  importName: 'OpsGenieWordmark',
+  message: 'OpsGenieWordmark was incorrectly spelled and is deprecated. Please use OpsgenieWordmark instead (no capital "g").'
+}];

package/dist/esm/rules/no-deprecated-imports/paths.js

@@ -1,3 +1,4 @@
+import { namedLogoConstantsExports, namedLogoExports } from './logo-paths';
 export var namedThemeExports = [{
   importName: 'assistive',
   message: 'The assistive mixin is deprecated. Please use `@atlaskit/visually-hidden` instead.'
@@ -67,4 +68,10 @@ export var restrictedPaths = [{
 }, {
   path: '@atlaskit/icon-priority',
   message: "icon-priority is deprecated due to limited usage in Cloud products. It will be deleted after 21 April 2022."
+}, {
+  path: '@atlaskit/logo/constants',
+  imports: namedLogoConstantsExports
+}, {
+  path: '@atlaskit/logo',
+  imports: namedLogoExports
 }];

package/dist/esm/rules/utils/jsx.js

@@ -0,0 +1,6 @@
+export function findProp(jsx, propName) {
+  var labelProp = jsx.openingElement.attributes.find(function (attr) {
+    return attr.type === 'JSXAttribute' && attr.name.name === propName;
+  });
+  return labelProp;
+}

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "4.4.5",
+	"version": "4.6.0",
 	"sideEffects": false
 }

package/dist/types/index.d.ts

@@ -1,18 +1,20 @@
 export declare const rules: {
     'ensure-design-token-usage': import("eslint").Rule.RuleModule;
-    'no-unsafe-design-token-usage': import("eslint").Rule.RuleModule;
+    'icon-label': import("eslint").Rule.RuleModule;
+    'no-deprecated-apis': import("eslint").Rule.RuleModule;
     'no-deprecated-design-token-usage': import("eslint").Rule.RuleModule;
     'no-deprecated-imports': import("eslint").Rule.RuleModule;
-    'no-deprecated-apis': import("eslint").Rule.RuleModule;
+    'no-unsafe-design-token-usage': import("eslint").Rule.RuleModule;
     'use-visually-hidden': import("eslint").Rule.RuleModule;
 };
 export declare const configs: {
     recommended: {
         plugins: string[];
         rules: {
+            '@atlaskit/design-system/icon-label': string;
+            '@atlaskit/design-system/no-deprecated-apis': string;
             '@atlaskit/design-system/no-deprecated-imports': string;
             '@atlaskit/design-system/use-visually-hidden': string;
-            '@atlaskit/design-system/no-deprecated-apis': string;
         };
     };
 };

package/dist/types/rules/icon-label/index.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/types/rules/no-deprecated-imports/logo-paths.d.ts

@@ -0,0 +1,8 @@
+export declare const namedLogoConstantsExports: {
+    importName: string;
+    message: string;
+}[];
+export declare const namedLogoExports: {
+    importName: string;
+    message: string;
+}[];

package/dist/types/rules/no-deprecated-imports/paths.d.ts

@@ -59,4 +59,16 @@ export declare const restrictedPaths: readonly [{
 }, {
     readonly path: "@atlaskit/icon-priority";
     readonly message: "icon-priority is deprecated due to limited usage in Cloud products. It will be deleted after 21 April 2022.";
+}, {
+    readonly path: "@atlaskit/logo/constants";
+    readonly imports: {
+        importName: string;
+        message: string;
+    }[];
+}, {
+    readonly path: "@atlaskit/logo";
+    readonly imports: {
+        importName: string;
+        message: string;
+    }[];
 }];

package/dist/types/rules/utils/jsx.d.ts

@@ -0,0 +1,2 @@
+import type { JSXAttribute, JSXElement } from 'eslint-codemod-utils';
+export declare function findProp(jsx: JSXElement, propName: string): JSXAttribute | undefined;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-design-system",
   "description": "The essential plugin for use with the Atlassian Design System.",
-  "version": "4.4.5",
+  "version": "4.6.0",
   "author": "Atlassian Pty Ltd",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -15,7 +15,7 @@
       "draft": true
     }
   },
-  "repository": "https://bitbucket.org/atlassian/atlassian-frontend",
+  "repository": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",
   "module:es2019": "dist/es2019/index.js",
@@ -26,7 +26,7 @@
     ".": "./src/index.tsx"
   },
   "dependencies": {
-    "@atlaskit/tokens": "^0.9.0",
+    "@atlaskit/tokens": "^0.10.0",
     "@babel/runtime": "^7.0.0",
     "eslint-codemod-utils": "^1.3.2"
   },