@atlaskit/eslint-plugin-design-system 4.13.7 → 4.13.9

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 4.13.9
+
+### Patch Changes
+
+- Updated dependencies
+
+## 4.13.8
+
+### Patch Changes
+
+- [`f4c5d7db7aa`](https://bitbucket.org/atlassian/atlassian-frontend/commits/f4c5d7db7aa) - Updates fix for `ensure-design-token-usage-spacing` to ensure fixes are not applied erroneously.
+
 ## 4.13.7
 
 ### Patch Changes

package/dist/cjs/rules/ensure-design-token-usage-spacing/index.js

@@ -110,7 +110,7 @@ var rule = {
 
           return node.key.name === 'fontSize';
         });
-        var fontSizeValue = (0, _utils.getValue)( // @ts-ignore
+        var fontSizeValue = (0, _utils.getValue)( // @ts-expect-error
         (0, _eslintCodemodUtils.isNodeOfType)(fontSizeNode, 'Property') && fontSizeNode.value, context);
         var fontSize = Array.isArray(fontSizeValue) ? fontSizeValue[0] : fontSizeValue;
 
@@ -337,9 +337,15 @@ var rule = {
 
                 var textForSource = context.getSourceCode().getText(node.quasi); // find `<property>: ...;` in original
 
-                var searchRegExp = new RegExp("".concat(rawProperty, ".+?;"), 'g'); // replace property:val with new property:val
+                var searchRegExp = new RegExp(style, 'g'); // replace property:val with new property:val
+
+                var replacement = textForSource.replace(searchRegExp, //  padding: ${gridSize()}px;
+                "".concat(rawProperty, ": ").concat(replacementValue));
+
+                if (!replacement) {
+                  return [];
+                }
 
-                var replacement = textForSource.replace(searchRegExp, "".concat(rawProperty, ": ").concat(replacementValue, ";"));
                 return [fixer.insertTextBefore(parentNode, "// TODO Delete this comment after verifying spacing token -> previous value `".concat(value.trim(), "`\n")), fixer.replaceText(node.quasi, replacement)];
               } : undefined
             });

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "4.13.7",
+	"version": "4.13.9",
 	"sideEffects": false
 }

package/dist/es2019/rules/ensure-design-token-usage-spacing/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable @atlassian/tangerine/import/entry-points */
 import { callExpression, identifier, isNodeOfType, literal, node as nodeFn, property } from 'eslint-codemod-utils';
 import spacingScale from '@atlaskit/tokens/spacing-raw';
 import typographyTokens from '@atlaskit/tokens/typography-raw';
@@ -81,7 +82,7 @@ const rule = {
 
           return node.key.name === 'fontSize';
         });
-        const fontSizeValue = getValue( // @ts-ignore
+        const fontSizeValue = getValue( // @ts-expect-error
         isNodeOfType(fontSizeNode, 'Property') && fontSizeNode.value, context);
         const fontSize = Array.isArray(fontSizeValue) ? fontSizeValue[0] : fontSizeValue;
 
@@ -290,9 +291,15 @@ const rule = {
 
                 const textForSource = context.getSourceCode().getText(node.quasi); // find `<property>: ...;` in original
 
-                const searchRegExp = new RegExp(`${rawProperty}.+?;`, 'g'); // replace property:val with new property:val
+                const searchRegExp = new RegExp(style, 'g'); // replace property:val with new property:val
+
+                const replacement = textForSource.replace(searchRegExp, //  padding: ${gridSize()}px;
+                `${rawProperty}: ${replacementValue}`);
+
+                if (!replacement) {
+                  return [];
+                }
 
-                const replacement = textForSource.replace(searchRegExp, `${rawProperty}: ${replacementValue};`);
                 return [fixer.insertTextBefore(parentNode, `// TODO Delete this comment after verifying spacing token -> previous value \`${value.trim()}\`\n`), fixer.replaceText(node.quasi, replacement)];
               } : undefined
             });

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "4.13.7",
+	"version": "4.13.9",
 	"sideEffects": false
 }

package/dist/esm/rules/ensure-design-token-usage-spacing/index.js

@@ -5,6 +5,7 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (O
 
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
 
+/* eslint-disable @atlassian/tangerine/import/entry-points */
 import { callExpression, identifier, isNodeOfType, literal, node as nodeFn, property } from 'eslint-codemod-utils';
 import spacingScale from '@atlaskit/tokens/spacing-raw';
 import typographyTokens from '@atlaskit/tokens/typography-raw';
@@ -95,7 +96,7 @@ var rule = {
 
           return node.key.name === 'fontSize';
         });
-        var fontSizeValue = getValue( // @ts-ignore
+        var fontSizeValue = getValue( // @ts-expect-error
         isNodeOfType(fontSizeNode, 'Property') && fontSizeNode.value, context);
         var fontSize = Array.isArray(fontSizeValue) ? fontSizeValue[0] : fontSizeValue;
 
@@ -322,9 +323,15 @@ var rule = {
 
                 var textForSource = context.getSourceCode().getText(node.quasi); // find `<property>: ...;` in original
 
-                var searchRegExp = new RegExp("".concat(rawProperty, ".+?;"), 'g'); // replace property:val with new property:val
+                var searchRegExp = new RegExp(style, 'g'); // replace property:val with new property:val
+
+                var replacement = textForSource.replace(searchRegExp, //  padding: ${gridSize()}px;
+                "".concat(rawProperty, ": ").concat(replacementValue));
+
+                if (!replacement) {
+                  return [];
+                }
 
-                var replacement = textForSource.replace(searchRegExp, "".concat(rawProperty, ": ").concat(replacementValue, ";"));
                 return [fixer.insertTextBefore(parentNode, "// TODO Delete this comment after verifying spacing token -> previous value `".concat(value.trim(), "`\n")), fixer.replaceText(node.quasi, replacement)];
               } : undefined
             });

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "4.13.7",
+	"version": "4.13.9",
 	"sideEffects": false
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-design-system",
   "description": "The essential plugin for use with the Atlassian Design System.",
-  "version": "4.13.7",
+  "version": "4.13.9",
   "author": "Atlassian Pty Ltd",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -33,7 +33,7 @@
     ".": "./src/index.tsx"
   },
   "dependencies": {
-    "@atlaskit/tokens": "^0.11.0",
+    "@atlaskit/tokens": "^0.12.0",
     "@babel/runtime": "^7.0.0",
     "eslint-codemod-utils": "^1.5.0"
   },

package/report.api.md

@@ -1,12 +1,17 @@
+<!-- API Report Version: 2.2 -->
+
 ## API Report File for "@atlaskit/eslint-plugin-design-system"
 
-> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
+> Do not edit this file. This report is auto-generated using [API Extractor](https://api-extractor.com/).
+> [Learn more about API reports](https://hello.atlassian.net/wiki/spaces/UR/pages/1825484529/Package+API+Reports)
+
+### Table of contents
 
-<!--
-	Generated API Report version: 2.0
--->
+- [Main Entry Types](#main-entry-types)
 
-[Learn more about API reports](https://hello.atlassian.net/wiki/spaces/UR/pages/1825484529/Package+API+Reports)
+### Main Entry Types
+
+<!--SECTION START: Main Entry Types-->
 
 ```ts
 import { Rule } from 'eslint';
@@ -32,7 +37,8 @@ export const configs: {
       '@atlaskit/design-system/use-visually-hidden': string;
       '@atlaskit/design-system/ensure-design-token-usage': string;
       '@atlaskit/design-system/no-banned-imports': string;
-      '@atlaskit/design-system/no-raw-spacing-values': string;
+      '@atlaskit/design-system/no-unsafe-design-token-usage': string;
+      '@atlaskit/design-system/ensure-design-token-usage-spacing': string;
     };
   };
 };
@@ -47,8 +53,10 @@ export const rules: {
   'no-banned-imports': Rule.RuleModule;
   'no-unsafe-design-token-usage': Rule.RuleModule;
   'use-visually-hidden': Rule.RuleModule;
-  'no-raw-spacing-values': Rule.RuleModule;
+  'ensure-design-token-usage-spacing': Rule.RuleModule;
 };
 
 // (No @packageDocumentation comment for this package)
 ```
+
+<!--SECTION END: Main Entry Types-->