@atlaskit/eslint-plugin-design-system 4.10.0 → 4.10.1

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 4.10.1
+
+### Patch Changes
+
+- [`d76851b2f42`](https://bitbucket.org/atlassian/atlassian-frontend/commits/d76851b2f42) - Improved NaN handling and output
+- [`0544fe823d1`](https://bitbucket.org/atlassian/atlassian-frontend/commits/0544fe823d1) - Updates to account for nested unary selectors.
+- [`1ed3db0c9be`](https://bitbucket.org/atlassian/atlassian-frontend/commits/1ed3db0c9be) - Improvements to lint rule and accounting for edge cases
+
 ## 4.10.0
 
 ### Minor Changes

package/dist/cjs/rules/no-raw-spacing-values/index.js

@@ -13,6 +13,12 @@ var _eslintCodemodUtils = require("eslint-codemod-utils");
 
 var _utils = require("./utils");
 
+function _createForOfIteratorHelper(o, allowArrayLike) { var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; if (!it) { if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = it.call(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it.return != null) it.return(); } finally { if (didErr) throw err; } } }; }
+
+function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
+
+function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }
+
 var rule = {
   meta: {
     type: 'problem',
@@ -33,7 +39,7 @@ var rule = {
           return;
         }
         /**
-         * We do this in case we the fontSize for a style object is declared alongside the `em` or `lineHeight` declaration
+         * We do this in case the fontSize for a style object is declared alongside the `em` or `lineHeight` declaration
          */
 
 
@@ -64,26 +70,36 @@ var rule = {
             return;
           }
 
+          if (node.value.type === 'Literal' && !(0, _utils.isValidSpacingValue)(node.value.value, fontSize)) {
+            context.report({
+              node: node,
+              messageId: 'noRawSpacingValues',
+              data: {
+                payload: "NaN:".concat(node.value.value)
+              }
+            });
+            return;
+          }
+
           var value = (0, _utils.getValue)(node.value, context);
 
-          if (value) {
+          if (value && (0, _utils.isValidSpacingValue)(value, fontSize)) {
             var values = typeof value === 'number' || typeof value === 'string' ? [value] : value;
-            values.forEach(function (value) {
+            values.forEach(function (val) {
               context.report({
                 node: node,
                 messageId: 'noRawSpacingValues',
                 data: {
-                  payload: "".concat(node.key.name, ":").concat((0, _utils.emToPixels)(value, fontSize))
+                  payload: "".concat(node.key.name, ":").concat((0, _utils.emToPixels)(val, fontSize))
                 }
               });
             });
-            return;
           } else {
             context.report({
               node: node,
               messageId: 'noRawSpacingValues',
               data: {
-                payload: "".concat(node.key.name, ":NaN")
+                payload: "NaN:".concat(value)
               }
             });
           }
@@ -106,7 +122,9 @@ var rule = {
          * Adapted from ensure-design-token-usage
          */
 
-        var cssProperties = combinedString.replace(/\n/g, '').split(/;|{|}/).map(function (el) {
+        var cssProperties = combinedString.split('\n').filter(function (line) {
+          return !line.trim().startsWith('@');
+        }).join('\n').replace(/\n/g, '').split(/;|{|}/).map(function (el) {
           return el.trim() || '';
         });
         cssProperties.map(function (style) {
@@ -115,14 +133,41 @@ var rule = {
               property = _style$split2[0],
               value = _style$split2[1];
 
+          property = (0, _utils.convertHyphenatedNameToCamelCase)(property);
+
           if ((0, _utils.isSpacingProperty)(property)) {
-            context.report({
-              node: node,
-              messageId: 'noRawSpacingValues',
-              data: {
-                payload: "".concat(property, ":").concat((0, _utils.removePixelSuffix)(value.trim()))
+            if ((0, _utils.isValidSpacingValue)(value)) {
+              var values = (0, _utils.getValueFromShorthand)(value);
+
+              var _iterator = _createForOfIteratorHelper(values),
+                  _step;
+
+              try {
+                for (_iterator.s(); !(_step = _iterator.n()).done;) {
+                  var val = _step.value;
+                  // could be array of values e.g. padding: 8px 12px 3px
+                  context.report({
+                    node: node,
+                    messageId: 'noRawSpacingValues',
+                    data: {
+                      payload: "".concat(property, ":").concat(val)
+                    }
+                  });
+                }
+              } catch (err) {
+                _iterator.e(err);
+              } finally {
+                _iterator.f();
               }
-            });
+            } else {
+              context.report({
+                node: node,
+                messageId: 'noRawSpacingValues',
+                data: {
+                  payload: "NaN:".concat(value)
+                }
+              });
+            }
           }
 
           return;

package/dist/cjs/rules/no-raw-spacing-values/utils.js

@@ -3,13 +3,13 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.emToPixels = void 0;
+exports.emToPixels = exports.convertHyphenatedNameToCamelCase = void 0;
 exports.findIdentifierInParentScope = findIdentifierInParentScope;
-exports.removePixelSuffix = exports.isSpacingProperty = exports.getValueFromShorthand = exports.getValue = void 0;
+exports.removePixelSuffix = exports.isValidSpacingValue = exports.isSpacingProperty = exports.getValueFromShorthand = exports.getValue = void 0;
 
 var _eslintCodemodUtils = require("eslint-codemod-utils");
 
-var properties = ['padding', 'paddingLeft', 'paddingTop', 'paddingRight', 'paddingBottom', 'marginLeft', 'marginTop', 'marginRight', 'marginBottom', 'margin', 'gap', 'fontSize', 'lineHeight', 'width', 'height'];
+var properties = ['padding', 'paddingLeft', 'paddingTop', 'paddingRight', 'paddingBottom', 'marginLeft', 'marginTop', 'marginRight', 'marginBottom', 'margin', 'gap', 'fontSize', 'lineHeight', 'width', 'height', 'rowGap', 'gridRowGap', 'columnGap', 'gridColumnGap'];
 
 function findIdentifierInParentScope(_ref) {
   var scope = _ref.scope,
@@ -123,6 +123,10 @@ var getValueFromIdentifier = function getValueFromIdentifier(node, context) {
 
   var definition = variable.defs[0];
 
+  if ((0, _eslintCodemodUtils.isNodeOfType)(definition.node, 'ImportSpecifier') && (0, _eslintCodemodUtils.isNodeOfType)(definition.node.parent, 'ImportDeclaration') && definition.node.parent.source.value === '@atlassian/jira-common-legacy-do-not-add-anything-new/src/styles') {
+    return definition.node.imported.name === 'gridSize' ? 8 : null;
+  }
+
   if (!(0, _eslintCodemodUtils.isNodeOfType)(definition.node, 'VariableDeclarator')) {
     return null;
   }
@@ -146,7 +150,7 @@ var getValueFromUnaryExpression = function getValueFromUnaryExpression(node, con
   } // eslint-disable-next-line no-eval
 
 
-  return eval("".concat(node.operator).concat(value));
+  return eval("".concat(node.operator, "(").concat(value, ")"));
 };
 /**
  * @example
@@ -198,9 +202,9 @@ var emToPixels = function emToPixels(value, fontSize) {
 
     if (match && typeof fontSize === 'number') {
       return Number(match[1]) * fontSize;
+    } else {
+      return null;
     }
-
-    return 'NaN';
   }
 
   return value;
@@ -220,4 +224,37 @@ var removePixelSuffix = function removePixelSuffix(value) {
   return Number(isString ? value.replace('px', '') : value);
 };
 
-exports.removePixelSuffix = removePixelSuffix;
+exports.removePixelSuffix = removePixelSuffix;
+var invalidSpacingUnitRegex = /(%$)|(\d+rem$)|(^calc)|(vw$)|(vh$)/;
+
+var isValidSpacingValue = function isValidSpacingValue(value, fontSize) {
+  if (typeof value === 'string') {
+    if (invalidSpacingUnitRegex.test(value)) {
+      return false;
+    }
+  } else if (Array.isArray(value)) {
+    // could be array due to shorthand
+    for (var val in value) {
+      if (invalidSpacingUnitRegex.test(val)) {
+        return false;
+      }
+    }
+  }
+
+  if (emRegex.test(value) && typeof fontSize !== 'number') {
+    return false;
+  }
+
+  return true;
+}; // convert line-height to lineHeight
+
+
+exports.isValidSpacingValue = isValidSpacingValue;
+
+var convertHyphenatedNameToCamelCase = function convertHyphenatedNameToCamelCase(prop) {
+  return prop.replace(/-./g, function (m) {
+    return m[1].toUpperCase();
+  });
+};
+
+exports.convertHyphenatedNameToCamelCase = convertHyphenatedNameToCamelCase;

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "4.10.0",
+	"version": "4.10.1",
 	"sideEffects": false
 }

package/dist/es2019/rules/no-raw-spacing-values/index.js

@@ -1,5 +1,5 @@
 import { isNodeOfType } from 'eslint-codemod-utils';
-import { emToPixels, getValue, isSpacingProperty, removePixelSuffix } from './utils';
+import { convertHyphenatedNameToCamelCase, emToPixels, getValue, getValueFromShorthand, isSpacingProperty, isValidSpacingValue } from './utils';
 const rule = {
   meta: {
     type: 'problem',
@@ -21,7 +21,7 @@ const rule = {
           return;
         }
         /**
-         * We do this in case we the fontSize for a style object is declared alongside the `em` or `lineHeight` declaration
+         * We do this in case the fontSize for a style object is declared alongside the `em` or `lineHeight` declaration
          */
 
 
@@ -52,26 +52,36 @@ const rule = {
             return;
           }
 
+          if (node.value.type === 'Literal' && !isValidSpacingValue(node.value.value, fontSize)) {
+            context.report({
+              node,
+              messageId: 'noRawSpacingValues',
+              data: {
+                payload: `NaN:${node.value.value}`
+              }
+            });
+            return;
+          }
+
           const value = getValue(node.value, context);
 
-          if (value) {
+          if (value && isValidSpacingValue(value, fontSize)) {
             const values = typeof value === 'number' || typeof value === 'string' ? [value] : value;
-            values.forEach(value => {
+            values.forEach(val => {
               context.report({
                 node,
                 messageId: 'noRawSpacingValues',
                 data: {
-                  payload: `${node.key.name}:${emToPixels(value, fontSize)}`
+                  payload: `${node.key.name}:${emToPixels(val, fontSize)}`
                 }
               });
             });
-            return;
           } else {
             context.report({
               node,
               messageId: 'noRawSpacingValues',
               data: {
-                payload: `${node.key.name}:NaN`
+                payload: `NaN:${value}`
               }
             });
           }
@@ -94,18 +104,34 @@ const rule = {
          * Adapted from ensure-design-token-usage
          */
 
-        const cssProperties = combinedString.replace(/\n/g, '').split(/;|{|}/).map(el => el.trim() || '');
+        const cssProperties = combinedString.split('\n').filter(line => !line.trim().startsWith('@')).join('\n').replace(/\n/g, '').split(/;|{|}/).map(el => el.trim() || '');
         cssProperties.map(style => {
-          const [property, value] = style.split(':');
+          let [property, value] = style.split(':');
+          property = convertHyphenatedNameToCamelCase(property);
 
           if (isSpacingProperty(property)) {
-            context.report({
-              node,
-              messageId: 'noRawSpacingValues',
-              data: {
-                payload: `${property}:${removePixelSuffix(value.trim())}`
+            if (isValidSpacingValue(value)) {
+              const values = getValueFromShorthand(value);
+
+              for (const val of values) {
+                // could be array of values e.g. padding: 8px 12px 3px
+                context.report({
+                  node,
+                  messageId: 'noRawSpacingValues',
+                  data: {
+                    payload: `${property}:${val}`
+                  }
+                });
               }
-            });
+            } else {
+              context.report({
+                node,
+                messageId: 'noRawSpacingValues',
+                data: {
+                  payload: `NaN:${value}`
+                }
+              });
+            }
           }
 
           return;

package/dist/es2019/rules/no-raw-spacing-values/utils.js

@@ -1,5 +1,5 @@
 import { isNodeOfType } from 'eslint-codemod-utils';
-const properties = ['padding', 'paddingLeft', 'paddingTop', 'paddingRight', 'paddingBottom', 'marginLeft', 'marginTop', 'marginRight', 'marginBottom', 'margin', 'gap', 'fontSize', 'lineHeight', 'width', 'height'];
+const properties = ['padding', 'paddingLeft', 'paddingTop', 'paddingRight', 'paddingBottom', 'marginLeft', 'marginTop', 'marginRight', 'marginBottom', 'margin', 'gap', 'fontSize', 'lineHeight', 'width', 'height', 'rowGap', 'gridRowGap', 'columnGap', 'gridColumnGap'];
 export function findIdentifierInParentScope({
   scope,
   identifierName
@@ -97,6 +97,10 @@ const getValueFromIdentifier = (node, context) => {
 
   const definition = variable.defs[0];
 
+  if (isNodeOfType(definition.node, 'ImportSpecifier') && isNodeOfType(definition.node.parent, 'ImportDeclaration') && definition.node.parent.source.value === '@atlassian/jira-common-legacy-do-not-add-anything-new/src/styles') {
+    return definition.node.imported.name === 'gridSize' ? 8 : null;
+  }
+
   if (!isNodeOfType(definition.node, 'VariableDeclarator')) {
     return null;
   }
@@ -120,7 +124,7 @@ const getValueFromUnaryExpression = (node, context) => {
   } // eslint-disable-next-line no-eval
 
 
-  return eval(`${node.operator}${value}`);
+  return eval(`${node.operator}(${value})`);
 };
 /**
  * @example
@@ -173,9 +177,9 @@ export const emToPixels = (value, fontSize) => {
 
     if (match && typeof fontSize === 'number') {
       return Number(match[1]) * fontSize;
+    } else {
+      return null;
     }
-
-    return 'NaN';
   }
 
   return value;
@@ -190,4 +194,29 @@ export const removePixelSuffix = value => {
 
 
   return Number(isString ? value.replace('px', '') : value);
+};
+const invalidSpacingUnitRegex = /(%$)|(\d+rem$)|(^calc)|(vw$)|(vh$)/;
+export const isValidSpacingValue = (value, fontSize) => {
+  if (typeof value === 'string') {
+    if (invalidSpacingUnitRegex.test(value)) {
+      return false;
+    }
+  } else if (Array.isArray(value)) {
+    // could be array due to shorthand
+    for (const val in value) {
+      if (invalidSpacingUnitRegex.test(val)) {
+        return false;
+      }
+    }
+  }
+
+  if (emRegex.test(value) && typeof fontSize !== 'number') {
+    return false;
+  }
+
+  return true;
+}; // convert line-height to lineHeight
+
+export const convertHyphenatedNameToCamelCase = prop => {
+  return prop.replace(/-./g, m => m[1].toUpperCase());
 };

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "4.10.0",
+	"version": "4.10.1",
 	"sideEffects": false
 }

package/dist/esm/rules/no-raw-spacing-values/index.js

@@ -1,6 +1,13 @@
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
+
+function _createForOfIteratorHelper(o, allowArrayLike) { var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; if (!it) { if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = it.call(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it.return != null) it.return(); } finally { if (didErr) throw err; } } }; }
+
+function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
+
+function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) { arr2[i] = arr[i]; } return arr2; }
+
 import { isNodeOfType } from 'eslint-codemod-utils';
-import { emToPixels, getValue, isSpacingProperty, removePixelSuffix } from './utils';
+import { convertHyphenatedNameToCamelCase, emToPixels, getValue, getValueFromShorthand, isSpacingProperty, isValidSpacingValue } from './utils';
 var rule = {
   meta: {
     type: 'problem',
@@ -21,7 +28,7 @@ var rule = {
           return;
         }
         /**
-         * We do this in case we the fontSize for a style object is declared alongside the `em` or `lineHeight` declaration
+         * We do this in case the fontSize for a style object is declared alongside the `em` or `lineHeight` declaration
          */
 
 
@@ -52,26 +59,36 @@ var rule = {
             return;
           }
 
+          if (node.value.type === 'Literal' && !isValidSpacingValue(node.value.value, fontSize)) {
+            context.report({
+              node: node,
+              messageId: 'noRawSpacingValues',
+              data: {
+                payload: "NaN:".concat(node.value.value)
+              }
+            });
+            return;
+          }
+
           var value = getValue(node.value, context);
 
-          if (value) {
+          if (value && isValidSpacingValue(value, fontSize)) {
             var values = typeof value === 'number' || typeof value === 'string' ? [value] : value;
-            values.forEach(function (value) {
+            values.forEach(function (val) {
               context.report({
                 node: node,
                 messageId: 'noRawSpacingValues',
                 data: {
-                  payload: "".concat(node.key.name, ":").concat(emToPixels(value, fontSize))
+                  payload: "".concat(node.key.name, ":").concat(emToPixels(val, fontSize))
                 }
               });
             });
-            return;
           } else {
             context.report({
               node: node,
               messageId: 'noRawSpacingValues',
               data: {
-                payload: "".concat(node.key.name, ":NaN")
+                payload: "NaN:".concat(value)
               }
             });
           }
@@ -94,7 +111,9 @@ var rule = {
          * Adapted from ensure-design-token-usage
          */
 
-        var cssProperties = combinedString.replace(/\n/g, '').split(/;|{|}/).map(function (el) {
+        var cssProperties = combinedString.split('\n').filter(function (line) {
+          return !line.trim().startsWith('@');
+        }).join('\n').replace(/\n/g, '').split(/;|{|}/).map(function (el) {
           return el.trim() || '';
         });
         cssProperties.map(function (style) {
@@ -103,14 +122,41 @@ var rule = {
               property = _style$split2[0],
               value = _style$split2[1];
 
+          property = convertHyphenatedNameToCamelCase(property);
+
           if (isSpacingProperty(property)) {
-            context.report({
-              node: node,
-              messageId: 'noRawSpacingValues',
-              data: {
-                payload: "".concat(property, ":").concat(removePixelSuffix(value.trim()))
+            if (isValidSpacingValue(value)) {
+              var values = getValueFromShorthand(value);
+
+              var _iterator = _createForOfIteratorHelper(values),
+                  _step;
+
+              try {
+                for (_iterator.s(); !(_step = _iterator.n()).done;) {
+                  var val = _step.value;
+                  // could be array of values e.g. padding: 8px 12px 3px
+                  context.report({
+                    node: node,
+                    messageId: 'noRawSpacingValues',
+                    data: {
+                      payload: "".concat(property, ":").concat(val)
+                    }
+                  });
+                }
+              } catch (err) {
+                _iterator.e(err);
+              } finally {
+                _iterator.f();
               }
-            });
+            } else {
+              context.report({
+                node: node,
+                messageId: 'noRawSpacingValues',
+                data: {
+                  payload: "NaN:".concat(value)
+                }
+              });
+            }
           }
 
           return;

package/dist/esm/rules/no-raw-spacing-values/utils.js

@@ -1,5 +1,5 @@
 import { isNodeOfType } from 'eslint-codemod-utils';
-var properties = ['padding', 'paddingLeft', 'paddingTop', 'paddingRight', 'paddingBottom', 'marginLeft', 'marginTop', 'marginRight', 'marginBottom', 'margin', 'gap', 'fontSize', 'lineHeight', 'width', 'height'];
+var properties = ['padding', 'paddingLeft', 'paddingTop', 'paddingRight', 'paddingBottom', 'marginLeft', 'marginTop', 'marginRight', 'marginBottom', 'margin', 'gap', 'fontSize', 'lineHeight', 'width', 'height', 'rowGap', 'gridRowGap', 'columnGap', 'gridColumnGap'];
 export function findIdentifierInParentScope(_ref) {
   var scope = _ref.scope,
       identifierName = _ref.identifierName;
@@ -104,6 +104,10 @@ var getValueFromIdentifier = function getValueFromIdentifier(node, context) {
 
   var definition = variable.defs[0];
 
+  if (isNodeOfType(definition.node, 'ImportSpecifier') && isNodeOfType(definition.node.parent, 'ImportDeclaration') && definition.node.parent.source.value === '@atlassian/jira-common-legacy-do-not-add-anything-new/src/styles') {
+    return definition.node.imported.name === 'gridSize' ? 8 : null;
+  }
+
   if (!isNodeOfType(definition.node, 'VariableDeclarator')) {
     return null;
   }
@@ -127,7 +131,7 @@ var getValueFromUnaryExpression = function getValueFromUnaryExpression(node, con
   } // eslint-disable-next-line no-eval
 
 
-  return eval("".concat(node.operator).concat(value));
+  return eval("".concat(node.operator, "(").concat(value, ")"));
 };
 /**
  * @example
@@ -178,9 +182,9 @@ export var emToPixels = function emToPixels(value, fontSize) {
 
     if (match && typeof fontSize === 'number') {
       return Number(match[1]) * fontSize;
+    } else {
+      return null;
     }
-
-    return 'NaN';
   }
 
   return value;
@@ -195,4 +199,31 @@ export var removePixelSuffix = function removePixelSuffix(value) {
 
 
   return Number(isString ? value.replace('px', '') : value);
+};
+var invalidSpacingUnitRegex = /(%$)|(\d+rem$)|(^calc)|(vw$)|(vh$)/;
+export var isValidSpacingValue = function isValidSpacingValue(value, fontSize) {
+  if (typeof value === 'string') {
+    if (invalidSpacingUnitRegex.test(value)) {
+      return false;
+    }
+  } else if (Array.isArray(value)) {
+    // could be array due to shorthand
+    for (var val in value) {
+      if (invalidSpacingUnitRegex.test(val)) {
+        return false;
+      }
+    }
+  }
+
+  if (emRegex.test(value) && typeof fontSize !== 'number') {
+    return false;
+  }
+
+  return true;
+}; // convert line-height to lineHeight
+
+export var convertHyphenatedNameToCamelCase = function convertHyphenatedNameToCamelCase(prop) {
+  return prop.replace(/-./g, function (m) {
+    return m[1].toUpperCase();
+  });
 };

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
-	"version": "4.10.0",
+	"version": "4.10.1",
 	"sideEffects": false
 }

package/dist/types/rules/no-raw-spacing-values/utils.d.ts

@@ -6,6 +6,8 @@ export declare function findIdentifierInParentScope({ scope, identifierName, }:
 }): Scope.Variable | null;
 export declare const isSpacingProperty: (prop: string) => boolean;
 export declare const getValueFromShorthand: (str: unknown) => any[];
-export declare const getValue: (node: EslintNode, context: Rule.RuleContext) => number | null | number[];
-export declare const emToPixels: <T extends unknown>(value: T, fontSize: number | null) => number | T | "NaN";
+export declare const getValue: (node: EslintNode, context: Rule.RuleContext) => string | number | any[] | null | undefined;
+export declare const emToPixels: <T extends unknown>(value: T, fontSize: number | null | undefined) => number | T | null;
 export declare const removePixelSuffix: (value: string | number) => string | number;
+export declare const isValidSpacingValue: (value: string | number | boolean | RegExp | null | undefined | any[] | bigint, fontSize?: number | null | undefined) => boolean;
+export declare const convertHyphenatedNameToCamelCase: (prop: string) => string;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-design-system",
   "description": "The essential plugin for use with the Atlassian Design System.",
-  "version": "4.10.0",
+  "version": "4.10.1",
   "author": "Atlassian Pty Ltd",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -32,7 +32,7 @@
   },
   "devDependencies": {
     "@atlaskit/ds-lib": "^2.1.0",
-    "@atlaskit/theme": "^12.0.2",
+    "@atlaskit/theme": "^12.2.0",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
     "@emotion/core": "^10.0.9",
     "@emotion/styled": "^11.0.0",