@atlaskit/eslint-plugin-design-system 14.0.0 → 14.2.0

package/dist/esm/rules/use-primitives/transformers/emotion-css/index.js

@@ -3,11 +3,17 @@ import _toConsumableArray from "@babel/runtime/helpers/toConsumableArray";
 
 import { getIdentifierInParentScope, isNodeOfType } from 'eslint-codemod-utils';
 import { getScope, getSourceCode } from '@atlaskit/eslint-utils/context-compat';
-import * as ast from '../../../../ast-nodes';
-import { getVariableDefinitionValue, getVariableUsagesCount, isValidCssPropertiesToTransform } from '../../utils';
+import { FunctionCall } from '../../../../ast-nodes/function-call';
+import { JSXAttribute as JSXAttributeHelper } from '../../../../ast-nodes/jsx-attribute';
+import { JSXElement as JSXElementHelper } from '../../../../ast-nodes/jsx-element';
+import { Root } from '../../../../ast-nodes/root';
+import { getVariableDefinitionValue } from '../../utils/get-variable-definition-value';
+import { getVariableUsagesCount } from '../../utils/get-variable-usage-count';
+import { isValidCssPropertiesToTransform } from '../../utils/is-valid-css-properties-to-transform';
 import { validateStyles } from '../../utils/validate-styles';
 import { cssToXcssTransformer } from '../css-to-xcss';
-import * as supported from './supported';
+import { attributes } from './attributes';
+import { elements } from './elements';
 export var EmotionCSS = {
   lint: function lint(node, _ref) {
     var context = _ref.context,
@@ -43,29 +49,29 @@ export var EmotionCSS = {
     if (!isNodeOfType(node, 'JSXElement')) {
       return false;
     }
-    var elementName = ast.JSXElement.getName(node);
+    var elementName = JSXElementHelper.getName(node);
     if (!elementName) {
       return false;
     }
 
     // Currently we only support `div`. This may change in future.
-    if (!supported.elements.includes(elementName)) {
+    if (!elements.includes(elementName)) {
       return false;
     }
 
     // Ignore elements that contain dangerous attributes like `id`.
-    if (!ast.JSXElement.hasAllowedAttrsOnly(node, supported.attributes)) {
+    if (!JSXElementHelper.hasAllowedAttrsOnly(node, attributes)) {
       return false;
     }
 
     // Currently we don't transform anything to `Box` unless it defines styles
-    var cssAttr = ast.JSXElement.getAttributeByName(node, 'css');
+    var cssAttr = JSXElementHelper.getAttributeByName(node, 'css');
     if (!cssAttr) {
       return false;
     }
 
     // Get `myStyles` in `css={myStyles}` as a string so we can search for the `const myStyles` VariableDefinition
-    var cssAttrValue = ast.JSXAttribute.getValue(cssAttr);
+    var cssAttrValue = JSXAttributeHelper.getValue(cssAttr);
     if ((cssAttrValue === null || cssAttrValue === void 0 ? void 0 : cssAttrValue.type) !== 'ExpressionStatement') {
       return false;
     }
@@ -81,13 +87,13 @@ export var EmotionCSS = {
     var cssVariableDefinition = getIdentifierInParentScope(getScope(context, node), cssAttrValue.value);
     var cssVariableValue = getVariableDefinitionValue(cssVariableDefinition);
     // Check if `cssVariableValue` is a function called `css()`
-    if (ast.FunctionCall.getName(cssVariableValue === null || cssVariableValue === void 0 ? void 0 : cssVariableValue.node.init) !== 'css') {
+    if (FunctionCall.getName(cssVariableValue === null || cssVariableValue === void 0 ? void 0 : cssVariableValue.node.init) !== 'css') {
       return false;
     }
     if (!(config.patterns.includes('string-style-property-fix') ? validateStyles(cssVariableValue === null || cssVariableValue === void 0 ? void 0 : cssVariableValue.node.init, config) : isValidCssPropertiesToTransform(cssVariableValue === null || cssVariableValue === void 0 ? void 0 : cssVariableValue.node.init, config))) {
       return false;
     }
-    var importDeclaration = ast.Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
+    var importDeclaration = Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
 
     // If there is more than one `@atlaskit/primitives` import, then it becomes difficult to determine which import to transform
     if (importDeclaration.length > 1) {
@@ -98,13 +104,13 @@ export var EmotionCSS = {
   _fix: function _fix(node, _ref3) {
     var context = _ref3.context;
     return function (fixer) {
-      var importFix = ast.Root.upsertNamedImportDeclaration({
+      var importFix = Root.upsertNamedImportDeclaration({
         module: '@atlaskit/primitives',
         specifiers: ['Box', 'xcss']
       }, context, fixer);
-      var cssAttr = ast.JSXElement.getAttributeByName(node, 'css'); // Can strongly assert the type here, because we validated it exists in `check()`.
-      var attributeFix = ast.JSXAttribute.updateName(cssAttr, 'xcss', fixer);
-      var elementNameFixes = ast.JSXElement.updateName(node, 'Box', fixer);
+      var cssAttr = JSXElementHelper.getAttributeByName(node, 'css'); // Can strongly assert the type here, because we validated it exists in `check()`.
+      var attributeFix = JSXAttributeHelper.updateName(cssAttr, 'xcss', fixer);
+      var elementNameFixes = JSXElementHelper.updateName(node, 'Box', fixer);
       var cssToXcssTransform = cssToXcssTransformer(node, context, fixer);
       return [importFix, attributeFix].concat(_toConsumableArray(elementNameFixes), _toConsumableArray(cssToXcssTransform)).filter(function (fix) {
         return Boolean(fix);

package/dist/esm/rules/use-primitives/transformers/space-token-map.js

@@ -0,0 +1,2 @@
+import { allSpaceMap } from '../../../common/token-maps.partial';
+export var spaceTokenMap = allSpaceMap;

package/dist/esm/rules/use-primitives/transformers/space-token-positive-map.js

@@ -0,0 +1,2 @@
+import { positiveSpaceMap } from '../../../common/token-maps.partial';
+export var spaceTokenPositiveMap = positiveSpaceMap;

package/dist/esm/rules/use-primitives/transformers/supported-dimension-attributes-map.js

@@ -0,0 +1,9 @@
+import { dimensionsMap } from './dimensions-map';
+export var supportedDimensionAttributesMap = {
+  width: dimensionsMap,
+  height: dimensionsMap,
+  minWidth: dimensionsMap,
+  minHeight: dimensionsMap,
+  maxWidth: dimensionsMap,
+  maxHeight: dimensionsMap
+};

package/dist/esm/rules/use-primitives/utils/convert-ast-object-expression-to-js-object.js

@@ -1,5 +1,5 @@
 import { isNodeOfType } from 'eslint-codemod-utils';
-export var SPREAD_SYNTAX = Symbol('SPREAD_SYNTAX');
+import { SPREAD_SYNTAX } from './spread-syntax';
 /**
  * Note: Not recursive. Only handles top level key/value pairs
  */

package/dist/esm/rules/use-primitives/utils/is-valid-css-properties-to-transform.js

@@ -2,8 +2,9 @@ import _typeof from "@babel/runtime/helpers/typeof";
 import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
 var _excluded = ["unsupported"];
 import { isNodeOfType } from 'eslint-codemod-utils';
-import * as ast from '../../../ast-nodes';
-import { supportedDimensionAttributesMap, supportedStylesMap } from '../transformers/css-to-xcss';
+import { Object as ObjectHelper } from '../../../ast-nodes/object';
+import { supportedStylesMap } from '../transformers/css-to-xcss';
+import { supportedDimensionAttributesMap } from '../transformers/supported-dimension-attributes-map';
 import { convertASTObjectExpressionToJSObject } from './convert-ast-object-expression-to-js-object';
 export var isValidCssPropertiesToTransform = function isValidCssPropertiesToTransform(node, config) {
   if (!node) {
@@ -14,12 +15,12 @@ export var isValidCssPropertiesToTransform = function isValidCssPropertiesToTran
   if (!cssObjectExpression || !isNodeOfType(cssObjectExpression, 'ObjectExpression')) {
     return false;
   }
-  if (!ast.Object.isFlat(cssObjectExpression)) {
+  if (!ObjectHelper.isFlat(cssObjectExpression)) {
     return false;
   }
 
   // `use-primitives` should not report on empty style objects. See: https://product-fabric.atlassian.net/browse/DSP-16520
-  if (ast.Object.getEntries(cssObjectExpression).length === 0) {
+  if (ObjectHelper.getEntries(cssObjectExpression).length === 0) {
     return false;
   }
   var _convertASTObjectExpr = convertASTObjectExpressionToJSObject(cssObjectExpression),

package/dist/esm/rules/use-primitives/utils/spread-syntax.js

@@ -0,0 +1 @@
+export var SPREAD_SYNTAX = Symbol('SPREAD_SYNTAX');

package/dist/esm/rules/use-primitives/utils/validate-styles.js

@@ -1,7 +1,10 @@
 import { isNodeOfType } from 'eslint-codemod-utils';
-import * as ast from '../../../ast-nodes';
-import { spaceTokenMap, supportedStylesMap } from '../transformers';
-import { supportedDimensionAttributesMap } from '../transformers/css-to-xcss';
+import { FunctionCall } from '../../../ast-nodes/function-call';
+import { Object as ObjectHelper } from '../../../ast-nodes/object';
+import { ObjectEntry } from '../../../ast-nodes/object-entry';
+import { supportedStylesMap } from '../transformers/css-to-xcss';
+import { spaceTokenMap } from '../transformers/space-token-map';
+import { supportedDimensionAttributesMap } from '../transformers/supported-dimension-attributes-map';
 export var validateStyles = function validateStyles(node, config) {
   if (!node) {
     return false;
@@ -11,10 +14,10 @@ export var validateStyles = function validateStyles(node, config) {
   if (!isNodeOfType(cssObjectExpression, 'ObjectExpression')) {
     return false;
   }
-  if (!ast.Object.isFlat(cssObjectExpression)) {
+  if (!ObjectHelper.isFlat(cssObjectExpression)) {
     return false;
   }
-  var entries = ast.Object.getEntries(cssObjectExpression);
+  var entries = ObjectHelper.getEntries(cssObjectExpression);
   if (entries.length === 0) {
     return false;
   }
@@ -33,7 +36,7 @@ export var validateStyles = function validateStyles(node, config) {
     if (!isNodeOfType(key, 'Identifier')) {
       return false;
     }
-    var property = ast.ObjectEntry.getPropertyName(entry);
+    var property = ObjectEntry.getPropertyName(entry);
     if (!property) {
       return false;
     }
@@ -87,10 +90,10 @@ var isTokenCall = function isTokenCall(node) {
   }
 
   // Is the function called 'token'?
-  if (ast.FunctionCall.getName(node) !== 'token') {
+  if (FunctionCall.getName(node) !== 'token') {
     return false;
   }
-  var token = ast.FunctionCall.getArgumentAtPos(node, 0);
+  var token = FunctionCall.getArgumentAtPos(node, 0);
   if (!token || token.type !== 'Literal') {
     return false;
   }
@@ -102,7 +105,7 @@ var isTokenCall = function isTokenCall(node) {
 
   // Not all `token()` calls have a fall back. This is fine, but if there is a fallback, make sure it's the same as the fallback xcss will use
   if (node.arguments.length === 2) {
-    var fallback = ast.FunctionCall.getArgumentAtPos(node, 1);
+    var fallback = FunctionCall.getArgumentAtPos(node, 1);
 
     // `getArgumentAtPos` is only able to understand `Literal` and `ObjectExpression` statements
     // If there are 2 args, but `fallback` is undefined, then the fallback is something wild, like `token('space.100, `${gridSize * rem(3)`})`

package/dist/esm/rules/use-primitives-text/index.js

@@ -1,7 +1,10 @@
 import { createLintRule } from '../utils/create-rule';
 import { errorBoundary } from '../utils/error-boundary';
 import { getConfig, PATTERNS } from './config';
-import { EmphasisElements, ParagraphElements, SpanElements, StrongElements } from './transformers';
+import { EmphasisElements } from './transformers/emphasis-elements';
+import { ParagraphElements } from './transformers/paragraph-elements';
+import { SpanElements } from './transformers/span-elements';
+import { StrongElements } from './transformers/strong-elements';
 var textDocsUrl = 'https://atlassian.design/components/primitives/text';
 var rule = createLintRule({
   meta: {

package/dist/esm/rules/use-primitives-text/transformers/add-color-inherit-attribute-fix.js

@@ -0,0 +1,8 @@
+import { JSXElement as JSXElementHelper } from '../../../ast-nodes/jsx-element';
+// Add color="inherit" prop depending on config
+export function addColorInheritAttributeFix(node, config, fixer) {
+  if (!config.inheritColor) {
+    return;
+  }
+  return JSXElementHelper.addAttribute(node, 'color', 'inherit', fixer);
+}

package/dist/esm/rules/use-primitives-text/transformers/allowed-attrs.js

@@ -0,0 +1 @@
+export var allowedAttrs = ['id', 'data-testid', 'key'];

package/dist/esm/rules/use-primitives-text/transformers/common.js

@@ -1,40 +1 @@
-import { isNodeOfType } from 'eslint-codemod-utils';
-import * as ast from '../../../ast-nodes';
-// Rename data-testid prop to testId if present
-export function updateTestIdAttributeFix(node, fixer) {
-  var testIdAttr = ast.JSXElement.getAttributeByName(node, 'data-testid');
-  if (testIdAttr) {
-    return ast.JSXAttribute.updateName(testIdAttr, 'testId', fixer);
-  }
-}
-
-// Add color="inherit" prop depending on config
-export function addColorInheritAttributeFix(node, config, fixer) {
-  if (!config.inheritColor) {
-    return;
-  }
-  return ast.JSXElement.addAttribute(node, 'color', 'inherit', fixer);
-}
-export var allowedAttrs = ['id', 'data-testid', 'key'];
-
-// Only allow elements with strings as children
-// The use of `<FormattedMessage ... />` component and `{formatMessage(...)}` are allowed as these are used for i18n
-export function hasTextChildrenOnly(node) {
-  var _node$children;
-  return (_node$children = node.children) === null || _node$children === void 0 ? void 0 : _node$children.every(function (child) {
-    if (isNodeOfType(child, 'JSXText')) {
-      return true;
-    }
-
-    // JSX child element <span><FormattedMessage /></span>
-    if (isNodeOfType(child, 'JSXElement') && ast.JSXElement.getName(child) === 'FormattedMessage') {
-      return true;
-    }
-
-    // JSX expression <span>{formatMessage(...)}</span>
-    if (isNodeOfType(child, 'JSXExpressionContainer') && isNodeOfType(child.expression, 'CallExpression')) {
-      return ast.FunctionCall.getName(child.expression) === 'formatMessage';
-    }
-    return false;
-  });
-}
+export {};

package/dist/esm/rules/use-primitives-text/transformers/emphasis-elements.js

@@ -6,8 +6,11 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 
 import { isNodeOfType } from 'eslint-codemod-utils';
 import { getSourceCode } from '@atlaskit/eslint-utils/context-compat';
-import * as ast from '../../../ast-nodes';
-import { addColorInheritAttributeFix, allowedAttrs, updateTestIdAttributeFix } from './common';
+import { JSXElement as JSXElementHelper } from '../../../ast-nodes/jsx-element';
+import { Root } from '../../../ast-nodes/root';
+import { addColorInheritAttributeFix } from './add-color-inherit-attribute-fix';
+import { allowedAttrs } from './allowed-attrs';
+import { updateTestIdAttributeFix } from './update-test-id-attribute-fix';
 export var EmphasisElements = {
   lint: function lint(node, _ref) {
     var context = _ref.context,
@@ -54,7 +57,7 @@ export var EmphasisElements = {
         success: false
       };
     }
-    var elementName = ast.JSXElement.getName(node);
+    var elementName = JSXElementHelper.getName(node);
     if (elementName !== 'em') {
       return {
         success: false
@@ -67,7 +70,7 @@ export var EmphasisElements = {
     }
 
     // Element has no unallowed props
-    if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {
+    if (!JSXElementHelper.hasAllowedAttrsOnly(node, allowedAttrs)) {
       return {
         success: true,
         autoFixable: false
@@ -75,7 +78,7 @@ export var EmphasisElements = {
     }
 
     // If there is more than one `@atlaskit/primitives` import, then it becomes difficult to determine which import to transform
-    var importDeclaration = ast.Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
+    var importDeclaration = Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
     if (importDeclaration.length > 1) {
       return {
         success: true,
@@ -91,12 +94,12 @@ export var EmphasisElements = {
     var context = _ref3.context,
       config = _ref3.config;
     return function (fixer) {
-      var importFix = ast.Root.upsertNamedImportDeclaration({
+      var importFix = Root.upsertNamedImportDeclaration({
         module: '@atlaskit/primitives',
         specifiers: ['Text']
       }, context, fixer);
-      var elementNameFixes = ast.JSXElement.updateName(node, 'Text', fixer);
-      var asAttributeFix = ast.JSXElement.addAttribute(node, 'as', 'em', fixer);
+      var elementNameFixes = JSXElementHelper.updateName(node, 'Text', fixer);
+      var asAttributeFix = JSXElementHelper.addAttribute(node, 'as', 'em', fixer);
       var colorAttributeFix = addColorInheritAttributeFix(node, config, fixer);
       var testAttributeFix = updateTestIdAttributeFix(node, fixer);
       return [importFix].concat(_toConsumableArray(elementNameFixes), [asAttributeFix, colorAttributeFix, testAttributeFix]).filter(function (fix) {

package/dist/esm/rules/use-primitives-text/transformers/has-text-children-only.js

@@ -0,0 +1,24 @@
+import { isNodeOfType } from 'eslint-codemod-utils';
+import { FunctionCall } from '../../../ast-nodes/function-call';
+import { JSXElement as JSXElementHelper } from '../../../ast-nodes/jsx-element';
+
+// The use of `<FormattedMessage ... />` component and `{formatMessage(...)}` are allowed as these are used for i18n
+export function hasTextChildrenOnly(node) {
+  var _node$children;
+  return (_node$children = node.children) === null || _node$children === void 0 ? void 0 : _node$children.every(function (child) {
+    if (isNodeOfType(child, 'JSXText')) {
+      return true;
+    }
+
+    // JSX child element <span><FormattedMessage /></span>
+    if (isNodeOfType(child, 'JSXElement') && JSXElementHelper.getName(child) === 'FormattedMessage') {
+      return true;
+    }
+
+    // JSX expression <span>{formatMessage(...)}</span>
+    if (isNodeOfType(child, 'JSXExpressionContainer') && isNodeOfType(child.expression, 'CallExpression')) {
+      return FunctionCall.getName(child.expression) === 'formatMessage';
+    }
+    return false;
+  });
+}

package/dist/esm/rules/use-primitives-text/transformers/paragraph-elements.js

@@ -6,8 +6,11 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 
 import { isNodeOfType } from 'eslint-codemod-utils';
 import { getSourceCode } from '@atlaskit/eslint-utils/context-compat';
-import * as ast from '../../../ast-nodes';
-import { addColorInheritAttributeFix, allowedAttrs, updateTestIdAttributeFix } from './common';
+import { JSXElement as JSXElementHelper } from '../../../ast-nodes/jsx-element';
+import { Root } from '../../../ast-nodes/root';
+import { addColorInheritAttributeFix } from './add-color-inherit-attribute-fix';
+import { allowedAttrs } from './allowed-attrs';
+import { updateTestIdAttributeFix } from './update-test-id-attribute-fix';
 export var ParagraphElements = {
   lint: function lint(node, _ref) {
     var context = _ref.context,
@@ -89,7 +92,7 @@ export var ParagraphElements = {
         }
       };
     }
-    var elementName = ast.JSXElement.getName(node);
+    var elementName = JSXElementHelper.getName(node);
     if (elementName !== 'p') {
       return {
         success: false,
@@ -117,7 +120,7 @@ export var ParagraphElements = {
         }
       };
     }
-    var siblings = ast.JSXElement.getChildren(node.parent);
+    var siblings = JSXElementHelper.getChildren(node.parent);
     if (siblings.length > 1) {
       var _siblings$0$range, _node$range, _siblings$0$range2, _node$range2;
       // Only report for the first p element by comparing node location
@@ -135,10 +138,10 @@ export var ParagraphElements = {
         if (!isNodeOfType(child, 'JSXElement')) {
           return false;
         }
-        if (ast.JSXElement.getName(child) !== 'p') {
+        if (JSXElementHelper.getName(child) !== 'p') {
           return false;
         }
-        return ast.JSXElement.hasAllowedAttrsOnly(child, allowedAttrs);
+        return JSXElementHelper.hasAllowedAttrsOnly(child, allowedAttrs);
       });
       if (!siblingsMatch) {
         return {
@@ -149,7 +152,7 @@ export var ParagraphElements = {
           }
         };
       }
-    } else if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {
+    } else if (!JSXElementHelper.hasAllowedAttrsOnly(node, allowedAttrs)) {
       return {
         success: true,
         autoFixable: false,
@@ -158,7 +161,7 @@ export var ParagraphElements = {
         }
       };
     }
-    var importDeclaration = ast.Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
+    var importDeclaration = Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
 
     // If there is more than one `@atlaskit/primitives` import, then it becomes difficult to determine which import to transform
     if (importDeclaration.length > 1) {
@@ -182,12 +185,12 @@ export var ParagraphElements = {
     var context = _ref3.context,
       config = _ref3.config;
     return function (fixer) {
-      var importFix = ast.Root.upsertNamedImportDeclaration({
+      var importFix = Root.upsertNamedImportDeclaration({
         module: '@atlaskit/primitives',
         specifiers: ['Text']
       }, context, fixer);
-      var elementNameFixes = ast.JSXElement.updateName(node, 'Text', fixer);
-      var asAttributeFix = ast.JSXElement.addAttribute(node, 'as', 'p', fixer);
+      var elementNameFixes = JSXElementHelper.updateName(node, 'Text', fixer);
+      var asAttributeFix = JSXElementHelper.addAttribute(node, 'as', 'p', fixer);
       var colorAttributeFix = addColorInheritAttributeFix(node, config, fixer);
       var testAttributeFix = updateTestIdAttributeFix(node, fixer);
       return [importFix].concat(_toConsumableArray(elementNameFixes), [asAttributeFix, colorAttributeFix, testAttributeFix]).filter(function (fix) {
@@ -203,7 +206,7 @@ export var ParagraphElements = {
       if (!isNodeOfType(node.parent, 'JSXElement') || !node.parent.closingElement) {
         return [];
       }
-      var importFix = ast.Root.upsertNamedImportDeclaration({
+      var importFix = Root.upsertNamedImportDeclaration({
         module: '@atlaskit/primitives',
         specifiers: ['Text', 'Stack']
       }, context, fixer);
@@ -211,8 +214,8 @@ export var ParagraphElements = {
       // Update all siblings elements and their attributes
       var siblingFixes = refs.siblings.map(function (sibling) {
         if (isNodeOfType(sibling, 'JSXElement')) {
-          var elementNameFixes = ast.JSXElement.updateName(sibling, 'Text', fixer);
-          var asAttributeFix = ast.JSXElement.addAttribute(sibling, 'as', 'p', fixer);
+          var elementNameFixes = JSXElementHelper.updateName(sibling, 'Text', fixer);
+          var asAttributeFix = JSXElementHelper.addAttribute(sibling, 'as', 'p', fixer);
           var colorAttributeFix = addColorInheritAttributeFix(sibling, config, fixer);
           var testAttributeFix = updateTestIdAttributeFix(sibling, fixer);
           return [].concat(_toConsumableArray(elementNameFixes), [asAttributeFix, colorAttributeFix, testAttributeFix]);

package/dist/esm/rules/use-primitives-text/transformers/span-elements.js

@@ -6,8 +6,12 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 
 import { isNodeOfType } from 'eslint-codemod-utils';
 import { getSourceCode } from '@atlaskit/eslint-utils/context-compat';
-import * as ast from '../../../ast-nodes';
-import { addColorInheritAttributeFix, allowedAttrs, hasTextChildrenOnly, updateTestIdAttributeFix } from './common';
+import { JSXElement as JSXElementHelper } from '../../../ast-nodes/jsx-element';
+import { Root } from '../../../ast-nodes/root';
+import { addColorInheritAttributeFix } from './add-color-inherit-attribute-fix';
+import { allowedAttrs } from './allowed-attrs';
+import { hasTextChildrenOnly } from './has-text-children-only';
+import { updateTestIdAttributeFix } from './update-test-id-attribute-fix';
 export var SpanElements = {
   lint: function lint(node, _ref) {
     var context = _ref.context,
@@ -54,7 +58,7 @@ export var SpanElements = {
         success: false
       };
     }
-    var elementName = ast.JSXElement.getName(node);
+    var elementName = JSXElementHelper.getName(node);
     if (elementName !== 'span') {
       return {
         success: false
@@ -74,7 +78,7 @@ export var SpanElements = {
     }
 
     // Element has no unallowed props
-    if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {
+    if (!JSXElementHelper.hasAllowedAttrsOnly(node, allowedAttrs)) {
       return {
         success: true,
         autoFixable: false
@@ -82,7 +86,7 @@ export var SpanElements = {
     }
 
     // If there is more than one `@atlaskit/primitives` import, then it becomes difficult to determine which import to transform
-    var importDeclaration = ast.Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
+    var importDeclaration = Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
     if (importDeclaration.length > 1) {
       return {
         success: true,
@@ -98,11 +102,11 @@ export var SpanElements = {
     var context = _ref3.context,
       config = _ref3.config;
     return function (fixer) {
-      var importFix = ast.Root.upsertNamedImportDeclaration({
+      var importFix = Root.upsertNamedImportDeclaration({
         module: '@atlaskit/primitives',
         specifiers: ['Text']
       }, context, fixer);
-      var elementNameFixes = ast.JSXElement.updateName(node, 'Text', fixer);
+      var elementNameFixes = JSXElementHelper.updateName(node, 'Text', fixer);
       var colorAttributeFix = addColorInheritAttributeFix(node, config, fixer);
       var testAttributeFix = updateTestIdAttributeFix(node, fixer);
       return [importFix].concat(_toConsumableArray(elementNameFixes), [colorAttributeFix, testAttributeFix]).filter(function (fix) {

package/dist/esm/rules/use-primitives-text/transformers/strong-elements.js

@@ -6,8 +6,11 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 
 import { isNodeOfType } from 'eslint-codemod-utils';
 import { getSourceCode } from '@atlaskit/eslint-utils/context-compat';
-import * as ast from '../../../ast-nodes';
-import { addColorInheritAttributeFix, allowedAttrs, updateTestIdAttributeFix } from './common';
+import { JSXElement as JSXElementHelper } from '../../../ast-nodes/jsx-element';
+import { Root } from '../../../ast-nodes/root';
+import { addColorInheritAttributeFix } from './add-color-inherit-attribute-fix';
+import { allowedAttrs } from './allowed-attrs';
+import { updateTestIdAttributeFix } from './update-test-id-attribute-fix';
 export var StrongElements = {
   lint: function lint(node, _ref) {
     var context = _ref.context,
@@ -54,7 +57,7 @@ export var StrongElements = {
         success: false
       };
     }
-    var elementName = ast.JSXElement.getName(node);
+    var elementName = JSXElementHelper.getName(node);
     if (elementName !== 'strong') {
       return {
         success: false
@@ -67,7 +70,7 @@ export var StrongElements = {
     }
 
     // Element has no unallowed props
-    if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {
+    if (!JSXElementHelper.hasAllowedAttrsOnly(node, allowedAttrs)) {
       return {
         success: true,
         autoFixable: false
@@ -75,7 +78,7 @@ export var StrongElements = {
     }
 
     // If there is more than one `@atlaskit/primitives` import, then it becomes difficult to determine which import to transform
-    var importDeclaration = ast.Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
+    var importDeclaration = Root.findImportsByModule(getSourceCode(context).ast.body, '@atlaskit/primitives');
     if (importDeclaration.length > 1) {
       return {
         success: true,
@@ -91,12 +94,12 @@ export var StrongElements = {
     var context = _ref3.context,
       config = _ref3.config;
     return function (fixer) {
-      var importFix = ast.Root.upsertNamedImportDeclaration({
+      var importFix = Root.upsertNamedImportDeclaration({
         module: '@atlaskit/primitives',
         specifiers: ['Text']
       }, context, fixer);
-      var elementNameFixes = ast.JSXElement.updateName(node, 'Text', fixer);
-      var asAttributeFix = ast.JSXElement.addAttribute(node, 'as', 'strong', fixer);
+      var elementNameFixes = JSXElementHelper.updateName(node, 'Text', fixer);
+      var asAttributeFix = JSXElementHelper.addAttribute(node, 'as', 'strong', fixer);
       var colorAttributeFix = addColorInheritAttributeFix(node, config, fixer);
       var testAttributeFix = updateTestIdAttributeFix(node, fixer);
       return [importFix].concat(_toConsumableArray(elementNameFixes), [asAttributeFix, colorAttributeFix, testAttributeFix]).filter(function (fix) {

package/dist/esm/rules/use-primitives-text/transformers/update-test-id-attribute-fix.js

@@ -0,0 +1,10 @@
+import { JSXAttribute } from '../../../ast-nodes/jsx-attribute';
+import { JSXElement as JSXElementHelper } from '../../../ast-nodes/jsx-element';
+
+// Rename data-testid prop to testId if present
+export function updateTestIdAttributeFix(node, fixer) {
+  var testIdAttr = JSXElementHelper.getAttributeByName(node, 'data-testid');
+  if (testIdAttr) {
+    return JSXAttribute.updateName(testIdAttr, 'testId', fixer);
+  }
+}