@atlaskit/eslint-plugin-design-system 13.40.2 → 13.40.4

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 13.40.4
+
+### Patch Changes
+
+- [`1f45f35f80c0a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/1f45f35f80c0a) -
+  use-spotlight-package now triggers for specific import specifiers, and ignores modal related
+  specifiers.
+- Updated dependencies
+
+## 13.40.3
+
+### Patch Changes
+
+- [`000d0a2d3aca2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/000d0a2d3aca2) -
+  Remove non-erasable syntax (e.g. enums, namespaces with runtime code) from package
+
 ## 13.40.2
 
 ### Patch Changes

package/dist/cjs/rules/consistent-css-prop-usage/index.js

@@ -73,6 +73,7 @@ var JSXExpressionLinter = /*#__PURE__*/function () {
    * @param configuration What css-related functions to account for (eg. css, xcss, cssMap), and whether to detect bottom vs top expressions.
    * @param expression The expression to traverse and lint.
    */
+
   function JSXExpressionLinter(context, cssAttributeName, configuration, expression) {
     (0, _classCallCheck2.default)(this, JSXExpressionLinter);
     this.context = context;

package/dist/cjs/rules/use-spotlight-package/linters/import-declaration/index.js

@@ -8,6 +8,13 @@ var _eslintCodemodUtils = require("eslint-codemod-utils");
 /* eslint-disable @repo/internal/react/require-jsdoc */
 
 var messageId = 'use-spotlight-package';
+var BANNED_IMPORTS = [
+// 'Modal',
+'Spotlight', 'SpotlightCard', 'SpotlightManager', 'SpotlightTarget', 'SpotlightTransition',
+// 'modalButtonTheme',
+'spotlightButtonTheme', 'useSpotlight',
+// 'ModalTransition',
+'SpotlightPulse'];
 var ImportDeclaration = exports.ImportDeclaration = {
   lint: function lint(node, _ref) {
     var context = _ref.context;
@@ -30,6 +37,24 @@ var ImportDeclaration = exports.ImportDeclaration = {
         ref: undefined
       };
     }
+    if (!node.specifiers) {
+      return {
+        success: false,
+        ref: undefined
+      };
+    }
+    var isViolation = node.specifiers.some(function (specifier) {
+      if (!(0, _eslintCodemodUtils.isNodeOfType)(specifier, 'ImportSpecifier')) {
+        return false;
+      }
+      return BANNED_IMPORTS.includes(specifier.imported.name);
+    });
+    if (!isViolation) {
+      return {
+        success: false,
+        ref: undefined
+      };
+    }
     return {
       success: true,
       ref: node

package/dist/es2019/rules/consistent-css-prop-usage/index.js

@@ -58,6 +58,7 @@ class JSXExpressionLinter {
    * @param configuration What css-related functions to account for (eg. css, xcss, cssMap), and whether to detect bottom vs top expressions.
    * @param expression The expression to traverse and lint.
    */
+
   constructor(context, cssAttributeName, configuration, expression) {
     this.context = context;
     this.cssAttributeName = cssAttributeName;

package/dist/es2019/rules/use-spotlight-package/linters/import-declaration/index.js

@@ -2,6 +2,13 @@
 
 import { isNodeOfType } from 'eslint-codemod-utils';
 const messageId = 'use-spotlight-package';
+const BANNED_IMPORTS = [
+// 'Modal',
+'Spotlight', 'SpotlightCard', 'SpotlightManager', 'SpotlightTarget', 'SpotlightTransition',
+// 'modalButtonTheme',
+'spotlightButtonTheme', 'useSpotlight',
+// 'ModalTransition',
+'SpotlightPulse'];
 export const ImportDeclaration = {
   lint(node, {
     context
@@ -26,6 +33,24 @@ export const ImportDeclaration = {
         ref: undefined
       };
     }
+    if (!node.specifiers) {
+      return {
+        success: false,
+        ref: undefined
+      };
+    }
+    const isViolation = node.specifiers.some(specifier => {
+      if (!isNodeOfType(specifier, 'ImportSpecifier')) {
+        return false;
+      }
+      return BANNED_IMPORTS.includes(specifier.imported.name);
+    });
+    if (!isViolation) {
+      return {
+        success: false,
+        ref: undefined
+      };
+    }
     return {
       success: true,
       ref: node

package/dist/esm/rules/consistent-css-prop-usage/index.js

@@ -66,6 +66,7 @@ var JSXExpressionLinter = /*#__PURE__*/function () {
    * @param configuration What css-related functions to account for (eg. css, xcss, cssMap), and whether to detect bottom vs top expressions.
    * @param expression The expression to traverse and lint.
    */
+
   function JSXExpressionLinter(context, cssAttributeName, configuration, expression) {
     _classCallCheck(this, JSXExpressionLinter);
     this.context = context;

package/dist/esm/rules/use-spotlight-package/linters/import-declaration/index.js

@@ -2,6 +2,13 @@
 
 import { isNodeOfType } from 'eslint-codemod-utils';
 var messageId = 'use-spotlight-package';
+var BANNED_IMPORTS = [
+// 'Modal',
+'Spotlight', 'SpotlightCard', 'SpotlightManager', 'SpotlightTarget', 'SpotlightTransition',
+// 'modalButtonTheme',
+'spotlightButtonTheme', 'useSpotlight',
+// 'ModalTransition',
+'SpotlightPulse'];
 export var ImportDeclaration = {
   lint: function lint(node, _ref) {
     var context = _ref.context;
@@ -24,6 +31,24 @@ export var ImportDeclaration = {
         ref: undefined
       };
     }
+    if (!node.specifiers) {
+      return {
+        success: false,
+        ref: undefined
+      };
+    }
+    var isViolation = node.specifiers.some(function (specifier) {
+      if (!isNodeOfType(specifier, 'ImportSpecifier')) {
+        return false;
+      }
+      return BANNED_IMPORTS.includes(specifier.imported.name);
+    });
+    if (!isViolation) {
+      return {
+        success: false,
+        ref: undefined
+      };
+    }
     return {
       success: true,
       ref: node

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
 	"description": "The essential plugin for use with the Atlassian Design System.",
-	"version": "13.40.2",
+	"version": "13.40.4",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
 	"publishConfig": {