@atlaskit/eslint-plugin-design-system 13.35.1 → 13.36.1

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 13.36.1
+
+### Patch Changes
+
+- [`3c3757717bc78`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3c3757717bc78) -
+  Introduced a temporary feature to the `no-unsafe-design-token-usage` rule to allow token fallbacks
+  for tokens specified in `UNSAFE_ignoreTokens` even if `fallbackUsage` is set to 'none'. This
+  should not be used and exists only to aid migration. It will be removed in the near future.
+
+## 13.36.0
+
+### Minor Changes
+
+- [`3147ae92ea7bd`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3147ae92ea7bd) -
+  Updates lozenge-badge-tag-labelling-system-migration eslint rule to include the migration_fallback
+  prop so that teams can adopt the Tag API without triggering an immediate visual change.
+
 ## 13.35.1
 
 ### Patch Changes

package/dist/cjs/rules/lozenge-badge-tag-labelling-system-migration/index.js

@@ -22,7 +22,7 @@ var rule = (0, _createRule.createLintRule)({
     },
     messages: {
       updateAppearance: 'Update appearance value to new semantic value.',
-      migrateTag: 'Non-bold <Lozenge> variants should migrate to <Tag> component.',
+      migrateTag: 'Non-bold <Lozenge> variants should migrate to <Tag> component. For safe, staged rollout, use the `migration_fallback="lozenge"` prop which renders as Lozenge when the feature flag is off.',
       manualReview: "Dynamic 'isBold' props require manual review before migration.",
       dynamicLozengeAppearance: "Dynamic 'appearance' prop values require manual review before migrating to Tag. Please verify the appearance value and manually convert it to the appropriate color prop value.",
       updateBadgeAppearance: 'Update Badge appearance value "{{oldValue}}" to new semantic value "{{newValue}}".',
@@ -365,6 +365,11 @@ var rule = (0, _createRule.createLintRule)({
       if (options.isSimpleTag || options.isLozengeMigration) {
         newAttributes.push('isRemovable={false}');
       }
+
+      // Add migration_fallback="lozenge" for Lozenge migrations to enable safe staged rollout
+      if (options.isLozengeMigration) {
+        newAttributes.push('migration_fallback="lozenge"');
+      }
       var attributesText = newAttributes.length > 0 ? " ".concat(newAttributes.join(' ')) : '';
       var children = node.children.length > 0 ? sourceCode.getText().slice(node.openingElement.range[1], node.closingElement ? node.closingElement.range[0] : node.range[1]) : '';
       var componentName = options.preserveComponentName ? node.openingElement.name.name : options.isAvatarTag ? 'AvatarTag' : 'Tag';

package/dist/cjs/rules/no-unsafe-design-token-usage/index.js

@@ -136,6 +136,14 @@ var rule = (0, _createRule.createLintRule)({
         } else if (node.arguments.length > 1 && config.fallbackUsage === 'none') {
           if (node.arguments[0].type === 'Literal') {
             var _value = node.arguments[0].value;
+
+            /**
+             * This check allows ADS tokens to be passed in via UNSAFE_ignoreTokens and allow fallbacks even if `fallbackUsage` is set to 'none'.
+             * Temporary solution introduced to allow fallbacks for shape tokens in Jira during migration
+             */
+            if (_value && UNSAFE_ignoreTokens.has(_value)) {
+              return;
+            }
             context.report({
               messageId: 'tokenFallbackRestricted',
               node: node.arguments[1],

package/dist/es2019/rules/lozenge-badge-tag-labelling-system-migration/index.js

@@ -12,7 +12,7 @@ const rule = createLintRule({
     },
     messages: {
       updateAppearance: 'Update appearance value to new semantic value.',
-      migrateTag: 'Non-bold <Lozenge> variants should migrate to <Tag> component.',
+      migrateTag: 'Non-bold <Lozenge> variants should migrate to <Tag> component. For safe, staged rollout, use the `migration_fallback="lozenge"` prop which renders as Lozenge when the feature flag is off.',
       manualReview: "Dynamic 'isBold' props require manual review before migration.",
       dynamicLozengeAppearance: "Dynamic 'appearance' prop values require manual review before migrating to Tag. Please verify the appearance value and manually convert it to the appropriate color prop value.",
       updateBadgeAppearance: 'Update Badge appearance value "{{oldValue}}" to new semantic value "{{newValue}}".',
@@ -354,6 +354,11 @@ const rule = createLintRule({
       if (options.isSimpleTag || options.isLozengeMigration) {
         newAttributes.push('isRemovable={false}');
       }
+
+      // Add migration_fallback="lozenge" for Lozenge migrations to enable safe staged rollout
+      if (options.isLozengeMigration) {
+        newAttributes.push('migration_fallback="lozenge"');
+      }
       const attributesText = newAttributes.length > 0 ? ` ${newAttributes.join(' ')}` : '';
       const children = node.children.length > 0 ? sourceCode.getText().slice(node.openingElement.range[1], node.closingElement ? node.closingElement.range[0] : node.range[1]) : '';
       const componentName = options.preserveComponentName ? node.openingElement.name.name : options.isAvatarTag ? 'AvatarTag' : 'Tag';

package/dist/es2019/rules/no-unsafe-design-token-usage/index.js

@@ -148,6 +148,14 @@ token('color.background.blanket');
             const {
               value
             } = node.arguments[0];
+
+            /**
+             * This check allows ADS tokens to be passed in via UNSAFE_ignoreTokens and allow fallbacks even if `fallbackUsage` is set to 'none'.
+             * Temporary solution introduced to allow fallbacks for shape tokens in Jira during migration
+             */
+            if (value && UNSAFE_ignoreTokens.has(value)) {
+              return;
+            }
             context.report({
               messageId: 'tokenFallbackRestricted',
               node: node.arguments[1],

package/dist/esm/rules/lozenge-badge-tag-labelling-system-migration/index.js

@@ -15,7 +15,7 @@ var rule = createLintRule({
     },
     messages: {
       updateAppearance: 'Update appearance value to new semantic value.',
-      migrateTag: 'Non-bold <Lozenge> variants should migrate to <Tag> component.',
+      migrateTag: 'Non-bold <Lozenge> variants should migrate to <Tag> component. For safe, staged rollout, use the `migration_fallback="lozenge"` prop which renders as Lozenge when the feature flag is off.',
       manualReview: "Dynamic 'isBold' props require manual review before migration.",
       dynamicLozengeAppearance: "Dynamic 'appearance' prop values require manual review before migrating to Tag. Please verify the appearance value and manually convert it to the appropriate color prop value.",
       updateBadgeAppearance: 'Update Badge appearance value "{{oldValue}}" to new semantic value "{{newValue}}".',
@@ -358,6 +358,11 @@ var rule = createLintRule({
       if (options.isSimpleTag || options.isLozengeMigration) {
         newAttributes.push('isRemovable={false}');
       }
+
+      // Add migration_fallback="lozenge" for Lozenge migrations to enable safe staged rollout
+      if (options.isLozengeMigration) {
+        newAttributes.push('migration_fallback="lozenge"');
+      }
       var attributesText = newAttributes.length > 0 ? " ".concat(newAttributes.join(' ')) : '';
       var children = node.children.length > 0 ? sourceCode.getText().slice(node.openingElement.range[1], node.closingElement ? node.closingElement.range[0] : node.range[1]) : '';
       var componentName = options.preserveComponentName ? node.openingElement.name.name : options.isAvatarTag ? 'AvatarTag' : 'Tag';

package/dist/esm/rules/no-unsafe-design-token-usage/index.js

@@ -129,6 +129,14 @@ var rule = createLintRule({
         } else if (node.arguments.length > 1 && config.fallbackUsage === 'none') {
           if (node.arguments[0].type === 'Literal') {
             var _value = node.arguments[0].value;
+
+            /**
+             * This check allows ADS tokens to be passed in via UNSAFE_ignoreTokens and allow fallbacks even if `fallbackUsage` is set to 'none'.
+             * Temporary solution introduced to allow fallbacks for shape tokens in Jira during migration
+             */
+            if (_value && UNSAFE_ignoreTokens.has(_value)) {
+              return;
+            }
             context.report({
               messageId: 'tokenFallbackRestricted',
               node: node.arguments[1],

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
 	"description": "The essential plugin for use with the Atlassian Design System.",
-	"version": "13.35.1",
+	"version": "13.36.1",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
 	"publishConfig": {
@@ -40,7 +40,7 @@
 	"dependencies": {
 		"@atlaskit/eslint-utils": "^2.0.0",
 		"@atlaskit/icon": "^30.0.0",
-		"@atlaskit/icon-lab": "^5.14.0",
+		"@atlaskit/icon-lab": "^5.15.0",
 		"@atlaskit/tokens": "^10.1.0",
 		"@babel/runtime": "^7.0.0",
 		"@typescript-eslint/utils": "^7.1.0",