@atlaskit/eslint-plugin-design-system 13.23.3 → 13.24.0

package/dist/esm/rules/lozenge-appearance-and-isbold-migration/index.js

@@ -0,0 +1,261 @@
+import { isNodeOfType } from 'eslint-codemod-utils';
+import { createLintRule } from '../utils/create-rule';
+var rule = createLintRule({
+  meta: {
+    name: 'lozenge-appearance-and-isbold-migration',
+    fixable: 'code',
+    type: 'suggestion',
+    docs: {
+      description: 'Helps migrate deprecated Lozenge usages to the new API or Tag component as part of the Labelling System Phase 1 migration.',
+      recommended: true,
+      severity: 'warn'
+    },
+    messages: {
+      replaceAppearance: "'appearance' prop on <Lozenge> is deprecated — use 'color' instead.",
+      migrateTag: 'Non-bold <Lozenge> variants should migrate to <Tag> component.',
+      manualReview: "Dynamic 'isBold' props require manual review before migration."
+    }
+  },
+  create: function create(context) {
+    /**
+     * Contains a map of imported Lozenge components.
+     */
+    var lozengeImports = {}; // local name -> import source
+    var tagImports = {}; // local name -> import source
+
+    /**
+     * Check if a JSX attribute value is a literal false
+     */
+    function isLiteralFalse(node) {
+      return node && node.type === 'JSXExpressionContainer' && node.expression && node.expression.type === 'Literal' && node.expression.value === false;
+    }
+
+    /**
+     * Check if a JSX attribute value is dynamic (not a literal boolean)
+     */
+    function isDynamicExpression(node) {
+      if (!node || node.type !== 'JSXExpressionContainer') {
+        return false;
+      }
+      var expr = node.expression;
+      return expr && !(expr.type === 'Literal' && typeof expr.value === 'boolean');
+    }
+
+    /**
+     * Get all attributes as an object for easier manipulation
+     */
+    function getAttributesMap(attributes) {
+      var map = {};
+      attributes.forEach(function (attr) {
+        if (attr.type === 'JSXAttribute' && attr.name.type === 'JSXIdentifier') {
+          map[attr.name.name] = attr;
+        }
+      });
+      return map;
+    }
+
+    /**
+     * Map Lozenge appearance values to Tag color values
+     */
+    function mapAppearanceToTagColor(appearanceValue) {
+      var mapping = {
+        success: 'lime',
+        default: 'standard',
+        removed: 'red',
+        inprogress: 'blue',
+        new: 'purple',
+        moved: 'orange'
+      };
+      return mapping[appearanceValue] || appearanceValue;
+    }
+
+    /**
+     * Map Lozenge appearance values to Lozenge color values
+     */
+    function mapAppearanceToLozengeColor(appearanceValue) {
+      var mapping = {
+        default: 'neutral',
+        inprogress: 'information',
+        moved: 'warning',
+        new: 'discovery',
+        removed: 'danger',
+        success: 'success'
+      };
+      return mapping[appearanceValue] || appearanceValue;
+    }
+
+    /**
+     * Extract the string value from a JSX attribute value
+     */
+    function extractStringValue(attrValue) {
+      if (!attrValue) {
+        return null;
+      }
+      if (attrValue.type === 'Literal') {
+        return attrValue.value;
+      }
+      if (attrValue.type === 'JSXExpressionContainer' && attrValue.expression && attrValue.expression.type === 'Literal') {
+        return attrValue.expression.value;
+      }
+      return null;
+    }
+
+    /**
+     * Generate the replacement JSX element text
+     */
+    function generateTagReplacement(node, lozengeLocalName) {
+      var sourceCode = context.getSourceCode();
+      var attributes = node.openingElement.attributes;
+
+      // Build new attributes array, excluding isBold and mapping appearance to color
+      var newAttributes = [];
+      attributes.forEach(function (attr) {
+        if (attr.type === 'JSXAttribute' && attr.name.type === 'JSXIdentifier') {
+          var attrName = attr.name.name;
+          if (attrName === 'isBold') {
+            // Skip isBold attribute
+            return;
+          }
+          if (attrName === 'appearance') {
+            // Map appearance to color with value transformation
+            var stringValue = extractStringValue(attr.value);
+            if (stringValue && typeof stringValue === 'string') {
+              var mappedColor = mapAppearanceToTagColor(stringValue);
+              newAttributes.push("color=\"".concat(mappedColor, "\""));
+            } else {
+              // If we can't extract the string value, keep as-is but rename to color
+              var value = attr.value ? sourceCode.getText(attr.value) : '';
+              newAttributes.push("color".concat(value ? "=".concat(value) : ''));
+            }
+            return;
+          }
+
+          // Keep all other attributes
+          newAttributes.push(sourceCode.getText(attr));
+        } else if (attr.type === 'JSXSpreadAttribute') {
+          // Keep spread attributes
+          newAttributes.push(sourceCode.getText(attr));
+        }
+      });
+      var attributesText = newAttributes.length > 0 ? " ".concat(newAttributes.join(' ')) : '';
+      var children = node.children.length > 0 ? sourceCode.getText().slice(node.openingElement.range[1], node.closingElement ? node.closingElement.range[0] : node.range[1]) : '';
+      if (node.closingElement) {
+        return "<Tag".concat(attributesText, ">").concat(children, "</Tag>");
+      } else {
+        return "<Tag".concat(attributesText, " />");
+      }
+    }
+    return {
+      ImportDeclaration: function ImportDeclaration(node) {
+        var moduleSource = node.source.value;
+        if (typeof moduleSource === 'string') {
+          // Track Lozenge imports
+          if (moduleSource === '@atlaskit/lozenge' || moduleSource.startsWith('@atlaskit/lozenge')) {
+            node.specifiers.forEach(function (spec) {
+              if (spec.type === 'ImportDefaultSpecifier') {
+                lozengeImports[spec.local.name] = moduleSource;
+              } else if (spec.type === 'ImportSpecifier' && spec.imported.type === 'Identifier') {
+                if (spec.imported.name === 'Lozenge') {
+                  lozengeImports[spec.local.name] = moduleSource;
+                }
+              }
+            });
+          }
+          // Track Tag imports
+          if (moduleSource === '@atlaskit/tag' || moduleSource.startsWith('@atlaskit/tag/')) {
+            node.specifiers.forEach(function (spec) {
+              if (spec.type === 'ImportDefaultSpecifier') {
+                tagImports[spec.local.name] = moduleSource;
+              } else if (spec.type === 'ImportSpecifier' && spec.imported.type === 'Identifier') {
+                if (spec.imported.name === 'Tag') {
+                  tagImports[spec.local.name] = moduleSource;
+                }
+              }
+            });
+          }
+        }
+      },
+      JSXElement: function JSXElement(node) {
+        if (!isNodeOfType(node, 'JSXElement')) {
+          return;
+        }
+        if (!isNodeOfType(node.openingElement.name, 'JSXIdentifier')) {
+          return;
+        }
+        var elementName = node.openingElement.name.name;
+
+        // Only process if this is a Lozenge component we've imported
+        if (!lozengeImports[elementName]) {
+          return;
+        }
+        var attributesMap = getAttributesMap(node.openingElement.attributes);
+        var appearanceProp = attributesMap.appearance;
+        var isBoldProp = attributesMap.isBold;
+
+        // Handle appearance prop migration
+        if (appearanceProp) {
+          context.report({
+            node: appearanceProp,
+            messageId: 'replaceAppearance',
+            fix: function fix(fixer) {
+              var fixes = [];
+              // Always rename the prop name
+              fixes.push(fixer.replaceText(appearanceProp.name, 'color'));
+
+              // Also map the value if it's a string literal and we're not migrating to Tag
+              var shouldMigrateToTag = !isBoldProp || isLiteralFalse(isBoldProp.value);
+              if (!shouldMigrateToTag) {
+                var stringValue = extractStringValue(appearanceProp.value);
+                if (stringValue && typeof stringValue === 'string') {
+                  var mappedColor = mapAppearanceToLozengeColor(stringValue);
+                  if (mappedColor !== stringValue) {
+                    // Update the value if it changed
+                    if (appearanceProp.value.type === 'Literal') {
+                      fixes.push(fixer.replaceText(appearanceProp.value, "\"".concat(mappedColor, "\"")));
+                    } else if (appearanceProp.value.type === 'JSXExpressionContainer' && appearanceProp.value.expression && appearanceProp.value.expression.type === 'Literal') {
+                      fixes.push(fixer.replaceText(appearanceProp.value.expression, "\"".concat(mappedColor, "\"")));
+                    }
+                  }
+                }
+              }
+              return fixes;
+            }
+          });
+        }
+
+        // Handle isBold prop and Tag migration
+        if (isBoldProp) {
+          if (isLiteralFalse(isBoldProp.value)) {
+            // isBold={false} should migrate to Tag
+            context.report({
+              node: node,
+              messageId: 'migrateTag',
+              fix: function fix(fixer) {
+                var replacement = generateTagReplacement(node, elementName);
+                return fixer.replaceText(node, replacement);
+              }
+            });
+          } else if (isDynamicExpression(isBoldProp.value)) {
+            // Dynamic isBold requires manual review
+            context.report({
+              node: isBoldProp,
+              messageId: 'manualReview'
+            });
+          }
+          // isBold={true} or isBold (implicit true) - no action needed
+        } else {
+          // No isBold prop means implicit false, should migrate to Tag
+          context.report({
+            node: node,
+            messageId: 'migrateTag',
+            fix: function fix(fixer) {
+              var replacement = generateTagReplacement(node, elementName);
+              return fixer.replaceText(node, replacement);
+            }
+          });
+        }
+      }
+    };
+  }
+});
+export default rule;

package/dist/esm/rules/no-deprecated-imports/handlers/icon.js

@@ -4,7 +4,7 @@ function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r)
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
 import { isNodeOfType, literal } from 'eslint-codemod-utils';
 import coreIconLabMetadata from '@atlaskit/icon-lab/metadata';
-import { coreIconMetadata, utilityIconMetadata } from '@atlaskit/icon/metadata';
+import { coreIconMetadata } from '@atlaskit/icon/metadata';
 import { pathWithCustomMessageId } from '../constants';
 /**
  * __Deprecation icon handler__
@@ -68,43 +68,42 @@ export var getDeprecationIconHandler = function getDeprecationIconHandler(contex
         importSource = _Object$entries$_i[0],
         error = _Object$entries$_i[1];
       if (importSource.includes('/migration/')) {
-        var _metadata$deprecatedI, _error$data;
+        var _coreIconMetadata$dep, _error$data;
         var _importSource$split$s = importSource.split('/').slice(1),
           _importSource$split$s2 = _slicedToArray(_importSource$split$s, 4),
           _location = _importSource$split$s2[0],
-          type = _importSource$split$s2[1],
+          _ = _importSource$split$s2[1],
           _migration = _importSource$split$s2[2],
           name = _importSource$split$s2[3];
-        var metadata = type === 'core' ? coreIconMetadata : utilityIconMetadata;
         var _name$split = name.split('--'),
           _name$split2 = _slicedToArray(_name$split, 2),
           deprecatedIconName = _name$split2[0],
           legacyIconName = _name$split2[1];
-        var replacement = metadata === null || metadata === void 0 || (_metadata$deprecatedI = metadata[deprecatedIconName]) === null || _metadata$deprecatedI === void 0 ? void 0 : _metadata$deprecatedI.replacement;
+        var replacement = (_coreIconMetadata$dep = coreIconMetadata[deprecatedIconName]) === null || _coreIconMetadata$dep === void 0 ? void 0 : _coreIconMetadata$dep.replacement;
         if (replacement && ((_error$data = error.data) === null || _error$data === void 0 ? void 0 : _error$data.unfixable) === 'false') {
           var newIconName = getIconComponentName(replacement.name);
           if (!shouldTurnOffAutoFixer) {
-            addAutoFix(error, importSource, "".concat(replacement.location, "/").concat(replacement.type, "/migration/").concat(replacement.name, "--").concat(legacyIconName), newIconName);
+            addAutoFix(error, importSource, "".concat(replacement.location, "/core/migration/").concat(replacement.name, "--").concat(legacyIconName), newIconName);
           }
         }
       } else {
-        var _metadata2;
+        var _metadata;
         var _importSource$split$s3 = importSource.split('/').slice(1),
           _importSource$split$s4 = _slicedToArray(_importSource$split$s3, 3),
           location = _importSource$split$s4[0],
-          _type = _importSource$split$s4[1],
+          _2 = _importSource$split$s4[1],
           _name = _importSource$split$s4[2];
-        var _metadata = void 0;
+        var metadata = void 0;
         if (location === 'icon') {
-          _metadata = _type === 'core' ? coreIconMetadata : utilityIconMetadata;
+          metadata = coreIconMetadata;
         } else if (location === 'icon-lab') {
-          _metadata = coreIconLabMetadata;
+          metadata = coreIconLabMetadata;
         }
-        var _replacement = (_metadata2 = _metadata) === null || _metadata2 === void 0 || (_metadata2 = _metadata2[_name]) === null || _metadata2 === void 0 ? void 0 : _metadata2.replacement;
+        var _replacement = (_metadata = metadata) === null || _metadata === void 0 || (_metadata = _metadata[_name]) === null || _metadata === void 0 ? void 0 : _metadata.replacement;
         if (_replacement) {
           var _newIconName = getIconComponentName(_replacement.name);
           if (!shouldTurnOffAutoFixer) {
-            addAutoFix(error, importSource, "".concat(_replacement.location, "/").concat(_replacement.type, "/").concat(_replacement.name), _newIconName);
+            addAutoFix(error, importSource, "".concat(_replacement.location, "/core/").concat(_replacement.name), _newIconName);
           }
         }
       }

package/dist/esm/rules/no-legacy-icons/helpers.js

@@ -71,10 +71,10 @@ var getNewIconNameAndImportPath = function getNewIconNameAndImportPath(iconPacka
     return {};
   }
   var newIcon = migrationMapObject.newIcon;
-  var migrationPath = newIcon.name === legacyIconName ? "".concat(newIcon.package, "/").concat(newIcon.type, "/migration/").concat(newIcon.name) : "".concat(newIcon.package, "/").concat(newIcon.type, "/migration/").concat(newIcon.name, "--").concat(legacyIconName.replaceAll('/', '-'));
+  var migrationPath = newIcon.name === legacyIconName ? "".concat(newIcon.package, "/core/migration/").concat(newIcon.name) : "".concat(newIcon.package, "/core/migration/").concat(newIcon.name, "--").concat(legacyIconName.replaceAll('/', '-'));
   return {
     iconName: newIcon.name,
-    importPath: shouldUseMigrationPath ? migrationPath : "".concat(newIcon.package, "/").concat(newIcon.type, "/").concat(newIcon.name)
+    importPath: shouldUseMigrationPath ? migrationPath : "".concat(newIcon.package, "/core/").concat(newIcon.name)
   };
 };
 

package/dist/esm/rules/utils/get-deprecated-config.js

@@ -4,13 +4,13 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import fs from 'fs';
 import path from 'path';
 import { deprecatedCore as deprecatedIconLabCore, deprecatedUtility as deprecatedIconLabUtility } from '@atlaskit/icon-lab/deprecated-map';
-import { deprecatedCore as deprecatedIconCore, deprecatedUtility as deprecatedIconUtility } from '@atlaskit/icon/deprecated-map';
+import { deprecatedCore as deprecatedIconCore } from '@atlaskit/icon/deprecated-map';
 export var getConfig = function getConfig(specifier) {
   var configPath = path.resolve(__dirname, '..', '..', '..', 'configs', 'deprecated.json');
   var source = fs.readFileSync(configPath, 'utf8');
   var parsedConfig = JSON.parse(source);
   var combinedConfig = _objectSpread(_objectSpread({}, parsedConfig), {}, {
-    imports: _objectSpread(_objectSpread(_objectSpread(_objectSpread(_objectSpread({}, parsedConfig.imports), deprecatedIconCore), deprecatedIconUtility), deprecatedIconLabCore), deprecatedIconLabUtility)
+    imports: _objectSpread(_objectSpread(_objectSpread(_objectSpread({}, parsedConfig.imports), deprecatedIconCore), deprecatedIconLabCore), deprecatedIconLabUtility)
   });
   return combinedConfig[specifier];
 };

package/dist/types/presets/all-flat.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::5aac2d8dc7c2832bcb8a96a143d60db5>>
+ * @codegen <<SignedSource::7fae089db9d7d7153fea58c673bd56af>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { Linter } from 'eslint';

package/dist/types/presets/all.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::43ea4411c4e338a916772d4bfda146cc>>
+ * @codegen <<SignedSource::655d7f24171da0dff60003d0f235e48a>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { ESLint } from 'eslint';

package/dist/types/presets/recommended-flat.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::3328b9c675a0d09876dcfbc5d29bc63f>>
+ * @codegen <<SignedSource::44a03b30a12e3b52d720c16785c9c649>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { Linter } from 'eslint';

package/dist/types/presets/recommended.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::b28f895280627b7a35f059f90783644a>>
+ * @codegen <<SignedSource::0311febdad396820af1b01dd2825b63f>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { ESLint } from 'eslint';

package/dist/types/rules/index.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::732bff0fc39d7ff05b6688694101698d>>
+ * @codegen <<SignedSource::75f94fc6b6fa998eed54b610e41bb9b1>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { Rule } from 'eslint';

package/dist/types/rules/lozenge-appearance-and-isbold-migration/index.d.ts

@@ -0,0 +1,2 @@
+declare const rule: import("eslint").Rule.RuleModule;
+export default rule;

package/dist/types/rules/no-legacy-icons/helpers.d.ts

@@ -46,14 +46,12 @@ export declare const isSize: (size: any) => size is Size;
 export declare const getMigrationMapObject: (iconPackage: string) => {
     newIcon?: {
         name: string;
-        type: string;
         package: string;
         isMigrationUnsafe?: boolean;
         shouldForceSmallIcon?: boolean;
     };
     additionalIcons?: {
         name: string;
-        type: string;
         package: string;
     }[];
     sizeGuidance: Record<import("@atlaskit/icon").Size, IconMigrationSizeGuidance>;

package/dist/types-ts4.5/presets/all-flat.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::5aac2d8dc7c2832bcb8a96a143d60db5>>
+ * @codegen <<SignedSource::7fae089db9d7d7153fea58c673bd56af>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { Linter } from 'eslint';

package/dist/types-ts4.5/presets/all.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::43ea4411c4e338a916772d4bfda146cc>>
+ * @codegen <<SignedSource::655d7f24171da0dff60003d0f235e48a>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { ESLint } from 'eslint';

package/dist/types-ts4.5/presets/recommended-flat.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::3328b9c675a0d09876dcfbc5d29bc63f>>
+ * @codegen <<SignedSource::44a03b30a12e3b52d720c16785c9c649>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { Linter } from 'eslint';

package/dist/types-ts4.5/presets/recommended.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::b28f895280627b7a35f059f90783644a>>
+ * @codegen <<SignedSource::0311febdad396820af1b01dd2825b63f>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { ESLint } from 'eslint';

package/dist/types-ts4.5/rules/index.codegen.d.ts

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::732bff0fc39d7ff05b6688694101698d>>
+ * @codegen <<SignedSource::75f94fc6b6fa998eed54b610e41bb9b1>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 import type { Rule } from 'eslint';

package/dist/types-ts4.5/rules/lozenge-appearance-and-isbold-migration/index.d.ts

@@ -0,0 +1,2 @@
+declare const rule: import("eslint").Rule.RuleModule;
+export default rule;

package/dist/types-ts4.5/rules/no-legacy-icons/helpers.d.ts

@@ -51,14 +51,12 @@ export declare const isSize: (size: any) => size is Size;
 export declare const getMigrationMapObject: (iconPackage: string) => {
     newIcon?: {
         name: string;
-        type: string;
         package: string;
         isMigrationUnsafe?: boolean;
         shouldForceSmallIcon?: boolean;
     };
     additionalIcons?: {
         name: string;
-        type: string;
         package: string;
     }[];
     sizeGuidance: Record<import("@atlaskit/icon").Size, IconMigrationSizeGuidance>;

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
 	"description": "The essential plugin for use with the Atlassian Design System.",
-	"version": "13.23.3",
+	"version": "13.24.0",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
 	"publishConfig": {
@@ -39,8 +39,8 @@
 	},
 	"dependencies": {
 		"@atlaskit/eslint-utils": "^2.0.0",
-		"@atlaskit/icon": "^28.5.0",
-		"@atlaskit/icon-lab": "^5.11.0",
+		"@atlaskit/icon": "^29.0.0",
+		"@atlaskit/icon-lab": "^5.12.0",
 		"@atlaskit/tokens": "^8.0.0",
 		"@babel/runtime": "^7.0.0",
 		"@typescript-eslint/utils": "^7.1.0",