@atlaskit/eslint-plugin-design-system 13.19.3 → 13.19.5

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 13.19.5
+
+### Patch Changes
+
+- Updated dependencies
+
+## 13.19.4
+
+### Patch Changes
+
+- [#198800](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/198800)
+  [`b57fbbece226f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b57fbbece226f) -
+  Fixed some false positives in @atlaskit/design-system/use-modal-dialog-close-button ESLint rule
+
 ## 13.19.3
 
 ### Patch Changes

package/dist/cjs/ast-nodes/import.js

@@ -43,7 +43,7 @@ var Import = exports.Import = {
       if (!(0, _eslintCodemodUtils.isNodeOfType)(specifier, 'ImportSpecifier')) {
         return false;
       }
-      return specifier.imported.name === name;
+      return specifier.imported.type === 'Identifier' && specifier.imported.name === name;
     });
   }
 };

package/dist/cjs/rules/enforce-inline-styles-in-select/utils.js

@@ -5,6 +5,13 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.checkStylesObject = checkStylesObject;
 var _eslintCodemodUtils = require("eslint-codemod-utils");
+var getScope = function getScope(context, node) {
+  if ('getScope' in context.sourceCode) {
+    return context.sourceCode.getScope(node);
+  }
+  // this is needed for jira's eslint update, as otherwise there is type errors only in jira typechecking
+  return context.getScope(node);
+};
 var unsupportedSelectors = [':',
 // pseudo-classes/elements
 '[',
@@ -91,7 +98,7 @@ function checkSpreadElement(node, spreadElement, context) {
 
   // Handle direct identifier (e.g., ...styles)
   if ((0, _eslintCodemodUtils.isNodeOfType)(argument, 'Identifier')) {
-    var scope = context.getScope();
+    var scope = getScope(context, argument);
     var variable = null;
     var currentScope = scope;
 
@@ -210,7 +217,7 @@ function checkStylesObject(node, stylesValue, context) {
     });
   } else if ((0, _eslintCodemodUtils.isNodeOfType)(stylesValue, 'Identifier')) {
     // track the variable
-    var scope = context.getScope();
+    var scope = getScope(context, stylesValue);
     var variable = null;
     var currentScope = scope;
 

package/dist/cjs/rules/ensure-design-token-usage/utils.js

@@ -169,7 +169,7 @@ var getValueFromIdentifier = function getValueFromIdentifier(node, context) {
   }
   var definition = variable.defs[0];
   if ((0, _eslintCodemodUtils.isNodeOfType)(definition.node, 'ImportSpecifier') && (0, _eslintCodemodUtils.isNodeOfType)(definition.node.parent, 'ImportDeclaration') && definition.node.parent.source.value === '@atlassian/jira-common-styles/src/main.tsx') {
-    return definition.node.imported.name === 'gridSize' ? 8 : null;
+    return definition.node.imported.type === 'Identifier' && definition.node.imported.name === 'gridSize' ? 8 : null;
   }
   if (!(0, _eslintCodemodUtils.isNodeOfType)(definition.node, 'VariableDeclarator')) {
     return null;

package/dist/cjs/rules/ensure-proper-xcss-usage/index.js

@@ -43,16 +43,18 @@ var rule = (0, _createRule.createLintRule)({
           // Handle different import sources
           switch (source) {
             case '@atlaskit/primitives/compiled':
-              tracker.compiledComponents.add(specifier.imported.name);
+              if (specifier.imported.type === 'Identifier') {
+                tracker.compiledComponents.add(specifier.imported.name);
+              }
               break;
             case '@atlaskit/primitives':
-              if (specifier.imported.name === 'xcss') {
+              if (specifier.imported.type === 'Identifier' && specifier.imported.name === 'xcss') {
                 tracker.xcssFunction.add(specifier.local.name);
               }
               break;
             case '@atlaskit/css':
             case '@compiled/react':
-              if (specifier.imported.name === 'cssMap') {
+              if (specifier.imported.type === 'Identifier' && specifier.imported.name === 'cssMap') {
                 tracker.cssMapFunction.add(specifier.local.name);
               }
               break;

package/dist/cjs/rules/no-deprecated-imports/checks.js

@@ -120,7 +120,7 @@ var createChecks = exports.createChecks = function createChecks(context) {
           } else if (specifier.type === 'ImportNamespaceSpecifier') {
             name = '*';
           } else if (specifier.type === 'ImportSpecifier') {
-            name = specifier.imported.name;
+            name = specifier.imported.type === 'Identifier' ? specifier.imported.name : '';
           }
           if (name) {
             importNames.set(name, specifier);
@@ -160,7 +160,7 @@ var createChecks = exports.createChecks = function createChecks(context) {
           var specifier = _step2.value;
           var name = void 0;
           if (specifier.local) {
-            name = specifier.local.name;
+            name = specifier.local.type === 'Identifier' ? specifier.local.name : '';
           }
           if (name) {
             importNames.set(name, specifier);

package/dist/cjs/rules/no-html-anchor/node-types/jsx-element/index.js

@@ -55,7 +55,7 @@ var JSXElement = exports.JSXElement = {
           }
         } else if (declaration.source.value === '@atlaskit/button/new') {
           var namedSpecifier = declaration.specifiers.find(function (specifier) {
-            return specifier.type === 'ImportSpecifier' && specifier.imported.name === 'LinkButton';
+            return specifier.type === 'ImportSpecifier' && specifier.imported.type === 'Identifier' && specifier.imported.name === 'LinkButton';
           });
           if (namedSpecifier) {
             existingLinkButtonName = namedSpecifier.local.name;

package/dist/cjs/rules/no-html-code/node-types/jsx-element/index.js

@@ -50,7 +50,7 @@ var JSXElement = exports.JSXElement = {
           declaration.specifiers.filter(function (specifier) {
             return (0, _eslintCodemodUtils.isNodeOfType)(specifier, 'ImportSpecifier') && (0, _eslintCodemodUtils.isNodeOfType)(specifier.parent, 'ImportDeclaration');
           }).forEach(function (specifier) {
-            if ((0, _eslintCodemodUtils.isNodeOfType)(specifier, 'ImportSpecifier') && specifier.imported.name === 'Code') {
+            if ((0, _eslintCodemodUtils.isNodeOfType)(specifier, 'ImportSpecifier') && specifier.imported.type === 'Identifier' && specifier.imported.name === 'Code') {
               existingCodeName = specifier.local.name;
             }
           });

package/dist/cjs/rules/no-invalid-css-map/utils.js

@@ -65,6 +65,7 @@ var CssMapObjectChecker = exports.CssMapObjectChecker = /*#__PURE__*/function ()
           messageId: 'noInlineFunctions'
         });
       } else if (value.type === 'BinaryExpression' || value.type === 'LogicalExpression') {
+        // @ts-ignore -- this needs to be `ts-ignore` because this only errors in jira's typechecking due to update, not platform's
         this.checkCssMapObjectValue(value.left);
         this.checkCssMapObjectValue(value.right);
       } else if (value.type === 'Identifier') {

package/dist/cjs/rules/no-legacy-icons/checks.js

@@ -89,7 +89,7 @@ var createChecks = exports.createChecks = function createChecks(context) {
           var _spec = _step2.value;
           if (_spec.type === 'ImportDefaultSpecifier') {
             newButtonImports.add(_spec.local.name);
-          } else if (_spec.type === 'ImportSpecifier' && _spec.imported.name === 'IconButton') {
+          } else if (_spec.type === 'ImportSpecifier' && 'name' in _spec.imported && _spec.imported.name === 'IconButton') {
             newButtonImports.add(_spec.local.name);
           }
         }
@@ -192,12 +192,14 @@ var createChecks = exports.createChecks = function createChecks(context) {
         try {
           for (_iterator5.s(); !(_step5 = _iterator5.n()).done;) {
             var spec = _step5.value;
-            (0, _helpers.createCantMigrateReExportError)(spec, moduleSource, spec.exported.name, errorsManual);
-            (0, _helpers.addToListOfRanges)(spec, errorRanges);
-            guidance[(0, _helpers.locToString)(spec)] = (0, _helpers.createGuidance)({
-              iconPackage: moduleSource,
-              shouldUseMigrationPath: shouldUseMigrationPath
-            });
+            if ('name' in spec.exported) {
+              (0, _helpers.createCantMigrateReExportError)(spec, moduleSource, spec.exported.name, errorsManual);
+              (0, _helpers.addToListOfRanges)(spec, errorRanges);
+              guidance[(0, _helpers.locToString)(spec)] = (0, _helpers.createGuidance)({
+                iconPackage: moduleSource,
+                shouldUseMigrationPath: shouldUseMigrationPath
+              });
+            }
           }
         } catch (err) {
           _iterator5.e(err);
@@ -238,7 +240,7 @@ var createChecks = exports.createChecks = function createChecks(context) {
       try {
         for (_iterator7.s(); !(_step7 = _iterator7.n()).done;) {
           var _spec3 = _step7.value;
-          if (Object.keys(legacyIconImports).includes(_spec3.local.name)) {
+          if ('name' in _spec3.local && 'name' in _spec3.exported && Object.keys(legacyIconImports).includes(_spec3.local.name)) {
             //update legacy imports to be exported
             legacyIconImports[_spec3.local.name] = {
               packageName: legacyIconImports[_spec3.local.name].packageName,

package/dist/cjs/rules/no-nested-styles/index.js

@@ -31,7 +31,7 @@ var isMediaObject = function isMediaObject(node, context) {
       // Make sure it's coming from the primitives packages and isn't a bootleg media query or worse: nested styles
       if ((0, _eslintCodemodUtils.isNodeOfType)(definition.node, 'ImportSpecifier') && definition.node.parent && (0, _eslintCodemodUtils.isNodeOfType)(definition.node.parent, 'ImportDeclaration') && allowedResponsiveImports.includes(definition.node.parent.source.value)) {
         // This should match the name of the media object exported from packages/design-system/primitives/src/responsive/media-helper.tsx
-        return definition.node.imported.name === 'media';
+        return definition.node.imported.type === 'Identifier' && definition.node.imported.name === 'media';
       }
     }
   }

package/dist/cjs/rules/no-separator-with-list-elements/index.js

@@ -26,7 +26,7 @@ var rule = (0, _createRule.createLintRule)({
       ImportDeclaration: function ImportDeclaration(node) {
         if (node.type === 'ImportDeclaration' && (node.source.value === '../src' || node.source.value === '@atlaskit/primitives')) {
           node.specifiers.forEach(function (specifier) {
-            if (specifier.type === 'ImportSpecifier' && specifier.imported.name === 'Inline') {
+            if (specifier.type === 'ImportSpecifier' && 'name' in specifier.imported && specifier.imported.name === 'Inline') {
               inlineComponentNames.push(specifier.local.name);
             }
           });

package/dist/cjs/rules/use-button-group-label/index.js

@@ -32,8 +32,9 @@ var rule = (0, _createRule.createLintRule)({
         var buttonGroupIdentifier = (_node$specifiers = node.specifiers) === null || _node$specifiers === void 0 ? void 0 : _node$specifiers.filter(function (spec) {
           if (node.source.value === '@atlaskit/button') {
             var _spec$imported;
-            return spec.type === 'ImportSpecifier' && ((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name) === 'ButtonGroup';
-          } else if (node.source.value === '@atlaskit/button/button-group') {
+            return spec.type === 'ImportSpecifier' && 'name' in spec.imported && ((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name) === 'ButtonGroup';
+          }
+          if (node.source.value === '@atlaskit/button/button-group') {
             return spec.type === 'ImportDefaultSpecifier';
           }
         });

package/dist/cjs/rules/use-correct-field/index.js

@@ -67,13 +67,13 @@ var rule = (0, _createRule.createLintRule)({
             specialFieldsByImport[source].local = defaultImport[0].local.name;
           }
         }
-        if ('@atlaskit/form' !== source) {
+        if (source !== '@atlaskit/form') {
           return;
         }
         var namedImport = node.specifiers.filter(function (spec) {
           return (0, _eslintCodemodUtils.isNodeOfType)(spec, 'ImportSpecifier');
         });
-        if (namedImport.length && namedImport[0].type === 'ImportSpecifier' && namedImport[0].imported.name === 'Field') {
+        if (namedImport.length && namedImport[0].type === 'ImportSpecifier' && 'name' in namedImport[0].imported && namedImport[0].imported.name === 'Field') {
           fieldImport = namedImport[0].local;
         }
       },

package/dist/cjs/rules/use-cx-function-in-xcss/index.js

@@ -37,7 +37,7 @@ var rule = (0, _createRule.createLintRule)({
         try {
           for (_iterator.s(); !(_step = _iterator.n()).done;) {
             var specifier = _step.value;
-            if (specifier.type === 'ImportSpecifier' && specifier.imported.name === 'cx') {
+            if (specifier.type === 'ImportSpecifier' && 'name' in specifier.imported && specifier.imported.name === 'cx') {
               importStatement.cxFuncLocalName = specifier.local.name;
             }
           }

package/dist/cjs/rules/use-datetime-picker-calendar-button/index.js

@@ -148,14 +148,16 @@ var rule = (0, _createRule.createLintRule)({
         var datetimePickerIdentifier = (_node$specifiers = node.specifiers) === null || _node$specifiers === void 0 ? void 0 : _node$specifiers.filter(function (spec) {
           if (node.source.value === '@atlaskit/datetime-picker') {
             var _spec$imported;
-            return (0, _eslintCodemodUtils.isNodeOfType)(spec, 'ImportSpecifier') && [DATE_PICKER, DATETIME_PICKER].includes((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name);
+            return (0, _eslintCodemodUtils.isNodeOfType)(spec, 'ImportSpecifier') && 'name' in spec.imported && [DATE_PICKER, DATETIME_PICKER].includes((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name);
           }
         });
         datetimePickerIdentifier.forEach(function (identifier) {
-          var imported = identifier.imported,
-            local = identifier.local;
-          contextLocalIdentifier.push(local.name);
-          contextImportedIdentifier.push(imported.name);
+          if ('name' in identifier.imported) {
+            var imported = identifier.imported,
+              local = identifier.local;
+            contextLocalIdentifier.push(local.name);
+            contextImportedIdentifier.push(imported.name);
+          }
         });
       },
       JSXElement: function JSXElement(node) {

package/dist/cjs/rules/use-menu-section-title/index.js

@@ -32,8 +32,9 @@ var rule = (0, _createRule.createLintRule)({
         var menuSectionIdentifier = (_node$specifiers = node.specifiers) === null || _node$specifiers === void 0 ? void 0 : _node$specifiers.filter(function (spec) {
           if (node.source.value === '@atlaskit/menu') {
             var _spec$imported;
-            return spec.type === 'ImportSpecifier' && ((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name) === 'Section';
-          } else if (node.source.value === '@atlaskit/menu/section') {
+            return spec.type === 'ImportSpecifier' && 'name' in spec.imported && ((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name) === 'Section';
+          }
+          if (node.source.value === '@atlaskit/menu/section') {
             return spec.type === 'ImportDefaultSpecifier';
           }
         });

package/dist/cjs/rules/use-modal-dialog-close-button/index.js

@@ -53,7 +53,7 @@ var rule = (0, _createRule.createLintRule)({
         node.specifiers.forEach(function (identifier) {
           if ((0, _eslintCodemodUtils.isNodeOfType)(identifier, 'ImportDefaultSpecifier')) {
             defaultImportLocalName = identifier.local.name;
-          } else if ((0, _eslintCodemodUtils.isNodeOfType)(identifier, 'ImportSpecifier')) {
+          } else if ((0, _eslintCodemodUtils.isNodeOfType)(identifier, 'ImportSpecifier') && 'name' in identifier.imported) {
             var importName = identifier.imported.name;
             var localName = identifier.local.name;
             if (importName === 'ModalHeader') {
@@ -82,20 +82,29 @@ var rule = (0, _createRule.createLintRule)({
             return;
           }
 
-          // Add expression conatiner's body if an expression container
+          // Add expression container's body if an expression container
           if ((0, _eslintCodemodUtils.isNodeOfType)(node, 'JSXExpressionContainer')) {
-            if (((0, _eslintCodemodUtils.isNodeOfType)(node.expression, 'ArrowFunctionExpression') || (0, _eslintCodemodUtils.isNodeOfType)(node.expression, 'FunctionExpression')) && (0, _eslintCodemodUtils.isNodeOfType)(node.expression.body, 'JSXElement')) {
-              searchNode(node.expression.body, true);
-            } else if ((0, _eslintCodemodUtils.isNodeOfType)(node.expression, 'LogicalExpression')) {
-              var _node$expression = node.expression,
-                left = _node$expression.left,
-                right = _node$expression.right;
+            var expression = node.expression;
+            if ((0, _eslintCodemodUtils.isNodeOfType)(expression, 'ArrowFunctionExpression') || (0, _eslintCodemodUtils.isNodeOfType)(expression, 'FunctionExpression')) {
+              if ((0, _eslintCodemodUtils.isNodeOfType)(expression.body, 'JSXElement') || (0, _eslintCodemodUtils.isNodeOfType)(expression.body, 'JSXFragment')) {
+                searchExpression(expression.body);
+              } else if ((0, _eslintCodemodUtils.isNodeOfType)(expression.body, 'BlockStatement')) {
+                expression.body.body.forEach(function (statement) {
+                  if ((0, _eslintCodemodUtils.isNodeOfType)(statement, 'ReturnStatement') && statement.argument) {
+                    searchExpression(statement.argument);
+                  }
+                });
+              }
+            } else if ((0, _eslintCodemodUtils.isNodeOfType)(expression, 'LogicalExpression')) {
+              var left = expression.left,
+                right = expression.right;
               [left, right].forEach(function (e) {
-                if ((0, _eslintCodemodUtils.isNodeOfType)(e, 'JSXElement')) {
-                  searchNode(e, true);
-                }
+                searchExpression(e);
               });
+            } else {
+              searchExpression(expression);
             }
+            return;
           }
 
           // Skip if not a JSX Element
@@ -118,6 +127,13 @@ var rule = (0, _createRule.createLintRule)({
             searchNode(node);
           }
         };
+        var searchExpression = function searchExpression(expression) {
+          if ((0, _eslintCodemodUtils.isNodeOfType)(expression, 'JSXElement')) {
+            searchNode(expression, true);
+          } else if ((0, _eslintCodemodUtils.isNodeOfType)(expression, 'JSXFragment')) {
+            searchJSXFragment(expression);
+          }
+        };
         var searchNode = function searchNode(node) {
           var searchSelf = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : false;
           if (searchSelf) {
@@ -136,6 +152,22 @@ var rule = (0, _createRule.createLintRule)({
             _iterator.f();
           }
         };
+        var searchJSXFragment = function searchJSXFragment(node) {
+          if ((0, _eslintCodemodUtils.isNodeOfType)(node, 'JSXFragment')) {
+            var _iterator2 = _createForOfIteratorHelper(node.children),
+              _step2;
+            try {
+              for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
+                var child = _step2.value;
+                checkNode(child);
+              }
+            } catch (err) {
+              _iterator2.e(err);
+            } finally {
+              _iterator2.f();
+            }
+          }
+        };
         if (name === defaultImportLocalName) {
           searchNode(node);
 

package/dist/cjs/rules/use-onboarding-spotlight-label/index.js

@@ -33,8 +33,9 @@ var rule = (0, _createRule.createLintRule)({
         var buttonGroupIdentifier = (_node$specifiers = node.specifiers) === null || _node$specifiers === void 0 ? void 0 : _node$specifiers.filter(function (spec) {
           if (node.source.value === '@atlaskit/onboarding') {
             var _spec$imported;
-            return spec.type === 'ImportSpecifier' && ((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name) === 'Spotlight';
-          } else if (node.source.value === '@atlaskit/onboarding/spotlight') {
+            return spec.type === 'ImportSpecifier' && 'name' in spec.imported && ((_spec$imported = spec.imported) === null || _spec$imported === void 0 ? void 0 : _spec$imported.name) === 'Spotlight';
+          }
+          if (node.source.value === '@atlaskit/onboarding/spotlight') {
             return spec.type === 'ImportDefaultSpecifier';
           }
         });

package/dist/cjs/rules/use-should-render-to-parent/index.js

@@ -54,7 +54,7 @@ var rule = (0, _createRule.createLintRule)({
         if (defaultImport.length && defaultImport[0].local) {
           componentLocalName = defaultImport[0].local.name;
           // or if popup and using a named import
-        } else if (namedImport.length && namedImport[0].type === 'ImportSpecifier' && namedImport[0].imported.name === 'Popup') {
+        } else if (namedImport.length && namedImport[0].type === 'ImportSpecifier' && 'name' in namedImport[0].imported && namedImport[0].imported.name === 'Popup') {
           componentLocalName = namedImport[0].local.name;
         }
       },

package/dist/cjs/rules/use-tokens-typography/transformers/style-object.js

@@ -247,7 +247,7 @@ var StyleObject = exports.StyleObject = {
         if (!(0, _eslintCodemodUtils.isNodeOfType)(specifier, 'ImportSpecifier')) {
           return false;
         }
-        if (specifier.imported.name === 'fontFallback') {
+        if ('name' in specifier.imported && specifier.imported.name === 'fontFallback') {
           return true;
         }
         return false;

package/dist/cjs/rules/use-visually-hidden/index.js

@@ -41,7 +41,7 @@ var rule = (0, _createRule.createLintRule)({
         var visuallyHiddenOrAssistive = node.specifiers.filter(function (specifier) {
           return specifier.type === 'ImportSpecifier';
         }).find(function (specifier) {
-          return THEME_IMPORT_NAMES.includes(specifier.imported.name);
+          return 'name' in specifier.imported && THEME_IMPORT_NAMES.includes(specifier.imported.name);
         });
         if (!visuallyHiddenOrAssistive) {
           return;

package/dist/cjs/rules/utils/create-no-exported-rule/is-styled-component.js

@@ -51,7 +51,7 @@ var getStyledImportSpecifierName = function getStyledImportSpecifierName(context
   var _supportedImport$spec;
   var supportedImport = (0, _getFirstSupportedImport.getFirstSupportedImport)(context, importSources);
   return supportedImport === null || supportedImport === void 0 || (_supportedImport$spec = supportedImport.specifiers.find(function (spec) {
-    return spec.type === 'ImportSpecifier' && spec.imported.name === 'styled' || spec.type === 'ImportDefaultSpecifier' && spec.local.name === 'styled';
+    return spec.type === 'ImportSpecifier' && 'name' in spec.imported && spec.imported.name === 'styled' || spec.type === 'ImportDefaultSpecifier' && spec.local.name === 'styled';
   })) === null || _supportedImport$spec === void 0 ? void 0 : _supportedImport$spec.local.name;
 };
 

package/dist/cjs/rules/utils/get-import-name.js

@@ -15,7 +15,7 @@ var getImportName = exports.getImportName = function getImportName(scope, packag
       if (!def || !def.node || !(0, _eslintCodemodUtils.isNodeOfType)(def.node, 'ImportSpecifier') || !def.parent || !(0, _eslintCodemodUtils.isNodeOfType)(def.parent, 'ImportDeclaration')) {
         return;
       }
-      return def.parent.source.value === packageName && def.node.imported.name === componentName;
+      return def.parent.source.value === packageName && 'name' in def.node.imported && def.node.imported.name === componentName;
     });
     if (matchedVariable) {
       break;
@@ -24,7 +24,6 @@ var getImportName = exports.getImportName = function getImportName(scope, packag
   }
   if (!matchedVariable) {
     return null;
-  } else {
-    return matchedVariable.defs[0].node.local.name;
   }
+  return matchedVariable.defs[0].node.local.name;
 };

package/dist/cjs/rules/utils/get-import-node-by-source.js

@@ -43,7 +43,7 @@ var getModuleOfIdentifier = exports.getModuleOfIdentifier = function getModuleOf
                 importName: identifierName
               };
             }
-            if (spec.type === 'ImportSpecifier' && spec.local.name === identifierName) {
+            if (spec.type === 'ImportSpecifier' && 'name' in spec.imported && spec.local.name === identifierName) {
               return {
                 moduleName: node.source.value + '',
                 importName: spec.imported.name

package/dist/es2019/ast-nodes/import.js

@@ -36,7 +36,7 @@ export const Import = {
       if (!isNodeOfType(specifier, 'ImportSpecifier')) {
         return false;
       }
-      return specifier.imported.name === name;
+      return specifier.imported.type === 'Identifier' && specifier.imported.name === name;
     });
   }
 };

package/dist/es2019/rules/enforce-inline-styles-in-select/utils.js

@@ -1,4 +1,11 @@
 import { isNodeOfType } from 'eslint-codemod-utils';
+const getScope = (context, node) => {
+  if ('getScope' in context.sourceCode) {
+    return context.sourceCode.getScope(node);
+  }
+  // this is needed for jira's eslint update, as otherwise there is type errors only in jira typechecking
+  return context.getScope(node);
+};
 const unsupportedSelectors = [':',
 // pseudo-classes/elements
 '[',
@@ -83,7 +90,7 @@ function checkSpreadElement(node, spreadElement, context) {
 
   // Handle direct identifier (e.g., ...styles)
   if (isNodeOfType(argument, 'Identifier')) {
-    const scope = context.getScope();
+    const scope = getScope(context, argument);
     let variable = null;
     let currentScope = scope;
 
@@ -198,7 +205,7 @@ export function checkStylesObject(node, stylesValue, context) {
     });
   } else if (isNodeOfType(stylesValue, 'Identifier')) {
     // track the variable
-    const scope = context.getScope();
+    const scope = getScope(context, stylesValue);
     let variable = null;
     let currentScope = scope;
 

package/dist/es2019/rules/ensure-design-token-usage/utils.js

@@ -128,7 +128,7 @@ const getValueFromIdentifier = (node, context) => {
   }
   const definition = variable.defs[0];
   if (isNodeOfType(definition.node, 'ImportSpecifier') && isNodeOfType(definition.node.parent, 'ImportDeclaration') && definition.node.parent.source.value === '@atlassian/jira-common-styles/src/main.tsx') {
-    return definition.node.imported.name === 'gridSize' ? 8 : null;
+    return definition.node.imported.type === 'Identifier' && definition.node.imported.name === 'gridSize' ? 8 : null;
   }
   if (!isNodeOfType(definition.node, 'VariableDeclarator')) {
     return null;

package/dist/es2019/rules/ensure-proper-xcss-usage/index.js

@@ -37,16 +37,18 @@ const rule = createLintRule({
           // Handle different import sources
           switch (source) {
             case '@atlaskit/primitives/compiled':
-              tracker.compiledComponents.add(specifier.imported.name);
+              if (specifier.imported.type === 'Identifier') {
+                tracker.compiledComponents.add(specifier.imported.name);
+              }
               break;
             case '@atlaskit/primitives':
-              if (specifier.imported.name === 'xcss') {
+              if (specifier.imported.type === 'Identifier' && specifier.imported.name === 'xcss') {
                 tracker.xcssFunction.add(specifier.local.name);
               }
               break;
             case '@atlaskit/css':
             case '@compiled/react':
-              if (specifier.imported.name === 'cssMap') {
+              if (specifier.imported.type === 'Identifier' && specifier.imported.name === 'cssMap') {
                 tracker.cssMapFunction.add(specifier.local.name);
               }
               break;

package/dist/es2019/rules/no-deprecated-imports/checks.js

@@ -108,7 +108,7 @@ export const createChecks = context => {
         } else if (specifier.type === 'ImportNamespaceSpecifier') {
           name = '*';
         } else if (specifier.type === 'ImportSpecifier') {
-          name = specifier.imported.name;
+          name = specifier.imported.type === 'Identifier' ? specifier.imported.name : '';
         }
         if (name) {
           importNames.set(name, specifier);
@@ -139,7 +139,7 @@ export const createChecks = context => {
       for (const specifier of node.specifiers) {
         let name;
         if (specifier.local) {
-          name = specifier.local.name;
+          name = specifier.local.type === 'Identifier' ? specifier.local.name : '';
         }
         if (name) {
           importNames.set(name, specifier);

package/dist/es2019/rules/no-html-anchor/node-types/jsx-element/index.js

@@ -29,7 +29,7 @@ export const JSXElement = {
           existingLinkName = defaultSpecifier.local.name;
         }
       } else if (declaration.source.value === '@atlaskit/button/new') {
-        const namedSpecifier = declaration.specifiers.find(specifier => specifier.type === 'ImportSpecifier' && specifier.imported.name === 'LinkButton');
+        const namedSpecifier = declaration.specifiers.find(specifier => specifier.type === 'ImportSpecifier' && specifier.imported.type === 'Identifier' && specifier.imported.name === 'LinkButton');
         if (namedSpecifier) {
           existingLinkButtonName = namedSpecifier.local.name;
         }

package/dist/es2019/rules/no-html-code/node-types/jsx-element/index.js

@@ -25,7 +25,7 @@ export const JSXElement = {
       }
       if (declaration.source.value === '@atlaskit/code') {
         declaration.specifiers.filter(specifier => isNodeOfType(specifier, 'ImportSpecifier') && isNodeOfType(specifier.parent, 'ImportDeclaration')).forEach(specifier => {
-          if (isNodeOfType(specifier, 'ImportSpecifier') && specifier.imported.name === 'Code') {
+          if (isNodeOfType(specifier, 'ImportSpecifier') && specifier.imported.type === 'Identifier' && specifier.imported.name === 'Code') {
             existingCodeName = specifier.local.name;
           }
         });

package/dist/es2019/rules/no-invalid-css-map/utils.js

@@ -50,6 +50,7 @@ export class CssMapObjectChecker {
         messageId: 'noInlineFunctions'
       });
     } else if (value.type === 'BinaryExpression' || value.type === 'LogicalExpression') {
+      // @ts-ignore -- this needs to be `ts-ignore` because this only errors in jira's typechecking due to update, not platform's
       this.checkCssMapObjectValue(value.left);
       this.checkCssMapObjectValue(value.right);
     } else if (value.type === 'Identifier') {

package/dist/es2019/rules/no-legacy-icons/checks.js

@@ -66,7 +66,7 @@ export const createChecks = context => {
       for (const spec of node.specifiers) {
         if (spec.type === 'ImportDefaultSpecifier') {
           newButtonImports.add(spec.local.name);
-        } else if (spec.type === 'ImportSpecifier' && spec.imported.name === 'IconButton') {
+        } else if (spec.type === 'ImportSpecifier' && 'name' in spec.imported && spec.imported.name === 'IconButton') {
           newButtonImports.add(spec.local.name);
         }
       }
@@ -140,12 +140,14 @@ export const createChecks = context => {
       const moduleSource = node.source.value;
       if (typeof moduleSource === 'string' && ['@atlaskit/icon/glyph/'].find(val => moduleSource.startsWith(val)) && node.specifiers.length) {
         for (const spec of node.specifiers) {
-          createCantMigrateReExportError(spec, moduleSource, spec.exported.name, errorsManual);
-          addToListOfRanges(spec, errorRanges);
-          guidance[locToString(spec)] = createGuidance({
-            iconPackage: moduleSource,
-            shouldUseMigrationPath
-          });
+          if ('name' in spec.exported) {
+            createCantMigrateReExportError(spec, moduleSource, spec.exported.name, errorsManual);
+            addToListOfRanges(spec, errorRanges);
+            guidance[locToString(spec)] = createGuidance({
+              iconPackage: moduleSource,
+              shouldUseMigrationPath
+            });
+          }
         }
       }
     } else if (node.declaration && isNodeOfType(node.declaration, 'VariableDeclaration')) {
@@ -168,7 +170,7 @@ export const createChecks = context => {
        * export { AddIcon, CrossIcon as default }
        */
       for (const spec of node.specifiers) {
-        if (Object.keys(legacyIconImports).includes(spec.local.name)) {
+        if ('name' in spec.local && 'name' in spec.exported && Object.keys(legacyIconImports).includes(spec.local.name)) {
           //update legacy imports to be exported
           legacyIconImports[spec.local.name] = {
             packageName: legacyIconImports[spec.local.name].packageName,