@atlaskit/eslint-plugin-design-system 13.19.0 → 13.19.2

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 13.19.2
+
+### Patch Changes
+
+- [#192592](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/192592)
+  [`558893bdbc7c3`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/558893bdbc7c3) -
+  Fixed no-legacy-icons auto fixer to retain size prop when migrating from migration to final core
+  entry point
+- Updated dependencies
+
+## 13.19.1
+
+### Patch Changes
+
+- [#188952](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/188952)
+  [`1a88e6e2601ae`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/1a88e6e2601ae) -
+  Migrated usage of renamed/deprecated icons
+- Updated dependencies
+
 ## 13.19.0
 
 ### Minor Changes

package/dist/cjs/rules/no-emotion-primitives/index.js

@@ -40,7 +40,7 @@ var rule = exports.rule = (0, _createRule.createLintRule)({
       recommended: false
     },
     messages: {
-      'no-emotion-primitives': 'Use @atlaskit/primitives/compiled instead of @atlaskit/primitives'
+      'no-emotion-primitives': 'Use @atlaskit/primitives/compiled instead of @atlaskit/primitives. Refer to go/akcss for more information.'
     },
     schema: schema
   },

package/dist/cjs/rules/no-legacy-icons/helpers.js

@@ -536,7 +536,8 @@ var createPropFixes = function createPropFixes(_ref7) {
     newIconName = _ref7.newIconName;
   var fixes = [];
   var spacing = metadata.spacing,
-    size = metadata.size;
+    size = metadata.size,
+    importSource = metadata.importSource;
   if (shouldUseMigrationPath && !legacyImportNode) {
     return fixes;
   }
@@ -565,8 +566,11 @@ var createPropFixes = function createPropFixes(_ref7) {
         if (size && sizeProp.value) {
           // update size prop with new replacement size
           fixes.push(fixer.replaceText(sizeProp.value, "\"".concat(size, "\"")));
-        } else {
-          // remove size prop if no new replacement size is specified
+        } else if (importSource.startsWith('@atlaskit/icon/glyph/')) {
+          // only remove size prop for glyph entry points if no new replacement size is specified
+          fixes.push(fixer.remove(sizeProp));
+        } else if (sizeProp.value && sizeProp.value.type === 'Literal' && typeof sizeProp.value.value === 'string' && sizeProp.value.value === 'medium') {
+          // if size is medium, we can remove it as it is the default size
           fixes.push(fixer.remove(sizeProp));
         }
       }

package/dist/cjs/rules/no-utility-icons/checks.js

@@ -11,7 +11,7 @@ function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol
 function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
 var specialCases = {
-  '@atlaskit/icon/utility/migration/cross--editor-close': '@atlaskit/icon/core/migration/close--editor-close'
+  '@atlaskit/icon/utility/migration/cross--editor-close': '@atlaskit/icon/core/migration/cross--editor-close'
 };
 var iconPropsinNewButton = ['icon', 'iconBefore', 'iconAfter'];
 var createChecks = exports.createChecks = function createChecks(context) {

package/dist/es2019/rules/no-emotion-primitives/index.js

@@ -30,7 +30,7 @@ export const rule = createLintRule({
       recommended: false
     },
     messages: {
-      'no-emotion-primitives': 'Use @atlaskit/primitives/compiled instead of @atlaskit/primitives'
+      'no-emotion-primitives': 'Use @atlaskit/primitives/compiled instead of @atlaskit/primitives. Refer to go/akcss for more information.'
     },
     schema
   },

package/dist/es2019/rules/no-legacy-icons/helpers.js

@@ -517,7 +517,8 @@ const createPropFixes = ({
   const fixes = [];
   const {
     spacing,
-    size
+    size,
+    importSource
   } = metadata;
   if (shouldUseMigrationPath && !legacyImportNode) {
     return fixes;
@@ -551,8 +552,11 @@ const createPropFixes = ({
         if (size && sizeProp.value) {
           // update size prop with new replacement size
           fixes.push(fixer.replaceText(sizeProp.value, `"${size}"`));
-        } else {
-          // remove size prop if no new replacement size is specified
+        } else if (importSource.startsWith('@atlaskit/icon/glyph/')) {
+          // only remove size prop for glyph entry points if no new replacement size is specified
+          fixes.push(fixer.remove(sizeProp));
+        } else if (sizeProp.value && sizeProp.value.type === 'Literal' && typeof sizeProp.value.value === 'string' && sizeProp.value.value === 'medium') {
+          // if size is medium, we can remove it as it is the default size
           fixes.push(fixer.remove(sizeProp));
         }
       }

package/dist/es2019/rules/no-utility-icons/checks.js

@@ -1,6 +1,6 @@
 import { isNodeOfType } from 'eslint-codemod-utils';
 const specialCases = {
-  '@atlaskit/icon/utility/migration/cross--editor-close': '@atlaskit/icon/core/migration/close--editor-close'
+  '@atlaskit/icon/utility/migration/cross--editor-close': '@atlaskit/icon/core/migration/cross--editor-close'
 };
 const iconPropsinNewButton = ['icon', 'iconBefore', 'iconAfter'];
 export const createChecks = context => {

package/dist/esm/rules/no-emotion-primitives/index.js

@@ -33,7 +33,7 @@ export var rule = createLintRule({
       recommended: false
     },
     messages: {
-      'no-emotion-primitives': 'Use @atlaskit/primitives/compiled instead of @atlaskit/primitives'
+      'no-emotion-primitives': 'Use @atlaskit/primitives/compiled instead of @atlaskit/primitives. Refer to go/akcss for more information.'
     },
     schema: schema
   },

package/dist/esm/rules/no-legacy-icons/helpers.js

@@ -527,7 +527,8 @@ var createPropFixes = function createPropFixes(_ref7) {
     newIconName = _ref7.newIconName;
   var fixes = [];
   var spacing = metadata.spacing,
-    size = metadata.size;
+    size = metadata.size,
+    importSource = metadata.importSource;
   if (shouldUseMigrationPath && !legacyImportNode) {
     return fixes;
   }
@@ -556,8 +557,11 @@ var createPropFixes = function createPropFixes(_ref7) {
         if (size && sizeProp.value) {
           // update size prop with new replacement size
           fixes.push(fixer.replaceText(sizeProp.value, "\"".concat(size, "\"")));
-        } else {
-          // remove size prop if no new replacement size is specified
+        } else if (importSource.startsWith('@atlaskit/icon/glyph/')) {
+          // only remove size prop for glyph entry points if no new replacement size is specified
+          fixes.push(fixer.remove(sizeProp));
+        } else if (sizeProp.value && sizeProp.value.type === 'Literal' && typeof sizeProp.value.value === 'string' && sizeProp.value.value === 'medium') {
+          // if size is medium, we can remove it as it is the default size
           fixes.push(fixer.remove(sizeProp));
         }
       }

package/dist/esm/rules/no-utility-icons/checks.js

@@ -4,7 +4,7 @@ function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r)
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
 import { isNodeOfType } from 'eslint-codemod-utils';
 var specialCases = {
-  '@atlaskit/icon/utility/migration/cross--editor-close': '@atlaskit/icon/core/migration/close--editor-close'
+  '@atlaskit/icon/utility/migration/cross--editor-close': '@atlaskit/icon/core/migration/cross--editor-close'
 };
 var iconPropsinNewButton = ['icon', 'iconBefore', 'iconAfter'];
 export var createChecks = function createChecks(context) {

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
 	"description": "The essential plugin for use with the Atlassian Design System.",
-	"version": "13.19.0",
+	"version": "13.19.2",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
 	"publishConfig": {
@@ -43,7 +43,7 @@
 	},
 	"dependencies": {
 		"@atlaskit/eslint-utils": "^2.0.0",
-		"@atlaskit/icon": "^27.5.0",
+		"@atlaskit/icon": "^27.8.0",
 		"@atlaskit/icon-lab": "^5.2.0",
 		"@atlaskit/tokens": "^5.6.0",
 		"@babel/runtime": "^7.0.0",
@@ -58,7 +58,7 @@
 	},
 	"devDependencies": {
 		"@af/formatting": "workspace:^",
-		"@atlaskit/ds-lib": "^4.1.0",
+		"@atlaskit/ds-lib": "^5.0.0",
 		"@atlaskit/theme": "^19.0.0",
 		"@atlassian/codegen": "^0.1.0",
 		"@atlassian/eslint-utils": "^0.5.0",