@atlaskit/eslint-plugin-design-system 13.17.2 → 13.17.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (33) hide show
  1. package/CHANGELOG.md +6 -0
  2. package/README.md +1 -0
  3. package/dist/cjs/presets/all-flat.codegen.js +2 -1
  4. package/dist/cjs/presets/all.codegen.js +2 -1
  5. package/dist/cjs/rules/enforce-inline-styles-in-select/index.js +76 -0
  6. package/dist/cjs/rules/enforce-inline-styles-in-select/utils.js +231 -0
  7. package/dist/cjs/rules/index.codegen.js +3 -1
  8. package/dist/cjs/rules/no-nested-styles/index.js +27 -20
  9. package/dist/es2019/presets/all-flat.codegen.js +2 -1
  10. package/dist/es2019/presets/all.codegen.js +2 -1
  11. package/dist/es2019/rules/enforce-inline-styles-in-select/index.js +68 -0
  12. package/dist/es2019/rules/enforce-inline-styles-in-select/utils.js +217 -0
  13. package/dist/es2019/rules/index.codegen.js +3 -1
  14. package/dist/es2019/rules/no-nested-styles/index.js +27 -18
  15. package/dist/esm/presets/all-flat.codegen.js +2 -1
  16. package/dist/esm/presets/all.codegen.js +2 -1
  17. package/dist/esm/rules/enforce-inline-styles-in-select/index.js +70 -0
  18. package/dist/esm/rules/enforce-inline-styles-in-select/utils.js +225 -0
  19. package/dist/esm/rules/index.codegen.js +3 -1
  20. package/dist/esm/rules/no-nested-styles/index.js +27 -20
  21. package/dist/types/index.codegen.d.ts +5 -0
  22. package/dist/types/presets/all-flat.codegen.d.ts +1 -0
  23. package/dist/types/presets/all.codegen.d.ts +1 -0
  24. package/dist/types/rules/enforce-inline-styles-in-select/index.d.ts +3 -0
  25. package/dist/types/rules/enforce-inline-styles-in-select/utils.d.ts +2 -0
  26. package/dist/types/rules/index.codegen.d.ts +1 -0
  27. package/dist/types-ts4.5/index.codegen.d.ts +5 -0
  28. package/dist/types-ts4.5/presets/all-flat.codegen.d.ts +1 -0
  29. package/dist/types-ts4.5/presets/all.codegen.d.ts +1 -0
  30. package/dist/types-ts4.5/rules/enforce-inline-styles-in-select/index.d.ts +3 -0
  31. package/dist/types-ts4.5/rules/enforce-inline-styles-in-select/utils.d.ts +2 -0
  32. package/dist/types-ts4.5/rules/index.codegen.d.ts +1 -0
  33. package/package.json +4 -4
package/dist/esm/rules/no-nested-styles/index.js CHANGED
@@ -52,18 +52,21 @@ var getKeyValue = function getKeyValue(node, context) {
52
52
  }
53
53
  return '';
54
54
  };
55
- var isWidthMediaQuery = function isWidthMediaQuery(rawSelector) {
56
- var selectors = parseSelector(rawSelector);
57
- if (selectors[0].startsWith('@')) {
58
- // If the selector includes a min-width/max-width query, return false - the primitives media object should be used instead:
59
- // https://staging.atlassian.design/components/primitives/responsive/breakpoints/examples
60
- // Otherwise return true, non-width queries are acceptable
61
- return selectors.some(function (selector) {
62
- return selector.includes('min-width') || selector.includes('max-width');
63
- });
64
- }
65
- return false;
66
- };
55
+
56
+ // const isWidthMediaQuery = (rawSelector: string): boolean => {
57
+ // const selectors = parseSelector(rawSelector);
58
+
59
+ // if (selectors[0].startsWith('@')) {
60
+ // // If the selector includes a min-width/max-width query, return false - the primitives media object should be used instead:
61
+ // // https://staging.atlassian.design/components/primitives/responsive/breakpoints/examples
62
+ // // Otherwise return true, non-width queries are acceptable
63
+ // return selectors.some(
64
+ // (selector) => selector.includes('min-width') || selector.includes('max-width'),
65
+ // );
66
+ // }
67
+ // return false;
68
+ // };
69
+
67
70
  var isAllowedNestedSelector = function isAllowedNestedSelector(rawSelector) {
68
71
  if (rawSelector.trim() === '&') {
69
72
  // This can be written without the nest.
@@ -95,7 +98,8 @@ var rule = createLintRule({
95
98
  severity: 'error'
96
99
  },
97
100
  messages: {
98
- noWidthQueries: 'Media queries that target min-width or max-width are not allowed. Use the media object provided by the Atlassian Design System instead. https://staging.atlassian.design/components/primitives/responsive/breakpoints/examples',
101
+ // noWidthQueries:
102
+ // 'Media queries that target min-width or max-width are not allowed. Use the media object provided by the Atlassian Design System instead. https://staging.atlassian.design/components/primitives/responsive/breakpoints/examples',
99
103
  noNestedStyles: 'Nested styles are not allowed as they can change unexpectedly when child markup changes and result in duplicates when extracting to CSS.',
100
104
  noDirectNestedStyles: "Styles applied with data attributes are not allowed, split them into discrete CSS declarations and apply them conditionally with JavaScript.\n\n```\nconst disabledStyles = css({ opacity: 0.5 });\n\n<div css={isDisabled && disabledStyles} />\n```\n"
101
105
  }
@@ -113,13 +117,16 @@ var rule = createLintRule({
113
117
  });
114
118
  return;
115
119
  }
116
- if (isWidthMediaQuery(getKeyValue(node.key, context))) {
117
- context.report({
118
- node: node,
119
- messageId: 'noWidthQueries'
120
- });
121
- return;
122
- }
120
+
121
+ // if (isWidthMediaQuery(getKeyValue(node.key as Rule.Node, context))) {
122
+ // context.report({
123
+ // node,
124
+ // messageId: 'noWidthQueries',
125
+ // });
126
+
127
+ // return;
128
+ // }
129
+
123
130
  if (!isAllowedNestedSelector(getKeyValue(node.key, context))) {
124
131
  context.report({
125
132
  node: node,
package/dist/types/index.codegen.d.ts CHANGED
@@ -16,6 +16,7 @@ export declare const plugin: {
16
16
  };
17
17
  rules: {
18
18
  'consistent-css-prop-usage': import("eslint").Rule.RuleModule;
19
+ 'enforce-inline-styles-in-select': import("eslint").Rule.RuleModule;
19
20
  'ensure-design-token-usage': import("eslint").Rule.RuleModule;
20
21
  'ensure-design-token-usage/preview': import("eslint").Rule.RuleModule;
21
22
  'ensure-icon-color': import("eslint").Rule.RuleModule;
@@ -84,6 +85,7 @@ export declare const plugin: {
84
85
  plugins: string[];
85
86
  rules: {
86
87
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
88
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
87
89
  '@atlaskit/design-system/ensure-design-token-usage': "error";
88
90
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
89
91
  '@atlaskit/design-system/ensure-icon-color': "error";
@@ -153,6 +155,7 @@ export declare const plugin: {
153
155
  };
154
156
  rules: {
155
157
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
158
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
156
159
  '@atlaskit/design-system/ensure-design-token-usage': "error";
157
160
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
158
161
  '@atlaskit/design-system/ensure-icon-color': "error";
@@ -323,6 +326,7 @@ declare const configs: {
323
326
  plugins: string[];
324
327
  rules: {
325
328
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
329
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
326
330
  '@atlaskit/design-system/ensure-design-token-usage': "error";
327
331
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
328
332
  '@atlaskit/design-system/ensure-icon-color': "error";
@@ -392,6 +396,7 @@ declare const configs: {
392
396
  };
393
397
  rules: {
394
398
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
399
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
395
400
  '@atlaskit/design-system/ensure-design-token-usage': "error";
396
401
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
397
402
  '@atlaskit/design-system/ensure-icon-color': "error";
package/dist/types/presets/all-flat.codegen.d.ts CHANGED
@@ -2,6 +2,7 @@ declare const _default: {
2
2
  plugins: {};
3
3
  rules: {
4
4
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
5
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
5
6
  '@atlaskit/design-system/ensure-design-token-usage': "error";
6
7
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
7
8
  '@atlaskit/design-system/ensure-icon-color': "error";
package/dist/types/presets/all.codegen.d.ts CHANGED
@@ -2,6 +2,7 @@ declare const _default: {
2
2
  plugins: string[];
3
3
  rules: {
4
4
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
5
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
5
6
  '@atlaskit/design-system/ensure-design-token-usage': "error";
6
7
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
7
8
  '@atlaskit/design-system/ensure-icon-color': "error";
package/dist/types/rules/enforce-inline-styles-in-select/index.d.ts ADDED
@@ -0,0 +1,3 @@
1
+ import type { Rule } from 'eslint';
2
+ declare const rule: Rule.RuleModule;
3
+ export default rule;
package/dist/types/rules/enforce-inline-styles-in-select/utils.d.ts ADDED
@@ -0,0 +1,2 @@
1
+ import type { Rule } from 'eslint';
2
+ export declare function checkStylesObject(node: Rule.Node, stylesValue: any, context: Rule.RuleContext): void;
package/dist/types/rules/index.codegen.d.ts CHANGED
@@ -1,5 +1,6 @@
1
1
  export declare const rules: {
2
2
  'consistent-css-prop-usage': import("eslint").Rule.RuleModule;
3
+ 'enforce-inline-styles-in-select': import("eslint").Rule.RuleModule;
3
4
  'ensure-design-token-usage': import("eslint").Rule.RuleModule;
4
5
  'ensure-design-token-usage/preview': import("eslint").Rule.RuleModule;
5
6
  'ensure-icon-color': import("eslint").Rule.RuleModule;
package/dist/types-ts4.5/index.codegen.d.ts CHANGED
@@ -16,6 +16,7 @@ export declare const plugin: {
16
16
  };
17
17
  rules: {
18
18
  'consistent-css-prop-usage': import("eslint").Rule.RuleModule;
19
+ 'enforce-inline-styles-in-select': import("eslint").Rule.RuleModule;
19
20
  'ensure-design-token-usage': import("eslint").Rule.RuleModule;
20
21
  'ensure-design-token-usage/preview': import("eslint").Rule.RuleModule;
21
22
  'ensure-icon-color': import("eslint").Rule.RuleModule;
@@ -84,6 +85,7 @@ export declare const plugin: {
84
85
  plugins: string[];
85
86
  rules: {
86
87
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
88
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
87
89
  '@atlaskit/design-system/ensure-design-token-usage': "error";
88
90
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
89
91
  '@atlaskit/design-system/ensure-icon-color': "error";
@@ -156,6 +158,7 @@ export declare const plugin: {
156
158
  };
157
159
  rules: {
158
160
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
161
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
159
162
  '@atlaskit/design-system/ensure-design-token-usage': "error";
160
163
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
161
164
  '@atlaskit/design-system/ensure-icon-color': "error";
@@ -335,6 +338,7 @@ declare const configs: {
335
338
  plugins: string[];
336
339
  rules: {
337
340
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
341
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
338
342
  '@atlaskit/design-system/ensure-design-token-usage': "error";
339
343
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
340
344
  '@atlaskit/design-system/ensure-icon-color': "error";
@@ -407,6 +411,7 @@ declare const configs: {
407
411
  };
408
412
  rules: {
409
413
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
414
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
410
415
  '@atlaskit/design-system/ensure-design-token-usage': "error";
411
416
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
412
417
  '@atlaskit/design-system/ensure-icon-color': "error";
package/dist/types-ts4.5/presets/all-flat.codegen.d.ts CHANGED
@@ -2,6 +2,7 @@ declare const _default: {
2
2
  plugins: {};
3
3
  rules: {
4
4
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
5
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
5
6
  '@atlaskit/design-system/ensure-design-token-usage': "error";
6
7
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
7
8
  '@atlaskit/design-system/ensure-icon-color': "error";
package/dist/types-ts4.5/presets/all.codegen.d.ts CHANGED
@@ -2,6 +2,7 @@ declare const _default: {
2
2
  plugins: string[];
3
3
  rules: {
4
4
  '@atlaskit/design-system/consistent-css-prop-usage': "error";
5
+ '@atlaskit/design-system/enforce-inline-styles-in-select': "error";
5
6
  '@atlaskit/design-system/ensure-design-token-usage': "error";
6
7
  '@atlaskit/design-system/ensure-design-token-usage/preview': "warn";
7
8
  '@atlaskit/design-system/ensure-icon-color': "error";
package/dist/types-ts4.5/rules/enforce-inline-styles-in-select/index.d.ts ADDED
@@ -0,0 +1,3 @@
1
+ import type { Rule } from 'eslint';
2
+ declare const rule: Rule.RuleModule;
3
+ export default rule;
package/dist/types-ts4.5/rules/enforce-inline-styles-in-select/utils.d.ts ADDED
@@ -0,0 +1,2 @@
1
+ import type { Rule } from 'eslint';
2
+ export declare function checkStylesObject(node: Rule.Node, stylesValue: any, context: Rule.RuleContext): void;
package/dist/types-ts4.5/rules/index.codegen.d.ts CHANGED
@@ -1,5 +1,6 @@
1
1
  export declare const rules: {
2
2
  'consistent-css-prop-usage': import("eslint").Rule.RuleModule;
3
+ 'enforce-inline-styles-in-select': import("eslint").Rule.RuleModule;
3
4
  'ensure-design-token-usage': import("eslint").Rule.RuleModule;
4
5
  'ensure-design-token-usage/preview': import("eslint").Rule.RuleModule;
5
6
  'ensure-icon-color': import("eslint").Rule.RuleModule;
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "name": "@atlaskit/eslint-plugin-design-system",
3
3
  "description": "The essential plugin for use with the Atlassian Design System.",
4
- "version": "13.17.2",
4
+ "version": "13.17.3",
5
5
  "author": "Atlassian Pty Ltd",
6
6
  "license": "Apache-2.0",
7
7
  "publishConfig": {
@@ -44,9 +44,9 @@
44
44
  },
45
45
  "dependencies": {
46
46
  "@atlaskit/eslint-utils": "^2.0.0",
47
- "@atlaskit/icon": "^26.4.0",
48
- "@atlaskit/icon-lab": "^4.17.0",
49
- "@atlaskit/tokens": "^5.0.0",
47
+ "@atlaskit/icon": "^27.0.0",
48
+ "@atlaskit/icon-lab": "^5.0.0",
49
+ "@atlaskit/tokens": "^5.2.0",
50
50
  "@babel/runtime": "^7.0.0",
51
51
  "@typescript-eslint/utils": "^7.1.0",
52
52
  "ajv": "^6.12.6",