@atlaskit/eslint-plugin-design-system 13.14.2 → 13.16.0

package/dist/cjs/rules/no-legacy-icons/helpers.js

@@ -5,7 +5,7 @@ var _typeof = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.throwManualErrors = exports.throwAutoErrors = exports.locToString = exports.isSize = exports.isInsideNewButton = exports.isInsideLegacyButton = exports.isInsideIconOnlyLegacyButton = exports.getUpcomingIcons = exports.getMigrationMapObject = exports.createHelpers = exports.createGuidance = exports.createCantMigrateSpreadPropsError = exports.createCantMigrateSizeUnknown = exports.createCantMigrateReExportError = exports.createCantMigrateIdentifierMapOrArrayError = exports.createCantMigrateIdentifierError = exports.createCantMigrateFunctionUnknownError = exports.createCantMigrateColorError = exports.createCantFindSuitableReplacementError = exports.createAutoMigrationError = exports.canMigrateColor = exports.canAutoMigrateNewIconBasedOnSize = exports.addToListOfRanges = void 0;
+exports.throwManualErrors = exports.throwAutoErrors = exports.locToString = exports.isSize = exports.isInsideNewButton = exports.isInsideLegacyButton = exports.isInsideIconOnlyLegacyButton = exports.getUpcomingIcons = exports.getMigrationMapObject = exports.getComponentName = exports.createHelpers = exports.createGuidance = exports.createCantMigrateSpreadPropsError = exports.createCantMigrateSizeUnknown = exports.createCantMigrateReExportError = exports.createCantMigrateIdentifierMapOrArrayError = exports.createCantMigrateIdentifierError = exports.createCantMigrateFunctionUnknownError = exports.createCantMigrateColorError = exports.createCantFindSuitableReplacementError = exports.createAutoMigrationError = exports.canMigrateColor = exports.canAutoMigrateNewIconBasedOnSize = exports.addToListOfRanges = void 0;
 var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toConsumableArray"));
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
@@ -66,7 +66,7 @@ var getIconKey = function getIconKey(iconPackage) {
  * Checks if a new icon can be auto-migrated based on guidance from the migration map
  */
 var canAutoMigrateNewIconBasedOnSize = exports.canAutoMigrateNewIconBasedOnSize = function canAutoMigrateNewIconBasedOnSize(guidance) {
-  return ['swap', 'swap-slight-visual-change', 'swap-visual-change', 'swap-size-shift-utility'].includes(guidance || '');
+  return guidance ? ['swap', 'swap-slight-visual-change', 'swap-visual-change'].includes(guidance) : false;
 };
 
 /**
@@ -94,8 +94,10 @@ var getNewIconNameAndImportPath = function getNewIconNameAndImportPath(iconPacka
 var createGuidance = exports.createGuidance = function createGuidance(_ref) {
   var iconPackage = _ref.iconPackage,
     insideNewButton = _ref.insideNewButton,
-    size = _ref.size,
-    shouldUseMigrationPath = _ref.shouldUseMigrationPath;
+    initialSize = _ref.size,
+    shouldUseMigrationPath = _ref.shouldUseMigrationPath,
+    shouldForceSmallIcon = _ref.shouldForceSmallIcon;
+  var size = shouldForceSmallIcon ? 'small' : initialSize;
   var migrationMapObject = getMigrationMapObject(iconPackage);
   var upcomingIcon = getUpcomingIcons(iconPackage);
   if (upcomingIcon) {
@@ -155,8 +157,18 @@ var createGuidance = exports.createGuidance = function createGuidance(_ref) {
     }
     if (insideNewButton) {
       _guidance += buttonGuidanceStr;
-    } else if (size && size === 'medium') {
-      _guidance += "Setting the spacing property to 'spacious' will maintain the icon's box dimensions - but consider setting spacing='none' as it allows for easier control of spacing by parent elements.\n";
+    } else if (size === 'medium') {
+      _guidance += "Setting the spacing='spacious' will maintain the icon's box dimensions - but consider setting spacing='none' as it allows for easier control of spacing by parent elements.\n";
+    } else if (size === 'small') {
+      if (initialSize !== 'small' && shouldForceSmallIcon) {
+        _guidance += "For this icon, it's recommended to use a smaller size using size='small'. Alternatively, for special cases where a larger version is needed size='medium' can be used, but it is generally discouraged for this icon.\n";
+      } else if (initialSize === 'small') {
+        if (shouldForceSmallIcon) {
+          _guidance += "Setting spacing='compact' will maintain the icon's box dimensions - but consider setting spacing='none' as it allows for easier control of spacing by parent elements.\n";
+        } else {
+          _guidance += "It's recommended to upscale to a medium icon with no spacing. Alternatively for special cases where smaller icons are required, the original icon size and dimensions can be maintained by using size='small' and spacing='compact'.\n";
+        }
+      }
     } else if (size) {
       _guidance += "In the new icon, please use spacing='none'.\n";
     }
@@ -280,7 +292,8 @@ var createAutoMigrationError = exports.createAutoMigrationError = function creat
     iconName = _ref4.iconName,
     errors = _ref4.errors,
     spacing = _ref4.spacing,
-    insideNewButton = _ref4.insideNewButton;
+    insideNewButton = _ref4.insideNewButton,
+    shouldForceSmallIcon = _ref4.shouldForceSmallIcon;
   var myError = {
     node: node,
     messageId: 'noLegacyIconsAutoMigration',
@@ -289,7 +302,8 @@ var createAutoMigrationError = exports.createAutoMigrationError = function creat
       iconName: iconName,
       spacing: spacing !== null && spacing !== void 0 ? spacing : '',
       // value type need to be a string in Rule.ReportDescriptor
-      insideNewButton: String(insideNewButton)
+      insideNewButton: String(insideNewButton),
+      shouldForceSmallIcon: String(shouldForceSmallIcon)
     }
   };
   errors[locToString(node)] = myError;
@@ -444,7 +458,7 @@ var getNewIconNameForRenaming = function getNewIconNameForRenaming(isInManualArr
   var newIconName;
   if (isInManualArray) {
     newIconName = getNewIconNameAndImportPath(importSource).iconName;
-    var keyToName = newIconName ? newIconName[0].toUpperCase() + newIconName.slice(1) + 'Icon' : undefined;
+    var keyToName = newIconName ? getComponentName(newIconName) : undefined;
     newIconName = keyToName;
     if (newIconName === undefined || importSpecifier === keyToName) {
       newIconName = "".concat(keyToName, "New");
@@ -452,6 +466,11 @@ var getNewIconNameForRenaming = function getNewIconNameForRenaming(isInManualArr
   }
   return newIconName;
 };
+var getComponentName = exports.getComponentName = function getComponentName(name) {
+  return name.split(/\W/).map(function (part) {
+    return "".concat(part[0].toUpperCase()).concat(part.slice(1));
+  }).join('').concat('Icon');
+};
 
 /**
  *
@@ -517,7 +536,8 @@ var createPropFixes = function createPropFixes(_ref7) {
     migrationImportNode = _ref7.migrationImportNode,
     newIconName = _ref7.newIconName;
   var fixes = [];
-  var spacing = metadata.spacing;
+  var spacing = metadata.spacing,
+    size = metadata.size;
   if (shouldUseMigrationPath && !legacyImportNode) {
     return fixes;
   }
@@ -533,24 +553,31 @@ var createPropFixes = function createPropFixes(_ref7) {
     if (primaryColor && primaryColor.type === 'JSXAttribute') {
       fixes.push(fixer.replaceText(primaryColor.name, 'color'));
     }
-
-    // rename or remove size prop based on shouldUseMigrationPath,
-    // add spacing="spacious" if
-    // 1. it's in error metadata, which means size is medium
-    // 2. no existing spacing prop
-    // 3. iconType is "core"
-    // 4. icon is not imported from migration entrypoint
     var sizeProp = findProp(attributes, 'size');
     var spacingProp = findProp(attributes, 'spacing');
-    if (spacing && !spacingProp && !migrationImportNode) {
-      fixes.push(fixer.insertTextAfter(sizeProp || openingElement.name, " spacing=\"".concat(spacing, "\"")));
-    }
     if (sizeProp && sizeProp.type === 'JSXAttribute') {
-      fixes.push(shouldUseMigrationPath ?
-      // replace size prop with LEGACY_size,
-      fixer.replaceText(sizeProp.name, 'LEGACY_size') :
-      // remove size prop if shouldUseMigrationPath is false
-      fixer.remove(sizeProp));
+      if (shouldUseMigrationPath) {
+        // Rename existing size prop to LEGACY_size and add new size prop if applicable
+        fixes.push(fixer.replaceText(sizeProp.name, 'LEGACY_size'));
+        if (size) {
+          fixes.push(fixer.insertTextAfter(sizeProp, " size=\"".concat(size, "\"")));
+        }
+      } else {
+        if (size && sizeProp.value) {
+          // update size prop with new replacement size
+          fixes.push(fixer.replaceText(sizeProp.value, "\"".concat(size, "\"")));
+        } else {
+          // remove size prop if no new replacement size is specified
+          fixes.push(fixer.remove(sizeProp));
+        }
+      }
+    } else if (size) {
+      fixes.push(fixer.insertTextAfter(openingElement.name, " size=\"".concat(size, "\"")));
+    }
+
+    // Add spacing prop if no existing spacing prop and icon is not imported from migration entrypoint
+    if (spacing && spacing !== 'none' && !spacingProp && !migrationImportNode) {
+      fixes.push(fixer.insertTextAfter(sizeProp || openingElement.name, " spacing=\"".concat(spacing, "\"")));
     }
 
     // rename or remove secondaryColor prop based on shouldUseMigrationPath
@@ -647,6 +674,7 @@ var throwManualErrors = exports.throwManualErrors = function throwManualErrors(_
 var throwAutoErrors = exports.throwAutoErrors = function throwAutoErrors(_ref10) {
   var errorsManual = _ref10.errorsManual,
     errorsAuto = _ref10.errorsAuto,
+    iconSizesInfo = _ref10.iconSizesInfo,
     legacyIconImports = _ref10.legacyIconImports,
     guidance = _ref10.guidance,
     migrationIconImports = _ref10.migrationIconImports,
@@ -702,7 +730,7 @@ var throwAutoErrors = exports.throwAutoErrors = function throwAutoErrors(_ref10)
       _step2;
     try {
       var _loop2 = function _loop2() {
-          var _legacyIconImports$er, _legacyIconImports$er2, _migrationIconImports;
+          var _iconSizesInfo$import, _iconSizesInfo$import2, _iconSizesInfo$import3, _legacyIconImports$er, _error$data2, _legacyIconImports$er2, _migrationIconImports;
           var _step2$value = (0, _slicedToArray2.default)(_step2.value, 2),
             _ = _step2$value[0],
             error = _step2$value[1];
@@ -712,8 +740,20 @@ var throwAutoErrors = exports.throwAutoErrors = function throwAutoErrors(_ref10)
           // If that is the case we'll need to provide a suggestion instead of auto-fixing as the suggestion will
           // add another import without removing the old import and this needs to be validated
           var isInManualArray = allManualErrorSources.has(importSource);
+
+          // Check if the icon has size of small, if so it cannot be automatically migrated. Two suggestions will be provided
+          // 1. Use core icon with no spacing
+          // 2. Use utility icon with compact spacing
+          var isSizeSmall = (_iconSizesInfo$import = iconSizesInfo[importSource]) === null || _iconSizesInfo$import === void 0 ? void 0 : _iconSizesInfo$import.small.includes(key);
+          var isMixedSizeUsage = ((_iconSizesInfo$import2 = iconSizesInfo[importSource]) === null || _iconSizesInfo$import2 === void 0 ? void 0 : _iconSizesInfo$import2.small.length) > 0 && ((_iconSizesInfo$import3 = iconSizesInfo[importSource]) === null || _iconSizesInfo$import3 === void 0 ? void 0 : _iconSizesInfo$import3.small.length) < iconSizesInfo[importSource].usageCount;
+
+          // Icon should be renamed
+          // 1. If the icon is in the manual array OR
+          // 2. If there is mixed size usages of this icon with size small
+          var shouldRenameIcon = isInManualArray || isMixedSizeUsage;
+
           // New icon name for renaming if the icon is in the manual array
-          var newIconName = getNewIconNameForRenaming(isInManualArray, importSource, errorList[0].data ? (_legacyIconImports$er = legacyIconImports[errorList[0].data.iconName]) === null || _legacyIconImports$er === void 0 ? void 0 : _legacyIconImports$er.importSpecifier : undefined);
+          var newIconName = getNewIconNameForRenaming(shouldRenameIcon, importSource, errorList[0].data ? (_legacyIconImports$er = legacyIconImports[errorList[0].data.iconName]) === null || _legacyIconImports$er === void 0 ? void 0 : _legacyIconImports$er.importSpecifier : undefined);
           if (!node) {
             return 0; // continue
           }
@@ -721,22 +761,43 @@ var throwAutoErrors = exports.throwAutoErrors = function throwAutoErrors(_ref10)
           if (Object.keys(error).includes('data') && error.data) {
             error.data.guidance = guidanceMessage;
           }
+          var shouldForceSmallIcon = ((_error$data2 = error.data) === null || _error$data2 === void 0 ? void 0 : _error$data2.shouldForceSmallIcon) === 'true';
           var fixArguments = error.data ? {
-            metadata: error.data,
+            metadata: _objectSpread(_objectSpread({}, error.data), {}, {
+              spacing: error.data.isInNewButton ? 'none' : error.data.spacing,
+              size: shouldForceSmallIcon ? 'small' : error.data.size
+            }),
             legacyImportNode: (_legacyIconImports$er2 = legacyIconImports[error.data.iconName]) === null || _legacyIconImports$er2 === void 0 ? void 0 : _legacyIconImports$er2.importNode,
             migrationImportNode: (_migrationIconImports = migrationIconImports[error.data.iconName]) === null || _migrationIconImports === void 0 ? void 0 : _migrationIconImports.importNode,
             shouldUseMigrationPath: shouldUseMigrationPath,
-            newIconName: isInManualArray ? newIconName : undefined
+            newIconName: shouldRenameIcon ? newIconName : undefined
           } : null;
           if (!error.data || shouldUseMigrationPath && !checkIfNewIconExist(error) || !fixArguments) {
             return 0; // continue
           }
-          if (isInManualArray) {
-            // provide suggestion if there is a manual error for the same import source and thus the legacy import can't be removed
+          var isInNewButton = fixArguments.metadata.insideNewButton === 'true';
+          if (isSizeSmall && !shouldForceSmallIcon) {
             error.suggest = [{
-              desc: 'Rename icon import, import from the new package, and update props.',
+              desc: isInNewButton ? 'Replace with medium core icon (Recommended)' : 'Replace with medium core icon and no spacing (Recommended)',
+              fix: function fix(fixer) {
+                return [].concat((0, _toConsumableArray2.default)(createPropFixes(_objectSpread(_objectSpread({}, fixArguments), {}, {
+                  metadata: _objectSpread(_objectSpread({}, fixArguments.metadata), {}, {
+                    spacing: 'none'
+                  }),
+                  node: node,
+                  fixer: fixer
+                }))), (0, _toConsumableArray2.default)(createImportFix(_objectSpread(_objectSpread({}, fixArguments), {}, {
+                  fixer: fixer
+                }))));
+              }
+            }, {
+              desc: isInNewButton ? 'Replace with small core icon' : 'Replace with small core icon and compact spacing',
               fix: function fix(fixer) {
                 return [].concat((0, _toConsumableArray2.default)(createPropFixes(_objectSpread(_objectSpread({}, fixArguments), {}, {
+                  metadata: _objectSpread(_objectSpread({}, fixArguments.metadata), {}, {
+                    spacing: 'compact',
+                    size: 'small'
+                  }),
                   node: node,
                   fixer: fixer
                 }))), (0, _toConsumableArray2.default)(createImportFix(_objectSpread(_objectSpread({}, fixArguments), {}, {
@@ -745,25 +806,40 @@ var throwAutoErrors = exports.throwAutoErrors = function throwAutoErrors(_ref10)
               }
             }];
           } else {
-            // Update Guidance message for auto-fixing
-            if (error.data) {
-              error.data.guidance = error.data.guidance + "\nTo automatically fix this icon, run the auto-fixer attached to the first use of ".concat(importSource, " in this file - either manually, or by saving this file.");
-            }
-            // There should only be 1 import fix for each import source and thus only add this at the start of the list
-            if (autoFixers.length === 0) {
+            if (isInManualArray) {
+              // provide suggestion if there is a manual error for the same import source and thus the legacy import can't be removed
+              error.suggest = [{
+                desc: 'Rename icon import, import from the new package, and update props.',
+                fix: function fix(fixer) {
+                  return [].concat((0, _toConsumableArray2.default)(createPropFixes(_objectSpread(_objectSpread({}, fixArguments), {}, {
+                    node: node,
+                    fixer: fixer
+                  }))), (0, _toConsumableArray2.default)(createImportFix(_objectSpread(_objectSpread({}, fixArguments), {}, {
+                    fixer: fixer
+                  }))));
+                }
+              }];
+            } else {
+              // Update Guidance message for auto-fixing
+              if (error.data) {
+                error.data.guidance = error.data.guidance + "\nTo automatically fix this icon, run the auto-fixer attached to the first use of ".concat(importSource, " in this file - either manually, or by saving this file.");
+              }
+              // There should only be 1 import fix for each import source and thus only add this at the start of the list
+              if (autoFixers.length === 0) {
+                autoFixers.push(function (fixer) {
+                  return createImportFix(_objectSpread(_objectSpread({}, fixArguments), {}, {
+                    fixer: fixer
+                  }));
+                });
+              }
+              // Push the prop fix regardless
               autoFixers.push(function (fixer) {
-                return createImportFix(_objectSpread(_objectSpread({}, fixArguments), {}, {
+                return createPropFixes(_objectSpread(_objectSpread({}, fixArguments), {}, {
+                  node: node,
                   fixer: fixer
                 }));
               });
             }
-            // Push the prop fix regardless
-            autoFixers.push(function (fixer) {
-              return createPropFixes(_objectSpread(_objectSpread({}, fixArguments), {}, {
-                node: node,
-                fixer: fixer
-              }));
-            });
           }
           // Add the error to the appliedErrorsForImport, ready to be thrown later
           appliedErrorsForImport.push(error);

package/dist/cjs/rules/no-utility-icons/checks.js

@@ -0,0 +1,233 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.createChecks = void 0;
+var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
+var _eslintCodemodUtils = require("eslint-codemod-utils");
+function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
+function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
+function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
+var specialCases = {
+  '@atlaskit/icon/utility/cross': '@atlaskit/icon/core/close',
+  '@atlaskit/icon/utility/migration/cross--editor-close': '@atlaskit/icon/core/migration/close--editor-close'
+};
+var iconPropsinNewButton = ['icon', 'iconBefore', 'iconAfter'];
+var createChecks = exports.createChecks = function createChecks(context) {
+  var importStatementsUtility = {};
+  var importStatementsCore = {};
+  var newButtonImports = new Set();
+  var errors = {};
+  var checkImportDeclarations = function checkImportDeclarations(node) {
+    var moduleSource = node.source.value;
+    if (typeof moduleSource !== 'string') {
+      return;
+    }
+    if (moduleSource.startsWith('@atlaskit/icon/utility/')) {
+      var _iterator = _createForOfIteratorHelper(node.specifiers),
+        _step;
+      try {
+        for (_iterator.s(); !(_step = _iterator.n()).done;) {
+          var specifier = _step.value;
+          if (specifier.type === 'ImportDefaultSpecifier') {
+            importStatementsUtility[specifier.local.name] = node;
+          }
+        }
+      } catch (err) {
+        _iterator.e(err);
+      } finally {
+        _iterator.f();
+      }
+    } else if (moduleSource.startsWith('@atlaskit/icon/core/')) {
+      var _iterator2 = _createForOfIteratorHelper(node.specifiers),
+        _step2;
+      try {
+        for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
+          var _specifier = _step2.value;
+          if (_specifier.type === 'ImportDefaultSpecifier') {
+            importStatementsCore[moduleSource] = {
+              node: node,
+              localName: _specifier.local.name
+            };
+          }
+        }
+      } catch (err) {
+        _iterator2.e(err);
+      } finally {
+        _iterator2.f();
+      }
+    } else if (moduleSource.startsWith('@atlaskit/button/')) {
+      var _iterator3 = _createForOfIteratorHelper(node.specifiers),
+        _step3;
+      try {
+        for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
+          var _specifier2 = _step3.value;
+          newButtonImports.add(_specifier2.local.name);
+        }
+      } catch (err) {
+        _iterator3.e(err);
+      } finally {
+        _iterator3.f();
+      }
+    }
+  };
+  var checkJSXElement = function checkJSXElement(node) {
+    if (!((0, _eslintCodemodUtils.isNodeOfType)(node, 'JSXElement') && (0, _eslintCodemodUtils.isNodeOfType)(node.openingElement.name, 'JSXIdentifier') && importStatementsUtility.hasOwnProperty(node.openingElement.name.name) && typeof importStatementsUtility[node.openingElement.name.name].source.value === 'string')) {
+      return;
+    }
+    if (!errors.hasOwnProperty(node.openingElement.name.name)) {
+      errors[node.openingElement.name.name] = [];
+    }
+    errors[node.openingElement.name.name].push({
+      node: node,
+      messageId: 'noUtilityIconsJSXElement',
+      localName: node.openingElement.name.name,
+      fixable: true,
+      inNewButton: false
+    });
+  };
+
+  // Cases: As Props, In Function Calls, In Arrays, In Maps, In Exports
+  var checkIconReference = function checkIconReference(node) {
+    //if this is an import statement then exit early
+    if (node.parent && ((0, _eslintCodemodUtils.isNodeOfType)(node.parent, 'ImportSpecifier') || (0, _eslintCodemodUtils.isNodeOfType)(node.parent, 'ImportDefaultSpecifier'))) {
+      return;
+    }
+
+    //check the reference to see if it's a utility icon, if not exit early
+    if (!importStatementsUtility.hasOwnProperty(node.name)) {
+      return;
+    }
+
+    // if it is in new Button then we can fix it
+    if (node.parent && node.parent.parent && node.parent.parent.parent && (0, _eslintCodemodUtils.isNodeOfType)(node.parent, 'JSXExpressionContainer') && (0, _eslintCodemodUtils.isNodeOfType)(node.parent.parent, 'JSXAttribute') && (0, _eslintCodemodUtils.isNodeOfType)(node.parent.parent.name, 'JSXIdentifier') && iconPropsinNewButton.includes(node.parent.parent.name.name) && (0, _eslintCodemodUtils.isNodeOfType)(node.parent.parent.parent, 'JSXOpeningElement') && (0, _eslintCodemodUtils.isNodeOfType)(node.parent.parent.parent.name, 'JSXIdentifier') && newButtonImports.has(node.parent.parent.parent.name.name)) {
+      // if it is in new Button then we can fix it
+      if (!errors.hasOwnProperty(node.name)) {
+        errors[node.name] = [];
+      }
+      errors[node.name].push({
+        node: node,
+        messageId: 'noUtilityIconsReference',
+        localName: node.name,
+        fixable: true,
+        inNewButton: true
+      });
+      return;
+    }
+
+    // manually error
+    if (!errors.hasOwnProperty(node.name)) {
+      errors[node.name] = [];
+    }
+    errors[node.name].push({
+      node: node,
+      messageId: 'noUtilityIconsReference',
+      localName: node.name,
+      fixable: false,
+      inNewButton: false
+    });
+  };
+
+  /**
+   * Throws the relevant errors in the correct order.
+   */
+  var throwErrors = function throwErrors() {
+    var _loop = function _loop() {
+      var utilityIcon = _Object$keys[_i];
+      var allFixable = errors[utilityIcon].every(function (x) {
+        return x.fixable;
+      }); // Check if ALL errors for a giving import are fixable
+      var originalImportNode = importStatementsUtility[utilityIcon];
+      var oldImportName = importStatementsUtility[utilityIcon].source.value;
+      var newImportName = specialCases.hasOwnProperty(oldImportName) ? specialCases[oldImportName] : oldImportName.replace('@atlaskit/icon/utility/', '@atlaskit/icon/core/');
+      var existingImport = importStatementsCore.hasOwnProperty(newImportName) ? importStatementsCore[newImportName].localName : null;
+      var replacementImportName = existingImport ? existingImport : allFixable ? utilityIcon : "".concat(utilityIcon, "Core");
+      var importFixAdded = false;
+      var _iterator4 = _createForOfIteratorHelper(errors[utilityIcon].entries()),
+        _step4;
+      try {
+        var _loop2 = function _loop2() {
+          var _step4$value = (0, _slicedToArray2.default)(_step4.value, 2),
+            index = _step4$value[0],
+            error = _step4$value[1];
+          if (error.fixable) {
+            context.report({
+              node: error.node,
+              messageId: error.messageId,
+              fix: function fix(fixer) {
+                var fixes = [];
+
+                // Add a new import statement if it doesn't already exist
+                if (!existingImport && !importFixAdded) {
+                  importFixAdded = true;
+                  fixes.push(fixer.insertTextBeforeRange([0, 0], "import ".concat(replacementImportName, " from '").concat(newImportName, "';\n")));
+                }
+
+                // Handle JSX elements differently if they are in a "new Button"
+                if (error.inNewButton) {
+                  // Replace the icon with a function that wraps it with iconProps and size="small"
+                  var wrappedIcon = "(iconProps) => <".concat(replacementImportName, " label=\"\" {...iconProps} size=\"small\" />");
+                  fixes.push(fixer.replaceText(error.node, wrappedIcon));
+                } else if ((0, _eslintCodemodUtils.isNodeOfType)(error.node, 'JSXElement') && (0, _eslintCodemodUtils.isNodeOfType)(error.node.openingElement.name, 'JSXIdentifier')) {
+                  // Replace the JSX element's closing tag with size="small"
+                  var newOpeningElementText = context.sourceCode.getText(error.node.openingElement).replace(/\s*\/\s*>$/, " size=\"small\"/>").replace(new RegExp('<\s*' + error.node.openingElement.name.name), "<".concat(replacementImportName));
+                  fixes.push(fixer.replaceText(error.node.openingElement, newOpeningElementText));
+                }
+
+                // Handle the first fixable error for import removal if all fixable for this import
+                if (index === 0 && allFixable) {
+                  fixes.push(fixer.remove(originalImportNode));
+                }
+                return fixes;
+              }
+            });
+          } else {
+            // Report non-fixable errors
+            context.report({
+              node: error.node,
+              messageId: error.messageId
+            });
+          }
+        };
+        for (_iterator4.s(); !(_step4 = _iterator4.n()).done;) {
+          _loop2();
+        }
+      } catch (err) {
+        _iterator4.e(err);
+      } finally {
+        _iterator4.f();
+      }
+    };
+    for (var _i = 0, _Object$keys = Object.keys(errors); _i < _Object$keys.length; _i++) {
+      _loop();
+    }
+
+    // If other utility icons are imported but there were no errors for them - (this should only be unused imports but good to have as a backup), report them
+    var otherUtilityImportsWithoutErrors = Object.keys(importStatementsUtility).filter(function (utilityIcon) {
+      return !errors.hasOwnProperty(utilityIcon);
+    });
+    var _iterator5 = _createForOfIteratorHelper(otherUtilityImportsWithoutErrors),
+      _step5;
+    try {
+      for (_iterator5.s(); !(_step5 = _iterator5.n()).done;) {
+        var utilityIcon = _step5.value;
+        context.report({
+          node: importStatementsUtility[utilityIcon],
+          messageId: 'noUtilityIconsImport'
+        });
+      }
+    } catch (err) {
+      _iterator5.e(err);
+    } finally {
+      _iterator5.f();
+    }
+  };
+  return {
+    checkImportDeclarations: checkImportDeclarations,
+    checkJSXElement: checkJSXElement,
+    checkIconReference: checkIconReference,
+    throwErrors: throwErrors
+  };
+};

package/dist/cjs/rules/no-utility-icons/index.js

@@ -0,0 +1,40 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+var _createRule = require("../utils/create-rule");
+var _checks = require("./checks");
+var rule = (0, _createRule.createLintRule)({
+  meta: {
+    name: 'no-utility-icons',
+    fixable: 'code',
+    hasSuggestions: true,
+    type: 'problem',
+    docs: {
+      description: 'Disallow use of deprecated utility icons, in favor of core icons with `size="small"`.',
+      recommended: true,
+      severity: 'warn'
+    },
+    messages: {
+      noUtilityIconsJSXElement: "Utility icons are deprecated. Please use core icons instead with the size prop set to small.",
+      noUtilityIconsImport: "Utility icons are deprecated. Please do not import them, use core icons instead.",
+      noUtilityIconsReference: "Utility icons are deprecated. To replace them, please use core icons with the size prop set to small instead."
+    }
+  },
+  create: function create(context) {
+    var _createChecks = (0, _checks.createChecks)(context),
+      checkImportDeclarations = _createChecks.checkImportDeclarations,
+      checkJSXElement = _createChecks.checkJSXElement,
+      checkIconReference = _createChecks.checkIconReference,
+      throwErrors = _createChecks.throwErrors;
+    return {
+      ImportDeclaration: checkImportDeclarations,
+      JSXElement: checkJSXElement,
+      Identifier: checkIconReference,
+      'Program:exit': throwErrors
+    };
+  }
+});
+var _default = exports.default = rule;

package/dist/cjs/rules/utils/get-deprecated-config.js

@@ -17,7 +17,7 @@ var getConfig = exports.getConfig = function getConfig(specifier) {
   var source = _fs.default.readFileSync(configPath, 'utf8');
   var parsedConfig = JSON.parse(source);
   var combinedConfig = _objectSpread(_objectSpread({}, parsedConfig), {}, {
-    imports: _objectSpread(_objectSpread(_objectSpread(_objectSpread({}, parsedConfig.imports), _deprecatedMap2.deprecatedCore), _deprecatedMap2.deprecatedUtility), _deprecatedMap.deprecatedCore)
+    imports: _objectSpread(_objectSpread(_objectSpread(_objectSpread(_objectSpread({}, parsedConfig.imports), _deprecatedMap2.deprecatedCore), _deprecatedMap2.deprecatedUtility), _deprecatedMap.deprecatedCore), _deprecatedMap.deprecatedUtility)
   });
   return combinedConfig[specifier];
 };

package/dist/es2019/presets/all-flat.codegen.js

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::c6c896451f2be4d48f04068f5bbb85f1>>
+ * @codegen <<SignedSource::5ceb45b21744434ca96a850461a3c574>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 
@@ -12,6 +12,7 @@ export default {
     '@atlaskit/design-system/ensure-design-token-usage': 'error',
     '@atlaskit/design-system/ensure-design-token-usage/preview': 'warn',
     '@atlaskit/design-system/ensure-icon-color': 'error',
+    '@atlaskit/design-system/ensure-proper-xcss-usage': 'error',
     '@atlaskit/design-system/icon-label': 'warn',
     '@atlaskit/design-system/no-banned-imports': 'error',
     '@atlaskit/design-system/no-boolean-autofocus-on-modal-dialog': 'warn',
@@ -47,6 +48,7 @@ export default {
     '@atlaskit/design-system/no-unsafe-design-token-usage': 'error',
     '@atlaskit/design-system/no-unsafe-style-overrides': 'warn',
     '@atlaskit/design-system/no-unsupported-drag-and-drop-libraries': 'error',
+    '@atlaskit/design-system/no-utility-icons': 'warn',
     '@atlaskit/design-system/prefer-primitives': 'warn',
     '@atlaskit/design-system/use-button-group-label': 'warn',
     '@atlaskit/design-system/use-cx-function-in-xcss': 'error',

package/dist/es2019/presets/all.codegen.js

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::d4de619ac262298b2af11f905a02b0dd>>
+ * @codegen <<SignedSource::b96d8bb5115de6e0a230feef152a1365>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 
@@ -11,6 +11,7 @@ export default {
     '@atlaskit/design-system/ensure-design-token-usage': 'error',
     '@atlaskit/design-system/ensure-design-token-usage/preview': 'warn',
     '@atlaskit/design-system/ensure-icon-color': 'error',
+    '@atlaskit/design-system/ensure-proper-xcss-usage': 'error',
     '@atlaskit/design-system/icon-label': 'warn',
     '@atlaskit/design-system/no-banned-imports': 'error',
     '@atlaskit/design-system/no-boolean-autofocus-on-modal-dialog': 'warn',
@@ -46,6 +47,7 @@ export default {
     '@atlaskit/design-system/no-unsafe-design-token-usage': 'error',
     '@atlaskit/design-system/no-unsafe-style-overrides': 'warn',
     '@atlaskit/design-system/no-unsupported-drag-and-drop-libraries': 'error',
+    '@atlaskit/design-system/no-utility-icons': 'warn',
     '@atlaskit/design-system/prefer-primitives': 'warn',
     '@atlaskit/design-system/use-button-group-label': 'warn',
     '@atlaskit/design-system/use-cx-function-in-xcss': 'error',

package/dist/es2019/presets/recommended-flat.codegen.js

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::af96131434aa77c7882ceb200e4e2cf1>>
+ * @codegen <<SignedSource::10f372e16c048db9bfb1bc36cf48421c>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 
@@ -36,6 +36,7 @@ export default {
     '@atlaskit/design-system/no-unsafe-design-token-usage': 'error',
     '@atlaskit/design-system/no-unsafe-style-overrides': 'warn',
     '@atlaskit/design-system/no-unsupported-drag-and-drop-libraries': 'error',
+    '@atlaskit/design-system/no-utility-icons': 'warn',
     '@atlaskit/design-system/use-button-group-label': 'warn',
     '@atlaskit/design-system/use-cx-function-in-xcss': 'error',
     '@atlaskit/design-system/use-datetime-picker-calendar-button': 'warn',