@atlaskit/eslint-plugin-design-system 10.9.0 → 10.10.1

package/dist/es2019/rules/no-legacy-icons/index.js

@@ -27,17 +27,16 @@ const rule = createLintRule({
       additionalProperties: false
     }],
     messages: {
-      noLegacyIconsAutoMigration: `Auto Migration:\nLegacy icon '{{iconName}}' from '{{importSource}}' detected.\nAutomatic migration is possible to '{{newIcon}}' from '{{newPackage}}.\nAtlassians: See https://go.atlassian.com/icon-migration-guide for details.'`,
-      noLegacyIconsManualMigration: `Manual Migration:\nLegacy icon '{{iconName}}' from '{{importSource}}' detected.\nAutomatic migration not possible.{{quietModeGuidance}}.\nAtlassians: See https://go.atlassian.com/icon-migration-guide for details.`,
-      cantFindSuitableReplacement: `No suitable replacement found for '{{iconName}}' from '{{importSource}}' at the size listed. Please manually migrate this icon.`,
+      noLegacyIconsAutoMigration: `Auto Migration:\nLegacy icon '{{iconName}}' from '{{importSource}}' detected.\nAutomatic migration is possible.\n\n{{guidance}}\nAtlassians: See https://go.atlassian.com/icon-migration-guide for details.'`,
+      noLegacyIconsManualMigration: `Manual Migration:\nLegacy icon '{{iconName}}' from '{{importSource}}' detected.\nAutomatic migration not possible.\n\n{{guidance}}\nAtlassians: See https://go.atlassian.com/icon-migration-guide for details.`,
+      cantFindSuitableReplacement: `No suitable replacement found for '{{iconName}}' from '{{importSource}}'{{sizeGuidance}}. Please manually migrate this icon.`,
       cantMigrateReExport: `'{{exportName}}' is a re-export of icon from '{{packageName}}' and cannot be automatically migrated. Please utilize the export from icons directly.`,
       cantMigrateColor: `Primary Color prop has {{colorValue}} which cannot be automatically migrated to color prop in the new Icon API. Please use either an appropriate color.icon, color.link token, or currentColor (as a last resort).`,
       cantMigrateSpreadProps: `This usage of Icon uses spread props in a way that can't be automatically migrated. Please explicitly define the following props after spread: '{{missingProps}}' `,
       cantMigrateSizeUnknown: `This usage of Icon sets the size via a variable or function that can't be determined.`,
       cantMigrateFunctionUnknown: `'{{iconName}}' from legacy '{{importSource}}' is used in unknown function/component. Please manually migrate this icon.`,
       cantMigrateIdentifier: `This icon is passed to other components via a map or array, in a way that can't be automatically migrated. Please manually migrate wherever this expression is used and use the icon components directly.`,
-      cantMigrateUnsafeProp: `Property '{{propName}}' with value of '{{value}}' is unable to be auto-migrated to the new button. Please manually migrate this icon.`,
-      guidance: `Guidance:\n'{{guidance}}'`
+      cantMigrateUnsafeProp: `Property '{{propName}}' with value of '{{value}}' is unable to be auto-migrated to the new button. Please manually migrate this icon.`
     }
   },
   create(context) {
@@ -56,77 +55,23 @@ const rule = createLintRule({
       checkCallExpression,
       throwErrors
     } = createChecks(context);
-    return {
+    return errorBoundary({
       // Track imports of relevant components
-      ImportDeclaration(node) {
-        errorBoundary(() => checkImportDeclarations(node), {
-          config: {
-            failSilently
-          }
-        });
-      },
+      ImportDeclaration: checkImportDeclarations,
       // Keep track of the relevant variable declarations and renames
-      VariableDeclaration(node) {
-        errorBoundary(() => checkVariableDeclarations(node), {
-          config: {
-            failSilently
-          }
-        });
-      },
+      VariableDeclaration: checkVariableDeclarations,
       // Case: default re-exports. Can't be auto-migrated
-      ExportDefaultDeclaration(node) {
-        errorBoundary(() => checkExportDefaultDeclaration(node), {
-          config: {
-            failSilently
-          }
-        });
-      },
-      ExportNamedDeclaration(node) {
-        errorBoundary(() => checkExportNamedVariables(node), {
-          config: {
-            failSilently
-          }
-        });
-      },
+      ExportDefaultDeclaration: checkExportDefaultDeclaration,
+      ExportNamedDeclaration: checkExportNamedVariables,
       // Legacy icons found in arrays/objects
-      'ObjectExpression > Property > Identifier, ArrayExpression > Identifier ': node => {
-        errorBoundary(() => checkArrayOrMap(node), {
-          config: {
-            failSilently
-          }
-        });
-      },
+      'ObjectExpression > Property > Identifier, ArrayExpression > Identifier ': checkArrayOrMap,
       // Legacy icons passed in via props, as JSX identifier (i.e. icon={AddIcon})
-      'JSXOpeningElement > JSXAttribute > JSXExpressionContainer > Identifier': node => {
-        errorBoundary(() => checkIconAsProp(node), {
-          config: {
-            failSilently
-          }
-        });
-      },
-      JSXElement(node) {
-        errorBoundary(() => checkJSXElement(node), {
-          config: {
-            failSilently
-          }
-        });
-      },
+      'JSXOpeningElement > JSXAttribute > JSXExpressionContainer > Identifier': checkIconAsProp,
+      JSXElement: checkJSXElement,
       // Icons called as an argument of a function (i.e. icon={DefaultIcon(AddIcon)})
-      CallExpression: node => {
-        errorBoundary(() => checkCallExpression(node), {
-          config: {
-            failSilently
-          }
-        });
-      },
-      'Program:exit': () => {
-        errorBoundary(() => throwErrors(), {
-          config: {
-            failSilently
-          }
-        });
-      }
-    };
+      CallExpression: checkCallExpression,
+      'Program:exit': throwErrors
+    }, failSilently);
   }
 });
 export default rule;

package/dist/es2019/rules/use-tokens-typography/index.js

@@ -6,14 +6,10 @@ const create = context => {
   const config = getConfig(context.options[0]);
   return {
     // const styles = css({ fontSize: '14px, ... }), styled.div({ fontSize: 14, ... })
-    ObjectExpression: node => errorBoundary(() => {
-      return StyleObject.lint(node, {
-        context,
-        config
-      });
-    }, {
+    ObjectExpression: errorBoundary(node => StyleObject.lint(node, {
+      context,
       config
-    })
+    }), config)
   };
 };
 const rule = createLintRule({

package/dist/es2019/rules/utils/error-boundary.js

@@ -1,3 +1,9 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+
+// Need to intersect type RuleListener with a generic function to allow use of Parameters<...> to be used
+
+// Allow config to be to be easily passed from rules
+
 /**
  * ESLint rules should NEVER throw exceptions, because that breaks the VSCode ESLint server
  * (and probably the IntelliJ one too), which causes linting to fail in a file.
@@ -5,15 +11,53 @@
  * It also breaks CI, which was the reason this error boundary was added. It's a final
  * catch all.
  */
-export const errorBoundary = (func, {
-  config
-}) => {
-  try {
-    func();
-  } catch (err) {
-    if (!config.failSilently) {
-      // eslint-disable-next-line no-console
-      console.warn(err);
-    }
+export function errorBoundary(ruleOrRules, config = false) {
+  const failSilently = failSilentlyFromConfig(config);
+  if (isSingleRuleListener(ruleOrRules)) {
+    return wrapSingleRuleListener(ruleOrRules, failSilently);
+  }
+  return wrapRuleListener(ruleOrRules, failSilently);
+}
+function isSingleRuleListener(rule) {
+  return typeof rule === 'function';
+}
+function failSilentlyFromConfig(c) {
+  switch (typeof c) {
+    case 'undefined':
+      return false;
+    case 'boolean':
+      return c;
+    case 'object':
+      if ('failSilently' in c) {
+        var _c$failSilently;
+        return (_c$failSilently = c.failSilently) !== null && _c$failSilently !== void 0 ? _c$failSilently : false;
+      } else if ('config' in c) {
+        var _c$config$failSilentl;
+        return (_c$config$failSilentl = c.config.failSilently) !== null && _c$config$failSilentl !== void 0 ? _c$config$failSilentl : false;
+      }
+      return false;
+    default:
+      throw new Error('Invalid config');
   }
-};
+}
+function wrapSingleRuleListener(rule, failSilently) {
+  return (...args) => {
+    try {
+      rule(...args);
+    } catch (err) {
+      if (!failSilently) {
+        // eslint-disable-next-line no-console
+        console.warn(err);
+      }
+    }
+  };
+}
+function wrapRuleListener(ruleListener, failSilently) {
+  return Object.entries(ruleListener).reduce((wrappedRuleListener, e) => {
+    const ruleName = e[0];
+    const rule = e[1];
+    return Object.assign(wrappedRuleListener, {
+      [ruleName]: wrapSingleRuleListener(rule, failSilently)
+    });
+  }, {});
+}

package/dist/esm/presets/all.codegen.js

@@ -1,6 +1,6 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::9bb5329713677543f16019954484ae2f>>
+ * @codegen <<SignedSource::ab43b6e1a867d07b9a27eae78d48834a>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 export default {
@@ -12,6 +12,7 @@ export default {
     '@atlaskit/design-system/icon-label': 'warn',
     '@atlaskit/design-system/no-banned-imports': 'error',
     '@atlaskit/design-system/no-css-tagged-template-expression': 'error',
+    '@atlaskit/design-system/no-custom-icons': 'warn',
     '@atlaskit/design-system/no-deprecated-apis': 'error',
     '@atlaskit/design-system/no-deprecated-design-token-usage': 'warn',
     '@atlaskit/design-system/no-deprecated-imports': 'error',