@atlaskit/eslint-plugin-design-system 10.22.0 → 10.23.0

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 10.23.0
+
+### Minor Changes
+
+- [#153668](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/153668)
+  [`a6c96d74835d5`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/a6c96d74835d5) -
+  Added a flat config preset equivalents for included eslint configs
+- [#153712](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/153712)
+  [`566eb89dd2b9f`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/566eb89dd2b9f) -
+  Introducing new rule to warn the combination of separator and `as="li|ol|dl"`
+
+## 10.22.1
+
+### Patch Changes
+
+- [#153007](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/153007)
+  [`89e8b9b297149`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/89e8b9b297149) -
+  Update `ensure-design-token-usage` rule to avoid false positive with Icon Tile component
+
 ## 10.22.0
 
 ### Minor Changes

package/README.md

@@ -73,6 +73,7 @@ module.exports = {
 | <a href="./src/rules/no-margin/README.md">no-margin</a>                                                                     | Disallow using the margin CSS property.                                                                                                                                                                                                                                                                             |             |         |             |
 | <a href="./src/rules/no-nested-styles/README.md">no-nested-styles</a>                                                       | Disallows use of nested styles in `css` functions.                                                                                                                                                                                                                                                                  | Yes         |         |             |
 | <a href="./src/rules/no-physical-properties/README.md">no-physical-properties</a>                                           | Disallow physical properties and values in `css` function calls.                                                                                                                                                                                                                                                    |             | Yes     |             |
+| <a href="./src/rules/no-separator-with-list-elements/README.md">no-separator-with-list-elements</a>                         | Warn when the `separator` prop is used with `as="li"`, `as="ol"`, or `as="dl"` in the Inline component.                                                                                                                                                                                                             | Yes         |         |             |
 | <a href="./src/rules/no-styled-tagged-template-expression/README.md">no-styled-tagged-template-expression</a>               | Disallows any `styled` tagged template expressions that originate from Emotion, Styled Components or Compiled                                                                                                                                                                                                       |             | Yes     |             |
 | <a href="./src/rules/no-unsafe-design-token-usage/README.md">no-unsafe-design-token-usage</a>                               | Enforces design token usage is statically and locally analyzable.                                                                                                                                                                                                                                                   | Yes         | Yes     |             |
 | <a href="./src/rules/no-unsafe-style-overrides/README.md">no-unsafe-style-overrides</a>                                     | Discourage usage of unsafe style overrides used against the Atlassian Design System.                                                                                                                                                                                                                                | Yes         |         |             |

package/dist/cjs/index.codegen.js

@@ -4,23 +4,57 @@ var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefau
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.configs = void 0;
+exports.plugin = exports.name = exports.default = exports.configs = void 0;
 Object.defineProperty(exports, "rules", {
   enumerable: true,
   get: function get() {
-    return _index.default;
+    return _index.rules;
   }
 });
+exports.version = void 0;
+var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+var _allFlat = _interopRequireDefault(require("./presets/all-flat.codegen"));
 var _all = _interopRequireDefault(require("./presets/all.codegen"));
+var _recommendedFlat = _interopRequireDefault(require("./presets/recommended-flat.codegen"));
 var _recommended = _interopRequireDefault(require("./presets/recommended.codegen"));
-var _index = _interopRequireDefault(require("./rules/index.codegen"));
-/**
+var _index = require("./rules/index.codegen");
+function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
+function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::abdb6f8b0dfdc4e2489691c04488f46e>>
+ * @codegen <<SignedSource::7656123b732a9145dedb7f9eee588883>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
-
-var configs = exports.configs = {
-  all: _all.default,
-  recommended: _recommended.default
-};
+// this uses require because not all node versions this package supports use the same import assertions/attributes
+var pkgJson = require('../package.json');
+var version = exports.version = pkgJson.version,
+  name = exports.name = pkgJson.name;
+var plugin = exports.plugin = {
+  meta: {
+    name: name,
+    version: version
+  },
+  rules: _index.rules,
+  // flat configs need to be done like this so they can get a reference to the plugin.
+  // see here: https://eslint.org/docs/latest/extend/plugins#configs-in-plugins
+  // they cannot use `Object.assign` because it will not work with the getter
+  configs: {
+    all: _all.default,
+    'all/flat': _objectSpread(_objectSpread({}, _allFlat.default), {}, {
+      plugins: _objectSpread(_objectSpread({}, _allFlat.default.plugins), {}, {
+        get '@atlaskit/design-system'() {
+          return plugin;
+        }
+      })
+    }),
+    recommended: _recommended.default,
+    'recommended/flat': _objectSpread(_objectSpread({}, _recommendedFlat.default), {}, {
+      plugins: _objectSpread(_objectSpread({}, _recommendedFlat.default.plugins), {}, {
+        get '@atlaskit/design-system'() {
+          return plugin;
+        }
+      })
+    })
+  }
+};
+var configs = exports.configs = plugin.configs;
+var _default = exports.default = plugin;

package/dist/cjs/index.js

@@ -1,5 +1,6 @@
 "use strict";
 
+var _typeof = require("@babel/runtime/helpers/typeof");
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
@@ -9,17 +10,43 @@ Object.defineProperty(exports, "configs", {
     return _index.configs;
   }
 });
+Object.defineProperty(exports, "default", {
+  enumerable: true,
+  get: function get() {
+    return _index.default;
+  }
+});
 Object.defineProperty(exports, "filterActionableDeprecations", {
   enumerable: true,
   get: function get() {
     return _filterActionableDeprecations.filterActionableDeprecations;
   }
 });
+Object.defineProperty(exports, "name", {
+  enumerable: true,
+  get: function get() {
+    return _index.name;
+  }
+});
+Object.defineProperty(exports, "plugin", {
+  enumerable: true,
+  get: function get() {
+    return _index.plugin;
+  }
+});
 Object.defineProperty(exports, "rules", {
   enumerable: true,
   get: function get() {
     return _index.rules;
   }
 });
-var _index = require("./index.codegen");
-var _filterActionableDeprecations = require("./rules/no-deprecated-apis/helpers/filter-actionable-deprecations");
+Object.defineProperty(exports, "version", {
+  enumerable: true,
+  get: function get() {
+    return _index.version;
+  }
+});
+var _index = _interopRequireWildcard(require("./index.codegen"));
+var _filterActionableDeprecations = require("./rules/no-deprecated-apis/helpers/filter-actionable-deprecations");
+function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
+function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }

package/dist/cjs/presets/all-flat.codegen.js

@@ -0,0 +1,61 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+/**
+ * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
+ * @codegen <<SignedSource::56a9d309ec6f548dce4a4f6e99059a15>>
+ * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
+ */
+var _default = exports.default = {
+  // NOTE: The reference to this plugin is inserted dynamically while creating the plugin in `index.codegen.tsx`
+  plugins: {},
+  rules: {
+    '@atlaskit/design-system/consistent-css-prop-usage': 'error',
+    '@atlaskit/design-system/ensure-design-token-usage': 'error',
+    '@atlaskit/design-system/ensure-design-token-usage/preview': 'warn',
+    '@atlaskit/design-system/ensure-icon-color': 'error',
+    '@atlaskit/design-system/icon-label': 'warn',
+    '@atlaskit/design-system/no-banned-imports': 'error',
+    '@atlaskit/design-system/no-css-tagged-template-expression': 'error',
+    '@atlaskit/design-system/no-custom-icons': 'warn',
+    '@atlaskit/design-system/no-dark-theme-vr-tests': 'error',
+    '@atlaskit/design-system/no-deprecated-apis': 'error',
+    '@atlaskit/design-system/no-deprecated-design-token-usage': 'warn',
+    '@atlaskit/design-system/no-deprecated-imports': 'error',
+    '@atlaskit/design-system/no-direct-use-of-web-platform-drag-and-drop': 'error',
+    '@atlaskit/design-system/no-html-anchor': 'warn',
+    '@atlaskit/design-system/no-html-button': 'warn',
+    '@atlaskit/design-system/no-invalid-css-map': ['error', {
+      allowedFunctionCalls: [['@atlaskit/tokens', 'token']]
+    }],
+    '@atlaskit/design-system/no-keyframes-tagged-template-expression': 'error',
+    '@atlaskit/design-system/no-legacy-icons': 'warn',
+    '@atlaskit/design-system/no-margin': 'warn',
+    '@atlaskit/design-system/no-nested-styles': 'error',
+    '@atlaskit/design-system/no-physical-properties': 'error',
+    '@atlaskit/design-system/no-separator-with-list-elements': 'warn',
+    '@atlaskit/design-system/no-styled-tagged-template-expression': 'error',
+    '@atlaskit/design-system/no-unsafe-design-token-usage': 'error',
+    '@atlaskit/design-system/no-unsafe-style-overrides': 'warn',
+    '@atlaskit/design-system/no-unsupported-drag-and-drop-libraries': 'error',
+    '@atlaskit/design-system/prefer-primitives': 'warn',
+    '@atlaskit/design-system/use-button-group-label': 'warn',
+    '@atlaskit/design-system/use-drawer-label': 'warn',
+    '@atlaskit/design-system/use-heading': 'warn',
+    '@atlaskit/design-system/use-heading-level-in-spotlight-card': 'warn',
+    '@atlaskit/design-system/use-href-in-link-item': 'warn',
+    '@atlaskit/design-system/use-latest-xcss-syntax': 'error',
+    '@atlaskit/design-system/use-latest-xcss-syntax-typography': 'warn',
+    '@atlaskit/design-system/use-menu-section-title': 'warn',
+    '@atlaskit/design-system/use-popup-label': 'warn',
+    '@atlaskit/design-system/use-primitives': 'warn',
+    '@atlaskit/design-system/use-primitives-text': 'warn',
+    '@atlaskit/design-system/use-tag-group-label': 'warn',
+    '@atlaskit/design-system/use-tokens-space': 'error',
+    '@atlaskit/design-system/use-tokens-typography': 'warn',
+    '@atlaskit/design-system/use-visually-hidden': 'error'
+  }
+};

package/dist/cjs/presets/all.codegen.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.default = void 0;
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::310e184a1b8eca0da1246cfe8d128e2c>>
+ * @codegen <<SignedSource::47f018ad98455be31dc522bcf5360adf>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 var _default = exports.default = {
@@ -35,6 +35,7 @@ var _default = exports.default = {
     '@atlaskit/design-system/no-margin': 'warn',
     '@atlaskit/design-system/no-nested-styles': 'error',
     '@atlaskit/design-system/no-physical-properties': 'error',
+    '@atlaskit/design-system/no-separator-with-list-elements': 'warn',
     '@atlaskit/design-system/no-styled-tagged-template-expression': 'error',
     '@atlaskit/design-system/no-unsafe-design-token-usage': 'error',
     '@atlaskit/design-system/no-unsafe-style-overrides': 'warn',

package/dist/cjs/presets/recommended-flat.codegen.js

@@ -0,0 +1,45 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+/**
+ * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
+ * @codegen <<SignedSource::9c6dda34a88386c4fa5b931ab4baf929>>
+ * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
+ */
+var _default = exports.default = {
+  // NOTE: The reference to this plugin is inserted dynamically while creating the plugin in `index.codegen.tsx`
+  plugins: {},
+  rules: {
+    '@atlaskit/design-system/consistent-css-prop-usage': 'error',
+    '@atlaskit/design-system/ensure-design-token-usage': 'error',
+    '@atlaskit/design-system/icon-label': 'warn',
+    '@atlaskit/design-system/no-banned-imports': 'error',
+    '@atlaskit/design-system/no-deprecated-apis': 'error',
+    '@atlaskit/design-system/no-deprecated-design-token-usage': 'warn',
+    '@atlaskit/design-system/no-deprecated-imports': 'error',
+    '@atlaskit/design-system/no-direct-use-of-web-platform-drag-and-drop': 'error',
+    '@atlaskit/design-system/no-html-anchor': 'warn',
+    '@atlaskit/design-system/no-html-button': 'warn',
+    '@atlaskit/design-system/no-invalid-css-map': ['error', {
+      allowedFunctionCalls: [['@atlaskit/tokens', 'token']]
+    }],
+    '@atlaskit/design-system/no-nested-styles': 'error',
+    '@atlaskit/design-system/no-separator-with-list-elements': 'warn',
+    '@atlaskit/design-system/no-unsafe-design-token-usage': 'error',
+    '@atlaskit/design-system/no-unsafe-style-overrides': 'warn',
+    '@atlaskit/design-system/no-unsupported-drag-and-drop-libraries': 'error',
+    '@atlaskit/design-system/use-button-group-label': 'warn',
+    '@atlaskit/design-system/use-drawer-label': 'warn',
+    '@atlaskit/design-system/use-heading-level-in-spotlight-card': 'warn',
+    '@atlaskit/design-system/use-href-in-link-item': 'warn',
+    '@atlaskit/design-system/use-latest-xcss-syntax': 'error',
+    '@atlaskit/design-system/use-latest-xcss-syntax-typography': 'warn',
+    '@atlaskit/design-system/use-menu-section-title': 'warn',
+    '@atlaskit/design-system/use-popup-label': 'warn',
+    '@atlaskit/design-system/use-tag-group-label': 'warn',
+    '@atlaskit/design-system/use-visually-hidden': 'error'
+  }
+};

package/dist/cjs/presets/recommended.codegen.js

@@ -6,7 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.default = void 0;
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::9be7e90918082d78473f5d2a2271b15c>>
+ * @codegen <<SignedSource::f1b4aa9e656294739485e62ba4a33f9d>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
 var _default = exports.default = {
@@ -26,6 +26,7 @@ var _default = exports.default = {
       allowedFunctionCalls: [['@atlaskit/tokens', 'token']]
     }],
     '@atlaskit/design-system/no-nested-styles': 'error',
+    '@atlaskit/design-system/no-separator-with-list-elements': 'warn',
     '@atlaskit/design-system/no-unsafe-design-token-usage': 'error',
     '@atlaskit/design-system/no-unsafe-style-overrides': 'warn',
     '@atlaskit/design-system/no-unsupported-drag-and-drop-libraries': 'error',

package/dist/cjs/rules/ensure-design-token-usage/color.js

@@ -148,7 +148,7 @@ var lintJSXLiteralForColor = exports.lintJSXLiteralForColor = function lintJSXLi
   if ((0, _isNode.isDecendantOfPrimitive)(node.parent, context)) {
     return;
   }
-  if (['alt', 'src', 'label', 'key'].includes(node.parent.name.name)) {
+  if (['alt', 'src', 'label', 'key', 'appearance'].includes(node.parent.name.name)) {
     return;
   }
   var isException = (0, _getIsException.getIsException)(config.exceptions);

package/dist/cjs/rules/index.codegen.js

@@ -4,7 +4,7 @@ var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefau
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.default = void 0;
+exports.rules = void 0;
 var _consistentCssPropUsage = _interopRequireDefault(require("./consistent-css-prop-usage"));
 var _ensureDesignTokenUsage = _interopRequireDefault(require("./ensure-design-token-usage"));
 var _ensureDesignTokenUsagePreview = _interopRequireDefault(require("./ensure-design-token-usage-preview"));
@@ -29,6 +29,7 @@ var _noLegacyIcons = _interopRequireDefault(require("./no-legacy-icons"));
 var _noMargin = _interopRequireDefault(require("./no-margin"));
 var _noNestedStyles = _interopRequireDefault(require("./no-nested-styles"));
 var _noPhysicalProperties = _interopRequireDefault(require("./no-physical-properties"));
+var _noSeparatorWithListElements = _interopRequireDefault(require("./no-separator-with-list-elements"));
 var _noStyledTaggedTemplateExpression = _interopRequireDefault(require("./no-styled-tagged-template-expression"));
 var _noUnsafeDesignTokenUsage = _interopRequireDefault(require("./no-unsafe-design-token-usage"));
 var _noUnsafeStyleOverrides = _interopRequireDefault(require("./no-unsafe-style-overrides"));
@@ -51,10 +52,11 @@ var _useTokensTypography = _interopRequireDefault(require("./use-tokens-typograp
 var _useVisuallyHidden = _interopRequireDefault(require("./use-visually-hidden"));
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::2c61c8c9aa86b4fb1d11e0bcba9d83a1>>
+ * @codegen <<SignedSource::2ab06b34c4e08cd70b0f67f5915f12c9>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
-var _default = exports.default = {
+
+var rules = exports.rules = {
   'consistent-css-prop-usage': _consistentCssPropUsage.default,
   'ensure-design-token-usage': _ensureDesignTokenUsage.default,
   'ensure-design-token-usage/preview': _ensureDesignTokenUsagePreview.default,
@@ -79,6 +81,7 @@ var _default = exports.default = {
   'no-margin': _noMargin.default,
   'no-nested-styles': _noNestedStyles.default,
   'no-physical-properties': _noPhysicalProperties.default,
+  'no-separator-with-list-elements': _noSeparatorWithListElements.default,
   'no-styled-tagged-template-expression': _noStyledTaggedTemplateExpression.default,
   'no-unsafe-design-token-usage': _noUnsafeDesignTokenUsage.default,
   'no-unsafe-style-overrides': _noUnsafeStyleOverrides.default,

package/dist/cjs/rules/no-legacy-icons/checks.js

@@ -392,14 +392,14 @@ var createChecks = exports.createChecks = function createChecks(context) {
         importSource: migrationIconImports[name].packageName,
         iconName: name,
         errors: errorsAuto,
-        shouldAddSpaciousSpacing: shouldAddSpaciousSpacing,
+        spacing: shouldAddSpaciousSpacing ? 'spacious' : undefined,
         insideNewButton: insideNewButton
       });
     }
 
     // Legacy icons rendered as JSX elements
     if (Object.keys(legacyIconImports).includes(name)) {
-      var _size, _size2, _sizeProp$value2;
+      var _size, _size2;
       // Determine if inside a new button - if so:
       // - Assume spread props are safe - still error if props explicitly set to unmigratable values
       var _insideNewButton = (0, _helpers.isInsideNewButton)(node, newButtonImports);
@@ -488,20 +488,32 @@ var createChecks = exports.createChecks = function createChecks(context) {
       var newIcon = migrationMapObject === null || migrationMapObject === void 0 ? void 0 : migrationMapObject.newIcon;
       var isNewIconMigratable = (0, _helpers.canAutoMigrateNewIconBasedOnSize)(upcomingIcon ? upcomingIcon.sizeGuidance[(_size = size) !== null && _size !== void 0 ? _size : 'medium'] : migrationMapObject === null || migrationMapObject === void 0 ? void 0 : migrationMapObject.sizeGuidance[(_size2 = size) !== null && _size2 !== void 0 ? _size2 : 'medium']);
 
-      // Add spacious spacing if:
-      // 1. size is medium, or not set (default is medium)
+      // Add spacing if:
+      // 1. size is medium for core/utility icons or small for utility icons, or not set (default is medium for core and small for utility icons)
       // 2. not inside a new or legacy button
       var _sizeProp = node.openingElement.attributes.find(function (attribute) {
         return attribute.type === 'JSXAttribute' && (attribute.name.name === 'size' || attribute.name.name === 'LEGACY_size');
       });
-      var _shouldAddSpaciousSpacing = (_sizeProp && _sizeProp.type === 'JSXAttribute' && ((_sizeProp$value2 = _sizeProp.value) === null || _sizeProp$value2 === void 0 ? void 0 : _sizeProp$value2.type) === 'Literal' && _sizeProp.value.value === 'medium' || !_sizeProp) && !_insideNewButton && !insideLegacyButton;
+      var spacing;
+      if (!_insideNewButton && !insideLegacyButton) {
+        var _sizeProp$value2;
+        if (_sizeProp && _sizeProp.type === 'JSXAttribute' && ((_sizeProp$value2 = _sizeProp.value) === null || _sizeProp$value2 === void 0 ? void 0 : _sizeProp$value2.type) === 'Literal') {
+          if (_sizeProp.value.value === 'medium') {
+            spacing = 'spacious';
+          } else if (_sizeProp.value.value === 'small' && (newIcon === null || newIcon === void 0 ? void 0 : newIcon.type) === 'utility') {
+            spacing = 'compact';
+          }
+        } else if (!_sizeProp) {
+          spacing = 'spacious';
+        }
+      }
       if (!hasManualMigration && (newIcon || upcomingIcon) && isNewIconMigratable) {
         (0, _helpers.createAutoMigrationError)({
           node: node,
           importSource: legacyIconImports[name].packageName,
           iconName: name,
           errors: errorsAuto,
-          shouldAddSpaciousSpacing: _shouldAddSpaciousSpacing,
+          spacing: spacing,
           insideNewButton: _insideNewButton
         });
       } else if ((!newIcon && !upcomingIcon || !isNewIconMigratable) && size) {

package/dist/cjs/rules/no-legacy-icons/helpers.js

@@ -279,7 +279,7 @@ var createAutoMigrationError = exports.createAutoMigrationError = function creat
     importSource = _ref4.importSource,
     iconName = _ref4.iconName,
     errors = _ref4.errors,
-    shouldAddSpaciousSpacing = _ref4.shouldAddSpaciousSpacing,
+    spacing = _ref4.spacing,
     insideNewButton = _ref4.insideNewButton;
   var myError = {
     node: node,
@@ -287,7 +287,7 @@ var createAutoMigrationError = exports.createAutoMigrationError = function creat
     data: {
       importSource: importSource,
       iconName: iconName,
-      spacing: shouldAddSpaciousSpacing ? 'spacious' : '',
+      spacing: spacing !== null && spacing !== void 0 ? spacing : '',
       // value type need to be a string in Rule.ReportDescriptor
       insideNewButton: String(insideNewButton)
     }
@@ -480,14 +480,11 @@ var createPropFixes = function createPropFixes(_ref7) {
     migrationImportNode = _ref7.migrationImportNode,
     newIconName = _ref7.newIconName;
   var fixes = [];
-  var importSource = metadata.importSource,
-    spacing = metadata.spacing,
+  var spacing = metadata.spacing,
     insideNewButton = metadata.insideNewButton;
   if (shouldUseMigrationPath && !legacyImportNode) {
     return fixes;
   }
-  var importPath = migrationImportNode ? importSource.replace('/migration', '').split('--')[0] : getNewIconNameAndImportPath(importSource, shouldUseMigrationPath).importPath;
-  var iconType = importPath !== null && importPath !== void 0 && importPath.startsWith('@atlaskit/icon/core') ? 'core' : 'utility';
   if (node.type === 'JSXElement') {
     var openingElement = node.openingElement;
     if (newIconName) {
@@ -519,7 +516,7 @@ var createPropFixes = function createPropFixes(_ref7) {
     // 4. icon is not imported from migration entrypoint
     var sizeProp = findProp(attributes, 'size');
     var spacingProp = findProp(attributes, 'spacing');
-    if (spacing && !spacingProp && iconType === 'core' && !migrationImportNode) {
+    if (spacing && !spacingProp && !migrationImportNode) {
       fixes.push(fixer.insertTextAfter(sizeProp || openingElement.name, " spacing=\"".concat(spacing, "\"")));
     }
     if (sizeProp && sizeProp.type === 'JSXAttribute') {

package/dist/cjs/rules/no-separator-with-list-elements/index.js

@@ -0,0 +1,62 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+var _eslintCodemodUtils = require("eslint-codemod-utils");
+var _createRule = require("../utils/create-rule");
+var separatorAsCombinationNotAllowed = 'The combination of `separator` with `as="li"`, `as="ol"`, or `as="dl"` is not allowed.';
+var rule = (0, _createRule.createLintRule)({
+  meta: {
+    name: 'no-separator-with-list-elements',
+    type: 'suggestion',
+    docs: {
+      description: 'Warn when the `separator` prop is used with `as="li"`, `as="ol"`, or `as="dl"` in the Inline component.',
+      recommended: true,
+      severity: 'warn'
+    },
+    messages: {
+      separatorAsCombinationNotAllowed: separatorAsCombinationNotAllowed
+    }
+  },
+  create: function create(context) {
+    var inlineComponentNames = [];
+    return {
+      ImportDeclaration: function ImportDeclaration(node) {
+        if (node.type === 'ImportDeclaration' && (node.source.value === '../src' || node.source.value === '@atlaskit/primitives')) {
+          node.specifiers.forEach(function (specifier) {
+            if (specifier.type === 'ImportSpecifier' && specifier.imported.name === 'Inline') {
+              inlineComponentNames.push(specifier.local.name);
+            }
+          });
+        }
+      },
+      JSXElement: function JSXElement(node) {
+        if (!(0, _eslintCodemodUtils.isNodeOfType)(node, 'JSXElement') || !(0, _eslintCodemodUtils.isNodeOfType)(node.openingElement.name, 'JSXIdentifier')) {
+          return;
+        }
+        var componentName = node.openingElement.name.name;
+        if (!inlineComponentNames.includes(componentName)) {
+          return;
+        }
+        var inlineProps = node.openingElement.attributes.filter(function (attr) {
+          return (0, _eslintCodemodUtils.isNodeOfType)(attr, 'JSXAttribute') && (0, _eslintCodemodUtils.isNodeOfType)(attr.name, 'JSXIdentifier');
+        });
+        var separatorProp = inlineProps.find(function (attr) {
+          return attr.name.name === 'separator';
+        });
+        var asProp = inlineProps.find(function (attr) {
+          return attr.name.name === 'as';
+        });
+        if (separatorProp && asProp && asProp.value && (0, _eslintCodemodUtils.isNodeOfType)(asProp.value, 'Literal') && ['li', 'ol', 'dl'].includes(asProp.value.value)) {
+          context.report({
+            node: node,
+            messageId: 'separatorAsCombinationNotAllowed'
+          });
+        }
+      }
+    };
+  }
+});
+var _default = exports.default = rule;

package/dist/es2019/index.codegen.js

@@ -1,12 +1,52 @@
 /**
  * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
- * @codegen <<SignedSource::abdb6f8b0dfdc4e2489691c04488f46e>>
+ * @codegen <<SignedSource::7656123b732a9145dedb7f9eee588883>>
  * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
  */
+import allFlat from './presets/all-flat.codegen';
 import all from './presets/all.codegen';
+import recommendedFlat from './presets/recommended-flat.codegen';
 import recommended from './presets/recommended.codegen';
-export { default as rules } from './rules/index.codegen';
-export const configs = {
-  all,
-  recommended
-};
+import { rules } from './rules/index.codegen';
+
+// this uses require because not all node versions this package supports use the same import assertions/attributes
+const pkgJson = require('../package.json');
+export const {
+  version,
+  name
+} = pkgJson;
+export const plugin = {
+  meta: {
+    name,
+    version
+  },
+  rules,
+  // flat configs need to be done like this so they can get a reference to the plugin.
+  // see here: https://eslint.org/docs/latest/extend/plugins#configs-in-plugins
+  // they cannot use `Object.assign` because it will not work with the getter
+  configs: {
+    all,
+    'all/flat': {
+      ...allFlat,
+      plugins: {
+        ...allFlat.plugins,
+        get '@atlaskit/design-system'() {
+          return plugin;
+        }
+      }
+    },
+    recommended,
+    'recommended/flat': {
+      ...recommendedFlat,
+      plugins: {
+        ...recommendedFlat.plugins,
+        get '@atlaskit/design-system'() {
+          return plugin;
+        }
+      }
+    }
+  }
+};
+export { rules } from './rules/index.codegen';
+export const configs = plugin.configs;
+export default plugin;

package/dist/es2019/index.js

@@ -1,2 +1,2 @@
-export { configs, rules } from './index.codegen';
+export { version, name, rules, plugin, configs, default } from './index.codegen';
 export { filterActionableDeprecations } from './rules/no-deprecated-apis/helpers/filter-actionable-deprecations';

package/dist/es2019/presets/all-flat.codegen.js

@@ -0,0 +1,55 @@
+/**
+ * THIS FILE WAS CREATED VIA CODEGEN DO NOT MODIFY {@see http://go/af-codegen}
+ * @codegen <<SignedSource::56a9d309ec6f548dce4a4f6e99059a15>>
+ * @codegenCommand yarn workspace @atlaskit/eslint-plugin-design-system codegen
+ */
+export default {
+  // NOTE: The reference to this plugin is inserted dynamically while creating the plugin in `index.codegen.tsx`
+  plugins: {},
+  rules: {
+    '@atlaskit/design-system/consistent-css-prop-usage': 'error',
+    '@atlaskit/design-system/ensure-design-token-usage': 'error',
+    '@atlaskit/design-system/ensure-design-token-usage/preview': 'warn',
+    '@atlaskit/design-system/ensure-icon-color': 'error',
+    '@atlaskit/design-system/icon-label': 'warn',
+    '@atlaskit/design-system/no-banned-imports': 'error',
+    '@atlaskit/design-system/no-css-tagged-template-expression': 'error',
+    '@atlaskit/design-system/no-custom-icons': 'warn',
+    '@atlaskit/design-system/no-dark-theme-vr-tests': 'error',
+    '@atlaskit/design-system/no-deprecated-apis': 'error',
+    '@atlaskit/design-system/no-deprecated-design-token-usage': 'warn',
+    '@atlaskit/design-system/no-deprecated-imports': 'error',
+    '@atlaskit/design-system/no-direct-use-of-web-platform-drag-and-drop': 'error',
+    '@atlaskit/design-system/no-html-anchor': 'warn',
+    '@atlaskit/design-system/no-html-button': 'warn',
+    '@atlaskit/design-system/no-invalid-css-map': ['error', {
+      allowedFunctionCalls: [['@atlaskit/tokens', 'token']]
+    }],
+    '@atlaskit/design-system/no-keyframes-tagged-template-expression': 'error',
+    '@atlaskit/design-system/no-legacy-icons': 'warn',
+    '@atlaskit/design-system/no-margin': 'warn',
+    '@atlaskit/design-system/no-nested-styles': 'error',
+    '@atlaskit/design-system/no-physical-properties': 'error',
+    '@atlaskit/design-system/no-separator-with-list-elements': 'warn',
+    '@atlaskit/design-system/no-styled-tagged-template-expression': 'error',
+    '@atlaskit/design-system/no-unsafe-design-token-usage': 'error',
+    '@atlaskit/design-system/no-unsafe-style-overrides': 'warn',
+    '@atlaskit/design-system/no-unsupported-drag-and-drop-libraries': 'error',
+    '@atlaskit/design-system/prefer-primitives': 'warn',
+    '@atlaskit/design-system/use-button-group-label': 'warn',
+    '@atlaskit/design-system/use-drawer-label': 'warn',
+    '@atlaskit/design-system/use-heading': 'warn',
+    '@atlaskit/design-system/use-heading-level-in-spotlight-card': 'warn',
+    '@atlaskit/design-system/use-href-in-link-item': 'warn',
+    '@atlaskit/design-system/use-latest-xcss-syntax': 'error',
+    '@atlaskit/design-system/use-latest-xcss-syntax-typography': 'warn',
+    '@atlaskit/design-system/use-menu-section-title': 'warn',
+    '@atlaskit/design-system/use-popup-label': 'warn',
+    '@atlaskit/design-system/use-primitives': 'warn',
+    '@atlaskit/design-system/use-primitives-text': 'warn',
+    '@atlaskit/design-system/use-tag-group-label': 'warn',
+    '@atlaskit/design-system/use-tokens-space': 'error',
+    '@atlaskit/design-system/use-tokens-typography': 'warn',
+    '@atlaskit/design-system/use-visually-hidden': 'error'
+  }
+};