@atlaskit/eslint-plugin-design-system 10.2.0 → 10.3.0

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 10.3.0
+
+### Minor Changes
+
+-   [#102286](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/102286)
+    [`8c56c1feba06`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/8c56c1feba06) -
+    Adds support for `role="button"` in `no-html-anchor` rule
+
+## 10.2.1
+
+### Patch Changes
+
+-   [#101749](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/101749)
+    [`08a34b7d741c`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/08a34b7d741c) -
+    use-primitives-text and use-heading lint rules to not target elements with no children.
+
 ## 10.2.0
 
 ### Minor Changes

package/constellation/no-html-anchor/usage.mdx

@@ -21,6 +21,12 @@ This rule marks code as violations when it finds native HTML anchor elements.
  ^ Using a native HTML `<a>`
   Hello, World!
 </a>
+
+<div role="link" tabIndex="0" data-href="https://www.atlassian.com">
+     ^^^^^^^^^^^ Using `role="link"` to create links
+  Hello, World!
+</div>
+
 ```
 
 ### Correct

package/constellation/no-unsafe-design-token-usage/usage.mdx

@@ -41,7 +41,7 @@ This rule comes with options to aid in migrating to design tokens.
 ### fallbackUsage
 
 -   `forced`: Fallback values must always be provided
--   `none`: Fallback values must never be provided. (Fixer will remove is provided)
+-   `none`: Fallback values must never be provided. (Fixer will remove if provided)
 -   `optional`: Fallbacks are optional
 
 ### shouldEnforceFallbacks (deprecated)

package/dist/cjs/rules/no-html-anchor/node-types/supported.js

@@ -11,6 +11,12 @@ function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != _typeof(e) && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 var supportedElements = [{
   name: 'a'
+}, {
+  name: '*',
+  attributes: [{
+    name: 'role',
+    values: ['link']
+  }]
 }];
 
 /**

package/dist/cjs/rules/use-heading/transformers/native-elements.js

@@ -53,6 +53,9 @@ var NativeElements = exports.NativeElements = {
     if (!(0, _eslintCodemodUtils.isNodeOfType)(node, 'JSXElement')) {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
     if (!node.parent) {
       return false;
     }

package/dist/cjs/rules/use-primitives-text/transformers/emphasis-elements.js

@@ -51,6 +51,9 @@ var EmphasisElements = exports.EmphasisElements = {
     if (elementName !== 'em') {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
 
     // Element has no unallowed props
     if (!ast.JSXElement.hasAllowedAttrsOnly(node, _common.allowedAttrs)) {

package/dist/cjs/rules/use-primitives-text/transformers/paragraph-elements.js

@@ -91,6 +91,14 @@ var ParagraphElements = exports.ParagraphElements = {
         }
       };
     }
+    if (!node.children.length) {
+      return {
+        success: false,
+        refs: {
+          siblings: []
+        }
+      };
+    }
 
     // All siblings have to be paragraph elements with no unallowed props
     if (!(0, _eslintCodemodUtils.isNodeOfType)(node.parent, 'JSXElement')) {

package/dist/cjs/rules/use-primitives-text/transformers/span-elements.js

@@ -51,6 +51,9 @@ var SpanElements = exports.SpanElements = {
     if (elementName !== 'span') {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
 
     // Element has no unallowed props
     if (!ast.JSXElement.hasAllowedAttrsOnly(node, _common.allowedAttrs)) {

package/dist/cjs/rules/use-primitives-text/transformers/strong-elements.js

@@ -51,6 +51,9 @@ var StrongElements = exports.StrongElements = {
     if (elementName !== 'strong') {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
 
     // Element has no unallowed props
     if (!ast.JSXElement.hasAllowedAttrsOnly(node, _common.allowedAttrs)) {

package/dist/es2019/rules/no-html-anchor/node-types/supported.js

@@ -2,6 +2,12 @@ import { isNodeOfType } from 'eslint-codemod-utils';
 import * as ast from '../../../ast-nodes';
 const supportedElements = [{
   name: 'a'
+}, {
+  name: '*',
+  attributes: [{
+    name: 'role',
+    values: ['link']
+  }]
 }];
 
 /**

package/dist/es2019/rules/use-heading/transformers/native-elements.js

@@ -44,6 +44,9 @@ export const NativeElements = {
     if (!isNodeOfType(node, 'JSXElement')) {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
     if (!node.parent) {
       return false;
     }

package/dist/es2019/rules/use-primitives-text/transformers/emphasis-elements.js

@@ -42,6 +42,9 @@ export const EmphasisElements = {
     if (elementName !== 'em') {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
 
     // Element has no unallowed props
     if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {

package/dist/es2019/rules/use-primitives-text/transformers/paragraph-elements.js

@@ -83,6 +83,14 @@ export const ParagraphElements = {
         }
       };
     }
+    if (!node.children.length) {
+      return {
+        success: false,
+        refs: {
+          siblings: []
+        }
+      };
+    }
 
     // All siblings have to be paragraph elements with no unallowed props
     if (!isNodeOfType(node.parent, 'JSXElement')) {

package/dist/es2019/rules/use-primitives-text/transformers/span-elements.js

@@ -42,6 +42,9 @@ export const SpanElements = {
     if (elementName !== 'span') {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
 
     // Element has no unallowed props
     if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {

package/dist/es2019/rules/use-primitives-text/transformers/strong-elements.js

@@ -42,6 +42,9 @@ export const StrongElements = {
     if (elementName !== 'strong') {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
 
     // Element has no unallowed props
     if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {

package/dist/esm/rules/no-html-anchor/node-types/supported.js

@@ -2,6 +2,12 @@ import { isNodeOfType } from 'eslint-codemod-utils';
 import * as ast from '../../../ast-nodes';
 var supportedElements = [{
   name: 'a'
+}, {
+  name: '*',
+  attributes: [{
+    name: 'role',
+    values: ['link']
+  }]
 }];
 
 /**

package/dist/esm/rules/use-heading/transformers/native-elements.js

@@ -43,6 +43,9 @@ export var NativeElements = {
     if (!isNodeOfType(node, 'JSXElement')) {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
     if (!node.parent) {
       return false;
     }

package/dist/esm/rules/use-primitives-text/transformers/emphasis-elements.js

@@ -41,6 +41,9 @@ export var EmphasisElements = {
     if (elementName !== 'em') {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
 
     // Element has no unallowed props
     if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {

package/dist/esm/rules/use-primitives-text/transformers/paragraph-elements.js

@@ -81,6 +81,14 @@ export var ParagraphElements = {
         }
       };
     }
+    if (!node.children.length) {
+      return {
+        success: false,
+        refs: {
+          siblings: []
+        }
+      };
+    }
 
     // All siblings have to be paragraph elements with no unallowed props
     if (!isNodeOfType(node.parent, 'JSXElement')) {

package/dist/esm/rules/use-primitives-text/transformers/span-elements.js

@@ -41,6 +41,9 @@ export var SpanElements = {
     if (elementName !== 'span') {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
 
     // Element has no unallowed props
     if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {

package/dist/esm/rules/use-primitives-text/transformers/strong-elements.js

@@ -41,6 +41,9 @@ export var StrongElements = {
     if (elementName !== 'strong') {
       return false;
     }
+    if (!node.children.length) {
+      return false;
+    }
 
     // Element has no unallowed props
     if (!ast.JSXElement.hasAllowedAttrsOnly(node, allowedAttrs)) {

package/dist/types/rules/use-heading/transformers/native-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement, JSXIdentifier, JSXOpeningElement } from 'eslint-codemod-utils';
+import { type JSXElement, type JSXIdentifier, type JSXOpeningElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 type ValidTags = 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6';
 interface ValidHeadingElement extends JSXElement {

package/dist/types/rules/use-primitives-text/transformers/emphasis-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement } from 'eslint-codemod-utils';
+import { type JSXElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 export declare const EmphasisElements: {
     lint(node: Rule.Node, { context, config }: MetaData): void;

package/dist/types/rules/use-primitives-text/transformers/paragraph-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement } from 'eslint-codemod-utils';
+import { type JSXElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 type CheckResult = {
     success: boolean;

package/dist/types/rules/use-primitives-text/transformers/span-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement } from 'eslint-codemod-utils';
+import { type JSXElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 export declare const SpanElements: {
     lint(node: Rule.Node, { context, config }: MetaData): void;

package/dist/types/rules/use-primitives-text/transformers/strong-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement } from 'eslint-codemod-utils';
+import { type JSXElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 export declare const StrongElements: {
     lint(node: Rule.Node, { context, config }: MetaData): void;

package/dist/types-ts4.5/rules/use-heading/transformers/native-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement, JSXIdentifier, JSXOpeningElement } from 'eslint-codemod-utils';
+import { type JSXElement, type JSXIdentifier, type JSXOpeningElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 type ValidTags = 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6';
 interface ValidHeadingElement extends JSXElement {

package/dist/types-ts4.5/rules/use-primitives-text/transformers/emphasis-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement } from 'eslint-codemod-utils';
+import { type JSXElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 export declare const EmphasisElements: {
     lint(node: Rule.Node, { context, config }: MetaData): void;

package/dist/types-ts4.5/rules/use-primitives-text/transformers/paragraph-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement } from 'eslint-codemod-utils';
+import { type JSXElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 type CheckResult = {
     success: boolean;

package/dist/types-ts4.5/rules/use-primitives-text/transformers/span-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement } from 'eslint-codemod-utils';
+import { type JSXElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 export declare const SpanElements: {
     lint(node: Rule.Node, { context, config }: MetaData): void;

package/dist/types-ts4.5/rules/use-primitives-text/transformers/strong-elements.d.ts

@@ -1,5 +1,5 @@
 import type { Rule } from 'eslint';
-import { JSXElement } from 'eslint-codemod-utils';
+import { type JSXElement } from 'eslint-codemod-utils';
 import { type MetaData } from './common';
 export declare const StrongElements: {
     lint(node: Rule.Node, { context, config }: MetaData): void;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@atlaskit/eslint-plugin-design-system",
   "description": "The essential plugin for use with the Atlassian Design System.",
-  "version": "10.2.0",
+  "version": "10.3.0",
   "author": "Atlassian Pty Ltd",
   "license": "Apache-2.0",
   "publishConfig": {
@@ -41,7 +41,7 @@
     "react": "^16.8.0 || ^17.0.0 || ~18.2.0"
   },
   "dependencies": {
-    "@atlaskit/eslint-utils": "^1.3.0",
+    "@atlaskit/eslint-utils": "^1.4.0",
     "@atlaskit/tokens": "*",
     "@babel/runtime": "^7.0.0",
     "@typescript-eslint/utils": "^5.48.1",