@atlaskit/eslint-plugin-design-system 10.12.0 → 10.12.2

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/eslint-plugin-design-system
 
+## 10.12.2
+
+### Patch Changes
+
+- [#124172](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/124172)
+  [`19b2005de7c1b`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/19b2005de7c1b) -
+  Wrap use-heading, use-primitives-text and use-latest-xcss-syntax-typography with an error boudary
+  to stop it breaking issue-automat CI.
+
+## 10.12.1
+
+### Patch Changes
+
+- [#124216](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/124216)
+  [`66f55374a6828`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/66f55374a6828) -
+  use-primitives-text bug fix for inline ESlint ignore statements.
+
 ## 10.12.0
 
 ### Minor Changes

package/dist/cjs/ast-nodes/jsx-element.js

@@ -63,12 +63,16 @@ var JSXElementHelper = exports.JSXElement = exports.JSXElementHelper = {
     return fix;
   },
   getChildren: function getChildren(node) {
-    // Filter out text children with whitespace characters only as JSX removes whitespace used for intendation
     var filteredChildren = node.children.filter(function (child) {
+      // Filter out text children with whitespace characters only as JSX removes whitespace used for intendation
       if ((0, _eslintCodemodUtils.isNodeOfType)(child, 'JSXText')) {
         var whiteSpaceChars = new RegExp('\\s', 'g');
         return !whiteSpaceChars.test(child.value);
       }
+      // Filter out empty JSX expressions, for example JSX expression containing comments only, including eslint ignore comments
+      if ((0, _eslintCodemodUtils.isNodeOfType)(child, 'JSXExpressionContainer')) {
+        return !(0, _eslintCodemodUtils.isNodeOfType)(child.expression, 'JSXEmptyExpression');
+      }
       return true;
     });
     return filteredChildren;

package/dist/cjs/rules/use-heading/config/index.js

@@ -5,6 +5,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.getConfig = void 0;
 var defaults = {
+  failSilently: false,
   patterns: ['native-elements'],
   enableUnsafeAutofix: false
 };

package/dist/cjs/rules/use-heading/index.js

@@ -5,6 +5,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 var _createRule = require("../utils/create-rule");
+var _errorBoundary = require("../utils/error-boundary");
 var _config = require("./config");
 var _transformers = require("./transformers");
 var docsUrl = 'https://atlassian.design/components/heading';
@@ -25,7 +26,7 @@ var rule = (0, _createRule.createLintRule)({
   },
   create: function create(context) {
     var config = (0, _config.getConfig)(context.options[0]);
-    return {
+    return (0, _errorBoundary.errorBoundary)({
       // transforms <h1>...</h1> usages
       'JSXElement[openingElement.name.name=/^h[0-6]$/]': function JSXElementOpeningElementNameNameH06$(node) {
         return _transformers.NativeElements.lint(node, {
@@ -33,7 +34,7 @@ var rule = (0, _createRule.createLintRule)({
           config: config
         });
       }
-    };
+    }, config);
   }
 });
 var _default = exports.default = rule;

package/dist/cjs/rules/use-latest-xcss-syntax-typography/config/index.js

@@ -0,0 +1,12 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.getConfig = void 0;
+var defaults = {
+  failSilently: false
+};
+var getConfig = exports.getConfig = function getConfig(overrides) {
+  return Object.assign({}, defaults, overrides);
+};

package/dist/cjs/rules/use-latest-xcss-syntax-typography/index.js

@@ -5,6 +5,8 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.error = exports.default = void 0;
 var _createRule = require("../utils/create-rule");
+var _errorBoundary = require("../utils/error-boundary");
+var _config = require("./config");
 var _linters = require("./linters");
 var error = exports.error = "Don't set fontSize, lineHeight, fontWeight properties on xcss. They are unsafe as they allow invalid combinations of typography tokens. There is ongoing work to make this a TypeScript error. Once that happens, you will have to delete/refactor anyway.";
 var rule = (0, _createRule.createLintRule)({
@@ -23,7 +25,8 @@ var rule = (0, _createRule.createLintRule)({
     }
   },
   create: function create(context) {
-    return {
+    var config = (0, _config.getConfig)(context.options[0]);
+    return (0, _errorBoundary.errorBoundary)({
       'CallExpression[callee.name="xcss"] ObjectExpression > Property > Identifier[name=/(fontSize|lineHeight|fontWeight)/]': function CallExpressionCalleeNameXcssObjectExpressionPropertyIdentifierNameFontSizeLineHeightFontWeight(node) {
         return _linters.BannedProperty.lint(node, {
           context: context
@@ -34,7 +37,7 @@ var rule = (0, _createRule.createLintRule)({
           context: context
         });
       }
-    };
+    }, config);
   }
 });
 var _default = exports.default = rule;

package/dist/cjs/rules/use-primitives-text/config/index.js

@@ -5,6 +5,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.getConfig = void 0;
 var defaults = {
+  failSilently: false,
   patterns: ['paragraph-elements', 'span-elements', 'strong-elements', 'emphasis-elements'],
   inheritColor: false,
   enableUnsafeAutofix: false

package/dist/cjs/rules/use-primitives-text/index.js

@@ -5,6 +5,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 var _createRule = require("../utils/create-rule");
+var _errorBoundary = require("../utils/error-boundary");
 var _config = require("./config");
 var _transformers = require("./transformers");
 var textDocsUrl = 'https://atlassian.design/components/primitives/text';
@@ -26,7 +27,7 @@ var rule = (0, _createRule.createLintRule)({
   },
   create: function create(context) {
     var config = (0, _config.getConfig)(context.options[0]);
-    return {
+    return (0, _errorBoundary.errorBoundary)({
       'JSXElement[openingElement.name.name=span]': function JSXElementOpeningElementNameNameSpan(node) {
         return _transformers.SpanElements.lint(node, {
           context: context,
@@ -51,7 +52,7 @@ var rule = (0, _createRule.createLintRule)({
           config: config
         });
       }
-    };
+    }, config);
   }
 });
 var _default = exports.default = rule;

package/dist/cjs/rules/use-tokens-typography/config/index.js

@@ -14,6 +14,9 @@ var ruleSchema = exports.ruleSchema = {
       },
       shouldEnforceFallbacks: {
         type: 'boolean'
+      },
+      enableUnsafeAutofix: {
+        type: 'boolean'
       }
     }
   }

package/dist/es2019/ast-nodes/jsx-element.js

@@ -57,12 +57,16 @@ export const JSXElementHelper = {
     return fix;
   },
   getChildren(node) {
-    // Filter out text children with whitespace characters only as JSX removes whitespace used for intendation
     const filteredChildren = node.children.filter(child => {
+      // Filter out text children with whitespace characters only as JSX removes whitespace used for intendation
       if (isNodeOfType(child, 'JSXText')) {
         const whiteSpaceChars = new RegExp('\\s', 'g');
         return !whiteSpaceChars.test(child.value);
       }
+      // Filter out empty JSX expressions, for example JSX expression containing comments only, including eslint ignore comments
+      if (isNodeOfType(child, 'JSXExpressionContainer')) {
+        return !isNodeOfType(child.expression, 'JSXEmptyExpression');
+      }
       return true;
     });
     return filteredChildren;

package/dist/es2019/rules/use-heading/config/index.js

@@ -1,4 +1,5 @@
 const defaults = {
+  failSilently: false,
   patterns: ['native-elements'],
   enableUnsafeAutofix: false
 };

package/dist/es2019/rules/use-heading/index.js

@@ -1,4 +1,5 @@
 import { createLintRule } from '../utils/create-rule';
+import { errorBoundary } from '../utils/error-boundary';
 import { getConfig } from './config';
 import { NativeElements } from './transformers';
 const docsUrl = 'https://atlassian.design/components/heading';
@@ -19,7 +20,7 @@ const rule = createLintRule({
   },
   create(context) {
     const config = getConfig(context.options[0]);
-    return {
+    return errorBoundary({
       // transforms <h1>...</h1> usages
       'JSXElement[openingElement.name.name=/^h[0-6]$/]': node => {
         return NativeElements.lint(node, {
@@ -27,7 +28,7 @@ const rule = createLintRule({
           config
         });
       }
-    };
+    }, config);
   }
 });
 export default rule;

package/dist/es2019/rules/use-latest-xcss-syntax-typography/config/index.js

@@ -0,0 +1,6 @@
+const defaults = {
+  failSilently: false
+};
+export const getConfig = overrides => {
+  return Object.assign({}, defaults, overrides);
+};

package/dist/es2019/rules/use-latest-xcss-syntax-typography/index.js

@@ -1,4 +1,6 @@
 import { createLintRule } from '../utils/create-rule';
+import { errorBoundary } from '../utils/error-boundary';
+import { getConfig } from './config';
 import { BannedProperty } from './linters';
 export const error = `Don't set fontSize, lineHeight, fontWeight properties on xcss. They are unsafe as they allow invalid combinations of typography tokens. There is ongoing work to make this a TypeScript error. Once that happens, you will have to delete/refactor anyway.`;
 const rule = createLintRule({
@@ -17,14 +19,15 @@ const rule = createLintRule({
     }
   },
   create(context) {
-    return {
+    const config = getConfig(context.options[0]);
+    return errorBoundary({
       'CallExpression[callee.name="xcss"] ObjectExpression > Property > Identifier[name=/(fontSize|lineHeight|fontWeight)/]': node => BannedProperty.lint(node, {
         context
       }),
       'CallExpression[callee.name="xcss"] ObjectExpression > Property > Literal[value=/(fontSize|lineHeight|fontWeight)/]': node => BannedProperty.lint(node, {
         context
       })
-    };
+    }, config);
   }
 });
 export default rule;

package/dist/es2019/rules/use-primitives-text/config/index.js

@@ -1,4 +1,5 @@
 const defaults = {
+  failSilently: false,
   patterns: ['paragraph-elements', 'span-elements', 'strong-elements', 'emphasis-elements'],
   inheritColor: false,
   enableUnsafeAutofix: false

package/dist/es2019/rules/use-primitives-text/index.js

@@ -1,4 +1,5 @@
 import { createLintRule } from '../utils/create-rule';
+import { errorBoundary } from '../utils/error-boundary';
 import { getConfig } from './config';
 import { EmphasisElements, ParagraphElements, SpanElements, StrongElements } from './transformers';
 const textDocsUrl = 'https://atlassian.design/components/primitives/text';
@@ -20,7 +21,7 @@ const rule = createLintRule({
   },
   create(context) {
     const config = getConfig(context.options[0]);
-    return {
+    return errorBoundary({
       'JSXElement[openingElement.name.name=span]': node => {
         return SpanElements.lint(node, {
           context,
@@ -45,7 +46,7 @@ const rule = createLintRule({
           config
         });
       }
-    };
+    }, config);
   }
 });
 export default rule;

package/dist/es2019/rules/use-tokens-typography/config/index.js

@@ -8,6 +8,9 @@ export const ruleSchema = {
       },
       shouldEnforceFallbacks: {
         type: 'boolean'
+      },
+      enableUnsafeAutofix: {
+        type: 'boolean'
       }
     }
   }

package/dist/esm/ast-nodes/jsx-element.js

@@ -57,12 +57,16 @@ export var JSXElementHelper = {
     return fix;
   },
   getChildren: function getChildren(node) {
-    // Filter out text children with whitespace characters only as JSX removes whitespace used for intendation
     var filteredChildren = node.children.filter(function (child) {
+      // Filter out text children with whitespace characters only as JSX removes whitespace used for intendation
       if (isNodeOfType(child, 'JSXText')) {
         var whiteSpaceChars = new RegExp('\\s', 'g');
         return !whiteSpaceChars.test(child.value);
       }
+      // Filter out empty JSX expressions, for example JSX expression containing comments only, including eslint ignore comments
+      if (isNodeOfType(child, 'JSXExpressionContainer')) {
+        return !isNodeOfType(child.expression, 'JSXEmptyExpression');
+      }
       return true;
     });
     return filteredChildren;

package/dist/esm/rules/use-heading/config/index.js

@@ -1,4 +1,5 @@
 var defaults = {
+  failSilently: false,
   patterns: ['native-elements'],
   enableUnsafeAutofix: false
 };

package/dist/esm/rules/use-heading/index.js

@@ -1,4 +1,5 @@
 import { createLintRule } from '../utils/create-rule';
+import { errorBoundary } from '../utils/error-boundary';
 import { getConfig } from './config';
 import { NativeElements } from './transformers';
 var docsUrl = 'https://atlassian.design/components/heading';
@@ -19,7 +20,7 @@ var rule = createLintRule({
   },
   create: function create(context) {
     var config = getConfig(context.options[0]);
-    return {
+    return errorBoundary({
       // transforms <h1>...</h1> usages
       'JSXElement[openingElement.name.name=/^h[0-6]$/]': function JSXElementOpeningElementNameNameH06$(node) {
         return NativeElements.lint(node, {
@@ -27,7 +28,7 @@ var rule = createLintRule({
           config: config
         });
       }
-    };
+    }, config);
   }
 });
 export default rule;

package/dist/esm/rules/use-latest-xcss-syntax-typography/config/index.js

@@ -0,0 +1,6 @@
+var defaults = {
+  failSilently: false
+};
+export var getConfig = function getConfig(overrides) {
+  return Object.assign({}, defaults, overrides);
+};

package/dist/esm/rules/use-latest-xcss-syntax-typography/index.js

@@ -1,4 +1,6 @@
 import { createLintRule } from '../utils/create-rule';
+import { errorBoundary } from '../utils/error-boundary';
+import { getConfig } from './config';
 import { BannedProperty } from './linters';
 export var error = "Don't set fontSize, lineHeight, fontWeight properties on xcss. They are unsafe as they allow invalid combinations of typography tokens. There is ongoing work to make this a TypeScript error. Once that happens, you will have to delete/refactor anyway.";
 var rule = createLintRule({
@@ -17,7 +19,8 @@ var rule = createLintRule({
     }
   },
   create: function create(context) {
-    return {
+    var config = getConfig(context.options[0]);
+    return errorBoundary({
       'CallExpression[callee.name="xcss"] ObjectExpression > Property > Identifier[name=/(fontSize|lineHeight|fontWeight)/]': function CallExpressionCalleeNameXcssObjectExpressionPropertyIdentifierNameFontSizeLineHeightFontWeight(node) {
         return BannedProperty.lint(node, {
           context: context
@@ -28,7 +31,7 @@ var rule = createLintRule({
           context: context
         });
       }
-    };
+    }, config);
   }
 });
 export default rule;

package/dist/esm/rules/use-primitives-text/config/index.js

@@ -1,4 +1,5 @@
 var defaults = {
+  failSilently: false,
   patterns: ['paragraph-elements', 'span-elements', 'strong-elements', 'emphasis-elements'],
   inheritColor: false,
   enableUnsafeAutofix: false

package/dist/esm/rules/use-primitives-text/index.js

@@ -1,4 +1,5 @@
 import { createLintRule } from '../utils/create-rule';
+import { errorBoundary } from '../utils/error-boundary';
 import { getConfig } from './config';
 import { EmphasisElements, ParagraphElements, SpanElements, StrongElements } from './transformers';
 var textDocsUrl = 'https://atlassian.design/components/primitives/text';
@@ -20,7 +21,7 @@ var rule = createLintRule({
   },
   create: function create(context) {
     var config = getConfig(context.options[0]);
-    return {
+    return errorBoundary({
       'JSXElement[openingElement.name.name=span]': function JSXElementOpeningElementNameNameSpan(node) {
         return SpanElements.lint(node, {
           context: context,
@@ -45,7 +46,7 @@ var rule = createLintRule({
           config: config
         });
       }
-    };
+    }, config);
   }
 });
 export default rule;

package/dist/esm/rules/use-tokens-typography/config/index.js

@@ -8,6 +8,9 @@ export var ruleSchema = {
       },
       shouldEnforceFallbacks: {
         type: 'boolean'
+      },
+      enableUnsafeAutofix: {
+        type: 'boolean'
       }
     }
   }

package/dist/types/rules/use-heading/config/index.d.ts

@@ -1,5 +1,6 @@
 type Pattern = 'native-elements';
 export interface RuleConfig {
+    failSilently: boolean;
     patterns: Pattern[];
     enableUnsafeAutofix: false;
 }

package/dist/types/rules/use-latest-xcss-syntax-typography/config/index.d.ts

@@ -0,0 +1,4 @@
+export interface RuleConfig {
+    failSilently: boolean;
+}
+export declare const getConfig: (overrides: Partial<RuleConfig>) => RuleConfig;

package/dist/types/rules/use-primitives-text/config/index.d.ts

@@ -1,5 +1,6 @@
 type Pattern = 'paragraph-elements' | 'span-elements' | 'strong-elements' | 'emphasis-elements';
 export interface RuleConfig {
+    failSilently: boolean;
     patterns: Pattern[];
     inheritColor: boolean;
     enableUnsafeAutofix: boolean;

package/dist/types-ts4.5/rules/use-heading/config/index.d.ts

@@ -1,5 +1,6 @@
 type Pattern = 'native-elements';
 export interface RuleConfig {
+    failSilently: boolean;
     patterns: Pattern[];
     enableUnsafeAutofix: false;
 }

package/dist/types-ts4.5/rules/use-latest-xcss-syntax-typography/config/index.d.ts

@@ -0,0 +1,4 @@
+export interface RuleConfig {
+    failSilently: boolean;
+}
+export declare const getConfig: (overrides: Partial<RuleConfig>) => RuleConfig;

package/dist/types-ts4.5/rules/use-primitives-text/config/index.d.ts

@@ -1,5 +1,6 @@
 type Pattern = 'paragraph-elements' | 'span-elements' | 'strong-elements' | 'emphasis-elements';
 export interface RuleConfig {
+    failSilently: boolean;
     patterns: Pattern[];
     inheritColor: boolean;
     enableUnsafeAutofix: boolean;

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@atlaskit/eslint-plugin-design-system",
 	"description": "The essential plugin for use with the Atlassian Design System.",
-	"version": "10.12.0",
+	"version": "10.12.2",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
 	"publishConfig": {