@atlaskit/emoji 71.16.1 → 71.16.3

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/emoji
 
+## 71.16.3
+
+### Patch Changes
+
+- [`6274e251b8398`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/6274e251b8398) -
+  Clean up the `cache_emoji_loader_for_the_same_config` feature gate. `EmojiLoader` now always
+  shares a single in-flight/resolved load promise between loaders created for the same config url,
+  instead of refetching per loader.
+
+  The cache is skipped in test environments (Jest, and automated browsers such as Playwright), so it
+  cannot leak responses between test cases that share a provider url.
+
+## 71.16.2
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 71.16.1
 
 ### Patch Changes

package/dist/cjs/api/EmojiLoader.js

@@ -7,12 +7,12 @@ Object.defineProperty(exports, "__esModule", {
 exports.default = void 0;
 var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
 var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
+var _isTestEnvironment = require("../util/is-test-environment");
 var _EmojiUtils = require("./EmojiUtils");
 /**
  * Shared cache of in-flight/resolved emoji load promises, keyed by the request URL so that
  * multiple loaders created for the same provider config reuse a single request instead of
- * refetching. Only consulted when `cache_emoji_loader_for_the_same_config` is enabled.
+ * refetching.
  */
 var emojiPromiseCache = new Map();
 
@@ -31,23 +31,25 @@ var EmojiLoader = exports.default = /*#__PURE__*/function () {
   return (0, _createClass2.default)(EmojiLoader, [{
     key: "loadEmoji",
     value: function loadEmoji() {
-      if ((0, _platformFeatureFlags.fg)('cache_emoji_loader_for_the_same_config')) {
-        var cacheKey = this.config.url;
-        var cachedPromise = emojiPromiseCache.get(cacheKey);
-        if (cachedPromise) {
-          return cachedPromise;
-        }
-        var emojiPromise = this.fetchEmoji();
-        // Evict on failure so a rejected promise is not cached, allowing retries to refetch.
-        emojiPromise.catch(function () {
-          if (emojiPromiseCache.get(cacheKey) === emojiPromise) {
-            emojiPromiseCache.delete(cacheKey);
-          }
-        });
-        emojiPromiseCache.set(cacheKey, emojiPromise);
-        return emojiPromise;
+      // The cache is module-level and outlives individual loaders, so under test it would leak
+      // responses between cases sharing a provider url. Always refetch there instead.
+      if ((0, _isTestEnvironment.isTestEnvironment)()) {
+        return this.fetchEmoji();
+      }
+      var cacheKey = this.config.url;
+      var cachedPromise = emojiPromiseCache.get(cacheKey);
+      if (cachedPromise) {
+        return cachedPromise;
       }
-      return this.fetchEmoji();
+      var emojiPromise = this.fetchEmoji();
+      // Evict on failure so a rejected promise is not cached, allowing retries to refetch.
+      emojiPromise.catch(function () {
+        if (emojiPromiseCache.get(cacheKey) === emojiPromise) {
+          emojiPromiseCache.delete(cacheKey);
+        }
+      });
+      emojiPromiseCache.set(cacheKey, emojiPromise);
+      return emojiPromise;
     }
   }, {
     key: "fetchEmoji",

package/dist/cjs/util/analytics/analytics.js

@@ -20,7 +20,7 @@ var createEvent = function createEvent(eventType, action, actionSubject, actionS
     actionSubjectId: actionSubjectId,
     attributes: _objectSpread({
       packageName: "@atlaskit/emoji",
-      packageVersion: "71.16.0"
+      packageVersion: "71.16.2"
     }, attributes)
   };
 };

package/dist/cjs/util/is-test-environment.js

@@ -0,0 +1,26 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.isTestEnvironment = isTestEnvironment;
+/**
+ * Detects Jest unit tests and automated browsers (Playwright and other WebDriver-based drivers).
+ *
+ * Used to opt out of module-level caching that outlives individual instances. Such a cache leaks
+ * state between test cases that share an input, which makes tests order-dependent and forces every
+ * consumer to reset shared internals from their own suites.
+ */
+function isTestEnvironment() {
+  try {
+    var _process, _process2;
+    return Boolean(typeof process !== 'undefined' && (
+    // NODE_ENV can be overridden by consumers, so also check for a Jest worker
+    ((_process = process) === null || _process === void 0 || (_process = _process.env) === null || _process === void 0 ? void 0 : _process.NODE_ENV) === 'test' || ((_process2 = process) === null || _process2 === void 0 || (_process2 = _process2.env) === null || _process2 === void 0 ? void 0 : _process2.JEST_WORKER_ID) !== undefined) ||
+    // Playwright serves examples with NODE_ENV=development, but sets navigator.webdriver
+    typeof navigator !== 'undefined' && navigator.webdriver);
+  } catch (e) {
+    // Catch possible error that might occur and just return false
+    return false;
+  }
+}

package/dist/es2019/api/EmojiLoader.js

@@ -1,10 +1,10 @@
-import { fg } from '@atlaskit/platform-feature-flags';
+import { isTestEnvironment } from '../util/is-test-environment';
 import { denormaliseEmojiServiceResponse, emojiRequest } from './EmojiUtils';
 
 /**
  * Shared cache of in-flight/resolved emoji load promises, keyed by the request URL so that
  * multiple loaders created for the same provider config reuse a single request instead of
- * refetching. Only consulted when `cache_emoji_loader_for_the_same_config` is enabled.
+ * refetching.
  */
 const emojiPromiseCache = new Map();
 
@@ -20,23 +20,25 @@ export default class EmojiLoader {
    * Returns a promise with an array of Emoji from all providers.
    */
   loadEmoji() {
-    if (fg('cache_emoji_loader_for_the_same_config')) {
-      const cacheKey = this.config.url;
-      const cachedPromise = emojiPromiseCache.get(cacheKey);
-      if (cachedPromise) {
-        return cachedPromise;
-      }
-      const emojiPromise = this.fetchEmoji();
-      // Evict on failure so a rejected promise is not cached, allowing retries to refetch.
-      emojiPromise.catch(() => {
-        if (emojiPromiseCache.get(cacheKey) === emojiPromise) {
-          emojiPromiseCache.delete(cacheKey);
-        }
-      });
-      emojiPromiseCache.set(cacheKey, emojiPromise);
-      return emojiPromise;
+    // The cache is module-level and outlives individual loaders, so under test it would leak
+    // responses between cases sharing a provider url. Always refetch there instead.
+    if (isTestEnvironment()) {
+      return this.fetchEmoji();
+    }
+    const cacheKey = this.config.url;
+    const cachedPromise = emojiPromiseCache.get(cacheKey);
+    if (cachedPromise) {
+      return cachedPromise;
     }
-    return this.fetchEmoji();
+    const emojiPromise = this.fetchEmoji();
+    // Evict on failure so a rejected promise is not cached, allowing retries to refetch.
+    emojiPromise.catch(() => {
+      if (emojiPromiseCache.get(cacheKey) === emojiPromise) {
+        emojiPromiseCache.delete(cacheKey);
+      }
+    });
+    emojiPromiseCache.set(cacheKey, emojiPromise);
+    return emojiPromise;
   }
   fetchEmoji() {
     return emojiRequest(this.config).then(emojiServiceResponse => denormaliseEmojiServiceResponse(emojiServiceResponse));

package/dist/es2019/util/analytics/analytics.js

@@ -9,7 +9,7 @@ const createEvent = (eventType, action, actionSubject, actionSubjectId, attribut
   actionSubjectId,
   attributes: {
     packageName: "@atlaskit/emoji",
-    packageVersion: "71.16.0",
+    packageVersion: "71.16.2",
     ...attributes
   }
 });

package/dist/es2019/util/is-test-environment.js

@@ -0,0 +1,20 @@
+/**
+ * Detects Jest unit tests and automated browsers (Playwright and other WebDriver-based drivers).
+ *
+ * Used to opt out of module-level caching that outlives individual instances. Such a cache leaks
+ * state between test cases that share an input, which makes tests order-dependent and forces every
+ * consumer to reset shared internals from their own suites.
+ */
+export function isTestEnvironment() {
+  try {
+    var _process, _process$env, _process2, _process2$env;
+    return Boolean(typeof process !== 'undefined' && (
+    // NODE_ENV can be overridden by consumers, so also check for a Jest worker
+    ((_process = process) === null || _process === void 0 ? void 0 : (_process$env = _process.env) === null || _process$env === void 0 ? void 0 : _process$env.NODE_ENV) === 'test' || ((_process2 = process) === null || _process2 === void 0 ? void 0 : (_process2$env = _process2.env) === null || _process2$env === void 0 ? void 0 : _process2$env.JEST_WORKER_ID) !== undefined) ||
+    // Playwright serves examples with NODE_ENV=development, but sets navigator.webdriver
+    typeof navigator !== 'undefined' && navigator.webdriver);
+  } catch (e) {
+    // Catch possible error that might occur and just return false
+    return false;
+  }
+}

package/dist/esm/api/EmojiLoader.js

@@ -1,12 +1,12 @@
 import _classCallCheck from "@babel/runtime/helpers/classCallCheck";
 import _createClass from "@babel/runtime/helpers/createClass";
-import { fg } from '@atlaskit/platform-feature-flags';
+import { isTestEnvironment } from '../util/is-test-environment';
 import { denormaliseEmojiServiceResponse, emojiRequest } from './EmojiUtils';
 
 /**
  * Shared cache of in-flight/resolved emoji load promises, keyed by the request URL so that
  * multiple loaders created for the same provider config reuse a single request instead of
- * refetching. Only consulted when `cache_emoji_loader_for_the_same_config` is enabled.
+ * refetching.
  */
 var emojiPromiseCache = new Map();
 
@@ -25,23 +25,25 @@ var EmojiLoader = /*#__PURE__*/function () {
   return _createClass(EmojiLoader, [{
     key: "loadEmoji",
     value: function loadEmoji() {
-      if (fg('cache_emoji_loader_for_the_same_config')) {
-        var cacheKey = this.config.url;
-        var cachedPromise = emojiPromiseCache.get(cacheKey);
-        if (cachedPromise) {
-          return cachedPromise;
-        }
-        var emojiPromise = this.fetchEmoji();
-        // Evict on failure so a rejected promise is not cached, allowing retries to refetch.
-        emojiPromise.catch(function () {
-          if (emojiPromiseCache.get(cacheKey) === emojiPromise) {
-            emojiPromiseCache.delete(cacheKey);
-          }
-        });
-        emojiPromiseCache.set(cacheKey, emojiPromise);
-        return emojiPromise;
+      // The cache is module-level and outlives individual loaders, so under test it would leak
+      // responses between cases sharing a provider url. Always refetch there instead.
+      if (isTestEnvironment()) {
+        return this.fetchEmoji();
+      }
+      var cacheKey = this.config.url;
+      var cachedPromise = emojiPromiseCache.get(cacheKey);
+      if (cachedPromise) {
+        return cachedPromise;
       }
-      return this.fetchEmoji();
+      var emojiPromise = this.fetchEmoji();
+      // Evict on failure so a rejected promise is not cached, allowing retries to refetch.
+      emojiPromise.catch(function () {
+        if (emojiPromiseCache.get(cacheKey) === emojiPromise) {
+          emojiPromiseCache.delete(cacheKey);
+        }
+      });
+      emojiPromiseCache.set(cacheKey, emojiPromise);
+      return emojiPromise;
     }
   }, {
     key: "fetchEmoji",

package/dist/esm/util/analytics/analytics.js

@@ -14,7 +14,7 @@ var createEvent = function createEvent(eventType, action, actionSubject, actionS
     actionSubjectId: actionSubjectId,
     attributes: _objectSpread({
       packageName: "@atlaskit/emoji",
-      packageVersion: "71.16.0"
+      packageVersion: "71.16.2"
     }, attributes)
   };
 };

package/dist/esm/util/is-test-environment.js

@@ -0,0 +1,20 @@
+/**
+ * Detects Jest unit tests and automated browsers (Playwright and other WebDriver-based drivers).
+ *
+ * Used to opt out of module-level caching that outlives individual instances. Such a cache leaks
+ * state between test cases that share an input, which makes tests order-dependent and forces every
+ * consumer to reset shared internals from their own suites.
+ */
+export function isTestEnvironment() {
+  try {
+    var _process, _process2;
+    return Boolean(typeof process !== 'undefined' && (
+    // NODE_ENV can be overridden by consumers, so also check for a Jest worker
+    ((_process = process) === null || _process === void 0 || (_process = _process.env) === null || _process === void 0 ? void 0 : _process.NODE_ENV) === 'test' || ((_process2 = process) === null || _process2 === void 0 || (_process2 = _process2.env) === null || _process2 === void 0 ? void 0 : _process2.JEST_WORKER_ID) !== undefined) ||
+    // Playwright serves examples with NODE_ENV=development, but sets navigator.webdriver
+    typeof navigator !== 'undefined' && navigator.webdriver);
+  } catch (e) {
+    // Catch possible error that might occur and just return false
+    return false;
+  }
+}

package/dist/types/util/is-test-environment.d.ts

@@ -0,0 +1,8 @@
+/**
+ * Detects Jest unit tests and automated browsers (Playwright and other WebDriver-based drivers).
+ *
+ * Used to opt out of module-level caching that outlives individual instances. Such a cache leaks
+ * state between test cases that share an input, which makes tests order-dependent and forces every
+ * consumer to reset shared internals from their own suites.
+ */
+export declare function isTestEnvironment(): boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/emoji",
-	"version": "71.16.1",
+	"version": "71.16.3",
 	"description": "Fabric emoji React components",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -50,14 +50,14 @@
 		"@atlaskit/spinner": "^20.1.0",
 		"@atlaskit/textfield": "^10.0.0",
 		"@atlaskit/theme": "^28.0.0",
-		"@atlaskit/tmp-editor-statsig": "^145.0.0",
+		"@atlaskit/tmp-editor-statsig": "^146.0.0",
 		"@atlaskit/tokens": "^16.6.0",
 		"@atlaskit/tooltip": "^24.0.0",
 		"@atlaskit/ufo": "^1.0.0",
 		"@atlaskit/util-service-support": "^7.2.0",
 		"@atlaskit/visually-hidden": "^4.2.0",
 		"@babel/runtime": "^7.0.0",
-		"@compiled/react": "^1.0.0",
+		"@compiled/react": "^1.0.2",
 		"@tanstack/react-virtual": "3.0.0-beta.60",
 		"js-search": "^2.0.0",
 		"lru_map": "^0.4.1",
@@ -139,9 +139,6 @@
 		},
 		"use-elements-stargate-emoji-path": {
 			"type": "boolean"
-		},
-		"cache_emoji_loader_for_the_same_config": {
-			"type": "boolean"
 		}
 	},
 	"platform-experiments": {