@atlaskit/emoji 70.0.0 → 70.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (5) hide show
  1. package/CHANGELOG.md +13 -0
  2. package/dist/cjs/components/common/Emoji.js +2 -2
  3. package/dist/es2019/components/common/Emoji.js +2 -2
  4. package/dist/esm/components/common/Emoji.js +2 -2
  5. package/package.json +4 -4
package/CHANGELOG.md CHANGED
@@ -1,5 +1,18 @@
1
1
  # @atlaskit/emoji
2
2
 
3
+ ## 70.1.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [`9e5079cbca371`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/9e5079cbca371) -
8
+ Fix accessibility issues image-alt, role-img-alt
9
+
10
+ ## 70.0.1
11
+
12
+ ### Patch Changes
13
+
14
+ - Updated dependencies
15
+
3
16
  ## 70.0.0
4
17
 
5
18
  ### Major Changes
package/dist/cjs/components/common/Emoji.js CHANGED
@@ -248,7 +248,7 @@ var ImageEmoji = exports.ImageEmoji = function ImageEmoji(props) {
248
248
  loading: disableLazyLoad ? 'eager' : 'lazy',
249
249
  src: src,
250
250
  key: src,
251
- alt: emoji.name || emoji.shortName,
251
+ alt: emoji.name || emoji.shortName || '',
252
252
  "data-emoji-short-name": emoji.shortName,
253
253
  "data-emoji-id": emoji.id,
254
254
  "data-emoji-text": emoji.fallback || emoji.shortName
@@ -325,7 +325,7 @@ var EmojiNodeWrapper = exports.EmojiNodeWrapper = /*#__PURE__*/(0, _react.forwar
325
325
  other = (0, _objectWithoutProperties2.default)(props, _excluded);
326
326
  var ariaLabel = (0, _platformFeatureFlags.fg)('platform_change_emoji_button_label') ? _i18n.messages.changeEmojiButtonLabel.defaultMessage : editorEmoji ? undefined : emoji.shortName;
327
327
  return /*#__PURE__*/_react.default.createElement("span", (0, _extends2.default)({
328
- role: editorEmoji ? undefined : shouldBeInteractive ? 'button' : 'img',
328
+ role: editorEmoji ? undefined : shouldBeInteractive ? 'button' : ariaLabel ? 'img' : 'presentation',
329
329
  "aria-label": ariaLabel,
330
330
  ref: ref,
331
331
  "data-testid": "".concat(type, "-emoji-").concat(emoji.shortName),
package/dist/es2019/components/common/Emoji.js CHANGED
@@ -241,7 +241,7 @@ export const ImageEmoji = props => {
241
241
  loading: disableLazyLoad ? 'eager' : 'lazy',
242
242
  src: src,
243
243
  key: src,
244
- alt: emoji.name || emoji.shortName,
244
+ alt: emoji.name || emoji.shortName || '',
245
245
  "data-emoji-short-name": emoji.shortName,
246
246
  "data-emoji-id": emoji.id,
247
247
  "data-emoji-text": emoji.fallback || emoji.shortName
@@ -317,7 +317,7 @@ export const EmojiNodeWrapper = /*#__PURE__*/forwardRef((props, ref) => {
317
317
  } = props;
318
318
  const ariaLabel = fg('platform_change_emoji_button_label') ? messages.changeEmojiButtonLabel.defaultMessage : editorEmoji ? undefined : emoji.shortName;
319
319
  return /*#__PURE__*/React.createElement("span", _extends({
320
- role: editorEmoji ? undefined : shouldBeInteractive ? 'button' : 'img',
320
+ role: editorEmoji ? undefined : shouldBeInteractive ? 'button' : ariaLabel ? 'img' : 'presentation',
321
321
  "aria-label": ariaLabel,
322
322
  ref: ref,
323
323
  "data-testid": `${type}-emoji-${emoji.shortName}`,
package/dist/esm/components/common/Emoji.js CHANGED
@@ -239,7 +239,7 @@ export var ImageEmoji = function ImageEmoji(props) {
239
239
  loading: disableLazyLoad ? 'eager' : 'lazy',
240
240
  src: src,
241
241
  key: src,
242
- alt: emoji.name || emoji.shortName,
242
+ alt: emoji.name || emoji.shortName || '',
243
243
  "data-emoji-short-name": emoji.shortName,
244
244
  "data-emoji-id": emoji.id,
245
245
  "data-emoji-text": emoji.fallback || emoji.shortName
@@ -316,7 +316,7 @@ export var EmojiNodeWrapper = /*#__PURE__*/forwardRef(function (props, ref) {
316
316
  other = _objectWithoutProperties(props, _excluded);
317
317
  var ariaLabel = fg('platform_change_emoji_button_label') ? messages.changeEmojiButtonLabel.defaultMessage : editorEmoji ? undefined : emoji.shortName;
318
318
  return /*#__PURE__*/React.createElement("span", _extends({
319
- role: editorEmoji ? undefined : shouldBeInteractive ? 'button' : 'img',
319
+ role: editorEmoji ? undefined : shouldBeInteractive ? 'button' : ariaLabel ? 'img' : 'presentation',
320
320
  "aria-label": ariaLabel,
321
321
  ref: ref,
322
322
  "data-testid": "".concat(type, "-emoji-").concat(emoji.shortName),
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/emoji",
3
- "version": "70.0.0",
3
+ "version": "70.1.0",
4
4
  "description": "Fabric emoji React components",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -42,14 +42,14 @@
42
42
  "@atlaskit/button": "^23.11.0",
43
43
  "@atlaskit/css": "^0.19.0",
44
44
  "@atlaskit/heading": "^5.4.0",
45
- "@atlaskit/icon": "^34.1.0",
45
+ "@atlaskit/icon": "^34.2.0",
46
46
  "@atlaskit/media-client": "^36.0.0",
47
47
  "@atlaskit/media-client-react": "^5.0.0",
48
48
  "@atlaskit/platform-feature-flags": "^1.1.0",
49
49
  "@atlaskit/primitives": "^19.0.0",
50
50
  "@atlaskit/spinner": "^19.1.0",
51
51
  "@atlaskit/textfield": "^8.3.0",
52
- "@atlaskit/tmp-editor-statsig": "^62.2.0",
52
+ "@atlaskit/tmp-editor-statsig": "^63.0.0",
53
53
  "@atlaskit/tokens": "^13.0.0",
54
54
  "@atlaskit/tooltip": "^21.1.0",
55
55
  "@atlaskit/ufo": "^0.4.0",
@@ -77,7 +77,7 @@
77
77
  "@atlaskit/elements-test-helpers": "workspace:^",
78
78
  "@atlaskit/media-core": "^37.0.0",
79
79
  "@atlaskit/ssr": "workspace:^",
80
- "@atlaskit/theme": "^23.0.0",
80
+ "@atlaskit/theme": "^23.1.0",
81
81
  "@atlassian/a11y-jest-testing": "^0.11.0",
82
82
  "@atlassian/feature-flags-test-utils": "^1.0.0",
83
83
  "@emotion/jest": "^11.8.0",