@atlaskit/editor-wikimarkup-transformer 11.1.8 → 11.1.10

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/editor-wikimarkup-transformer
 
+## 11.1.10
+
+### Patch Changes
+
+- [`6eb39a91ca0`](https://bitbucket.org/atlassian/atlassian-frontend/commits/6eb39a91ca0) - Fixed ADF parsing issue related to codeblock inside table header
+
+## 11.1.9
+
+### Patch Changes
+
+- [`13721843343`](https://bitbucket.org/atlassian/atlassian-frontend/commits/13721843343) - Added support for multiple hardbreaks inside a table
+
 ## 11.1.8
 
 ### Patch Changes

package/dist/cjs/parser/tokenize/table.js

@@ -98,16 +98,22 @@ var table = function table(_ref) {
 
       case processState.LINE_BREAK:
         {
+          //ADFEXP-156 (Prevent table from closing on multiple line breaks and relying on | for closing of table)
           // If we encounter an empty line, we should end the table
-          var emptyLineMatch = substring.match(EMPTY_LINE_REGEXP);
-
-          if (emptyLineMatch) {
-            bufferToCells(cellStyle, buffer.join(''), cellsBuffer, schema, ignoreTokenTypes, context);
-            currentState = processState.END_TABLE;
-            continue;
-          } // If we enconter a new row
-
-
+          // const emptyLineMatch = substring.match(EMPTY_LINE_REGEXP);
+          // if (emptyLineMatch) {
+          //   bufferToCells(
+          //     cellStyle,
+          //     buffer.join(''),
+          //     cellsBuffer,
+          //     schema,
+          //     ignoreTokenTypes,
+          //     context,
+          //   );
+          //   currentState = processState.END_TABLE;
+          //   continue;
+          // }
+          // If we enconter a new row
           var cellMatch = substring.match(CELL_REGEXP);
 
           if (cellMatch) {
@@ -372,7 +378,7 @@ function createTableHeader(pmNode, schema) {
 
   if (pmNode.type.name === 'text' && !(0, _text2.hasAnyOfMarks)(pmNode, ['strong', 'code'])) {
     return pmNode.mark([].concat((0, _toConsumableArray2.default)(pmNode.marks), [mark]));
-  } else if (pmNode.childCount > 0 && pmNode.firstChild && pmNode.child(0)) {
+  } else if (pmNode.childCount > 0 && pmNode.firstChild && pmNode.child(0) && pmNode.type.name !== 'codeBlock') {
     var jsonNode = traverseJsonNodeAndAddMarks(pmNode.toJSON(), 'strong', schema);
     pmNode = _prosemirrorModel.Node.fromJSON(schema, jsonNode);
     return pmNode;

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-wikimarkup-transformer",
-	"version": "11.1.8",
+	"version": "11.1.10",
 	"sideEffects": false
 }

package/dist/es2019/parser/tokenize/table.js

@@ -77,16 +77,22 @@ export const table = ({
 
       case processState.LINE_BREAK:
         {
+          //ADFEXP-156 (Prevent table from closing on multiple line breaks and relying on | for closing of table)
           // If we encounter an empty line, we should end the table
-          const emptyLineMatch = substring.match(EMPTY_LINE_REGEXP);
-
-          if (emptyLineMatch) {
-            bufferToCells(cellStyle, buffer.join(''), cellsBuffer, schema, ignoreTokenTypes, context);
-            currentState = processState.END_TABLE;
-            continue;
-          } // If we enconter a new row
-
-
+          // const emptyLineMatch = substring.match(EMPTY_LINE_REGEXP);
+          // if (emptyLineMatch) {
+          //   bufferToCells(
+          //     cellStyle,
+          //     buffer.join(''),
+          //     cellsBuffer,
+          //     schema,
+          //     ignoreTokenTypes,
+          //     context,
+          //   );
+          //   currentState = processState.END_TABLE;
+          //   continue;
+          // }
+          // If we enconter a new row
           const cellMatch = substring.match(CELL_REGEXP);
 
           if (cellMatch) {
@@ -346,7 +352,7 @@ function createTableHeader(pmNode, schema) {
 
   if (pmNode.type.name === 'text' && !hasAnyOfMarks(pmNode, ['strong', 'code'])) {
     return pmNode.mark([...pmNode.marks, mark]);
-  } else if (pmNode.childCount > 0 && pmNode.firstChild && pmNode.child(0)) {
+  } else if (pmNode.childCount > 0 && pmNode.firstChild && pmNode.child(0) && pmNode.type.name !== 'codeBlock') {
     const jsonNode = traverseJsonNodeAndAddMarks(pmNode.toJSON(), 'strong', schema);
     pmNode = PMNode.fromJSON(schema, jsonNode);
     return pmNode;

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-wikimarkup-transformer",
-	"version": "11.1.8",
+	"version": "11.1.10",
 	"sideEffects": false
 }

package/dist/esm/parser/tokenize/table.js

@@ -78,16 +78,22 @@ export var table = function table(_ref) {
 
       case processState.LINE_BREAK:
         {
+          //ADFEXP-156 (Prevent table from closing on multiple line breaks and relying on | for closing of table)
           // If we encounter an empty line, we should end the table
-          var emptyLineMatch = substring.match(EMPTY_LINE_REGEXP);
-
-          if (emptyLineMatch) {
-            bufferToCells(cellStyle, buffer.join(''), cellsBuffer, schema, ignoreTokenTypes, context);
-            currentState = processState.END_TABLE;
-            continue;
-          } // If we enconter a new row
-
-
+          // const emptyLineMatch = substring.match(EMPTY_LINE_REGEXP);
+          // if (emptyLineMatch) {
+          //   bufferToCells(
+          //     cellStyle,
+          //     buffer.join(''),
+          //     cellsBuffer,
+          //     schema,
+          //     ignoreTokenTypes,
+          //     context,
+          //   );
+          //   currentState = processState.END_TABLE;
+          //   continue;
+          // }
+          // If we enconter a new row
           var cellMatch = substring.match(CELL_REGEXP);
 
           if (cellMatch) {
@@ -350,7 +356,7 @@ function createTableHeader(pmNode, schema) {
 
   if (pmNode.type.name === 'text' && !hasAnyOfMarks(pmNode, ['strong', 'code'])) {
     return pmNode.mark([].concat(_toConsumableArray(pmNode.marks), [mark]));
-  } else if (pmNode.childCount > 0 && pmNode.firstChild && pmNode.child(0)) {
+  } else if (pmNode.childCount > 0 && pmNode.firstChild && pmNode.child(0) && pmNode.type.name !== 'codeBlock') {
     var jsonNode = traverseJsonNodeAndAddMarks(pmNode.toJSON(), 'strong', schema);
     pmNode = PMNode.fromJSON(schema, jsonNode);
     return pmNode;

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/editor-wikimarkup-transformer",
-	"version": "11.1.8",
+	"version": "11.1.10",
 	"sideEffects": false
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/editor-wikimarkup-transformer",
-  "version": "11.1.8",
+  "version": "11.1.10",
   "description": "Wiki markup transformer for JIRA and Confluence",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -12,13 +12,6 @@
   "module": "dist/esm/index.js",
   "module:es2019": "dist/es2019/index.js",
   "types": "dist/types/index.d.ts",
-  "typesVersions": {
-    ">=4.0 <4.5": {
-      "*": [
-        "dist/types-ts4.0/*"
-      ]
-    }
-  },
   "sideEffects": false,
   "atlaskit:src": "src/index.ts",
   "atlassian": {
@@ -40,13 +33,13 @@
   "devDependencies": {
     "@atlaskit/activity": "^1.0.1",
     "@atlaskit/docs": "*",
-    "@atlaskit/editor-common": "^70.1.0",
-    "@atlaskit/editor-core": "^173.0.0",
+    "@atlaskit/editor-common": "^70.3.0",
+    "@atlaskit/editor-core": "^175.0.0",
     "@atlaskit/editor-test-helpers": "^17.2.0",
     "@atlaskit/mention": "^21.0.0",
     "@atlaskit/profilecard": "^17.2.0",
-    "@atlaskit/renderer": "^102.0.0",
-    "@atlaskit/util-data-test": "^17.5.0",
+    "@atlaskit/renderer": "^103.0.0",
+    "@atlaskit/util-data-test": "^17.6.0",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",
     "@emotion/react": "^11.7.1",
     "@types/prosemirror-model": "^1.11.0",

package/report.api.md

@@ -1,4 +1,4 @@
-<!-- API Report Version: 2.2 -->
+<!-- API Report Version: 2.3 -->
 
 ## API Report File for "@atlaskit/editor-wikimarkup-transformer"
 

package/dist/types-ts4.0/char.d.ts

@@ -1 +0,0 @@
-export declare const EM_DASH = "\u2014";

package/dist/types-ts4.0/encoder/emoji-unicode-mapping.d.ts

@@ -1,3 +0,0 @@
-export declare const mapping: {
-    [key: string]: string;
-};

package/dist/types-ts4.0/encoder/index.d.ts

@@ -1,9 +0,0 @@
-import { Node as PMNode } from 'prosemirror-model';
-import { Context } from '../interfaces';
-export declare type MarkEncoder = (text: string, attrs: any) => string;
-export declare type NodeEncoder = (node: PMNode, opts?: NodeEncoderOpts) => string;
-export declare type NodeEncoderOpts = {
-    parent?: PMNode;
-    context?: Context;
-};
-export declare function encode(node: PMNode, context?: Context): string;

package/dist/types-ts4.0/encoder/marks/__base.d.ts

@@ -1,5 +0,0 @@
-/**
- * For text that has leading and ending space. We don't want to
- * convert it to `* strong *. Instead, we need it to be ` *strong* `
- */
-export declare const baseMarkPattern: (text: string, token: string) => string;

package/dist/types-ts4.0/encoder/marks/code.d.ts

@@ -1,2 +0,0 @@
-import { MarkEncoder } from '..';
-export declare const code: MarkEncoder;

package/dist/types-ts4.0/encoder/marks/color.d.ts

@@ -1,2 +0,0 @@
-import { MarkEncoder } from '..';
-export declare const textColor: MarkEncoder;

package/dist/types-ts4.0/encoder/marks/em.d.ts

@@ -1,2 +0,0 @@
-import { MarkEncoder } from '..';
-export declare const em: MarkEncoder;

package/dist/types-ts4.0/encoder/marks/link.d.ts

@@ -1,2 +0,0 @@
-import { MarkEncoder } from '..';
-export declare const link: MarkEncoder;

package/dist/types-ts4.0/encoder/marks/strike.d.ts

@@ -1,2 +0,0 @@
-import { MarkEncoder } from '..';
-export declare const strike: MarkEncoder;

package/dist/types-ts4.0/encoder/marks/strong.d.ts

@@ -1,6 +0,0 @@
-import { MarkEncoder } from '..';
-/**
- * For text that has leading and ending space. We don't want to
- * convert it to `*strong *. Instead, we need it to be `*strong* `
- */
-export declare const strong: MarkEncoder;

package/dist/types-ts4.0/encoder/marks/subsup.d.ts

@@ -1,2 +0,0 @@
-import { MarkEncoder } from '..';
-export declare const subsup: MarkEncoder;

package/dist/types-ts4.0/encoder/marks/underline.d.ts

@@ -1,2 +0,0 @@
-import { MarkEncoder } from '..';
-export declare const underline: MarkEncoder;

package/dist/types-ts4.0/encoder/nodes/block-card.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const blockCard: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/blockquote.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const blockquote: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/bullet-list.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const bulletList: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/caption.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const caption: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/code-block.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const codeBlock: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/date.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const date: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/decisionItem.d.ts

@@ -1,3 +0,0 @@
-import { Node as PMNode } from 'prosemirror-model';
-import { NodeEncoderOpts } from '..';
-export declare const decisionItem: (node: PMNode, { context }?: NodeEncoderOpts) => string;

package/dist/types-ts4.0/encoder/nodes/decisionList.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const decisionList: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/doc.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '../';
-export declare const doc: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/embed-card.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const embedCard: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/emoji.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const emoji: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/expand.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const expand: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/hard-break.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const hardBreak: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/heading.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const heading: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/inline-card.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const inlineCard: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/inlines.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const inlines: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/listItem.d.ts

@@ -1,3 +0,0 @@
-import { Node as PMNode } from 'prosemirror-model';
-import { Context } from '../../interfaces';
-export declare const listItem: (node: PMNode, prefix: string, context?: Context | undefined) => string;

package/dist/types-ts4.0/encoder/nodes/media-group.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const mediaGroup: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/media-inline.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const mediaInline: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/media.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const media: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/mention.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const mention: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/ordered-list.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const orderedList: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/panel.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const panel: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/paragraph.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const paragraph: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/rule.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const rule: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/status.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const status: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/table.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const table: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/taskItem.d.ts

@@ -1,3 +0,0 @@
-import { Node as PMNode } from 'prosemirror-model';
-import { NodeEncoderOpts } from '..';
-export declare const taskItem: (node: PMNode, nestedLevel: number, { context }?: NodeEncoderOpts) => string;

package/dist/types-ts4.0/encoder/nodes/taskList.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const taskList: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/text.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const text: NodeEncoder;

package/dist/types-ts4.0/encoder/nodes/unknown.d.ts

@@ -1,2 +0,0 @@
-import { NodeEncoder } from '..';
-export declare const unknown: NodeEncoder;

package/dist/types-ts4.0/index.d.ts

@@ -1,15 +0,0 @@
-import { Node as PMNode, Schema } from 'prosemirror-model';
-import { Context } from './interfaces';
-interface Transformer<T> {
-    encode(node: PMNode): T;
-    parse(content: T): PMNode;
-}
-export declare class WikiMarkupTransformer implements Transformer<string> {
-    private schema;
-    constructor(schema?: Schema);
-    private sanitizeWikiMarkup;
-    encode(node: PMNode, context?: Context): string;
-    parse(wikiMarkup: string, context?: Context): PMNode;
-    private buildContext;
-}
-export default WikiMarkupTransformer;

package/dist/types-ts4.0/interfaces.d.ts

@@ -1,74 +0,0 @@
-import { Node as PMNode } from 'prosemirror-model';
-export interface AddArgs {
-    style: string | null;
-    content: PMNode[];
-}
-export interface Builder {
-    type: string;
-    /**
-     * Add a item to the builder
-     * @param {AddCellArgs[]} items
-     */
-    add(items: AddArgs[]): void;
-    /**
-     * Compile a prosemirror node from the root list
-     * @returns {PMNode}
-     */
-    buildPMNode(): PMNode;
-}
-export interface ListItem {
-    content?: any[];
-    parent: List;
-    children: List[];
-}
-export interface List {
-    children: ListItem[];
-    type: ListType;
-    parent?: ListItem;
-}
-export declare type ListType = 'bulletList' | 'orderedList';
-export declare type CellType = 'tableHeader' | 'tableCell';
-export interface TableCell {
-    type: CellType;
-    content: PMNode[];
-}
-export interface TableRow {
-    cells: TableCell[];
-}
-export interface Table {
-    rows: TableRow[];
-}
-export interface AddCellArgs extends AddArgs {
-    style: string;
-    content: PMNode[];
-}
-export interface ConversionMap {
-    [key: string]: string;
-}
-export interface MediaConversionMap {
-    [key: string]: {
-        transform?: string;
-        embed?: boolean;
-    };
-}
-export declare type TokenErrCallback = (err: Error, tokenType: string) => void;
-export interface Context {
-    readonly issueKeyRegex?: RegExp | undefined;
-    readonly tokenErrCallback?: TokenErrCallback;
-    readonly conversion?: {
-        readonly inlineCardConversion?: ConversionMap;
-        readonly mediaConversion?: MediaConversionMap;
-        mentionConversion?: ConversionMap;
-    };
-    readonly hydration?: {
-        readonly media?: {
-            targetCollectionId?: string;
-        };
-    };
-    readonly defaults?: {
-        readonly media?: {
-            width: number | null;
-            height: number | null;
-        };
-    };
-}

package/dist/types-ts4.0/parser/abstract-tree.d.ts

@@ -1,11 +0,0 @@
-import { Node as PMNode, Schema } from 'prosemirror-model';
-import { Context } from '../interfaces';
-export default class AbstractTree {
-    private schema;
-    private wikiMarkup;
-    constructor(schema: Schema, wikiMarkup: string);
-    /**
-     * Convert reduced macros tree into prosemirror model tree
-     */
-    getProseMirrorModel(context: Context): PMNode;
-}

package/dist/types-ts4.0/parser/builder/list-builder.d.ts

@@ -1,66 +0,0 @@
-import { Node as PMNode, Schema } from 'prosemirror-model';
-import { AddArgs, ListType } from '../../interfaces';
-/**
- * Return the type of a list from the bullets
- */
-export declare function getType(bullets: string): ListType;
-export declare class ListBuilder {
-    private schema;
-    private root;
-    private lastDepth;
-    private lastList;
-    constructor(schema: Schema, bullets: string);
-    /**
-     * Return the type of the base list
-     * @returns {ListType}
-     */
-    get type(): ListType;
-    /**
-     * Add a list item to the builder
-     * @param {AddArgs[]} items
-     */
-    add(items: AddArgs[]): void;
-    /**
-     * Compile a prosemirror node from the root list
-     * @returns {PMNode[]}
-     */
-    buildPMNode(): PMNode[];
-    /**
-     * Build prosemirror bulletList or orderedList node
-     * @param {List} list
-     * @returns {PMNode}
-     */
-    private parseList;
-    /**
-     * Build prosemirror listItem node
-     * This function would possibly return non listItem nodes
-     * which we need to break out later
-     * @param {ListItem} item
-     */
-    private parseListItem;
-    private isParagraphEmptyTextNode;
-    private createListItem;
-    /**
-     * Add an item at the same level as the current list item
-     * @param {ListType} type
-     * @param {PMNode} content
-     * @returns {PMNode}
-     */
-    private addListItem;
-    /**
-     * Append the past content to the last accessed list node (multiline entries)
-     * @param {PMNode[]} content
-     */
-    private appendToLastItem;
-    /**
-     * Created a nested list structure of N depth under the current node
-     * @param {number} depth
-     * @param {ListType} type
-     */
-    private createNest;
-    /**
-     * Find the Nth list ancestor of the current list
-     * @param {number} depth
-     */
-    private findAncestor;
-}

package/dist/types-ts4.0/parser/builder/table-builder.d.ts

@@ -1,45 +0,0 @@
-import { Node as PMNode, Schema } from 'prosemirror-model';
-import { AddCellArgs, Builder } from '../../interfaces';
-export declare class TableBuilder implements Builder {
-    private schema;
-    private root;
-    private lastRow?;
-    constructor(schema: Schema);
-    /**
-     * Return the type of the base element
-     * @returns {string}
-     */
-    get type(): string;
-    /**
-     * Add new cells to the table
-     * @param {AddCellArgs[]} cells
-     */
-    add(cells: AddCellArgs[]): void;
-    /**
-     * Build a prosemirror table from the data
-     * @returns {PMNode}
-     */
-    buildPMNode(): PMNode;
-    private emptyTableCell;
-    private emptyTableRow;
-    /**
-     * Build prosemirror table node
-     * @returns {PMNode}
-     */
-    private buildTableNode;
-    /**
-     * Build prosemirror tr node
-     * @returns {PMNode}
-     */
-    private buildTableRowNode;
-    /**
-     * Build prosemirror td/th node
-     * @param {TableCell} cell
-     * @returns {PMNode}
-     */
-    private buildTableCellNode;
-    /**
-     * Add a new row to the table
-     */
-    private addRow;
-}

package/dist/types-ts4.0/parser/color.d.ts

@@ -1,3 +0,0 @@
-export declare function getEditorColor(attrs: {
-    [key: string]: string;
-}): string | null;

package/dist/types-ts4.0/parser/error.d.ts

@@ -1 +0,0 @@
-export declare function error(message: string, _input: string, line: number, column: number): void;