@atlaskit/editor-tables 2.9.82 → 2.9.84

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (5) hide show
  1. package/CHANGELOG.md +14 -0
  2. package/dist/cjs/utils/normalize-selection.js +8 -31
  3. package/dist/es2019/utils/normalize-selection.js +1 -25
  4. package/dist/esm/utils/normalize-selection.js +8 -31
  5. package/package.json +2 -2
package/CHANGELOG.md CHANGED
@@ -1,5 +1,19 @@
1
1
  # @atlaskit/editor-tables
2
2
 
3
+ ## 2.9.84
4
+
5
+ ### Patch Changes
6
+
7
+ - [`ab837b5646256`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ab837b5646256) -
8
+ [ux] EDITOR-6274 Clean up platform_editor_element_drag_and_drop_multiselect
9
+ - Updated dependencies
10
+
11
+ ## 2.9.83
12
+
13
+ ### Patch Changes
14
+
15
+ - Updated dependencies
16
+
3
17
  ## 2.9.82
4
18
 
5
19
  ### Patch Changes
package/dist/cjs/utils/normalize-selection.js CHANGED
@@ -5,7 +5,6 @@ Object.defineProperty(exports, "__esModule", {
5
5
  });
6
6
  exports.normalizeSelection = normalizeSelection;
7
7
  var _state = require("@atlaskit/editor-prosemirror/state");
8
- var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
9
8
  var _cellSelection = require("../cell-selection");
10
9
  var _tableMap = require("../table-map");
11
10
  function normalizeSelection(state, transaction, allowTableNodeSelection) {
@@ -18,7 +17,6 @@ function normalizeSelection(state, transaction, allowTableNodeSelection) {
18
17
  if (sel instanceof _state.NodeSelection) {
19
18
  role = sel.node.type.spec.tableRole;
20
19
  }
21
- var isMultiSelect = (0, _experiments.editorExperiment)('platform_editor_element_drag_and_drop_multiselect', true);
22
20
  if (sel instanceof _state.NodeSelection && role) {
23
21
  if (role === 'cell' || role === 'header_cell') {
24
22
  normalize = _cellSelection.CellSelection.create(doc, sel.from);
@@ -33,7 +31,7 @@ function normalizeSelection(state, transaction, allowTableNodeSelection) {
33
31
  }
34
32
  } else if (sel instanceof _state.TextSelection && isCellBoundarySelection(sel)) {
35
33
  normalize = _state.TextSelection.create(doc, sel.from);
36
- } else if (sel instanceof _state.TextSelection && (isMultiSelect ? isTextSelectionAcrossSameTableCells(sel) : isTextSelectionAcrossCells(sel))) {
34
+ } else if (sel instanceof _state.TextSelection && isTextSelectionAcrossSameTableCells(sel)) {
37
35
  normalize = _state.TextSelection.create(doc, sel.$from.start(), sel.$from.end());
38
36
  }
39
37
  if (normalize) {
@@ -64,32 +62,11 @@ function isCellBoundarySelection(_ref2) {
64
62
  // eslint-disable-next-line require-unicode-regexp
65
63
  return afterFrom === beforeTo && /row|table/.test($from.node(depth).type.spec.tableRole);
66
64
  }
67
- function isTextSelectionAcrossCells(_ref3) {
65
+ function isTextSelectionAcrossSameTableCells(_ref3) {
68
66
  var $from = _ref3.$from,
69
67
  $to = _ref3.$to;
70
68
  var fromCellBoundaryNode;
71
69
  var toCellBoundaryNode;
72
- for (var i = $from.depth; i > 0; i--) {
73
- var node = $from.node(i);
74
- if (node.type.spec.tableRole === 'cell' || node.type.spec.tableRole === 'header_cell') {
75
- fromCellBoundaryNode = node;
76
- break;
77
- }
78
- }
79
- for (var _i = $to.depth; _i > 0; _i--) {
80
- var _node = $to.node(_i);
81
- if (_node.type.spec.tableRole === 'cell' || _node.type.spec.tableRole === 'header_cell') {
82
- toCellBoundaryNode = _node;
83
- break;
84
- }
85
- }
86
- return fromCellBoundaryNode !== toCellBoundaryNode && $to.parentOffset === 0;
87
- }
88
- function isTextSelectionAcrossSameTableCells(_ref4) {
89
- var $from = _ref4.$from,
90
- $to = _ref4.$to;
91
- var fromCellBoundaryNode;
92
- var toCellBoundaryNode;
93
70
  var fromCellTableNode;
94
71
  var toCellTableNode;
95
72
  for (var i = $from.depth; i > 0; i--) {
@@ -102,13 +79,13 @@ function isTextSelectionAcrossSameTableCells(_ref4) {
102
79
  break;
103
80
  }
104
81
  }
105
- for (var _i2 = $to.depth; _i2 > 0; _i2--) {
106
- var _node2 = $to.node(_i2);
107
- if (_node2.type.spec.tableRole === 'cell' || _node2.type.spec.tableRole === 'header_cell') {
108
- toCellBoundaryNode = _node2;
82
+ for (var _i = $to.depth; _i > 0; _i--) {
83
+ var _node = $to.node(_i);
84
+ if (_node.type.spec.tableRole === 'cell' || _node.type.spec.tableRole === 'header_cell') {
85
+ toCellBoundaryNode = _node;
109
86
  }
110
- if (_node2.type.name === 'table') {
111
- toCellTableNode = _node2;
87
+ if (_node.type.name === 'table') {
88
+ toCellTableNode = _node;
112
89
  break;
113
90
  }
114
91
  }
package/dist/es2019/utils/normalize-selection.js CHANGED
@@ -1,5 +1,4 @@
1
1
  import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state';
2
- import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
3
2
  import { CellSelection } from '../cell-selection';
4
3
  import { TableMap } from '../table-map';
5
4
  export function normalizeSelection(state, transaction, allowTableNodeSelection) {
@@ -13,7 +12,6 @@ export function normalizeSelection(state, transaction, allowTableNodeSelection)
13
12
  if (sel instanceof NodeSelection) {
14
13
  role = sel.node.type.spec.tableRole;
15
14
  }
16
- const isMultiSelect = editorExperiment('platform_editor_element_drag_and_drop_multiselect', true);
17
15
  if (sel instanceof NodeSelection && role) {
18
16
  if (role === 'cell' || role === 'header_cell') {
19
17
  normalize = CellSelection.create(doc, sel.from);
@@ -28,7 +26,7 @@ export function normalizeSelection(state, transaction, allowTableNodeSelection)
28
26
  }
29
27
  } else if (sel instanceof TextSelection && isCellBoundarySelection(sel)) {
30
28
  normalize = TextSelection.create(doc, sel.from);
31
- } else if (sel instanceof TextSelection && (isMultiSelect ? isTextSelectionAcrossSameTableCells(sel) : isTextSelectionAcrossCells(sel))) {
29
+ } else if (sel instanceof TextSelection && isTextSelectionAcrossSameTableCells(sel)) {
32
30
  normalize = TextSelection.create(doc, sel.$from.start(), sel.$from.end());
33
31
  }
34
32
  if (normalize) {
@@ -62,28 +60,6 @@ function isCellBoundarySelection({
62
60
  // eslint-disable-next-line require-unicode-regexp
63
61
  return afterFrom === beforeTo && /row|table/.test($from.node(depth).type.spec.tableRole);
64
62
  }
65
- function isTextSelectionAcrossCells({
66
- $from,
67
- $to
68
- }) {
69
- let fromCellBoundaryNode;
70
- let toCellBoundaryNode;
71
- for (let i = $from.depth; i > 0; i--) {
72
- const node = $from.node(i);
73
- if (node.type.spec.tableRole === 'cell' || node.type.spec.tableRole === 'header_cell') {
74
- fromCellBoundaryNode = node;
75
- break;
76
- }
77
- }
78
- for (let i = $to.depth; i > 0; i--) {
79
- const node = $to.node(i);
80
- if (node.type.spec.tableRole === 'cell' || node.type.spec.tableRole === 'header_cell') {
81
- toCellBoundaryNode = node;
82
- break;
83
- }
84
- }
85
- return fromCellBoundaryNode !== toCellBoundaryNode && $to.parentOffset === 0;
86
- }
87
63
  function isTextSelectionAcrossSameTableCells({
88
64
  $from,
89
65
  $to
package/dist/esm/utils/normalize-selection.js CHANGED
@@ -1,5 +1,4 @@
1
1
  import { NodeSelection, TextSelection } from '@atlaskit/editor-prosemirror/state';
2
- import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
3
2
  import { CellSelection } from '../cell-selection';
4
3
  import { TableMap } from '../table-map';
5
4
  export function normalizeSelection(state, transaction, allowTableNodeSelection) {
@@ -12,7 +11,6 @@ export function normalizeSelection(state, transaction, allowTableNodeSelection)
12
11
  if (sel instanceof NodeSelection) {
13
12
  role = sel.node.type.spec.tableRole;
14
13
  }
15
- var isMultiSelect = editorExperiment('platform_editor_element_drag_and_drop_multiselect', true);
16
14
  if (sel instanceof NodeSelection && role) {
17
15
  if (role === 'cell' || role === 'header_cell') {
18
16
  normalize = CellSelection.create(doc, sel.from);
@@ -27,7 +25,7 @@ export function normalizeSelection(state, transaction, allowTableNodeSelection)
27
25
  }
28
26
  } else if (sel instanceof TextSelection && isCellBoundarySelection(sel)) {
29
27
  normalize = TextSelection.create(doc, sel.from);
30
- } else if (sel instanceof TextSelection && (isMultiSelect ? isTextSelectionAcrossSameTableCells(sel) : isTextSelectionAcrossCells(sel))) {
28
+ } else if (sel instanceof TextSelection && isTextSelectionAcrossSameTableCells(sel)) {
31
29
  normalize = TextSelection.create(doc, sel.$from.start(), sel.$from.end());
32
30
  }
33
31
  if (normalize) {
@@ -58,32 +56,11 @@ function isCellBoundarySelection(_ref2) {
58
56
  // eslint-disable-next-line require-unicode-regexp
59
57
  return afterFrom === beforeTo && /row|table/.test($from.node(depth).type.spec.tableRole);
60
58
  }
61
- function isTextSelectionAcrossCells(_ref3) {
59
+ function isTextSelectionAcrossSameTableCells(_ref3) {
62
60
  var $from = _ref3.$from,
63
61
  $to = _ref3.$to;
64
62
  var fromCellBoundaryNode;
65
63
  var toCellBoundaryNode;
66
- for (var i = $from.depth; i > 0; i--) {
67
- var node = $from.node(i);
68
- if (node.type.spec.tableRole === 'cell' || node.type.spec.tableRole === 'header_cell') {
69
- fromCellBoundaryNode = node;
70
- break;
71
- }
72
- }
73
- for (var _i = $to.depth; _i > 0; _i--) {
74
- var _node = $to.node(_i);
75
- if (_node.type.spec.tableRole === 'cell' || _node.type.spec.tableRole === 'header_cell') {
76
- toCellBoundaryNode = _node;
77
- break;
78
- }
79
- }
80
- return fromCellBoundaryNode !== toCellBoundaryNode && $to.parentOffset === 0;
81
- }
82
- function isTextSelectionAcrossSameTableCells(_ref4) {
83
- var $from = _ref4.$from,
84
- $to = _ref4.$to;
85
- var fromCellBoundaryNode;
86
- var toCellBoundaryNode;
87
64
  var fromCellTableNode;
88
65
  var toCellTableNode;
89
66
  for (var i = $from.depth; i > 0; i--) {
@@ -96,13 +73,13 @@ function isTextSelectionAcrossSameTableCells(_ref4) {
96
73
  break;
97
74
  }
98
75
  }
99
- for (var _i2 = $to.depth; _i2 > 0; _i2--) {
100
- var _node2 = $to.node(_i2);
101
- if (_node2.type.spec.tableRole === 'cell' || _node2.type.spec.tableRole === 'header_cell') {
102
- toCellBoundaryNode = _node2;
76
+ for (var _i = $to.depth; _i > 0; _i--) {
77
+ var _node = $to.node(_i);
78
+ if (_node.type.spec.tableRole === 'cell' || _node.type.spec.tableRole === 'header_cell') {
79
+ toCellBoundaryNode = _node;
103
80
  }
104
- if (_node2.type.name === 'table') {
105
- toCellTableNode = _node2;
81
+ if (_node.type.name === 'table') {
82
+ toCellTableNode = _node;
106
83
  break;
107
84
  }
108
85
  }
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/editor-tables",
3
- "version": "2.9.82",
3
+ "version": "2.9.84",
4
4
  "description": "A package that contains common classes and utility functions for editor tables",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -29,7 +29,7 @@
29
29
  "dependencies": {
30
30
  "@atlaskit/editor-prosemirror": "^7.3.0",
31
31
  "@atlaskit/platform-feature-flags": "^1.1.0",
32
- "@atlaskit/tmp-editor-statsig": "^72.0.0",
32
+ "@atlaskit/tmp-editor-statsig": "^74.0.0",
33
33
  "@babel/runtime": "^7.0.0"
34
34
  },
35
35
  "devDependencies": {