@atlaskit/editor-synced-block-provider 8.3.1 → 8.4.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/editor-synced-block-provider
 
+## 8.4.0
+
+### Minor Changes
+
+- [`5e439884aa23d`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/5e439884aa23d) -
+  Add a readiness guard to the source synced-block cache-update path. When a `bodiedSyncBlock` node
+  is updated before its `localId`/`resourceId` has been populated (a benign timing/initialisation
+  ordering case), the cache update is now skipped as a no-op instead of throwing. This stops the
+  `Local ID or resource ID is not set` error from being logged and from firing the synced-block
+  update-cache operational error event, so it no longer counts as a genuine cache-update failure.
+  Gated behind `platform_editor_blocks_patch_4`.
+
 ## 8.3.1
 
 ### Patch Changes

package/dist/cjs/store-manager/sourceSyncBlockStoreManager.js

@@ -123,6 +123,10 @@ var SourceSyncBlockStoreManager = exports.SourceSyncBlockStoreManager = /*#__PUR
           localId = _syncBlockNode$attrs.localId,
           resourceId = _syncBlockNode$attrs.resourceId;
         if (!localId || !resourceId) {
+          // Identifiers not populated yet: benign timing case, skip as a no-op.
+          if ((0, _platformFeatureFlags.fg)('platform_editor_blocks_patch_4')) {
+            return false;
+          }
           throw new Error('Local ID or resource ID is not set');
         }
         var cachedBlock = this.syncBlockCache.get(resourceId);

package/dist/es2019/store-manager/sourceSyncBlockStoreManager.js

@@ -95,6 +95,10 @@ export class SourceSyncBlockStoreManager {
         resourceId
       } = syncBlockNode.attrs;
       if (!localId || !resourceId) {
+        // Identifiers not populated yet: benign timing case, skip as a no-op.
+        if (fg('platform_editor_blocks_patch_4')) {
+          return false;
+        }
         throw new Error('Local ID or resource ID is not set');
       }
       const cachedBlock = this.syncBlockCache.get(resourceId);

package/dist/esm/store-manager/sourceSyncBlockStoreManager.js

@@ -116,6 +116,10 @@ export var SourceSyncBlockStoreManager = /*#__PURE__*/function () {
           localId = _syncBlockNode$attrs.localId,
           resourceId = _syncBlockNode$attrs.resourceId;
         if (!localId || !resourceId) {
+          // Identifiers not populated yet: benign timing case, skip as a no-op.
+          if (fg('platform_editor_blocks_patch_4')) {
+            return false;
+          }
           throw new Error('Local ID or resource ID is not set');
         }
         var cachedBlock = this.syncBlockCache.get(resourceId);

package/package.json

@@ -21,7 +21,7 @@
 		"@atlaskit/editor-prosemirror": "^8.0.0",
 		"@atlaskit/node-data-provider": "^13.0.0",
 		"@atlaskit/platform-feature-flags": "^2.0.0",
-		"@atlaskit/tmp-editor-statsig": "^114.5.0",
+		"@atlaskit/tmp-editor-statsig": "^114.6.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^0.20.0",
 		"graphql-ws": "^5.14.2",
@@ -74,7 +74,7 @@
 		}
 	},
 	"name": "@atlaskit/editor-synced-block-provider",
-	"version": "8.3.1",
+	"version": "8.4.0",
 	"description": "Synced Block Provider for @atlaskit/editor-plugin-synced-block",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -88,6 +88,9 @@
 		"platform_editor_blocks_patch_3": {
 			"type": "boolean"
 		},
+		"platform_editor_blocks_patch_4": {
+			"type": "boolean"
+		},
 		"platform_synced_block_patch_13": {
 			"type": "boolean"
 		},