@atlaskit/editor-synced-block-provider 4.2.8 → 4.2.10

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @atlaskit/editor-synced-block-provider
 
+## 4.2.10
+
+### Patch Changes
+
+- [`becb755f01510`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/becb755f01510) -
+  Editor-5990: Create and delete call to block service when deleting orphan source blocks
+- Updated dependencies
+
+## 4.2.9
+
+### Patch Changes
+
+- [`827be3d512390`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/827be3d512390) -
+  Refactor source synced block cache update to use appendTransaction instead of nodeview update.
+  Behind fg('platform_synced_block_update_refactor'):
+  - Moves cache update from nodeview update() to PM plugin appendTransaction hook, filtering out
+    non-user changes (remote collab, table auto-scale, dirty transactions)
+  - Moves initial cache population from nodeview constructor to PM plugin state.init()
+  - Optimises updateSyncBlockData with Fragment.eq() for O(1) comparison instead of toJSON() +
+    lodash/isEqual
+- Updated dependencies
+
 ## 4.2.8
 
 ### Patch Changes

package/dist/cjs/clients/block-service/blockService.js

@@ -4,7 +4,7 @@ var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefau
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.updateSyncedBlocks = exports.updateSyncedBlock = exports.updateReferenceSyncedBlockOnDocument = exports.isBlockContentResponse = exports.getSyncedBlockContent = exports.getReferenceSyncedBlocksByBlockAri = exports.getReferenceSyncedBlocks = exports.deleteSyncedBlock = exports.createSyncedBlock = exports.batchRetrieveSyncedBlocks = exports.BlockTimeoutError = exports.BlockError = void 0;
+exports.updateSyncedBlocks = exports.updateSyncedBlock = exports.updateReferenceSyncedBlockOnDocument = exports.isBlockContentResponse = exports.getSyncedBlockContent = exports.getReferenceSyncedBlocksByBlockAri = exports.getReferenceSyncedBlocks = exports.deleteSyncedBlock = exports.createSyncedBlock = exports.batchRetrieveSyncedBlocks = exports.BlockTimeoutError = exports.BlockNotFoundError = exports.BlockError = void 0;
 var _regenerator = _interopRequireDefault(require("@babel/runtime/regenerator"));
 var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
 var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
@@ -226,15 +226,31 @@ var BlockError = exports.BlockError = /*#__PURE__*/function (_Error) {
   (0, _inherits2.default)(BlockError, _Error);
   return (0, _createClass2.default)(BlockError);
 }( /*#__PURE__*/(0, _wrapNativeSuper2.default)(Error));
-var BlockTimeoutError = exports.BlockTimeoutError = /*#__PURE__*/function (_Error2) {
-  function BlockTimeoutError() {
+/**
+ * Thrown when Block Service returns RESOURCE_NOT_FOUND for a block.
+ * This typically happens when an orphan block (e.g. from a copied page) is deleted.
+ * The caller should create the block first, then delete it to ensure a proper soft-delete record.
+ */
+var BlockNotFoundError = exports.BlockNotFoundError = /*#__PURE__*/function (_Error2) {
+  function BlockNotFoundError() {
     var _this2;
-    (0, _classCallCheck2.default)(this, BlockTimeoutError);
-    _this2 = _callSuper(this, BlockTimeoutError, ['Block request timed out']);
-    _this2.name = 'BlockTimeoutError';
+    (0, _classCallCheck2.default)(this, BlockNotFoundError);
+    _this2 = _callSuper(this, BlockNotFoundError, ['Block not found in Block Service']);
+    _this2.name = 'BlockNotFoundError';
     return _this2;
   }
-  (0, _inherits2.default)(BlockTimeoutError, _Error2);
+  (0, _inherits2.default)(BlockNotFoundError, _Error2);
+  return (0, _createClass2.default)(BlockNotFoundError);
+}( /*#__PURE__*/(0, _wrapNativeSuper2.default)(Error));
+var BlockTimeoutError = exports.BlockTimeoutError = /*#__PURE__*/function (_Error3) {
+  function BlockTimeoutError() {
+    var _this3;
+    (0, _classCallCheck2.default)(this, BlockTimeoutError);
+    _this3 = _callSuper(this, BlockTimeoutError, ['Block request timed out']);
+    _this3.name = 'BlockTimeoutError';
+    return _this3;
+  }
+  (0, _inherits2.default)(BlockTimeoutError, _Error3);
   return (0, _createClass2.default)(BlockTimeoutError);
 }( /*#__PURE__*/(0, _wrapNativeSuper2.default)(Error));
 var getSyncedBlockContent = exports.getSyncedBlockContent = /*#__PURE__*/function () {
@@ -420,7 +436,7 @@ var deleteSyncedBlock = exports.deleteSyncedBlock = /*#__PURE__*/function () {
             _context4.next = 16;
             break;
           }
-          return _context4.abrupt("return");
+          throw new BlockNotFoundError();
         case 16:
           throw new Error(result.errors.map(function (e) {
             return e.message;

package/dist/cjs/providers/block-service/blockServiceAPI.js

@@ -1031,31 +1031,42 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
             case 9:
               _context0.prev = 9;
               _context0.t0 = _context0["catch"](3);
+              if (!(_context0.t0 instanceof _blockService.BlockNotFoundError && this.parentAri && (0, _platformFeatureFlags.fg)('platform_synced_block_patch_8'))) {
+                _context0.next = 13;
+                break;
+              }
+              return _context0.abrupt("return", this.deleteOrphanBlock({
+                blockAri: blockAri,
+                resourceId: resourceId,
+                parentAri: this.parentAri,
+                deleteReason: deleteReason
+              }));
+            case 13:
               if (!(_context0.t0 instanceof _blockService.BlockError)) {
-                _context0.next = 15;
+                _context0.next = 17;
                 break;
               }
               if (!(_context0.t0.status === 404)) {
-                _context0.next = 14;
+                _context0.next = 16;
                 break;
               }
               return _context0.abrupt("return", {
                 resourceId: resourceId,
                 success: true
               });
-            case 14:
+            case 16:
               return _context0.abrupt("return", {
                 resourceId: resourceId,
                 success: false,
                 error: mapBlockError(_context0.t0)
               });
-            case 15:
+            case 17:
               return _context0.abrupt("return", {
                 resourceId: resourceId,
                 success: false,
                 error: (0, _errorHandling.stringifyError)(_context0.t0)
               });
-            case 16:
+            case 18:
             case "end":
               return _context0.stop();
           }
@@ -1065,6 +1076,111 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
         return _deleteData.apply(this, arguments);
       }
       return deleteData;
+    }() // The block is an orphan (e.g. from a copied page) — it doesn't exist in Block Service.
+    // Block Service uses soft-deletes, so we must first create the block then delete it,
+    // ensuring a deletion-reason record is stored (used to display errors in reference blocks).
+  }, {
+    key: "deleteOrphanBlock",
+    value: function () {
+      var _deleteOrphanBlock = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee0(_ref7) {
+        var blockAri, resourceId, parentAri, deleteReason, stepVersion;
+        return _regenerator.default.wrap(function _callee0$(_context1) {
+          while (1) switch (_context1.prev = _context1.next) {
+            case 0:
+              blockAri = _ref7.blockAri, resourceId = _ref7.resourceId, parentAri = _ref7.parentAri, deleteReason = _ref7.deleteReason;
+              _context1.prev = 1;
+              if (!this.getVersion) {
+                _context1.next = 8;
+                break;
+              }
+              _context1.next = 5;
+              return this.getVersion();
+            case 5:
+              _context1.t0 = _context1.sent;
+              _context1.next = 9;
+              break;
+            case 8:
+              _context1.t0 = undefined;
+            case 9:
+              stepVersion = _context1.t0;
+              _context1.prev = 10;
+              _context1.next = 13;
+              return (0, _blockService.createSyncedBlock)({
+                blockAri: blockAri,
+                blockInstanceId: resourceId,
+                sourceAri: parentAri,
+                product: this.product,
+                content: '[]',
+                stepVersion: stepVersion
+              });
+            case 13:
+              _context1.next = 25;
+              break;
+            case 15:
+              _context1.prev = 15;
+              _context1.t1 = _context1["catch"](10);
+              if (!(_context1.t1 instanceof Error && _context1.t1.message.includes('Conditional check failed'))) {
+                _context1.next = 20;
+                break;
+              }
+              _context1.next = 25;
+              break;
+            case 20:
+              if (!(_context1.t1 instanceof _blockService.BlockError)) {
+                _context1.next = 24;
+                break;
+              }
+              return _context1.abrupt("return", {
+                resourceId: resourceId,
+                success: false,
+                error: mapBlockError(_context1.t1)
+              });
+            case 24:
+              return _context1.abrupt("return", {
+                resourceId: resourceId,
+                success: false,
+                error: (0, _errorHandling.stringifyError)(_context1.t1)
+              });
+            case 25:
+              _context1.next = 27;
+              return (0, _blockService.deleteSyncedBlock)({
+                blockAri: blockAri,
+                deleteReason: deleteReason
+              });
+            case 27:
+              return _context1.abrupt("return", {
+                resourceId: resourceId,
+                success: true,
+                error: undefined
+              });
+            case 30:
+              _context1.prev = 30;
+              _context1.t2 = _context1["catch"](1);
+              if (!(_context1.t2 instanceof _blockService.BlockError)) {
+                _context1.next = 34;
+                break;
+              }
+              return _context1.abrupt("return", {
+                resourceId: resourceId,
+                success: false,
+                error: mapBlockError(_context1.t2)
+              });
+            case 34:
+              return _context1.abrupt("return", {
+                resourceId: resourceId,
+                success: false,
+                error: (0, _errorHandling.stringifyError)(_context1.t2)
+              });
+            case 35:
+            case "end":
+              return _context1.stop();
+          }
+        }, _callee0, this, [[1, 30], [10, 15]]);
+      }));
+      function deleteOrphanBlock(_x18) {
+        return _deleteOrphanBlock.apply(this, arguments);
+      }
+      return deleteOrphanBlock;
     }() // the sourceId is the resourceId of the source synced block.
   }, {
     key: "generateResourceIdForReference",
@@ -1089,22 +1205,22 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
   }, {
     key: "updateReferenceData",
     value: function () {
-      var _updateReferenceData = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee0(blocks, noContent) {
+      var _updateReferenceData = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee1(blocks, noContent) {
         var _this2 = this;
-        return _regenerator.default.wrap(function _callee0$(_context1) {
-          while (1) switch (_context1.prev = _context1.next) {
+        return _regenerator.default.wrap(function _callee1$(_context10) {
+          while (1) switch (_context10.prev = _context10.next) {
             case 0:
               if (this.parentAri) {
-                _context1.next = 2;
+                _context10.next = 2;
                 break;
               }
-              return _context1.abrupt("return", {
+              return _context10.abrupt("return", {
                 success: false,
                 error: _types.SyncBlockError.Errored
               });
             case 2:
-              _context1.prev = 2;
-              _context1.next = 5;
+              _context10.prev = 2;
+              _context10.next = 5;
               return (0, _blockService.updateReferenceSyncedBlockOnDocument)({
                 documentAri: this.parentAri,
                 blocks: blocks.map(function (block) {
@@ -1119,32 +1235,32 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
                 noContent: noContent
               });
             case 5:
-              return _context1.abrupt("return", {
+              return _context10.abrupt("return", {
                 success: true
               });
             case 8:
-              _context1.prev = 8;
-              _context1.t0 = _context1["catch"](2);
-              if (!(_context1.t0 instanceof _blockService.BlockError)) {
-                _context1.next = 12;
+              _context10.prev = 8;
+              _context10.t0 = _context10["catch"](2);
+              if (!(_context10.t0 instanceof _blockService.BlockError)) {
+                _context10.next = 12;
                 break;
               }
-              return _context1.abrupt("return", {
+              return _context10.abrupt("return", {
                 success: false,
-                error: mapBlockError(_context1.t0)
+                error: mapBlockError(_context10.t0)
               });
             case 12:
-              return _context1.abrupt("return", {
+              return _context10.abrupt("return", {
                 success: false,
-                error: (0, _errorHandling.stringifyError)(_context1.t0)
+                error: (0, _errorHandling.stringifyError)(_context10.t0)
               });
             case 13:
             case "end":
-              return _context1.stop();
+              return _context10.stop();
           }
-        }, _callee0, this, [[2, 8]]);
+        }, _callee1, this, [[2, 8]]);
       }));
-      function updateReferenceData(_x18, _x19) {
+      function updateReferenceData(_x19, _x20) {
         return _updateReferenceData.apply(this, arguments);
       }
       return updateReferenceData;
@@ -1152,17 +1268,17 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
   }, {
     key: "writeDataBatch",
     value: function () {
-      var _writeDataBatch = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee1(data) {
+      var _writeDataBatch = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee10(data) {
         var _this3 = this;
         var stepVersion, blockAriToResourceIdMap, blocks, response, results, successResourceIds, _iterator6, _step6, block, errorResourceIds, _iterator7, _step7, _loop2;
-        return _regenerator.default.wrap(function _callee1$(_context11) {
-          while (1) switch (_context11.prev = _context11.next) {
+        return _regenerator.default.wrap(function _callee10$(_context12) {
+          while (1) switch (_context12.prev = _context12.next) {
             case 0:
               if (!(!this.parentAri || !this.parentId)) {
-                _context11.next = 2;
+                _context12.next = 2;
                 break;
               }
-              return _context11.abrupt("return", data.map(function (block) {
+              return _context12.abrupt("return", data.map(function (block) {
                 return {
                   error: _types.SyncBlockError.Errored,
                   resourceId: block.resourceId
@@ -1170,20 +1286,20 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
               }));
             case 2:
               if (!this.getVersion) {
-                _context11.next = 8;
+                _context12.next = 8;
                 break;
               }
-              _context11.next = 5;
+              _context12.next = 5;
               return this.getVersion();
             case 5:
-              _context11.t0 = _context11.sent;
-              _context11.next = 9;
+              _context12.t0 = _context12.sent;
+              _context12.next = 9;
               break;
             case 8:
-              _context11.t0 = undefined;
+              _context12.t0 = undefined;
             case 9:
-              stepVersion = _context11.t0;
-              _context11.prev = 10;
+              stepVersion = _context12.t0;
+              _context12.prev = 10;
               // Create a map from blockAri to original resourceId for matching responses
               blockAriToResourceIdMap = new Map();
               blocks = data.map(function (block) {
@@ -1196,12 +1312,12 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
                   stepVersion: stepVersion
                 };
               });
-              _context11.next = 15;
+              _context12.next = 15;
               return (0, _blockService.updateSyncedBlocks)({
                 blocks: blocks
               });
             case 15:
-              response = _context11.sent;
+              response = _context12.sent;
               results = []; // Process successful updates
               if (response.success) {
                 successResourceIds = new Set(response.success.map(function (block) {
@@ -1224,7 +1340,7 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
                 }
               }
               if (!response.error) {
-                _context11.next = 36;
+                _context12.next = 36;
                 break;
               }
               errorResourceIds = new Map(response.error.map(function (err) {
@@ -1233,11 +1349,11 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
                 blockAriToResourceIdMap.get(err.blockAri) || '', mapErrorResponseCode(err.code)];
               }));
               _iterator7 = _createForOfIteratorHelper(data);
-              _context11.prev = 21;
+              _context12.prev = 21;
               _loop2 = /*#__PURE__*/_regenerator.default.mark(function _loop2() {
                 var block, error;
-                return _regenerator.default.wrap(function _loop2$(_context10) {
-                  while (1) switch (_context10.prev = _context10.next) {
+                return _regenerator.default.wrap(function _loop2$(_context11) {
+                  while (1) switch (_context11.prev = _context11.next) {
                     case 0:
                       block = _step7.value;
                       error = errorResourceIds.get(block.resourceId);
@@ -1266,72 +1382,72 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
                       }
                     case 3:
                     case "end":
-                      return _context10.stop();
+                      return _context11.stop();
                   }
                 }, _loop2);
               });
               _iterator7.s();
             case 24:
               if ((_step7 = _iterator7.n()).done) {
-                _context11.next = 28;
+                _context12.next = 28;
                 break;
               }
-              return _context11.delegateYield(_loop2(), "t1", 26);
+              return _context12.delegateYield(_loop2(), "t1", 26);
             case 26:
-              _context11.next = 24;
+              _context12.next = 24;
               break;
             case 28:
-              _context11.next = 33;
+              _context12.next = 33;
               break;
             case 30:
-              _context11.prev = 30;
-              _context11.t2 = _context11["catch"](21);
-              _iterator7.e(_context11.t2);
+              _context12.prev = 30;
+              _context12.t2 = _context12["catch"](21);
+              _iterator7.e(_context12.t2);
             case 33:
-              _context11.prev = 33;
+              _context12.prev = 33;
               _iterator7.f();
-              return _context11.finish(33);
+              return _context12.finish(33);
             case 36:
-              return _context11.abrupt("return", results);
+              return _context12.abrupt("return", results);
             case 39:
-              _context11.prev = 39;
-              _context11.t3 = _context11["catch"](10);
-              if (!(_context11.t3 instanceof _blockService.BlockError)) {
-                _context11.next = 43;
+              _context12.prev = 39;
+              _context12.t3 = _context12["catch"](10);
+              if (!(_context12.t3 instanceof _blockService.BlockError)) {
+                _context12.next = 43;
                 break;
               }
-              return _context11.abrupt("return", data.map(function (block) {
+              return _context12.abrupt("return", data.map(function (block) {
                 return {
-                  error: mapBlockError(_context11.t3),
+                  error: mapBlockError(_context12.t3),
                   resourceId: block.resourceId
                 };
               }));
             case 43:
-              return _context11.abrupt("return", data.map(function (block) {
+              return _context12.abrupt("return", data.map(function (block) {
                 return {
-                  error: (0, _errorHandling.stringifyError)(_context11.t3),
+                  error: (0, _errorHandling.stringifyError)(_context12.t3),
                   resourceId: block.resourceId
                 };
               }));
             case 44:
             case "end":
-              return _context11.stop();
+              return _context12.stop();
           }
-        }, _callee1, this, [[10, 39], [21, 30, 33, 36]]);
+        }, _callee10, this, [[10, 39], [21, 30, 33, 36]]);
       }));
-      function writeDataBatch(_x20) {
+      function writeDataBatch(_x21) {
         return _writeDataBatch.apply(this, arguments);
       }
       return writeDataBatch;
     }()
   }]);
 }();
-var createBlockServiceAPIProviders = function createBlockServiceAPIProviders(_ref7) {
-  var cloudId = _ref7.cloudId,
-    parentAri = _ref7.parentAri,
-    parentId = _ref7.parentId,
-    product = _ref7.product,
-    getVersion = _ref7.getVersion;
+var createBlockServiceAPIProviders = function createBlockServiceAPIProviders(_ref8) {
+  var cloudId = _ref8.cloudId,
+    parentAri = _ref8.parentAri,
+    parentId = _ref8.parentId,
+    product = _ref8.product,
+    getVersion = _ref8.getVersion;
   return {
     fetchProvider: new BlockServiceADFFetchProvider({
       cloudId: cloudId,
@@ -1346,12 +1462,12 @@ var createBlockServiceAPIProviders = function createBlockServiceAPIProviders(_re
     })
   };
 };
-var useMemoizedBlockServiceAPIProviders = exports.useMemoizedBlockServiceAPIProviders = function useMemoizedBlockServiceAPIProviders(_ref8) {
-  var cloudId = _ref8.cloudId,
-    parentAri = _ref8.parentAri,
-    parentId = _ref8.parentId,
-    product = _ref8.product,
-    getVersion = _ref8.getVersion;
+var useMemoizedBlockServiceAPIProviders = exports.useMemoizedBlockServiceAPIProviders = function useMemoizedBlockServiceAPIProviders(_ref9) {
+  var cloudId = _ref9.cloudId,
+    parentAri = _ref9.parentAri,
+    parentId = _ref9.parentId,
+    product = _ref9.product,
+    getVersion = _ref9.getVersion;
   return (0, _react.useMemo)(function () {
     return createBlockServiceAPIProviders({
       cloudId: cloudId,
@@ -1362,9 +1478,9 @@ var useMemoizedBlockServiceAPIProviders = exports.useMemoizedBlockServiceAPIProv
     });
   }, [cloudId, parentAri, parentId, product, getVersion]);
 };
-var createBlockServiceFetchOnlyAPIProvider = function createBlockServiceFetchOnlyAPIProvider(_ref9) {
-  var cloudId = _ref9.cloudId,
-    parentAri = _ref9.parentAri;
+var createBlockServiceFetchOnlyAPIProvider = function createBlockServiceFetchOnlyAPIProvider(_ref0) {
+  var cloudId = _ref0.cloudId,
+    parentAri = _ref0.parentAri;
   return {
     fetchProvider: new BlockServiceADFFetchProvider({
       cloudId: cloudId,
@@ -1377,9 +1493,9 @@ var createBlockServiceFetchOnlyAPIProvider = function createBlockServiceFetchOnl
 /**
  * If the parentAri is not a valid ARI, pass in an empty string.
  */
-var useMemoizedBlockServiceFetchOnlyAPIProvider = exports.useMemoizedBlockServiceFetchOnlyAPIProvider = function useMemoizedBlockServiceFetchOnlyAPIProvider(_ref0) {
-  var cloudId = _ref0.cloudId,
-    parentAri = _ref0.parentAri;
+var useMemoizedBlockServiceFetchOnlyAPIProvider = exports.useMemoizedBlockServiceFetchOnlyAPIProvider = function useMemoizedBlockServiceFetchOnlyAPIProvider(_ref1) {
+  var cloudId = _ref1.cloudId,
+    parentAri = _ref1.parentAri;
   return (0, _react.useMemo)(function () {
     return createBlockServiceFetchOnlyAPIProvider({
       cloudId: cloudId,

package/dist/cjs/store-manager/sourceSyncBlockStoreManager.js

@@ -83,14 +83,31 @@ var SourceSyncBlockStoreManager = exports.SourceSyncBlockStoreManager = /*#__PUR
         if (!localId || !resourceId) {
           throw new Error('Local ID or resource ID is not set');
         }
-        var syncBlockData = (0, _utils.convertSyncBlockPMNodeToSyncBlockData)(syncBlockNode);
         var cachedBlock = this.syncBlockCache.get(resourceId);
-        if (cachedBlock && !(0, _isEqual.default)(syncBlockData.content, cachedBlock.content)) {
-          this.hasReceivedContentChange = true;
+        if ((0, _platformFeatureFlags.fg)('platform_synced_block_update_refactor')) {
+          var _cachedBlock$contentF;
+          // Fast path: if the PM content fragment hasn't changed, skip serialization entirely
+          // Fragment.eq() leverages ProseMirror's structural sharing for O(1) comparison
+          if (cachedBlock !== null && cachedBlock !== void 0 && (_cachedBlock$contentF = cachedBlock.contentFragment) !== null && _cachedBlock$contentF !== void 0 && _cachedBlock$contentF.eq(syncBlockNode.content)) {
+            return true;
+          }
+          var syncBlockData = (0, _utils.convertSyncBlockPMNodeToSyncBlockData)(syncBlockNode);
+          if (cachedBlock) {
+            this.hasReceivedContentChange = true;
+          }
+          this.syncBlockCache.set(resourceId, _objectSpread(_objectSpread({}, syncBlockData), {}, {
+            isDirty: true,
+            contentFragment: syncBlockNode.content
+          }));
+        } else {
+          var _syncBlockData = (0, _utils.convertSyncBlockPMNodeToSyncBlockData)(syncBlockNode);
+          if (cachedBlock && !(0, _isEqual.default)(_syncBlockData.content, cachedBlock.content)) {
+            this.hasReceivedContentChange = true;
+          }
+          this.syncBlockCache.set(resourceId, _objectSpread(_objectSpread({}, _syncBlockData), {}, {
+            isDirty: true
+          }));
         }
-        this.syncBlockCache.set(resourceId, _objectSpread(_objectSpread({}, syncBlockData), {}, {
-          isDirty: true
-        }));
         return true;
       } catch (error) {
         var _this$fireAnalyticsEv;

package/dist/es2019/clients/block-service/blockService.js

@@ -298,6 +298,18 @@ export class BlockError extends Error {
     this.status = status;
   }
 }
+
+/**
+ * Thrown when Block Service returns RESOURCE_NOT_FOUND for a block.
+ * This typically happens when an orphan block (e.g. from a copied page) is deleted.
+ * The caller should create the block first, then delete it to ensure a proper soft-delete record.
+ */
+export class BlockNotFoundError extends Error {
+  constructor() {
+    super('Block not found in Block Service');
+    this.name = 'BlockNotFoundError';
+  }
+}
 export class BlockTimeoutError extends Error {
   constructor() {
     super('Block request timed out');
@@ -404,10 +416,10 @@ export const deleteSyncedBlock = async ({
         return ((_e$extensions = e.extensions) === null || _e$extensions === void 0 ? void 0 : _e$extensions.errorType) === 'RESOURCE_NOT_FOUND';
       });
       if (allNotFound) {
-        // do not throw an error, return early
-        // as if the block is not found, it is likely an orphan from a page copy.
-        // delete the synced block should just delete the block from the ADF, no need to delete it from the block service as it does not exist.
-        return;
+        // Throw BlockNotFoundError so the caller can create the block first then retry the delete.
+        // Block Service uses soft-deletes: the entry must exist before deletion so a deletion-reason
+        // is stored (used to display errors in reference blocks).
+        throw new BlockNotFoundError();
       }
     }
     throw new Error(result.errors.map(e => e.message).join(', '));