@atlaskit/editor-synced-block-provider 4.1.5 → 4.1.7

package/AGENTS.md

@@ -1,16 +1,17 @@
 # Synced Block Provider — Developer Agent Guide
 
-> **Package**: `@atlaskit/editor-synced-block-provider`
-> **Purpose**: Data layer for synced blocks — store managers, block service API client, ARI generation, permissions, media tokens.
-> **Full Knowledge Base**: [Synced Blocks — Comprehensive Knowledge Base](https://hello.atlassian.net/wiki/spaces/egcuc/pages/6679548384)
+> **Package**: `@atlaskit/editor-synced-block-provider` **Purpose**: Data layer for synced blocks —
+> store managers, block service API client, ARI generation, permissions, media tokens. **Full
+> Knowledge Base**:
+> [Synced Blocks — Comprehensive Knowledge Base](https://hello.atlassian.net/wiki/spaces/egcuc/pages/6679548384)
 
 ---
 
 ## Quick Context
 
 This package manages the lifecycle and state of synced blocks for both source and reference nodes.
-It provides the data fetching, caching, subscription, and persistence layer used by the editor plugin
-and the renderer across Confluence and Jira.
+It provides the data fetching, caching, subscription, and persistence layer used by the editor
+plugin and the renderer across Confluence and Jira.
 
 ---
 
@@ -62,17 +63,19 @@ SyncBlockStoreManager (parent coordinator)
 
 ### ARI Formats & Utilities
 
-| Function | ARI Pattern | Example |
-|----------|-------------|---------|
-| `generateBlockAri({cloudId, parentId, product, resourceId})` | Source block ARI | `ari:cloud:block::{cloudId}/confluence-page:{pageId}/{localId}` |
-| `generateBlockAriFromReference({cloudId, resourceId})` | Reference block ARI | — |
-| `getConfluencePageAri({pageId, cloudId, pageType})` | Confluence page | `ari:cloud:confluence::{cloudId}:page/{pageId}` |
-| `getJiraWorkItemAri({cloudId, workItemId})` | Jira issue | `ari:cloud:jira::{cloudId}:work-item/{issueId}` |
-| `getJiraWorkItemIdFromAri(ari)` | Extract issue ID from ARI | — |
+| Function                                                     | ARI Pattern               | Example                                                         |
+| ------------------------------------------------------------ | ------------------------- | --------------------------------------------------------------- |
+| `generateBlockAri({cloudId, parentId, product, resourceId})` | Source block ARI          | `ari:cloud:block::{cloudId}/confluence-page:{pageId}/{localId}` |
+| `generateBlockAriFromReference({cloudId, resourceId})`       | Reference block ARI       | —                                                               |
+| `getConfluencePageAri({pageId, cloudId, pageType})`          | Confluence page           | `ari:cloud:confluence::{cloudId}:page/{pageId}`                 |
+| `getJiraWorkItemAri({cloudId, workItemId})`                  | Jira issue                | `ari:cloud:jira::{cloudId}:work-item/{issueId}`                 |
+| `getJiraWorkItemIdFromAri(ari)`                              | Extract issue ID from ARI | —                                                               |
 
 ### Block Service API
 
-The client in `clients/block-service/blockService.ts` communicates via GraphQL at `/gateway/api/graphql`:
+The client in `clients/block-service/blockService.ts` communicates via GraphQL at
+`/gateway/api/graphql`:
+
 - **Fetch**: Single or batch block content retrieval
 - **Create**: Register new source block with content
 - **Update**: Push content changes (debounced 3s)
@@ -82,27 +85,33 @@ The client in `clients/block-service/blockService.ts` communicates via GraphQL a
 
 ### Media Token Fetching
 
-`fetchMediaToken(contentId)` → GraphQL `MediaUploadTokenQuery` → returns `{token, config: {clientId, fileStoreUrl}, collectionId}`
+`fetchMediaToken(contentId)` → GraphQL `MediaUploadTokenQuery` → returns
+`{token, config: {clientId, fileStoreUrl}, collectionId}`
 
-Used when synced blocks contain media (images, files) — the reference needs a valid token to render media from the source page.
+Used when synced blocks contain media (images, files) — the reference needs a valid token to render
+media from the source page.
 
 ---
 
 ## Common Tasks
 
 ### Adding a new API method
+
 1. Add the GraphQL query/mutation in `clients/block-service/blockService.ts`
 2. Expose it through the appropriate store manager
 3. Export from `src/index.ts` if needed by product integrations
 4. Add tests in `editor-synced-block-provider-tests`
 
 ### Debugging data issues
+
 1. Check `ReferenceSyncBlockStoreManager` cache state
 2. Verify ARI format matches expected pattern for the product
 3. Check Block Service API responses in network tab (look for `/gateway/api/graphql`)
-4. Use analytics: [HOW-TO: Debug errors](https://hello.atlassian.net/wiki/spaces/egcuc/pages/6342760320)
+4. Use analytics:
+   [HOW-TO: Debug errors](https://hello.atlassian.net/wiki/spaces/egcuc/pages/6342760320)
 
 ### Adding support for a new product
+
 1. Create ARI utilities in `clients/{product}/ari.ts`
 2. Ensure `generateBlockAri` supports the new product type
 3. Add media token fetching if the product has media content
@@ -111,7 +120,10 @@ Used when synced blocks contain media (images, files) — the reference needs a
 ---
 
 ## Related Packages
+
 - **Plugin**: `platform/packages/editor/editor-plugin-synced-block/` — uses store managers
 - **Renderer**: `platform/packages/editor/editor-synced-block-renderer/` — uses fetch provider
-- **Confluence**: `confluence/next/packages/fabric-providers/src/SyncedBlockProvider.ts` — wraps this provider
-- **Jira**: `jira/src/packages/issue/issue-view-synced-block-provider/` — wraps this provider with Relay
+- **Confluence**: `confluence/next/packages/fabric-providers/src/SyncedBlockProvider.ts` — wraps
+  this provider
+- **Jira**: `jira/src/packages/issue/issue-view-synced-block-provider/` — wraps this provider with
+  Relay

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @atlaskit/editor-synced-block-provider
 
+## 4.1.7
+
+### Patch Changes
+
+- [`612d18a57aabd`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/612d18a57aabd) -
+  404s on updating a source synced block should be ignored
+- Updated dependencies
+
+## 4.1.6
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 4.1.5
 
 ### Patch Changes

package/dist/cjs/providers/block-service/blockServiceAPI.js

@@ -12,6 +12,7 @@ var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/creat
 var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toConsumableArray"));
 var _asyncToGenerator2 = _interopRequireDefault(require("@babel/runtime/helpers/asyncToGenerator"));
 var _react = require("react");
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _ari = require("../../clients/block-service/ari");
 var _blockService = require("../../clients/block-service/blockService");
@@ -49,6 +50,8 @@ var mapErrorResponseCode = function mapErrorResponseCode(errorCode) {
   switch (errorCode) {
     case 'FORBIDDEN':
       return _types.SyncBlockError.Forbidden;
+    case 'RESOURCE_NOT_FOUND':
+      return (0, _platformFeatureFlags.fg)('block_service_source_repair') ? _types.SyncBlockError.NotFound : _types.SyncBlockError.Errored;
     case 'NOT_FOUND':
       return _types.SyncBlockError.NotFound;
     case 'INVALID_REQUEST':
@@ -832,8 +835,6 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
     this.product = product;
     this.getVersion = getVersion;
   }
-
-  // it will first try to update and if it can't (404) then it will try to create
   return (0, _createClass2.default)(BlockServiceADFWriteProvider, [{
     key: "writeData",
     value: function () {
@@ -1241,10 +1242,19 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
                       block = _step7.value;
                       error = errorResourceIds.get(block.resourceId);
                       if (error) {
-                        results.push({
-                          error: error,
-                          resourceId: block.resourceId
-                        });
+                        if ((0, _platformFeatureFlags.fg)('block_service_source_repair')) {
+                          if (error !== _types.SyncBlockError.NotFound) {
+                            results.push({
+                              error: error,
+                              resourceId: block.resourceId
+                            });
+                          }
+                        } else {
+                          results.push({
+                            error: error,
+                            resourceId: block.resourceId
+                          });
+                        }
                       } else if (!results.some(function (r) {
                         return r.resourceId === block.resourceId;
                       })) {

package/dist/es2019/providers/block-service/blockServiceAPI.js

@@ -1,5 +1,6 @@
 /* eslint-disable require-unicode-regexp  */
 import { useMemo } from 'react';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { generateBlockAri, generateBlockAriFromReference } from '../../clients/block-service/ari';
 import { batchRetrieveSyncedBlocks, BlockError, BlockTimeoutError, createSyncedBlock, deleteSyncedBlock, getReferenceSyncedBlocks, getReferenceSyncedBlocksByBlockAri, getSyncedBlockContent, updateReferenceSyncedBlockOnDocument, updateSyncedBlock, updateSyncedBlocks } from '../../clients/block-service/blockService';
@@ -32,6 +33,8 @@ const mapErrorResponseCode = errorCode => {
   switch (errorCode) {
     case 'FORBIDDEN':
       return SyncBlockError.Forbidden;
+    case 'RESOURCE_NOT_FOUND':
+      return fg('block_service_source_repair') ? SyncBlockError.NotFound : SyncBlockError.Errored;
     case 'NOT_FOUND':
       return SyncBlockError.NotFound;
     case 'INVALID_REQUEST':
@@ -573,8 +576,6 @@ class BlockServiceADFWriteProvider {
     this.product = product;
     this.getVersion = getVersion;
   }
-
-  // it will first try to update and if it can't (404) then it will try to create
   async writeData(data) {
     if (!this.parentAri || !this.parentId) {
       return {
@@ -802,10 +803,19 @@ class BlockServiceADFWriteProvider {
         for (const block of data) {
           const error = errorResourceIds.get(block.resourceId);
           if (error) {
-            results.push({
-              error,
-              resourceId: block.resourceId
-            });
+            if (fg('block_service_source_repair')) {
+              if (error !== SyncBlockError.NotFound) {
+                results.push({
+                  error,
+                  resourceId: block.resourceId
+                });
+              }
+            } else {
+              results.push({
+                error,
+                resourceId: block.resourceId
+              });
+            }
           } else if (!results.some(r => r.resourceId === block.resourceId)) {
             // If not in success or error lists, mark as errored
             results.push({

package/dist/esm/providers/block-service/blockServiceAPI.js

@@ -11,6 +11,7 @@ function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length)
 import _regeneratorRuntime from "@babel/runtime/regenerator";
 /* eslint-disable require-unicode-regexp  */
 import { useMemo } from 'react';
+import { fg } from '@atlaskit/platform-feature-flags';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { generateBlockAri as _generateBlockAri, generateBlockAriFromReference } from '../../clients/block-service/ari';
 import { batchRetrieveSyncedBlocks, BlockError, BlockTimeoutError, createSyncedBlock, deleteSyncedBlock, getReferenceSyncedBlocks, getReferenceSyncedBlocksByBlockAri, getSyncedBlockContent, updateReferenceSyncedBlockOnDocument, updateSyncedBlock, updateSyncedBlocks } from '../../clients/block-service/blockService';
@@ -43,6 +44,8 @@ var mapErrorResponseCode = function mapErrorResponseCode(errorCode) {
   switch (errorCode) {
     case 'FORBIDDEN':
       return SyncBlockError.Forbidden;
+    case 'RESOURCE_NOT_FOUND':
+      return fg('block_service_source_repair') ? SyncBlockError.NotFound : SyncBlockError.Errored;
     case 'NOT_FOUND':
       return SyncBlockError.NotFound;
     case 'INVALID_REQUEST':
@@ -827,8 +830,6 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
     this.product = product;
     this.getVersion = getVersion;
   }
-
-  // it will first try to update and if it can't (404) then it will try to create
   return _createClass(BlockServiceADFWriteProvider, [{
     key: "writeData",
     value: function () {
@@ -1236,10 +1237,19 @@ var BlockServiceADFWriteProvider = /*#__PURE__*/function () {
                       block = _step7.value;
                       error = errorResourceIds.get(block.resourceId);
                       if (error) {
-                        results.push({
-                          error: error,
-                          resourceId: block.resourceId
-                        });
+                        if (fg('block_service_source_repair')) {
+                          if (error !== SyncBlockError.NotFound) {
+                            results.push({
+                              error: error,
+                              resourceId: block.resourceId
+                            });
+                          }
+                        } else {
+                          results.push({
+                            error: error,
+                            resourceId: block.resourceId
+                          });
+                        }
                       } else if (!results.some(function (r) {
                         return r.resourceId === block.resourceId;
                       })) {

package/package.json

@@ -29,7 +29,7 @@
 		"@atlaskit/editor-prosemirror": "^7.3.0",
 		"@atlaskit/node-data-provider": "^9.0.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
-		"@atlaskit/tmp-editor-statsig": "^44.0.0",
+		"@atlaskit/tmp-editor-statsig": "^45.0.0",
 		"@babel/runtime": "^7.0.0",
 		"@compiled/react": "^0.20.0",
 		"graphql-ws": "^5.14.2",
@@ -38,7 +38,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^112.7.0",
+		"@atlaskit/editor-common": "^112.8.0",
 		"react": "^18.2.0"
 	},
 	"devDependencies": {
@@ -81,12 +81,16 @@
 		}
 	},
 	"name": "@atlaskit/editor-synced-block-provider",
-	"version": "4.1.5",
+	"version": "4.1.7",
 	"description": "Synced Block Provider for @atlaskit/editor-plugin-synced-block",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
 	},
-	"platform-feature-flags": {}
+	"platform-feature-flags": {
+		"block_service_source_repair": {
+			"type": "boolean"
+		}
+	}
 }