@atlaskit/editor-synced-block-provider 3.10.0 → 3.11.0

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @atlaskit/editor-synced-block-provider
 
+## 3.11.0
+
+### Minor Changes
+
+- [`7b4cb91fc67a6`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/7b4cb91fc67a6) -
+  Do not immediately show error state on initial load of blocks
+
 ## 3.10.0
 
 ### Minor Changes

package/dist/cjs/providers/syncBlockProvider.js

@@ -115,11 +115,21 @@ var SyncBlockProvider = exports.SyncBlockProvider = /*#__PURE__*/function (_Sync
             case 10:
               _context.prev = 10;
               _context.t0 = _context["catch"](4);
-              return _context.abrupt("return", blockIdentifiers.map(function (blockIdentifier) {
-                return {
-                  error: _types.SyncBlockError.Errored,
-                  resourceId: blockIdentifier.resourceId
-                };
+              return _context.abrupt("return", Promise.allSettled(blockIdentifiers.map(function (blockIdentifier) {
+                return _this2.fetchProvider.fetchData(blockIdentifier.resourceId).then(function (data) {
+                  return data;
+                }, function () {
+                  return {
+                    error: _types.SyncBlockError.Errored,
+                    resourceId: blockIdentifier.resourceId
+                  };
+                });
+              })).then(function (results) {
+                return results.filter(function (result) {
+                  return result.status === 'fulfilled';
+                }).map(function (result) {
+                  return result.value;
+                });
               }));
             case 13:
               _context.next = 16;

package/dist/es2019/providers/syncBlockProvider.js

@@ -66,11 +66,22 @@ export class SyncBlockProvider extends SyncBlockDataProvider {
       try {
         return await this.fetchProvider.batchFetchData(blockIdentifiers);
       } catch {
-        // If batch fetch fails, return error for all resourceIds
-        return blockIdentifiers.map(blockIdentifier => ({
-          error: SyncBlockError.Errored,
-          resourceId: blockIdentifier.resourceId
-        }));
+        // If batch fetch fails, fall back to individual fetch behavior
+        // This allows loading states to be shown before errors, matching non-batch behavior
+        return Promise.allSettled(blockIdentifiers.map(blockIdentifier => {
+          return this.fetchProvider.fetchData(blockIdentifier.resourceId).then(data => {
+            return data;
+          }, () => {
+            return {
+              error: SyncBlockError.Errored,
+              resourceId: blockIdentifier.resourceId
+            };
+          });
+        })).then(results => {
+          return results.filter(result => {
+            return result.status === 'fulfilled';
+          }).map(result => result.value);
+        });
       }
     } else {
       return Promise.allSettled(blockIdentifiers.map(blockIdentifier => {

package/dist/esm/providers/syncBlockProvider.js

@@ -108,11 +108,21 @@ export var SyncBlockProvider = /*#__PURE__*/function (_SyncBlockDataProvide) {
             case 10:
               _context.prev = 10;
               _context.t0 = _context["catch"](4);
-              return _context.abrupt("return", blockIdentifiers.map(function (blockIdentifier) {
-                return {
-                  error: SyncBlockError.Errored,
-                  resourceId: blockIdentifier.resourceId
-                };
+              return _context.abrupt("return", Promise.allSettled(blockIdentifiers.map(function (blockIdentifier) {
+                return _this2.fetchProvider.fetchData(blockIdentifier.resourceId).then(function (data) {
+                  return data;
+                }, function () {
+                  return {
+                    error: SyncBlockError.Errored,
+                    resourceId: blockIdentifier.resourceId
+                  };
+                });
+              })).then(function (results) {
+                return results.filter(function (result) {
+                  return result.status === 'fulfilled';
+                }).map(function (result) {
+                  return result.value;
+                });
               }));
             case 13:
               _context.next = 16;

package/package.json

@@ -77,7 +77,7 @@
 		}
 	},
 	"name": "@atlaskit/editor-synced-block-provider",
-	"version": "3.10.0",
+	"version": "3.11.0",
 	"description": "Synced Block Provider for @atlaskit/editor-plugin-synced-block",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",