@atlaskit/editor-synced-block-provider 2.2.2 → 2.2.3

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @atlaskit/editor-synced-block-provider
 
+## 2.2.3
+
+### Patch Changes
+
+- [`b32a210dc472a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b32a210dc472a) -
+  Refactor async logic
+
 ## 2.2.2
 
 ### Patch Changes

package/dist/cjs/hooks/useFetchSyncBlockData.js

@@ -4,10 +4,11 @@ var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefau
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.useFetchSyncBlockData = void 0;
+exports.useFetchSyncBlockData = exports.SYNC_BLOCK_FETCH_INTERVAL = void 0;
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = require("react");
 var _types = require("../common/types");
+var SYNC_BLOCK_FETCH_INTERVAL = exports.SYNC_BLOCK_FETCH_INTERVAL = 3000;
 var useFetchSyncBlockData = exports.useFetchSyncBlockData = function useFetchSyncBlockData(manager, syncBlockNode) {
   var _useState = (0, _react.useState)(null),
     _useState2 = (0, _slicedToArray2.default)(_useState, 2),
@@ -40,7 +41,7 @@ var useFetchSyncBlockData = exports.useFetchSyncBlockData = function useFetchSyn
   }, [manager, syncBlockNode]);
   (0, _react.useEffect)(function () {
     fetchSyncBlockNode();
-    var interval = window.setInterval(fetchSyncBlockNode, 3000);
+    var interval = window.setInterval(fetchSyncBlockNode, SYNC_BLOCK_FETCH_INTERVAL);
     return function () {
       window.clearInterval(interval);
     };

package/dist/cjs/hooks/useHandleContentChanges.js

@@ -7,7 +7,10 @@ exports.useHandleContentChanges = void 0;
 var _react = require("react");
 var useHandleContentChanges = exports.useHandleContentChanges = function useHandleContentChanges(manager, syncBlockNode) {
   (0, _react.useEffect)(function () {
-    //TODO: EDITOR-1921 - add error analytics
-    manager.updateSyncBlockData(syncBlockNode);
+    try {
+      manager.updateSyncBlockData(syncBlockNode);
+    } catch (_unused) {
+      //TODO: EDITOR-1921 - add error analytics
+    }
   }, [manager, syncBlockNode]);
 };

package/dist/cjs/store-manager/referenceSyncBlockStoreManager.js

@@ -81,27 +81,35 @@ var ReferenceSyncBlockStoreManager = exports.ReferenceSyncBlockStoreManager = /*
                   resourceId: syncBlockNode.attrs.resourceId
                 });
               }
-              _context.next = 7;
+              _context.prev = 5;
+              _context.next = 8;
               return this.dataProvider.fetchNodesData([syncNode]);
-            case 7:
+            case 8:
               data = _context.sent;
               if (data) {
-                _context.next = 10;
+                _context.next = 11;
                 break;
               }
               throw new Error('Failed to fetch sync block node data');
-            case 10:
+            case 11:
+              _context.next = 16;
+              break;
+            case 13:
+              _context.prev = 13;
+              _context.t0 = _context["catch"](5);
+              throw new Error('Failed to fetch sync block node data');
+            case 16:
               fetchSyncBlockDataResult = data[0];
               if (!fetchSyncBlockDataResult.error && fetchSyncBlockDataResult.data) {
                 // only adds it to the map if it did not error out
                 this.syncBlockCache.set(syncBlockNode.attrs.localId, _objectSpread(_objectSpread({}, existingSyncBlock), fetchSyncBlockDataResult.data));
               }
               return _context.abrupt("return", fetchSyncBlockDataResult);
-            case 13:
+            case 19:
             case "end":
               return _context.stop();
           }
-        }, _callee, this);
+        }, _callee, this, [[5, 13]]);
       }));
       function fetchSyncBlockData(_x) {
         return _fetchSyncBlockData.apply(this, arguments);

package/dist/cjs/store-manager/sourceSyncBlockStoreManager.js

@@ -27,18 +27,15 @@ var SourceSyncBlockStoreManager = exports.SourceSyncBlockStoreManager = /*#__PUR
   return (0, _createClass2.default)(SourceSyncBlockStoreManager, [{
     key: "updateSyncBlockData",
     value: function updateSyncBlockData(syncBlockNode) {
-      try {
-        var _syncBlockNode$attrs = syncBlockNode.attrs,
-          localId = _syncBlockNode$attrs.localId,
-          resourceId = _syncBlockNode$attrs.resourceId;
-        if (!localId || !resourceId) {
-          throw new Error('Local ID or resource ID is not set');
-        }
-        var syncBlockData = (0, _utils.convertSyncBlockPMNodeToSyncBlockData)(syncBlockNode);
-        this.syncBlockCache.set(localId, syncBlockData);
-      } catch (_unused) {
-        //TODO: EDITOR-1921 - add error analytics
+      var _syncBlockNode$attrs = syncBlockNode.attrs,
+        localId = _syncBlockNode$attrs.localId,
+        resourceId = _syncBlockNode$attrs.resourceId;
+      if (!localId || !resourceId) {
+        throw new Error('Local ID or resource ID is not set');
       }
+      var syncBlockData = (0, _utils.convertSyncBlockPMNodeToSyncBlockData)(syncBlockNode);
+      this.syncBlockCache.set(localId, syncBlockData);
+      return true;
     }
 
     /**

package/dist/cjs/store-manager/syncBlockStoreManager.js

@@ -23,6 +23,9 @@ var SyncBlockStoreManager = exports.SyncBlockStoreManager = /*#__PURE__*/functio
   return (0, _createClass2.default)(SyncBlockStoreManager, [{
     key: "fetchSyncBlockData",
     value: function fetchSyncBlockData(syncBlockNode) {
+      if (!['bodiedSyncBlock', 'syncBlock'].includes(syncBlockNode.type.name)) {
+        throw new Error('Node is not a sync block');
+      }
       if (this.isSourceBlock(syncBlockNode)) {
         return Promise.reject(new Error('Invalid sync block node type provided for fetchSyncBlockData'));
       }
@@ -37,7 +40,7 @@ var SyncBlockStoreManager = exports.SyncBlockStoreManager = /*#__PURE__*/functio
     key: "updateSyncBlockData",
     value: function updateSyncBlockData(syncBlockNode) {
       if (this.isSourceBlock(syncBlockNode)) {
-        this.sourceSyncBlockStoreManager.updateSyncBlockData(syncBlockNode);
+        return this.sourceSyncBlockStoreManager.updateSyncBlockData(syncBlockNode);
       } else {
         throw new Error('Invalid sync block node type provided for updateSyncBlockData');
       }

package/dist/es2019/hooks/useFetchSyncBlockData.js

@@ -1,5 +1,6 @@
 import { useCallback, useEffect, useState } from 'react';
 import { SyncBlockError } from '../common/types';
+export const SYNC_BLOCK_FETCH_INTERVAL = 3000;
 export const useFetchSyncBlockData = (manager, syncBlockNode) => {
   const [fetchSyncBlockDataResult, setFetchSyncBlockDataResult] = useState(null);
   const fetchSyncBlockNode = useCallback(() => {
@@ -29,7 +30,7 @@ export const useFetchSyncBlockData = (manager, syncBlockNode) => {
   }, [manager, syncBlockNode]);
   useEffect(() => {
     fetchSyncBlockNode();
-    const interval = window.setInterval(fetchSyncBlockNode, 3000);
+    const interval = window.setInterval(fetchSyncBlockNode, SYNC_BLOCK_FETCH_INTERVAL);
     return () => {
       window.clearInterval(interval);
     };

package/dist/es2019/hooks/useHandleContentChanges.js

@@ -1,7 +1,10 @@
 import { useEffect } from 'react';
 export const useHandleContentChanges = (manager, syncBlockNode) => {
   useEffect(() => {
-    //TODO: EDITOR-1921 - add error analytics
-    manager.updateSyncBlockData(syncBlockNode);
+    try {
+      manager.updateSyncBlockData(syncBlockNode);
+    } catch {
+      //TODO: EDITOR-1921 - add error analytics
+    }
   }, [manager, syncBlockNode]);
 };

package/dist/es2019/store-manager/referenceSyncBlockStoreManager.js

@@ -56,8 +56,13 @@ export class ReferenceSyncBlockStoreManager {
         resourceId: syncBlockNode.attrs.resourceId
       });
     }
-    const data = await this.dataProvider.fetchNodesData([syncNode]);
-    if (!data) {
+    let data;
+    try {
+      data = await this.dataProvider.fetchNodesData([syncNode]);
+      if (!data) {
+        throw new Error('Failed to fetch sync block node data');
+      }
+    } catch (error) {
       throw new Error('Failed to fetch sync block node data');
     }
     const fetchSyncBlockDataResult = data[0];

package/dist/es2019/store-manager/sourceSyncBlockStoreManager.js

@@ -13,19 +13,16 @@ export class SourceSyncBlockStoreManager {
    * @param syncBlockNode - The sync block node to update
    */
   updateSyncBlockData(syncBlockNode) {
-    try {
-      const {
-        localId,
-        resourceId
-      } = syncBlockNode.attrs;
-      if (!localId || !resourceId) {
-        throw new Error('Local ID or resource ID is not set');
-      }
-      const syncBlockData = convertSyncBlockPMNodeToSyncBlockData(syncBlockNode);
-      this.syncBlockCache.set(localId, syncBlockData);
-    } catch {
-      //TODO: EDITOR-1921 - add error analytics
+    const {
+      localId,
+      resourceId
+    } = syncBlockNode.attrs;
+    if (!localId || !resourceId) {
+      throw new Error('Local ID or resource ID is not set');
     }
+    const syncBlockData = convertSyncBlockPMNodeToSyncBlockData(syncBlockNode);
+    this.syncBlockCache.set(localId, syncBlockData);
+    return true;
   }
 
   /**

package/dist/es2019/store-manager/syncBlockStoreManager.js

@@ -12,6 +12,9 @@ export class SyncBlockStoreManager {
     this.sourceSyncBlockStoreManager = new SourceSyncBlockStoreManager(dataProvider);
   }
   fetchSyncBlockData(syncBlockNode) {
+    if (!['bodiedSyncBlock', 'syncBlock'].includes(syncBlockNode.type.name)) {
+      throw new Error('Node is not a sync block');
+    }
     if (this.isSourceBlock(syncBlockNode)) {
       return Promise.reject(new Error('Invalid sync block node type provided for fetchSyncBlockData'));
     }
@@ -24,7 +27,7 @@ export class SyncBlockStoreManager {
    */
   updateSyncBlockData(syncBlockNode) {
     if (this.isSourceBlock(syncBlockNode)) {
-      this.sourceSyncBlockStoreManager.updateSyncBlockData(syncBlockNode);
+      return this.sourceSyncBlockStoreManager.updateSyncBlockData(syncBlockNode);
     } else {
       throw new Error('Invalid sync block node type provided for updateSyncBlockData');
     }

package/dist/esm/hooks/useFetchSyncBlockData.js

@@ -1,6 +1,7 @@
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import { useCallback, useEffect, useState } from 'react';
 import { SyncBlockError } from '../common/types';
+export var SYNC_BLOCK_FETCH_INTERVAL = 3000;
 export var useFetchSyncBlockData = function useFetchSyncBlockData(manager, syncBlockNode) {
   var _useState = useState(null),
     _useState2 = _slicedToArray(_useState, 2),
@@ -33,7 +34,7 @@ export var useFetchSyncBlockData = function useFetchSyncBlockData(manager, syncB
   }, [manager, syncBlockNode]);
   useEffect(function () {
     fetchSyncBlockNode();
-    var interval = window.setInterval(fetchSyncBlockNode, 3000);
+    var interval = window.setInterval(fetchSyncBlockNode, SYNC_BLOCK_FETCH_INTERVAL);
     return function () {
       window.clearInterval(interval);
     };

package/dist/esm/hooks/useHandleContentChanges.js

@@ -1,7 +1,10 @@
 import { useEffect } from 'react';
 export var useHandleContentChanges = function useHandleContentChanges(manager, syncBlockNode) {
   useEffect(function () {
-    //TODO: EDITOR-1921 - add error analytics
-    manager.updateSyncBlockData(syncBlockNode);
+    try {
+      manager.updateSyncBlockData(syncBlockNode);
+    } catch (_unused) {
+      //TODO: EDITOR-1921 - add error analytics
+    }
   }, [manager, syncBlockNode]);
 };

package/dist/esm/store-manager/referenceSyncBlockStoreManager.js

@@ -74,27 +74,35 @@ export var ReferenceSyncBlockStoreManager = /*#__PURE__*/function () {
                   resourceId: syncBlockNode.attrs.resourceId
                 });
               }
-              _context.next = 7;
+              _context.prev = 5;
+              _context.next = 8;
               return this.dataProvider.fetchNodesData([syncNode]);
-            case 7:
+            case 8:
               data = _context.sent;
               if (data) {
-                _context.next = 10;
+                _context.next = 11;
                 break;
               }
               throw new Error('Failed to fetch sync block node data');
-            case 10:
+            case 11:
+              _context.next = 16;
+              break;
+            case 13:
+              _context.prev = 13;
+              _context.t0 = _context["catch"](5);
+              throw new Error('Failed to fetch sync block node data');
+            case 16:
               fetchSyncBlockDataResult = data[0];
               if (!fetchSyncBlockDataResult.error && fetchSyncBlockDataResult.data) {
                 // only adds it to the map if it did not error out
                 this.syncBlockCache.set(syncBlockNode.attrs.localId, _objectSpread(_objectSpread({}, existingSyncBlock), fetchSyncBlockDataResult.data));
               }
               return _context.abrupt("return", fetchSyncBlockDataResult);
-            case 13:
+            case 19:
             case "end":
               return _context.stop();
           }
-        }, _callee, this);
+        }, _callee, this, [[5, 13]]);
       }));
       function fetchSyncBlockData(_x) {
         return _fetchSyncBlockData.apply(this, arguments);

package/dist/esm/store-manager/sourceSyncBlockStoreManager.js

@@ -20,18 +20,15 @@ export var SourceSyncBlockStoreManager = /*#__PURE__*/function () {
   return _createClass(SourceSyncBlockStoreManager, [{
     key: "updateSyncBlockData",
     value: function updateSyncBlockData(syncBlockNode) {
-      try {
-        var _syncBlockNode$attrs = syncBlockNode.attrs,
-          localId = _syncBlockNode$attrs.localId,
-          resourceId = _syncBlockNode$attrs.resourceId;
-        if (!localId || !resourceId) {
-          throw new Error('Local ID or resource ID is not set');
-        }
-        var syncBlockData = convertSyncBlockPMNodeToSyncBlockData(syncBlockNode);
-        this.syncBlockCache.set(localId, syncBlockData);
-      } catch (_unused) {
-        //TODO: EDITOR-1921 - add error analytics
+      var _syncBlockNode$attrs = syncBlockNode.attrs,
+        localId = _syncBlockNode$attrs.localId,
+        resourceId = _syncBlockNode$attrs.resourceId;
+      if (!localId || !resourceId) {
+        throw new Error('Local ID or resource ID is not set');
       }
+      var syncBlockData = convertSyncBlockPMNodeToSyncBlockData(syncBlockNode);
+      this.syncBlockCache.set(localId, syncBlockData);
+      return true;
     }
 
     /**

package/dist/esm/store-manager/syncBlockStoreManager.js

@@ -17,6 +17,9 @@ export var SyncBlockStoreManager = /*#__PURE__*/function () {
   return _createClass(SyncBlockStoreManager, [{
     key: "fetchSyncBlockData",
     value: function fetchSyncBlockData(syncBlockNode) {
+      if (!['bodiedSyncBlock', 'syncBlock'].includes(syncBlockNode.type.name)) {
+        throw new Error('Node is not a sync block');
+      }
       if (this.isSourceBlock(syncBlockNode)) {
         return Promise.reject(new Error('Invalid sync block node type provided for fetchSyncBlockData'));
       }
@@ -31,7 +34,7 @@ export var SyncBlockStoreManager = /*#__PURE__*/function () {
     key: "updateSyncBlockData",
     value: function updateSyncBlockData(syncBlockNode) {
       if (this.isSourceBlock(syncBlockNode)) {
-        this.sourceSyncBlockStoreManager.updateSyncBlockData(syncBlockNode);
+        return this.sourceSyncBlockStoreManager.updateSyncBlockData(syncBlockNode);
       } else {
         throw new Error('Invalid sync block node type provided for updateSyncBlockData');
       }

package/dist/types/hooks/useFetchSyncBlockData.d.ts

@@ -1,4 +1,5 @@
 import { type Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import type { FetchSyncBlockDataResult } from '../providers/types';
 import type { SyncBlockStoreManager } from '../store-manager/syncBlockStoreManager';
+export declare const SYNC_BLOCK_FETCH_INTERVAL = 3000;
 export declare const useFetchSyncBlockData: (manager: SyncBlockStoreManager, syncBlockNode: PMNode) => FetchSyncBlockDataResult | null;

package/dist/types/store-manager/sourceSyncBlockStoreManager.d.ts

@@ -15,7 +15,7 @@ export declare class SourceSyncBlockStoreManager {
      * Add/update a sync block node to/from the local cache
      * @param syncBlockNode - The sync block node to update
      */
-    updateSyncBlockData(syncBlockNode: PMNode): void;
+    updateSyncBlockData(syncBlockNode: PMNode): boolean;
     /**
      * Save content of bodiedSyncBlock nodes in local cache to backend
      *

package/dist/types/store-manager/syncBlockStoreManager.d.ts

@@ -13,7 +13,7 @@ export declare class SyncBlockStoreManager {
      * Add/update a sync block node to/from the local cache
      * @param syncBlockNode - The sync block node to update
      */
-    updateSyncBlockData(syncBlockNode: PMNode): void;
+    updateSyncBlockData(syncBlockNode: PMNode): boolean;
     /**
      * Save content of bodiedSyncBlock nodes in local cache to backend
      *

package/dist/types-ts4.5/hooks/useFetchSyncBlockData.d.ts

@@ -1,4 +1,5 @@
 import { type Node as PMNode } from '@atlaskit/editor-prosemirror/model';
 import type { FetchSyncBlockDataResult } from '../providers/types';
 import type { SyncBlockStoreManager } from '../store-manager/syncBlockStoreManager';
+export declare const SYNC_BLOCK_FETCH_INTERVAL = 3000;
 export declare const useFetchSyncBlockData: (manager: SyncBlockStoreManager, syncBlockNode: PMNode) => FetchSyncBlockDataResult | null;

package/dist/types-ts4.5/store-manager/sourceSyncBlockStoreManager.d.ts

@@ -15,7 +15,7 @@ export declare class SourceSyncBlockStoreManager {
      * Add/update a sync block node to/from the local cache
      * @param syncBlockNode - The sync block node to update
      */
-    updateSyncBlockData(syncBlockNode: PMNode): void;
+    updateSyncBlockData(syncBlockNode: PMNode): boolean;
     /**
      * Save content of bodiedSyncBlock nodes in local cache to backend
      *

package/dist/types-ts4.5/store-manager/syncBlockStoreManager.d.ts

@@ -13,7 +13,7 @@ export declare class SyncBlockStoreManager {
      * Add/update a sync block node to/from the local cache
      * @param syncBlockNode - The sync block node to update
      */
-    updateSyncBlockData(syncBlockNode: PMNode): void;
+    updateSyncBlockData(syncBlockNode: PMNode): boolean;
     /**
      * Save content of bodiedSyncBlock nodes in local cache to backend
      *

package/package.json

@@ -82,7 +82,7 @@
 		}
 	},
 	"name": "@atlaskit/editor-synced-block-provider",
-	"version": "2.2.2",
+	"version": "2.2.3",
 	"description": "Synced Block Provider for @atlaskit/editor-plugin-synced-block",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",