@atlaskit/editor-synced-block-provider 10.0.3 → 10.0.5

package/dist/cjs/store-manager/syncBlockStoreManager.js

@@ -12,7 +12,6 @@ var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/cl
 var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/createClass"));
 var _react = require("react");
 var _monitoring = require("@atlaskit/editor-common/monitoring");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _ari = require("../clients/block-service/ari");
 var _types = require("../common/types");
 var _errorHandling = require("../utils/errorHandling");
@@ -308,7 +307,6 @@ var useMemoizedSyncBlockStoreManager = exports.useMemoizedSyncBlockStoreManager
     syncBlockStoreManager.setFireAnalyticsEvent(fireAnalyticsEvent);
   }
 
-  // Gated by platform_synced_block_patch_14:
   // Destroy the SyncBlockStoreManager when:
   //   (a) the component unmounts — manager is fully cleaned up, or
   //   (b) dataProvider changes — the old manager (now orphaned by the
@@ -320,9 +318,7 @@ var useMemoizedSyncBlockStoreManager = exports.useMemoizedSyncBlockStoreManager
   // changes, triggering the cleanup for the old instance.
   (0, _react.useEffect)(function () {
     return function () {
-      if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_14')) {
-        syncBlockStoreManager.destroy();
-      }
+      syncBlockStoreManager.destroy();
     };
   }, [syncBlockStoreManager]);
   return syncBlockStoreManager;

package/dist/cjs/store-manager/syncBlockSubscriptionManager.js

@@ -11,7 +11,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _bindEventListener = require("bind-event-listener");
 var _browserApis = require("@atlaskit/browser-apis");
 var _monitoring = require("@atlaskit/editor-common/monitoring");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _errorHandling = require("../utils/errorHandling");
 var _resolveSyncBlockInstance = require("../utils/resolveSyncBlockInstance");
 var _utils = require("../utils/utils");
@@ -35,12 +34,7 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
     (0, _defineProperty2.default)(this, "graphqlSubscriptions", new Map());
     (0, _defineProperty2.default)(this, "subscriptionChangeListeners", new Set());
     (0, _defineProperty2.default)(this, "useRealTimeSubscriptions", false);
-    // Track pending cache deletions to handle block moves (unmount/remount)
-    // When a block is moved, the old component unmounts before the new one mounts,
-    // causing the cache to be deleted prematurely. We delay deletion to allow
-    // the new component to subscribe and cancel the pending deletion.
-    (0, _defineProperty2.default)(this, "pendingCacheDeletions", new Map());
-    // backoff cap (gate ON)
+    // backoff cap
     (0, _defineProperty2.default)(this, "retryAttempts", new Map());
     (0, _defineProperty2.default)(this, "pendingRetries", new Map());
     // Resources whose reconnection exhausted while the tab was hidden: parked here and
@@ -74,21 +68,17 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
     // EDITOR-7861: higher ceiling lets transient WS-gateway drops self-heal
     // before a terminal failure is surfaced.
     function getMaxRetryAttempts() {
-      return (0, _platformFeatureFlags.fg)('platform_editor_blocks_patch_3') ? SyncBlockSubscriptionManager.MAX_RETRY_ATTEMPTS_HARDENED : SyncBlockSubscriptionManager.MAX_RETRY_ATTEMPTS;
+      return SyncBlockSubscriptionManager.MAX_RETRY_ATTEMPTS_HARDENED;
     }
 
-    // Backoff delay for the given attempt.
-    // Gate OFF: pure exponential (1s, 2s, 4s, 8s, 16s).
-    // Gate ON (EDITOR-7861): exponential capped at MAX_RETRY_DELAY_MS with equal
-    // jitter (capped/2 + random*capped/2) — de-synchronises simultaneous
-    // reconnects while guaranteeing a non-zero delay (full jitter could hit 0).
+    // Backoff delay for the given attempt (EDITOR-7861): exponential capped at
+    // MAX_RETRY_DELAY_MS with equal jitter (capped/2 + random*capped/2) —
+    // de-synchronises simultaneous reconnects while guaranteeing a non-zero delay
+    // (full jitter could hit 0).
   }, {
     key: "getReconnectionDelay",
     value: function getReconnectionDelay(attempts) {
       var exponential = SyncBlockSubscriptionManager.INITIAL_RETRY_DELAY_MS * Math.pow(SyncBlockSubscriptionManager.RETRY_BACKOFF_MULTIPLIER, attempts);
-      if (!(0, _platformFeatureFlags.fg)('platform_editor_blocks_patch_3')) {
-        return exponential;
-      }
       var half = Math.min(exponential, SyncBlockSubscriptionManager.MAX_RETRY_DELAY_MS) / 2;
       return Math.round(half + Math.random() * half);
     }
@@ -141,7 +131,7 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
           (0, _monitoring.logException)(error, {
             location: 'editor-synced-block-provider/syncBlockSubscriptionManager/notifySubscriptionChangeListeners'
           });
-          (_this3$deps$getFireAn = _this3.deps.getFireAnalyticsEvent()) === null || _this3$deps$getFireAn === void 0 || _this3$deps$getFireAn((0, _errorHandling.fetchErrorPayload)(error.message, undefined, undefined, (0, _errorHandling.buildFetchErrorAttribution)((0, _platformFeatureFlags.fg)('platform_editor_blocks_patch_3'), error.message)));
+          (_this3$deps$getFireAn = _this3.deps.getFireAnalyticsEvent()) === null || _this3$deps$getFireAn === void 0 || _this3$deps$getFireAn((0, _errorHandling.fetchErrorPayload)(error.message, undefined, undefined, (0, _errorHandling.buildFetchErrorAttribution)(error.message)));
         }
       });
     }
@@ -166,16 +156,7 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
       // This handles the case where a block is moved - the old component unmounts
       // (scheduling deletion) but the new component mounts and subscribes before
       // the deletion timeout fires.
-      //
-      // Under the flag, cache deletion is owned by the store manager.
-      // With the flag off, the legacy 1s timer path is preserved.
-      var pendingDeletion = this.pendingCacheDeletions.get(resourceId);
-      if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_14')) {
-        this.deps.cancelPendingCacheDeletion(resourceId);
-      } else if (pendingDeletion) {
-        clearTimeout(pendingDeletion);
-        this.pendingCacheDeletions.delete(resourceId);
-      }
+      this.deps.cancelPendingCacheDeletion(resourceId);
 
       // add to subscriptions map
       var resourceSubscriptions = this.subscriptions.get(resourceId) || {};
@@ -216,30 +197,9 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
             // Notify listeners that subscription was removed
             _this4.notifySubscriptionChangeListeners();
 
-            // Under the flag, delegate cache deletion to the store manager
+            // Delegate cache deletion to the store manager
             // which uses a 30s grace period with guard re-checks.
-            if ((0, _platformFeatureFlags.fg)('platform_synced_block_patch_14')) {
-              _this4.deps.scheduleCacheDeletion(resourceId);
-            } else {
-              // Legacy path (unchanged): delay cache deletion to handle
-              // block moves (unmount/remount). When a block is moved, the
-              // old component unmounts before the new one mounts. By
-              // delaying deletion, we give the new component time to
-              // subscribe and cancel this pending deletion, preserving
-              // the cached data.
-              // TODO: EDITOR-4152 - Rework this logic (superseded by
-              // `platform_synced_block_patch_14`).
-              var deletionTimeout = setTimeout(function () {
-                var hasSubscribers = _this4.subscriptions.has(resourceId);
-
-                // Only delete if still no subscribers (wasn't re-subscribed)
-                if (!hasSubscribers) {
-                  _this4.deps.deleteFromCache(resourceId);
-                }
-                _this4.pendingCacheDeletions.delete(resourceId);
-              }, 1000);
-              _this4.pendingCacheDeletions.set(resourceId, deletionTimeout);
-            }
+            _this4.deps.scheduleCacheDeletion(resourceId);
           } else {
             _this4.subscriptions.set(resourceId, resourceSubscriptions);
           }
@@ -322,17 +282,10 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
         (0, _monitoring.logException)(error, {
           location: 'editor-synced-block-provider/syncBlockSubscriptionManager/graphql-subscription'
         });
-        // EDITOR-7861: a single socket drop is usually transient and
-        // recovers on reconnect, so under the gate we don't fire a
-        // user-facing error here — it's only surfaced on exhaustion (see
-        // scheduleReconnection). Gate OFF keeps the legacy fire-on-drop.
-        // This branch only runs when the gate is OFF, so buildFetchErrorAttribution
-        // would return undefined; the structured attribution (EDITOR-7862) is therefore
-        // applied at the gate-ON exhaustion site in scheduleReconnection instead.
-        if (!(0, _platformFeatureFlags.fg)('platform_editor_blocks_patch_3')) {
-          var _this6$deps$getFireAn;
-          (_this6$deps$getFireAn = _this6.deps.getFireAnalyticsEvent()) === null || _this6$deps$getFireAn === void 0 || _this6$deps$getFireAn((0, _errorHandling.fetchErrorPayload)(error.message, resourceId, (0, _utils.getSourceProductFromResourceIdSafe)(resourceId)));
-        }
+        // EDITOR-7861: a single socket drop is usually transient and recovers
+        // on reconnect, so we don't fire a user-facing error here — it's only
+        // surfaced on exhaustion, where the structured attribution
+        // (EDITOR-7862) is applied too. See scheduleReconnection.
         _this6.handleSubscriptionTerminated(resourceId);
       }, function () {
         _this6.handleSubscriptionTerminated(resourceId);
@@ -375,24 +328,23 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
       if (attempts >= maxAttempts) {
         var _this$deps$getFireAna2;
         // Exhausted all attempts — the only place a WS drop surfaces as a
-        // fetch error under the gate (EDITOR-7861).
+        // fetch error (EDITOR-7861).
         var errorMessage = "Subscription reconnection failed after ".concat(attempts, " attempts");
 
         // Tab hidden at exhaustion: don't surface a terminal failure (user isn't
         // looking, and most exhaustions self-recover once foregrounded). Park + re-arm
         // on wake, emitting a benign `deferred` signal so suppression stays auditable.
-        var shouldDefer = (0, _platformFeatureFlags.fg)('platform_editor_blocks_patch_3') && this.isDocumentHidden();
-        if (shouldDefer) {
+        if (this.isDocumentHidden()) {
           var _this$deps$getFireAna;
           this.deferredExhausted.add(resourceId);
           this.registerWakeListeners();
-          (_this$deps$getFireAna = this.deps.getFireAnalyticsEvent()) === null || _this$deps$getFireAna === void 0 || _this$deps$getFireAna((0, _errorHandling.fetchErrorPayload)(errorMessage, resourceId, (0, _utils.getSourceProductFromResourceIdSafe)(resourceId), (0, _errorHandling.buildFetchErrorAttribution)(true, errorMessage, undefined, /* deferred */true)));
+          (_this$deps$getFireAna = this.deps.getFireAnalyticsEvent()) === null || _this$deps$getFireAna === void 0 || _this$deps$getFireAna((0, _errorHandling.fetchErrorPayload)(errorMessage, resourceId, (0, _utils.getSourceProductFromResourceIdSafe)(resourceId), (0, _errorHandling.buildFetchErrorAttribution)(errorMessage, undefined, /* deferred */true)));
           return;
         }
         (0, _monitoring.logException)(new Error(errorMessage), {
           location: 'editor-synced-block-provider/syncBlockSubscriptionManager/max-retries-exhausted'
         });
-        (_this$deps$getFireAna2 = this.deps.getFireAnalyticsEvent()) === null || _this$deps$getFireAna2 === void 0 || _this$deps$getFireAna2((0, _errorHandling.fetchErrorPayload)(errorMessage, resourceId, (0, _utils.getSourceProductFromResourceIdSafe)(resourceId), (0, _errorHandling.buildFetchErrorAttribution)((0, _platformFeatureFlags.fg)('platform_editor_blocks_patch_3'), errorMessage)));
+        (_this$deps$getFireAna2 = this.deps.getFireAnalyticsEvent()) === null || _this$deps$getFireAna2 === void 0 || _this$deps$getFireAna2((0, _errorHandling.fetchErrorPayload)(errorMessage, resourceId, (0, _utils.getSourceProductFromResourceIdSafe)(resourceId), (0, _errorHandling.buildFetchErrorAttribution)(errorMessage)));
         return;
       }
       var delay = this.getReconnectionDelay(attempts);
@@ -613,21 +565,6 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
       this.titleSubscriptions.clear();
       this.subscriptionChangeListeners.clear();
       this.useRealTimeSubscriptions = false;
-
-      // Clear any pending cache deletions
-      var _iterator5 = _createForOfIteratorHelper(this.pendingCacheDeletions.values()),
-        _step5;
-      try {
-        for (_iterator5.s(); !(_step5 = _iterator5.n()).done;) {
-          var timeout = _step5.value;
-          clearTimeout(timeout);
-        }
-      } catch (err) {
-        _iterator5.e(err);
-      } finally {
-        _iterator5.f();
-      }
-      this.pendingCacheDeletions.clear();
     }
   }, {
     key: "shouldUseRealTime",
@@ -667,7 +604,7 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
         // Prefer the structured `type` (a `SyncBlockError` enum value) for classification
         // and fall back to the free-text `reason` so source-state/permission strings are
         // still bucketed (EDITOR-7862). The emitted free-text `error` attribute is unchanged.
-        (_this$deps$getFireAna3 = this.deps.getFireAnalyticsEvent()) === null || _this$deps$getFireAna3 === void 0 || _this$deps$getFireAna3((0, _errorHandling.fetchErrorPayload)(errorMessage, syncBlockInstance.resourceId, (_syncBlockInstance$da3 = (_syncBlockInstance$da4 = syncBlockInstance.data) === null || _syncBlockInstance$da4 === void 0 ? void 0 : _syncBlockInstance$da4.product) !== null && _syncBlockInstance$da3 !== void 0 ? _syncBlockInstance$da3 : (0, _utils.getSourceProductFromResourceIdSafe)(syncBlockInstance.resourceId), (0, _errorHandling.buildFetchErrorAttribution)((0, _platformFeatureFlags.fg)('platform_editor_blocks_patch_3'), ((_syncBlockInstance$er3 = syncBlockInstance.error) === null || _syncBlockInstance$er3 === void 0 ? void 0 : _syncBlockInstance$er3.type) || ((_syncBlockInstance$er4 = syncBlockInstance.error) === null || _syncBlockInstance$er4 === void 0 ? void 0 : _syncBlockInstance$er4.reason), (_syncBlockInstance$er5 = syncBlockInstance.error) === null || _syncBlockInstance$er5 === void 0 ? void 0 : _syncBlockInstance$er5.statusCode)));
+        (_this$deps$getFireAna3 = this.deps.getFireAnalyticsEvent()) === null || _this$deps$getFireAna3 === void 0 || _this$deps$getFireAna3((0, _errorHandling.fetchErrorPayload)(errorMessage, syncBlockInstance.resourceId, (_syncBlockInstance$da3 = (_syncBlockInstance$da4 = syncBlockInstance.data) === null || _syncBlockInstance$da4 === void 0 ? void 0 : _syncBlockInstance$da4.product) !== null && _syncBlockInstance$da3 !== void 0 ? _syncBlockInstance$da3 : (0, _utils.getSourceProductFromResourceIdSafe)(syncBlockInstance.resourceId), (0, _errorHandling.buildFetchErrorAttribution)(((_syncBlockInstance$er3 = syncBlockInstance.error) === null || _syncBlockInstance$er3 === void 0 ? void 0 : _syncBlockInstance$er3.type) || ((_syncBlockInstance$er4 = syncBlockInstance.error) === null || _syncBlockInstance$er4 === void 0 ? void 0 : _syncBlockInstance$er4.reason), (_syncBlockInstance$er5 = syncBlockInstance.error) === null || _syncBlockInstance$er5 === void 0 ? void 0 : _syncBlockInstance$er5.statusCode)));
       }
     }
   }]);
@@ -675,10 +612,8 @@ var SyncBlockSubscriptionManager = exports.SyncBlockSubscriptionManager = /*#__P
 // Reconnection with exponential backoff.
 (0, _defineProperty2.default)(SyncBlockSubscriptionManager, "INITIAL_RETRY_DELAY_MS", 1000);
 (0, _defineProperty2.default)(SyncBlockSubscriptionManager, "RETRY_BACKOFF_MULTIPLIER", 2);
-(0, _defineProperty2.default)(SyncBlockSubscriptionManager, "MAX_RETRY_ATTEMPTS", 5);
-// legacy (gate OFF)
 (0, _defineProperty2.default)(SyncBlockSubscriptionManager, "MAX_RETRY_ATTEMPTS_HARDENED", 8);
-// gate ON (EDITOR-7861)
+// EDITOR-7861
 (0, _defineProperty2.default)(SyncBlockSubscriptionManager, "MAX_RETRY_DELAY_MS", 30000);
 // Coalesce wake-event bursts into one re-arm sweep to avoid a reconnection storm.
 (0, _defineProperty2.default)(SyncBlockSubscriptionManager, "WAKE_DEBOUNCE_MS", 1000);

package/dist/cjs/utils/errorHandling.js

@@ -70,17 +70,9 @@ var classifyErrorReason = exports.classifyErrorReason = function classifyErrorRe
 
 /**
  * Builds the {@link ErrorAttributionAttributes} for a failed synced-block operation from
- * the raw result `error` field and optional backend `statusCode`. Returns `undefined`
- * when the `platform_editor_blocks_patch_3` gate is OFF, so the new `reason`/`statusCode`
- * attributes are only emitted once the gate is rolled out (EDITOR-7796).
- *
- * `gateEnabled` is injected by the caller (the store managers evaluate `fg(...)`) so this
- * helper stays pure and trivially unit-testable for both gate states.
+ * the raw result `error` field and optional backend `statusCode` (EDITOR-7796).
  */
-var buildErrorAttribution = exports.buildErrorAttribution = function buildErrorAttribution(gateEnabled, error, statusCode) {
-  if (!gateEnabled) {
-    return undefined;
-  }
+var buildErrorAttribution = exports.buildErrorAttribution = function buildErrorAttribution(error, statusCode) {
   return _objectSpread({
     reason: classifyErrorReason(error)
   }, statusCode !== undefined && {
@@ -195,17 +187,10 @@ var classifyFetchErrorReason = exports.classifyFetchErrorReason = function class
 /**
  * Builds the {@link FetchErrorAttributionAttributes} for a failed fetch/subscribe
  * synced-block operation from the raw `error` field and optional backend `statusCode`.
- * Returns `undefined` when the `platform_editor_blocks_patch_3` gate is OFF, so the new
- * `reason`/`statusCode`/`benign` attributes are only emitted once the gate is rolled out
- * (EDITOR-7862). The existing free-text `error` attribute is always left unchanged.
- *
- * `gateEnabled` is injected by the caller (the store managers evaluate `fg(...)`) so this
- * helper stays pure and trivially unit-testable for both gate states.
+ * Emits the `reason`/`statusCode`/`benign` attributes (EDITOR-7862). The existing
+ * free-text `error` attribute is always left unchanged.
  */
-var buildFetchErrorAttribution = exports.buildFetchErrorAttribution = function buildFetchErrorAttribution(gateEnabled, error, statusCode, deferred) {
-  if (!gateEnabled) {
-    return undefined;
-  }
+var buildFetchErrorAttribution = exports.buildFetchErrorAttribution = function buildFetchErrorAttribution(error, statusCode, deferred) {
   var reason = classifyFetchErrorReason(error);
   return _objectSpread(_objectSpread({
     reason: reason,
@@ -262,8 +247,8 @@ function getErrorPayload(actionSubjectId, error, resourceId, sourceProduct, attr
 var fetchErrorPayload = exports.fetchErrorPayload = function fetchErrorPayload(error, resourceId, sourceProduct, attribution) {
   return (
     // Branch on attribution presence so each call resolves to a concrete overload: with
-    // attribution it hits the fetch overload (wider `reason`); without it (gate OFF) it
-    // hits the no-attribution overload. Both produce a fetch event regardless.
+    // attribution it hits the fetch overload (wider `reason`); without it, the
+    // no-attribution overload. Both produce a fetch event regardless.
     attribution ? getErrorPayload(_analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_FETCH, error, resourceId, sourceProduct, attribution) : getErrorPayload(_analytics.ACTION_SUBJECT_ID.SYNCED_BLOCK_FETCH, error, resourceId, sourceProduct)
   );
 };
@@ -287,8 +272,7 @@ var updateCacheErrorPayload = exports.updateCacheErrorPayload = function updateC
 };
 /**
  * Payload for `SYNCED_BLOCK_SOURCE_INFO_ORPHANED`. Fired when source-info
- * resolves into a cache that has already been deleted — should be unreachable
- * under `platform_synced_block_patch_14`.
+ * resolves into a cache that has already been deleted — should be unreachable.
  */
 var sourceInfoOrphanedPayload = exports.sourceInfoOrphanedPayload = function sourceInfoOrphanedPayload(resourceId, sourceProduct, context) {
   return {
@@ -363,14 +347,13 @@ var createSuccessPayload = exports.createSuccessPayload = function createSuccess
 
 /**
  * Optional enrichment for the `syncedBlockCreate` success event. All fields
- * optional so gate-off/legacy payloads are unchanged. `inputMethod`: creating
+ * optional so legacy payloads are unchanged. `inputMethod`: creating
  * surface (enum, PII-safe). `createdEmpty`: true from an empty selection, false
  * when content was converted.
  */
 
 /**
- * Operational `syncedBlockCreate` success event, behind
- * `platform_editor_blocks_patch_4`, with the `blockInstanceId` join key and,
+ * Operational `syncedBlockCreate` success event with the `blockInstanceId` join key and,
  * when available, the `inputMethod` + `createdEmpty` creation-type signals.
  */
 var createSuccessOperationalPayload = exports.createSuccessOperationalPayload = function createSuccessOperationalPayload(resourceId, blockInstanceId, sourceProduct, enrichment) {
@@ -394,8 +377,7 @@ var createSuccessOperationalPayload = exports.createSuccessOperationalPayload =
 };
 
 /**
- * Operational first-content-added event, behind
- * `platform_editor_blocks_patch_4`. Fired once when a block created empty first
+ * Operational first-content-added event. Fired once when a block created empty first
  * gains user content. Join keys only (`resourceId` + `blockInstanceId`), no user
  * content (PII-safe).
  */
@@ -431,9 +413,8 @@ var updateSuccessPayload = exports.updateSuccessPayload = function updateSuccess
 };
 
 /**
- * Optional enrichment for the `syncedBlockDelete` success event behind
- * `platform_editor_blocks_patch_4`. All fields optional so the gate-off payload
- * is unchanged; `blockInstanceId` is the bare-uuid join key.
+ * Optional enrichment for the `syncedBlockDelete` success event. All fields are
+ * optional for extensibility; `blockInstanceId` is the bare-uuid join key.
  */
 
 var deleteSuccessPayload = exports.deleteSuccessPayload = function deleteSuccessPayload(resourceId, sourceProduct, enrichment) {

package/dist/es2019/common/types.js

@@ -40,14 +40,13 @@ export let SyncBlockError = /*#__PURE__*/function (SyncBlockError) {
  * asynchronously and `destroy()` nulls it on orphaned managers, so queued/
  * in-flight ops throw `Data provider not set` — previously mis-logged as a real
  * error. These let throw and catch sites agree on one non-string-matched signal
- * so the residual false errors are suppressed. Gated by
- * `platform_editor_blocks_patch_3`.
+ * so the residual false errors are suppressed.
  *
  * NB: these intentionally live here rather than in a dedicated module to avoid
  * adding a downstream file to consuming Jira packages' Thunderstone complexity.
  */
 
-/** Legacy message — kept identical for gate-off and historical events. */
+/** Legacy message — kept identical for historical events. */
 export const PROVIDER_NOT_READY_MESSAGE = 'Data provider not set';
 
 /**

package/dist/es2019/hooks/useFetchSyncBlockData.js

@@ -32,10 +32,10 @@ export const useFetchSyncBlockData = (manager, resourceId, localId, fireAnalytic
   // On Jira the data provider is wired asynchronously, so the manager can be
   // constructed with `dataProvider === undefined`. Fetching/subscribing in that
   // window throws `Data provider not set`, logged as a false fetch error
-  // (EDITOR-7860). Gate on readiness; once the provider resolves a new manager
+  // (EDITOR-7860). Check readiness; once the provider resolves a new manager
   // instance is created so `referenceManager` changes identity and the effect
   // below re-runs, subscribing exactly once.
-  const isDataProviderReady = fg('platform_editor_blocks_patch_3') ? (_manager$referenceMan2 = (_manager$referenceMan3 = (_manager$referenceMan4 = manager.referenceManager).hasDataProvider) === null || _manager$referenceMan3 === void 0 ? void 0 : _manager$referenceMan3.call(_manager$referenceMan4)) !== null && _manager$referenceMan2 !== void 0 ? _manager$referenceMan2 : false : true;
+  const isDataProviderReady = (_manager$referenceMan2 = (_manager$referenceMan3 = (_manager$referenceMan4 = manager.referenceManager).hasDataProvider) === null || _manager$referenceMan3 === void 0 ? void 0 : _manager$referenceMan3.call(_manager$referenceMan4)) !== null && _manager$referenceMan2 !== void 0 ? _manager$referenceMan2 : false;
   const reloadData = useCallback(async () => {
     if (isLoading) {
       return;
@@ -61,8 +61,7 @@ export const useFetchSyncBlockData = (manager, resourceId, localId, fireAnalytic
       // EDITOR-7860: benign not-ready throw — emit no error and stay loading
       // so it resolves on retry once the provider is wired. Checked before
       // `logException` so the benign case produces no exception-tracker noise.
-      // Gate-off behaviour is unchanged.
-      if (isProviderNotReadyError(error) && fg('platform_editor_blocks_patch_3')) {
+      if (isProviderNotReadyError(error)) {
         setFetchState(prev => ({
           ...prev,
           isLoading: true
@@ -72,7 +71,7 @@ export const useFetchSyncBlockData = (manager, resourceId, localId, fireAnalytic
       logException(error, {
         location: 'editor-synced-block-provider/useFetchSyncBlockData'
       });
-      fireAnalyticsEvent === null || fireAnalyticsEvent === void 0 ? void 0 : fireAnalyticsEvent(fetchErrorPayload(error.message, resourceId, getSourceProductFromResourceIdSafe(resourceId), buildFetchErrorAttribution(fg('platform_editor_blocks_patch_3'), error.message)));
+      fireAnalyticsEvent === null || fireAnalyticsEvent === void 0 ? void 0 : fireAnalyticsEvent(fetchErrorPayload(error.message, resourceId, getSourceProductFromResourceIdSafe(resourceId), buildFetchErrorAttribution(error.message)));
 
       // Thread the PII-safe original message/name so the renderer can de-opaque
       // this otherwise-bare `errored` failure. `originalMessage` carries the

package/dist/es2019/store-manager/referenceSyncBlockStoreManager.js

@@ -1,7 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import isEqual from 'lodash/isEqual';
 import { logException } from '@atlaskit/editor-common/monitoring';
-import { fg } from '@atlaskit/platform-feature-flags';
 import { isProviderNotReadyError, ProviderNotReadyError, SyncBlockError } from '../common/types';
 import { buildErrorAttribution, buildFetchErrorAttribution, cacheDeletionForcedPayload, fetchErrorPayload, fetchSuccessPayload, getSourceInfoErrorPayload, sourceInfoOrphanedPayload, updateReferenceErrorPayload } from '../utils/errorHandling';
 import { getFetchExperience, getFetchSourceInfoExperience, getSaveReferenceExperience } from '../utils/experienceTracking';
@@ -16,7 +15,7 @@ const ENTITY_NOT_FOUND_MAX_RETRIES = 3;
 const ENTITY_NOT_FOUND_INITIAL_DELAY_MS = 2000;
 
 // Grace period before a cache entry is removed after the last subscriber
-// unsubscribes (gated by `platform_synced_block_patch_14`). Guards are
+// unsubscribes. Guards are
 // re-checked at fire time; if any are positive, the timer is rescheduled.
 const CACHE_DELETION_GRACE_PERIOD_MS = 30_000;
 // Max reschedules before force-deleting with an analytics event (~5 min).
@@ -43,8 +42,7 @@ export class ReferenceSyncBlockStoreManager {
     // Track retry attempts for EntityNotFound errors (block may be in the process of being created)
     _defineProperty(this, "entityNotFoundRetryCount", new Map());
     _defineProperty(this, "entityNotFoundRetryTimers", new Map());
-    // Pending cache deletion timers keyed by resourceId (gated by
-    // `platform_synced_block_patch_14`). Cancelled when a subscriber re-attaches.
+    // Pending cache deletion timers keyed by resourceId. Cancelled when a subscriber re-attaches.
     _defineProperty(this, "pendingCacheDeletions", new Map());
     // Reschedule counter per resource — reset on actual deletion or re-subscribe.
     _defineProperty(this, "cacheDeletionRescheduleCounts", new Map());
@@ -59,7 +57,6 @@ export class ReferenceSyncBlockStoreManager {
       getDataProvider: () => this.dataProvider,
       getFromCache: rid => this.getFromCache(rid),
       updateCache: inst => this.updateCache(inst),
-      deleteFromCache: rid => this.deleteFromCache(rid),
       debouncedBatchedFetchSyncBlocks: rid => this.debouncedBatchedFetchSyncBlocks(rid),
       fetchSyncBlockSourceInfo: rid => this.fetchSyncBlockSourceInfo(rid),
       getFireAnalyticsEvent: () => this.fireAnalyticsEvent,
@@ -67,7 +64,7 @@ export class ReferenceSyncBlockStoreManager {
         this.isCacheDirty = true;
       },
       // Delegate cache lifecycle to the store manager so guards can be
-      // checked atomically (gated by `platform_synced_block_patch_14`).
+      // checked atomically.
       scheduleCacheDeletion: rid => this.scheduleCacheDeletion(rid),
       cancelPendingCacheDeletion: rid => this.cancelPendingCacheDeletion(rid)
     });
@@ -426,11 +423,8 @@ export class ReferenceSyncBlockStoreManager {
     }
     if (!this.dataProvider) {
       // EDITOR-7860: tag the throw so catch sites can suppress the benign
-      // not-ready/torn-down case. Gate-off keeps the legacy throw + message.
-      if (fg('platform_editor_blocks_patch_3')) {
-        throw new ProviderNotReadyError();
-      }
-      throw new Error('Data provider not set');
+      // not-ready/torn-down case.
+      throw new ProviderNotReadyError();
     }
     nodesToFetch.forEach(node => {
       this.syncBlockFetchDataRequests.set(node.attrs.resourceId, true);
@@ -477,7 +471,7 @@ export class ReferenceSyncBlockStoreManager {
         // No resourceId means we cannot derive a sourceProduct here; intentionally omit.
         // Classify on the structured `type` first, falling back to the free-text
         // `reason`/payload (EDITOR-7862).
-        (_this$fireAnalyticsEv8 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv8 === void 0 ? void 0 : _this$fireAnalyticsEv8.call(this, fetchErrorPayload(payload, undefined, undefined, buildFetchErrorAttribution(fg('platform_editor_blocks_patch_3'), ((_syncBlockInstance$er3 = syncBlockInstance.error) === null || _syncBlockInstance$er3 === void 0 ? void 0 : _syncBlockInstance$er3.type) || ((_syncBlockInstance$er4 = syncBlockInstance.error) === null || _syncBlockInstance$er4 === void 0 ? void 0 : _syncBlockInstance$er4.reason) || payload, (_syncBlockInstance$er5 = syncBlockInstance.error) === null || _syncBlockInstance$er5 === void 0 ? void 0 : _syncBlockInstance$er5.statusCode)));
+        (_this$fireAnalyticsEv8 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv8 === void 0 ? void 0 : _this$fireAnalyticsEv8.call(this, fetchErrorPayload(payload, undefined, undefined, buildFetchErrorAttribution(((_syncBlockInstance$er3 = syncBlockInstance.error) === null || _syncBlockInstance$er3 === void 0 ? void 0 : _syncBlockInstance$er3.type) || ((_syncBlockInstance$er4 = syncBlockInstance.error) === null || _syncBlockInstance$er4 === void 0 ? void 0 : _syncBlockInstance$er4.reason) || payload, (_syncBlockInstance$er5 = syncBlockInstance.error) === null || _syncBlockInstance$er5 === void 0 ? void 0 : _syncBlockInstance$er5.statusCode)));
         return;
       }
       const existingSyncBlock = this.getFromCache(syncBlockInstance.resourceId);
@@ -508,13 +502,13 @@ export class ReferenceSyncBlockStoreManager {
         var _this$entityNotFoundR;
         // Skip error analytics when EntityNotFound will be retried, to avoid
         // inflating error-rate metrics with expected transient failures
-        const isRetryingEntityNotFound = syncBlockInstance.error.type === SyncBlockError.EntityNotFound && ((_this$entityNotFoundR = this.entityNotFoundRetryCount.get(syncBlockInstance.resourceId)) !== null && _this$entityNotFoundR !== void 0 ? _this$entityNotFoundR : 0) < ENTITY_NOT_FOUND_MAX_RETRIES && fg('platform_synced_block_patch_13');
+        const isRetryingEntityNotFound = syncBlockInstance.error.type === SyncBlockError.EntityNotFound && ((_this$entityNotFoundR = this.entityNotFoundRetryCount.get(syncBlockInstance.resourceId)) !== null && _this$entityNotFoundR !== void 0 ? _this$entityNotFoundR : 0) < ENTITY_NOT_FOUND_MAX_RETRIES;
         if (!isRetryingEntityNotFound) {
           var _this$fireAnalyticsEv9, _syncBlockInstance$da, _syncBlockInstance$da2;
           // Classify on the structured `type` (a `SyncBlockError` enum value) first,
           // falling back to the free-text `reason` so source-state/permission strings
           // are still bucketed (EDITOR-7862). The emitted `error` attribute is unchanged.
-          (_this$fireAnalyticsEv9 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv9 === void 0 ? void 0 : _this$fireAnalyticsEv9.call(this, fetchErrorPayload(syncBlockInstance.error.reason || syncBlockInstance.error.type, syncBlockInstance.resourceId, (_syncBlockInstance$da = (_syncBlockInstance$da2 = syncBlockInstance.data) === null || _syncBlockInstance$da2 === void 0 ? void 0 : _syncBlockInstance$da2.product) !== null && _syncBlockInstance$da !== void 0 ? _syncBlockInstance$da : getSourceProductFromResourceIdSafe(syncBlockInstance.resourceId), buildFetchErrorAttribution(fg('platform_editor_blocks_patch_3'), syncBlockInstance.error.type || syncBlockInstance.error.reason, syncBlockInstance.error.statusCode)));
+          (_this$fireAnalyticsEv9 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv9 === void 0 ? void 0 : _this$fireAnalyticsEv9.call(this, fetchErrorPayload(syncBlockInstance.error.reason || syncBlockInstance.error.type, syncBlockInstance.resourceId, (_syncBlockInstance$da = (_syncBlockInstance$da2 = syncBlockInstance.data) === null || _syncBlockInstance$da2 === void 0 ? void 0 : _syncBlockInstance$da2.product) !== null && _syncBlockInstance$da !== void 0 ? _syncBlockInstance$da : getSourceProductFromResourceIdSafe(syncBlockInstance.resourceId), buildFetchErrorAttribution(syncBlockInstance.error.type || syncBlockInstance.error.reason, syncBlockInstance.error.statusCode)));
         }
         if (syncBlockInstance.error.type === SyncBlockError.NotFound || syncBlockInstance.error.type === SyncBlockError.Forbidden) {
           hasExpectedError = true;
@@ -522,9 +516,7 @@ export class ReferenceSyncBlockStoreManager {
           // Schedule a retry for EntityNotFound — the source block may be in
           // the process of being created by a collaborator (race condition
           // between NCS propagation and Block Service createBlock call).
-          if (fg('platform_synced_block_patch_13')) {
-            this.scheduleEntityNotFoundRetry(syncBlockInstance.resourceId);
-          }
+          this.scheduleEntityNotFoundRetry(syncBlockInstance.resourceId);
           if (!isRetryingEntityNotFound) {
             hasUnexpectedError = true;
           }
@@ -550,7 +542,7 @@ export class ReferenceSyncBlockStoreManager {
     const existingSyncBlock = this.getFromCache(resourceId);
     // If the cache entry was deleted while the source-info request was
     // in flight, fire an analytics event so the race is observable.
-    if (!existingSyncBlock && fg('platform_synced_block_patch_14')) {
+    if (!existingSyncBlock) {
       var _this$fireAnalyticsEv1;
       (_this$fireAnalyticsEv1 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv1 === void 0 ? void 0 : _this$fireAnalyticsEv1.call(this, sourceInfoOrphanedPayload(resourceId, getSourceProductFromResourceIdSafe(resourceId), {
         hasPendingDeletion: this.pendingCacheDeletions.has(resourceId),
@@ -602,16 +594,14 @@ export class ReferenceSyncBlockStoreManager {
     this._providerFactoryManager.deleteFactory(resourceId);
     // Evict in-flight source-info promise and reset reschedule counter
     // so a stale resolution can't silently merge into a re-fetched entry.
-    if (fg('platform_synced_block_patch_14')) {
-      this.syncBlockSourceInfoRequests.delete(resourceId);
-      this.cacheDeletionRescheduleCounts.delete(resourceId);
-    }
+    this.syncBlockSourceInfoRequests.delete(resourceId);
+    this.cacheDeletionRescheduleCounts.delete(resourceId);
   }
 
   /**
    * Returns true if the cache entry for `resourceId` is safe to delete:
    * no active subscribers, no in-flight source-info request, and no
-   * queued/in-flight batch fetch (gated by `platform_synced_block_patch_14`).
+   * queued/in-flight batch fetch.
    */
   canDeleteCache(resourceId) {
     if (this._subscriptionManager.getSubscriptions().has(resourceId)) {
@@ -628,14 +618,11 @@ export class ReferenceSyncBlockStoreManager {
 
   /**
    * Schedules cache deletion for `resourceId` after the grace period
-   * (gated by `platform_synced_block_patch_14`). Called when the last
+   * Called when the last
    * subscriber unsubscribes. Guards are re-checked at fire time; if any
    * are positive the timer is rescheduled up to MAX_RESCHEDULES times.
    */
   scheduleCacheDeletion(resourceId) {
-    if (!fg('platform_synced_block_patch_14')) {
-      return;
-    }
     if (this.isDestroyed) {
       return;
     }
@@ -663,13 +650,10 @@ export class ReferenceSyncBlockStoreManager {
 
   /**
    * Cancels any pending cache deletion timer for `resourceId` and resets the
-   * reschedule counter (gated by `platform_synced_block_patch_14`). Called
+   * reschedule counter. Called
    * when a new subscriber arrives.
    */
   cancelPendingCacheDeletion(resourceId) {
-    if (!fg('platform_synced_block_patch_14')) {
-      return;
-    }
     const existing = this.pendingCacheDeletions.get(resourceId);
     if (existing) {
       clearTimeout(existing);
@@ -687,7 +671,7 @@ export class ReferenceSyncBlockStoreManager {
   onCacheDeletionTimerFire(resourceId) {
     var _this$cacheDeletionRe;
     if (this.canDeleteCache(resourceId)) {
-      // `deleteFromCache` resets the reschedule counter under the flag.
+      // `deleteFromCache` resets the reschedule counter.
       this.deleteFromCache(resourceId);
       return;
     }
@@ -707,7 +691,7 @@ export class ReferenceSyncBlockStoreManager {
       logException(new Error(`Cache deletion forced after ${currentCount} reschedules — stuck in-flight guard`), {
         location: 'editor-synced-block-provider/referenceSyncBlockStoreManager/cache-deletion-forced'
       });
-      // `deleteFromCache` resets the reschedule counter under the flag.
+      // `deleteFromCache` resets the reschedule counter.
       this.deleteFromCache(resourceId);
       // If subscribers still exist, kick off a fresh fetch so they get
       // fresh data on the next batch tick instead of holding stale data
@@ -804,14 +788,14 @@ export class ReferenceSyncBlockStoreManager {
       var _this$fireAnalyticsEv11;
       // EDITOR-7860: benign not-ready/torn-down case — suppress both the
       // exception-tracker log and the analytics event (checked first so the
-      // benign case stays fully silent). Gate-off behaviour is unchanged.
-      if (isProviderNotReadyError(error) && fg('platform_editor_blocks_patch_3')) {
+      // benign case stays fully silent).
+      if (isProviderNotReadyError(error)) {
         return () => {};
       }
       logException(error, {
         location: 'editor-synced-block-provider/referenceSyncBlockStoreManager'
       });
-      (_this$fireAnalyticsEv11 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv11 === void 0 ? void 0 : _this$fireAnalyticsEv11.call(this, fetchErrorPayload(error.message, undefined, undefined, buildFetchErrorAttribution(fg('platform_editor_blocks_patch_3'), error.message)));
+      (_this$fireAnalyticsEv11 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv11 === void 0 ? void 0 : _this$fireAnalyticsEv11.call(this, fetchErrorPayload(error.message, undefined, undefined, buildFetchErrorAttribution(error.message)));
       return () => {};
     }
   }
@@ -919,7 +903,7 @@ export class ReferenceSyncBlockStoreManager {
         (_this$saveExperience2 = this.saveExperience) === null || _this$saveExperience2 === void 0 ? void 0 : _this$saveExperience2.failure({
           reason: updateResult.error || 'Failed to update reference synced blocks on the document'
         });
-        (_this$fireAnalyticsEv12 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv12 === void 0 ? void 0 : _this$fireAnalyticsEv12.call(this, updateReferenceErrorPayload(updateResult.error || 'Failed to update reference synced blocks on the document', undefined, undefined, buildErrorAttribution(fg('platform_editor_blocks_patch_3'), updateResult.error, updateResult.statusCode)));
+        (_this$fireAnalyticsEv12 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv12 === void 0 ? void 0 : _this$fireAnalyticsEv12.call(this, updateReferenceErrorPayload(updateResult.error || 'Failed to update reference synced blocks on the document', undefined, undefined, buildErrorAttribution(updateResult.error, updateResult.statusCode)));
       }
     } catch (error) {
       var _this$saveExperience3, _this$fireAnalyticsEv13;
@@ -932,8 +916,8 @@ export class ReferenceSyncBlockStoreManager {
       });
       // No `resourceId` available in this catch — sourceProduct is intentionally omitted.
       // No structured SyncBlockError/status here, so the attribution `reason` falls back
-      // to `unknown` when the gate is on.
-      (_this$fireAnalyticsEv13 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv13 === void 0 ? void 0 : _this$fireAnalyticsEv13.call(this, updateReferenceErrorPayload(error.message, undefined, undefined, buildErrorAttribution(fg('platform_editor_blocks_patch_3'))));
+      // to `unknown`.
+      (_this$fireAnalyticsEv13 = this.fireAnalyticsEvent) === null || _this$fireAnalyticsEv13 === void 0 ? void 0 : _this$fireAnalyticsEv13.call(this, updateReferenceErrorPayload(error.message, undefined, undefined, buildErrorAttribution()));
     } finally {
       if (!success) {
         // set isCacheDirty back to true for cases where it failed to update the reference synced blocks on the BE
@@ -998,16 +982,8 @@ export class ReferenceSyncBlockStoreManager {
     });
     this.fireAnalyticsEvent = undefined;
 
-    // Under `platform_synced_block_patch_14`, `destroy()` is now wired to
-    // React component unmount via `useMemoizedSyncBlockStoreManager`.
-    // Clearing the module-level singleton on unmount would wipe SSR session
-    // cache data that a sibling/successor manager (e.g. the editor
-    // instance that mounts immediately after the renderer unmounts during
-    // the view-mode transition) is about to read.
-    // Let entries age out naturally instead — the in-memory cache is
-    // naturally bounded by `maxSize` (LRU) and cleared on hard navigation.
-    if (!fg('platform_synced_block_patch_14')) {
-      syncBlockInMemorySessionCache.clear();
-    }
+    // `destroy()` is wired to React component unmount via
+    // `useMemoizedSyncBlockStoreManager`. Let the in-memory session cache age
+    // out naturally instead of clearing it during a view-mode transition.
   }
 }