@atlaskit/editor-presets 5.2.3 → 6.0.0

package/CHANGELOG.md

@@ -1,5 +1,66 @@
 # @atlaskit/editor-presets
 
+## 6.0.0
+
+### Major Changes
+
+- [`2cfc0f295c39a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/2cfc0f295c39a) -
+  [ux] FG cleanup - Removes `confluence_frontend_content_wrapper` from platform (treated as
+  permanently launched / implicitly true).
+
+  ## Breaking change
+
+  The `confluence_frontend_content_wrapper` gate previously guarded a scroll-gutter tweak in
+  `basePluginOptions` that only read the `base` builder's `__livePage` field. With the gate
+  launched, that field is no longer read, so the now-dead `base` option was removed rather than left
+  as vestigial API.
+
+  For `@atlaskit/editor-presets` (published):
+  - The `base` option was removed from the public preset plugin options type
+    (`AllPublicPluginOptions.base` is now `never`).
+  - `basePluginOptions()` no longer takes an argument (was `basePluginOptions({ options })`).
+
+  This is a **type-level** breaking change only. At runtime it is a no-op: the `base` option (and
+  the `__livePage` value passed through it) was already unused once the gate was on, so removing it
+  does not change editor behaviour. It is scored `major` for `@atlaskit/editor-presets` because that
+  package is published and the type contract change will break the builds of external TypeScript
+  consumers that still pass `base`. `@atlassian/confluence-presets` is `private` (not published) and
+  receives the same code change, so it is scored `minor`.
+
+  ## Migration
+
+  Stop passing the `base` option to the preset, and call `basePluginOptions()` with no arguments:
+
+  ```diff
+   fullPagePreset({
+     intl,
+     pluginOptions: {
+  -    base: { __livePage },
+       // ...other plugin options unchanged
+     },
+   });
+  ```
+
+  ```diff
+  - basePluginOptions({ options: { __livePage } });
+  + basePluginOptions();
+  ```
+
+  Note: `__livePage` itself is not removed — it remains a valid, live field on the other plugin
+  option builders (e.g. `selection`, `selectionMarker`, `collabEdit`, `card`). Only the unused
+  `base.__livePage` passthrough is gone. All in-repo consumers have been migrated as part of this
+  PR.
+
+### Patch Changes
+
+- Updated dependencies
+
+## 5.2.4
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 5.2.3
 
 ### Patch Changes

package/dist/cjs/confluence-full-page-base/index.js

@@ -197,9 +197,7 @@ function confluenceFullPageBasePreset(props) {
   })]).add(_editorPluginClipboard.clipboardPlugin).add(_editorPluginFocus.focusPlugin).add(_editorPluginComposition.compositionPlugin).add([_editorPluginContextIdentifier.contextIdentifierPlugin, (0, _contextIdentifierPluginOptions.contextIdentifierPluginOptions)({
     options: pluginOptions.contextIdentifier,
     providers: providers
-  })]).add([_editorPluginBase.basePlugin, (0, _basePluginOptions.basePluginOptions)({
-    options: pluginOptions.base
-  })]).maybeAdd([_editorPluginUserPreferences.userPreferencesPlugin, (0, _userPreferencesPluginOptions.userPreferencesPluginOptions)({
+  })]).add([_editorPluginBase.basePlugin, (0, _basePluginOptions.basePluginOptions)()]).maybeAdd([_editorPluginUserPreferences.userPreferencesPlugin, (0, _userPreferencesPluginOptions.userPreferencesPluginOptions)({
     providers: providers,
     options: pluginOptions.userPreferencesPlugin
   })], enabledOptionalPlugins.userPreferences).add(_editorPluginDecorations.decorationsPlugin).add([_editorPluginTypeAhead.typeAheadPlugin, (0, _typeAheadPluginOptions.typeAheadPluginOptions)({

package/dist/cjs/confluence-full-page-base/pluginOptions/basePluginOptions.js

@@ -4,13 +4,10 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.basePluginOptions = basePluginOptions;
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
-function basePluginOptions(_ref) {
-  var options = _ref.options;
-  var removeScrollGutter = !(0, _platformFeatureFlags.fg)('confluence_frontend_content_wrapper') && options.__livePage;
+function basePluginOptions() {
   return {
     allowInlineCursorTarget: true,
-    allowScrollGutter: removeScrollGutter ? undefined : {
+    allowScrollGutter: {
       getScrollElement: function getScrollElement() {
         return document.querySelector('.fabric-editor-popup-scroll-parent');
       }

package/dist/cjs/confluence-full-page-base/pluginOptions/contextPanelPluginOptions.js

@@ -13,8 +13,7 @@ function contextPanelPluginOptions(_ref) {
   return (
     // SECTION: From confluence/next/packages/editor-presets/src/full-page/useFullPageEditorPreset.ts
     // If object-sidebar is not enabled, then we don't need to pass the contextPanelOptions
-    // eslint-disable-next-line @atlaskit/platform/no-preconditioning
-    (0, _platformFeatureFlags.fg)('confluence_frontend_content_wrapper') && (0, _platformFeatureFlags.fg)('platform_editor_ai_object_sidebar_injection') ? {
+    (0, _platformFeatureFlags.fg)('platform_editor_ai_object_sidebar_injection') ? {
       objectSideBar: options.objectSideBar
     } : undefined
     // END SECTION

package/dist/cjs/confluence-full-page-base/pluginOptions/loomPluginOptions.js

@@ -4,13 +4,12 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.loomPluginOptions = loomPluginOptions;
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 function loomPluginOptions(_ref) {
   var options = _ref.options;
   return {
     // SECTION: From confluence/next/packages/loom-editor-utils/src/hooks/useLoomPluginOptions.tsx
     renderButton: options.renderButton,
-    shouldShowToolbarButton: (0, _platformFeatureFlags.fg)('confluence_frontend_content_wrapper') ? false : undefined
+    shouldShowToolbarButton: false
     // END SECTION
   };
 }

package/dist/es2019/confluence-full-page-base/index.js

@@ -193,9 +193,7 @@ export function confluenceFullPageBasePreset(props) {
   })]).add(clipboardPlugin).add(focusPlugin).add(compositionPlugin).add([contextIdentifierPlugin, contextIdentifierPluginOptions({
     options: pluginOptions.contextIdentifier,
     providers
-  })]).add([basePlugin, basePluginOptions({
-    options: pluginOptions.base
-  })]).maybeAdd([userPreferencesPlugin, userPreferencesPluginOptions({
+  })]).add([basePlugin, basePluginOptions()]).maybeAdd([userPreferencesPlugin, userPreferencesPluginOptions({
     providers,
     options: pluginOptions.userPreferencesPlugin
   })], enabledOptionalPlugins.userPreferences).add(decorationsPlugin).add([typeAheadPlugin, typeAheadPluginOptions({

package/dist/es2019/confluence-full-page-base/pluginOptions/basePluginOptions.js

@@ -1,11 +1,7 @@
-import { fg } from '@atlaskit/platform-feature-flags';
-export function basePluginOptions({
-  options
-}) {
-  const removeScrollGutter = !fg('confluence_frontend_content_wrapper') && options.__livePage;
+export function basePluginOptions() {
   return {
     allowInlineCursorTarget: true,
-    allowScrollGutter: removeScrollGutter ? undefined : {
+    allowScrollGutter: {
       getScrollElement: () => document.querySelector('.fabric-editor-popup-scroll-parent')
     }
   };

package/dist/es2019/confluence-full-page-base/pluginOptions/contextPanelPluginOptions.js

@@ -8,8 +8,7 @@ export function contextPanelPluginOptions({
   return (
     // SECTION: From confluence/next/packages/editor-presets/src/full-page/useFullPageEditorPreset.ts
     // If object-sidebar is not enabled, then we don't need to pass the contextPanelOptions
-    // eslint-disable-next-line @atlaskit/platform/no-preconditioning
-    fg('confluence_frontend_content_wrapper') && fg('platform_editor_ai_object_sidebar_injection') ? {
+    fg('platform_editor_ai_object_sidebar_injection') ? {
       objectSideBar: options.objectSideBar
     } : undefined
     // END SECTION

package/dist/es2019/confluence-full-page-base/pluginOptions/loomPluginOptions.js

@@ -1,11 +1,10 @@
-import { fg } from '@atlaskit/platform-feature-flags';
 export function loomPluginOptions({
   options
 }) {
   return {
     // SECTION: From confluence/next/packages/loom-editor-utils/src/hooks/useLoomPluginOptions.tsx
     renderButton: options.renderButton,
-    shouldShowToolbarButton: fg('confluence_frontend_content_wrapper') ? false : undefined
+    shouldShowToolbarButton: false
     // END SECTION
   };
 }

package/dist/esm/confluence-full-page-base/index.js

@@ -191,9 +191,7 @@ export function confluenceFullPageBasePreset(props) {
   })]).add(clipboardPlugin).add(focusPlugin).add(compositionPlugin).add([contextIdentifierPlugin, contextIdentifierPluginOptions({
     options: pluginOptions.contextIdentifier,
     providers: providers
-  })]).add([basePlugin, basePluginOptions({
-    options: pluginOptions.base
-  })]).maybeAdd([userPreferencesPlugin, userPreferencesPluginOptions({
+  })]).add([basePlugin, basePluginOptions()]).maybeAdd([userPreferencesPlugin, userPreferencesPluginOptions({
     providers: providers,
     options: pluginOptions.userPreferencesPlugin
   })], enabledOptionalPlugins.userPreferences).add(decorationsPlugin).add([typeAheadPlugin, typeAheadPluginOptions({

package/dist/esm/confluence-full-page-base/pluginOptions/basePluginOptions.js

@@ -1,10 +1,7 @@
-import { fg } from '@atlaskit/platform-feature-flags';
-export function basePluginOptions(_ref) {
-  var options = _ref.options;
-  var removeScrollGutter = !fg('confluence_frontend_content_wrapper') && options.__livePage;
+export function basePluginOptions() {
   return {
     allowInlineCursorTarget: true,
-    allowScrollGutter: removeScrollGutter ? undefined : {
+    allowScrollGutter: {
       getScrollElement: function getScrollElement() {
         return document.querySelector('.fabric-editor-popup-scroll-parent');
       }

package/dist/esm/confluence-full-page-base/pluginOptions/contextPanelPluginOptions.js

@@ -7,8 +7,7 @@ export function contextPanelPluginOptions(_ref) {
   return (
     // SECTION: From confluence/next/packages/editor-presets/src/full-page/useFullPageEditorPreset.ts
     // If object-sidebar is not enabled, then we don't need to pass the contextPanelOptions
-    // eslint-disable-next-line @atlaskit/platform/no-preconditioning
-    fg('confluence_frontend_content_wrapper') && fg('platform_editor_ai_object_sidebar_injection') ? {
+    fg('platform_editor_ai_object_sidebar_injection') ? {
       objectSideBar: options.objectSideBar
     } : undefined
     // END SECTION

package/dist/esm/confluence-full-page-base/pluginOptions/loomPluginOptions.js

@@ -1,10 +1,9 @@
-import { fg } from '@atlaskit/platform-feature-flags';
 export function loomPluginOptions(_ref) {
   var options = _ref.options;
   return {
     // SECTION: From confluence/next/packages/loom-editor-utils/src/hooks/useLoomPluginOptions.tsx
     renderButton: options.renderButton,
-    shouldShowToolbarButton: fg('confluence_frontend_content_wrapper') ? false : undefined
+    shouldShowToolbarButton: false
     // END SECTION
   };
 }

package/dist/types/confluence-full-page-base/pluginOptions/basePluginOptions.d.ts

@@ -1,8 +1,2 @@
 import type { BasePluginOptions } from '@atlaskit/editor-plugin-base';
-interface Props {
-    options: {
-        __livePage?: boolean;
-    };
-}
-export declare function basePluginOptions({ options }: Props): BasePluginOptions;
-export {};
+export declare function basePluginOptions(): BasePluginOptions;

package/dist/types/confluence-full-page-base/types.d.ts

@@ -106,7 +106,6 @@ import type { agentManagedExtensionPluginOptions } from './pluginOptions/agentMa
 import type { analyticsPluginOptions } from './pluginOptions/analyticsPluginOptions';
 import type { annotationPluginOptions } from './pluginOptions/annotationPluginOptions';
 import type { avatarGroupPluginOptions } from './pluginOptions/avatarGroupPluginOptions';
-import type { basePluginOptions } from './pluginOptions/basePluginOptions';
 import type { blockMenuPluginOptions } from './pluginOptions/blockMenuPluginOptions';
 import type { blockTypePluginOptions } from './pluginOptions/blockTypePluginOptions';
 import type { breakoutPluginOptions } from './pluginOptions/breakoutPluginOptions';
@@ -321,7 +320,7 @@ export interface AllPublicPluginOptions {
     analytics: OptionsFromPluginOptionsBuilder<typeof analyticsPluginOptions>;
     annotation: OptionsFromPluginOptionsBuilder<typeof annotationPluginOptions>;
     avatarGroup: OptionsFromPluginOptionsBuilder<typeof avatarGroupPluginOptions>;
-    base: OptionsFromPluginOptionsBuilder<typeof basePluginOptions>;
+    base: never;
     batchAttributeUpdates: never;
     betterTypeHistory: never;
     blockControls: never;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-presets",
-	"version": "5.2.3",
+	"version": "6.0.0",
 	"license": "Apache-2.0",
 	"description": "Public editor presets for Atlassian Editor containing base configurations for Confluence and other products",
 	"publishConfig": {
@@ -95,7 +95,7 @@
 		"@atlaskit/editor-plugin-selection-extension": "^15.0.0",
 		"@atlaskit/editor-plugin-selection-marker": "^12.0.0",
 		"@atlaskit/editor-plugin-selection-toolbar": "^13.0.0",
-		"@atlaskit/editor-plugin-show-diff": "^10.4.0",
+		"@atlaskit/editor-plugin-show-diff": "^10.5.0",
 		"@atlaskit/editor-plugin-status": "^13.1.0",
 		"@atlaskit/editor-plugin-submit-editor": "^12.0.0",
 		"@atlaskit/editor-plugin-synced-block": "^10.3.0",
@@ -114,14 +114,14 @@
 		"@atlaskit/editor-plugin-user-intent": "^10.0.0",
 		"@atlaskit/editor-plugin-user-preferences": "^10.0.0",
 		"@atlaskit/editor-plugin-width": "^13.0.0",
-		"@atlaskit/platform-feature-flags": "^2.0.0",
-		"@atlaskit/tmp-editor-statsig": "^129.0.0",
+		"@atlaskit/platform-feature-flags": "^2.1.0",
+		"@atlaskit/tmp-editor-statsig": "^130.2.0",
 		"@atlassian/ari": "^2.596.0",
 		"@atlassian/editor-plugin-agent-managed-extension": "^2.12.0",
 		"@babel/runtime": "^7.0.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^116.33.0",
+		"@atlaskit/editor-common": "^116.34.0",
 		"react": "^18.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"
 	},
@@ -164,9 +164,6 @@
 		"platform_editor_ai_object_sidebar_injection": {
 			"type": "boolean"
 		},
-		"confluence_frontend_content_wrapper": {
-			"type": "boolean"
-		},
 		"platform_editor_content_mode_button_mvp": {
 			"type": "boolean"
 		},