@atlaskit/editor-plugin-type-ahead 10.0.4 → 10.0.5

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/editor-plugin-type-ahead
 
+## 10.0.5
+
+### Patch Changes
+
+- [`e6835136c4227`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/e6835136c4227) -
+  [FFCLEANUP-98435] remove stale experiment `platform_editor_a11y_typeahead_tab_keypress`
+- Updated dependencies
+
 ## 10.0.4
 
 ### Patch Changes

package/dist/cjs/ui/InputQuery.js

@@ -17,7 +17,6 @@ var _ui = require("@atlaskit/editor-common/ui");
 var _utils = require("@atlaskit/editor-prosemirror/utils");
 var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
-var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _constants = require("../pm-plugins/constants");
 var _utils2 = require("../pm-plugins/utils");
@@ -211,26 +210,7 @@ var InputQuery = exports.InputQuery = /*#__PURE__*/_react.default.memo(function
         }
         break;
       case 'Tab':
-        if ((0, _expValEquals.expValEquals)('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-          event.shiftKey ? selectPreviousItem() : selectNextItem();
-          break;
-        } else {
-          if (selectedIndex === -1) {
-            /**
-             * TODO DTR-1401: (also see ED-17200) There are two options
-             * here, either
-             * - set the index directly to 1 in WrapperTypeAhead.tsx's
-             *   `insertSelectedItem` at the cost of breaking some of the a11y
-             *   focus changes,
-             * - or do this jank at the cost of some small analytics noise.
-             *
-             */
-            selectPreviousItem();
-            selectNextItem();
-          }
-          // TODO: DTR-1401 - why is this calling select item when hitting tab? fix this in DTR-1401
-          onItemSelect(_typeAhead.SelectItemMode.TAB);
-        }
+        event.shiftKey ? selectPreviousItem() : selectNextItem();
         break;
       case 'ArrowDown':
         selectNextItem();

package/dist/cjs/ui/MoreOptions.js

@@ -55,11 +55,6 @@ var MoreOptions = exports.MoreOptions = function MoreOptions(_ref) {
         onClick();
         // Prevent keydown listener in TypeaheadList from handling Enter pressed
         e.stopPropagation();
-      } else if (e.key === 'Tab' && !(0, _expValEquals.expValEquals)('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-        // TypeaheadList will try to insert selected item on Tab press
-        // hence stop propagation to prevent that and treat this as noop
-        e.stopPropagation();
-        e.preventDefault();
       }
     };
 

package/dist/cjs/ui/TypeAheadList.js

@@ -18,7 +18,6 @@ var _typeAhead = require("@atlaskit/editor-common/type-ahead");
 var _ui = require("@atlaskit/editor-common/ui");
 var _menu = require("@atlaskit/menu");
 var _compiled = require("@atlaskit/primitives/compiled");
-var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _closeTypeAhead = require("../pm-plugins/commands/close-type-ahead");
 var _updateSelectedIndex = require("../pm-plugins/commands/update-selected-index");
 var _constants = require("../pm-plugins/constants");
@@ -103,10 +102,7 @@ var TypeAheadListComponent = /*#__PURE__*/_react.default.memo(function (_ref2) {
     };
   }, [onItemClick]);
   var isNavigationKey = function isNavigationKey(event) {
-    if ((0, _expValEquals.expValEquals)('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-      return ['ArrowDown', 'ArrowUp', 'Tab', 'Enter', 'Shift'].includes(event.key);
-    }
-    return ['ArrowDown', 'ArrowUp', 'Tab', 'Enter'].includes(event.key);
+    return ['ArrowDown', 'ArrowUp', 'Tab', 'Enter', 'Shift'].includes(event.key);
   };
   var focusTargetElement = (0, _react.useCallback)(function () {
     var _decorationElement$qu;
@@ -251,13 +247,7 @@ var TypeAheadListComponent = /*#__PURE__*/_react.default.memo(function (_ref2) {
             event.stopPropagation();
             break;
           case 'Tab':
-            if ((0, _expValEquals.expValEquals)('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-              event.shiftKey ? selectPreviousItem() : selectNextItem();
-              break;
-            } else {
-              //Tab key quick inserts the selected item.
-              onItemClick(_typeAhead.SelectItemMode.TAB, selectedIndex, _analytics.INPUT_METHOD.KEYBOARD);
-            }
+            event.shiftKey ? selectPreviousItem() : selectNextItem();
             event.preventDefault();
             break;
           case 'Enter':

package/dist/es2019/ui/InputQuery.js

@@ -14,7 +14,6 @@ import { AssistiveText } from '@atlaskit/editor-common/ui';
 import { findParentNodeOfType } from '@atlaskit/editor-prosemirror/utils';
 import { blockNodesVerticalMargin } from '@atlaskit/editor-shared-styles';
 import { fg } from '@atlaskit/platform-feature-flags';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { CloseSelectionOptions, TYPE_AHEAD_DECORATION_ELEMENT_ID, TYPE_AHEAD_POPUP_CONTENT_CLASS } from '../pm-plugins/constants';
 import { getPluginState } from '../pm-plugins/utils';
@@ -195,26 +194,7 @@ export const InputQuery = /*#__PURE__*/React.memo(({
         }
         break;
       case 'Tab':
-        if (expValEquals('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-          event.shiftKey ? selectPreviousItem() : selectNextItem();
-          break;
-        } else {
-          if (selectedIndex === -1) {
-            /**
-             * TODO DTR-1401: (also see ED-17200) There are two options
-             * here, either
-             * - set the index directly to 1 in WrapperTypeAhead.tsx's
-             *   `insertSelectedItem` at the cost of breaking some of the a11y
-             *   focus changes,
-             * - or do this jank at the cost of some small analytics noise.
-             *
-             */
-            selectPreviousItem();
-            selectNextItem();
-          }
-          // TODO: DTR-1401 - why is this calling select item when hitting tab? fix this in DTR-1401
-          onItemSelect(SelectItemMode.TAB);
-        }
+        event.shiftKey ? selectPreviousItem() : selectNextItem();
         break;
       case 'ArrowDown':
         selectNextItem();

package/dist/es2019/ui/MoreOptions.js

@@ -49,11 +49,6 @@ export const MoreOptions = ({
         onClick();
         // Prevent keydown listener in TypeaheadList from handling Enter pressed
         e.stopPropagation();
-      } else if (e.key === 'Tab' && !expValEquals('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-        // TypeaheadList will try to insert selected item on Tab press
-        // hence stop propagation to prevent that and treat this as noop
-        e.stopPropagation();
-        e.preventDefault();
       }
     };
 

package/dist/es2019/ui/TypeAheadList.js

@@ -16,7 +16,6 @@ import { SelectItemMode, typeAheadListMessages } from '@atlaskit/editor-common/t
 import { AssistiveText } from '@atlaskit/editor-common/ui';
 import { MenuGroup } from '@atlaskit/menu';
 import { Text, Box } from '@atlaskit/primitives/compiled';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { closeTypeAhead } from '../pm-plugins/commands/close-type-ahead';
 import { updateSelectedIndex } from '../pm-plugins/commands/update-selected-index';
 import { TYPE_AHEAD_DECORATION_ELEMENT_ID } from '../pm-plugins/constants';
@@ -87,10 +86,7 @@ const TypeAheadListComponent = /*#__PURE__*/React.memo(({
     onItemClick
   }), [onItemClick]);
   const isNavigationKey = event => {
-    if (expValEquals('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-      return ['ArrowDown', 'ArrowUp', 'Tab', 'Enter', 'Shift'].includes(event.key);
-    }
-    return ['ArrowDown', 'ArrowUp', 'Tab', 'Enter'].includes(event.key);
+    return ['ArrowDown', 'ArrowUp', 'Tab', 'Enter', 'Shift'].includes(event.key);
   };
   const focusTargetElement = useCallback(() => {
     var _decorationElement$qu;
@@ -234,13 +230,7 @@ const TypeAheadListComponent = /*#__PURE__*/React.memo(({
             event.stopPropagation();
             break;
           case 'Tab':
-            if (expValEquals('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-              event.shiftKey ? selectPreviousItem() : selectNextItem();
-              break;
-            } else {
-              //Tab key quick inserts the selected item.
-              onItemClick(SelectItemMode.TAB, selectedIndex, INPUT_METHOD.KEYBOARD);
-            }
+            event.shiftKey ? selectPreviousItem() : selectNextItem();
             event.preventDefault();
             break;
           case 'Enter':

package/dist/esm/ui/InputQuery.js

@@ -15,7 +15,6 @@ import { AssistiveText } from '@atlaskit/editor-common/ui';
 import { findParentNodeOfType } from '@atlaskit/editor-prosemirror/utils';
 import { blockNodesVerticalMargin } from '@atlaskit/editor-shared-styles';
 import { fg } from '@atlaskit/platform-feature-flags';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { CloseSelectionOptions, TYPE_AHEAD_DECORATION_ELEMENT_ID, TYPE_AHEAD_POPUP_CONTENT_CLASS } from '../pm-plugins/constants';
 import { getPluginState } from '../pm-plugins/utils';
@@ -201,26 +200,7 @@ export var InputQuery = /*#__PURE__*/React.memo(function (_ref) {
         }
         break;
       case 'Tab':
-        if (expValEquals('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-          event.shiftKey ? selectPreviousItem() : selectNextItem();
-          break;
-        } else {
-          if (selectedIndex === -1) {
-            /**
-             * TODO DTR-1401: (also see ED-17200) There are two options
-             * here, either
-             * - set the index directly to 1 in WrapperTypeAhead.tsx's
-             *   `insertSelectedItem` at the cost of breaking some of the a11y
-             *   focus changes,
-             * - or do this jank at the cost of some small analytics noise.
-             *
-             */
-            selectPreviousItem();
-            selectNextItem();
-          }
-          // TODO: DTR-1401 - why is this calling select item when hitting tab? fix this in DTR-1401
-          onItemSelect(SelectItemMode.TAB);
-        }
+        event.shiftKey ? selectPreviousItem() : selectNextItem();
         break;
       case 'ArrowDown':
         selectNextItem();

package/dist/esm/ui/MoreOptions.js

@@ -46,11 +46,6 @@ export var MoreOptions = function MoreOptions(_ref) {
         onClick();
         // Prevent keydown listener in TypeaheadList from handling Enter pressed
         e.stopPropagation();
-      } else if (e.key === 'Tab' && !expValEquals('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-        // TypeaheadList will try to insert selected item on Tab press
-        // hence stop propagation to prevent that and treat this as noop
-        e.stopPropagation();
-        e.preventDefault();
       }
     };
 

package/dist/esm/ui/TypeAheadList.js

@@ -17,7 +17,6 @@ import { SelectItemMode, typeAheadListMessages } from '@atlaskit/editor-common/t
 import { AssistiveText } from '@atlaskit/editor-common/ui';
 import { MenuGroup } from '@atlaskit/menu';
 import { Text, Box } from '@atlaskit/primitives/compiled';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { closeTypeAhead } from '../pm-plugins/commands/close-type-ahead';
 import { updateSelectedIndex } from '../pm-plugins/commands/update-selected-index';
 import { TYPE_AHEAD_DECORATION_ELEMENT_ID } from '../pm-plugins/constants';
@@ -94,10 +93,7 @@ var TypeAheadListComponent = /*#__PURE__*/React.memo(function (_ref2) {
     };
   }, [onItemClick]);
   var isNavigationKey = function isNavigationKey(event) {
-    if (expValEquals('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-      return ['ArrowDown', 'ArrowUp', 'Tab', 'Enter', 'Shift'].includes(event.key);
-    }
-    return ['ArrowDown', 'ArrowUp', 'Tab', 'Enter'].includes(event.key);
+    return ['ArrowDown', 'ArrowUp', 'Tab', 'Enter', 'Shift'].includes(event.key);
   };
   var focusTargetElement = useCallback(function () {
     var _decorationElement$qu;
@@ -242,13 +238,7 @@ var TypeAheadListComponent = /*#__PURE__*/React.memo(function (_ref2) {
             event.stopPropagation();
             break;
           case 'Tab':
-            if (expValEquals('platform_editor_a11y_typeahead_tab_keypress', 'isEnabled', true)) {
-              event.shiftKey ? selectPreviousItem() : selectNextItem();
-              break;
-            } else {
-              //Tab key quick inserts the selected item.
-              onItemClick(SelectItemMode.TAB, selectedIndex, INPUT_METHOD.KEYBOARD);
-            }
+            event.shiftKey ? selectPreviousItem() : selectNextItem();
             event.preventDefault();
             break;
           case 'Enter':

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/editor-plugin-type-ahead",
-	"version": "10.0.4",
+	"version": "10.0.5",
 	"description": "Type-ahead plugin for @atlaskit/editor-core",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -44,7 +44,7 @@
 		"@atlaskit/primitives": "^19.0.0",
 		"@atlaskit/prosemirror-history": "^0.2.0",
 		"@atlaskit/prosemirror-input-rules": "^3.6.0",
-		"@atlaskit/tmp-editor-statsig": "^66.0.0",
+		"@atlaskit/tmp-editor-statsig": "^67.0.0",
 		"@atlaskit/tokens": "^13.0.0",
 		"@atlaskit/visually-hidden": "^3.0.0",
 		"@babel/runtime": "^7.0.0",
@@ -56,7 +56,7 @@
 		"w3c-keyname": "^2.1.8"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^114.7.0",
+		"@atlaskit/editor-common": "^114.8.0",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0",
 		"react-intl": "^5.25.1 || ^6.0.0 || ^7.0.0"